Re: [PATCH] D20498: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr

2016-06-21 Thread Tim Shen via cfe-commits
timshen added a comment. http://reviews.llvm.org/D21243 is committed. Let's do this again. Repository: rL LLVM http://reviews.llvm.org/D20498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

Re: [PATCH] D21241: Add an ASTMatcher for ignoring ExprWithCleanups.

2016-06-21 Thread Tim Shen via cfe-commits
timshen abandoned this revision. timshen added a comment. > I was wondering why we didn't created that Matcher: IgnoreImplicit Actually you are right. There already exists a IgnoreImplict in clang-tidy and I just switched to that. Abandoning this patch. Thanks! http://reviews.llvm.org/D2124

r273312 - Re-commit "[Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr."

2016-06-21 Thread Tim Shen via cfe-commits
Author: timshen Date: Tue Jun 21 15:29:17 2016 New Revision: 273312 URL: http://llvm.org/viewvc/llvm-project?rev=273312&view=rev Log: Re-commit "[Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr." Since D21243 fixes relative clang-tidy tests. This reverts commit a71d9fbd

Re: [PATCH] D20498: [Temporary] Add an ExprWithCleanups for each C++ MaterializeTemporaryExpr

2016-06-21 Thread Tim Shen via cfe-commits
timshen added a comment. Committed as r273312. Repository: rL LLVM http://reviews.llvm.org/D20498 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

2016-06-30 Thread Tim Shen via cfe-commits
timshen updated this revision to Diff 62433. timshen added a comment. Done. Added a new testcase to ensure the correct behavior with exceptions turned on. http://reviews.llvm.org/D20499 Files: lib/CodeGen/CGCleanup.cpp lib/CodeGen/CGDecl.cpp lib/CodeGen/CGExpr.cpp lib/CodeGen/CodeGenFu

r274385 - [Temporary, Lifetime] Add lifetime marks for temporaries

2016-07-01 Thread Tim Shen via cfe-commits
Author: timshen Date: Fri Jul 1 16:08:47 2016 New Revision: 274385 URL: http://llvm.org/viewvc/llvm-project?rev=274385&view=rev Log: [Temporary, Lifetime] Add lifetime marks for temporaries With all MaterializeTemporaryExprs coming with a ExprWithCleanups, it's easy to add correct lifetime.end m

Re: [PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

2016-07-01 Thread Tim Shen via cfe-commits
This revision was automatically updated to reflect the committed changes. timshen marked an inline comment as done. Closed by commit rL274385: [Temporary, Lifetime] Add lifetime marks for temporaries (authored by timshen). Changed prior to commit: http://reviews.llvm.org/D20499?vs=62433&id=6254

r274387 - Remove unncessary CHECKs from r274385

2016-07-01 Thread Tim Shen via cfe-commits
Author: timshen Date: Fri Jul 1 16:16:58 2016 New Revision: 274387 URL: http://llvm.org/viewvc/llvm-project?rev=274387&view=rev Log: Remove unncessary CHECKs from r274385 Modified: cfe/trunk/test/CodeGen/temporary-lifetime.cpp Modified: cfe/trunk/test/CodeGen/temporary-lifetime.cpp URL: ht

Re: [PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

2016-07-01 Thread Tim Shen via cfe-commits
timshen added a comment. Also committed r274387 to remove unnecessary CHECks. It seems to cause problems in certain platforms. Repository: rL LLVM http://reviews.llvm.org/D20499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://list

r274396 - Removes CHECKs for symbolic label names (as Debug Clang will generate).

2016-07-01 Thread Tim Shen via cfe-commits
Author: timshen Date: Fri Jul 1 17:50:00 2016 New Revision: 274396 URL: http://llvm.org/viewvc/llvm-project?rev=274396&view=rev Log: Removes CHECKs for symbolic label names (as Debug Clang will generate). Differential Revision: http://reviews.llvm.org/D20499 Modified: cfe/trunk/test/CodeGen

Re: [PATCH] D20499: [Temporary, Lifetime] Add lifetime marks for temporaries

2016-07-01 Thread Tim Shen via cfe-commits
timshen added a comment. ...and r274396 to remove all of the checks for symbolic labels, which are not generated by release builds, nor controlled by a runtime-flag. Repository: rL LLVM http://reviews.llvm.org/D20499 ___ cfe-commits mailing list

Re: [PATCH] D15589: [PPC] Add long long/double support for vec_cts, vec_ctu and vec_ctf.

2016-01-04 Thread Tim Shen via cfe-commits
timshen added a comment. Ping? http://reviews.llvm.org/D15589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15589: [PPC] Add long long/double support for vec_cts, vec_ctu and vec_ctf.

2016-01-08 Thread Tim Shen via cfe-commits
timshen closed this revision. timshen added a comment. Thanks iteratee for committing as r257135 ! http://reviews.llvm.org/D15589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D15585: [PPC] Add long long/double support for vec_cts, vec_ctu and vec_ctf in altivec.h

2015-12-16 Thread Tim Shen via cfe-commits
timshen abandoned this revision. timshen added a comment. Due to unknown reasons, Phabricator is not sending emails to the list. Kill this revision and create another one to see. http://reviews.llvm.org/D15585 ___ cfe-commits mailing list cfe-commi

[PATCH] D15589: [PPC] Add long long/double support for vec_cts, vec_ctu and vec_ctf.

2015-12-16 Thread Tim Shen via cfe-commits
timshen created this revision. timshen added a subscriber: cfe-commits. Add long long/double support for vec_cts, vec_ctu and vec_ctf. Similar to this change in GCC: https://gcc.gnu.org/ml/gcc-patches/2014-08/msg02653.html http://reviews.llvm.org/D15589 Files: lib/Headers/altivec.h test/Co

<    1   2