This revision was automatically updated to reflect the committed changes.
Closed by commit rL330627: [libcxx] implement
declarations based on P0214R7. (authored by timshen, committed by ).
Herald added a subscriber: llvm-commits.
Changed prior to commit:
https://reviews.llvm
timshen accepted this revision.
timshen added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/test/CodeGen/builtins-nvptx-ptx60.cu:6
// RUN: %clang_cc1 -triple nvptx64-unknown-unknown -target-cpu sm_80 \
-// RUN:-fcuda-is-device -t
timshen created this revision.
timshen added a reviewer: mclow.lists.
Herald added a subscriber: sanjoy.
Herald added a reviewer: EricWF.
The patch includes all declarations, and also implements the following features:
- ABI.
- narrowing-conversion related SFIANE, including simd<> ctors and
(sta
timshen updated this revision to Diff 126813.
timshen added a comment.
Address comments:
- Generator ctor is implementable
- Format issues of tests
- SFINAE on __is_non_narrowing_convertible for arithmetics only.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/simd
libcx
timshen marked 4 inline comments as done.
timshen added inline comments.
Comment at: libcxx/include/experimental/simd:1069
+std::is_same<_Abi, simd_abi::fixed_size>::value &&
+__is_non_narrowing_convertible<_Up, _Tp>()>::type>
+ simd(const simd<_U
timshen accepted this revision.
timshen added a comment.
This revision is now accepted and ready to land.
Offline discussion discovered that __clear_cache() is not implemented for
powerpc64 (the big-endian target). I think it's correct to use the same
implementation of __clear_cache() for both e
timshen created this revision.
Herald added a subscriber: sanjoy.
The mis-compile is triggered by internal code, but I haven't reduced it to a
small piece of code. Add a FIXME here, since a decent fix doesn't seem to be
trivial.
The decent fix can be changing Decl::Init to PointerUnion, and mak
This revision was automatically updated to reflect the committed changes.
Closed by commit rL309908: [Sema] Add a comment on an identified bug on default
arguments. (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D36253?vs=109461&id=109464#toc
Repository:
rL LLVM
ht
timshen accepted this revision.
timshen added a comment.
This revision is now accepted and ready to land.
What's the test situation for these headers?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73237/new/
https://reviews.llvm.org/D73237
_
timshen added inline comments.
Comment at: libcxx/include/experimental/simd:669
+
+#if _LIBCPP_STD_VER > 14 && !defined(_LIBCPP_HAS_NO_VARIABLE_TEMPLATES)
+template
mclow.lists wrote:
> Isn't the parallelism TS based on C++17?
>
I intended to have a C++11 (and
timshen updated this revision to Diff 139393.
timshen marked 7 inline comments as done.
timshen added a comment.
Address comments.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/nothing_to_do.p
timshen updated this revision to Diff 141188.
timshen added a comment.
Addressed comments.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/include/module.modulemap
libcxx/test/libcxx/double_include.sh.cpp
libcxx/test/
timshen marked 5 inline comments as done.
timshen added inline comments.
Comment at:
libcxx/test/std/experimental/simd/simd.traits/is_simd_mask.pass.cpp:68
+
+static_assert(!is_simd_mask::value, "");
+
mclow.lists wrote:
> How about a couple more negative tests
timshen updated this revision to Diff 141189.
timshen added a comment.
Also optimize -O0 load and stores by using memcpy.
https://reviews.llvm.org/D44659
Files:
libcxx/include/experimental/simd
libcxx/test/std/experimental/simd/simd.elementwise/operators.pass.cpp
Index: libcxx/test/std/exp
timshen updated this revision to Diff 141436.
timshen marked an inline comment as done.
timshen added a comment.
Update file comments copy-paste error.
https://reviews.llvm.org/D41148
Files:
libcxx/include/experimental/__config
libcxx/include/experimental/simd
libcxx/include/module.module
timshen created this revision.
Herald added a subscriber: sanjoy.
Herald added a reviewer: EricWF.
Build abstraction on regex's allocation
This fixes a fuzzer crasher from a huge input (provided by Marshall), which
seems to be a stackoverflow during destruction. However, I can't reproduce
Marsh
timshen updated this revision to Diff 120334.
timshen added a comment.
Add an assertion to __push.
https://reviews.llvm.org/D39308
Files:
libcxx/include/regex
Index: libcxx/include/regex
===
--- libcxx/include/regex
+++ libcxx/i
timshen added a comment.
In https://reviews.llvm.org/D39308#907424, @mclow.lists wrote:
> A couple of notes.
Sorry for the oversights, when a C++11(-only :) contributor doesn't care about
ABI stability, nor exceptions, he contributes naive code. :P I'll fix them.
> - This change means that n
timshen updated this revision to Diff 120711.
timshen added a comment.
Remove the uses of variadic template and auto.
I'm not sure of how to implement this without a ABI change (the addition of
__storage_).
https://reviews.llvm.org/D39308
Files:
libcxx/include/regex
Index: libcxx/include/r
timshen created this revision.
timshen added reviewers: hfinkel, kbarton, iteratee, echristo.
timshen added subscribers: llvm-commits, cfe-commits.
Herald added subscribers: nemanjai, mehdi_amini.
This patch changes the layout of DoubleAPFloat, and adjust all
operations to do either:
1. (IEEEdoub
timshen updated this revision to Diff 81980.
timshen added a comment.
Remove 'else' after return.
Remove 'return' on void type.
https://reviews.llvm.org/D27872
Files:
clang/test/CodeGen/ppc64-complex-parms.c
llvm/include/llvm/ADT/APFloat.h
llvm/lib/Support/APFloat.cpp
llvm/test/CodeGen/
timshen updated this revision to Diff 81981.
timshen added a comment.
Remove more 'else' after return.
https://reviews.llvm.org/D27872
Files:
clang/test/CodeGen/ppc64-complex-parms.c
llvm/include/llvm/ADT/APFloat.h
llvm/lib/Support/APFloat.cpp
llvm/test/CodeGen/PowerPC/fp128-bitcast-aft
timshen updated this revision to Diff 82148.
timshen added a comment.
Consistently use early return style.
https://reviews.llvm.org/D27872
Files:
clang/test/CodeGen/ppc64-complex-parms.c
llvm/include/llvm/ADT/APFloat.h
llvm/lib/Support/APFloat.cpp
llvm/test/CodeGen/PowerPC/fp128-bitcast
timshen added a comment.
I changed type style to early return.
For constructors and destructors, I use:
if (...) {
// statement;
return;
}
For normal functions that returns void, I chose:
if (...)
return Foo();
llvm_unreachable(...);
since it's more compact. If returning v
timshen created this revision.
timshen added reviewers: kbarton, hfinkel, iteratee, echristo, bogner.
timshen added subscribers: llvm-commits, cfe-commits.
Herald added subscribers: amehsan, nemanjai, mehdi_amini.
For a << b (as original vec_sl does), if b >= sizeof(a) * 8, the
behavior is undefin
timshen created this revision.
timshen added a reviewer: mclow.lists.
timshen added a subscriber: cfe-commits.
Herald added a reviewer: EricWF.
This prevents the backtracking regex engines from "hanging forever"
under certain input.
https://reviews.llvm.org/D28224
Files:
libcxx/include/regex
timshen updated this revision to Diff 82840.
timshen added a comment.
Detect user defined _LIBCPP_REGEX_COMPLEXITY_FACTOR first.
https://reviews.llvm.org/D28224
Files:
libcxx/include/regex
libcxx/test/std/re/re.alg/re.alg.match/exponential.pass.cpp
libcxx/test/std/re/re.alg/re.alg.search/
timshen added a comment.
I defined and exported a macro _LIBCPP_REGEX_COMPLEXITY_FACTOR in the hope that
even when the library is shipped to the user, and when the user finds the
factor to be inappropriate, they can override it.
I'm not aware of and exported macro policy though, please advice.
timshen updated this revision to Diff 83140.
timshen added a comment.
Update comments, and move llvm changes to another patch.
https://reviews.llvm.org/D28037
Files:
clang/lib/Headers/altivec.h
clang/test/CodeGen/builtins-ppc-altivec.c
Index: clang/test/CodeGen/builtins-ppc-altivec.c
=
timshen added a comment.
In https://reviews.llvm.org/D27872#636130, @echristo wrote:
> Looks pretty weird. Typically I'd suggest just:
>
> if (foo) {
>
> Foo();
> return;
>
> }
>
> since that will keep cognitive overhead to a minimum.
>
> -eric
>
> > Other functions are not controversial.
I
timshen added a comment.
In https://reviews.llvm.org/D27872#636149, @echristo wrote:
> I'm pretty sure I've never seen return widely used in
> the code base versus my suggestion. That said, if you've looked and it's
> roughly 50/50 then I care a lot less (and we can bike shed in some separate
timshen added a comment.
Friendly ping :)
Is there anyone else I can add as a reviewer, if no one feels comfortable
reviewing the semantic?
https://reviews.llvm.org/D27872
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
timshen updated this revision to Diff 83700.
timshen added a comment.
Rename semPPCDoubleDoubleImpl to semPPCDoubleDoubleLegacy to reflect its use
more accurately.
https://reviews.llvm.org/D27872
Files:
clang/test/CodeGen/ppc64-complex-parms.c
llvm/include/llvm/ADT/APFloat.h
llvm/lib/Sup
timshen added a comment.
In https://reviews.llvm.org/D27872#639020, @hfinkel wrote:
> it is not at all obvious what is going on (i.e. why are we casting to
> integers?). Maybe semPPCDoubleDoubleImpl needs a better name now? It seems
> confusing to have semPPCDoubleDoubleImpl and semPPCDoubleDou
timshen marked an inline comment as done.
timshen added inline comments.
Comment at: llvm/include/llvm/ADT/APFloat.h:791
void makeNaN(bool SNaN, bool Neg, const APInt *fill) {
-getIEEE().makeNaN(SNaN, Neg, fill);
+if (usesLayout(getSemantics()))
+ return U.IEEE.ma
timshen marked an inline comment as done.
timshen added a comment.
Friendly ping. :)
We still have internal test failures that this patch (and the next one) fixes,
and I think this is the last "hard to review" patch in the APFloat refactoring.
https://reviews.llvm.org/D27872
___
timshen added a comment.
In https://reviews.llvm.org/D28037#652021, @echristo wrote:
> Going to commit this?
I'd like to commit https://reviews.llvm.org/D28329 first. If we commit this
now, the normal code will be slower.
https://reviews.llvm.org/D28037
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292659: [Altivec] Change vec_sl to a << (b % (sizeof(a) *
8)) (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D28037?vs=83140&id=85194#toc
Repository:
rL LLVM
https://review
timshen updated this revision to Diff 85217.
timshen marked 2 inline comments as done.
timshen added a comment.
Stylish changes.
https://reviews.llvm.org/D27872
Files:
clang/test/CodeGen/ppc64-complex-parms.c
llvm/include/llvm/ADT/APFloat.h
llvm/lib/Support/APFloat.cpp
llvm/test/CodeGen
timshen added inline comments.
Comment at: llvm/include/llvm/ADT/APFloat.h:1039
+ /// \brief Operator+ overload which provides the default
+ /// \c nmNearestTiesToEven rounding mode and *no* error checking.
APFloat operator+(const APFloat &RHS) const {
echri
This revision was automatically updated to reflect the committed changes.
Closed by commit rL292839: [APFloat] Switch from (PPCDoubleDoubleImpl,
IEEEdouble) layout to (IEEEdouble… (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D27872?vs=85217&id=85457#toc
Repository:
timshen marked 13 inline comments as done.
timshen added inline comments.
Comment at: llvm/include/llvm/ADT/APFloat.h:1054
+ opStatus next(bool nextDown) {
+if (usesLayout(getSemantics()))
jlebar wrote:
> FWIW, see my screed on this:
> http://jlebar.com/2
timshen updated this revision to Diff 86375.
timshen added a comment.
Fix in the right way as rsmith pointed out.
https://reviews.llvm.org/D24333
Files:
clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
clang/lib/Sema/TreeTransform.h
clang/test/Sema/pr30306.cpp
Index: clang/test/Sema/pr303
timshen updated this revision to Diff 86377.
timshen added a comment.
ActOnFinishFullExpr after exiting the expression evaluation context.
https://reviews.llvm.org/D24333
Files:
clang/lib/Sema/SemaTemplateInstantiateDecl.cpp
clang/lib/Sema/TreeTransform.h
clang/test/Sema/pr30306.cpp
Ind
timshen created this revision.
Herald added subscribers: hiraditya, eraman, inglorion, mehdi_amini, sanjoy.
Previously it doesn't actually invoke the designated new PM builder
functions.
https://reviews.llvm.org/D34728
Files:
clang/lib/CodeGen/BackendUtil.cpp
llvm/lib/Passes/PassBuilder.cpp
timshen added a comment.
A question I have is that I don't know how to test this. Ideally we want
-debug-pass-manager from opt, but that flag is not part of the LLVM libraries.
https://reviews.llvm.org/D34728
___
cfe-commits mailing list
cfe-commit
timshen updated this revision to Diff 104533.
timshen marked 5 inline comments as done.
timshen added a comment.
Added -fexperimental-new-pass-manager=off/on/debug for printing debug
information.
Added a Clang test.
Do tell if you want me to split this patch. I didn't, becuase then I don't have
timshen added inline comments.
Comment at: clang/lib/CodeGen/BackendUtil.cpp:804-807
+ case 0:
+return PassBuilder::O0;
+
case 1:
tejohnson wrote:
> chandlerc wrote:
> > Why is this change needed?
> I assume it is just cleanup since this isn't currently c
timshen created this revision.
Herald added subscribers: hiraditya, mehdi_amini, sanjoy.
https://reviews.llvm.org/D34790
Files:
clang/include/clang/Driver/Options.td
clang/include/clang/Frontend/CodeGenOptions.def
clang/include/clang/Frontend/CodeGenOptions.h
clang/lib/CodeGen/BackendUtil
timshen updated this revision to Diff 104551.
timshen added a comment.
Splitted into two patches. I'll commit this one (ThinLTO change) without the
test first, then commit the flag change with the Clang ThinLTO pipeline test.
https://reviews.llvm.org/D34728
Files:
clang/lib/CodeGen/BackendUt
timshen added inline comments.
Comment at: clang/include/clang/Driver/Options.td:971-973
+def fexperimental_new_pass_manager_EQ : Joined<["-"],
"fexperimental-new-pass-manager=">,
+ Group, Flags<[CC1Option]>,
+ HelpText<"Enables an experimental new pass manager in LLVM.">,
Va
timshen updated this revision to Diff 104753.
timshen added a comment.
Use a cc1 flag -fdebug-pass-manager instead.
https://reviews.llvm.org/D34790
Files:
clang/include/clang/Driver/CC1Options.td
clang/include/clang/Frontend/CodeGenOptions.def
clang/lib/CodeGen/BackendUtil.cpp
clang/lib
timshen added a comment.
Also add @tejohnson as a reviewer, since the LTO test changed
https://reviews.llvm.org/D34790
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
timshen marked 2 inline comments as done.
timshen added inline comments.
Comment at: clang/include/clang/Driver/Options.td:971-973
+def fexperimental_new_pass_manager_EQ : Joined<["-"],
"fexperimental-new-pass-manager=">,
+ Group, Flags<[CC1Option]>,
+ HelpText<"Enables an exp
timshen updated this revision to Diff 104766.
timshen marked an inline comment as done.
timshen added a comment.
Herald added a subscriber: aprantl.
s/the debug prints/debug printing/
https://reviews.llvm.org/D34790
Files:
clang/include/clang/Driver/CC1Options.td
clang/include/clang/Fronten
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306756: [ThinkLTO] Invoke
build(Thin)?LTOPreLinkDefaultPipeline. (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D34728?vs=104551&id=104767#toc
Repository:
rL LLVM
https://r
This revision was automatically updated to reflect the committed changes.
Closed by commit rL306757: [NewPM] Add Clang cc1 flag -fdebug-pass-manager for
printing debug information. (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D34790?vs=104766&id=104768#toc
Repositor
timshen added a comment.
`__can_bind_reference()` doesn't return anything when
__reference_binds_to_temporary doesn't exist. This causes builds break with old
compilers.
Should it just return true if __reference_binds_to_temporary doesn't exist?
Repository:
rCXX libc++
https://reviews.llvm
timshen added a comment.
Created https://reviews.llvm.org/D42510 for discussion. I'm not sure if it's a
good idea, though.
Repository:
rCXX libc++
https://reviews.llvm.org/D41977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lis
timshen created this revision.
timshen added reviewers: EricWF, rsmith.
Herald added a subscriber: sanjoy.
This is a follow-up to https://reviews.llvm.org/D41977.
https://reviews.llvm.org/D42510
Files:
libcxx/include/tuple
Index: libcxx/include/tuple
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295123: [VLA] Handle VLA size expression in a
full-expression context. (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D24333?vs=86377&id=88464#toc
Repository:
rL LLVM
https
timshen created this revision.
Herald added a subscriber: nemanjai.
I'm not sure why they were in different files, but it's kind of harder to
maintain. I create this patch partially for initiate a discussion.
https://reviews.llvm.org/D30118
Files:
clang/test/CodeGen/xray-attributes-supported
This revision was automatically updated to reflect the committed changes.
Closed by commit rL295778: [XRay] Merge xray clang flag tests, and add
powerpc64le. (authored by timshen).
Changed prior to commit:
https://reviews.llvm.org/D30118?vs=88953&id=89284#toc
Repository:
rL LLVM
https://rev
101 - 163 of 163 matches
Mail list logo
