thorsten-klein wrote:
Thanks a lot for your review @vbvictor!
I have resolved your review findings.
What do you think about the option's name? Is `AllowNoNamespaceComments` fine
for you or shall I rename to `AllowOmittingNamespaceComments` (or any other
suggestion)?
https://github.com/llvm/
https://github.com/thorsten-klein updated
https://github.com/llvm/llvm-project/pull/124265
>From 608ceb0bb475aad65abb55a1dd02bf84d62ec99c Mon Sep 17 00:00:00 2001
From: "Klein, Thorsten (GDE-EDSI1)"
Date: Fri, 24 Jan 2025 13:46:24 +0100
Subject: [PATCH] added option AllowNoNamespaceComments for
https://github.com/thorsten-klein created
https://github.com/llvm/llvm-project/pull/124265
new option AllowNoNamespaceComments for
`google-readability-namespace-comments.AllowNoNamespaceComments` is added.
Ref: #124264
When true, the check will allow that no namespace comment is present. If a
https://github.com/thorsten-klein updated
https://github.com/llvm/llvm-project/pull/124265
>From 15a8d29ef422afe853adeb1fd66e5218d9ebfa34 Mon Sep 17 00:00:00 2001
From: "Klein, Thorsten (GDE-EDSI1)"
Date: Fri, 24 Jan 2025 13:46:24 +0100
Subject: [PATCH] added option AllowNoNamespaceComments for
https://github.com/thorsten-klein edited
https://github.com/llvm/llvm-project/pull/124265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/thorsten-klein edited
https://github.com/llvm/llvm-project/pull/124265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -287,6 +287,11 @@ Changes in existing checks
` check to
report a location even when the member location is not valid.
+- Improved :doc:`google-readability-namespace-comments
+ ` check to
+ add an option ``AllowNoNamespaceComments``, that permits
thors
https://github.com/thorsten-klein updated
https://github.com/llvm/llvm-project/pull/124265
>From bade51bc7f0135e5c74cc64ee851a17813c6820f Mon Sep 17 00:00:00 2001
From: "Klein, Thorsten (GDE-EDSI1)"
Date: Fri, 24 Jan 2025 13:46:24 +0100
Subject: [PATCH] added option AllowNoNamespaceComments for
thorsten-klein wrote:
@EugeneZelenko What do you think about some additional option
`EnforceNoNamespaceComments` in order to enforce that no namespace comment is
present?
If you like the idea, I could create some additional PR for introducing this
option.
https://github.com/llvm/llvm-project/
https://github.com/thorsten-klein updated
https://github.com/llvm/llvm-project/pull/124265
>From 9f3bc5021e6da87fa9a8db60b513acb87ed6b02f Mon Sep 17 00:00:00 2001
From: "Klein, Thorsten (GDE-EDSI1)"
Date: Fri, 24 Jan 2025 13:46:24 +0100
Subject: [PATCH] added option AllowNoNamespaceComments for
https://github.com/thorsten-klein updated
https://github.com/llvm/llvm-project/pull/124265
>From b1bfe0682f9889ae792ada546d3e4f1cd86acf69 Mon Sep 17 00:00:00 2001
From: "Klein, Thorsten (GDE-EDSI1)"
Date: Fri, 24 Jan 2025 13:46:24 +0100
Subject: [PATCH] added option AllowNoNamespaceComments for
https://github.com/thorsten-klein updated
https://github.com/llvm/llvm-project/pull/124265
>From 9a2171658093b791e08f0f2b93e132be3a4419f5 Mon Sep 17 00:00:00 2001
From: "Klein, Thorsten (GDE-EDSI1)"
Date: Fri, 24 Jan 2025 13:46:24 +0100
Subject: [PATCH] added option AllowNoNamespaceComments for
https://github.com/thorsten-klein updated
https://github.com/llvm/llvm-project/pull/124265
>From 4f44b9294bf290332faf3223d17999565cbea4d4 Mon Sep 17 00:00:00 2001
From: "Klein, Thorsten (GDE-EDSI1)"
Date: Fri, 24 Jan 2025 13:46:24 +0100
Subject: [PATCH] added option AllowNoNamespaceComments for
https://github.com/thorsten-klein updated
https://github.com/llvm/llvm-project/pull/124265
>From 150cb66b9e440d9ed2019b5ceb9a26ed8c21942b Mon Sep 17 00:00:00 2001
From: "Klein, Thorsten (GDE-EDSI1)"
Date: Fri, 24 Jan 2025 13:46:24 +0100
Subject: [PATCH] added option AllowNoNamespaceComments for
https://github.com/thorsten-klein edited
https://github.com/llvm/llvm-project/pull/124265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -187,6 +187,11 @@ Changes in existing checks
` check by fixing a false positive
where ``strerror`` was flagged as MT-unsafe.
+- Improved :doc:`google-readability-namespace-comments
thorsten-klein wrote:
I will add another ReleaseNotes entry.
Shall I ru
https://github.com/thorsten-klein updated
https://github.com/llvm/llvm-project/pull/124265
>From a683a7b33fe9b2e06e5116261b8decf233d72d67 Mon Sep 17 00:00:00 2001
From: "Klein, Thorsten (GDE-EDSI1)"
Date: Fri, 24 Jan 2025 13:46:24 +0100
Subject: [PATCH] added option AllowNoNamespaceComments for
@@ -187,6 +187,11 @@ Changes in existing checks
` check by fixing a false positive
where ``strerror`` was flagged as MT-unsafe.
+- Improved :doc:`google-readability-namespace-comments
thorsten-klein wrote:
> Shall I run the tests for this llvm-namespace-c
https://github.com/thorsten-klein updated
https://github.com/llvm/llvm-project/pull/124265
>From a6556aebc4f70be5e8be805fd009589fa7e0dc22 Mon Sep 17 00:00:00 2001
From: "Klein, Thorsten (GDE-EDSI1)"
Date: Fri, 24 Jan 2025 13:46:24 +0100
Subject: [PATCH] added option AllowNoNamespaceComments for
https://github.com/thorsten-klein updated
https://github.com/llvm/llvm-project/pull/124265
>From 6bbb691e844e51b40e38958c22678bb066d301f5 Mon Sep 17 00:00:00 2001
From: "Klein, Thorsten (GDE-EDSI1)"
Date: Fri, 24 Jan 2025 13:46:24 +0100
Subject: [PATCH] added option AllowNoNamespaceComments for
https://github.com/thorsten-klein updated
https://github.com/llvm/llvm-project/pull/124265
>From 0c0f9a860e060eecb23a541f478772a3f7b2731c Mon Sep 17 00:00:00 2001
From: "Klein, Thorsten (GDE-EDSI1)"
Date: Fri, 24 Jan 2025 13:46:24 +0100
Subject: [PATCH] added option AllowNoNamespaceComments for
thorsten-klein wrote:
My e-mail address is now public 👍
https://github.com/llvm/llvm-project/pull/124265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
thorsten-klein wrote:
I have no access to a computer today. I can fix tomorrow, if it has not been
fixed before.
https://github.com/llvm/llvm-project/pull/124265
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
23 matches
Mail list logo
