[PATCH] D148284: [clangd] Add "readonly" token to const member expressions

2023-04-13 Thread Thorben Tröbst via Phabricator via cfe-commits
t-troebst created this revision. t-troebst added a reviewer: nridge. t-troebst added a project: clang-tools-extra. Herald added subscribers: kadircet, arphaman. Herald added a project: All. t-troebst requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.

[PATCH] D148284: [clangd] Add "readonly" token to const member expressions

2023-04-13 Thread Thorben Tröbst via Phabricator via cfe-commits
t-troebst updated this revision to Diff 513406. t-troebst added a comment. Changed `isConstQualifed()` to the custom `isConst()` (though this `isConst()` behaves strangely for pointer types, we should fix this separately and keep them synced for now). Repository: rG LLVM Github Monorepo CHA

[PATCH] D148284: [clangd] Add "readonly" token to const member expressions

2023-05-01 Thread Thorben Tröbst via Phabricator via cfe-commits
t-troebst updated this revision to Diff 518641. t-troebst added a comment. Add best effort attempt to get const-ness for dependent member expressions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148284/new/ https://reviews.llvm.org/D148284 Files

[PATCH] D148284: [clangd] Add "readonly" token to const member expressions

2023-05-01 Thread Thorben Tröbst via Phabricator via cfe-commits
t-troebst added a comment. I've added some logic to get const-ness for dependent expressions. I think you're right that its probably reasonable to do this since mutable is almost always used in member functions where the type isn't dependent anyways. Repository: rG LLVM Github Monorepo CHAN