[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

Origami404 created this revision. Herald added a project: All. Origami404 added reviewers: aaron.ballman, erichkeane, mgorny, jyknight, mibintc, clang-language-wg. Origami404 published this revision for review. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. On GNU/

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

Origami404 updated this revision to Diff 471865. Origami404 added a comment. I'm sorry that my patch can not pass the CI test, but I can not reproduce the CI failure loaclly, including clang-format related problems. On my machine, `ninja check-clang` shows: [0/1] Running the Clang regression t

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

Origami404 added a comment. After digging more deeply into tests, I found that if we decide to make clang include `stdc-predef.h` or other things, the behavior of many libtooling-related tools (e.g. clang-tidy, clangd, and python binding) will be affected. For example, `clang-tidy/checkers/cpp

[PATCH] D137343: [clang] add -Wvla-stack-allocation

Origami404 updated this revision to Diff 483796. Origami404 added a comment. [clang] add -Wvla-stack-allocation and divide different VLA warning New behaviors: -Wvla-stack-allocation warns on use of a VLA that involves a stack allocation -Wvla-portability warns on any use of a VM type, ev

[PATCH] D137343: [clang] add -Wvla-stack-allocation

Origami404 added a subscriber: mizvekov. Origami404 added a comment. Hello, I am back now and will be available anytime next week, so if anyone has any idea on this topic, please at me! I haven't found a way that "feels right" to achieve consensus yet. But I do have something to share currently

[PATCH] D137343: [clang] add -Wvla-stack-allocation

Origami404 created this revision. Herald added a project: All. Origami404 edited the summary of this revision. Origami404 edited the summary of this revision. Origami404 added reviewers: aaron.ballman, efriedma. Origami404 added a subscriber: inclyc. Origami404 published this revision for review. H

[PATCH] D137343: [clang] add -Wvla-stack-allocation

Origami404 added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137343/new/ https://reviews.llvm.org/D137343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

Origami404 added a comment. ping :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137043/new/ https://reviews.llvm.org/D137043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

Origami404 added a comment. In D137043#3935129 , @aaronpuchert wrote: > This include-if-exists mechanism seems brittle to me. Do you mean the way that we used to test a file and include it (inserting `#if __has_include`) is brittle or compilation flags

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

Origami404 updated this revision to Diff 477453. Origami404 added a comment. Change implements according reviews. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137043/new/ https://reviews.llvm.org/D137043 Files: clang/docs/ReleaseNotes.rst cla

[PATCH] D137343: [clang] add -Wvla-stack-allocation

Origami404 updated this revision to Diff 477482. Origami404 added a comment. Update release notes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137343/new/ https://reviews.llvm.org/D137343 Files: clang/docs/ReleaseNotes.rst clang/include/clan

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

Origami404 updated this revision to Diff 478977. Origami404 added a comment. Improved comments and release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137043/new/ https://reviews.llvm.org/D137043 Files: clang/docs/ReleaseNotes.rst clan

[PATCH] D137043: [clang] add implicit include for Linux/gnu compatibility

Origami404 marked 7 inline comments as done. Origami404 added inline comments. Comment at: clang/test/Driver/stdc-predef.c:33-34 + +// This behavior should appear in all languages that use the c preprocessor, +// including C, C++ and Objective-C, as long as the system uses musl.

[PATCH] D137343: [clang] add -Wvla-stack-allocation

Origami404 added a comment. > int foo(void); > > void bar(int a, int b[*]); // variable length array used, correct > void bar(int a, int b[a]) { variable length array used, correct > int x[foo()]; // variable length array that may require stack allocation > used, correct > > (