[clang] [llvm] [Sema] Implement support for -Wformat-signedness (PR #74440)

2023-12-05 Thread Takuya Shimizu via cfe-commits
@@ -918,6 +918,9 @@ def Wdeprecated : Flag<["-"], "Wdeprecated">, Group, HelpText<"Enable warnings for deprecated constructs and define __DEPRECATED">; def Wno_deprecated : Flag<["-"], "Wno-deprecated">, Group, Visibility<[ClangOption, CC1Option]>; +def Wformat_signedness

[llvm] [clang] [Sema] Implement support for -Wformat-signedness (PR #74440)

2023-12-11 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: > I need to extend the tablegen backend ClangDiagnosticsEmitter with some kind > of new option to handle this, right? Alternatively, you could probably use `DiagnosticsEngine::isIgnored` to check if the `-Wformat-signedness` is enabled or not, and control whether `MatchSigned

[clang] [clang][Sema] Refine unused-member-function diagnostic message for constructors (PR #84515)

2024-03-20 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: Please add a release note line to `clang/docs/ReleaseNotes.rst` because this patch changes the diagnostic behavior of clang https://github.com/llvm/llvm-project/pull/84515 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [clang][ExprConst] Fix crash on uninitialized array subobject (PR #67817)

2023-10-22 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: Ping https://github.com/llvm/llvm-project/pull/67817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] Fix crash on uninitialized array subobject (PR #67817)

2023-10-26 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/67817 >From 7f4db6d81f24adb72416e79bde65a1a13d9a82b8 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Fri, 29 Sep 2023 23:49:11 +0900 Subject: [PATCH 1/4] [clang][ExprConst] Fix crash on uninitialized array subob

[clang] [clang][ExprConst] Fix crash on uninitialized array subobject (PR #67817)

2023-10-26 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet closed https://github.com/llvm/llvm-project/pull/67817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] Fix crash on uninitialized array subobject (PR #67817)

2023-10-26 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: Thanks for the heads up. I'll request backporting in a few hours when buildbots finish running tests. https://github.com/llvm/llvm-project/pull/67817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[clang] [clang][Sema] Fix crash introduced in b2cd9db589335d5885c04df83003a623cf2f05ff (PR #66954)

2023-09-20 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet created https://github.com/llvm/llvm-project/pull/66954 Old iterator is invalidated upon SmallVector elements additions. Stores index instead of iterator to avoid this. Fixes https://github.com/llvm/llvm-project/issues/66938 >From 74b06739e7309798e53110307bfe0abb9

[clang] [clang][Sema] Fix crash introduced in b2cd9db589335d5885c04df83003a623cf2f05ff (PR #66954)

2023-09-20 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/66954 >From 74b06739e7309798e53110307bfe0abb9bd5b649 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Thu, 21 Sep 2023 06:27:55 +0900 Subject: [PATCH 1/2] [clang][Sema] Fix crash introduced in b2cd9db Old iterato

[clang] [clang][Sema] Fix crash introduced in b2cd9db589335d5885c04df83003a623cf2f05ff (PR #66954)

2023-09-21 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet closed https://github.com/llvm/llvm-project/pull/66954 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-24 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: > ping @hazohelet . This should be good to land and should help clear some red > in our CI for Linux kernel builds. Thanks for the ping. I was away for a while. I'm merging this after updating the PR descriptions. https://github.com/llvm/llvm-project/pull/65969 __

[clang] [clang][Sema] Make format size estimator aware of %p's existence in format string (PR #65969)

2023-09-24 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet edited https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Make format size estimator aware of %p's existence in format string (PR #65969)

2023-09-24 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet closed https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 491b281 - [clang][SemaCXX] Diagnose tautological uses of consteval if and is_constant_evaluated

2023-09-26 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-09-27T09:26:06+09:00 New Revision: 491b2810fb7fe5f080fa9c4f5945ed0a6909dc92 URL: https://github.com/llvm/llvm-project/commit/491b2810fb7fe5f080fa9c4f5945ed0a6909dc92 DIFF: https://github.com/llvm/llvm-project/commit/491b2810fb7fe5f080fa9c4f5945ed0a6909dc92.diff

[clang] [clang][ExprConst] Fix crash on uninitialized array subobject (PR #67817)

2023-09-29 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet created https://github.com/llvm/llvm-project/pull/67817 https://reviews.llvm.org/D146358 was assuming that all subobjects have their own name (`SubobjectDecl`), but it was not true for array elements. Fixes https://github.com/llvm/llvm-project/issues/67317 >From e

[clang] [clang][ExprConst] Fix crash on uninitialized array subobject (PR #67817)

2023-09-29 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/67817 >From e331f12dd6f8976df44855619ab740aee86ddd2e Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Fri, 29 Sep 2023 23:49:11 +0900 Subject: [PATCH 1/2] [clang][ExprConst] Fix crash on uninitialized array subob

[clang] [clang][ExprConst] Fix crash on uninitialized array subobject (PR #67817)

2023-10-02 Thread Takuya Shimizu via cfe-commits
@@ -2411,10 +2411,15 @@ static bool CheckEvaluationResult(CheckEvaluationResultKind CERK, const FieldDecl *SubobjectDecl, CheckedTemporaries &CheckedTemps) { if (!Value.hasValue()) { -assert(SubobjectDec

[clang] 2176c5e - [Clang][Sema] Fix display of characters on static assertion failure

2023-10-03 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-10-04T14:09:06+09:00 New Revision: 2176c5e510e3bfcbc75afb13e78d287141f239a7 URL: https://github.com/llvm/llvm-project/commit/2176c5e510e3bfcbc75afb13e78d287141f239a7 DIFF: https://github.com/llvm/llvm-project/commit/2176c5e510e3bfcbc75afb13e78d287141f239a7.diff

[clang] 8e329ca - Reland "[Clang][SemaCXX] Add unused warning for variables declared in condition expressions"

2023-08-15 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-08-15T17:24:13+09:00 New Revision: 8e329caa944c377c51ef567d5aa67cfac9ffd0fa URL: https://github.com/llvm/llvm-project/commit/8e329caa944c377c51ef567d5aa67cfac9ffd0fa DIFF: https://github.com/llvm/llvm-project/commit/8e329caa944c377c51ef567d5aa67cfac9ffd0fa.diff

[clang] 5aded52 - Revert "Reland "[Clang][SemaCXX] Add unused warning for variables declared in condition expressions""

2023-08-15 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-08-15T19:54:51+09:00 New Revision: 5aded521ea94810b81369eaa951dcf59ad5ab82d URL: https://github.com/llvm/llvm-project/commit/5aded521ea94810b81369eaa951dcf59ad5ab82d DIFF: https://github.com/llvm/llvm-project/commit/5aded521ea94810b81369eaa951dcf59ad5ab82d.diff

[clang] b3469ce - [clang][Analysis] Handle && and || against variable and its negation as tautology

2023-08-17 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-08-17T17:55:48+09:00 New Revision: b3469ce6f80bce2b0a86026fd6867c4b04853466 URL: https://github.com/llvm/llvm-project/commit/b3469ce6f80bce2b0a86026fd6867c4b04853466 DIFF: https://github.com/llvm/llvm-project/commit/b3469ce6f80bce2b0a86026fd6867c4b04853466.diff

[clang] 985a72b - [clang][Diagnostics] Provide source range to integer-overflow warnings

2023-08-19 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-08-19T22:05:12+09:00 New Revision: 985a72b6b3e74f0d29780b2a97b5817473338ffe URL: https://github.com/llvm/llvm-project/commit/985a72b6b3e74f0d29780b2a97b5817473338ffe DIFF: https://github.com/llvm/llvm-project/commit/985a72b6b3e74f0d29780b2a97b5817473338ffe.diff

[clang] [clang][ExprConst] Fix crash on uninitialized array subobject (PR #67817)

2023-10-09 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: Ping https://github.com/llvm/llvm-project/pull/67817 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ExprConst] Fix crash on uninitialized array subobject (PR #67817)

2023-10-15 Thread Takuya Shimizu via cfe-commits
@@ -2411,10 +2411,15 @@ static bool CheckEvaluationResult(CheckEvaluationResultKind CERK, const FieldDecl *SubobjectDecl, CheckedTemporaries &CheckedTemps) { if (!Value.hasValue()) { -assert(SubobjectDec

[clang] [clang][ExprConst] Fix crash on uninitialized array subobject (PR #67817)

2023-10-15 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/67817 >From acb5d8286335f85732ede8d33ac2529e13a3f61b Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Fri, 29 Sep 2023 23:49:11 +0900 Subject: [PATCH 1/3] [clang][ExprConst] Fix crash on uninitialized array subob

[clang] [clang][ExprConst] Fix crash on uninitialized array subobject (PR #67817)

2023-10-15 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/67817 >From acb5d8286335f85732ede8d33ac2529e13a3f61b Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Fri, 29 Sep 2023 23:49:11 +0900 Subject: [PATCH 1/4] [clang][ExprConst] Fix crash on uninitialized array subob

[clang] e90f4fc - [clang][ExprConstant] Print template arguments when describing stack frame

2023-07-31 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-07-31T17:05:56+09:00 New Revision: e90f4fc6acaffd216e06e47df0aee6a8b5b2d4a9 URL: https://github.com/llvm/llvm-project/commit/e90f4fc6acaffd216e06e47df0aee6a8b5b2d4a9 DIFF: https://github.com/llvm/llvm-project/commit/e90f4fc6acaffd216e06e47df0aee6a8b5b2d4a9.diff

[clang] bd0ed0a - [Clang][SemaCXX] Add unused warning for variables declared in condition expressions

2023-08-06 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-08-06T16:24:09+09:00 New Revision: bd0ed0abc31fa5a49e87eeca7aa872e7f6e4d1e7 URL: https://github.com/llvm/llvm-project/commit/bd0ed0abc31fa5a49e87eeca7aa872e7f6e4d1e7 DIFF: https://github.com/llvm/llvm-project/commit/bd0ed0abc31fa5a49e87eeca7aa872e7f6e4d1e7.diff

[clang] 18b6f6e - Revert "[Clang][SemaCXX] Add unused warning for variables declared in condition expressions"

2023-08-06 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-08-06T17:02:01+09:00 New Revision: 18b6f6e0c7d0b492e90738d684aeb731754aeaac URL: https://github.com/llvm/llvm-project/commit/18b6f6e0c7d0b492e90738d684aeb731754aeaac DIFF: https://github.com/llvm/llvm-project/commit/18b6f6e0c7d0b492e90738d684aeb731754aeaac.diff

[clang] 24c91d4 - [clang][ExprConstant] Fix crash on uninitialized base class subobject

2023-08-07 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-08-08T15:53:17+09:00 New Revision: 24c91d443222bdb20205630d300ae61bfa07067e URL: https://github.com/llvm/llvm-project/commit/24c91d443222bdb20205630d300ae61bfa07067e DIFF: https://github.com/llvm/llvm-project/commit/24c91d443222bdb20205630d300ae61bfa07067e.diff

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

2023-09-07 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/65248: >From eee4c3aee9350be51c9333f284810ffebd9d1663 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Mon, 4 Sep 2023 16:23:00 +0900 Subject: [PATCH 1/3] [clang][MSExtentions] Fix invalid overload failure about

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

2023-09-10 Thread Takuya Shimizu via cfe-commits
@@ -4443,7 +,7 @@ struct CompoundAssignSubobjectHandler { return foundVector(Subobj, SubobjType); case APValue::Indeterminate: Info.FFDiag(E, diag::note_constexpr_access_uninit) - << /*read of=*/0 << /*uninitialized object=*/1; + << /*read

[clang] [clang][Diagnostics] Add source range to uninitialized diagnostics (PR #65896)

2023-09-10 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/65896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-11 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet created https://github.com/llvm/llvm-project/pull/65969: GCC stops counting format string's size when it sees %p format in order to avoid `Wformat-truncation` false positive against Linux kernel's format extension (%pOF, for example). This change makes clang's beha

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-11 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-11 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet labeled https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-11 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet labeled https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-11 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-11 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-11 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-11 Thread Takuya Shimizu via cfe-commits
@@ -96,6 +96,11 @@ void call_snprintf(double d) { __builtin_snprintf(buf, 1, "%.1000g", d); // expected-warning {{'snprintf' will always be truncated; specified size is 1, but format string expands to at least 2}} __builtin_snprintf(buf, 5, "%.1000g", d); __builtin_snpr

[clang] 72f6abb - [clang][Sema] Fix format size estimator's handling of %o, %x, %X with alternative form

2023-09-11 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-09-12T12:22:26+09:00 New Revision: 72f6abb9bca68bf1398b321a73ebe3158bca67e5 URL: https://github.com/llvm/llvm-project/commit/72f6abb9bca68bf1398b321a73ebe3158bca67e5 DIFF: https://github.com/llvm/llvm-project/commit/72f6abb9bca68bf1398b321a73ebe3158bca67e5.diff

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-12 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/65969: >From 80d8743441ce1e25f19dbc48bce480b5becfa208 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Tue, 12 Sep 2023 00:39:44 +0900 Subject: [PATCH 1/3] [clang][Sema] Stop format size estimator upon %p to adapt

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-12 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: > Is there some way we can narrow the scope of this patch so we don't lose > warnings for normal `snprintf`s, only for the kernel one? If we really can't > tell the difference from the source code, we could move the affected warnings > to a different warning group instead, so

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-12 Thread Takuya Shimizu via cfe-commits
@@ -851,6 +851,50 @@ class ScanfDiagnosticFormatHandler } }; +/// `I` points to the next character of `%p` format. +/// This functon checks if the subsequent character can be linux kernel's +/// extnded format specifier +static inline constexpr bool canBeLinuxFormatExtension

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-13 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: Thanks for the detailed suggestion! I agree it's the appropriate approach. I was planning to separate `Wformat-truncation` from `Wfortify-source` sometime after this PR (as was requested in the same issue), but now that we are going to introduce a new warning group, we should

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-13 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/65969: >From 5ee1a4f83c69b5e2910ea883dca7f0fa2c1a4bd3 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Wed, 13 Sep 2023 17:43:11 +0900 Subject: [PATCH 1/2] [clang][Diagnostics] Separate Wformat-overflow and Wform

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-13 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet resolved https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-13 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet resolved https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-13 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet resolved https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-13 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet resolved https://github.com/llvm/llvm-project/pull/65969 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

2023-09-14 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: > @hazohelet Does this collide or intersect with the work wrt. (un)evaluated > contexts in https://reviews.llvm.org/D155064 ? I wasn't aware of VLA cases in that patch. My patch needs modification so that use of `is_constant_evaluated` and consteval-if NOT considered tautologi

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-14 Thread Takuya Shimizu via cfe-commits
@@ -961,10 +961,16 @@ def FormatNonStandard : DiagGroup<"format-non-iso">; def FormatY2K : DiagGroup<"format-y2k">; def FormatPedantic : DiagGroup<"format-pedantic">; def FormatTypeConfusion : DiagGroup<"format-type-confusion">; + +def FormatOverflowNonKprintf: DiagGroup<"forma

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-14 Thread Takuya Shimizu via cfe-commits
@@ -1350,10 +1360,17 @@ void Sema::checkFortifiedBuiltinMemoryFunction(FunctionDecl *FD, llvm::APSInt::getUnsigned(H.getSizeLowerBound()) .extOrTrunc(SizeTypeWidth); if (FormatSize > *SourceSize && *SourceSize != 0) { - DiagID = dia

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-14 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/65969: >From 5ee1a4f83c69b5e2910ea883dca7f0fa2c1a4bd3 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Wed, 13 Sep 2023 17:43:11 +0900 Subject: [PATCH 1/3] [clang][Diagnostics] Separate Wformat-overflow and Wform

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

2023-09-14 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: > Where do you think it matters? I can't this of cases where ConstantEvaluated > context are nested in one another without some intertwined potentially > evaluated context I was mostly thinking about cases where the array-bound expression appears inside immediate function con

[clang] [Clang] Handle consteval expression in array bounds expressions (PR #66222)

2023-09-15 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: > I'll add a test. immediate contexts are recursive, constant evaluated > contexts are not, i don't think there is a case where you would get an > additional evaluation context that is not for a full expression, and if you > have a full expression you do expect the immediate i

[clang] [clang][Sema] Stop format size estimator upon %p to adapt to linux kernel's extension (PR #65969)

2023-09-18 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/65969 >From 5ee1a4f83c69b5e2910ea883dca7f0fa2c1a4bd3 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Wed, 13 Sep 2023 17:43:11 +0900 Subject: [PATCH 1/4] [clang][Diagnostics] Separate Wformat-overflow and Wforma

[clang] b2cd9db - [clang][Sema] Remove irrelevant diagnostics from constraint satisfaction failure

2023-09-18 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-09-18T18:14:44+09:00 New Revision: b2cd9db589335d5885c04df83003a623cf2f05ff URL: https://github.com/llvm/llvm-project/commit/b2cd9db589335d5885c04df83003a623cf2f05ff DIFF: https://github.com/llvm/llvm-project/commit/b2cd9db589335d5885c04df83003a623cf2f05ff.diff

[clang] 176981a - [clang][Diagnostics] Fix distant source ranges in bad-conversion notes

2023-07-14 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-07-14T22:59:41+09:00 New Revision: 176981ac58d3e4beb02b9d110524e72be509375d URL: https://github.com/llvm/llvm-project/commit/176981ac58d3e4beb02b9d110524e72be509375d DIFF: https://github.com/llvm/llvm-project/commit/176981ac58d3e4beb02b9d110524e72be509375d.diff

[clang] 615d812 - [clang][ExprConstant] Improve error message of compound assignment against uninitialized object

2023-08-25 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-08-25T16:08:07+09:00 New Revision: 615d812696ee8827d6d78ad106d6022ff2778137 URL: https://github.com/llvm/llvm-project/commit/615d812696ee8827d6d78ad106d6022ff2778137 DIFF: https://github.com/llvm/llvm-project/commit/615d812696ee8827d6d78ad106d6022ff2778137.diff

[clang] 0c9c9dd - [clang][Sema] Add truncation warning on fortified snprintf

2023-08-25 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-08-26T14:41:05+09:00 New Revision: 0c9c9dd9a24f9d715d950fef0ac7aae01437af96 URL: https://github.com/llvm/llvm-project/commit/0c9c9dd9a24f9d715d950fef0ac7aae01437af96 DIFF: https://github.com/llvm/llvm-project/commit/0c9c9dd9a24f9d715d950fef0ac7aae01437af96.diff

[clang] 01b88dd - [NFC] Remove unused variables declared in conditions

2023-08-29 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-08-30T10:05:06+09:00 New Revision: 01b88dd66d9d52d3f531a7d490e18c549f36f445 URL: https://github.com/llvm/llvm-project/commit/01b88dd66d9d52d3f531a7d490e18c549f36f445 DIFF: https://github.com/llvm/llvm-project/commit/01b88dd66d9d52d3f531a7d490e18c549f36f445.diff

[clang] 92023b1 - Reland "[Clang][SemaCXX] Add unused warning for variables declared in condition expressions"

2023-08-29 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-08-30T10:05:10+09:00 New Revision: 92023b15099012a657da07ebf49dd7d94a260f84 URL: https://github.com/llvm/llvm-project/commit/92023b15099012a657da07ebf49dd7d94a260f84 DIFF: https://github.com/llvm/llvm-project/commit/92023b15099012a657da07ebf49dd7d94a260f84.diff

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

2023-09-03 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

2023-09-03 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet labeled https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

2023-09-03 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

2023-09-03 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet created https://github.com/llvm/llvm-project/pull/65238: When the caret location is lower than the lowest source range, clang is printing wrong line numbers. The first line number should consider caret location line even when there are source ranges provided. Curr

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

2023-09-03 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

2023-09-03 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

2023-09-03 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

2023-09-03 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: When the `Loc` is higher than the lowest begin source location, `DisplayLineNo` still points to the lowest begin location line because we have ```c++ DisplayLineNo = std::min(DisplayLineNo, SM.getPresumedLineNumber(I.getBegin())); ``` in L1169, correct? This does not b

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

2023-09-04 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: > Ouch the inability to comment outside of modified code is going to be painful. > > The changed code being > > ```c++ > unsigned DisplayLineNo = Loc.getPresumedLoc().getLine(); > for (const auto &I : Ranges) { > DisplayLineNo = > std::min(DisplayLineNo, SM.g

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

2023-09-04 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet labeled https://github.com/llvm/llvm-project/pull/65248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

2023-09-04 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet created https://github.com/llvm/llvm-project/pull/65248: Loss of `__unaligned` qualifier does not invalidate overload candidates. This fixes a regression reported in https://reviews.llvm.org/D153690 >From eee4c3aee9350be51c9333f284810ffebd9d1663 Mon Sep 17 00:00:00

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

2023-09-04 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

2023-09-04 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

2023-09-04 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

2023-09-04 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet review_requested https://github.com/llvm/llvm-project/pull/65248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

2023-09-04 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/65238: >From 2bc13f3b013a4bda4364e9c29bc792ca6a0c7cf1 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Mon, 4 Sep 2023 10:46:17 +0900 Subject: [PATCH 1/2] [clang][Diagnostics] Fix wrong line number display When t

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

2023-09-04 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/65238: >From 2bc13f3b013a4bda4364e9c29bc792ca6a0c7cf1 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Mon, 4 Sep 2023 10:46:17 +0900 Subject: [PATCH 1/3] [clang][Diagnostics] Fix wrong line number display When t

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

2023-09-04 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/65248: >From eee4c3aee9350be51c9333f284810ffebd9d1663 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Mon, 4 Sep 2023 16:23:00 +0900 Subject: [PATCH 1/2] [clang][MSExtentions] Fix invalid overload failure about

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-04 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: FWIW, an empty commit didn't trigger CI correctly yesterday, so pushing a non-empty commit might fix the CI issue. https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] [clang][MSExtentions] Fix invalid overload failure about the loss of `__unaligned` qualifier (PR #65248)

2023-09-04 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet updated https://github.com/llvm/llvm-project/pull/65248: >From eee4c3aee9350be51c9333f284810ffebd9d1663 Mon Sep 17 00:00:00 2001 From: Takuya Shimizu Date: Mon, 4 Sep 2023 16:23:00 +0900 Subject: [PATCH 1/3] [clang][MSExtentions] Fix invalid overload failure about

[clang] [Clang] Fix missing diagnostic for non-standard layout type in `offsetof` (PR #65246)

2023-09-04 Thread Takuya Shimizu via cfe-commits
hazohelet wrote: Adding an irrelevant new line in a modified test file would suffice to trigger the CI build. Force-pushing doesn't seem to be desirable during code review. https://github.com/llvm/llvm-project/pull/65246 ___ cfe-commits mailing list c

[clang] [clang][Diagnostics] Fix wrong line number display (PR #65238)

2023-09-04 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet closed https://github.com/llvm/llvm-project/pull/65238 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dfb85c3 - [Clang][Interp] Diagnose uninitialized ctor of global record arrays

2023-06-21 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-06-21T19:03:01+09:00 New Revision: dfb85c3ce09a7bd1a059a3e821390b5111454f9e URL: https://github.com/llvm/llvm-project/commit/dfb85c3ce09a7bd1a059a3e821390b5111454f9e DIFF: https://github.com/llvm/llvm-project/commit/dfb85c3ce09a7bd1a059a3e821390b5111454f9e.diff

[clang] 940c94e - [clang][Sema] Fix comments to conform to bugprone-argument-comment (NFC)

2023-06-23 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-06-23T22:25:04+09:00 New Revision: 940c94e1c1b99511630b6f61890ac54161b5829c URL: https://github.com/llvm/llvm-project/commit/940c94e1c1b99511630b6f61890ac54161b5829c DIFF: https://github.com/llvm/llvm-project/commit/940c94e1c1b99511630b6f61890ac54161b5829c.diff

[clang] 409a809 - [clang][Diagnostics] Provide parameter source range to arity-mismatch notes

2023-06-25 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-06-26T00:27:15+09:00 New Revision: 409a8097c5c728607eb6b05efb1744bf5f9096e1 URL: https://github.com/llvm/llvm-project/commit/409a8097c5c728607eb6b05efb1744bf5f9096e1 DIFF: https://github.com/llvm/llvm-project/commit/409a8097c5c728607eb6b05efb1744bf5f9096e1.diff

[clang] f6be96a - [clang][ExprConstant] Fix display of syntactically-invalid note for member function calls

2023-06-27 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-06-28T00:19:46+09:00 New Revision: f6be96aa4e5e282ea52041ad6fe5fff13a3df103 URL: https://github.com/llvm/llvm-project/commit/f6be96aa4e5e282ea52041ad6fe5fff13a3df103 DIFF: https://github.com/llvm/llvm-project/commit/f6be96aa4e5e282ea52041ad6fe5fff13a3df103.diff

[clang] 8038086 - [clang][Sema] Remove dead diagnostic for loss of __unaligned qualifier

2023-06-29 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-06-29T23:02:09+09:00 New Revision: 8038086aa75a122e5e632ebb1e7da06a2f7eed4b URL: https://github.com/llvm/llvm-project/commit/8038086aa75a122e5e632ebb1e7da06a2f7eed4b DIFF: https://github.com/llvm/llvm-project/commit/8038086aa75a122e5e632ebb1e7da06a2f7eed4b.diff

[clang] 986cbd8 - [clang][AST] TextNodeDumper should not evaluate the initializer of constexpr variable declaration when it has a dependent type

2023-05-22 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-05-23T00:57:38+09:00 New Revision: 986cbd80d1dc838c61abff24b8d7ac28dcf4ac2a URL: https://github.com/llvm/llvm-project/commit/986cbd80d1dc838c61abff24b8d7ac28dcf4ac2a DIFF: https://github.com/llvm/llvm-project/commit/986cbd80d1dc838c61abff24b8d7ac28dcf4ac2a.diff

[clang] 456d072 - Reland: [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

2023-05-24 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-05-24T21:31:25+09:00 New Revision: 456d072405d29ac731ad22fa1ec198b9f8265c4e URL: https://github.com/llvm/llvm-project/commit/456d072405d29ac731ad22fa1ec198b9f8265c4e DIFF: https://github.com/llvm/llvm-project/commit/456d072405d29ac731ad22fa1ec198b9f8265c4e.diff

[clang] 29dc47a - [clang][Sema] `-Wshadow` warns about shadowings by static local variables

2023-05-24 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-05-24T21:31:25+09:00 New Revision: 29dc47a9eeeb2e080170109e3e2fb3cd5aad58d2 URL: https://github.com/llvm/llvm-project/commit/29dc47a9eeeb2e080170109e3e2fb3cd5aad58d2 DIFF: https://github.com/llvm/llvm-project/commit/29dc47a9eeeb2e080170109e3e2fb3cd5aad58d2.diff

[clang] 0e167fc - [clang][AST] Print name instead of type when diagnosing uninitialized subobject in constexpr variables

2023-05-16 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-05-16T21:49:57+09:00 New Revision: 0e167fc0a2147c9b673b8afd5fea001b0d127781 URL: https://github.com/llvm/llvm-project/commit/0e167fc0a2147c9b673b8afd5fea001b0d127781 DIFF: https://github.com/llvm/llvm-project/commit/0e167fc0a2147c9b673b8afd5fea001b0d127781.diff

[clang] b8c08f7 - [clang][Sema] Fix diagnostic message for unused constant variable templates

2023-06-14 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-06-14T21:43:03+09:00 New Revision: b8c08f7ae86da4723f9e125d5defa5404518d87d URL: https://github.com/llvm/llvm-project/commit/b8c08f7ae86da4723f9e125d5defa5404518d87d DIFF: https://github.com/llvm/llvm-project/commit/b8c08f7ae86da4723f9e125d5defa5404518d87d.diff

[clang] 6408317 - [clang][Sema] Provide source range to several Wunused warnings

2023-06-16 Thread Takuya Shimizu via cfe-commits
Author: Takuya Shimizu Date: 2023-06-16T19:26:53+09:00 New Revision: 64083172eea26e50c8b22b85697a825be8bda424 URL: https://github.com/llvm/llvm-project/commit/64083172eea26e50c8b22b85697a825be8bda424 DIFF: https://github.com/llvm/llvm-project/commit/64083172eea26e50c8b22b85697a825be8bda424.diff

[clang] [clang][Sema] Fix crash on atomic builtins with incomplete type args (PR #96374)

2024-06-29 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet closed https://github.com/llvm/llvm-project/pull/96374 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix crash on atomic builtins with incomplete type args (PR #96374)

2024-06-21 Thread Takuya Shimizu via cfe-commits
https://github.com/hazohelet created https://github.com/llvm/llvm-project/pull/96374 This patch fixes the crash when pointers to incomplete type are passed to atomic builtins such as `__atomic_load`. `ASTContext::getTypeInfoInChars` assumes that the argument type is a complete type, so I added

[clang] [clang][Sema] Fix crash on atomic builtins with incomplete type args (PR #96374)

2024-06-24 Thread Takuya Shimizu via cfe-commits
@@ -4570,7 +4570,8 @@ ExprResult Sema::BuildAtomicExpr(SourceRange CallRange, SourceRange ExprRange, } // Pointer to object of size zero is not allowed. - if (Context.getTypeInfoInChars(AtomTy).Width.isZero()) { + if (!AtomTy->isIncompleteType() && hazo

  1   2   >