Author: twoh
Date: Wed Aug 14 00:11:09 2019
New Revision: 368804
URL: http://llvm.org/viewvc/llvm-project?rev=368804&view=rev
Log:
[NewPM][PassInstrumentation] IR printing support from clang driver
Summary: https://reviews.llvm.org/D50923 enabled the IR printing support for
the new pass manager,
twoh added a comment.
ping
https://reviews.llvm.org/D23765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
twoh added a comment.
ping
https://reviews.llvm.org/D23765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
twoh added a comment.
ping
https://reviews.llvm.org/D23765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: twoh
Date: Wed Dec 6 09:00:53 2017
New Revision: 319904
URL: http://llvm.org/viewvc/llvm-project?rev=319904&view=rev
Log:
Stringizing raw string literals containing newline
Summary: This patch implements 4.3 of
http://open-std.org/jtc1/sc22/wg21/docs/papers/2014/n4220.pdf. If a raw stri
Author: twoh
Date: Wed Aug 16 12:36:24 2017
New Revision: 311037
URL: http://llvm.org/viewvc/llvm-project?rev=311037&view=rev
Log:
Use the file name from linemarker for debug info if an input is preprocessed
source.
Summary:
Even in the case of the input file is a preprocessed source, clang uses
twoh created this revision.
twoh added a reviewer: rsmith.
twoh added a subscriber: cfe-commits.
Since rL274049, for an inheriting constructor declaration, the name of the
using declaration (and using shadow declaration comes from the using
declaration) is the name of a derived class, not the ba
twoh added a comment.
ping
https://reviews.llvm.org/D23765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
twoh added a comment.
Ping.
https://reviews.llvm.org/D23765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
twoh updated this revision to Diff 71560.
twoh added a comment.
Tests added
https://reviews.llvm.org/D23765
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/crash-has-nothrow-constructor.cpp
test/SemaCXX/crash-has-nothrow-copy.cpp
Index: test/SemaCXX/crash-has-nothrow-copy.cpp
==
twoh updated this revision to Diff 71711.
twoh added a comment.
Updated diff. For ConstructorUsingShadowDecl, test with its target
CXXConstructorDecl, but only when it is not a default/copy/move constructor.
https://reviews.llvm.org/D23765
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/cxx11
twoh added a comment.
@rsmith Thank you for your review! I added tests to cxx11-crashes.cpp, as the
goal of this patch is not handling __has_* traits right but preventing ICE.
Also, I tried to use ConstructorUsingShadowDecl::getConstructor instead of
ConstructorUsingShadowDecl::getTargetDecl fo
Author: twoh
Date: Tue Feb 21 16:30:55 2017
New Revision: 295779
URL: http://llvm.org/viewvc/llvm-project?rev=295779&view=rev
Log:
Fix for pr31836 - pp_nonportable_path on absolute paths: broken delimiters
Summary: This is a patch for PR31836. As the bug replaces the path separators
in the inclu
Author: twoh
Date: Tue Mar 7 14:20:23 2017
New Revision: 297194
URL: http://llvm.org/viewvc/llvm-project?rev=297194&view=rev
Log:
Use filename in linemarker when compiling preprocessed source (Revised)
Summary:
This is a revised version of D28796. Included test is changed to
resolve the target c
twoh added a comment.
ping
https://reviews.llvm.org/D23765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
twoh updated this revision to Diff 75441.
twoh marked an inline comment as done.
twoh added a comment.
Addressing comments from @sepavloff. Thanks!
https://reviews.llvm.org/D23765
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/cxx11-crashes.cpp
Index: test/SemaCXX/cxx11-crashes.cpp
twoh marked an inline comment as not done.
twoh added a comment.
Ping
https://reviews.llvm.org/D23765
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
twoh added a comment.
Is there a particular reason why "opt_record_file" is defined in CC1Options.td,
not Options.td? If -opt-record-file= is provided by the command line,
line 829-831 in CompilerInvocation.cpp won't handle it because opt_record_file
is not a CodeGenArg.
Repository:
rL LLVM
twoh added a comment.
In https://reviews.llvm.org/D25225#584012, @hfinkel wrote:
> In https://reviews.llvm.org/D25225#584010, @twoh wrote:
>
> > Is there a particular reason why "opt_record_file" is defined in
> > CC1Options.td, not Options.td? If -opt-record-file= is provided
> > by the comman
twoh updated this revision to Diff 76817.
twoh added a comment.
Addressing comments from @rsmith. Thanks!
https://reviews.llvm.org/D23765
Files:
lib/Sema/SemaExprCXX.cpp
test/SemaCXX/cxx11-crashes.cpp
Index: test/SemaCXX/cxx11-crashes.cpp
==
twoh updated this revision to Diff 55377.
twoh added a comment.
Addressing comments from @joerg. Two versions of the test provided, one for an
architecture with signed char(x86_64) and the other for an architecture with
unsigned char(powerpc64).
http://reviews.llvm.org/D19062
Files:
include
twoh added a comment.
Ping. Can someone please commit this patch for me? Thanks!
http://reviews.llvm.org/D19062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
twoh updated this revision to Diff 56198.
twoh added a comment.
Rebased on ToT. Thanks @aaron.ballman!
http://reviews.llvm.org/D19062
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/Builtins.h
lib/Sema/SemaDecl.cpp
test/FixIt/typo.m
test/Sema/enable_if.c
test/Sema/libbui
twoh created this revision.
twoh added reviewers: faisalv, rsmith.
twoh added a subscriber: cfe-commits.
(This is a fix for Bug 27797 https://llvm.org/bugs/show_bug.cgi?id=27797).
Currently when RebuildLambdaScopeInfo() function in lib/Sema/SemaDecl.cpp
observes lambda capturing 'this', it calls
twoh added a comment.
Thank you for your comments. @faisalv, it is great that you already submitted a
patch. Let me see if your patch resolves the issue I have. Thanks!
http://reviews.llvm.org/D20349
___
cfe-commits mailing list
cfe-commits@lists.l
twoh added a comment.
My patch passes check-clang and the test cases in this patch as well.
BTW, newly added test cases in the patch seem to be passed even without the
patch. Isn't the bug appears when template instantiation generates nested
lambdas (because template instantiation updates the '
twoh added a comment.
@faisalv, thank you for the update. I wonder if getCurrentThisType() is the
best place to call adjustCVQualifiersForCXXThisWithinLambda(). It seems that
getCurrentThisType() does more than its name suggests. Is there any other place
that the adjustment function can be call
twoh created this revision.
twoh added reviewers: rsmith, aaron.ballman.
twoh added a subscriber: cfe-commits.
Add functions declared in ctype.h to builtin function database. All functions
are annotated with nothrow and const attribute, which enables better
optimization.
http://reviews.llvm.or
twoh added a comment.
@joerg My bad. They surely read from globals. I'll fix the diff. Thanks for the
catch!
http://reviews.llvm.org/D18970
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c
twoh updated this revision to Diff 53369.
twoh added a comment.
Fix attribute annotation from 'const' to 'pure'. Add support for 'pure'
attribute to builtin function database related code. Test case
(test/Sema/libbuiltins-ctype.c) added. Line 116 of test/FixIt/typo.m is removed
because it is no
twoh updated this revision to Diff 53395.
twoh added a comment.
Addressing comments from @aaron.ballman. It would be great if someone can
commit this patch for me, as I don't have the privilege yet.
http://reviews.llvm.org/D18970
Files:
include/clang/Basic/Builtins.def
include/clang/Basic/
Sure, I'll take a look.
Thanks!
-- Taewook
On 4/13/16, 8:00 AM, "Aaron Ballman" wrote:
>aaron.ballman added a comment.
>
>I reverted this in r266201; it was causing build bot failures like:
>
>https://urldefense.proofpoint.com/v2/url?u=http-3A__lab.llvm.org-3A8011_bu
>ilders_clang-2Dppc64be-2Dl
twoh created this revision.
twoh added a reviewer: aaron.ballman.
twoh added subscribers: joerg, cfe-commits, rsmith.
Add functions declared in ctype.h to builtin function database. All functions
are annotated with nothrow and const attribute, which enables better
optimization.
This patch has
Joerg,
Thank you for your comments. I submitted a new patch
(http://reviews.llvm.org/D19062) with a new test that checks attributes
but not types. I think this should cover both cases. What do you think?
Thanks,
Taewook
On 4/14/16, 2:46 AM, "Joerg Sonnenberger" wrote:
>On Wed, Apr 13, 2016 at
twoh added a comment.
Ping. @joerg, could you please take a look?
http://reviews.llvm.org/D19062
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
twoh added a comment.
Hmm, yes it seems not so simple to move the call to another place. If I come up
with a better idea I'll submit it as a separate patch, as I don't want to block
this one. Thank you for your work, @faisalv!
http://reviews.llvm.org/D19783
_
Author: twoh
Date: Fri Jun 3 13:27:39 2016
New Revision: 271701
URL: http://llvm.org/viewvc/llvm-project?rev=271701&view=rev
Log:
Test commit
Modified:
cfe/trunk/include/clang/Basic/Builtins.def
Modified: cfe/trunk/include/clang/Basic/Builtins.def
URL:
http://llvm.org/viewvc/llvm-project
Author: twoh
Date: Fri Jun 3 13:30:12 2016
New Revision: 271702
URL: http://llvm.org/viewvc/llvm-project?rev=271702&view=rev
Log:
[Title] Revert test commit
Summary: Revert test commit
Trac Bug: #
Blame Rev:
Reviewed By:
Test Plan:
Revert Plan:
Database Impact:
Memcache Impact:
Other Not
Author: twoh
Date: Fri Jun 3 13:52:51 2016
New Revision: 271708
URL: http://llvm.org/viewvc/llvm-project?rev=271708&view=rev
Log:
Use the name of the file on disk to issue a new diagnostic about non-portable
#include and #import paths.
Differential Revision: http://reviews.llvm.org/D19843
Corre
twoh added a subscriber: twoh.
twoh closed this revision.
twoh added a comment.
I have commit in r271708: http://reviews.llvm.org/rL271708
http://reviews.llvm.org/D19843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/c
Author: twoh
Date: Fri Jun 3 22:14:43 2016
New Revision: 271761
URL: http://llvm.org/viewvc/llvm-project?rev=271761&view=rev
Log:
Revert commit r271708
Removed:
cfe/trunk/test/Lexer/Inputs/case-insensitive-include.h
cfe/trunk/test/Lexer/case-insensitive-include-ms.c
cfe/trunk/test/L
I reverted the patch with r271761 and r271764.
Thanks,
Taewook
On 6/3/16, 6:40 PM, "Bruno Cardoso Lopes" wrote:
>> The information about whether the file is in a system path is already being
>> computed, so it would incur no extra overhead. I'm not sure that's the right
>> fix. You are more tha
twoh added a comment.
Reverted in r271761.
http://reviews.llvm.org/D19843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: twoh
Date: Mon Jun 13 12:03:18 2016
New Revision: 272562
URL: http://llvm.org/viewvc/llvm-project?rev=272562&view=rev
Log:
Use the name of the file on disk to issue a new diagnostic about non-portable
#include and #import paths.
Differential Revision: http://reviews.llvm.org/D19843
Corre
twoh closed this revision.
twoh added a comment.
Re-commited in http://reviews.llvm.org/rL272562
http://reviews.llvm.org/D19843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: twoh
Date: Mon Jun 13 13:32:30 2016
New Revision: 272572
URL: http://llvm.org/viewvc/llvm-project?rev=272572&view=rev
Log:
Revert r272562 for build bot failure (clang-x86-win2008-selfhost)
Removed:
cfe/trunk/test/Lexer/Inputs/case-insensitive-include.h
cfe/trunk/test/Lexer/case-i
twoh added a comment.
I already reverted the path in http://reviews.llvm.org/rL272572, so re-commit
should be the way to go.
http://reviews.llvm.org/D19843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailma
Author: twoh
Date: Mon Jun 13 15:40:21 2016
New Revision: 272584
URL: http://llvm.org/viewvc/llvm-project?rev=272584&view=rev
Log:
Use the name of the file on disk to issue a new diagnostic about non-portable
#include and #import paths.
Differential Revision: http://reviews.llvm.org/D19843
Corre
twoh closed this revision.
twoh added a comment.
Committed by commit http://reviews.llvm.org/rL272584
http://reviews.llvm.org/D19843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: twoh
Date: Mon Jun 13 16:55:33 2016
New Revision: 272592
URL: http://llvm.org/viewvc/llvm-project?rev=272592&view=rev
Log:
Patch for r272584 (http://reviews.llvm.org/rL272584) to address
clang-x64-ninja-win7 buildbot failure.
Patch by Eric Niebler
Modified:
cfe/trunk/lib/Lex/PPDire
twoh added a comment.
Patch committed in http://reviews.llvm.org/rL272592.
http://reviews.llvm.org/D19843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
51 matches
Mail list logo
