[PATCH] D75985: clangd doc: Show a test case for clangd with some commands

sylvestre.ledru updated this revision to Diff 249653. sylvestre.ledru added a comment. fix some typo + desc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75985/new/ https://reviews.llvm.org/D75985 Files: clang-tools-extra/docs/clangd/SimpleExamp

[PATCH] D75985: clangd doc: Show a test case for clangd with some commands

sylvestre.ledru added a comment. Good question :) I have been wearing two hats here. With my Debian/Ubuntu hat, i have been interested to write some dumb integration tests to be sure that clangd, as a package, works as expected. I just need to make sure that the binary starts, that I can send s

[PATCH] D68720: Support -fstack-clash-protection for x86

sylvestre.ledru added a comment. In D68720#1862050 , @xbolva00 wrote: > Any plans to merge this feature to 10 release? I would love to have it in -10 for Firefox ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D41808: Rename clang link from clang-X.Y to clang-X

sylvestre.ledru updated this revision to Diff 140202. sylvestre.ledru edited the summary of this revision. sylvestre.ledru added a comment. Add to the release notes Repository: rC Clang https://reviews.llvm.org/D41808 Files: CMakeLists.txt docs/ReleaseNotes.rst Index: docs/ReleaseNotes

[PATCH] D38124: Hide some symbols to avoid a crash on shutdown when using code coverage

sylvestre.ledru updated this revision to Diff 122077. sylvestre.ledru edited the summary of this revision. https://reviews.llvm.org/D38124 Files: lib/profile/GCDAProfiling.c test/profile/Inputs/instrprof-dlopen-dlclose-main.c test/profile/instrprof-dlopen-dlclose-gcov.test Index: test/prof

[PATCH] D38124: Hide some symbols to avoid a crash on shutdown when using code coverage

sylvestre.ledru added a comment. please thank Marco :) https://reviews.llvm.org/D38124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30990: Add more examples to clang-format configuration

sylvestre.ledru created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D30990 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h === --- include

[PATCH] D30990: Add more examples to clang-format configuration

sylvestre.ledru added inline comments. Comment at: docs/ClangFormatStyleOptions.rst:671 + + bool value = a ++ a Is this example valid? I don't see wh

[PATCH] D30990: Add more examples to clang-format configuration

sylvestre.ledru updated this revision to Diff 91925. sylvestre.ledru added a comment. More example (JS) https://reviews.llvm.org/D30990 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h ===

[PATCH] D30990: Add more examples to clang-format configuration

sylvestre.ledru updated this revision to Diff 91928. sylvestre.ledru added a comment. Improve consistency on an example https://reviews.llvm.org/D30990 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h ===

[PATCH] D30990: Add more examples to clang-format configuration

sylvestre.ledru added a comment. Daniel, is that ok with you? https://reviews.llvm.org/D30990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30990: Add more examples to clang-format configuration

sylvestre.ledru updated this revision to Diff 92316. sylvestre.ledru marked an inline comment as done. https://reviews.llvm.org/D30990 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h ==

[PATCH] D31408: Add more examples to clang-format configuration

sylvestre.ledru created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D31408 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h === --- include

[PATCH] D31408: Add more examples to clang-format configuration

sylvestre.ledru updated this revision to Diff 93195. sylvestre.ledru added a comment. Thanks, indeed! :) https://reviews.llvm.org/D31408 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h ==

[PATCH] D31408: Add more examples to clang-format configuration

sylvestre.ledru added a comment. Daniel, wdyt? :) https://reviews.llvm.org/D31408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31408: Add more examples to clang-format configuration

sylvestre.ledru updated this revision to Diff 94008. https://reviews.llvm.org/D31408 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: docs/ClangFormatStyleOptions.rst === --- docs/ClangFormatStyleOpti

[PATCH] D31408: Add more examples to clang-format configuration

sylvestre.ledru added inline comments. Comment at: docs/ClangFormatStyleOptions.rst:941 + ContinuationIndentWidth: 2 + ColumnLimit: 15 + djasper wrote: > You could force line wraps with tailing //-comments instead. much better. thanks

[PATCH] D31860: Add more examples to clang tidy checkers

sylvestre.ledru created this revision. sylvestre.ledru added a project: clang-tools-extra. https://reviews.llvm.org/D31860 Files: docs/clang-tidy/checks/llvm-namespace-comment.rst docs/clang-tidy/checks/llvm-twine-local.rst docs/clang-tidy/checks/misc-inefficient-algorithm.rst docs/clang-

[PATCH] D31862: docs/clang-tidy/tools/dump_check_docs.py: Remove deprecated script

sylvestre.ledru created this revision. This has been used to create the doc from the code comments. Now, this is very out of sync. https://reviews.llvm.org/D31862 Files: docs/clang-tidy/tools/dump_check_docs.py Index: docs/clang-tidy/tools/dump_check_docs.py ===

[PATCH] D31408: Add more examples to clang-format configuration

sylvestre.ledru added a comment. Daniel, is that ok with you? https://reviews.llvm.org/D31408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30863: [clang-format] make docs/tools/{dump_format_style.py, dump_ast_matchers.py} flake8 compliant

sylvestre.ledru added a comment. Manuel, is that ok with you? https://reviews.llvm.org/D30863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D31860: Add more examples to clang tidy checkers

sylvestre.ledru added inline comments. Comment at: docs/clang-tidy/checks/misc-unused-parameters.rst:15 + + void a(int /*i*/) {} + alexfh wrote: > nit: two spaces before the comment. I believe it is the case ? I stole this from the unit test //test/clang-tidy/

[PATCH] D30863: [clang-format] make docs/tools/{dump_format_style.py, dump_ast_matchers.py} flake8 compliant

sylvestre.ledru added a comment. Manuel, ping? https://reviews.llvm.org/D30863 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34824: clang-format: add an option -verbose to list the files being processed

sylvestre.ledru created this revision. sylvestre.ledru added a project: clang. https://reviews.llvm.org/D34824 Files: docs/ClangFormat.rst docs/ReleaseNotes.rst tools/clang-format/ClangFormat.cpp Index: docs/ReleaseNotes.rst

[PATCH] D34824: clang-format: add an option -verbose to list the files being processed

sylvestre.ledru updated this revision to Diff 104995. Herald added a subscriber: klimek. https://reviews.llvm.org/D34824 Files: docs/ClangFormat.rst docs/ReleaseNotes.rst test/Format/verbose.cpp tools/clang-format/ClangFormat.cpp Index: tools/clang-format/ClangFormat.cpp ===

[PATCH] D34824: clang-format: add an option -verbose to list the files being processed

sylvestre.ledru added inline comments. Comment at: tools/clang-format/ClangFormat.cpp:380 +if (Verbose.getNumOccurrences() != 0) +outs() << "Formatting " << FileNames[0] << '\n'; break; djasper wrote: > As clang-format often returns the result on

[PATCH] D34824: clang-format: add an option -verbose to list the files being processed

sylvestre.ledru added a comment. is that ok @djasper ? https://reviews.llvm.org/D34824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34824: clang-format: add an option -verbose to list the files being processed

sylvestre.ledru added inline comments. Comment at: tools/clang-format/ClangFormat.cpp:377 break; case 1: Error = clang::format::format(FileNames[0]); djasper wrote: > I think we should restructure the code to not have to duplicate what you are > add

[PATCH] D34824: clang-format: add an option -verbose to list the files being processed

sylvestre.ledru updated this revision to Diff 106778. https://reviews.llvm.org/D34824 Files: docs/ClangFormat.rst docs/ReleaseNotes.rst test/Format/verbose.cpp tools/clang-format/ClangFormat.cpp Index: tools/clang-format/ClangFormat.cpp ==

[PATCH] D34824: clang-format: add an option -verbose to list the files being processed

sylvestre.ledru marked 7 inline comments as done. sylvestre.ledru added inline comments. Comment at: test/Format/verbose.cpp:2 +// RUN: clang-format %s -verbose | FileCheck %s +// CHECK: Formatting + djasper wrote: > This seems like a pretty minimal test to me. C

[PATCH] D35462: Also add the option -no-pie (like -nopie)

sylvestre.ledru created this revision. For example, this option is expected by ghc (haskell compiler). Currently, building with ghc will fail with: clang: error: unknown argument: '-no-pie' `gcc' failed in phase `Linker'. (Exit code: 1) . /usr/share/haskell-devscripts/Dh_Haskell.sh && \

[PATCH] D34824: clang-format: add an option -verbose to list the files being processed

sylvestre.ledru updated this revision to Diff 107089. sylvestre.ledru marked an inline comment as done. sylvestre.ledru added a comment. Fixed, thanks for spotting the mistake. Looks like we could improve the testsuite as my mistake hasn't been catched. https://reviews.llvm.org/D34824 Files:

[PATCH] D29943: [clang-format] Align block comment decorations

sylvestre.ledru added a comment. Maybe this could be added to the release notes? Repository: rL LLVM https://reviews.llvm.org/D29943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru created this revision. To avoid potential regressions and checking most of the coding style aspects at once https://reviews.llvm.org/D30111 Files: test/Format/check-coding-style-mozilla.cpp Index: test/Format/check-coding-style-mozilla.cpp ===

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru updated this revision to Diff 89022. https://reviews.llvm.org/D30111 Files: test/Format/check-coding-style-mozilla.cpp Index: test/Format/check-coding-style-mozilla.cpp === --- test/Format/check-coding-style-mozill

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru marked 3 inline comments as done. sylvestre.ledru added inline comments. Comment at: test/Format/check-coding-style-mozilla.cpp:10 + * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ + +if (true) { krasimir wrote: > What is tested here

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru updated this revision to Diff 89093. sylvestre.ledru marked 3 inline comments as done. https://reviews.llvm.org/D30111 Files: unittests/Format/CheckCodingStyleMozilla.cpp Index: unittests/Format/CheckCodingStyleMozilla.cpp ===

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru added inline comments. Comment at: test/Format/check-coding-style-mozilla.cpp:48 +, +public Y +{ krasimir wrote: > sylvestre.ledru wrote: > > krasimir wrote: > > > This does not check precisely what the comment says

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru updated this revision to Diff 89094. sylvestre.ledru added a comment. Sorry, I tried to rename the file but this is too confusing for Phabricator it seems... https://reviews.llvm.org/D30111 Files: unittests/Format/check-coding-style-mozilla.cpp Index: unittests/Format/check-

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru added a comment. @krasimir is that ok with you? https://reviews.llvm.org/D30111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru updated this revision to Diff 90053. Herald added a subscriber: mgorny. https://reviews.llvm.org/D30111 Files: test/Format/check-coding-style-mozilla.cpp unittests/Format/CMakeLists.txt Index: unittests/Format/CMakeLists.txt ===

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru added a comment. I will rename it before the upload if that is fine with you. Comment at: unittests/Format/check-coding-style-mozilla.cpp:77 +return mVar; + } // Tiny functions can be written in a single line. + krasimir wrote: > Note that

[PATCH] D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration

sylvestre.ledru added inline comments. Comment at: docs/ClangFormatStyleOptions.rst:430 + If ``true``, in the class inheritance expression clang-format will + break before operands ``:`` and ``,`` only if there is multiple + inheritance. s/is/are/ =

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru added a comment. Manuel, is that ok with you? thanks (I will rename the file) https://reviews.llvm.org/D30111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru added a comment. This isn't about testing individual issues. This is to make sure that the Mozilla coding style remains consistent and we don't regress specific coding style. I found that easy and simple to have a single file to check for the specificities. After https://review

[PATCH] D30532: Add examples to clang-format configuration

sylvestre.ledru created this revision. https://reviews.llvm.org/D30532 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: docs/ClangFormatStyleOptions.rst === --- docs/ClangFormatStyleOptions.rst +++ do

[PATCH] D30532: Add examples to clang-format configuration

sylvestre.ledru added a comment. If you think it makes sense, I will do that for the rest of the options https://reviews.llvm.org/D30532 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D30532: Add examples to clang-format configuration

sylvestre.ledru updated this revision to Diff 90330. sylvestre.ledru marked 3 inline comments as done. https://reviews.llvm.org/D30532 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: docs/ClangFormatStyleOptions.rst ===

[PATCH] D30532: Add examples to clang-format configuration

sylvestre.ledru added inline comments. Comment at: docs/ClangFormatStyleOptions.rst:218 + +#define A \ +int ; \ klimek wrote: > Do we really align these 3 spaces out? nope, bad copy and paste it seems. Sorry Comment at: docs/Cla

[PATCH] D30532: Add examples to clang-format configuration

sylvestre.ledru updated this revision to Diff 90331. sylvestre.ledru added a comment. With the rst generation https://reviews.llvm.org/D30532 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: docs/ClangFormatStyleOptions.rst ==

[PATCH] D30111: [clang-format] Add a test to check at once all the Mozilla coding style

sylvestre.ledru added a comment. > What problem is this addressing, though? Have we frequently changed > formatting in a way that has negatively impacted Mozilla code? We are integrating more clang-format into gecko processes. About the reason, I believed I explained them in the comment above

[PATCH] D30532: Add examples to clang-format configuration

sylvestre.ledru added a comment. I see a lot of values in examples. If I started this review, it is because I was lost in all the options and could not find what I was looking for. If you want, I can update the example to provide results with and without the option. like > With SpacesInCStyle

[PATCH] D30532: Add examples to clang-format configuration

sylvestre.ledru added a comment. > For bool options it seems easiest to do something like: > true: x = ( int32 )y; > false: x = (int32)y; That works for single declarations but for stuff like: > SomeClass::Constructor() > : a(a) > , b(b) > , c(c) {} I won't be

[PATCH] D30532: Add examples to clang-format configuration

sylvestre.ledru updated this revision to Diff 90482. sylvestre.ledru added a comment. With the changes requested by Daniel. This is much better indeed! https://reviews.llvm.org/D30532 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h

[PATCH] D30532: Add examples to clang-format configuration

sylvestre.ledru updated this revision to Diff 90486. sylvestre.ledru added a comment. updated => affected + align the vs https://reviews.llvm.org/D30532 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h =

[PATCH] D30607: Replace re module by regex module in run-clang-tidy script

sylvestre.ledru created this revision. Herald added a subscriber: JDevlieghere. Avoid limitation of 100 groups for regular expressions Patch by Manuel Grizonnet reported here: https://github.com/llvm-mirror/clang-tools-extra/pull/9 https://reviews.llvm.org/D30607 Files: clang-tidy/tool/run-c

[PATCH] D30532: Add examples to clang-format configuration

sylvestre.ledru marked 2 inline comments as done. sylvestre.ledru added a comment. Daniel, it is good for me now. Once it is accepted, I will work on the rest in a separate commit if that is ok with you; https://reviews.llvm.org/D30532 ___ cfe-com

[PATCH] D30734: Add more examples to clang-format configuration

sylvestre.ledru created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D30734 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h === --- include

[PATCH] D30734: Add more examples to clang-format configuration

sylvestre.ledru updated this revision to Diff 91002. sylvestre.ledru added a comment. with the changes, I will land it now https://reviews.llvm.org/D30734 Files: docs/ClangFormatStyleOptions.rst include/clang/Format/Format.h Index: include/clang/Format/Format.h

[PATCH] D30740: Remove a useless subsitution in doxygen2rst which was incorrectly replacing * by \*

sylvestre.ledru created this revision. For example, "int\* a;" is displayed instead of "int* a;" https://reviews.llvm.org/D30740 Files: docs/ClangFormatStyleOptions.rst docs/tools/dump_format_style.py Index: docs/ClangFormatStyleOptions.rst

[PATCH] D30860: Add more examples and fix a bug in the py generation script

sylvestre.ledru created this revision. Herald added a subscriber: klimek. https://reviews.llvm.org/D30860 Files: docs/ClangFormatStyleOptions.rst docs/tools/dump_format_style.py include/clang/Format/Format.h Index: include/clang/Format/Format.h =

[PATCH] D30860: [clang-format] Add more examples and fix a bug in the py generation script

sylvestre.ledru added inline comments. Comment at: docs/tools/dump_format_style.py:67 def __str__(self): -return '* ``%s`` %s' % (self.name, doxygen2rst(self.comment)) +return '\n* ``%s`` %s' % (self.name, doxygen2rst(self.comment)) This is needed to

[PATCH] D30863: [clang-format] make docs/tools/{dump_format_style.py, dump_ast_matchers.py} flake8 compliant

sylvestre.ledru created this revision. no functional changes https://reviews.llvm.org/D30863 Files: docs/tools/dump_ast_matchers.py docs/tools/dump_format_style.py Index: docs/tools/dump_format_style.py === --- docs/tools/dump

[PATCH] D28462: clang-format: Add new style option AlignConsecutiveMacros

sylvestre.ledru added a comment. Any progress on this? Thanks Repository: rL LLVM https://reviews.llvm.org/D28462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D30487: ClangFormat - Add option to break before inheritance separation operator in class declaration

sylvestre.ledru added a comment. Added to the release notes in r297721 Repository: rL LLVM https://reviews.llvm.org/D30487 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29943: [clang-format] Align block comment decorations

sylvestre.ledru added a comment. I did it for you Added to the release notes in r297721 Repository: rL LLVM https://reviews.llvm.org/D29943 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D27557: Update the default of the Mozilla coding style

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: klimek. sylvestre.ledru added a subscriber: cfe-commits. I also proposed the change in Firefox .clang-format file: https://bugzilla.mozilla.org/show_bug.cgi?id=1322321 https://reviews.llvm.org/D27557 Files: lib/Format/Fo

[PATCH] D27557: Update the default of the Mozilla coding style

sylvestre.ledru updated this revision to Diff 81004. sylvestre.ledru added a comment. Keep SpaceAfterTemplateKeyword to true https://reviews.llvm.org/D27557 Files: lib/Format/Format.cpp Index: lib/Format/Format.cpp === --- lib/

[PATCH] D27557: Update the default of the Mozilla coding style

sylvestre.ledru updated this revision to Diff 81005. sylvestre.ledru added a comment. typo https://reviews.llvm.org/D27557 Files: lib/Format/Format.cpp Index: lib/Format/Format.cpp === --- lib/Format/Format.cpp +++ lib/Format/F

[PATCH] D118211: Add missing namespace to PPCLinux.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd71493ff060: Add missing namespace to PPCLinux.cpp (authored by glandium, committed by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHA

[PATCH] D60380: Also document -arch as -arch is mac specific

sylvestre.ledru updated this revision to Diff 405259. sylvestre.ledru added a comment. Take in account Serge's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60380/new/ https://reviews.llvm.org/D60380 Files: clang/docs/CommandGuide/clang.

[PATCH] D60380: Also document -arch as -arch is mac specific

sylvestre.ledru updated this revision to Diff 405262. sylvestre.ledru added a comment. add . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D60380/new/ https://reviews.llvm.org/D60380 Files: clang/docs/CommandGuide/clang.rst Index: clang/docs/Co

[PATCH] D60380: Also document -arch as -arch is mac specific

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb4bb622fc94a: Also document -arch as -arch is mac specific (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

sylvestre.ledru added inline comments. Comment at: clang/docs/ReleaseNotes.rst:177 +* CMake ``-DCLANG_DEFAULT_PIE_ON_LINUX=ON`` is now the default. + This matches GCC installations on many Linux distros. it would be nice to explain what "pie" it is doing :)

[PATCH] D99852: [Driver] Detect libstdc++ include paths for native gcc (-m32 and -m64) on Debian i386

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Many thanks. it fixed my issues! /usr/include/i386-linux-gnu/c++/8 is indeed much nicer :) Thanks for all your hard work on fixing the header detection. it was indeed too co

[PATCH] D99501: ignore -flto= options recognized by GCC

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG162848654842: ignore -flto= options recognized by GCC (authored by sylvestre.ledru). Herald added a project: clang. Herald added a subscriber: cfe-co

[PATCH] D99996: [Driver] Drop $DEFAULT_TRIPLE-$name as a fallback program name

sylvestre.ledru added a comment. To understand better, we will be fixing a bug from 2015, correct? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D6/new/ https://reviews.llvm.org/D6 ___ cfe-commits

[PATCH] D100484: add test case for ignoring -flto=auto and -flto=jobserver

This revision was automatically updated to reflect the committed changes. Closed by commit rG56cb214b38a7: add test case for ignoring -flto=auto and -flto=jobserver (authored by doko, committed by sylvestre.ledru). Herald added a project: clang. Repository: rG LLVM Github Monorepo CHANGES SINC

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

sylvestre.ledru added a comment. I might be wrong but if the ABI is incompatible, are we not supposed to update the SONAME itself? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94941/new/ https://reviews.llvm.org/D94941 __

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

sylvestre.ledru added a comment. Yeah, my question is more "is that enough for distro?" https://www.debian.org/doc/manuals/maint-guide/advanced.en.html https://www.gnu.org/software/libtool/manual/html_node/Updating-version-info.html I might be wrong but if 11.1 and 11.0 aren't compatible (not jus

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Let's do it then :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94941/new/ https://reviews.llvm.org/D94941

[PATCH] D94941: Add minor version to libclang.so and libclang-cpp.so SONAME

sylvestre.ledru added a comment. I guess this will be clearly mentioned in the release notes :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D94941/new/ https://reviews.llvm.org/D94941 ___ cfe-commits ma

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: xbolva00, nathanchance. sylvestre.ledru requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D111215 Files:

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

sylvestre.ledru added a comment. It found a few issues on Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1734285 I think it should be added it in the release notes: https://reviews.llvm.org/D111215 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

sylvestre.ledru updated this revision to Diff 377483. sylvestre.ledru added a comment. Take in account the comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111215/new/ https://reviews.llvm.org/D111215 Files: clang/docs/ReleaseNotes.rst In

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

sylvestre.ledru added a comment. @xbolva00 sorry but you would like -Wbitwise-instead-of-logical (part of -Wbool-operation) warns about use of bitwise with boolean operands which have side effects or -Wbitwise-instead-of-logical (part of -Wbool-operation) warns about use of bitwise with boole

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

sylvestre.ledru updated this revision to Diff 377486. sylvestre.ledru added a comment. add "which have side effects" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111215/new/ https://reviews.llvm.org/D111215 Files: clang/docs/ReleaseNotes.rst

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

This revision was automatically updated to reflect the committed changes. Closed by commit rG9c8f950a0400: clang release notes: document the -Wbool-operation improvement (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111

[PATCH] D111215: clang release notes: document the -Wbool-operation improvement

sylvestre.ledru added a comment. @Quuxplusone fixed, thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111215/new/ https://reviews.llvm.org/D111215 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[PATCH] D105169: [Clang/Test]: Rename enable_noundef_analysis to disable-noundef-analysis and turn it off by default

sylvestre.ledru added a comment. This change caused libclc to fail to build on old ubuntu (using llvm-spir 10.0.0-1) See: https://bugs.llvm.org/show_bug.cgi?id=52200 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105169/new/ https://reviews.llvm.o

[PATCH] D112030: [docs] Remove Makefile.sphinx files

sylvestre.ledru added a comment. I am using them but I can move to sphinx calls. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112030/new/ https://reviews.llvm.org/D112030 ___ cfe-commits mailing list cf

[PATCH] D112030: [docs] Remove Makefile.sphinx files

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. I don't need any time, please land it when you want, I will adjust later :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112030/new/ https://reviews.llvm.org/D112030 ___

[PATCH] D112030: [docs] Remove Makefile.sphinx files

sylvestre.ledru added a comment. Adjustment made on my side: https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/commit/daf38c1634954d9aad7a1393eef0828c57f41a53 @tstellar Maybe you could add this to the release notes? (I think others are probably using it) Repository: rG LLVM Github Mon

[PATCH] D112299: Replace references to Makefile.sphinx

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: tstellar. Herald added a reviewer: aaron.ballman. sylvestre.ledru requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. and fix some typos Repository:

[PATCH] D112299: Replace references to Makefile.sphinx

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfd5e3f36f218: Replace references to Makefile.sphinx (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: tstellar, MaskRay. Herald added a subscriber: mgorny. sylvestre.ledru requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Currently, it is a bit buried in the file even if

[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file

sylvestre.ledru updated this revision to Diff 368126. sylvestre.ledru added a comment. Move the comment too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108533/new/ https://reviews.llvm.org/D108533 Files: clang/tools/libclang/CMakeLists.txt I

[PATCH] D108533: [clang] Move the soname declaration in a variable at the top of the file

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe611b1da84b: [clang] Move the soname declaration in a variable at the top of the file (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D109023: libclang: Document the soname change in the release notes

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: MaskRay, tstellar. sylvestre.ledru requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D109023 Files: cla

[PATCH] D109023: libclang: Document the soname change in the release notes

sylvestre.ledru added a comment. OK, for the variable, I took the liberty then to cherry-pick : https://github.com/llvm/llvm-project/commit/039d1a94b908d786965bf4fd35f9e933ca899719 For the release notes: https://github.com/llvm/llvm-project/commit/d597db1aebf282fa88d4359816f409d164054095 https://

<    1   2   3   4   5   >