[PATCH] D61909: Add Clang shared library with C++ exports

sylvestre.ledru added a comment. ok, it should probably be installed in that case (it is currently in usr/lib/llvm-9/lib/libclang_shared.so.9 ) by the way, the name of lib isn't super explicit :/ Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61909/new/ https://r

[PATCH] D61909: Add Clang shared library with C++ exports

sylvestre.ledru added a comment. @beanz Great doc, thanks! I will see what I could use for Debian/Ubuntu packages (as we have a lot users and packages organized in a specific way, it isn't always easy to make huge changes) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D61909: Add Clang shared library with C++ exports

sylvestre.ledru added inline comments. Comment at: tools/clang-shlib/CMakeLists.txt:8 + +add_clang_library(clang_shared + SHARED can we agree on a different name? we already have licbclang which is a shared library. Maybe libclangcpp.so ? Re

[PATCH] D68260: Decrease the verbosity of the -ftime-trace optionAnd move the relevant information in the doc.

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: anton-afanasyev. Herald added a project: clang. Currently, building a large software like Firefox shows 'Use chrome://tracing or Speedscope App (https://www.speedscope.app) for flamegraph visualization' for each file. Repo

[PATCH] D68260: Decrease the verbosity of the -ftime-trace optionAnd move the relevant information in the doc.

sylvestre.ledru added a comment. thanks :) Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68260/new/ https://reviews.llvm.org/D68260 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-b

[PATCH] D68448: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

sylvestre.ledru added a comment. I don't think I can review that but I do appreciate the feature! Maybe we should make that explicit in the release notes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68448/new/ https://reviews.llvm.org/D68448

[PATCH] D68448: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

sylvestre.ledru added a comment. More dynamic, less static usage :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68448/new/ https://reviews.llvm.org/D68448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D45532: [StaticAnalyzer] Checker to find uninitialized fields after a constructor call

sylvestre.ledru added a comment. If you are interested, I executed this checker on Firefox code. Results can be found here http://sylvestre.ledru.info/reports/fx-scan-build/ Andi reported this bug https://bugs.llvm.org/show_bug.cgi?id=37965 Repository: rC Clang https://reviews.llvm.org/D455

[PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

sylvestre.ledru added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Maybe it could be mentioned in the release notes? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D24243/new/ https://reviews.llvm.org/D24243 __

[PATCH] D24243: [clang-move] A prototype tool for moving class definition to new file.

sylvestre.ledru added a comment. In D24243#1695052 , @sylvestre.ledru wrote: > Maybe it could be mentioned in the release notes? Forget about this comment, I have been distracted by the fact that it is now installed https://reviews.llvm.org/D68423 Re

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

sylvestre.ledru added a comment. @steakhal Thanks for this patch. I tried it on Firefox and it found a bunch of stuff we improved. Some examples: https://hg.mozilla.org/integration/autoland/rev/db24db8f5f549ff446d1c3c69799187bcc2409e2 https://hg.mozilla.org/integration/autoland/rev/5de53dab979a40

[PATCH] D68710: Remove time-trace message as it is inconsistent style

sylvestre.ledru added inline comments. Comment at: clang/include/clang/Driver/Options.td:1797 + HelpText<"Turn on time profiler. Generates JSON file based on output filename. " + "Results can be analyzed with chrome://tracing or `Speedscope App " + "

[PATCH] D68710: Remove time-trace message as it is inconsistent style

sylvestre.ledru added a comment. besides that, I think we should do it; thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68710/new/ https://reviews.llvm.org/D68710 ___ cfe-commits mailing list c

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

sylvestre.ledru added a comment. I added it to the release notes here : https://reviews.llvm.org/rC374593 I am wondering if the option( WarnForDeadNestedAssignments ) to disable it is really necessary? I haven't seen any false positive while deadstore has some. Repository: rL LLVM CHANGES SI

[PATCH] D66733: [analyzer] Add a checker option to detect nested dead stores

sylvestre.ledru added a comment. It now shows for the llvm toolchain: http://llvm.org/reports/scan-build/ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66733/new/ https://reviews.llvm.org/D66733 ___ cfe-commits mailin

[PATCH] D68927: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Thanks It fixed my problem. Maybe you could improve the doc and/or comment to make this behavior more explicit? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68927/

[PATCH] D63932: [GlobalDCE] Dead Virtual Function Elimination

sylvestre.ledru added a comment. @ostannard Maybe you could add that to the release notes? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63932/new/ https://reviews.llvm.org/D63932 ___ cfe-commi

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

sylvestre.ledru added a comment. @MyDeveloperDay I think it should be added to the release notes. it is a great new changes for clang format (it would have made my life at Mozilla much easier ;) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68554/

[PATCH] D68927: [clang-tools-extra] Fix overzealous linking of dylib to clangTidy

sylvestre.ledru added a comment. In that function https://github.com/llvm/llvm-project/blob/5fd467feb813eefe3558da434cb038213582/clang/cmake/modules/AddClang.cmake#L180 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68927/new/ https://reviews.l

[PATCH] D68720: Support -fstack-clash-protection for x86

sylvestre.ledru added a comment. You should also probably document the arg in clang/docs/ClangCommandLineReference.rst we have -fstack-protector-strong & co in the doc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.

[PATCH] D68448: [clang-tools-extra] [cmake] Link against libclang-cpp whenever possible

sylvestre.ledru added a comment. > More dynamic, less static isn't always a good thing. It saves disk space at > the expense of performance. The option that controls this is > `CLANG_LINK_CLANG_DYLIB`, which is mentioned in the clang 9.0 release notes. Sure :) For example, for a full build of l

[PATCH] D68720: Support -fstack-clash-protection for x86

sylvestre.ledru added inline comments. Comment at: clang/docs/ClangCommandLineReference.rst:1901 + +Instrument stack allocation to prevent stack clash attacks. + Maybe add that it is Linux only? :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/ne

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

sylvestre.ledru added a comment. Well done! For Firefox, we decided to go ahead and reformat everything at once. I has been way easier this way. You should run flake8 & autopep8 on your python code. it isn't idomatic Python code (";" are useless on python for example) Commen

[PATCH] D80627: [clang-format] Create a python documentation tool to generate a summary of the clang-format status for the whole of the LLVM project

sylvestre.ledru added inline comments. Comment at: clang/docs/tools/generate_formatted_state.py:48 +if "/test/" in path: +print root +continue print xx is python 2 please use print(xx) Comment at: clang/docs/too

[PATCH] D77458: [clang-tools-extra] NFC: Fix trivial typo in documents and comments

sylvestre.ledru added a comment. Herald added a subscriber: wuzish. You used codespell for this? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77458/new/ https://reviews.llvm.org/D77458 ___ cfe-

[PATCH] D68554: [clang-format] Proposal for clang-format to give compiler style warnings

sylvestre.ledru added a comment. I reported a small issue here: https://bugs.llvm.org/show_bug.cgi?id=45441 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68554/new/ https://reviews.llvm.org/D68554 ___

[PATCH] D77574: [OpenMP] Fix layering problem with FrontendOpenMP

sylvestre.ledru added a comment. @lebedev.ri @jdoerfert Looks like it might have caused: https://bugs.llvm.org/show_bug.cgi?id=45453 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77574/new/ https://reviews.llvm.org/D77574 ___

[PATCH] D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`

sylvestre.ledru added a comment. please add this to the release notes too :) something like "new option -allow-enabling-alpha-checkers added to run-clang-tidy to enable alpha checkers" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77882/new/ https

[PATCH] D77882: [clang-tidy] Add option to use alpha checkers from clang-analyzer when using `run-clang-tidy.py`

sylvestre.ledru added a comment. LGTM! thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77882/new/ https://reviews.llvm.org/D77882 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D77983: clang-tidy doc: add a note for every checker with an autofix

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: alexfh, aaron.ballman. Herald added subscribers: Charusso, arphaman, kbarton, nemanjai. Herald added a project: clang. Currently, when looking at a checker documentation, we have to go back to the whole list or look at the sou

[PATCH] D77983: clang-tidy doc: add a note for every checker with an autofix

sylvestre.ledru updated this revision to Diff 256943. sylvestre.ledru added a comment. 2 spaces instead of 4 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77983/new/ https://reviews.llvm.org/D77983 Files: clang-tools-extra/docs/clang-tidy/checks

[PATCH] D77983: clang-tidy doc: add a note for every checker with an autofix

sylvestre.ledru added a comment. Makes sense. I will give it a try :) thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77983/new/ https://reviews.llvm.org/D77983 ___ cfe-commits mailing list cfe-co

[PATCH] D78052: add_new_check.py: Update of the template to add an autofix section

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: alexfh. Herald added a project: clang. As discussed here: https://reviews.llvm.org/D77983 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D78052 Files: clang-tools-extra/clang-tidy/add_new_check.py Inde

[PATCH] D77983: clang-tidy doc: add a note for every checker with an autofix

sylvestre.ledru updated this revision to Diff 257105. sylvestre.ledru added a comment. Doing it by hand. @alexfh please let me know if you would be ok with it (I will do it by hand) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77983/new/ https://r

[PATCH] D74669: [clang-tidy] New check: bugprone-suspicious-include

sylvestre.ledru added a comment. Firefox uses a unified build model. For better performances in the binary, the C++ files are compiled as the same time from a single file (ex: Unified_cpp_netwerk_base3.cpp) which will include the .cpp files. This isn't a common use case, so, don't hesitate to i

[PATCH] D79895: Add a new warning to warn when passing uninitialized variables as const reference parameters to a function

sylvestre.ledru added a comment. @zequanwu could you please update the release notes? thanks https://github.com/llvm/llvm-project/blob/master/clang/docs/ReleaseNotes.rst Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79895/new/ https://reviews.llvm.

[PATCH] D83386: clang: Don't show a trailing space with --version when not built from the repo

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: thakis, hans. Herald added a project: clang. Reported here: https://bugs.llvm.org/show_bug.cgi?id=38998#c15 Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D83386 Files: clang/lib/Basic/Version.cpp Index

[PATCH] D83386: clang: Don't show a trailing space with --version when not built from the repo

This revision was automatically updated to reflect the committed changes. Closed by commit rGbbea4d5e6b82: clang: Don't show a trailing space with --version when not built from the repo (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revie

[PATCH] D81932: [clang-tidy] Improved accuracy of check list updater script

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Excellent, thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81932/new/ https://reviews.llvm.org/D81932 _

[PATCH] D78052: add_new_check.py: Update of the template to add an autofix section

sylvestre.ledru added a comment. @alexfh ping ? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78052/new/ https://reviews.llvm.org/D78052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D77983: clang-tidy doc: add a note for every checker with an autofix

sylvestre.ledru added a comment. @alexfh ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77983/new/ https://reviews.llvm.org/D77983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D78807: Fix gendered documentation

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78807/new/ https://reviews.llvm.org/D78807 __

[PATCH] D69573: [clang-format] [PR36294] AlwaysBreakAfterReturnType works incorrectly for some operator functions

sylvestre.ledru added a comment. FYI, in Mozilla build of clang-format, we reverted this change. It was causing more issues than fixes. https://bugzilla.mozilla.org/show_bug.cgi?id=1629853 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69573/new/ h

[PATCH] D77983: clang-tidy doc: add a note for every checker with an autofix

sylvestre.ledru added a comment. @alexfh ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77983/new/ https://reviews.llvm.org/D77983 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D78052: add_new_check.py: Update of the template to add an autofix section

sylvestre.ledru added a comment. @alexfh ping ? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78052/new/ https://reviews.llvm.org/D78052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D77983: clang-tidy doc: add a note for every checker with an autofix

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGdc0f79ea5b99: clang-tidy doc: add a note for checkers with an autofix (authored by sylvestre.ledru). Repository: rG LLV

[PATCH] D78052: add_new_check.py: Update of the template to add an autofix section

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGf97f92e5b0fd: add_new_check.py: Update of the template to add an autofix section (authored by sylvestre.ledru). Repositor

[PATCH] D78052: add_new_check.py: Update of the template to add an autofix section

sylvestre.ledru added a comment. has been reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78052/new/ https://reviews.llvm.org/D78052 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D77983: clang-tidy doc: add a note for every checker with an autofix

sylvestre.ledru reopened this revision. sylvestre.ledru added a comment. has been reverted Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77983/new/ https://reviews.llvm.org/D77983 ___ cfe-commits maili

[PATCH] D38124: Hide some symbols to avoid a crash on shutdown when using code coverage

sylvestre.ledru added a comment. @davidxl David, is that ok with you? Can you sign off this change? Thanks https://reviews.llvm.org/D38124 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

sylvestre.ledru created this revision. Reported here: http://bugs.debian.org/882505 Patch by Andreas Beckmann https://reviews.llvm.org/D40453 Files: lib/Driver/ToolChains/Cuda.cpp Index: lib/Driver/ToolChains/Cuda.cpp === ---

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

sylvestre.ledru added a comment. Debian packages don't update the PATH and we are aiming at providing packages working out of the box. In general, yeah, we have to do that for every distros... :/ https://reviews.llvm.org/D40453 ___ cfe-commits mai

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

sylvestre.ledru updated this revision to Diff 124629. https://reviews.llvm.org/D40453 Files: lib/Driver/ToolChains/Cuda.cpp Index: lib/Driver/ToolChains/Cuda.cpp === --- lib/Driver/ToolChains/Cuda.cpp +++ lib/Driver/ToolChains/Cu

[PATCH] D40453: Add the nvidia-cuda-toolkit Debian package path to search path

sylvestre.ledru updated this revision to Diff 124636. https://reviews.llvm.org/D40453 Files: lib/Driver/ToolChains/Cuda.cpp Index: lib/Driver/ToolChains/Cuda.cpp === --- lib/Driver/ToolChains/Cuda.cpp +++ lib/Driver/ToolChains/Cu

[PATCH] D133771: Add a "Potentially Breaking Changes" section to the Clang release notes

sylvestre.ledru added inline comments. Comment at: clang/docs/ReleaseNotes.rst:49 + present in major C++ implementations (including Clang), this error has the + ability to be downgraded into a warning (via: -Wno-error=enum-constexpr-conversion) + to provide a transition perio

[PATCH] D114099: Enable `_Float16` type support on X86 without the avx512fp16 flag

sylvestre.ledru added a comment. Herald added a subscriber: jsji. Herald added a project: All. @zahiraam Sorry, i missed your questions > But I see in the command above that it is compiling with > -DCOMPILER_RT_HAS_FLOAT16. @sylvestre.ledru is this flag really supposed to > be on? dunno, I gu

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

sylvestre.ledru added a comment. Same as in https://reviews.llvm.org/D114099 It breaks the build on ubuntu bionic, Hirsute, etc on amd64: "/build/llvm-toolchain-snapshot-15~++20220702091600+23ee84f43201/build-llvm/./bin/clang" --target=x86_64-pc-linux-gnu -DVISIBILITY_HIDDEN -fstack-protecto

[PATCH] D129049: [clang] Fix gcc-6 compilation error. (NFC)

sylvestre.ledru added a comment. thanks I will retrigger the CI Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129049/new/ https://reviews.llvm.org/D129049 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D107082: [X86][RFC] Enable `_Float16` type support on X86 following the psABI

sylvestre.ledru added a comment. @pengfei I am not convinced it is an issue on my side. I don't have anything particular in this area and using a stage2 build system. Anyway, this patch fixes the issue on my side: https://salsa.debian.org/pkg-llvm-team/llvm-toolchain/-/blob/snapshot/debian/patch

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

sylvestre.ledru added a comment. Same, it broke apt.llvm.org It is installing some of the libs in debian/tmp/libgomp.so instead of debian/tmp/usr/lib/llvm-15/lib/libgomp.so I think it should be indeed revert (and in the branch 15 too) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D131307: [Clang] Allow downgrading to a warning the diagnostic for setting a non fixed enum to a value outside the range of the enumeration values

sylvestre.ledru added a comment. We have this error in OpenMP: https://github.com/llvm/llvm-project/issues/57022 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131307/new/ https://reviews.llvm.org/D131307 ___

[PATCH] D99081: [clang-tidy] ensure run-clang-tidy reports children killed by signals

sylvestre.ledru added a comment. Oh, I missed your message. I can land it for you, ok? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99081/new/ https://reviews.llvm.org/D99081 ___ cfe-commits mailing lis

[PATCH] D99081: [clang-tidy] ensure run-clang-tidy reports children killed by signals

This revision was automatically updated to reflect the committed changes. Closed by commit rGf6ba03584b3c: [clang-tidy] ensure run-clang-tidy reports children killed by signals (authored by ijc, committed by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D105527: libclang.so: Make SONAME independent from LLVM version

sylvestre.ledru added a comment. As this is a big deal for packager, maybe it should be part of the release notes ? (maybe it is and I just missed it :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105527/new/ https://reviews.llvm.org/D105527 __

[PATCH] D7982: [clang-tidy] Add readability-duplicate-include check

sylvestre.ledru added a comment. Thanks for this, it found 74 occurrences of this in the firefox code base https://hg.mozilla.org/mozilla-central/rev/b07f125d09fd Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7982/new/ https://reviews.llvm.org/D798

[PATCH] D110663: [Driver] Support Debian multiarch style lib/clang/14.0.0/x86_64-linux-gnu runtime path and include/x86_64-linux-gnu/c++/v1 libc++ path

sylvestre.ledru added a comment. Could you please stop with the pings? and chat directly ? (It seems that you are colleagues?!) I would like to follow what is happening here but not get flooded. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110663

[PATCH] D66792: [ReleaseNotes] MemorySanitizer support of ASLR on FreeBSD

sylvestre.ledru accepted this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. Looks good, thanks Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66792/new/ https://reviews.llvm.org/D66792 __

[PATCH] D64666: [Sema] Enable -Wimplicit-int-float-conversion for integral to floating point precision loss

sylvestre.ledru added a comment. FYI, it found a bunch of new warnings in Firefox: https://bugzilla.mozilla.org/show_bug.cgi?id=1577236 https://bugzilla.mozilla.org/show_bug.cgi?id=1577051 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.ll

[PATCH] D64666: [Sema] Enable -Wimplicit-int-float-conversion for integral to floating point precision loss

sylvestre.ledru added a comment. @ziangwan maybe you should add this improvement to the release notes, wdyt? Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64666/new/ https://reviews.llvm.org/D64666 ___ cfe-commits mai

[PATCH] D66042: [analyzer] Analysis: Silence checkers

sylvestre.ledru added a comment. @Charusso This probably should be added to the release notes: https://clang.llvm.org/docs/ReleaseNotes.html#static-analyzer and detailed in the doc. Please let me know if you need help! Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru created this revision. Herald added subscribers: xazax.hun, JDevlieghere. In the current list http://clang.llvm.org/extra/clang-tidy/checks/list.html it is hard to know which one has autofix or not. This isn't perfect because we will have to list but I haven't found a better way.

[PATCH] D36051: [clang-tidy] List the checkers with autofix

sylvestre.ledru added a comment. Good ideas guys. I will try to update list.rst to a table with the extra information. https://reviews.llvm.org/D36051 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/lis

[PATCH] D34824: clang-format: add an option -verbose to list the files being processed

sylvestre.ledru reopened this revision. sylvestre.ledru added a comment. This revision is now accepted and ready to land. actually, arc commit never landed this change :( https://reviews.llvm.org/D34824 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

sylvestre.ledru added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:66 bugprone-posix-return + bugprone-signed-char-misuse bugprone-sizeof-container list.rst has changed, you should try to rebase your patch! Repositor

[PATCH] D71963: clang-tidy doc: Add the severities description

sylvestre.ledru created this revision. sylvestre.ledru added reviewers: dkrupp, aaron.ballman. Herald added subscribers: rnkovacs, whisperity. Herald added a project: clang. I took the text from codechecker. Daniel Krupp ( @dkrupp ) wrote it. Repository: rG LLVM Github Monorepo https://review

[PATCH] D70265: [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines

sylvestre.ledru added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:198 cppcoreguidelines-avoid-magic-numbers (redirects to readability-magic-numbers) + cppcoreguidelines-avoid-non-const-global-variables cppcoreguidelines-c-copy-assign

[PATCH] D70265: [clang-tidy] Add clang tidy check I.2 to cppcoreguidelines

sylvestre.ledru added inline comments. Comment at: clang-tools-extra/docs/clang-tidy/checks/list.rst:411 * + cppcoreguidelines-avoid-non-const-global-variables + It should not be there. It won't be referenced on the list. If you are uncomfortable setting a

[PATCH] D71963: clang-tidy doc: Add the severities description

sylvestre.ledru added a comment. I do agree that they are subjective and not perfect. However, I found the classification extremely useful when you look at the results on big projects. I have been using codechecker (where the severities are coming from) for Firefox and its has been extremely us

[PATCH] D69758: [Gnu toolchain] Look at standard GCC paths for libstdcxx by default

sylvestre.ledru requested changes to this revision. sylvestre.ledru added a comment. This revision now requires changes to proceed. //[Gnu toolchain] // maybe this can be removed in the title? Comment at: clang/lib/Driver/ToolChains/Linux.cpp:36 /// /// Debian-based systems a

[PATCH] D36051: Move from a long list of checkers to tables

sylvestre.ledru added a comment. @malcolm.parsons really? Oh, where is it implemented? https://github.com/llvm/llvm-project/blob/61504079515f76ca094bb836c4d53b41064220d6/clang-tools-extra/clang-tidy/modernize/MakeUniqueCheck.cpp I didn't see it here Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D36051: Move from a long list of checkers to tables

sylvestre.ledru added a comment. Thanks. Fixed in https://github.com/llvm/llvm-project/commit/e8c9110b56b516a22b41e95e347bc141814ab87c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D36051/new/ https://reviews.llvm.org/D36051

[PATCH] D71963: clang-tidy doc: Add the severities description

sylvestre.ledru added a comment. > I may have missed this in prior discussions, and if so, I'm sorry -- but why > are we taking CodeChecker as the model for this? I went ahead and use it because: - it is there and maintained (I contributed to the list a few time) - it is pretty good from my exp

[PATCH] D71963: clang-tidy doc: Add the severities description

sylvestre.ledru added a comment. OK, do you want me to prepare a patch to remove the severities? or to update the values using another list? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71963/new/ https://reviews.llvm.org/D71963 ___

[PATCH] D71963: clang-tidy doc: Add the severities description

sylvestre.ledru abandoned this revision. sylvestre.ledru added a comment. ok, thanks! I will remove them tomorrow or the next day. Do you have any guidance about the next steps to add them back? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71963/n

[PATCH] D72049: clang-tidy doc: Remove severities as they don't make consensus

sylvestre.ledru created this revision. Herald added subscribers: cfe-commits, whisperity. Herald added a reviewer: jdoerfert. Herald added a project: clang. sylvestre.ledru added a reviewer: aaron.ballman. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D72049 Files: clang-tools

[PATCH] D71963: clang-tidy doc: Add the severities description

sylvestre.ledru added a comment. @aaron.ballman done in https://reviews.llvm.org/D72049 By the way, when you say: > There are other models that exist and are maintained. > Other models are also pretty good. which lists do you have in mind? thanks Repository: rG LLVM Github Monorepo CHAN

[PATCH] D72049: clang-tidy doc: Remove severities as they don't make consensus

This revision was automatically updated to reflect the committed changes. Closed by commit rG773667b8c20d: clang-tidy doc: Remove severities as they don't make consensus (authored by sylvestre.ledru). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D720

[PATCH] D72217: [clang-tidy] Added readability-qualified-auto check

sylvestre.ledru added a comment. In D72217#1804533 , @njames93 wrote: > side note when creating this, the add_new_check.py file hasn't been updated > in relation to this commit > https://github.com/llvm/llvm-project/commit/d2c9c9157b0528436d3b9f5e22c872f

[PATCH] D72421: Refresh the add_new_check.py now that we use a table + autofix

sylvestre.ledru created this revision. sylvestre.ledru added a reviewer: alexfh. Herald added a subscriber: mgorny. Herald added a project: clang. sylvestre.ledru updated this revision to Diff 236922. sylvestre.ledru added a comment. sylvestre.ledru updated this revision to Diff 236923. remove art

[PATCH] D72421: Refresh the add_new_check.py now that we use a table + autofix

sylvestre.ledru updated this revision to Diff 236922. sylvestre.ledru added a comment. remove artifcats Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72421/new/ https://reviews.llvm.org/D72421 Files: clang-tools-extra/clang-tidy/add_new_check.py

[PATCH] D72421: Refresh the add_new_check.py now that we use a table + autofix

sylvestre.ledru updated this revision to Diff 236923. sylvestre.ledru added a comment. arf, arc.. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72421/new/ https://reviews.llvm.org/D72421 Files: clang-tools-extra/clang-tidy/add_new_check.py Inde

[PATCH] D72421: Refresh the add_new_check.py now that we use a table + autofix

sylvestre.ledru updated this revision to Diff 236924. sylvestre.ledru added a comment. Fix some rst warnings Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72421/new/ https://reviews.llvm.org/D72421 Files: clang-tools-extra/clang-tidy/add_new_che

[PATCH] D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix

sylvestre.ledru added a comment. It finds some stuff that I missed in the list :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72421/new/ https://reviews.llvm.org/D72421 ___ cfe-commits mailing list c

[PATCH] D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix

sylvestre.ledru added a comment. > Thanks for this, Also how would you feel about adding a parameter to the > script that could create alias definitions in much the same way? Do you have more details about your expectation? I could have a look but in a separate commit :) Repository: rG LLVM

[PATCH] D71082: Allow system header to provide their own implementation of some builtin

sylvestre.ledru added a comment. @serge-sans-paille any blocker for this to land? Would be great to have it in version 10. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71082/new/ https://reviews.llvm.org/D71082 _

[PATCH] D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix

sylvestre.ledru marked 5 inline comments as done. sylvestre.ledru added inline comments. Comment at: clang-tools-extra/clang-tidy/add_new_check.py:372 +f.write(' :header: "Name", "Offers fixes"\n') +f.write(' :widths: 50, 20\n\n') f.writelines(checks)

[PATCH] D72421: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix

This revision was automatically updated to reflect the committed changes. Closed by commit rGc348a2674b57: [clang-tidy] Refresh the add_new_check.py now that we use a table + autofix (authored by sylvestre.ledru). Changed prior to commit: https://reviews.llvm.org/D72421?vs=236924&id=237178#toc

[PATCH] D68720: Support -fstack-clash-protection for x86

sylvestre.ledru added a comment. @craig.topper do you think there is a chance that this change could be part of clang-10 ? Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/ https://reviews.llvm.org/D68720 _

[PATCH] D71174: [clang-tidy] new check: bugprone-signed-char-misuse

sylvestre.ledru added a comment. In D71174#1774249 , @ztamas wrote: > I run the new check on LibreOffice codebase with the option > CharTypdefsToIgnore = "sal_Int8". > The check produced 32 findings. Interesting. It found 31 issues on the Firefox code

[PATCH] D81272: [clang-tidy] New check `bugprone-redundant-branch-condition`

sylvestre.ledru added a comment. Thanks for this checker. FYI, it found (at least) 3 defects in Firefox code: https://hg.mozilla.org/mozilla-central/rev/651e68f628d0 https://bugzilla.mozilla.org/show_bug.cgi?id=1664747 (unlikely that it was causing any actual bugs in the product) Repository:

<    1   2   3   4   5   >