[PATCH] D51021: ABI-Testsuite: Force the old c++11 ABI in mangling/test.xpp

Sunil_Srivastava accepted this revision. Sunil_Srivastava added a comment. This revision is now accepted and ready to land. LGTM Repository: rT test-suite https://reviews.llvm.org/D51021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[PATCH] D46836: Fix some rtti-options tests

Sunil_Srivastava created this revision. Herald added a subscriber: cfe-commits. Certain tests in rtti-options.cpp are not really testing anything because they are testing for the absence of -frtti option to the cc1 process. Since the cc1 process does not take -frtti option, these tests are passi

[PATCH] D46982: Do not enable RTTI with -fexceptions, for PS4

Sunil_Srivastava created this revision. Sunil_Srivastava added a reviewer: filcab. Herald added a subscriber: cfe-commits. NFC for targets other than PS4. This patch is a change in behavior for PS4, in that PS4 will no longer enable RTTI when -fexceptions is specified (RTTI and Exceptions are dis

[PATCH] D47291: Proposal to make rtti errors more generic.

Sunil_Srivastava created this revision. Herald added a subscriber: cfe-commits. This patch changes the wording of two errors to make them more generic. An attempt to use dynamic_cast while rtti is disabled, curently emits the error: cannot use dynamic_cast with -fno-rtti and a similar one for

[PATCH] D47291: Proposal to make rtti errors more generic.

Sunil_Srivastava added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729 def err_no_dynamic_cast_with_fno_rtti : Error< - "cannot use dynamic_cast with -fno-rtti">; + "use of dynamic_cast requires enabling RTTI">; probinson wrote:

[PATCH] D47291: Proposal to make rtti errors more generic.

Sunil_Srivastava added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:6729 def err_no_dynamic_cast_with_fno_rtti : Error< - "cannot use dynamic_cast with -fno-rtti">; + "use of dynamic_cast requires enabling RTTI">; wristow wrote: >

[PATCH] D47291: Proposal to make rtti errors more generic.

Sunil_Srivastava updated this revision to Diff 150038. Sunil_Srivastava added a comment. Changed as per Paul's suggestion. https://reviews.llvm.org/D47291 Files: include/clang/Basic/DiagnosticSemaKinds.td test/SemaCXX/no-rtti.cpp Index: test/SemaCXX/no-rtti.cpp ===

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava created this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We wish to disable most calling convention attributes for PS4, allowing just cdecl (and the equivalent sysv_abi on PS4), which are default. Repository: rC Clang https://reviews.llvm

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava removed reviewers: wristow, rnk, rjmccall. Sunil_Srivastava marked an inline comment as done. Sunil_Srivastava added inline comments. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:2961 +def error_cconv_unsupported : Error< + "%0 calling convention not s

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava marked an inline comment as done. Sunil_Srivastava added inline comments. Comment at: test/Sema/no_callconv.cpp:1 +// RUN: %clang_cc1 %s -triple x86_64-scei-ps4 -DPS4 -fsyntax-only -verify +// RUN: %clang_cc1 %s -triple x86_64-unknown-linux-gnu -fsyntax-only -ver

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava added a comment. Pre-commit to change the wording and ID of warn_cconv_ignore has gone in in r366368. I will be shortly updating this review to account for that, and for other points raised here. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava updated this revision to Diff 210674. Sunil_Srivastava added a comment. - Adapted suggestion from Ried. - Cleaned up line ending and properties of the test case. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64780/new/ https://reviews.llvm.org/D64780 Files: include/c

[PATCH] D64780: Disallow most calling convention attributes on PS4.

Sunil_Srivastava marked an inline comment as done. Sunil_Srivastava added inline comments. Comment at: lib/Basic/Targets/OSTargets.h:564 } + TargetInfo::CallingConvCheckResult checkCallingConvention(CallingConv CC) const override { +return (CC == CC_C) ? TargetInfo::CCCR

[PATCH] D129404: Change default C dialect for PS5 to gnu17/gnu18.

Sunil_Srivastava created this revision. Sunil_Srivastava added reviewers: probinson, wristow. Herald added a project: All. Sunil_Srivastava requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://revie

[PATCH] D129404: Change default C dialect for PS5 to gnu17/gnu18.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa844378b2bc2: Change default C dialect for PS5 to gnu17/gnu18. (authored by Sunil_Srivastava). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D129404/new/ htt

[PATCH] D86649: Fix for assertion failure on PR46865

Sunil_Srivastava created this revision. Sunil_Srivastava added reviewers: rsmith, erichkeane. Herald added a project: clang. Herald added a subscriber: cfe-commits. Sunil_Srivastava requested review of this revision. This is a proposed fix for the crash of PR46865. Repository: rG LLVM Github M

[PATCH] D155998: Set default C++ level for Playstation to C++17.

Sunil_Srivastava created this revision. Herald added a project: All. Sunil_Srivastava requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D155998 Files: clang/lib/Basic/LangStan

[PATCH] D155998: Set default C++ level for PlayStation(r) to C++17.

Sunil_Srivastava updated this revision to Diff 543088. Sunil_Srivastava added a comment. Deleted Sie specific test, now that the behavior is same as the default. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155998/new/ https://reviews.llvm.org/D155998 Files: clang/lib/Basic/LangStan

[PATCH] D22057: Prevent devirtualization of calls to un-instantiated functions.

Sunil_Srivastava added a comment. Ping https://reviews.llvm.org/D22057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D22057: Prevent devirtualization of calls to un-instantiated functions.

Sunil_Srivastava added a comment. A friendly ping. https://reviews.llvm.org/D22057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D94438: Fis for Assertion failure on dependent expression.

Sunil_Srivastava created this revision. Sunil_Srivastava added reviewers: jstenglein, erichkeane. Sunil_Srivastava requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The check for the value passed to __buildtin_return_address needs to be guard

[PATCH] D94438: Fis for Assertion failure on dependent expression.

Sunil_Srivastava marked an inline comment as done. Sunil_Srivastava added inline comments. Comment at: clang/test/Sema/builtin-returnaddress.c:3 // RUN: %clang_cc1 -fsyntax-only -Wmost -verify %s +// RUN: %clang_cc1 -x c++ -fsyntax-only -Wframe-address -verify %s +// RUN: %clang

[PATCH] D94438: Fis for Assertion failure on dependent expression.

This revision was automatically updated to reflect the committed changes. Sunil_Srivastava marked an inline comment as done. Closed by commit rGf706486eaf07: Fix for crash in __builtin_return_address in template context. (authored by Sunil_Srivastava). Changed prior to commit: https://reviews.l