[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

steven_wu added inline comments. Comment at: clang/lib/CodeGen/CodeGenAction.cpp:164 LLVMIRGenerationRefCount(0), - Gen(CreateLLVMCodeGen(Diags, InFile, std::move(FS), HeaderSearchOpts, -PPOpts, CodeGenOpts, C, CoverageInfo)), +

[PATCH] D139052: [NFC][Profile] Access profile through VirtualFileSystem

steven_wu added inline comments. Comment at: clang/lib/Frontend/CompilerInvocation.cpp:1729 + if (!Opts.ProfileInstrumentUsePath.empty()) { +auto FS = llvm::vfs::getRealFileSystem(); +setPGOUseInstrumentor(Opts, Opts.ProfileInstrumentUsePath, *FS, Diags); ---

[PATCH] D131858: [clang] Track the templated entity in type substitution.

steven_wu added a comment. > Can you tell if this has been fixed by > https://github.com/llvm/llvm-project/commit/303f20a2cab4554a10ec225fd853709146f8c51c > ? I can still reproduce this with latest commit. It is not fixed. At least it can easily reproduce on Darwin platform with bootstrap (sta

[PATCH] D139956: Workaround an assertion failure during module build

steven_wu created this revision. steven_wu added reviewers: mizvekov, arphaman. Herald added a subscriber: ributzka. Herald added a project: All. steven_wu requested review of this revision. Herald added a project: LLVM. After the change in https://reviews.llvm.org/D131858, clang cannot bootstrap

[PATCH] D139956: Workaround an assertion failure during module build

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe77e14ecf17b: Workaround an assertion failure during module build (authored by steven_wu). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D131858: [clang] Track the templated entity in type substitution.

steven_wu added a comment. The workaround in https://reviews.llvm.org/D139956 can get llvm-project bootstrap correctly, doesn't fix the underlying issue. The new failures is in building `SupportTests` where it issues a weird warning followed by missing symbol. It might be related to this commit

[PATCH] D140164: [clang/Lexer] Enhance `Lexer::getImmediateMacroNameForDiagnostics` to return a result from non-file buffers

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Lex/Lexer.cpp:1050 - // If the macro's spelling has no FileID, then it's actually a token paste - // or stringization (or similar) and no

[PATCH] D29065: Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly().

steven_wu added a comment. I think you should add a new API for embedBitcodeMarkerEnabled() or revert the name the APIs to before https://reviews.llvm.org/rL287084. https://reviews.llvm.org/D29065 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D29066: Forward -bitcode_process_mode to ld64 in marker-only mode

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D29066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo

[PATCH] D29065: Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly().

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. Depending on how you look at the previous commit, you can think that as a new API or just rename the old API. I actually dont think there is too much issue names. Plz go ahead. https:/

[PATCH] D29065: Split isUsingLTO() outside of embedBitcodeInObject() and embedBitcodeMarkerOnly().

steven_wu added a comment. Sorry I just notice that when I look at driver today. Comment at: cfe/trunk/lib/Driver/Tools.cpp:6464 if (C.getDriver().isSaveTempsEnabled() && - !C.getDriver().embedBitcodeInObject() && isa(JA)) + !C.getDriver().embedBitcodeInObject() &&

[PATCH] D100405: Ship `llvm-cxxfilt` in the toolchain.

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100405/new/ https://reviews.llvm.org/D100405 _

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

steven_wu added a comment. I don't know enough about Dwarf unwinding but the implementation looks generally good. Can you please add a testcase indicating how ORCJIT is planning to use it? Comment at: libunwind/src/DwarfParser.hpp:158 + FDE_Info

[PATCH] D111863: [libunwind] Add an interface for dynamic .eh_frame registration

steven_wu added a comment. In D111863#3071328 , @housel wrote: > In D111863#3069279 , @lhames wrote: > >> I think the ORC runtime provides a much more natural way to test this. Did >> you manage to come up with s

[PATCH] D108881: [clang][driver] Honor the last -flto= flag even if an earlier -flto is present

steven_wu added a comment. I agree that it might be good to change to the behavior that last arg wins but it might be simpler to set `-flto` to be an alias of `-flto=full`: diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index 1a3d1dcceec7..a796fb7

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

steven_wu added a comment. I will do a cleanup of `parseLTOMode` function since we don't need a `OptPos` parameter anymore. There are few minor places references `OPT_flto` or `OPT_foffload_lto` can be cleaned up too. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

steven_wu added a comment. In D108881#2973719 , @mnadeem wrote: > In D108881#2973516 , @steven_wu > wrote: > >> I will do a cleanup of `parseLTOMode` function since we don't need a >> `OptPos` parameter anymore.

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

steven_wu added a comment. In D108881#2987990 , @mnadeem wrote: > In D108881#2973735 , @steven_wu > wrote: > >> In D108881#2973719 , @mnadeem >> wrote: >> >>> In D108881

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

steven_wu added a comment. If you didn't quite get what I mean, I am suggesting to cleanup all the reference to the old flag. Since `-flto` is rewrite by the driver to `-flto=full`, clang should not query `OPT_flto` anymore. All references to the old flag needs to be audited and removed while p

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

steven_wu added a comment. In D108881#2988026 , @tejohnson wrote: > In D108881#2988016 , @steven_wu > wrote: > >> In D108881#2987990 , @mnadeem >> wrote: >> >>> In D1088

[PATCH] D108881: [clang][driver] Honor the last -flto(=.*)? argument

steven_wu accepted this revision. steven_wu added a comment. This revision is now accepted and ready to land. I am not familiar with offloading side of LTO driver but the change looks functionally the same to me. Thanks for doing this! Remember to update the commit message with the correct info.

<    1   2   3