[PATCH] D69620: Add AIX assembler support

stevewan marked 4 inline comments as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:28 + const char *LinkingOutput) const { + claimNoWarnArgs(Args); + ArgStringList CmdArgs; Xiangling_L wro

[PATCH] D69620: Add AIX assembler support

stevewan updated this revision to Diff 230360. stevewan marked an inline comment as done. stevewan added a comment. Add "-u" to accept undefined symbol as extern. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69620/new/ https://reviews.llvm.org/D69

[PATCH] D69620: Add AIX assembler support

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:28 + const char *LinkingOutput) const { + claimNoWarnArgs(Args); + ArgStringList CmdArgs; stevewan wrote:

[PATCH] D69620: Add AIX assembler support

stevewan updated this revision to Diff 231000. stevewan marked 12 inline comments as done. stevewan added a comment. Remove claimNoWarnArgs, limit the number of input files, and add more comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69620/

[PATCH] D69620: Add AIX assembler support

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:28 + const char *LinkingOutput) const { + claimNoWarnArgs(Args); + ArgStringList CmdArgs; stevewan wrote:

[PATCH] D69620: Add AIX assembler support

stevewan updated this revision to Diff 231557. stevewan added a comment. Correct a typo in a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69620/new/ https://reviews.llvm.org/D69620 Files: clang/lib/Driver/ToolChains/AIX.cpp clang/lib

[PATCH] D69620: Add AIX assembler support

stevewan updated this revision to Diff 231579. stevewan added a comment. Herald added subscribers: kbarton, nemanjai. Add more input file handling 1. Check if the input file is of type Filename or Nothing, throw assertion otherwise. 2. Add a test case to verify the correct behaviour of assembler

[PATCH] D69620: Add AIX assembler support

stevewan marked 3 inline comments as done. stevewan added inline comments. Comment at: clang/lib/Driver/ToolChains/AIX.cpp:68 + if (Inputs.size() != 1) +llvm_unreachable("Invalid number of input files."); + const InputInfo &II = Inputs[0]; hubert.reinterpre

[PATCH] D69620: Add AIX assembler support

stevewan updated this revision to Diff 231712. stevewan added a comment. State in the comment the expectation to driver in handling assembler source input when invoking as(1). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69620/new/ https://review

[PATCH] D74015: [AIX][Frontend] C++ ABI customizations for AIX boilerplate

stevewan added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:520 + +class XLClangCXXABI final : public ItaniumCXXABI { +public: The class name here is inconsistent with how our ABI kind was called previously, as David pointed out. Maybe rename

[PATCH] D72736: [AIX] Add improved interface for retrieving load module paths

stevewan added a comment. Provided that you have squashed all changes into the latest commit in your branch, `git diff HEAD^ -U1` should emit the context you need. Adjust the number of lines of context accordingly to fit the size of your files. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D118152: [clang][deps] Adapt test to be compatible when the assembler is called by default

stevewan added inline comments. Comment at: clang/test/ClangScanDeps/headerwithdirname.cpp:16 -// CHECK: headerwithdirname_input.o +// CHECK: headerwithdirname_input{{.*}}{{.o|.s}} // CHECK-NEXT: headerwithdirname_input.cpp Jake-Egan wrote: > jansvoboda11 wrot

[PATCH] D118477: [NFC][AIX]Disable new pcm tests on AIX

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Same as D114481 , the PCH reader looks for a `__clangast` section in the precompiled module file, which isn't presen

[PATCH] D118477: [NFC][AIX]Disable new pcm tests on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG760e69223d83: [NFC][AIX]Disable new pcm tests on AIX (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. These tests emit unexpected diagnostics on AIX because the byval alignment warning is emitted too aggressively. https://reviews.llvm.org/D118350 is s

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

stevewan updated this revision to Diff 404947. stevewan added a comment. Use "-Wno-aix-compat" so that we don't lose coverage on AIX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118670/new/ https://reviews.llvm.org/D118670 Files: clang/test/Ana

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

stevewan updated this revision to Diff 404951. stevewan added a comment. Add the flag to all Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118670/new/ https://reviews.llvm.org/D118670 Files: clang/test/Analysis/padding_c.c clang/test/Analysis/

[PATCH] D118670: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG245b8e5691ed: [NFC][AIX]Disable failed tests due to aggressive byval alignment warning on AIX (authored by stevewan). Repository: rG LLVM Github M

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 367833. stevewan added a comment. Address comments about the check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/RecordLayoutBuilder.cpp c

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1975 + bool AlignAttrCanDecreaseAlignment = + AlignIsRequired && (Ty->getAs() != nullptr || FieldPacked); + rjmccall wrote: > Okay, so first off, the comment and variable name

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 367875. stevewan added a comment. De-Morgan-ize if condition for readability Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/RecordLayoutBuild

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 367942. stevewan added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/RecordLayoutBuilder.cpp clang/test/Layout/aix-ali

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 368702. stevewan added a comment. Herald added a subscriber: jfb. Add recursive check for typedef Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan marked 2 inline comments as done. stevewan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1975 + bool AlignAttrCanDecreaseAlignment = + AlignIsRequired && (Ty->getAs() != nullptr || FieldPacked); + rjmccall wrote: > stevew

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 368716. stevewan marked an inline comment as done. stevewan added a comment. Avoid unannotated fall-through between cases Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369157. stevewan added a comment. Make TypeInfo carry more information about "aligned" attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/inclu

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan marked an inline comment as done. stevewan added inline comments. Comment at: clang/lib/AST/RecordLayoutBuilder.cpp:1984 +auto checkTypeIsTypedef = [](auto &&checkTypeIsTypedef, + const auto Ty) -> bool { + bool isTypedef = false;

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369163. stevewan marked an inline comment as done. stevewan added a comment. Cleanup the condition check Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: cla

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369164. stevewan added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTContext.c

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369177. stevewan added a comment. Fix missing "&&" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTC

[PATCH] D108858: TypeInfo records more information about align requirement

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Extend the information preserved in `TypeInfo` by replacing the `AlignIsRequired` bool flag with a three-valued enum, the enum also indicates where the

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan added a comment. In D107394#2970326 , @rjmccall wrote: > Please add me to the review for the other patch and I'll approve it pretty > quickly, and then we can get back to this one. Sorry for the delay. Posted https://reviews.llvm.org/D108858, o

[PATCH] D108858: TypeInfo records more information about align requirement

stevewan updated this revision to Diff 369235. stevewan added a comment. Oops missed one flag. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108858/new/ https://reviews.llvm.org/D108858 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST

[PATCH] D108858: TypeInfo records more information about align requirement

stevewan updated this revision to Diff 369240. stevewan added a comment. Fix enum usage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108858/new/ https://reviews.llvm.org/D108858 Files: clang/include/clang/AST/ASTContext.h clang/lib/AST/ASTCon

[PATCH] D108858: TypeInfo records more information about align requirement

stevewan updated this revision to Diff 369258. stevewan added a comment. Add RequiredByEnum case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108858/new/ https://reviews.llvm.org/D108858 Files: clang/include/clang/AST/ASTContext.h clang/lib/A

[PATCH] D108858: TypeInfo records more information about align requirement

This revision was automatically updated to reflect the committed changes. Closed by commit rG73733ae526a5: TypeInfo records more information about align requirement (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108858/new/ ht

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369293. stevewan added a comment. Adapt to new TypeInfo design Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/ASTContext.cpp clang/lib/AST/

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

stevewan updated this revision to Diff 369319. stevewan added a comment. Rename lambda and add comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https://reviews.llvm.org/D107394 Files: clang/lib/AST/RecordLayoutBuilder.cpp cla

[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

This revision was automatically updated to reflect the committed changes. Closed by commit rG71b170ccf36e: [AIX] "aligned" attribute does not decrease alignment (authored by stevewan). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107394/new/ https:

[PATCH] D109387: [AIX] Check for typedef properly when getting preferred type align

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. The current check for typedef is naive and doesn't deal with any convoluted cases. This patch makes use of the new 'AlignRequirement' enum field from

[PATCH] D109387: [AIX] Check for typedef properly when getting preferred type align

stevewan added a comment. In D109387#2987780 , @rjmccall wrote: > LGTM, except it's missing tests. Thanks. This is an NFC patch, the tests added in https://reviews.llvm.org/D107598 should still suffice IMHO. Repository: rG LLVM Github Monorepo CHAN

[PATCH] D109387: [NFC][AIX] Check for typedef properly when getting preferred type align

stevewan added a comment. In D109387#2987843 , @rjmccall wrote: > Oh, no, I don't think this is NFC. It seems very likely that there's some > case where the behavior is distinguishable. Maybe a typedef of a record with > an alignment attribute? > >

[PATCH] D109387: [AIX] Check for typedef properly when getting preferred type align

stevewan updated this revision to Diff 371418. stevewan added a comment. Add test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109387/new/ https://reviews.llvm.org/D109387 Files: clang/lib/AST/ASTContext.cpp clang/test/Layout/aix-power-a

[PATCH] D109387: [AIX] Check for typedef properly when getting preferred type align

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG806ff3c4a42c: [AIX] Check for typedef properly when getting preferred type align (authored by stevewan). Repository: rG LLVM Github Monorepo CHAN

<    1   2