Author: saugustine
Date: Thu Aug 30 09:37:06 2018
New Revision: 341083
URL: http://llvm.org/viewvc/llvm-project?rev=341083&view=rev
Log:
Test the cross-product of how libgcc-related arguments are passed to the linker.
Modified:
cfe/trunk/test/Driver/linux-ld.c
Modified: cfe/trunk/test/Drive
Author: saugustine
Date: Thu Aug 30 13:07:23 2018
New Revision: 341107
URL: http://llvm.org/viewvc/llvm-project?rev=341107&view=rev
Log:
Refactor Addlibgcc to make the when and what logic more straightfoward.
No functional change. A forthcoming change will add support
for -shared-libgcc.
Modifi
Author: saugustine
Date: Thu Aug 30 13:42:49 2018
New Revision: 341114
URL: http://llvm.org/viewvc/llvm-project?rev=341114&view=rev
Log:
Revert r341107. That change breaks lto-android in a way is untested.
Modified:
cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp
Modified: cfe/trunk/lib/Drive
Author: saugustine
Date: Fri Aug 31 10:59:03 2018
New Revision: 341231
URL: http://llvm.org/viewvc/llvm-project?rev=341231&view=rev
Log:
Refactor Addlibgcc to make the when and what logic more straightfoward.
Add Android tests.
Modified:
cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp
cf
Author: saugustine
Date: Mon Jan 28 10:56:43 2019
New Revision: 352404
URL: http://llvm.org/viewvc/llvm-project?rev=352404&view=rev
Log:
Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib=
Summary:
"clang++ hello.cc --rtlib=compiler-rt"
now works without specifying additional unwind or exc
Author: saugustine
Date: Mon Jan 28 10:56:44 2019
New Revision: 352405
URL: http://llvm.org/viewvc/llvm-project?rev=352405&view=rev
Log:
Correct help text for --unwindlib options.
Modified:
cfe/trunk/include/clang/Driver/Options.td
Modified: cfe/trunk/include/clang/Driver/Options.td
URL:
ht
Author: saugustine
Date: Tue Jan 29 10:27:51 2019
New Revision: 352524
URL: http://llvm.org/viewvc/llvm-project?rev=352524&view=rev
Log:
Rollback unwindlib patch.
Removed:
cfe/trunk/test/Driver/compiler-rt-unwind.c
Modified:
cfe/trunk/include/clang/Basic/DiagnosticDriverKinds.td
cfe/t
Author: saugustine
Date: Tue Mar 19 13:01:59 2019
New Revision: 356508
URL: http://llvm.org/viewvc/llvm-project?rev=356508&view=rev
Log:
Add --unwindlib=[libgcc|compiler-rt] to parallel --rtlib= [take 2]
"clang++ hello.cc --rtlib=compiler-rt"
now can works without specifying additional unwind or
Author: saugustine
Date: Thu Mar 21 16:30:50 2019
New Revision: 356724
URL: http://llvm.org/viewvc/llvm-project?rev=356724&view=rev
Log:
This test assumes that -rtlib defaults to libgcc. But that isn't true in the
face of -DCLANG_DEFAULT_RTLIB=compiler-rt.
Subscribers: dberris, jdoerfert, llvm-c
Author: saugustine
Date: Wed Jul 10 16:38:00 2019
New Revision: 365713
URL: http://llvm.org/viewvc/llvm-project?rev=365713&view=rev
Log:
rL365634 adds a unique_ptr in
GobalCompilationDatabase.h:108 but CompilationDatabase is only forward
declared. This makes the header not compile standalone, be
Author: saugustine
Date: Mon May 13 11:45:03 2019
New Revision: 360610
URL: http://llvm.org/viewvc/llvm-project?rev=360610&view=rev
Log:
Add a new LIBUNWIND_WEAK_PTHREAD Cmake option to force
calls into the pthread library use weak symbols.
This option allows libpthread to be a weak dependency ra
Author: saugustine
Date: Thu Jan 10 14:25:58 2019
New Revision: 350900
URL: http://llvm.org/viewvc/llvm-project?rev=350900&view=rev
Log:
Properly support -shared-libgcc.
This revision was revied in D55016.
Modified:
cfe/trunk/lib/Driver/ToolChains/CommonArgs.cpp
cfe/trunk/test/Driver/lin
I applied this to a clean local copy, which has no other changes, and have
the following test error, which may be pilot error on my part, but
nevertheless, this test needs to be robust to changes in the line number.
llvm-svn/llvm/tools/clang/unittests/Tooling/QualTypeNamesTest.cpp:39:
Failure
Valu
Author: saugustine
Date: Fri May 4 13:12:39 2018
New Revision: 331552
URL: http://llvm.org/viewvc/llvm-project?rev=331552&view=rev
Log:
Allow modifying the PrintingPolicy for fully qualified names.
Author: mikhail.rama...@gmail.com
Modified:
cfe/trunk/include/clang/AST/QualTypeNames.h
Committed as r331552.
On Fri, May 4, 2018 at 12:43 PM, Mikhail Ramalho via Phabricator <
revi...@reviews.llvm.org> wrote:
> mikhail.ramalho updated this revision to Diff 145255.
> mikhail.ramalho added a comment.
>
> Fixed the test case.
>
>
> https://reviews.llvm.org/D36610
>
> Files:
> includ
Author: Sterling Augustine
Date: 2020-06-08T14:16:30-07:00
New Revision: f07b3d41e73979e46f468dbaa27866bbb53c1ab6
URL:
https://github.com/llvm/llvm-project/commit/f07b3d41e73979e46f468dbaa27866bbb53c1ab6
DIFF:
https://github.com/llvm/llvm-project/commit/f07b3d41e73979e46f468dbaa27866bbb53c1ab6.
Author: Sterling Augustine
Date: 2020-06-09T17:19:38-07:00
New Revision: ccd192204da45cc3f4b42f585f04c4f934b21bef
URL:
https://github.com/llvm/llvm-project/commit/ccd192204da45cc3f4b42f585f04c4f934b21bef
DIFF:
https://github.com/llvm/llvm-project/commit/ccd192204da45cc3f4b42f585f04c4f934b21bef.
Author: Sterling Augustine
Date: 2020-06-12T12:10:13-07:00
New Revision: e64059828f19f629081220bffeb3ef7582870111
URL:
https://github.com/llvm/llvm-project/commit/e64059828f19f629081220bffeb3ef7582870111
DIFF:
https://github.com/llvm/llvm-project/commit/e64059828f19f629081220bffeb3ef7582870111.
Sorry for the trouble. I think many buildbots don't build lldb--not enough
of them anyway. I found this myself.
As I understand it, the switch-cover warning is supposed to be enabled
everywhere when built in release mode, so it looks like the lldb builders
(what few there are) aren't building in r
Author: Sterling Augustine
Date: 2020-08-18T14:37:36-07:00
New Revision: a20f5fe70810e0a768c1814d69d10862965c21e4
URL:
https://github.com/llvm/llvm-project/commit/a20f5fe70810e0a768c1814d69d10862965c21e4
DIFF:
https://github.com/llvm/llvm-project/commit/a20f5fe70810e0a768c1814d69d10862965c21e4.
Author: Sterling Augustine
Date: 2021-02-18T13:04:58-08:00
New Revision: 4544a63b77056212af341722b2e04471a8ec0be6
URL:
https://github.com/llvm/llvm-project/commit/4544a63b77056212af341722b2e04471a8ec0be6
DIFF:
https://github.com/llvm/llvm-project/commit/4544a63b77056212af341722b2e04471a8ec0be6.
Author: Sterling Augustine
Date: 2021-02-18T13:26:07-08:00
New Revision: fc97a63db0d3488ce6c422a9545f8b0268760918
URL:
https://github.com/llvm/llvm-project/commit/fc97a63db0d3488ce6c422a9545f8b0268760918
DIFF:
https://github.com/llvm/llvm-project/commit/fc97a63db0d3488ce6c422a9545f8b0268760918.
Author: Victor Kuznetsov
Date: 2021-06-03T10:50:00-07:00
New Revision: 3e55f55048387a8efef01e445d46fc5cf100285d
URL:
https://github.com/llvm/llvm-project/commit/3e55f55048387a8efef01e445d46fc5cf100285d
DIFF:
https://github.com/llvm/llvm-project/commit/3e55f55048387a8efef01e445d46fc5cf100285d.di
Author: Sterling Augustine
Date: 2021-06-10T13:14:45-07:00
New Revision: 1d3873d41eca67e974bafbaa91866581bcc0d973
URL:
https://github.com/llvm/llvm-project/commit/1d3873d41eca67e974bafbaa91866581bcc0d973
DIFF:
https://github.com/llvm/llvm-project/commit/1d3873d41eca67e974bafbaa91866581bcc0d973.
Author: Sterling Augustine
Date: 2022-08-26T12:40:55-07:00
New Revision: 5eab94f7eb20c2f5d3123e7401892a1a6a133e38
URL:
https://github.com/llvm/llvm-project/commit/5eab94f7eb20c2f5d3123e7401892a1a6a133e38
DIFF:
https://github.com/llvm/llvm-project/commit/5eab94f7eb20c2f5d3123e7401892a1a6a133e38.
Author: Sterling Augustine
Date: 2022-08-26T12:43:05-07:00
New Revision: f886f7e8ef7aa4f54298db792a656373af90440c
URL:
https://github.com/llvm/llvm-project/commit/f886f7e8ef7aa4f54298db792a656373af90440c
DIFF:
https://github.com/llvm/llvm-project/commit/f886f7e8ef7aa4f54298db792a656373af90440c.
Author: Sterling Augustine
Date: 2023-07-14T13:34:26-07:00
New Revision: b9543f7de69770a97e983452c5158acc3b4783c7
URL:
https://github.com/llvm/llvm-project/commit/b9543f7de69770a97e983452c5158acc3b4783c7
DIFF:
https://github.com/llvm/llvm-project/commit/b9543f7de69770a97e983452c5158acc3b4783c7.
Author: Sterling Augustine
Date: 2023-08-23T14:34:40-07:00
New Revision: 5eb44df1b64dbd1a86b099128092a7fd2001c0ba
URL:
https://github.com/llvm/llvm-project/commit/5eb44df1b64dbd1a86b099128092a7fd2001c0ba
DIFF:
https://github.com/llvm/llvm-project/commit/5eb44df1b64dbd1a86b099128092a7fd2001c0ba.
Author: Sterling Augustine
Date: 2020-04-02T10:52:25-07:00
New Revision: 71fbd6e40632f437049215904c28ad9d63cff4bc
URL:
https://github.com/llvm/llvm-project/commit/71fbd6e40632f437049215904c28ad9d63cff4bc
DIFF:
https://github.com/llvm/llvm-project/commit/71fbd6e40632f437049215904c28ad9d63cff4bc.
Author: Sterling Augustine
Date: 2020-03-03T09:13:01-08:00
New Revision: d93371238e7f5d5f9c506a88cf4f05f8dea9d008
URL:
https://github.com/llvm/llvm-project/commit/d93371238e7f5d5f9c506a88cf4f05f8dea9d008
DIFF:
https://github.com/llvm/llvm-project/commit/d93371238e7f5d5f9c506a88cf4f05f8dea9d008.
Author: Sterling Augustine
Date: 2019-11-07T14:48:35-08:00
New Revision: d3c744313c3cca0c076f031ec71e66ca74b12f2a
URL:
https://github.com/llvm/llvm-project/commit/d3c744313c3cca0c076f031ec71e66ca74b12f2a
DIFF:
https://github.com/llvm/llvm-project/commit/d3c744313c3cca0c076f031ec71e66ca74b12f2a.
Author: Sterling Augustine
Date: 2019-12-05T16:48:18-08:00
New Revision: 6470497817eafe3fe2d15e11ade78fd99753d7ca
URL:
https://github.com/llvm/llvm-project/commit/6470497817eafe3fe2d15e11ade78fd99753d7ca
DIFF:
https://github.com/llvm/llvm-project/commit/6470497817eafe3fe2d15e11ade78fd99753d7ca.
Author: Sterling Augustine
Date: 2020-03-05T08:55:22-08:00
New Revision: 470f995a517f5dbb53b1f5cd87ca3c9be0b32d79
URL:
https://github.com/llvm/llvm-project/commit/470f995a517f5dbb53b1f5cd87ca3c9be0b32d79
DIFF:
https://github.com/llvm/llvm-project/commit/470f995a517f5dbb53b1f5cd87ca3c9be0b32d79.
Author: Sterling Augustine
Date: 2020-03-06T13:28:09-08:00
New Revision: eb755df5c27f5687a4f43a62e7eb0713c3f8f030
URL:
https://github.com/llvm/llvm-project/commit/eb755df5c27f5687a4f43a62e7eb0713c3f8f030
DIFF:
https://github.com/llvm/llvm-project/commit/eb755df5c27f5687a4f43a62e7eb0713c3f8f030.
Author: Sterling Augustine
Date: 2020-03-10T10:35:15-07:00
New Revision: d67cf7a0a970df6e69db437514bf61a2ab283e67
URL:
https://github.com/llvm/llvm-project/commit/d67cf7a0a970df6e69db437514bf61a2ab283e67
DIFF:
https://github.com/llvm/llvm-project/commit/d67cf7a0a970df6e69db437514bf61a2ab283e67.
Author: Sterling Augustine
Date: 2020-03-11T10:13:33-07:00
New Revision: 8ffdabdb61e1e2251b07ee93a4806cde1890f47d
URL:
https://github.com/llvm/llvm-project/commit/8ffdabdb61e1e2251b07ee93a4806cde1890f47d
DIFF:
https://github.com/llvm/llvm-project/commit/8ffdabdb61e1e2251b07ee93a4806cde1890f47d.
Author: Sterling Augustine
Date: 2020-03-12T10:53:33-07:00
New Revision: c53c2058ffb8ff877702bb2dded31c85c1dfe66d
URL:
https://github.com/llvm/llvm-project/commit/c53c2058ffb8ff877702bb2dded31c85c1dfe66d
DIFF:
https://github.com/llvm/llvm-project/commit/c53c2058ffb8ff877702bb2dded31c85c1dfe66d.
Author: Sterling Augustine
Date: 2020-03-12T11:55:10-07:00
New Revision: 3eef58991b26feb37aaae92d5b568b27fab84584
URL:
https://github.com/llvm/llvm-project/commit/3eef58991b26feb37aaae92d5b568b27fab84584
DIFF:
https://github.com/llvm/llvm-project/commit/3eef58991b26feb37aaae92d5b568b27fab84584.
Author: Sterling Augustine
Date: 2020-03-12T18:14:22-07:00
New Revision: 3758b858ef3b39b3081bf9a567ead8bc69c9a208
URL:
https://github.com/llvm/llvm-project/commit/3758b858ef3b39b3081bf9a567ead8bc69c9a208
DIFF:
https://github.com/llvm/llvm-project/commit/3758b858ef3b39b3081bf9a567ead8bc69c9a208.
Author: saugustine
Date: Thu Jul 6 14:02:52 2017
New Revision: 307315
URL: http://llvm.org/viewvc/llvm-project?rev=307315&view=rev
Log:
Allow CompilerInvocations to generate .d files.
Summary:
Most clang tools should ignore the -M
family of options because one wouldn't want them
to generate a ne
Author: saugustine
Date: Thu Jul 6 15:47:19 2017
New Revision: 307329
URL: http://llvm.org/viewvc/llvm-project?rev=307329&view=rev
Log:
This call-site should have been updated as part of D34304.
Summary: Use an argument adjuster to preserve behavior inadvertantly changed by
D34304.
Reviewers:
Author: saugustine
Date: Fri Jul 14 11:33:30 2017
New Revision: 308043
URL: http://llvm.org/viewvc/llvm-project?rev=308043&view=rev
Log:
Prevent ClangTools from generating dependency files.
D34304 created a way for ToolInvocations to conditionally generate
dependency files, and updated call sites
As requested on cfe-dev, enclosed is a patch (that needs some
style-related work) to calculate the complete fully qualified name of
arbitrary Qualtypes, including recursively expanding template
parameters and subtypes.
Seems to me like it follows most of the conventions described here:
http://llv
saugustine updated this revision to Diff 39605.
saugustine added a comment.
Handle unscoped enum with name. Also add test cases.
http://reviews.llvm.org/D14459
Files:
lib/AST/Decl.cpp
unittests/AST/NamedDeclPrinterTest.cpp
Index: unittests/AST/NamedDeclPrinterTest.cpp
=
saugustine updated this revision to Diff 46680.
saugustine marked 19 inline comments as done.
saugustine added a comment.
- Update docs. Handle keywords and anonymous namespaces.
- Address code review issues. Cleanup many
http://reviews.llvm.org/D15861
Files:
include/clang/Tooling/Core/QualTy
Richard,
Please take another look when you get a chance. Thanks.
On Tue, Feb 2, 2016 at 11:14 AM, Sterling Augustine
wrote:
> saugustine updated this revision to Diff 46680.
> saugustine marked 19 inline comments as done.
> saugustine added a comment.
>
> - Update docs. Handle keywords and anon
saugustine updated this revision to Diff 47267.
saugustine added a comment.
- Privatize all functions but getFullyQualifiedName.
http://reviews.llvm.org/D15861
Files:
include/clang/Tooling/Core/QualTypeNames.h
lib/Tooling/Core/CMakeLists.txt
lib/Tooling/Core/QualTypeNames.cpp
unittests/
saugustine updated this revision to Diff 47343.
saugustine added a comment.
- Cleanup dyn_cast usage inside QualTypeNames.
http://reviews.llvm.org/D15861
Files:
include/clang/Tooling/Core/QualTypeNames.h
lib/Tooling/Core/CMakeLists.txt
lib/Tooling/Core/QualTypeNames.cpp
unittests/Toolin
I've updated the change.
Would you mind checking it in? I'll look into switching the implementations
shortly.
On Tue, Feb 9, 2016 at 11:02 AM, Sterling Augustine
wrote:
> saugustine updated this revision to Diff 47343.
> saugustine added a comment.
>
> - Cleanup dyn_cast usage inside QualTypeNa
saugustine created this revision.
saugustine added a reviewer: rsmith.
saugustine added subscribers: cfe-commits, klimek.
The keyword "template" isn't necessary when
printing a fully-qualified qualtype name, and, in fact,
results in a syntax error if one tries to use it. So stop
printing it.
http
saugustine added a comment.
Thanks for the quick review. Assuming my response to your comment on line 138
is adequate, would you mind checking it in?
Comment at: unittests/Tooling/QualTypeNamesTest.cpp:138
@@ -136,3 +137,3 @@
" typedef int non_dependent_type;\n"
saugustine requested a review of this revision.
saugustine added a comment.
Would you mind reviewing this, and checking it in if you find it acceptable?
http://reviews.llvm.org/D17214
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://li
saugustine created this revision.
saugustine added a reviewer: rnk.
saugustine added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Treat qualifiers on elaborated types for qualtypenames appropriately.
http://reviews.llvm.org/D20040
Files:
lib/Tooling/Core/QualTypeNames.cpp
un
saugustine updated this revision to Diff 56634.
saugustine marked an inline comment as done.
saugustine added a comment.
- Handle elaborated types even more cleanly.
http://reviews.llvm.org/D20040
Files:
lib/Tooling/Core/QualTypeNames.cpp
unittests/Tooling/QualTypeNamesTest.cpp
Index: unit
saugustine added a comment.
Thanks for the reviews. I believe I have addressed all issues. Take another
look when you get the chance.
Comment at: lib/Tooling/Core/QualTypeNames.cpp:401-403
@@ -397,6 +400,5 @@
// move the qualifiers on the outer type (avoid 'std::const string
saugustine added a comment.
Thanks again. I've addressed the last little bits. Mind checking this in for me?
http://reviews.llvm.org/D20040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
saugustine updated this revision to Diff 56643.
saugustine marked 4 inline comments as done.
saugustine added a comment.
- Address remaining nits from review.
http://reviews.llvm.org/D20040
Files:
lib/Tooling/Core/QualTypeNames.cpp
unittests/Tooling/QualTypeNamesTest.cpp
Index: unittests/T
saugustine accepted this revision.
saugustine added a comment.
This revision is now accepted and ready to land.
This looks good and useful to me on the Tooling/Core side, but someone more
familiar with the internals of NestedNamesSpecifiers should sign off on that
portion.
Also, I would probabl
pe.cpp looks much simpler?
> Where is the additional complexity coming from?
>
> - Ben
>
>
> On Sat, Oct 24, 2015 at 12:29 AM, Sterling Augustine via cfe-commits
> wrote:
> > As requested on cfe-dev, enclosed is a patch (that needs some
> > style-related work) to calc
saugustine updated this revision to Diff 44245.
saugustine marked 4 inline comments as done.
saugustine added a comment.
- Update docs. Handle keywords and anonymous namespaces.
http://reviews.llvm.org/D15861
Files:
include/clang/Tooling/Core/QualTypeNames.h
lib/Tooling/Core/CMakeLists.txt
saugustine added a comment.
Thanks for the reviews. Please take another look when you get a chance.
Comment at: include/clang/Tooling/Core/QualTypeNames.h:32-33
@@ +31,4 @@
+namespace TypeName {
+///\brief Convert the type into one with fully qualified template
+/// arguments.
+
Author: Sterling Augustine
Date: 2021-04-12T14:39:13-07:00
New Revision: c2ad7c23707cece995ee9070283a72c4afc8c0fe
URL:
https://github.com/llvm/llvm-project/commit/c2ad7c23707cece995ee9070283a72c4afc8c0fe
DIFF:
https://github.com/llvm/llvm-project/commit/c2ad7c23707cece995ee9070283a72c4afc8c0fe.
Author: Sterling Augustine
Date: 2021-04-14T13:29:51-07:00
New Revision: d2bb3cbbf8bc3a1b3d27c5a89e7cdd56bdca924f
URL:
https://github.com/llvm/llvm-project/commit/d2bb3cbbf8bc3a1b3d27c5a89e7cdd56bdca924f
DIFF:
https://github.com/llvm/llvm-project/commit/d2bb3cbbf8bc3a1b3d27c5a89e7cdd56bdca924f.
63 matches
Mail list logo