smcgro created this revision.
smcgro added reviewers: SjoerdMeijer, rsmith.
Herald added a subscriber: cfe-commits.
The SPIR target currently allows for half precision floating point types to use
the LLVM intrinsic functions to convert to floats and doubles. This is illegal
in SPIR as the only i
smcgro added a comment.
Thanks for the feedback @SjoerdMeijer I've updated the commit message and
responded to the comments
Comment at: lib/Basic/Targets/SPIR.h:50
UseAddrSpaceMapMangling = true;
+HasLegalHalfType = true;
// Define available target features
-
smcgro updated this revision to Diff 151512.
https://reviews.llvm.org/D48188
Files:
lib/Basic/Targets/SPIR.h
test/CodeGen/spir-half-type.cpp
Index: test/CodeGen/spir-half-type.cpp
===
--- /dev/null
+++ test/CodeGen/spir-half-typ
smcgro updated this revision to Diff 151938.
smcgro added a comment.
Added a function parameter to one of the functions
https://reviews.llvm.org/D48188
Files:
lib/Basic/Targets/SPIR.h
test/CodeGen/spir-half-type.cpp
Index: test/CodeGen/spir-half-type.cpp
===
smcgro added a comment.
That's great @SjoerdMeijer , thanks for the review. I don't have commit access
to clang so if there are no more reviews then it would be great if someone
could commit this for me, thanks.
https://reviews.llvm.org/D48188
___
