[PATCH] D127519: [clang-cl] Accept /FA[c][s][u], but ignore the arguments

2022-06-13 Thread Stephen Long via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4245ed67ce4: [clang-cl] Accept /FA[c][s][u], but ignore the arguments (authored by steplong). Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

2022-06-13 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 436551. steplong added a comment. - Remove -Og, and all non-zero optimization levels - Fix up docs - Modified tests to reflect -Og and non-zero opt level change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126

[PATCH] D127641: [clang-cl][MSVC] Add default /Zc conformance arguments

2022-06-13 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 436592. steplong added a comment. - Ignore /Zc:wchar_t Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127641/new/ https://reviews.llvm.org/D127641 Files: clang/include/clang/Driver/Options.td clang/test/Dr

[PATCH] D126984: [clang] Add support for optimize function attribute

2022-06-14 Thread Stephen Long via Phabricator via cfe-commits
steplong added a comment. I'm open to tabling this and just implementing support for an empty optimization list for the pragma (i.e. `#pragma optimize("", on | off)`). For our use case, at the moment, we only see the pragma being used this way. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D126984: [clang] Add support for optimize function attribute

2022-06-14 Thread Stephen Long via Phabricator via cfe-commits
steplong added a comment. > I appreciate your patience while we figure out the right approach here; we > don't usually have this many false starts when working through a feature > review. :-) No worries, I appreciate the community doing the due diligence. Repository: rG LLVM Github Monorepo

[PATCH] D127641: [clang-cl][MSVC] Add default /Zc conformance arguments

2022-06-14 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 436860. steplong added a comment. Herald added a subscriber: MaskRay. - Only enable /Zc:alignedNew and /Zc:sizedDealloc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127641/new/ https://reviews.llvm.org/D12764

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

2022-06-14 Thread Stephen Long via Phabricator via cfe-commits
steplong added inline comments. Comment at: clang/lib/Driver/ToolChains/Clang.cpp:6641 // by default. if (Arg *A = Args.getLastArg(options::OPT_faligned_allocation, options::OPT_fno_aligned_allocation, There's a check here fo

[PATCH] D125723: [MSVC] Add support for MSVC pragma optimize

2022-06-14 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 436954. steplong edited the summary of this revision. steplong added a comment. - Change logic to only handle empty optimization list - Fixup doc and tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125723/n

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

2022-06-14 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 436985. steplong added a comment. - Change logic for /Zc:alignedNew and /Zc:sizedDealloc - Add tests for different /std:c++ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127641/new/ https://reviews.llvm.org/D1

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

2022-06-15 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 437153. steplong added a comment. - Fix docs - Clean up code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125723/new/ https://reviews.llvm.org/D125723 Files: clang/docs/ReleaseNotes.rst clang/include/cla

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

2022-06-15 Thread Stephen Long via Phabricator via cfe-commits
steplong added inline comments. Comment at: clang/docs/ReleaseNotes.rst:304 + all functions following the pragma. At the moment, only an empty list is + supported. xbolva00 wrote: > xbolva00 wrote: > > So to sum up.. #pragma optimize("", off) disables all opt

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

2022-06-15 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 437243. steplong added a comment. `https://docs.microsoft.com/en-us/cpp/build/reference/zc-sizeddealloc-enable-global-sized-dealloc-functions?view=msvc-170` says it implements this by default starting on MSVC 2015. I don't have an older version of MSVC, so

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

2022-06-15 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 437260. steplong added a comment. - Add documentation on difference btwn MSVC and Clang's implementation of pragma optimize Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125723/new/ https://reviews.llvm.org/D

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

2022-06-15 Thread Stephen Long via Phabricator via cfe-commits
steplong added inline comments. Comment at: clang/docs/LanguageExtensions.rst:3800 +``g``, ``t``, and ``y``. Clang's current implementation of the pragma behaves in +the same way as the clang pragma. All functions between ``off`` and ``on`` will +be decorated with the ``optnone`

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

2022-06-15 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 437280. steplong added a comment. - Fix docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125723/new/ https://reviews.llvm.org/D125723 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.rst

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

2022-06-20 Thread Stephen Long via Phabricator via cfe-commits
steplong added a comment. Hmm, it looks like MSVC is accepting: extern "C" { static void foo(); } static int foo(); #pragma alloc_text("s", foo) static void foo() {} Ignoring the `pragma alloc_text`, it looks like GCC compiles the following `foo` with C linkage vs LLVM which comp

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

2022-06-20 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 438437. steplong added a comment. - Remove DEFAULT from test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127641/new/ https://reviews.llvm.org/D127641 Files: clang/lib/Driver/ToolChains/Clang.cpp clang/t

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

2022-06-20 Thread Stephen Long via Phabricator via cfe-commits
steplong added a comment. It looks like misc-new-delete-overloads.cpp is failing on line 20: 1 // RUN: %check_clang_tidy %s misc-new-delete-overloads %t 2 3 typedef decltype(sizeof(int)) size_t; 4 5 struct S { 6 // CHECK-MESSAGES: :[[@LINE+1]]:9: warning: declaration of 'opera

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

2022-06-21 Thread Stephen Long via Phabricator via cfe-commits
steplong added a comment. In D126559#3598885 , @hans wrote: >> Ignoring the `pragma alloc_text`, it looks like GCC compiles the following >> `foo` with C linkage vs LLVM which compiles with C++ linkage (foo's name is >> mangled): > > The mangled name sh

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

2022-06-21 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 438682. steplong added a comment. Herald added a project: clang-tools-extra. - Add `-target x86_64-unknown-linux` to `misc-new-delete-overloads.cpp` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127641/new/ ht

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

2022-06-21 Thread Stephen Long via Phabricator via cfe-commits
steplong added a comment. In D126559#3598950 , @hans wrote: >> Oh I see, that makes sense. We aren't accepting >> https://godbolt.org/z/9Yej9vhYd. Do you know of a way to get the `NamedDecl` >> with `extern "C"` instead of the second declaration? > > I'

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

2022-06-21 Thread Stephen Long via Phabricator via cfe-commits
steplong added a comment. I tried the following: FunctionDecl *FD = ND->getAsFunction(); DeclContext *DC = ND->getDeclContext(); DEBUG_WITH_TYPE("foo", llvm::dbgs() << "[FOO] DC->isExternCContext() : " << DC->isExternCContext() << "\n"); DEBUG_WITH_TYPE("foo", llvm::dbgs(

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

2022-06-21 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 438778. steplong added a comment. Whoops, this is a clang-tidy test, so `-target` won't work here. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127641/new/ https://reviews.llvm.org/D127641 Files: clang-too

[PATCH] D127641: [clang-cl][MSVC] Enable /Zc:alignedNew for C++17 and /Zc:sizedDealloc by default

2022-06-21 Thread Stephen Long via Phabricator via cfe-commits
steplong added a comment. Hmm, a StaticAnalyzer unit test is failing. It looks it is expecting `"test.CXXDeallocator: NumArgs: 1\n"`, but getting `"test.CXXDeallocator: NumArgs: 2\n". I'm assuming it is because sized deallocation is enabled on default for MSVC now Repository: rG LLVM Github

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

2022-06-22 Thread Stephen Long via Phabricator via cfe-commits
steplong added a comment. Hi, I'll land this on Friday. Let me know if there are any comments. Also, I'm not sure how to rebase it on top of main. At the moment, it's still on top of D126984 (i.e. stack has one open) Repository: rG LLVM Github Monorepo CHA

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

2022-06-22 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 439097. steplong added a comment. - Fix up docs Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125723/new/ https://reviews.llvm.org/D125723 Files: clang/docs/LanguageExtensions.rst clang/docs/ReleaseNotes.

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

2022-06-24 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 439738. steplong added a comment. - Run pre-merge checks again after abandoning dependent patch D126984 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125723/new/ https://rev

[PATCH] D125723: [MSVC] Add initial support for MSVC pragma optimize

2022-06-24 Thread Stephen Long via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG186bea3750d6: [MSVC] Add initial support for MSVC pragma optimize (authored by steplong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

2022-05-27 Thread Stephen Long via Phabricator via cfe-commits
steplong created this revision. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. `isExternCContext()` is returning false for functions in C files Change-Id: I51cccb476aa19dc0a0a78e951d7f482befdb78ca R

[PATCH] D125723: [MSVC] Add support for MSVC pragma optimize

2022-05-31 Thread Stephen Long via Phabricator via cfe-commits
steplong added inline comments. Comment at: clang/lib/Sema/SemaAttr.cpp:1207-1213 + FD->addAttr(FramePointerAttr::CreateImplicit(Context, Kind)); +} + +void Sema::AddOptsize(FunctionDecl *FD, SourceLocation Loc) { + FD->dropAttr(); + OptimizeSizeAttr::Kind Kind = OptimizeSizeA

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

2022-05-31 Thread Stephen Long via Phabricator via cfe-commits
steplong added a comment. It looks like MSVC also accepts // foo.c static void foo(); #pragma alloc_text("hello", foo) void foo() {} and // foo.cpp extern "C" { static void foo(); #pragma alloc_text("hello", foo) void foo() {} } Do you know of a way I can check whether a fu

[PATCH] D126719: [clang-cl] Add support for /kernel

2022-05-31 Thread Stephen Long via Phabricator via cfe-commits
steplong created this revision. Herald added a project: All. steplong requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. MSVC defines _KERNEL_MODE when /kernel is passed. Also, /kernel disables RTTI and C++ exception handling. https:/

[PATCH] D126719: [clang-cl] Add support for /kernel

2022-05-31 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 433185. steplong added a comment. - Test that exceptions aren't enabled with /kernel Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126719/new/ https://reviews.llvm.org/D126719 Files: clang/include/clang/Bas

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

2022-05-31 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 433194. steplong added a comment. - Handle static C/C++ functions and C functions in general Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126559/new/ https://reviews.llvm.org/D126559 Files: clang/lib/Sema/

[PATCH] D126719: [clang-cl] Add support for /kernel

2022-05-31 Thread Stephen Long via Phabricator via cfe-commits
steplong added a comment. In D126719#3548469 , @thakis wrote: > What does cl do if both `/kernel` and (eg) `/EHsc` is passed (try both > orders)? Same question for `/kernel /GR`. From my experiments, cl doesn't complain and happily compiles the code if

[PATCH] D126719: [clang-cl] Add support for /kernel

2022-06-01 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 433389. steplong added a comment. Herald added a subscriber: ormris. - Reject /kernel and /arch combinations for x64 and x86 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126719/new/ https://reviews.llvm.org/D

[PATCH] D126559: [MSVC] Fix pragma alloc_text failing for C files

2022-06-01 Thread Stephen Long via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa5b056fe49a9: [MSVC] Fix pragma alloc_text failing for C files (authored by steplong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126559/new/ https://rev

[PATCH] D126719: [clang-cl] Add support for /kernel

2022-06-01 Thread Stephen Long via Phabricator via cfe-commits
steplong added a comment. In D126719#3548469 , @thakis wrote: > It also says `/kernel` is passed on to the linker. Do you know how the linker distinguishes objects created by /kernel vs non-/kernel? At the moment, we are just using MSVC's linker to link

[PATCH] D125723: [MSVC] Add support for MSVC pragma optimize

2022-06-01 Thread Stephen Long via Phabricator via cfe-commits
steplong added a comment. Appreciate the help! It's not clear to me how to go from the strings "Os", "foo1", "foo2", "foo3" to adding "-Os -ffoo1 -ffoo2 -ffoo3" to the compilation line for that function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[PATCH] D126719: [clang-cl] Add support for /kernel

2022-06-01 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 433502. steplong added a comment. - Change UnsupportedArches to SupportedArches Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126719/new/ https://reviews.llvm.org/D126719 Files: clang/include/clang/Basic/La

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

2022-06-03 Thread Stephen Long via Phabricator via cfe-commits
steplong created this revision. Herald added a reviewer: aaron.ballman. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. At the moment, it only supports a string argument that refers to the optimization

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

2022-06-03 Thread Stephen Long via Phabricator via cfe-commits
steplong added inline comments. Comment at: clang/lib/CodeGen/CGCall.cpp:2169 +HasOptnone = TargetDecl->hasAttr() || + (TargetDecl->hasAttr() && + TargetDecl->getAttr()->getLevel() == "0"); I don't think this is the most ergon

[PATCH] D126719: [clang-cl] Add support for /kernel

2022-06-03 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 434107. steplong added a comment. - Change to SupportedArches.insert() - Add logic that errors if /kernel and /GR - Add test for /kernel and /EHsc (silently override /EHsc. Only errors when trying to use exceptions in src code) and /kernel and /GR (fails wit

[PATCH] D126719: [clang-cl] Add support for /kernel

2022-06-03 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 434122. steplong added a comment. - Whoops missed a "/" in the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126719/new/ https://reviews.llvm.org/D126719 Files: clang/include/clang/Basic/LangOptions.de

[PATCH] D126719: [clang-cl] Add support for /kernel

2022-06-06 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 434459. steplong added a comment. - Clang-formatted patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126719/new/ https://reviews.llvm.org/D126719 Files: clang/include/clang/Basic/LangOptions.def clang/

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

2022-06-06 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 434639. steplong added a comment. - Added docs for attribute - Changed attribute to use Enum - Optsize includes -Og, -Oz, and -Ofast - Change to warning instead of error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

2022-06-06 Thread Stephen Long via Phabricator via cfe-commits
steplong added inline comments. Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4841-4850 + StringRef Level; + // Check if argument is prefixed with "-O" or "O" + if (Arg.str().rfind("-O", 0) == 0) +Level = Arg.substr(2); + else if (Arg.str().rfind("O", 0) == 0) +Level =

[PATCH] D126719: [clang-cl] Add support for /kernel

2022-06-07 Thread Stephen Long via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe3a6784ac967: [clang-cl] Add support for /kernel (authored by pzheng, committed by steplong). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126719/new/ http

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

2022-06-08 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 435264. steplong added a comment. Herald added a subscriber: jdoerfert. - Fix up docs and comments - Fix failing pragma-attribute-supported-attributes-list.test - Remove debug print - Change to StringMap Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

2022-06-08 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 435313. steplong added a comment. - Add Arg when creating Attr Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126984/new/ https://reviews.llvm.org/D126984 Files: clang/include/clang/Basic/Attr.td clang/inc

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

2022-06-08 Thread Stephen Long via Phabricator via cfe-commits
steplong added a comment. In D126984#3567822 , @aaron.ballman wrote: > Two final (I hope) nits! One is in the code, the other is that this should > have a release note for the new attribute. Assuming precommit CI pipeline > passes, then I think this is

[PATCH] D126984: [clang] Add initial support for gcc's optimize function attribute

2022-06-09 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 435680. steplong added a comment. - Added release notes on attribute Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126984/new/ https://reviews.llvm.org/D126984 Files: clang/docs/ReleaseNotes.rst clang/inc

[PATCH] D127452: [clang-cl][MSVC] Map /external:Wn n=1-4 to -Wsystem-headers

2022-06-09 Thread Stephen Long via Phabricator via cfe-commits
steplong created this revision. Herald added a project: All. steplong requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D127452 Files: clang/include/clang/Driver/Options.td

[PATCH] D127452: [clang-cl][MSVC] Map /external:Wn n=1-4 to -Wsystem-headers

2022-06-09 Thread Stephen Long via Phabricator via cfe-commits
steplong added a comment. I don't think /external:Wn behaves exactly like -Wsystem-headers. /external:Wn applies /Wn to the system headers, while -Wsystem-headers applies whatever is on the command line to the system headers. I think /external:Wn behaves more like: // foo.c #pragma clang d

[PATCH] D127452: [clang-cl][MSVC] Map /external:Wn n=1-4 to -Wsystem-headers

2022-06-10 Thread Stephen Long via Phabricator via cfe-commits
steplong added inline comments. Comment at: clang/test/Driver/cl-zc.cpp:106 // DllExportInlines-NOT: "-fno-dllexport-inlines" +// RUN: %clang_cl /external:W1 /c -### -- %s 2>&1 | FileCheck -check-prefix=EXTERNAL_Wn %s hans wrote: > This is not the right test

[PATCH] D127452: [clang-cl][MSVC] Map /external:Wn n=1-4 to -Wsystem-headers

2022-06-10 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 435901. steplong added a comment. - Move tests to cl-options.c - Map /external:W0 to -Wno-system-headers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127452/new/ https://reviews.llvm.org/D127452 Files: cla

[PATCH] D127452: [clang-cl][MSVC] Map /external:Wn n=1-4 to -Wsystem-headers

2022-06-10 Thread Stephen Long via Phabricator via cfe-commits
steplong updated this revision to Diff 435910. steplong added a comment. - Change helptext for /external:W0 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127452/new/ https://reviews.llvm.org/D127452 Files: clang/include/clang/Driver/Options.td

<    1   2