steveire created this revision.
steveire added a reviewer: aaron.ballman.
steveire requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This reduces template bloat, but more importantly, makes it possible to
construct one from clang-query withou
steveire created this revision.
steveire added a reviewer: aaron.ballman.
steveire requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D94880
Files:
clang/lib/ASTMatchers/Dynami
steveire created this revision.
steveire added a reviewer: aaron.ballman.
steveire requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D94881
Files:
clang/include/clang/ASTMatch
steveire added a comment.
This is WIP because there is still some error handling and code completion
handling to do. Pushed the patch though to complete the series :
https://github.com/steveire/llvm-project/commits/mapAnyOf
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
htt
steveire added inline comments.
Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2867
+extern const internal::MapAnyOfMatcher
+callOrConstruct;
+
aaron.ballman wrote:
> I'm not super keen on this name. It's certainly descriptive, but I do wonder
> i
This revision was automatically updated to reflect the committed changes.
Closed by commit rGecf696641e6c: [ASTMatchers] Allow use of mapAnyOf in more
contexts (authored by stephenkelly).
Changed prior to commit:
https://reviews.llvm.org/D94864?vs=317175&id=317690#toc
Repository:
rG LLVM Git
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8d112a8eda9d: Remove TypedMatcherOps from VariantValue
(authored by stephenkelly).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94876/new/
https://reviews.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG0cd0eb6e0a81: Add API to retrieve a clade kind from
ASTNodeKind (authored by stephenkelly).
Changed prior to commit:
https://reviews.llvm.org/D94877?vs=317226&id=317703#toc
Repository:
rG LLVM Github
steveire updated this revision to Diff 317704.
steveire added a comment.
Update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94878/new/
https://reviews.llvm.org/D94878
Files:
clang/include/clang/ASTMatchers/Dynamic/VariantValue.h
clang/lib/AS
steveire updated this revision to Diff 317705.
steveire added a comment.
Update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94879/new/
https://reviews.llvm.org/D94879
Files:
clang/lib/ASTMatchers/Dynamic/Marshallers.h
Index: clang/lib/ASTMat
steveire added inline comments.
Comment at: clang/lib/ASTMatchers/Dynamic/Marshallers.h:948
+ return {};
+auto VM = Arg.Value.getMatcher();
+if (VM.hasTypedMatcher(NK)) {
aaron.ballman wrote:
> Note, this is an example of why use of `auto
steveire updated this revision to Diff 317709.
steveire added a comment.
Update
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94865/new/
https://reviews.llvm.org/D94865
Files:
clang/docs/LibASTMatchersReference.html
clang/include/clang/ASTMatc
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8000c778532b: Make it possible to store a ASTNodeKind in
VariantValue (authored by stephenkelly).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94878/new/
h
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe377c8eeb4aa: Implement dynamic mapAnyOf in terms of
ASTNodeKinds (authored by stephenkelly).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94879/new/
https
steveire added inline comments.
Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:2867
+extern const internal::MapAnyOfMatcher
+callOrConstruct;
+
aaron.ballman wrote:
> steveire wrote:
> > aaron.ballman wrote:
> > > I'm not super keen on this name. I
steveire added a comment.
FYI - there's nothing "anti-inclusive" about East/West.
In Qt I proposed a change which added properties to an object. Those properties
in my change were named "Left"/"Right". The reviewer objected to those names
because "scripts which are not Right-to-Left exist". So
1001 - 1016 of 1016 matches
Mail list logo