[PATCH] D53500: Add 'detailed-ast' output as an alias for 'dump'

This revision was automatically updated to reflect the committed changes. Closed by commit rL345193: [clang-query] Add 'detailed-ast' output as an alias for 'dump' (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D53501: [clang-query] Refactor Output settings to booleans

This revision was automatically updated to reflect the committed changes. Closed by commit rL345194: [clang-query] Refactor Output settings to booleans (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D53501?vs=170

[PATCH] D53501: [clang-query] Refactor Output settings to booleans

This revision was automatically updated to reflect the committed changes. Closed by commit rCTE345194: [clang-query] Refactor Output settings to booleans (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D53501?vs=170431&id=170975#toc Repository: rL LLV

[PATCH] D52857: [clang-query] Add non-exclusive output API

steveire updated this revision to Diff 171046. steveire added a comment. New command design Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D52857 Files: clang-query/Query.cpp clang-query/Query.h clang-query/QueryParser.cpp clang-query/QueryParser.h unittests/clang-quer

[PATCH] D52857: [clang-query] Add non-exclusive output API

This revision was automatically updated to reflect the committed changes. Closed by commit rL345522: [clang-query] Add non-exclusive output API (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D52857?vs=171046&id=1

[PATCH] D52857: [clang-query] Add non-exclusive output API

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: clang-query/QueryParser.cpp:285 +if (VarStr.empty()) + return new InvalidQuery("expected variable name"); +if (Var == PQV_Invalid) aaron.ballman wrote: > This seem

[PATCH] D53882: [clang-tidy] Adding Zircon checker for std namespace

steveire added inline comments. Comment at: clang-tools-extra/clang-tidy/zircon/NoStdNamespaceCheck.cpp:52 + Finder->addMatcher( + valueDecl(hasType(decl(hasDeclContext(namespaceDecl(isStdNamespace()) + .bind("stdVar"), Recommend extracting `na

[PATCH] D55488: Add utility for dumping a label with child nodes

This revision was automatically updated to reflect the committed changes. Closed by commit rC350957: [ASTDump] Add utility for dumping a label with child nodes (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D55488?vs=180935&id=181331#toc Repository:

[PATCH] D55492: Implement Attr dumping in terms of visitors

This revision was automatically updated to reflect the committed changes. Closed by commit rC350958: Implement Attr dumping in terms of visitors (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D55492?vs=181182&id=181334#toc Repository: rC Clang CHANG

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

steveire updated this revision to Diff 181395. steveire added a comment. Updates Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55491/new/ https://reviews.llvm.org/D55491 Files: include/clang/AST/TemplateArgumentVisitor.h include/clang/AST/TextNodeDumper.h

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

steveire added a comment. In D55491#1355105 , @thakis wrote: > Out of interest, what's the motivation for this? It seems to add way more > code than it removes, so there must be some other advantage, but the patch > description doesn't say. The reason

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/TemplateArgumentVisitor.h:24 +/// A simple visitor class that helps create template argument visitors. +template class Ref, typename ImplClass, + typename RetTy = vo

[PATCH] D55491: Implement TemplateArgument dumping in terms of Visitor

This revision was automatically updated to reflect the committed changes. Closed by commit rL351012: Implement TemplateArgument dumping in terms of Visitor (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55491?vs

[PATCH] D55340: NFC: Move dump of individual Stmts to TextNodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rL351014: [ASTDump] NFC: Move dump of individual Stmts to TextNodeDumper (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D56639: NFC: Move Type Visit implementation to TextNodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56639 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumper

[PATCH] D56641: NFC: Move dumping of QualType node to TextNodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56641 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumpe

[PATCH] D56640: NFC: Canonicalize handling of TypeLocInfo

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. No need to avoid the Visit method. Repository: rC Clang https://reviews.llvm.org/D56640 Files: lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp

[PATCH] D56642: NFC: Move dump of type nodes to NodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56642 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumper

[PATCH] D56642: NFC: Move dump of type nodes to NodeDumper

steveire updated this revision to Diff 181452. steveire added a comment. Format Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56642/new/ https://reviews.llvm.org/D56642 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.

[PATCH] D55394: Re-order type param children of ObjC nodes

steveire marked an inline comment as done. steveire added inline comments. Comment at: test/AST/ast-dump-decl.m:90 // CHECK-NEXT: -ObjCProtocol {{.+}} 'P' +// CHECK-NEXT: -ObjCTypeParamDecl {{.+}} col:33 T 'id':'id' aaron.ballman wrote: > It seems strange

[PATCH] D56643: NFC: Move Decl node handling to TextNodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56643 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumper

[PATCH] D56642: NFC: Move dump of type nodes to NodeDumper

steveire updated this revision to Diff 181475. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56642/new/ https://reviews.llvm.org/D56642 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.

[PATCH] D56642: NFC: Move dump of type nodes to NodeDumper

steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:145 void VisitVariableArrayType(const VariableArrayType *T) { - OS << " "; - NodeDumper.dumpSourceRange(T->getBracketsRange()); - VisitArrayType(T); +

[PATCH] D55394: Re-order type param children of ObjC nodes

steveire marked an inline comment as done. steveire added inline comments. Comment at: test/AST/ast-dump-decl.m:90 // CHECK-NEXT: -ObjCProtocol {{.+}} 'P' +// CHECK-NEXT: -ObjCTypeParamDecl {{.+}} col:33 T 'id':'id' dblaikie wrote: > steveire wrote: > > a

[PATCH] D56639: NFC: Move Type Visit implementation to TextNodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rC351114: [ASTDump] NFC: Move Type Visit implementation to TextNodeDumper (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56639?vs=181448&id=181625#toc Repositor

[PATCH] D56640: NFC: Canonicalize handling of TypeLocInfo

This revision was automatically updated to reflect the committed changes. Closed by commit rC351115: [ASTDump] NFC: Canonicalize handling of TypeLocInfo (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56640?vs=181449&id=181626#toc Repository: rC Clan

[PATCH] D56641: NFC: Move dumping of QualType node to TextNodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rL351116: [ASTDump] NFC: Move dumping of QualType node to TextNodeDumper (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION ht

[PATCH] D56642: NFC: Move dump of type nodes to NodeDumper

steveire updated this revision to Diff 181632. steveire added a comment. Nits Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56642/new/ https://reviews.llvm.org/D56642 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cp

[PATCH] D55340: NFC: Move dump of individual Stmts to TextNodeDumper

steveire closed this revision. steveire added a comment. Closing after it was reopened by spammer. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55340/new/ https://reviews.llvm.org/D55340 ___ cfe-commits mailing list

[PATCH] D56642: NFC: Move dump of type nodes to NodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rC351172: [ASTDump] NFC: Move dump of type nodes to NodeDumper (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56642?vs=181632&id=181738#toc Repository: rC Cla

[PATCH] D56643: NFC: Move Decl node handling to TextNodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rC351175: NFC: Move Decl node handling to TextNodeDumper (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56643?vs=181453&id=181740#toc Repository: rC Clang CH

[PATCH] D56707: Implement CXXCtorInitializer dump in terms of Visitor

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56707 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumpe

[PATCH] D56708: NFC: Implement OMPClause dump in terms of visitors

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56708 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumpe

[PATCH] D56709: Implement BlockDecl::Capture dump in terms of visitors

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56709 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumpe

[PATCH] D55083: Re-arrange content in FunctionDecl dump

steveire updated this revision to Diff 181744. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D55083/new/ https://reviews.llvm.org/D55083 Files: lib/AST/ASTDumper.cpp test/AST/ast-dump-funcs.cpp Index: test/AST/ast-dump-funcs

[PATCH] D56708: NFC: Implement OMPClause dump in terms of visitors

steveire updated this revision to Diff 181749. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56708/new/ https://reviews.llvm.org/D56708 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.

[PATCH] D56709: Implement BlockDecl::Capture dump in terms of visitors

steveire updated this revision to Diff 181751. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56709/new/ https://reviews.llvm.org/D56709 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.

[PATCH] D55083: Re-arrange content in FunctionDecl dump

steveire marked an inline comment as done. steveire added inline comments. Comment at: test/AST/ast-dump-funcs.cpp:59 // CHECK: CXXMethodDecl 0x{{[^ ]*}} col:8 f 'void (float, int)' + // CHECK-NEXT: Overrides: [ 0x{{[^ ]*}} S::f 'void (float, int)' ] // CHECK-NEXT: ParmV

[PATCH] D56707: Implement CXXCtorInitializer dump in terms of Visitor

This revision was automatically updated to reflect the committed changes. Closed by commit rL351235: Implement CXXCtorInitializer dump in terms of Visitor (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://rev

[PATCH] D56708: NFC: Implement OMPClause dump in terms of visitors

This revision was automatically updated to reflect the committed changes. Closed by commit rL351236: NFC: Implement OMPClause dump in terms of visitors (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D56708?vs=181

[PATCH] D56708: NFC: Implement OMPClause dump in terms of visitors

steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/AST/TextNodeDumper.cpp:276-280 + if (!C) { +ColorScope Color(OS, ShowColors, NullColor); +OS << "<<>> OMPClause"; +return; + } aaron.ballman wrote: > This pat

[PATCH] D56709: Implement BlockDecl::Capture dump in terms of visitors

This revision was automatically updated to reflect the committed changes. Closed by commit rC351239: Implement BlockDecl::Capture dump in terms of visitors (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56709?vs=181751&id=181859#toc Repository: rC C

[PATCH] D55083: Re-arrange content in FunctionDecl dump

This revision was automatically updated to reflect the committed changes. Closed by commit rC351269: Re-order overrides in FunctionDecl dump (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D55083?vs=181744&id=181892#toc Repository: rC Clang CHANGES S

[PATCH] D55394: Re-order type param children of ObjC nodes

This revision was automatically updated to reflect the committed changes. Closed by commit rL351272: Re-order type param children of ObjC nodes (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D55394?vs=177071&id=1

[PATCH] D56751: [ASTDump] Mark variadic declarations with a tag instead of child node

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. This makes it easier to separate traversal of the AST from output generation. Repository: rC Clang https://reviews.llvm.org/D56751 Files: lib/AST/ASTDumper.cpp lib/AST/TextNo

[PATCH] D56752: [ASTDump] Mark BlockDecls which capture this with a tag

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Removal of the child node makes it easier to separate traversal from output generation. Repository: rC Clang https://reviews.llvm.org/D56752 Files: lib/AST/ASTDumper.cpp Inde

[PATCH] D56752: [ASTDump] Mark BlockDecls which capture this with a tag

steveire updated this revision to Diff 181909. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56752/new/ https://reviews.llvm.org/D56752 Files: lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp ===

[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56753 Files: lib/AST/ASTDumper.cpp Index: lib/AST/ASTDumper.cpp =

[PATCH] D56786: Changes to `CXXMemberExpr` matchers.

steveire added a comment. Can you break this up into multiple commits? Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56786/new/ https://reviews.llvm.org/D56786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D56786: [ASTMatchers] Changes to `CXXMemberExpr` matchers.

steveire added a comment. It is always valuable to split changes which are independent. Usually you can extract NFC changes first and then look at what remains to split it. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56786/new/ https://reviews.llvm.org/D56786

[PATCH] D56786: [ASTMatchers] Changes to `CXXMemberExpr` matchers.

steveire added a comment. It seems that you update docs for existing matchers without changing those matchers. You could put all of that in one patch. Then, you seem to add some tests for existing matches. You could put that in the second patch. Then your third patch would add the new matcher

[PATCH] D56829: Move decl context dumping to TextNodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Only an obscure case is moved. Repository: rC Clang https://reviews.llvm.org/D56829 Files: lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumper.cp

[PATCH] D56829: Move decl context dumping to TextNodeDumper

steveire marked an inline comment as done. steveire added a comment. I don't know what C++ code results in the `undeserialized declarations` output. Can you suggest some? Comment at: lib/AST/ASTDumper.cpp:519-520 - (DC->hasExternalLexicalStorage() || - (Dese

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

steveire added inline comments. Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:475 + auto MatchesType = cxxMemberCallExpr(on(hasType(cxxRecordDecl(hasName("X"); + EXPECT_TRUE(matches( + R"cc( Could you add a test which uses the s

[PATCH] D56786: [ASTMatchers] Changes to `CXXMemberExpr` matchers.

steveire added a comment. Should this one now be closed? The 'Add Action...' dropdown has an action for that. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56786/new/ https://reviews.llvm.org/D56786 ___ cfe-commits

[PATCH] D56849: [ASTMatchers][NFC] Update comments on assorted `CXXMemberCallExpr` matchers.

steveire added inline comments. Comment at: clang/docs/LibASTMatchersReference.html:4823 + matches "x.m", but not "m" +memberExpr(hasObjectExpression(hasType(pointsTo( + cxxRecordDecl(hasName("X")) If we're going to put such examples and details into the

[PATCH] D56752: [ASTDump] Mark BlockDecls which capture this with a tag

steveire updated this revision to Diff 182475. steveire added a comment. Rebase Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56752/new/ https://reviews.llvm.org/D56752 Files: lib/AST/ASTDumper.cpp test/AST/ast-dump-decl.mm Index: test/AST/ast-dump-decl.mm

[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

steveire updated this revision to Diff 182476. steveire marked an inline comment as done. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56753/new/ https://reviews.llvm.org/D56753 Files: lib/AST/ASTDumper.cpp Index: lib/AST/AS

[PATCH] D56829: Move decl context dumping to TextNodeDumper

steveire updated this revision to Diff 182478. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56829/new/ https://reviews.llvm.org/D56829 Files: lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumper.c

[PATCH] D56829: Move decl context dumping to TextNodeDumper

steveire updated this revision to Diff 182482. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56829/new/ https://reviews.llvm.org/D56829 Files: lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumper.c

[PATCH] D56850: [ASTMatchers][NFC] Add tests for assorted `CXXMemberCallExpr` matchers.

steveire added a comment. Thanks, do you need someone to commit this for you? Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:492 + auto MatchesX = cxxMemberCallExpr(on(hasType(cxxRecordDecl(hasName("X"); + EXPECT_TRUE(notMatches(Snippet1, MatchesX));

[PATCH] D56751: [ASTDump] Mark variadic declarations with a tag instead of child node

This revision was automatically updated to reflect the committed changes. Closed by commit rC351597: [ASTDump] Mark variadic declarations with a tag instead of child node (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56751?vs=181904&id=182598#toc Rep

[PATCH] D56752: [ASTDump] Mark BlockDecls which capture this with a tag

This revision was automatically updated to reflect the committed changes. Closed by commit rL351600: [ASTDump] Mark BlockDecls which capture this with a tag (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Repository: rL LLVM CHANGES SINCE LAST ACTION https://r

[PATCH] D56753: [ASTDump] Mark null params with a tag rather than a child node

This revision was automatically updated to reflect the committed changes. Closed by commit rL351601: [ASTDump] Mark null params with a tag rather than a child node (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D

[PATCH] D56829: Move decl context dumping to TextNodeDumper

steveire updated this revision to Diff 182607. steveire marked an inline comment as done. steveire added a comment. Update Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56829/new/ https://reviews.llvm.org/D56829 Files: lib/AST/ASTDumper.cpp lib/AST/TextNodeD

[PATCH] D56829: Move decl context dumping to TextNodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rC351637: Move decl context dumping to TextNodeDumper (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56829?vs=182607&id=182669#toc Repository: rC Clang CHANG

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. As a type, this can be visited upon. This is similar in spirit to the BlockDecl::Capture type. Repository: rC Clang https://reviews.llvm.org/D56959 Files: include/clang/AST/Ex

[PATCH] D56960: NFC: Implement GenericSelectionExpr::Association dump with Visitor

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56960 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumpe

[PATCH] D56961: NFC: Move GenericSelectionExpr dump to NodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D56961 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDumpe

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

steveire marked 2 inline comments as done. steveire added inline comments. Comment at: include/clang/AST/Expr.h:5068 + Association getAssociation(unsigned I) const { +return Association(cast(SubExprs[END_EXPR + I]), AssocTypes[I], aaron.ballman wrote: > Ra

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

steveire marked an inline comment as done. steveire added inline comments. Comment at: include/clang/AST/Expr.h:5068 + Association getAssociation(unsigned I) const { +return Association(cast(SubExprs[END_EXPR + I]), AssocTypes[I], aaron.ballman wrote: > st

[PATCH] D57098: [WIP][AST] NFC: Introduce new class GenericSelectionExpr::Association

steveire added a comment. Thanks for doing this! It would be easier to review (now and in the future!) if you split it into at least 3 commits - Refactor without changing API to use trailing objects - The change to use bitfields and Stmt.h - Introduce new class GenericSelectionExpr::Association

[PATCH] D57098: [WIP][AST] NFC: Introduce new class GenericSelectionExpr::Association

steveire added a comment. In D57098#1367852 , @riccibruno wrote: > In D57098#1367816 , @steveire wrote: > > > Thanks for doing this! > > > > It would be easier to review (now and in the future!) if you split it into

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. Splitting the introduction of and porting to `Create` would significantly reduce the number of files touched by the 'real' change in this commit, and therefore reduce noise in the commit (following the idea of "do one thing per commit" to make the code reviewable in th

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. I haven't done a full review as it's not obvious what parts of the diff relate to which separate change. Perhaps Aaron will review and approve though for you anyway. Thanks! Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57104/new/ htt

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

steveire added a comment. Just in case you didn't know, you could have (and still can!) just update https://reviews.llvm.org/D57098 instead of creating a new PR. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57106/new/ https://reviews.llvm.org/D57106

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:1465 - for (unsigned I = 0, N = E->getNumAssocs(); I != N; ++I) { + for (GenericSelectionExpr::ConstAssociation Assoc : E->associations()) { dumpChild([=] { Range for loops in this file ge

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. In D57104#1368072 , @riccibruno wrote: > In D57104#1368055 , @steveire wrote: > > > Splitting the introduction of and porting to `Create` would significantly > > reduce the number of files

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

steveire accepted this revision. steveire added a comment. This revision is now accepted and ready to land. Is this covered by CI? Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 __

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

steveire added a comment. The question was whether there is a build-bot for FreeBSD (if there is, then it is covered by CI). Doesn't matter though. If no such bot exists, this isn't the commit to enforce requiring one! Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://

[PATCH] D57102: [extra] unit tests enable crash-recovery cases on FreeBSD

steveire added a comment. You may need to accept the new license terms: http://lists.llvm.org/pipermail/llvm-dev/2019-January/129069.html Repository: rCTE Clang Tools Extra CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57102/new/ https://reviews.llvm.org/D57102 __

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added inline comments. Comment at: include/clang/AST/Expr.h:5095 - SourceLocation getBeginLoc() const LLVM_READONLY { return GenericLoc; } - SourceLocation getEndLoc() const LLVM_READONLY { return RParenLoc; } riccibruno wrote: > steveire wrote: > >

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. Thanks, but I don't see the factored out changes in the repo. Are you going to commit those first? Also, please factor out the introduction and use of `::Create`. It seems to be unrelated to the trailing objects change. Repository: rC Clang CHANGES SINCE LAST ACTI

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. There's definitely a better possible ordering in two commits: 1. Introduce `::Create` and port to it 2. Use trailing objects, taking advantage of the fact that `::Create` exists. That would make it clear in the future to other people because both commits would be clean

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. In D57104#1369985 , @steveire wrote: > There's definitely a better possible ordering in two commits: > > 1. Introduce `::Create` and port to it > 2. Use trailing objects, taking advantage of the fact that `::Create` exists. > >

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. In D57104#1370081 , @riccibruno wrote: > > I highly recommend this 9 minute video if this is new to you or you haven't > > seen it before: https://youtu.be/qpdYRPL3SVE?t=103 > > I would like to add an additional meta-comment here

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. In D57104#1369751 , @riccibruno wrote: > Cleanup the patch by factoring out the NFC changes. > > @steveire This should be much clearer now. I'd like to apply this patch locally, but I think the removed parts are not in the repo

[PATCH] D57104: [AST] Pack GenericSelectionExpr

steveire added a comment. I was just working on this this afternoon to show you the difference when it is split up. Looks like you committed this meanwhile. While building I noticed that you introduced a `-Wreorder` bug in D57238 , which isn't surprising given h

[PATCH] D57106: [AST] Introduce GenericSelectionExpr::Association

steveire added a comment. This was subsequently reverted. Is there a status update? Rebasing and committing D56959 would unblock traverser work and would allow this to progress separately in parallel. Repository: rL LLVM CHANGES SINCE LAST ACTION https://

[PATCH] D56960: NFC: Implement GenericSelectionExpr::Association dump with Visitor

This revision was automatically updated to reflect the committed changes. Closed by commit rC352552: NFC: Implement GenericSelectionExpr::Association dump with Visitor (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56960?vs=182673&id=184178#toc Reposi

[PATCH] D56961: NFC: Move GenericSelectionExpr dump to NodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rC352558: NFC: Move GenericSelectionExpr dump to NodeDumper (authored by steveire, committed by ). Changed prior to commit: https://reviews.llvm.org/D56961?vs=182674&id=184187#toc Repository: rC Clang

[PATCH] D57419: [ASTDump] Move Decl node dumping to TextNodeDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, jfb. Repository: rC Clang https://reviews.llvm.org/D57419 Files: include/clang/AST/TextNodeDumper.h lib/AST/ASTDumper.cpp lib/AST/TextNodeDumper.cpp Index: lib/AST/TextNodeDu

[PATCH] D56959: [AST] NFC: Introduce new class GenericSelectionExpr::Association

steveire abandoned this revision. steveire added a comment. An alternative was written and committed. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56959/new/ https://reviews.llvm.org/D56959 ___ cfe-commits mailing l

[PATCH] D57419: [ASTDump] Move Decl node dumping to TextNodeDumper

This revision was automatically updated to reflect the committed changes. Closed by commit rL352655: [ASTDump] Move Decl node dumping to TextNodeDumper (authored by steveire, committed by ). Herald added a subscriber: llvm-commits. Changed prior to commit: https://reviews.llvm.org/D57419?vs=184

[PATCH] D57419: [ASTDump] Move Decl node dumping to TextNodeDumper

steveire added a comment. In D57419#1377187 , @lebedev.ri wrote: > Needs rebasing for rL352631 . Thanks. Rebased and re-tested. Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57419/new/

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added subscribers: cfe-commits, jfb. This new traverser class allows clients to re-use the traversal logic which was previously part of ASTDumper. This means that alternative visit logic may be implemented, such as

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

steveire updated this revision to Diff 184363. steveire added a comment. Fix comment Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57472/new/ https://reviews.llvm.org/D57472 Files: include/clang/AST/ASTDumpTraverser.h lib/AST/ASTDumper.cpp Index: lib/AST/AS

[PATCH] D57472: [AST] Extract ASTDumpTraverser class from ASTDumper

steveire marked an inline comment as done. steveire added inline comments. Comment at: lib/AST/ASTDumper.cpp:63 - if (const auto *C = dyn_cast(D)) -for (const auto *I : C->inits()) - Visit(I); - - if (D->doesThisDeclarationHaveABody()) -Visit(

[PATCH] D57502: [ASTDump] Make template specialization tests more exact

steveire created this revision. steveire added a reviewer: aaron.ballman. Herald added a subscriber: cfe-commits. Repository: rC Clang https://reviews.llvm.org/D57502 Files: test/AST/ast-dump-decl.cpp Index: test/AST/ast-dump-decl.cpp

[PATCH] D53936: [clang-tidy] More clearly separate public, check-facing APIs from internal ones.

steveire added inline comments. Comment at: clang-tidy/ClangTidy.h:11 +// +// It should remain as stable as possible, as many out-of-tree checks exist. +//===--===// Clang C++ code does not have

<    1   2   3   4   5   6   7   8   9   10   >