STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible
loss of data", part 6/7.
test/std/algorithms/alg.modifying.operations/alg.random.shuffle/random_sh
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC warning C4244 "conversion from 'X' to 'Y', possible
loss of data", part 7/7.
test/std/input.output/iostream.format/input.streams/istream.unformatted/g
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix MSVC warning C6001 "Using uninitialized memory".
/analyze sees array::size() being called on arrays with garbage-inited doubles,
and complains. It doesn't k
STL_MSFT added a comment.
It was debatable to me whether this was actually a compiler bug, but I suppose
that it can see size()'s definition and should be able to notice that the
elements aren't accessed. I've filed VSO#300037 "Bogus warning C6001 "Using
uninitialized memory" for array::size()"
STL_MSFT added a comment.
I can't possibly defend C1XX's behavior in your foo() scenario - but the pair
scenarios being fixed here are different. pair's constructor from (X&&,
Y&&) is perfect forwarding, so while the compiler can see that literals are
being passed to (int&&, int&&), when it ins
STL_MSFT added a comment.
I checked, and Clang 3.8.0 behaves identically to C1XX in the pair scenario.
Here's the test case:
#include
template struct Pair {
A a;
B b;
template Pair(X&& x, Y&& y) :
a(std::forward(x)), b(std::forward(y)) { }
};
int main()
STL_MSFT marked an inline comment as done.
STL_MSFT added inline comments.
Comment at: test/std/re/re.traits/value.pass.cpp:119
}
for (int c = 'g'; c < 0x; ++c)
{
EricWF wrote:
> Can't we just make `c` a `wchar_t` like above?
Yes (b
STL_MSFT updated the summary for this revision.
STL_MSFT updated this revision to Diff 80810.
STL_MSFT marked an inline comment as done.
STL_MSFT added a comment.
Changed test/std/re/re.traits/value.pass.cpp to iterate with wchar_t as
requested.
https://reviews.llvm.org/D27544
Files:
test/s
STL_MSFT added a comment.
Responded to https://reviews.llvm.org/D27540. tuple is affected just like pair.
https://reviews.llvm.org/D27541
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
STL_MSFT added a comment.
I could mark these assertions as libcxx-specific, but I tend to believe that
they should be removed outright (even if the natural implementation of a list
without debug checks provides this behavior).
https://reviews.llvm.org/D26626
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Add LIBCPP_ASSERT_NOEXCEPT/LIBCPP_ASSERT_NOT_NOEXCEPT, remove
an unused variable.
test/support/test_macros.h
For convenience/greppability, add macros for libcx
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix string_view tests.
test/std/strings/string.view/string.view.ops/compare.pointer_size.pass.cpp
Passing -1 to size_t triggers signed/unsigned mismatch warning
STL_MSFT added a comment.
Hmm, would a pragma guarded by _MSC_VER be better? I can easily do that. I've
tried to avoid cluttering the test with VC-specific pragmas, but I understand
your concern about initializing too much memory.
https://reviews.llvm.org/D27555
STL_MSFT added a comment.
Yeah, users are free to do this, which also triggers conversion warnings for
us. I think I'll need to investigate actually fixing/suppressing them in our
sources and abandoning this patch; leaving it open for now as a todo.
https://reviews.llvm.org/D27270
_
STL_MSFT added a comment.
Actually, the compiler bug was resolved as fixed earlier today. Verifying...
https://reviews.llvm.org/D27555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
STL_MSFT abandoned this revision.
STL_MSFT added a comment.
Verified compiler fix. Abandoning this patch - nothing has been committed.
https://reviews.llvm.org/D27555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-
STL_MSFT abandoned this revision.
STL_MSFT added a comment.
r289358 fixes everything for me, thanks! Abandoning this revision.
https://reviews.llvm.org/D26623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mail
STL_MSFT created this revision.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
[libcxx] [test] Fix a size_t-to-int truncation warning in error_code.pass.cpp.
This test was triggering MSVC x64 warning C4267
"conversion from 'size_t' to 'int', possible loss
STL_MSFT retitled this revision from "[libcxx] [test] Fix a size_t-to-int
truncation warning in error_code.pass.cpp." to "[libcxx] [test] Fix
size_t-to-int truncation warnings in syserr.hash.".
STL_MSFT updated the summary for this revision.
STL_MSFT updated this revision to Diff 81160.
STL_MSFT
STL_MSFT created this revision.
[libcxx] [test] Avoid P0138R2, direct-list-init of fixed enums from integers.
This C++17 Core Language feature isn't necessary when testing std::byte.
It's a minor convenience, but it limits test coverage to very new compilers.
(I encountered this because C1XX cur
STL_MSFT created this revision.
[libcxx] [test] In msvc_stdlib_force_include.hpp, use _HAS_CXX17 to set
TEST_STD_VER.
_HAS_CXX17 indicates whether MSVC's STL is in C++17 mode.
https://reviews.llvm.org/D32726
Files:
test/support/msvc_stdlib_force_include.hpp
Index: test/support/msvc_stdlib
STL_MSFT created this revision.
[libcxx] [test] Be compatible with LWG 2438 "std::iterator inheritance
shouldn't be mandated".
In C++17, these iterators are allowed but not required to inherit from the
deprecated std::iterator base class.
https://reviews.llvm.org/D32727
Files:
test/std/ite
STL_MSFT accepted this revision.
STL_MSFT added inline comments.
This revision is now accepted and ready to land.
Comment at: test/support/archetypes.hpp:20
protected:
+#endif // !TEST_WORKAROUND_C1XX_BROKEN_ZA_CTOR_CHECK
NullBase() = default;
I think that th
STL_MSFT added inline comments.
Comment at: test/support/msvc_stdlib_force_include.hpp:76
+#include
+
EricWF wrote:
> Is the `stdlib.h` include above not enough?
It isn't enough. In MSVC there's a distinction between CRT headers like
`stdlib.h` and STL header
STL_MSFT created this revision.
[libcxx] [test] Fix MSVC "warning C6326: Potential comparison of a constant
with another constant".
The expressions `1 == 1` and `true` have the same type, value category, and
value.
https://reviews.llvm.org/D32924
Files:
test/std/containers/sequences/vector
STL_MSFT closed this revision.
STL_MSFT added a comment.
Committed with requested changes.
https://reviews.llvm.org/D32727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
STL_MSFT created this revision.
[libcxx] [test] Suppress MSVC's /analyze warning C6294 in a more fine-grained
manner.
https://reviews.llvm.org/D32926
Files:
test/std/utilities/template.bitset/bitset.cons/char_ptr_ctor.pass.cpp
test/std/utilities/template.bitset/bitset.cons/default.pass.cpp
STL_MSFT resigned from this revision.
STL_MSFT added inline comments.
Comment at: include/exception:192
+#endif
+void* __ptr1_;
+void* __ptr2_;
BillyONeal wrote:
> I hope you realize you are doing "evil" unsupported things :). (We won't go
> out of our w
STL_MSFT added inline comments.
Comment at: test/support/test_workarounds.h:21
#if defined(TEST_COMPILER_C1XX)
-# define TEST_WORKAROUND_C1XX_BROKEN_NULLPTR_CONVERSION_OPERATOR
-# define TEST_WORKAROUND_C1XX_BROKEN_IS_TRIVIALLY_COPYABLE
Do you need to go update
STL_MSFT created this revision.
STL_MSFT added reviewers: ldionne, Mordante, EricWF, mclow.lists.
Herald added a reviewer: bollu.
Herald added a reviewer: MaskRay.
STL_MSFT requested review of this revision.
Herald added projects: clang, libc++, clang-tools-extra.
Herald added subscribers: cfe-comm
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8bd106a89172: [NFC] Fix typos in release notes. (authored by
STL_MSFT).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://r
101 - 131 of 131 matches
Mail list logo
