[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

stefanhaller created this revision. Herald added subscribers: dexonsmith, usaxena95, kadircet, arphaman, hiraditya. Herald added a project: All. stefanhaller requested review of this revision. Herald added subscribers: cfe-commits, llvm-commits, ilya-biryukov. Herald added projects: clang, LLVM, cl

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

stefanhaller updated this revision to Diff 426233. stefanhaller added a comment. Fix documentation of ThreadPriority::Low (was: Background), and move it up from set_thread_priority to ThreadPriority. (Is it ok that there's no documentation left for set_thread_priority? I couldn't come up with any

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

stefanhaller added a comment. In D124715#3488447 , @sammccall wrote: > (How) does this interact with battery vs mains power on laptops? > It seems like there's a common scenario where: > > - the user is on a relatively slow laptop, running off battery > -

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

stefanhaller added a comment. In D124715#3491782 , @akyrtzi wrote: > That said, you may want to consider dynamically switching to background if > running on laptop with battery, or other heuristics, My take on this is that it would be Apple's responsibi

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

stefanhaller added a comment. In D124715#3491985 , @sammccall wrote: > I'm still concerned some users will find this a large regression and we won't > have a good workaround: > > - it'll use a lot more battery than before On Intel Macs, I'm not sure tha

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

stefanhaller updated this revision to Diff 427567. stefanhaller added a comment. Updated the patch to have both Background and Low As discussed, we provide both Background and Low now, with Low being the default; Linux and Windows still implement both the same (as Background), this could be chang

[PATCH] D124715: Use QoS class Utility for ThreadPriority::Low on Mac

stefanhaller updated this revision to Diff 427577. stefanhaller added a comment. - Added a comment to setThreadBackgroundPriority - Improved comments for ThreadPriority enum - Add FIXME comments for Windows and Linux Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac

stefanhaller added a comment. @sammccall I addressed your last change requests with a revised patch, do you want to have a final look? Also, I don't have commit rights, could somebody please land this for me once everybody is happy with it? Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D124715: Add ThreadPriority::Low, and use QoS class Utility on Mac

stefanhaller added a comment. In D124715#3498846 , @sammccall wrote: > Looks great! I'm happy to land it, will do so on Tuesday unless anyone has > further comments. @sammccall Just a friendly ping, in case you forgot. 😄 Repository: rG LLVM Github M