[PATCH] D50984: AMDGPU: Move target code into TargetParser

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D50984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D57349: AMDGPU: Add ds append/consume builtins

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D57349/new/ https://reviews.llvm.org/D57349 ___ cfe-commits mailing list cfe-commi

[PATCH] D58847: AMDGPU: Fix the mapping of sub group sync scope

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D58847/new/ https://reviews.llvm.org/D58847 ___ cfe-commits mailing list cfe-commi

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes

rampitec added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7973 + if (Ordering != llvm::AtomicOrdering::SequentiallyConsistent) { +if (Scope != SyncScope::OpenCLAllSVMDevices) + Name = Twine(Twine(Name) + Twine("-")).str(); if (!Name.empty()

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes (clang)

rampitec added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7976 + +Name = Twine(Twine(Name) + Twine("one-as")).str(); + } b-sumner wrote: > kzhuravl wrote: > > rampitec wrote: > > > I think subgroup is in the single address space even if sequenti

[PATCH] D59494: AMDGPU: Add support for cross address space synchronization scopes (clang)

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D59494/new/ https://reviews.llvm.org/D59494 ___ cfe-commits mailing list cfe-commi

[PATCH] D61112: AMDGPU: Enable _Float16

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D61112/new/ https://reviews.llvm.org/D61112 ___ cfe-commits mailing list cfe-commi

[PATCH] D37386: [AMDGPU] Implement infrastructure to set options in AMDGPUToolChain

rampitec added inline comments. Comment at: lib/Driver/ToolChains/AMDGPU.h:44 +private: + const std::map OptionsDefault = { + {options::OPT_O, "3"}, Is it really needed to create map in the header? https://reviews.llvm.org/D37386 __

[PATCH] D37386: [AMDGPU] Implement infrastructure to set options in AMDGPUToolChain

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D37386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/c

[PATCH] D63366: AMDGPU: Add GWS instruction builtins

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63366/new/ https://reviews.llvm.org/D63366 ___ cfe-commits mailing list cfe-commi

[PATCH] D63578: AMDGPU: Add DS GWS sema builtins

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63578/new/ https://reviews.llvm.org/D63578 ___ cfe-commits mailing list cfe-commi

[PATCH] D64828: AMDGPU: Add some missing builtins

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64828/new/ https://reviews.llvm.org/D64828 ___ cfe-commits mailing list cfe-commi

[PATCH] D65454: AMDGPU: Add missing builtin declarations

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65454/new/ https://reviews.llvm.org/D65454 ___ cfe-commits mailing list cfe-commi

[PATCH] D66198: AMDGPU: Add builtins for is_local/is_private

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66198/new/ https://reviews.llvm.org/D66198 ___ cfe-commits mailing list cfe-commi

[PATCH] D66198: AMDGPU: Add builtins for is_local/is_private

rampitec added a comment. Didn't you forget to update test/CodeGenOpenCL/amdgpu-features.cl? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66198/new/ https://reviews.llvm.org/D66198 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D63649: AMDGPU: Fix target builtins for gfx10

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D63649/new/ https://reviews.llvm.org/D63649 ___ cfe-commits mailing list cfe-commi

[PATCH] D61875: [AMDGPU] gfx1010 clang target

This revision was automatically updated to reflect the committed changes. Closed by commit rC360634: [AMDGPU] gfx1010 clang target (authored by rampitec, committed by ). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rC Clang CHANGES SINCE LAST ACTION http

[PATCH] D56525: [AMDGPU] Separate feature dot-insts

rampitec created this revision. rampitec added reviewers: b-sumner, kzhuravl, msearles. Herald added subscribers: cfe-commits, t-tye, tpr, dstuttard, yaxunl, nhaehnle, wdng, jvesely. clang part Repository: rC Clang https://reviews.llvm.org/D56525 Files: include/clang/Basic/BuiltinsAMDGPU.

[PATCH] D56525: [AMDGPU] Separate feature dot-insts

This revision was automatically updated to reflect the committed changes. Closed by commit rL350794: [AMDGPU] Separate feature dot-insts (authored by rampitec, committed by ). Changed prior to commit: https://reviews.llvm.org/D56525?vs=180969&id=180991#toc Repository: rL LLVM CHANGES SINCE

[PATCH] D81959: [HIP] Enable -amdgpu-internalize-symbols

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81959/new/ https://reviews.llvm.org/D81959 ___ cfe-commits mailing list

[PATCH] D81886: [AMDGPU] Add gfx1030 target

rampitec marked an inline comment as done. rampitec added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:266-267 names. + ``gfx1030`` ``amdgcn`` dGPU - xnack

[PATCH] D85337: [AMDGPU] gfx1031 target

This revision was automatically updated to reflect the committed changes. Closed by commit rGea7d0e2996ec: [AMDGPU] gfx1031 target (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D85337: [AMDGPU] gfx1031 target

rampitec added inline comments. Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1844 LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1030), + LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1031), LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_XNACK), jhen

[PATCH] D85337: [AMDGPU] gfx1031 target

rampitec marked 2 inline comments as done. rampitec added inline comments. Comment at: llvm/tools/llvm-readobj/ELFDumper.cpp:1844 LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1030), + LLVM_READOBJ_ENUM_ENT(ELF, EF_AMDGPU_MACH_AMDGCN_GFX1031), LLVM_READOBJ_ENUM_ENT(E

[PATCH] D79744: clang: Add address space to indirect abi info and use it for kernels

rampitec added a comment. Typo in commit message: "Previously, indirect arguments assumed assumed". CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79744/new/ https://reviews.llvm.org/D79744 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D128952: [AMDGPU] Add WMMA clang builtins

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128952/new/ https://reviews.llvm.org/D128952 ___

[PATCH] D122044: [AMDGPU] New gfx940 mfma instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG27439a764230: [AMDGPU] New gfx940 mfma instructions (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. R

[PATCH] D122191: [AMDGPU] Support gfx940 smfmac instructions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6e3e14f600af: [AMDGPU] Support gfx940 smfmac instructions (authored by rampitec). Herald added subscribers: cfe-commits, hsmhsm. Herald added a proje

[PATCH] D123825: clang/AMDGPU: Define macro for -munsafe-fp-atomics

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123825/new/ https://reviews.llvm.org/D123825 ___ cfe-commits mailing list cfe-co

[PATCH] D119886: [AMDGPU] Promote recursive loads from kernel argument to constant

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb0aa1946dfe1: [AMDGPU] Promote recursive loads from kernel argument to constant (authored by rampitec). Herald added a project: clang. Herald added a

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

rampitec added a comment. You do not handle masks other than 0 yet? Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:219 +// MASK = 0: No instructions may be scheduled across SCHED_BARRIER. +// MASK = 1: Non-memory, non-side-effect producing instructions may be +//

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

rampitec added a comment. In D124700#3483609 , @kerbowa wrote: > In D124700#3483556 , @rampitec > wrote: > >> You do not handle masks other than 0 yet? > > We handle 0 and 1 only. Do you mean 1 is supported simp

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. In D124700#3483715 , @kerbowa wrote: > In D124700#3483633 , @rampitec > wrote: > >> In D124700#3483609 <

[PATCH] D124700: [AMDGPU] Add llvm.amdgcn.sched.barrier intrinsic

rampitec accepted this revision. rampitec added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124700/new/ https://reviews.llvm.org/D124700 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D129902: [AMDGPU] Support for gfx940 fp8 conversions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9fa5a6b7e8a2: [AMDGPU] Support for gfx940 fp8 conversions (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commi

[PATCH] D129906: [AMDGPU] Support for gfx940 fp8 mfma

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2695f0a688e9: [AMDGPU] Support for gfx940 fp8 mfma (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Re

[PATCH] D129908: [AMDGPU] Support for gfx940 fp8 smfmac

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG523a99c0eb03: [AMDGPU] Support for gfx940 fp8 smfmac (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits.

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

rampitec added inline comments. Comment at: lib/CodeGen/TargetInfo.cpp:7885 +// By default, restrict the maximum size to 256. +F->addFnAttr("amdgpu-flat-work-group-size", "128,256"); } arsenm wrote: > yaxunl wrote: > > arsenm wrote: > > > b-sumner wrot

[PATCH] D62739: AMDGPU: Always emit amdgpu-flat-work-group-size

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D62739/new/ https://reviews.llvm.org/D62739 ___ cfe-commits mailing list cfe-commi

[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

rampitec added a comment. This is obviously LGTM from the AMDGPU BE point of view, we did it ourselves. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87972/new/ https://reviews.llvm.org/D87972 ___ cfe-co

[PATCH] D87947: [AMDGPU] Make ds fp atomics overloadable

This revision was automatically updated to reflect the committed changes. Closed by commit rG59691dc8740c: [AMDGPU] Make ds fp atomics overloadable (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

rampitec added inline comments. Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:1581 +def int_amdgcn_endpgm : GCCBuiltin<"__builtin_amdgcn_endpgm">, + Intrinsic<[], [], [IntrNoReturn, IntrNoMem, IntrHasSideEffects] +>; Mayby also IntrCold? Repository: r

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

rampitec added a comment. In D90809#2376994 , @b-sumner wrote: > Should this also be IntrConvergent? Probably yes... This is control flow after all. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90809/new/

[PATCH] D90809: [amdgpu] Add `llvm.amdgcn.endpgm` support.

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. In D90809#2377221 , @hliao wrote: > In D90809#2377083 , @rampitec wrote: > >> In D90809#2376994

[PATCH] D90886: [AMDGPU] Simplify amdgpu-macros.cl test. NFC.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4fcdfc4398bd: [AMDGPU] Simplify amdgpu-macros.cl test. NFC. (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D88916: [AMDGPU] Add gfx602, gfx705, gfx805 targets

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88916/new/ https://reviews.llvm.org/D88916 _

[PATCH] D89487: [AMDGPU] gfx1032 target

This revision was automatically updated to reflect the committed changes. Closed by commit rGd1beb95d1241: [AMDGPU] gfx1032 target (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D89487: [AMDGPU] gfx1032 target

rampitec added inline comments. Comment at: clang/test/Driver/amdgpu-macros.cl:216 // GFX1031-DAG: #define FP_FAST_FMA 1 +// GFX1032-DAG: #define FP_FAST_FMA 1 tra wrote: > This test could use some refactoring. > Individual macro checks could be collapsed to >

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

rampitec added a comment. You need to add a new test for this new error. Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:134 + if (isAmdHsaOS() && getGeneration() == AMDGPUSubtarget::SOUTHERN_ISLANDS) { +report_fatal_error("GFX6 (SI) ASICs does not support AMD HSA O

[PATCH] D92115: AMDGPU - Add diagnostic for compiling modules with AMD HSA OS type and GFX 6 arch

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:62-72 +static AMDGPUSubtarget::Generation initializeGen(const Triple &TT, + StringRef GPU) { + if (GPU.contains("generic")) { +return TT.get

[PATCH] D89487: [AMDGPU] gfx1032 target

rampitec marked 3 inline comments as done. rampitec added inline comments. Comment at: llvm/docs/AMDGPUUsage.rst:280 names. + ``gfx1032`` ``amdgcn`` dGPU - xnack

[PATCH] D89487: [AMDGPU] gfx1032 target

rampitec marked 3 inline comments as done. rampitec added inline comments. Comment at: llvm/lib/Support/TargetParser.cpp:66 // Don't bother listing the implicitly true features -constexpr GPUInfo AMDGCNGPUs[43] = { +constexpr GPUInfo AMDGCNGPUs[44] = { // Name Canonic

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

rampitec added a comment. In D89582#2335619 , @arsenm wrote: > In D89582#2335574 , @yaxunl wrote: > >> What if a device function is called by kernels with different work group >> sizes, will caller's work group siz

[PATCH] D89582: clang/AMDGPU: Apply workgroup related attributes to all functions

rampitec added a comment. In D89582#2335704 , @arsenm wrote: > In D89582#2335671 , @rampitec wrote: > >> In D89582#2335619 , @arsenm wrote: >> >>> In D89582#2335574

[PATCH] D90447: [AMDGPU] Add gfx1033 target

rampitec added a comment. Missing changes to these files: clang/include/clang/Basic/Cuda.h clang/lib/Basic/Cuda.cpp clang/lib/Basic/Targets/NVPTX.cpp clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp llvm/lib/Object/ELFObjectFile.cpp llvm/test/Object/AMDGPU/elf-header-flags-mach.yaml llvm/test/tools/llvm-

[PATCH] D90447: [AMDGPU] Add gfx1033 target

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90447/new/ https://reviews.llvm.org/D90447 _

[PATCH] D102306: Add gfx1034

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102306/new/ https://reviews.llvm.org/D102306 ___ cfe-commits mailing list cfe-commi

[PATCH] D95733: [AMDGPU] Set s-memtime-inst feature from clang

This revision was automatically updated to reflect the committed changes. Closed by commit rG8e661d3d9c52: [AMDGPU] Set s-memtime-inst feature from clang (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D96906: [AMDGPU] gfx90a support

This revision was automatically updated to reflect the committed changes. Closed by commit rGa8d9d50762c4: [AMDGPU] gfx90a support (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Changed prior to commit: https://reviews.llvm.org/D96906?vs=324434&id=

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added a comment. In D96906#2570086 , @tra wrote: > This is a pretty huge patch, with no details in the commit log. > > One hour between sending the patch out and landing it is not sufficient for > anyone to meaningfully > review the patch and th

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:191-199 + MCRegister RepReg; + for (MCRegister R : *MRI->getRegClass(Reg)) { +if (!MRI->isReserved(R)) { + RepReg = R; + break; +} + } arsenm wrote: >

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, + HelpText<"Dis

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, + HelpText<"Dis

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: clang/include/clang/Driver/Options.td:3097-3101 +def mtgsplit : Flag<["-"], "mtgsplit">, Group, + HelpText<"Enable threadgroup split execution mode (AMDGPU only)">; +def mno_tgsplit : Flag<["-"], "mno-tgsplit">, Group, + HelpText<"Dis

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:191-199 + MCRegister RepReg; + for (MCRegister R : *MRI->getRegClass(Reg)) { +if (!MRI->isReserved(R)) { + RepReg = R; + break; +} + } arsenm wrote: >

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:191-199 + MCRegister RepReg; + for (MCRegister R : *MRI->getRegClass(Reg)) { +if (!MRI->isReserved(R)) { + RepReg = R; + break; +} + } arsenm wrote: >

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:191-199 + MCRegister RepReg; + for (MCRegister R : *MRI->getRegClass(Reg)) { +if (!MRI->isReserved(R)) { + RepReg = R; + break; +} + } rampitec wrote:

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:191-199 + MCRegister RepReg; + for (MCRegister R : *MRI->getRegClass(Reg)) { +if (!MRI->isReserved(R)) { + RepReg = R; + break; +} + } arsenm wrote: >

[PATCH] D96906: [AMDGPU] gfx90a support

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIFormMemoryClauses.cpp:191-199 + MCRegister RepReg; + for (MCRegister R : *MRI->getRegClass(Reg)) { +if (!MRI->isReserved(R)) { + RepReg = R; + break; +} + } rampitec wrote:

[PATCH] D97420: [AMDGPU] require s-memtime-inst for __builtin_amdgcn_s_memtime

This revision was automatically updated to reflect the committed changes. Closed by commit rG502b3bfc6a71: [AMDGPU] require s-memtime-inst for __builtin_amdgcn_s_memtime (authored by rampitec). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Mon

[PATCH] D103663: [AMDGPU] Add gfx1013 target

rampitec added a comment. You need to replace HasGFX10_BEncoding with HasGFX10_AEncoding in the BVH and IMAGE_MSAA_LOAD_X. You also need to update llvm.amdgcn.image.msaa.load.x.ll test to include gfx1013. Comment at: llvm/lib/Target/AMDGPU/AMDGPU.td:1106 [FeatureGFX10,

[PATCH] D103663: [AMDGPU] Add gfx1013 target

rampitec added inline comments. Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.intersect_ray.ll:4 +; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1013 -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s +; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1012 -v

[PATCH] D103663: [AMDGPU] Add gfx1013 target

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:4697 + if (!ST.hasGFX10_AEncoding()) { +DiagnosticInfoUnsupported BadIntrin(B.getMF().getFunction(), "intrinsic not supported on subtarget", +M

[PATCH] D103663: [AMDGPU] Add gfx1013 target

rampitec added inline comments. Comment at: llvm/test/CodeGen/AMDGPU/GlobalISel/llvm.amdgcn.intersect_ray.ll:4 +; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1013 -verify-machineinstrs < %s | FileCheck -check-prefix=GCN %s +; RUN: llc -global-isel -march=amdgcn -mcpu=gfx1012 -v

[PATCH] D103663: [AMDGPU] Add gfx1013 target

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:4700 +B.getMF().getFunction().getContext().diagnose(BadIntrin); +B.buildUndef(MI.getOperand(0)); +MI.eraseFromParent(); rampitec wrote: > Just return false like

[PATCH] D103663: [AMDGPU] Add gfx1013 target

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/AMDGPULegalizerInfo.cpp:4701 +B.getMF().getFunction().getContext().diagnose(BadIntrin); +B.buildUndef(MI.getOperand(0)); +MI.eraseFromParent(); You can just omit undef and erase. CHA

[PATCH] D104804: [AMDGPU] Add gfx1035 target

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104804/new/ https://reviews.llvm.org/D104804 ___

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec requested changes to this revision. rampitec added a comment. This revision now requires changes to proceed. Needs an IR test, a test for different supported targets, and a negative test for unsupported features. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.de

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

rampitec requested changes to this revision. rampitec added a comment. This revision now requires changes to proceed. You cannot do it in a generic llvm code, it simply has no knowledge of what was the reason for BE's choice. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:5

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

rampitec added a comment. In D106891#2921048 , @gandhi21299 wrote: > @rampitec should the unsafe check go in some pass later in the pipeline then? No. The only place which has all the knowledge is `SITargetLowering::shouldExpandAtomicRMWInIR()`. That i

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16212 + case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmax_f64: { +Intrinsic::ID IID; +llvm::Type *ArgTy = llvm::Type::getDoubleTy(getLLVMContext()); gandhi21299 wrote: > rampitec

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16212 + case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmax_f64: { +Intrinsic::ID IID; +llvm::Type *ArgTy = llvm::Type::getDoubleTy(getLLVMContext()); arsenm wrote: > rampitec wrote

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16212 + case AMDGPU::BI__builtin_amdgcn_flat_atomic_fmax_f64: { +Intrinsic::ID IID; +llvm::Type *ArgTy = llvm::Type::getDoubleTy(getLLVMContext()); arsenm wrote: > rampitec wrote

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16270 +llvm::Function *F = CGM.getIntrinsic(IID, {ArgTy}); +return Builder.CreateCall(F, {Addr, Val, ZeroI32, ZeroI32, ZeroI1}); + } Should we map flags since we already have the

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

rampitec added a comment. In D106891#2921096 , @gandhi21299 wrote: > @rampitec Since remarks cannot be emitted in SIISelLowering because it isn't > a pass, in what form can I emit the diagnostics in SIISelLowering? You could pass ORE to the TLI. Repo

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

rampitec added a comment. In D106891#2921108 , @gandhi21299 wrote: > How can I construct an ORE to start off with? I don't think its appropriate > to construct it in `shouldExpandAtomicRMWInsts(RMW)` You have already constructed it. You can just pass i

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added a comment. In D106909#2922567 , @gandhi21299 wrote: > @rampitec how do I handle the following? > > builtins-fp-atomics.cl:38:10: error: > '__builtin_amdgcn_global_atomic_fadd_f64' needs target feature > atomic-fadd-insts > *rtn = _

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added a comment. In D106909#2923724 , @gandhi21299 wrote: > @rampitec what should I be testing exactly in the IR test? Produced call to the intrinsic. All of these tests there doing that. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:16270 +llvm::Function *F = CGM.getIntrinsic(IID, {ArgTy}); +return Builder.CreateCall(F, {Addr, Val, ZeroI32, ZeroI32, ZeroI1}); + } gandhi21299 wrote: > rampitec wrote: > > gand

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

rampitec added a comment. It still does not do anything useful and still produces useless, wrong and misleading remarks for all targets. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 __

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

rampitec added inline comments. Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:595 + OptimizationRemark Remark(DEBUG_TYPE, "Passed", RMW->getFunction()); + Remark << "A hardware instruction was generated"; + return Remark; Nothing was generated

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

rampitec added a comment. In D106891#2925692 , @gandhi21299 wrote: > - eliminated the scope argument as per discussion > - added more tests You have updated wrong patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

rampitec added a comment. JBTW, patch title is way too long. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added inline comments. Comment at: clang/include/clang/Basic/BuiltinsAMDGPU.def:201 +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_f32, "ff*1f", "t", "gfx90a-insts") +TARGET_BUILTIN(__builtin_amdgcn_global_atomic_fadd_v2f16, "V2hV2h*1V2h", "t", "gfx90a-insts") +TA

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics in GFX90A

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12139 +OptimizationRemark Remark(DEBUG_TYPE, "Passed", RMW->getFunction()); +Remark << "A hardware instruction was generated"; +return Remark; gandhi2129

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics in GFX90A

rampitec added a comment. The title should not mention gfx90a, it is not true. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106891/new/ https://reviews.llvm.org/D106891 ___ cfe-commits mailing list cfe-

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec added inline comments. Comment at: clang/test/CodeGenOpenCL/builtins-fp-atomics-unsupported-gfx7.cl:8 +} \ No newline at end of file Add new line. Comment at: clang/test/CodeGenOpenCL/unsupported-fadd2f16-gfx908.cl:1 +// REQUIRES: amd

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12146 +OptimizationRemark Remark(DEBUG_TYPE, "Passed", RMW->getFunction()); +Remark << "A floating-point atomic instruction will generate an unsafe" + " hardware

[PATCH] D106909: [clang] Add clang builtins support for gfx90a

rampitec accepted this revision. rampitec added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106909/new/ https://reviews.llvm.org/D106909 ___

[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

rampitec added inline comments. Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12155 + OptimizationRemark Remark(DEBUG_TYPE, "Passed", RMW->getFunction()); + Remark << "A floating-point atomic instruction with no following use" +" will

  1   2   >