stanionascu updated this revision to Diff 92367.
stanionascu edited the summary of this revision.
stanionascu added a comment.
- removed unrelated new line change
- extended the "clang.path" description a bit
- removed defaultValue for getConfig<>, as it's anyway "contributed" by
extension packag
stanionascu added inline comments.
Comment at: clangd/clients/clangd-vscode/package.json:45
+"default": "clangd",
+"description": "The path to clangd executable"
+},
krasimir wrote:
> krasimir wrote:
> > May
stanionascu added a comment.
Thanks for review!
Would be great if somebody would commit it, as I cannot do it myself.
https://reviews.llvm.org/D31121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
stanionascu created this revision.
rfc8089#appendix-E.2 specifies that paths can begin with a drive letter e.g. as
file:///c:/.
In this case just consuming front file:// is not enough and the 3rd slash must
be consumed to produce a valid path on windows.
The patch introduce a generic way of con
stanionascu added inline comments.
Comment at: clangd/Protocol.cpp:613
+ if (CI.kind != CompletionItemKind::Missing)
+Os << R"("kind":)" << static_cast(CI.kind) << R"(",)";
+ if (!CI.detail.empty())
if kind is actually provided there will be a trailing quot
stanionascu updated this revision to Diff 94271.
stanionascu added a comment.
Refactored URI handling to make it more explicit, also updated the parts which
expect a File parameter and not an URI.
https://reviews.llvm.org/D31401
Files:
clangd/ASTManager.cpp
clangd/ASTManager.h
clangd/Doc
stanionascu marked 5 inline comments as done.
stanionascu added inline comments.
Comment at: clangd/Protocol.cpp:61
if (KeyValue == "uri") {
- Result.uri = Value->getValue(Storage);
+ Result.uri = Uri::parse(Value->getValue(Storage));
} else if (KeyValue == "v
stanionascu marked 2 inline comments as done.
stanionascu added a comment.
Thank you for the review!
If there are no other comments/suggestions, would be great if someone would
merge it as I'm lacking the permission to do so.
https://reviews.llvm.org/D31401
_
stanionascu created this revision.
stanionascu added a project: clang-tools-extra.
The patch implements the conversion method from CXCursorKind to
clangd::CompletionItemKind.
https://reviews.llvm.org/D31853
Files:
clangd/ASTManager.cpp
clangd/Protocol.cpp
test/clangd/completion.test
Ind
stanionascu updated this revision to Diff 94716.
stanionascu added a comment.
recreated from svn checkout
https://reviews.llvm.org/D31853
Files:
clangd/ASTManager.cpp
clangd/Protocol.cpp
test/clangd/completion.test
Index: test/clangd/completion.test
==
stanionascu updated this revision to Diff 94720.
stanionascu added a comment.
One more try updating the revision on fresh git+svn clone.
https://reviews.llvm.org/D31853
Files:
clangd/ASTManager.cpp
clangd/Protocol.cpp
test/clangd/completion.test
Index: test/clangd/completion.test
===
stanionascu added a comment.
In https://reviews.llvm.org/D31853#722219, @krasimir wrote:
> Looks good! However it would be easier for reviewers if you could please use
> arc: http://llvm.org/docs/Phabricator.html#id2
> This makes it easy since I only have to do `arc patch D31853` in order to
>
12 matches
Mail list logo
