[PATCH] D150931: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

2023-05-18 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: tahonermann. Herald added a subscriber: steakhal. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch adds missing assignment operator to the class which h

[PATCH] D150931: [NFC][Clang][Coverity] Fix Static Code Analysis Concerns with copy without assign

2023-05-18 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 523649. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150931/new/ https://reviews.llvm.org/D150931 Files: clang/include/clang/Analysis/Analyses/ThreadSafetyTIL.h clang/include/clang/StaticAnalyzer/Core/PathSensitive/CallEvent.h Index: clang/includ

[PATCH] D150960: [NFC] Fix uninitialized scalar variable found by Coverity static analyzer tool

2023-05-19 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: zturner. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: LLVM. Herald added a subscriber:

[PATCH] D150960: [NFC] Fix uninitialized scalar variable found by Coverity static analyzer tool

2023-05-19 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. I am closing this PR. The change is not correct. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150960/new/ https://reviews.llvm.org/D150960 ___ cfe-commits mailing list cfe-commits

[PATCH] D150960: [NFC] Fix uninitialized scalar variable found by Coverity static analyzer tool

2023-05-19 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 523735. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150960/new/ https://reviews.llvm.org/D150960 Files: llvm/include/llvm/Demangle/MicrosoftDemangle.h Index: llvm/include/llvm/Demangle/MicrosoftDemangle.h =

[PATCH] D148189: [NFC][Clang] Fix static analyzer tool remark about missing user-defined assignment operator

2023-04-17 Thread Soumi Manna via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7e1b62bd9ca8: [NFC][Clang] Fix static analyzer tool remark about missing user-defined… (authored by Manna). Repository: rG LLVM Github Monorepo C

[PATCH] D147708: [NFC][clang] Fix static analyzer tool remarks about large copies by values

2023-04-17 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thanks @erichkeane for the suggestion. I will follow it in future commits. In D147708#4255361 , @erichkeane wrote: > Note, in the future, if in your commit message you do: > > `Differential Revision: ` > > the review will auto-clo

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

2023-04-18 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added reviewers: tahonermann, aaron.ballman. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware, kristof.beyls. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested

[PATCH] D147901: [NFC][CLANG][API] Fix coverity remarks about large copies by values

2023-04-18 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you everyone for reviews and feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147901/new/ https://reviews.llvm.org/D147901 ___ cfe-commits mailing list cfe-commits@lis

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

2023-04-20 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 515318. Manna added a comment. Thank you everyone for reviews and feedbacks. I misunderstood some of the False positive Coverity cases. Thanks for the explanation and suggestions. I will keep this in mind while investigating static analysis in future. This pat

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

2023-04-20 Thread Soumi Manna via Phabricator via cfe-commits
Manna marked 7 inline comments as done. Manna added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:9426 } else { for (auto IvarPair : DuplicateIvars) { Diag(IvarPair.first->getLocation(), tahonermann wrote: > aaron.b

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

2023-04-20 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: luke, manas, frasercrmck, ASDenysPetrov, luismarques, apazos, sameer.abuasal, s.egerton, Jim, dkrupp, donat.nagy, jocewei, Szelethus, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, a.sidorin, edward-jon

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

2023-04-20 Thread Soumi Manna via Phabricator via cfe-commits
Manna added inline comments. Comment at: clang/lib/AST/ASTContext.cpp:8206 - for (auto B : CXXRD->bases()) + for (const auto &B : CXXRD->bases()) if (hasTemplateSpecializationInEncodedString(B.getType().getTypePtr(), CXXBaseSpecifier is less in size, but

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

2023-04-20 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 515494. Manna marked an inline comment as done and an inline comment as not done. Manna edited the summary of this revision. Manna added a comment. I have removed the case involving the `Policy` class CHANGES SINCE LAST ACTION https://reviews.llvm.org/D14881

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

2023-04-20 Thread Soumi Manna via Phabricator via cfe-commits
Manna marked an inline comment as done. Manna added a comment. Thank you @tahonermann and @erichkeane for reviews and feedback. Comment at: clang/utils/TableGen/ClangAttrEmitter.cpp:4262 // will be using. - for (auto I : Attrs) { + for (const auto &I : Attrs) { const

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

2023-04-21 Thread Soumi Manna via Phabricator via cfe-commits
Manna marked an inline comment as done. Manna added a comment. @aaron.ballman, do you have any more concerns or comments? Thank you CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148639/new/ https://reviews.llvm.org/D148639 ___ cfe-commits mai

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

2023-04-21 Thread Soumi Manna via Phabricator via cfe-commits
Manna marked an inline comment as done. Manna added a comment. @erichkeane do you have any more concerns? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148812/new/ https://reviews.llvm.org/D148812 ___ cfe-commits mailing list cfe-commits@list

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

2023-04-21 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 515729. Manna edited the summary of this revision. Manna added a comment. I have addressed @erichkeane's review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148812/new/ https://reviews.llvm.org/D148812 Files: clang/lib/AST/ASTContext.cpp

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

2023-04-21 Thread Soumi Manna via Phabricator via cfe-commits
Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/Lex/Pragma.cpp:1110 Module *M = nullptr; - for (auto IIAndLoc : ModuleName) { + for (const auto &IIAndLoc : ModuleName) { M = MM.lookupModuleQualified(IIAndLoc.fir

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

2023-04-23 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. In D148639#4284085 , @tahonermann wrote: > This set of changes looks good to me. Thank you @tahonermann CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148639/new/ https://reviews.llvm.org/D148639 ___

[PATCH] D148812: [NFC][clang] Fix static analyzer concerns

2023-04-23 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Manna marked an inline comment as done. Closed by commit rGff4d2207db00: [NFC][clang] Fix static analyzer concerns (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

2023-04-24 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: kosarev, tpr. Herald added a reviewer: aaron.ballman. Herald added a reviewer: ributzka. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDevelo

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

2023-04-24 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 516445. Manna edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149074/new/ https://reviews.llvm.org/D149074 Files: clang/include/clang/ExtractAPI/ExtractAPIVisitor.h clang/lib/AST/ComputeDependence.cpp clang/lib/

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

2023-04-24 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 516488. Manna marked 7 inline comments as done. Manna edited the summary of this revision. Manna added a comment. I have addressed @tahonermann review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149074/new/ https://reviews.llvm.org/D149074

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

2023-04-24 Thread Soumi Manna via Phabricator via cfe-commits
Manna added inline comments. Comment at: clang/utils/TableGen/NeonEmitter.cpp:392 -for (auto Type : Types) { +for (const auto &Type : Types) { // If this builtin takes an immediate argument, we need to #define it rather tahonermann wrote: > The

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

2023-04-24 Thread Soumi Manna via Phabricator via cfe-commits
Manna added inline comments. Comment at: clang/lib/Sema/SemaLookup.cpp:4662 - for (auto KNPair : KnownNamespaces) + for (const auto &KNPair : KnownNamespaces) Namespaces.addNameSpecifier(KNPair.first); tahonermann wrote: > The element type is a pair of `

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

2023-04-24 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. In D149074#4293543 , @tahonermann wrote: > Looks good to me Thank you @tahonermann CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149074/new/ https://reviews.llvm.org/D149074

[PATCH] D149074: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY

2023-04-24 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG38ecb9767c14: [NFC][clang] Fix Coverity bugs with AUTO_CAUSES_COPY (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149074/new/ https://re

[PATCH] D149163: [NFC][CLANG] Fix coverity remarks about large copy by values

2023-04-25 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: tahonermann. Herald added a subscriber: arphaman. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. Reported By Static Analyzer Tool, Coverity: Big parameter passed by value Copying large value

[PATCH] D149163: [NFC][CLANG] Fix coverity remarks about large copy by values

2023-04-25 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 516834. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149163/new/ https://reviews.llvm.org/D149163 Files: clang/include/clang/Sema/CodeCompleteConsumer.h clang/lib/CodeGen/CGGPUBuiltin.cpp clang/lib/CodeGen/CGNonTrivialStruct.cpp clang/lib/Code

[PATCH] D149163: [NFC][CLANG] Fix coverity remarks about large copy by values

2023-04-25 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 516883. Manna added a comment. Herald added a subscriber: kadircet. Herald added a project: clang-tools-extra. Fix bot failures CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149163/new/ https://reviews.llvm.org/D149163 Files: clang-tools-extra/clan

[PATCH] D149163: [NFC][CLANG] Fix coverity remarks about large copy by values

2023-04-25 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 517010. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149163/new/ https://reviews.llvm.org/D149163 Files: clang-tools-extra/clangd/CodeComplete.cpp clang/include/clang/Sema/CodeCompleteConsumer.h clang/lib/CodeGen/CodeGenModule.cpp clang/lib/Co

[PATCH] D149163: [NFC][CLANG] Fix coverity remarks about large copy by values

2023-04-25 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 517018. Manna edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149163/new/ https://reviews.llvm.org/D149163 Files: clang/lib/CodeGen/CGGPUBuiltin.cpp clang/lib/CodeGen/CGNonTrivialStruct.cpp clang/lib/CodeGen/Cod

[PATCH] D149163: [NFC][CLANG] Fix coverity remarks about large copy by values

2023-04-28 Thread Soumi Manna via Phabricator via cfe-commits
Manna marked 4 inline comments as done. Manna added inline comments. Comment at: clang/lib/CodeGen/CGGPUBuiltin.cpp:128 -bool containsNonScalarVarargs(CodeGenFunction *CGF, CallArgList Args) { +bool containsNonScalarVarargs(CodeGenFunction *CGF, const CallArgList &Args) { re

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

2023-04-28 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a reviewer: jdoerfert. Herald added sub

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

2023-04-28 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 517964. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149461/new/ https://reviews.llvm.org/D149461 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/Serialization/ASTReader.cpp clang/lib/Serialization/ASTWriter.cpp Index: clang/lib/Seri

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

2023-04-28 Thread Soumi Manna via Phabricator via cfe-commits
Manna added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:4428 // Mark selectors as out of date. - for (auto Sel : SelectorGeneration) + for (const auto &Sel : SelectorGeneration) SelectorOutOfDate[Sel.first] = true; Here Object of

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

2023-04-28 Thread Soumi Manna via Phabricator via cfe-commits
Manna added inline comments. Comment at: clang/lib/Serialization/ASTReader.cpp:7696 if (isa(DC)) { -for (auto Lexical : TULexicalDecls) +for (const auto &Lexical : TULexicalDecls) Visit(Lexical.first, Lexical.second); This returns `std::vector`

[PATCH] D149163: [NFC][CLANG] Fix coverity remarks about large copy by values

2023-04-28 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Manna marked 3 inline comments as done. Closed by commit rG4faf3fcf3fb2: [NFC][CLANG] Fix coverity remarks about large copy by values (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D148639: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY

2023-04-28 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe52a8b89adda: [NFC][clang] Fix static analyzer concerns about AUTO_CAUSES_COPY (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148639/new/

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

2023-04-30 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 518347. Manna edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149461/new/ https://reviews.llvm.org/D149461 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/Serialization/ASTReader.cpp clang/lib/Serializ

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

2023-04-30 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 518373. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149461/new/ https://reviews.llvm.org/D149461 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/Serialization/ASTReader.cpp clang/lib/Serialization/ASTWriter.cpp Index: clang/lib/Seri

[PATCH] D149461: [NFC] ][CLANG] Fix static code analyzer concerns

2023-04-30 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 518375. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149461/new/ https://reviews.llvm.org/D149461 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/lib/Serialization/ASTReader.cpp clang/lib/Serialization/ASTWriter.cpp Index: clang/lib/Seri

[PATCH] D149631: [NFC][CLANG] Fix static analyzer codes concerns about large copies by value

2023-05-01 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: aaron.ballman. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDevelop

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

2023-05-02 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: tahonermann. Herald added subscribers: manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added projects: All, clang, clang-format. Herald added reviewers: rymiel, HazardyKnusperkeks, owenpan, MyDeveloperD

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

2023-05-02 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @erichkeane and @tahonermann for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149647/new/ https://reviews.llvm.org/D149647 ___ cfe-commits mailing list cfe-comm

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

2023-05-02 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: tahonermann. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch adds missing assignment operator to the class which has user-defined copy/move constructo

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by value

2023-05-03 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thanks @erichkeane for response. @MyDeveloperDay, Our internal Coverity link won't work without login. This is what Coverity was complaining about. Big parameter passed by value Copying large values is inefficient, consider passing by reference; Low, medium, and high siz

[PATCH] D149718: [NFC][Clang] Fix Coverity issues of copy without assign

2023-05-03 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 519331. Manna added a comment. Fix clang-format errors and typo in comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149718/new/ https://reviews.llvm.org/D149718 Files: clang/include/clang/Analysis/BodyFarm.h clang/include/clang/Sema/ParsedA

[PATCH] D149647: [NFC][Clang]Fix static analyzer tool remarks about large copies by values

2023-05-03 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 519337. Manna retitled this revision from "[NFC][Clang]Fix static analyzer tool remarks about large copies by value" to "[NFC][Clang]Fix static analyzer tool remarks about large copies by values". Manna edited the summary of this revision. Manna added a comment

[PATCH] D152107: [NFC][CLANG] Fix nullptr dereference issue in checkSizelessVectorShift()

2023-06-05 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @erichkeane for reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152107/new/ https://reviews.llvm.org/D152107 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D152107: [NFC][CLANG] Fix nullptr dereference issue in checkSizelessVectorShift()

2023-06-05 Thread Soumi Manna via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG3581e6b857f4: [NFC][CLANG] Fix nullptr dereference issue in checkSizelessVectorShift() (authored by Manna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152

[PATCH] D152194: [NFC][CLANG] Fix nullptr dereference issue found by static analyzer tool

2023-06-05 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: steakhal, manas, ASDenysPetrov, martong, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Hera

[PATCH] D152194: [NFC][CLANG] Fix nullptr dereference issue found by static analyzer tool

2023-06-05 Thread Soumi Manna via Phabricator via cfe-commits
Manna added inline comments. Comment at: clang/lib/StaticAnalyzer/Checkers/DynamicTypePropagation.cpp:756 if (ReceiverType->isObjCIdType() || ReceiverType->isObjCClassType() || ASTCtxt.canAssignObjCInterfaces(ReceiverObjectPtrType, TrackedType)) { const ObjCI

[PATCH] D152197: [NFC][CLANG] Fix static analyzer bugs with dereference after null check

2023-06-05 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: erichkeane. Herald added subscribers: ctetreau, manas, ASDenysPetrov, dkrupp, donat.nagy, Szelethus, a.sidorin, baloghadamsoftware. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch

[PATCH] D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool

2023-06-06 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 529133. Manna retitled this revision from "[NFC][CLANG] Fix nullptr dereference issue found by static analyzer tool" to "[StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool". Manna edited the summary of this revision. Manna added a comm

[PATCH] D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()

2023-06-06 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 529138. Manna retitled this revision from "[NFC][CLANG] Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()" to "Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()". Manna edited the sum

[PATCH] D152197: Fix static analyzer bugs with null pointer dereferences in CheckSizelessVectorOperands()

2023-06-06 Thread Soumi Manna via Phabricator via cfe-commits
Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:11148 if (LHSType->isVLSTBuiltinType() && RHSType->isVLSTBuiltinType() && Context.getBuiltinVectorTypeInfo(LHSBuiltinTy).EC != Context.getBuiltinVecto

[PATCH] D153033: [NFC][CLANG] Fix potential null pointer dereference bugs

2023-06-15 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added a reviewer: erichkeane. Herald added a reviewer: NoQ. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. This patch uses castAs instead of getAs which will assert if the type doesn't match and adds nullptr

[PATCH] D153033: [NFC][CLANG] Fix potential null pointer dereference bugs

2023-06-15 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 531766. Manna added a comment. Fix build error CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153033/new/ https://reviews.llvm.org/D153033 Files: clang/lib/AST/ASTContext.cpp clang/lib/AST/MicrosoftMangle.cpp clang/lib/Analysis/ThreadSafety.cpp

[PATCH] D153033: [NFC][CLANG] Fix potential null pointer dereference bugs

2023-06-15 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 531773. Manna added a comment. Update patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153033/new/ https://reviews.llvm.org/D153033 Files: clang/lib/AST/ASTContext.cpp clang/lib/AST/MicrosoftMangle.cpp clang/lib/Analysis/ThreadSafety.cpp c

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

2023-06-15 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 531976. Manna retitled this revision from "[NFC][CLANG] Fix potential null pointer dereference bugs" to "[CLANG]Fix potential null pointer dereference bugs". Manna added a comment. Herald added subscribers: steakhal, martong. Address review comment and update p

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

2023-06-15 Thread Soumi Manna via Phabricator via cfe-commits
Manna added inline comments. Comment at: clang/lib/Analysis/ThreadSafety.cpp:505-511 const unsigned *i = C.lookup(D); llvm::errs() << " -> "; + if (!i) { +llvm::errs() << "<>"; +return; + } dumpVarDefinitionName(*i);

[PATCH] D152194: [StaticAnalyzer] Fix nullptr dereference issue found by static analyzer tool

2023-06-15 Thread Soumi Manna via Phabricator via cfe-commits
Manna added a comment. Thank you @erichkeane and @steakhal for reviews and comments. In D152194#4402377 , @steakhal wrote: > Please update the title and the summary of this patch to reflect what it > actually achieves. > We also usually use the `[analyz

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

2023-06-16 Thread Soumi Manna via Phabricator via cfe-commits
Manna updated this revision to Diff 532138. Manna added a comment. Address review comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153033/new/ https://reviews.llvm.org/D153033 Files: clang/lib/AST/ASTContext.cpp clang/lib/AST/MicrosoftMangle.cpp clang/lib/Analysis/ThreadSaf

[PATCH] D153033: [CLANG]Fix potential null pointer dereference bugs

2023-06-16 Thread Soumi Manna via Phabricator via cfe-commits
Manna marked an inline comment as done. Manna added inline comments. Comment at: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp:3368 - VD = VD->getCanonicalDecl(); + VD = cast(VD->getCanonicalDecl()); auto I = FunctionGlobalizedDecls.find(CGF.CurFn); aaron.ballm

[PATCH] D153146: [CLANG] Fix potential integer overflow value in getRVVTypeSize()

2023-06-16 Thread Soumi Manna via Phabricator via cfe-commits
Manna created this revision. Manna added reviewers: erichkeane, aaron.ballman, tahonermann. Herald added a project: All. Manna requested review of this revision. Herald added a project: clang. In getRVVTypeSize(clang::​ASTContext &, clang::​BuiltinType const *) potential integer overflow occurs o

<    1   2   3