[PATCH] D136080: [flang] Add -ffp-contract option processing

vzakhari added inline comments. Comment at: flang/include/flang/Frontend/LangOptions.h:29 + +// Enable the floating point pragma +FPM_On, tblah wrote: > awarzynski wrote: > > What are these pragmas? Perhaps you can add a test that would include them? > I

[PATCH] D136080: [flang] Add -ffp-contract option processing

vzakhari added inline comments. Comment at: flang/include/flang/Frontend/LangOptions.h:29 + +// Enable the floating point pragma +FPM_On, tblah wrote: > vzakhari wrote: > > tblah wrote: > > > awarzynski wrote: > > > > What are these pragmas? Perhaps you c

[PATCH] D136080: [flang] Add -ffp-contract option processing

vzakhari added inline comments. Comment at: clang/lib/Driver/ToolChains/Flang.cpp:94 + << Val << A->getOption().getName() << "fast"; + FPContract = "fast"; +} else I know I suggested myself mapping `on` to `fast`, but it seems it will be more r

[PATCH] D136080: [flang] Add -ffp-contract option processing

vzakhari accepted this revision. vzakhari added a comment. This revision is now accepted and ready to land. Thank you! LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D136080/new/ https://reviews.llvm.org/D136080 ___ cfe-commits mailing lis

[PATCH] D131808: [clang,flang] Add missing options fsyntax-only in help

vzakhari accepted this revision. vzakhari added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131808/new/ https://reviews.llvm.org/D131808 __

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

vzakhari added inline comments. Comment at: flang-rt/CMakeLists.txt:17-23 +# Check if flang-rt is built as a standalone project. +if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR OR FLANG_RT_STANDALONE_BUILD) + project(FlangRT C CXX) + set(CMAKE_INCLUDE_CURRENT_DIR ON) +

[PATCH] D154869: [Flang] [FlangRT] Implement FlangRT library as solution to Flang's runtime LLVM integration

vzakhari added inline comments. Comment at: flang-rt/CMakeLists.txt:17-23 +# Check if flang-rt is built as a standalone project. +if (CMAKE_SOURCE_DIR STREQUAL CMAKE_CURRENT_SOURCE_DIR OR FLANG_RT_STANDALONE_BUILD) + project(FlangRT C CXX) + set(CMAKE_INCLUDE_CURRENT_DIR ON) +

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

vzakhari added a comment. Thank you for working on this! Comment at: flang/include/flang/Tools/CLOptions.inc:235 +/// passes pipeline +inline void createHLFIRToFIRPassPipeline(mlir::PassManager &pm, +llvm::OptimizationLevel optLevel = defaultOptLevel) { W

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

vzakhari added inline comments. Comment at: flang/include/flang/Tools/CLOptions.inc:238 + pm.addPass(mlir::createCanonicalizerPass()); + pm.addPass(hlfir::createLowerHLFIRIntrinsicsPass()); + pm.addPass(hlfir::createBufferizeHLFIRPass()); I would imagine we ma

[PATCH] D146278: [flang] add -flang-experimental-hlfir flag to flang-new

vzakhari added a comment. LGTM Please address @awarzynski's comment about the test. Comment at: flang/include/flang/Tools/CLOptions.inc:235 +/// passes pipeline +inline void createHLFIRToFIRPassPipeline(mlir::PassManager &pm, +llvm::OptimizationLevel optLevel = defaultOpt

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

vzakhari added inline comments. Comment at: flang/test/Driver/target-cpu-features.f90:1 -! REQUIRES: aarch64-registered-target, x86-registered-target +! REQUIRES: aarch64-registered-target, x86-registered-target, riscv-registered-target Can we split this test

[PATCH] D151088: [flang][hlfir] Separate -emit-fir and -emit-hlfir for flang-new

vzakhari accepted this revision. vzakhari added a comment. Thank you for the follow-up! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151088/new/ https://reviews.llvm.org/D151088 ___ cfe-commits mailing

[PATCH] D143301: [flang] Handle unsupported warning flags

vzakhari added a comment. The new tests fail to link: flang-new: warning: The warning option '-Wextra' is not supported /usr/bin/ld: cannot find -lFortran_main /usr/bin/ld: cannot find -lFortranRuntime /usr/bin/ld: cannot find -lFortranDecimal Is the linking really necessary? Repositor

[PATCH] D148958: Size and element numbers are often swapped when calling calloc

vzakhari added a comment. In D148958#4288728 , @MaskRay wrote: > This is an unnecessary change. The arguments are interchangeable. > In musl, there are at least 2 places where the parameters could be swapped, > but I not unsure this warrants a commit. I

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

vzakhari added a comment. In D148767#4315667 , @jobnoorman wrote: > Hi, this seems to have broken my bolt+debug+shared build. I don't think there > are build bots for this configuration but you can reproduce it like this: Same with flang+debug+shared b