[clang] 10d6562 - Fix "not all control paths return a value" MSVC warning. NFC.

2023-05-30 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2023-05-30T10:33:31+01:00 New Revision: 10d6562ff1bc0009024633b1fd6ab6c3abaea4b7 URL: https://github.com/llvm/llvm-project/commit/10d6562ff1bc0009024633b1fd6ab6c3abaea4b7 DIFF: https://github.com/llvm/llvm-project/commit/10d6562ff1bc0009024633b1fd6ab6c3abaea4b7.diff

[clang] c10138a - Fix MSVC "not all control paths return a value" warning. NFC.

2023-05-19 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2023-05-19T10:40:14+01:00 New Revision: c10138a54f7f50c7a4d92b79a8887c51c52e2c20 URL: https://github.com/llvm/llvm-project/commit/c10138a54f7f50c7a4d92b79a8887c51c52e2c20 DIFF: https://github.com/llvm/llvm-project/commit/c10138a54f7f50c7a4d92b79a8887c51c52e2c20.diff

[clang] b87e5a0 - Add missing llvm/Support/Compiler.h include for MSVC builds without __has_attribute

2023-05-19 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2023-05-19T10:39:31+01:00 New Revision: b87e5a046f6e3ee117c9f8cbe9ae368b30127b37 URL: https://github.com/llvm/llvm-project/commit/b87e5a046f6e3ee117c9f8cbe9ae368b30127b37 DIFF: https://github.com/llvm/llvm-project/commit/b87e5a046f6e3ee117c9f8cbe9ae368b30127b37.diff

[clang] c68e92d - Fix MSVC "not all control paths return a value" warning. NFC.

2023-05-03 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2023-05-03T10:23:41+01:00 New Revision: c68e92d941723702810093161be4834f3ca68372 URL: https://github.com/llvm/llvm-project/commit/c68e92d941723702810093161be4834f3ca68372 DIFF: https://github.com/llvm/llvm-project/commit/c68e92d941723702810093161be4834f3ca68372.diff

[clang] bf449be - [docs] Add missing empty line before lists

2023-06-14 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2023-06-14T11:42:09+01:00 New Revision: bf449be9677bf9fd8c591512cfba152250170432 URL: https://github.com/llvm/llvm-project/commit/bf449be9677bf9fd8c591512cfba152250170432 DIFF: https://github.com/llvm/llvm-project/commit/bf449be9677bf9fd8c591512cfba152250170432.diff

[clang] 00b1dd8 - [docs] Add missing empty line at start of code-block

2023-06-14 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2023-06-14T12:49:07+01:00 New Revision: 00b1dd82d72f4000c26c28e1471128569255dadc URL: https://github.com/llvm/llvm-project/commit/00b1dd82d72f4000c26c28e1471128569255dadc DIFF: https://github.com/llvm/llvm-project/commit/00b1dd82d72f4000c26c28e1471128569255dadc.diff

[clang] 7e20e13 - [docs] Add missing label

2023-06-14 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2023-06-14T13:08:07+01:00 New Revision: 7e20e13dd88bb9f2d7665186d97632846e566304 URL: https://github.com/llvm/llvm-project/commit/7e20e13dd88bb9f2d7665186d97632846e566304 DIFF: https://github.com/llvm/llvm-project/commit/7e20e13dd88bb9f2d7665186d97632846e566304.diff

[clang-tools-extra] fceec8d - Fix MSVC "not all control paths return a value" warning. NFC.

2022-12-05 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2022-12-05T10:39:54Z New Revision: fceec8dcd8da66fa611e7fd104052fa37b65aecb URL: https://github.com/llvm/llvm-project/commit/fceec8dcd8da66fa611e7fd104052fa37b65aecb DIFF: https://github.com/llvm/llvm-project/commit/fceec8dcd8da66fa611e7fd104052fa37b65aecb.diff LOG:

[clang] cebc348 - Fix MSVC "not all control paths return a value" warning. NFC.

2022-12-08 Thread Simon Pilgrim via cfe-commits
Author: Simon Pilgrim Date: 2022-12-08T11:44:18Z New Revision: cebc348f6735b1fb5607e408dfe2e4d34abe0002 URL: https://github.com/llvm/llvm-project/commit/cebc348f6735b1fb5607e408dfe2e4d34abe0002 DIFF: https://github.com/llvm/llvm-project/commit/cebc348f6735b1fb5607e408dfe2e4d34abe0002.diff LOG:

r290063 - Wdocumentation fix

2016-12-18 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Sun Dec 18 08:12:38 2016 New Revision: 290063 URL: http://llvm.org/viewvc/llvm-project?rev=290063&view=rev Log: Wdocumentation fix Modified: cfe/trunk/include/clang/Basic/OpenCLOptions.h Modified: cfe/trunk/include/clang/Basic/OpenCLOptions.h URL: http://llvm.org/viewv

r290258 - Wdocumentation fix

2016-12-21 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Wed Dec 21 10:39:09 2016 New Revision: 290258 URL: http://llvm.org/viewvc/llvm-project?rev=290258&view=rev Log: Wdocumentation fix Modified: cfe/trunk/include/clang/Sema/Sema.h Modified: cfe/trunk/include/clang/Sema/Sema.h URL: http://llvm.org/viewvc/llvm-project/cfe/t

r290547 - Wdocumentation fix

2016-12-26 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Mon Dec 26 12:11:49 2016 New Revision: 290547 URL: http://llvm.org/viewvc/llvm-project?rev=290547&view=rev Log: Wdocumentation fix Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp Modified: cfe/trunk/lib/Sema/SemaTemplateDeduction.cpp URL: http://llvm.org/viewvc/

r290773 - Wdocumentation fix

2016-12-30 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Fri Dec 30 16:55:33 2016 New Revision: 290773 URL: http://llvm.org/viewvc/llvm-project?rev=290773&view=rev Log: Wdocumentation fix Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/t

Re: r290773 - Wdocumentation fix

2016-12-31 Thread Simon Pilgrim via cfe-commits
On 30/12/2016 23:12, Richard Smith wrote: On 30 Dec 2016 3:06 pm, "Simon Pilgrim via cfe-commits" mailto:cfe-commits@lists.llvm.org>> wrote: Author: rksimon Date: Fri Dec 30 16:55:33 2016 New Revision: 290773 URL: http://llvm.org/viewvc/llvm-project?rev

r279382 - Wdocumentation fix

2016-08-20 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Sat Aug 20 15:21:27 2016 New Revision: 279382 URL: http://llvm.org/viewvc/llvm-project?rev=279382&view=rev Log: Wdocumentation fix Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp Modified: cfe/trunk/lib/Analysis/CloneDetection.cpp URL: http://llvm.org/viewvc/llvm-p

r280917 - Fixed a 'not all control paths return a value' warning on MSVC builds

2016-09-08 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Sep 8 04:59:58 2016 New Revision: 280917 URL: http://llvm.org/viewvc/llvm-project?rev=280917&view=rev Log: Fixed a 'not all control paths return a value' warning on MSVC builds Modified: cfe/trunk/lib/CodeGen/CGVTables.cpp Modified: cfe/trunk/lib/CodeGen/CGVTables.

r280921 - Moved unreachable to appease msvc, gcc and clang

2016-09-08 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Sep 8 06:03:41 2016 New Revision: 280921 URL: http://llvm.org/viewvc/llvm-project?rev=280921&view=rev Log: Moved unreachable to appease msvc, gcc and clang Modified: cfe/trunk/lib/CodeGen/CGVTables.cpp Modified: cfe/trunk/lib/CodeGen/CGVTables.cpp URL: http://llvm

Re: [PATCH] D21021: [Clang][AVX512][BuiltIn]Adding intrinsics move_{sd|ss} to clang

2016-09-16 Thread Simon Pilgrim via cfe-commits
RKSimon added a subscriber: RKSimon. Comment at: lib/Headers/avx512fintrin.h:9124 @@ +9123,3 @@ +{ + return (__m128) __builtin_ia32_movss_mask ((__v4sf) __A, (__v4sf) __B, + (__v4sf) __W, delena wrote: > please try the following: > if (__U) > retu

r297784 - Fix Wdocumentation warning

2017-03-14 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Tue Mar 14 16:43:52 2017 New Revision: 297784 URL: http://llvm.org/viewvc/llvm-project?rev=297784&view=rev Log: Fix Wdocumentation warning Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp Modified: cfe/trunk/lib/CodeGen/CGDecl.cpp URL: http://llvm.org/viewvc/llvm-project/cfe

r297885 - [X86][XOP] Add codegen tests for vector integer comparison intrinsics (PR15844)

2017-03-15 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Wed Mar 15 15:20:43 2017 New Revision: 297885 URL: http://llvm.org/viewvc/llvm-project?rev=297885&view=rev Log: [X86][XOP] Add codegen tests for vector integer comparison intrinsics (PR15844) We were testing for the generic _mm_com_* intrinsics, but not the specific compari

r297905 - Remove repeated code (PR32250). NFCI.

2017-03-15 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Wed Mar 15 17:43:36 2017 New Revision: 297905 URL: http://llvm.org/viewvc/llvm-project?rev=297905&view=rev Log: Remove repeated code (PR32250). NFCI. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/IteratorPastEndChecker.cpp Modified: cfe/trunk/lib/StaticAnalyzer/Checke

r298364 - [X86][AVX512] Add _mm512_cvtsd_f64 and _mm512_cvtss_f32 intrinsics (PR32305)

2017-03-21 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Tue Mar 21 07:46:13 2017 New Revision: 298364 URL: http://llvm.org/viewvc/llvm-project?rev=298364&view=rev Log: [X86][AVX512] Add _mm512_cvtsd_f64 and _mm512_cvtss_f32 intrinsics (PR32305) Differential Revision: https://reviews.llvm.org/D31155 Modified: cfe/trunk/lib/He

r298511 - [X86][MMX] Add tests for _mm_set*_* intrinsics

2017-03-22 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Wed Mar 22 09:55:43 2017 New Revision: 298511 URL: http://llvm.org/viewvc/llvm-project?rev=298511&view=rev Log: [X86][MMX] Add tests for _mm_set*_* intrinsics Modified: cfe/trunk/test/CodeGen/mmx-builtins.c Modified: cfe/trunk/test/CodeGen/mmx-builtins.c URL: http://ll

r298712 - Fix MSVC 'not all control paths return a value' warning.

2017-03-24 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Fri Mar 24 11:59:14 2017 New Revision: 298712 URL: http://llvm.org/viewvc/llvm-project?rev=298712&view=rev Log: Fix MSVC 'not all control paths return a value' warning. Modified: cfe/trunk/lib/Index/IndexingContext.cpp Modified: cfe/trunk/lib/Index/IndexingContext.cpp U

[clang-tools-extra] r299074 - Spelling mistakes in comments. NFCI.

2017-03-30 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Mar 30 08:10:33 2017 New Revision: 299074 URL: http://llvm.org/viewvc/llvm-project?rev=299074&view=rev Log: Spelling mistakes in comments. NFCI. Based on corrections mentioned in patch for clang for PR27635 Modified: clang-tools-extra/trunk/clang-rename/USRFinder.cp

r299083 - Spelling mistakes in comments. NFCI. (PR27635)

2017-03-30 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Mar 30 09:13:19 2017 New Revision: 299083 URL: http://llvm.org/viewvc/llvm-project?rev=299083&view=rev Log: Spelling mistakes in comments. NFCI. (PR27635) Modified: cfe/trunk/include/clang/AST/ASTContext.h cfe/trunk/include/clang/AST/Decl.h cfe/trunk/include/

r299193 - Strip trailing whitespace

2017-03-31 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Fri Mar 31 05:40:56 2017 New Revision: 299193 URL: http://llvm.org/viewvc/llvm-project?rev=299193&view=rev Log: Strip trailing whitespace Modified: cfe/trunk/include/clang/AST/ASTContext.h Modified: cfe/trunk/include/clang/AST/ASTContext.h URL: http://llvm.org/viewvc/l

r299198 - Spelling mistakes in comments. NFCI.

2017-03-31 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Fri Mar 31 06:00:53 2017 New Revision: 299198 URL: http://llvm.org/viewvc/llvm-project?rev=299198&view=rev Log: Spelling mistakes in comments. NFCI. Modified: cfe/trunk/include/clang/AST/ASTContext.h cfe/trunk/include/clang/AST/Decl.h cfe/trunk/lib/Sema/SemaCheck

[clang-tools-extra] r299642 - Wdocumentation fix

2017-04-06 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Apr 6 05:49:02 2017 New Revision: 299642 URL: http://llvm.org/viewvc/llvm-project?rev=299642&view=rev Log: Wdocumentation fix Modified: clang-tools-extra/trunk/clang-rename/USRLocFinder.h Modified: clang-tools-extra/trunk/clang-rename/USRLocFinder.h URL: http://ll

r300326 - [X86][SSE] Update MOVNTDQA non-temporal loads to generic implementation (clang)

2017-04-14 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Fri Apr 14 10:05:57 2017 New Revision: 300326 URL: http://llvm.org/viewvc/llvm-project?rev=300326&view=rev Log: [X86][SSE] Update MOVNTDQA non-temporal loads to generic implementation (clang) MOVNTDQA non-temporal aligned vector loads can be correctly represented using gene

[clang-tools-extra] r294299 - Disable test on windows buildbots without shell support

2017-02-07 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Tue Feb 7 07:08:22 2017 New Revision: 294299 URL: http://llvm.org/viewvc/llvm-project?rev=294299&view=rev Log: Disable test on windows buildbots without shell support Modified: clang-tools-extra/trunk/test/clangd/formatting.test Modified: clang-tools-extra/trunk/test/c

r307931 - Fix -Wdocumentation warning. NFCI

2017-07-13 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Jul 13 10:29:48 2017 New Revision: 307931 URL: http://llvm.org/viewvc/llvm-project?rev=307931&view=rev Log: Fix -Wdocumentation warning. NFCI Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h URL: http://llvm.org/vi

r307932 - Fix spelling mistakes in comments. NFCI.

2017-07-13 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Jul 13 10:34:44 2017 New Revision: 307932 URL: http://llvm.org/viewvc/llvm-project?rev=307932&view=rev Log: Fix spelling mistakes in comments. NFCI. Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.h URL: http://llvm

r322845 - Fix MSVC "uninitialized variable" warning.

2018-01-18 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Jan 18 05:28:54 2018 New Revision: 322845 URL: http://llvm.org/viewvc/llvm-project?rev=322845&view=rev Log: Fix MSVC "uninitialized variable" warning. Modified: cfe/trunk/tools/c-index-test/c-index-test.c Modified: cfe/trunk/tools/c-index-test/c-index-test.c URL: h

[clang-tools-extra] r323112 - Fix MSVC implicit double-float truncation warning. NFCI.

2018-01-22 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Mon Jan 22 05:15:16 2018 New Revision: 323112 URL: http://llvm.org/viewvc/llvm-project?rev=323112&view=rev Log: Fix MSVC implicit double-float truncation warning. NFCI. Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp Modified: clang-tools-extra/trunk/clangd/Co

r294740 - Wdocumentation fixes

2017-02-10 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Fri Feb 10 06:14:01 2017 New Revision: 294740 URL: http://llvm.org/viewvc/llvm-project?rev=294740&view=rev Log: Wdocumentation fixes Modified: cfe/trunk/lib/CodeGen/MacroPPCallbacks.h Modified: cfe/trunk/lib/CodeGen/MacroPPCallbacks.h URL: http://llvm.org/viewvc/llvm-p

r295183 - Fix spelling mistake - paramater -> parameter. NFCI.

2017-02-15 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Wed Feb 15 09:12:06 2017 New Revision: 295183 URL: http://llvm.org/viewvc/llvm-project?rev=295183&view=rev Log: Fix spelling mistake - paramater -> parameter. NFCI. Modified: cfe/trunk/lib/AST/MicrosoftMangle.cpp cfe/trunk/lib/CodeGen/CGCall.cpp cfe/trunk/lib/Sem

[clang-tools-extra] r295498 - Fix windows buildbots that don't have full shell support

2017-02-17 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Fri Feb 17 15:31:31 2017 New Revision: 295498 URL: http://llvm.org/viewvc/llvm-project?rev=295498&view=rev Log: Fix windows buildbots that don't have full shell support Modified: clang-tools-extra/trunk/test/clang-tidy/clang-tidy-diff.cpp Modified: clang-tools-extra/tru

r295584 - [X86][XOP] Fix type conversion warning in vpcmov generic implementations.

2017-02-18 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Sat Feb 18 17:47:34 2017 New Revision: 295584 URL: http://llvm.org/viewvc/llvm-project?rev=295584&view=rev Log: [X86][XOP] Fix type conversion warning in vpcmov generic implementations. Modified: cfe/trunk/lib/Headers/xopintrin.h Modified: cfe/trunk/lib/Headers/xopintri

r295828 - Fix -Wunused-private-field warning by removing unused ODRHash reference field from ODRDeclVisitor

2017-02-22 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Wed Feb 22 07:19:24 2017 New Revision: 295828 URL: http://llvm.org/viewvc/llvm-project?rev=295828&view=rev Log: Fix -Wunused-private-field warning by removing unused ODRHash reference field from ODRDeclVisitor Modified: cfe/trunk/lib/AST/ODRHash.cpp Modified: cfe/trunk

r295829 - Fix 'control reaches end of non-void function' warning

2017-02-22 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Wed Feb 22 07:21:24 2017 New Revision: 295829 URL: http://llvm.org/viewvc/llvm-project?rev=295829&view=rev Log: Fix 'control reaches end of non-void function' warning Modified: cfe/trunk/lib/Serialization/ASTReader.cpp Modified: cfe/trunk/lib/Serialization/ASTReader.cpp

[PATCH] D20358: [Clang][AVX512][Intrinsics]Convert AVX non-temporal store builtins to LLVM-native IR.

2016-11-15 Thread Simon Pilgrim via cfe-commits
RKSimon added a comment. Abandon this patch? We replaced the x86 vector non-temporal store builtins with __builtin_nontemporal_store directly in the headers. https://reviews.llvm.org/D20358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

[PATCH] D20359: [LLVM][AVX512][Intrinsics] Convert AVX non-temporal store builtins to LLVM-native IR.

2016-11-15 Thread Simon Pilgrim via cfe-commits
RKSimon added a comment. Close this? It appears to have been committed, including the auto upgrade tests requested by Craig. https://reviews.llvm.org/D20359 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailm

r286996 - Fixed spelling in comments. NFCI.

2016-11-15 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Tue Nov 15 12:28:07 2016 New Revision: 286996 URL: http://llvm.org/viewvc/llvm-project?rev=286996&view=rev Log: Fixed spelling in comments. NFCI. Modified: cfe/trunk/include/clang/AST/DeclObjC.h cfe/trunk/include/clang/Basic/TargetInfo.h cfe/trunk/lib/Sema/SemaEx

[PATCH] D26686: [X86][AVX512] Replace lossless i32/u64 to f64 conversion intrinsics with generic IR

2016-11-15 Thread Simon Pilgrim via cfe-commits
RKSimon created this revision. RKSimon added reviewers: craig.topper, igorb, delena. RKSimon added a subscriber: cfe-commits. RKSimon set the repository for this revision to rL LLVM. Both the (V)CVTDQ2PD (i32 to f64) and (V)CVTDQ2PD (u32 to f64) conversion instructions are lossless and can be saf

r287088 - [X86][AVX512] Replace lossless i32/u32 to f64 conversion intrinsics with generic IR

2016-11-16 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Wed Nov 16 03:27:40 2016 New Revision: 287088 URL: http://llvm.org/viewvc/llvm-project?rev=287088&view=rev Log: [X86][AVX512] Replace lossless i32/u32 to f64 conversion intrinsics with generic IR Both the (V)CVTDQ2PD (i32 to f64) and (V)CVTUDQ2PD (u32 to f64) conversion in

[PATCH] D26686: [X86][AVX512] Replace lossless i32/u32 to f64 conversion intrinsics with generic IR

2016-11-16 Thread Simon Pilgrim via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL287088: [X86][AVX512] Replace lossless i32/u32 to f64 conversion intrinsics with… (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D26686?vs=78038&id=78146#toc Repository: rL

r287114 - Remove duplicate condition (PR30648). NFCI.

2016-11-16 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Wed Nov 16 10:11:08 2016 New Revision: 287114 URL: http://llvm.org/viewvc/llvm-project?rev=287114&view=rev Log: Remove duplicate condition (PR30648). NFCI. We only need to check that the bitstream entry is a Record. Modified: cfe/trunk/lib/Serialization/ASTReader.cpp M

r287335 - Wdocumentation fix

2016-11-18 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Fri Nov 18 05:18:28 2016 New Revision: 287335 URL: http://llvm.org/viewvc/llvm-project?rev=287335&view=rev Log: Wdocumentation fix Modified: cfe/trunk/include/clang/Driver/Driver.h Modified: cfe/trunk/include/clang/Driver/Driver.h URL: http://llvm.org/viewvc/llvm-proje

r287755 - [X86][AVX512VL] Add missing _mm256_maskz_alignr_epi64 shufflevector check

2016-11-23 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Wed Nov 23 05:38:52 2016 New Revision: 287755 URL: http://llvm.org/viewvc/llvm-project?rev=287755&view=rev Log: [X86][AVX512VL] Add missing _mm256_maskz_alignr_epi64 shufflevector check Missed in rL287733 Modified: cfe/trunk/test/CodeGen/avx512vl-builtins.c Modified: c

r289285 - Fix unused variable warnings. NFCI.

2016-12-09 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Fri Dec 9 16:45:21 2016 New Revision: 289285 URL: http://llvm.org/viewvc/llvm-project?rev=289285&view=rev Log: Fix unused variable warnings. NFCI. Modified: cfe/trunk/lib/CodeGen/CGExprConstant.cpp cfe/trunk/lib/CodeGen/CodeGenTypes.cpp Modified: cfe/trunk/lib/Code

r301637 - [X86][SSE] Add _mm_set_pd1 (PR32827)

2017-04-28 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Fri Apr 28 05:28:32 2017 New Revision: 301637 URL: http://llvm.org/viewvc/llvm-project?rev=301637&view=rev Log: [X86][SSE] Add _mm_set_pd1 (PR32827) Matches _mm_set_ps1 implementation Modified: cfe/trunk/lib/Headers/emmintrin.h cfe/trunk/test/CodeGen/sse2-builtins.c

r301749 - [X86][AVX] Added support for _mm256_zext* helper intrinsics (PR32839)

2017-04-29 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Sat Apr 29 12:17:06 2017 New Revision: 301749 URL: http://llvm.org/viewvc/llvm-project?rev=301749&view=rev Log: [X86][AVX] Added support for _mm256_zext* helper intrinsics (PR32839) Modified: cfe/trunk/lib/Headers/avx512fintrin.h cfe/trunk/lib/Headers/avxintrin.h

r302418 - [X86][LWP] Add clang support for LWP instructions.

2017-05-08 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Mon May 8 07:09:45 2017 New Revision: 302418 URL: http://llvm.org/viewvc/llvm-project?rev=302418&view=rev Log: [X86][LWP] Add clang support for LWP instructions. This patch adds support for the the LightWeight Profiling (LWP) instructions which are available on all AMD Bul

r302445 - [X86][LWP] Add __LWP__ macro tests

2017-05-08 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Mon May 8 12:25:48 2017 New Revision: 302445 URL: http://llvm.org/viewvc/llvm-project?rev=302445&view=rev Log: [X86][LWP] Add __LWP__ macro tests Missed in rL302418 Differential Revision: https://reviews.llvm.org/D32770 Modified: cfe/trunk/test/Preprocessor/predefined

r302557 - [X86][LWP] Removing LWP todo comment. NFCI.

2017-05-09 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Tue May 9 12:43:16 2017 New Revision: 302557 URL: http://llvm.org/viewvc/llvm-project?rev=302557&view=rev Log: [X86][LWP] Removing LWP todo comment. NFCI. LWP / lwpintrin.h is now supported Modified: cfe/trunk/lib/Headers/x86intrin.h Modified: cfe/trunk/lib/Headers/x8

r302559 - [X86][LWP] Remove MSVC LWP intrinsics stubs.

2017-05-09 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Tue May 9 12:50:16 2017 New Revision: 302559 URL: http://llvm.org/viewvc/llvm-project?rev=302559&view=rev Log: [X86][LWP] Remove MSVC LWP intrinsics stubs. Now provided in lwpintrin.h Modified: cfe/trunk/lib/Headers/intrin.h Modified: cfe/trunk/lib/Headers/intrin.h UR

[clang-tools-extra] r303078 - Fix windows buildbots - missing include and namespace

2017-05-15 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Mon May 15 11:36:11 2017 New Revision: 303078 URL: http://llvm.org/viewvc/llvm-project?rev=303078&view=rev Log: Fix windows buildbots - missing include and namespace Modified: clang-tools-extra/trunk/clangd/DraftStore.cpp clang-tools-extra/trunk/clangd/DraftStore.h

[clang-tools-extra] r303344 - Fix 'not all control paths return a value' warning on windows buildbots.

2017-05-18 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu May 18 05:48:23 2017 New Revision: 303344 URL: http://llvm.org/viewvc/llvm-project?rev=303344&view=rev Log: Fix 'not all control paths return a value' warning on windows buildbots. Modified: clang-tools-extra/trunk/clang-tidy/ClangTidyDiagnosticConsumer.cpp Modified

[clang-tools-extra] r284476 - Fix signed/unsigned comparison warnings

2016-10-18 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Tue Oct 18 08:15:31 2016 New Revision: 284476 URL: http://llvm.org/viewvc/llvm-project?rev=284476&view=rev Log: Fix signed/unsigned comparison warnings Modified: clang-tools-extra/trunk/unittests/clang-tidy/NamespaceAliaserTest.cpp clang-tools-extra/trunk/unittests/c

r285067 - Fix MSVC unused variable warning.

2016-10-25 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Tue Oct 25 07:59:15 2016 New Revision: 285067 URL: http://llvm.org/viewvc/llvm-project?rev=285067&view=rev Log: Fix MSVC unused variable warning. LLVM_ATTRIBUTE_UNUSED doesn't work for non-gcc style compilers. Modified: cfe/trunk/lib/StaticAnalyzer/Checkers/StdLibraryFu

r285281 - Fix MSVC warning about missing 'this' from lambda default capture mode

2016-10-27 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Oct 27 05:51:29 2016 New Revision: 285281 URL: http://llvm.org/viewvc/llvm-project?rev=285281&view=rev Log: Fix MSVC warning about missing 'this' from lambda default capture mode Modified: cfe/trunk/lib/Lex/PPLexerChange.cpp Modified: cfe/trunk/lib/Lex/PPLexerChange

Re: r285281 - Fix MSVC warning about missing 'this' from lambda default capture mode

2016-10-27 Thread Simon Pilgrim via cfe-commits
You’re not kidding, its incredibly annoying. I can add a comment explaining why its there if you wish? Simon >> On 27 Oct 2016, at 12:51, Simon Pilgrim via cfe-commits >> wrote: >> >> Author: rksimon >> Date: Thu Oct 27 05:51:29 2016 >> New Revision: 2852

r285390 - Fix MSVC "not all control paths return a value" warning

2016-10-28 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Fri Oct 28 05:09:35 2016 New Revision: 285390 URL: http://llvm.org/viewvc/llvm-project?rev=285390&view=rev Log: Fix MSVC "not all control paths return a value" warning Add unreachable after enum switch statement Modified: cfe/trunk/lib/Driver/Action.cpp Modified: cfe/t

[clang-tools-extra] r286449 - Fix -Wdocumentation warning

2016-11-10 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Nov 10 07:54:39 2016 New Revision: 286449 URL: http://llvm.org/viewvc/llvm-project?rev=286449&view=rev Log: Fix -Wdocumentation warning Modified: clang-tools-extra/trunk/clang-move/ClangMove.h Modified: clang-tools-extra/trunk/clang-move/ClangMove.h URL: http://llv

r286595 - [X86] Merge (near) duplicate scalar non-temporal store code. NFCI.

2016-11-11 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Fri Nov 11 08:38:34 2016 New Revision: 286595 URL: http://llvm.org/viewvc/llvm-project?rev=286595&view=rev Log: [X86] Merge (near) duplicate scalar non-temporal store code. NFCI. Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp Modified: cfe/trunk/lib/CodeGen/CGBuiltin.cpp

[PATCH] D12835: [X86][SSE] Replace 128-bit SSE41 PMOVSX intrinsics with native IR

2015-09-13 Thread Simon Pilgrim via cfe-commits
RKSimon created this revision. RKSimon added reviewers: ab, qcolombet, craig.topper, spatel. RKSimon added a subscriber: cfe-commits. RKSimon set the repository for this revision to rL LLVM. 128-bit vector integer sign extensions correctly lower to the pmovsx instructions even for debug builds.

Re: [PATCH] D12835: [X86][SSE] Replace 128-bit SSE41 PMOVSX intrinsics with native IR

2015-09-19 Thread Simon Pilgrim via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL248092: [X86][SSE] Replace 128-bit SSE41 PMOVSX intrinsics with native IR (authored by RKSimon). Changed prior to commit: http://reviews.llvm.org/D12835?vs=34646&id=35167#toc Repository: rL LLVM htt

r248092 - [X86][SSE] Replace 128-bit SSE41 PMOVSX intrinsics with native IR

2015-09-19 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Sat Sep 19 10:12:38 2015 New Revision: 248092 URL: http://llvm.org/viewvc/llvm-project?rev=248092&view=rev Log: [X86][SSE] Replace 128-bit SSE41 PMOVSX intrinsics with native IR 128-bit vector integer sign extensions correctly lower to the pmovsx instructions even for debug

Re: r243851 - Fix invalid shufflevector operands

2015-08-15 Thread Simon Pilgrim via cfe-commits
> On 14 Aug 2015, at 19:10, Hans Wennborg wrote: > > On Fri, Aug 14, 2015 at 2:09 AM, John McCall wrote: >>> On Aug 10, 2015, at 12:40 PM, Hans Wennborg wrote: >>> On Fri, Aug 7, 2015 at 11:57 AM, Simon Pilgrim >>> wrote: On 06/08/2015 18:05, Hans Wennborg wrote: > > On Sun, Au

[PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics

2015-08-15 Thread Simon Pilgrim via cfe-commits
RKSimon created this revision. RKSimon added reviewers: craig.topper, echristo, mkuper. RKSimon added a subscriber: cfe-commits. RKSimon set the repository for this revision to rL LLVM. Adds missing SSE/AVX 'undefined' intrinsics (PR24040): _mm_undefined_pd + _mm256_undefined_pd _mm_undefined_ps

Re: [PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics

2015-08-16 Thread Simon Pilgrim via cfe-commits
RKSimon added a comment. Yes using that uninitialized value has worried me as well. I originally set it to zero (and considered using __ LINE __ or __ COUNTER __) but both introduce defined behaviour that I could see causing all sorts of problems further down the line in debug vs release builds

Re: [PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics

2015-08-19 Thread Simon Pilgrim via cfe-commits
RKSimon updated this revision to Diff 32514. RKSimon added a comment. Added ia32 builtin undef intrinsics (I didn't bother with the mmx as I can't find any evidence of an undefined intrinsic for it). Added the avx512 intrinsics referenced in the intel intrinsics guide. Technically there's nothi

[PATCH] D12143: [X86][AVX2] Replace avx2.pbroadcast / avx2.vbroadcast intrinsics usage in avx2intrin.h with __builtin_shufflevector

2015-08-19 Thread Simon Pilgrim via cfe-commits
RKSimon created this revision. RKSimon added reviewers: qcolombet, craig.topper, ab, spatel, silvas. RKSimon added a subscriber: cfe-commits. RKSimon set the repository for this revision to rL LLVM. Sister patch to D10555 As discussed on D10555, this patch replaces the use of the avx2.vbroadcast

Re: [PATCH] D12143: [X86][AVX2] Replace avx2.pbroadcast / avx2.vbroadcast intrinsics usage in avx2intrin.h with __builtin_shufflevector

2015-08-19 Thread Simon Pilgrim via cfe-commits
RKSimon abandoned this revision. RKSimon added a comment. In http://reviews.llvm.org/D12143#228006, @ab wrote: > Heh, this is http://reviews.llvm.org/D10556, no? :P Yes you're right (and you remembered to kill the builtin defs) - please can you add some more reviewers so that we can get it dea

Re: [PATCH] D12212: [Headers][X86] Add -O0 assembly tests for intrinsics.

2015-08-20 Thread Simon Pilgrim via cfe-commits
RKSimon added a comment. Definitely like this idea - hopefully it'll make it safer to remove unnecessary builtins. Comment at: avx2-builtins-codegen.c:182 @@ -151,1 +181,3 @@ + // FIXME-CHECK-ASM: vpxor %ymm{{.*}} + // FIXME-CHECK-ASM: vandps {{.*}}, %ymm{{.*}} return _mm2

Re: [PATCH] D12212: [Headers][X86] Add -O0 assembly tests for intrinsics.

2015-08-22 Thread Simon Pilgrim via cfe-commits
RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM with a suitable FIXME comment. Email me if you want to split the work on adding this to the other SSE/AVX builtin tests. http://reviews.llvm.org/D12212 _

r245815 - Added missing tests for SSE41 pmovsx/pmovzx extension intrinsics

2015-08-23 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Sun Aug 23 11:19:38 2015 New Revision: 245815 URL: http://llvm.org/viewvc/llvm-project?rev=245815&view=rev Log: Added missing tests for SSE41 pmovsx/pmovzx extension intrinsics Modified: cfe/trunk/test/CodeGen/sse-builtins.c Modified: cfe/trunk/test/CodeGen/sse-builtins

[PATCH] D12272: [X86] Remove unnecessary MMX declarations from Intrin.h

2015-08-23 Thread Simon Pilgrim via cfe-commits
RKSimon created this revision. RKSimon added reviewers: echristo, silvas, craig.topper. RKSimon added a subscriber: cfe-commits. RKSimon set the repository for this revision to rL LLVM. As discussed in PR23648 - the intrinsics _m_from_int, _m_to_int and _m_prefetch are defined in mmintrin.h and p

Re: [PATCH] D12272: [X86] Remove unnecessary MMX declarations from Intrin.h

2015-08-25 Thread Simon Pilgrim via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL245975: [X86] Remove unnecessary MMX declarations from Intrin.h (authored by RKSimon). Changed prior to commit: http://reviews.llvm.org/D12272?vs=32926&id=33124#toc Repository: rL LLVM http://review

r245975 - [X86] Remove unnecessary MMX declarations from Intrin.h

2015-08-25 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Tue Aug 25 16:27:46 2015 New Revision: 245975 URL: http://llvm.org/viewvc/llvm-project?rev=245975&view=rev Log: [X86] Remove unnecessary MMX declarations from Intrin.h As discussed in PR23648 - the intrinsics _m_from_int, _m_to_int and _m_prefetch are defined in mmintrin.h

[PATCH] D12340: [X86] Remove unnecessary 3DNow declarations from Intrin.h

2015-08-25 Thread Simon Pilgrim via cfe-commits
RKSimon created this revision. RKSimon added reviewers: echristo, mkuper, silvas, craig.topper. RKSimon added a subscriber: cfe-commits. RKSimon set the repository for this revision to rL LLVM. Follow up to D12272 This adds the missing 3dnow intrinsics _m_to_float / _m_from_float and removes the

r246083 - [X86][SSE] Add _mm_undefined_* intrinsics

2015-08-26 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Wed Aug 26 16:17:12 2015 New Revision: 246083 URL: http://llvm.org/viewvc/llvm-project?rev=246083&view=rev Log: [X86][SSE] Add _mm_undefined_* intrinsics Added missing SSE/AVX 'undefined' intrinsics (PR24040): _mm_undefined_pd, _mm_undefined_ps + _mm_undefined_si128 _mm256_

Re: [PATCH] D12052: [X86][SSE] Add _mm_undefined_* intrinsics

2015-08-26 Thread Simon Pilgrim via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL246083: [X86][SSE] Add _mm_undefined_* intrinsics (authored by RKSimon). Changed prior to commit: http://reviews.llvm.org/D12052?vs=32514&id=33249#toc Repository: rL LLVM http://reviews.llvm.org/D12

r246200 - [X86] Add __builtin_ia32_undef* intrinsics to test

2015-08-27 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Aug 27 15:29:13 2015 New Revision: 246200 URL: http://llvm.org/viewvc/llvm-project?rev=246200&view=rev Log: [X86] Add __builtin_ia32_undef* intrinsics to test Minor tweak to rL246083 Modified: cfe/trunk/test/CodeGen/builtins-x86.c Modified: cfe/trunk/test/CodeGen/b

r246204 - [X86][F16C] Added debug codegen test for F16C intrinsics

2015-08-27 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Aug 27 15:34:02 2015 New Revision: 246204 URL: http://llvm.org/viewvc/llvm-project?rev=246204&view=rev Log: [X86][F16C] Added debug codegen test for F16C intrinsics Part of PR24590 Modified: cfe/trunk/test/CodeGen/f16c-builtins.c Modified: cfe/trunk/test/CodeGen/f1

r246206 - [X86][FMA4] Added debug codegen test for FMA4 intrinsics

2015-08-27 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Aug 27 15:41:45 2015 New Revision: 246206 URL: http://llvm.org/viewvc/llvm-project?rev=246206&view=rev Log: [X86][FMA4] Added debug codegen test for FMA4 intrinsics Part of PR24590 Modified: cfe/trunk/test/CodeGen/fma4-builtins.c Modified: cfe/trunk/test/CodeGen/fm

r246211 - [X86][XOP] Added debug codegen test for XOP intrinsics

2015-08-27 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Aug 27 16:32:03 2015 New Revision: 246211 URL: http://llvm.org/viewvc/llvm-project?rev=246211&view=rev Log: [X86][XOP] Added debug codegen test for XOP intrinsics Part of PR24590 Modified: cfe/trunk/test/CodeGen/xop-builtins.c Modified: cfe/trunk/test/CodeGen/xop-b

r246223 - [X86][3DNow] Added debug codegen test for 3DNow! intrinsics

2015-08-27 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Thu Aug 27 17:18:09 2015 New Revision: 246223 URL: http://llvm.org/viewvc/llvm-project?rev=246223&view=rev Log: [X86][3DNow] Added debug codegen test for 3DNow! intrinsics Part of PR24590 Modified: cfe/trunk/test/CodeGen/3dnow-builtins.c Modified: cfe/trunk/test/CodeGe

Re: r246223 - [X86][3DNow] Added debug codegen test for 3DNow! intrinsics

2015-08-28 Thread Simon Pilgrim via cfe-commits
n X86 specific area and check the AArch64 bots after commit to make sure it passes. You probably didn't get the email because the bot was broken when you committed, then all your other commits were breaking a broken bot. :) cheers, --renato On 27 August 2015 at 23:18, Simon Pilgrim via cfe-comm

r246363 - [X86] Reapplied r246204, r246206, r246211, r246223

2015-08-29 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Sat Aug 29 12:13:40 2015 New Revision: 246363 URL: http://llvm.org/viewvc/llvm-project?rev=246363&view=rev Log: [X86] Reapplied r246204, r246206, r246211, r246223 (Re)added debug codegen test for F16C, FMA4, XOP + 3DNow! intrinsics Part of PR24590 Modified: cfe/trunk/t

r246944 - [X86]][SSE42] Added SSE42 IR + assembly codegen builtin tests

2015-09-06 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Sun Sep 6 09:05:33 2015 New Revision: 246944 URL: http://llvm.org/viewvc/llvm-project?rev=246944&view=rev Log: [X86]][SSE42] Added SSE42 IR + assembly codegen builtin tests Added: cfe/trunk/test/CodeGen/sse42-builtins.c Added: cfe/trunk/test/CodeGen/sse42-builtins.c UR

r246945 - [X86]][SSE3] Added SSE3 IR + assembly codegen builtin tests

2015-09-06 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Sun Sep 6 09:45:13 2015 New Revision: 246945 URL: http://llvm.org/viewvc/llvm-project?rev=246945&view=rev Log: [X86]][SSE3] Added SSE3 IR + assembly codegen builtin tests Added: cfe/trunk/test/CodeGen/sse3-builtins.c Added: cfe/trunk/test/CodeGen/sse3-builtins.c URL:

r246947 - [X86]][SSE3] Added SSE41 IR + assembly codegen builtin tests

2015-09-06 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Sun Sep 6 11:38:17 2015 New Revision: 246947 URL: http://llvm.org/viewvc/llvm-project?rev=246947&view=rev Log: [X86]][SSE3] Added SSE41 IR + assembly codegen builtin tests Transferred SSE41 instructions from sse-builtins.c Added: cfe/trunk/test/CodeGen/sse41-builtins.c

r246948 - [X86][SSSE3] Added SSSE3 IR + assembly codegen builtin tests

2015-09-06 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Sun Sep 6 12:06:22 2015 New Revision: 246948 URL: http://llvm.org/viewvc/llvm-project?rev=246948&view=rev Log: [X86][SSSE3] Added SSSE3 IR + assembly codegen builtin tests Transferred SSSE3 instructions from sse-builtins.c Added: cfe/trunk/test/CodeGen/ssse3-builtins.c

r246974 - [X86][SSE4A] Added SSE4A IR + assembly codegen builtin tests

2015-09-07 Thread Simon Pilgrim via cfe-commits
Author: rksimon Date: Mon Sep 7 15:10:11 2015 New Revision: 246974 URL: http://llvm.org/viewvc/llvm-project?rev=246974&view=rev Log: [X86][SSE4A] Added SSE4A IR + assembly codegen builtin tests Modified: cfe/trunk/test/CodeGen/sse4a-builtins.c Modified: cfe/trunk/test/CodeGen/sse4a-builtins

Re: r243851 - Fix invalid shufflevector operands

2015-08-07 Thread Simon Pilgrim via cfe-commits
On 06/08/2015 18:05, Hans Wennborg wrote: On Sun, Aug 2, 2015 at 8:28 AM, Simon Pilgrim wrote: Author: rksimon Date: Sun Aug 2 10:28:10 2015 New Revision: 243851 URL: http://llvm.org/viewvc/llvm-project?rev=243851&view=rev Log: Fix invalid shufflevector operands This patch fixes bug 23800 (

Re: [PATCH] D22105: [X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic IR

2016-07-19 Thread Simon Pilgrim via cfe-commits
RKSimon added a comment. In https://reviews.llvm.org/D22105#488513, @eli.friedman wrote: > I don't think we need to use x86-specific operations for sitofp-like > conversions; the C cast is equivalent given that a 32 or 64-bit integer is > always in within the range of a 32-bit float. I think

Re: [PATCH] D22105: [X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic IR

2016-07-19 Thread Simon Pilgrim via cfe-commits
RKSimon added a comment. In https://reviews.llvm.org/D22105#488566, @eli.friedman wrote: > The x86-specific operation is affected by the rounding mode... but so is a C > cast. This is specified by Annex F in the C standard. > > Of course, you're going to end up with undefined behavior if you ac

Re: [PATCH] D22105: [X86][SSE] Reimplement SSE fp2si conversion intrinsics instead of using generic IR

2016-07-19 Thread Simon Pilgrim via cfe-commits
RKSimon updated this revision to Diff 64534. RKSimon added a comment. Removed sitofp conversion changes Repository: rL LLVM https://reviews.llvm.org/D22105 Files: include/clang/Basic/BuiltinsX86.def lib/Headers/avxintrin.h lib/Headers/emmintrin.h lib/Headers/xmmintrin.h test/CodeGe

<    2   3   4   5   6   7   8   9   10   11   >