[PATCH] D28018: AMD family 17h (znver1) enablement

RKSimon added a comment. In https://reviews.llvm.org/D28018#639765, @GGanesh wrote: > Fallback to CK_BTVER1 is ok but not to CK_BTVER2. This is not possible > because of the partial YMM writes. They have different behavior for znver1 > with AVX and their legacy SIMD counterparts. So, as of now

[PATCH] D28018: AMD family 17h (znver1) enablement

RKSimon added a comment. LGTM - @craig.topper any additional comments? https://reviews.llvm.org/D28018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28400: [AArch64] Use generic bitreverse intrinsic, rather than AArch64 specific.

RKSimon added inline comments. Comment at: test/CodeGen/arm_acle.c:247 // ARM-LABEL: test_rbit // AArch32: call i32 @llvm.arm.rbit +// AArch64: call i32 @llvm.bitreverse.i32 Since you're here is it worth dealing with the AARCH32 case as well? We know it works

[PATCH] D28503: Documentation for the newly added x86 intrinsics.

RKSimon added inline comments. Comment at: emmintrin.h:1607 +/// +/// This intrinsic corresponds to the VMOVSD / MOVSD instruction. +/// kromanova wrote: > kromanova wrote: > > kromanova wrote: > > > probinson wrote: > > > > should this be VMOVQ/MOVQ instead? >

[PATCH] D31155: [X86][AVX512] Add _mm512_cvtsd_f64 and _mm512_cvtss_f32 intrinsics (PR32305)

RKSimon created this revision. Repository: rL LLVM https://reviews.llvm.org/D31155 Files: lib/Headers/avx512fintrin.h test/CodeGen/avx512f-builtins.c Index: test/CodeGen/avx512f-builtins.c === --- test/CodeGen/avx512f-builti

[PATCH] D31155: [X86][AVX512] Add _mm512_cvtsd_f64 and _mm512_cvtss_f32 intrinsics (PR32305)

This revision was automatically updated to reflect the committed changes. Closed by commit rL298364: [X86][AVX512] Add _mm512_cvtsd_f64 and _mm512_cvtss_f32 intrinsics (PR32305) (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D31155?vs=92390&id=92477#toc Repository:

[PATCH] D31428: [x86] fix AVX FP cmp intrinsic documentation (PR28110)

RKSimon added inline comments. Comment at: lib/Headers/avxintrin.h:1752 +///0x1e : Greater-than (ordered, non-signaling) +///0x1f : True (unordered, signaling) /// \returns A 128-bit vector of [4 x float] containing the comparison results. Minor: clean u

[PATCH] D31766: [Clang][X86][SSE] Update MOVNTDQA non-temporal loads to generic implementation

RKSimon created this revision. MOVNTDQA non-temporal aligned vector loads can be correctly represented using generic builtin loads, allowing us to remove the existing x86 intrinsics. The LLVM companion patch will be published shortly. Repository: rL LLVM https://reviews.llvm.org/D31766 Fil

[PATCH] D31766: [Clang][X86][SSE] Update MOVNTDQA non-temporal loads to generic implementation

This revision was automatically updated to reflect the committed changes. Closed by commit rL300326: [X86][SSE] Update MOVNTDQA non-temporal loads to generic implementation (clang) (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D31766?vs=94379&id=95303#toc Repository:

[PATCH] D12340: [X86] Remove unnecessary 3DNow declarations from Intrin.h

RKSimon abandoned this revision. RKSimon added a comment. Abandoning this - unless we have a way to known when to automatically insert emms/femms then its not safe to do this. Repository: rL LLVM https://reviews.llvm.org/D12340 ___ cfe-commits m

[PATCH] D29386: Clzero flag addition and inclusion under znver1

RKSimon added a comment. Still missing a test in llvm\tools\clang\test\CodeGen\builtins-x86.c Repository: rL LLVM https://reviews.llvm.org/D29386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D34842: [X86] Add RDRND to Goldmont. Add MOVBE to all Atom CPUs

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM with a couple of comments. On the LLVM side, X86.td GoldMont class looks like it needs RDRAND as well. Comment at: lib/Basic/Targets.cpp:3310 setFeatureEnabledIm

[PATCH] D35449: [X86] Implement __builtin_cpu_is

RKSimon added a comment. I don't have much experience with this builtin - does gcc use it for anything but x86? google didn't turn up much. https://reviews.llvm.org/D35449 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

[PATCH] D42016: [X86] Implement old kunpck intrinsics using vector ops on vXi1 instead of integer shift/and/or

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. I agree keeping them as vector types makes more sense, assuming the vXi1 handling and bitcasts to/from integer types are up to snuff. https://reviews.llvm.org/D42016

[PATCH] D41517: mmintrin.h documentation fixes and updates

RKSimon added inline comments. Comment at: lib/Headers/mmintrin.h:55 /// -/// This intrinsic corresponds to the VMOVD / MOVD instruction. +/// This intrinsic corresponds to the MOVD instruction. /// efriedma wrote: > craig.topper wrote: > > kromanova wrote:

[PATCH] D41523: xmmintrin.h documentation fixes and updates

RKSimon added a comment. Apart for the -Wdocumentation issue (which can be handled separately), is there anything else stalling this ticket? https://reviews.llvm.org/D41523 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.o

[PATCH] D42272: [X86] Add rdpid command line option and intrinsics.

RKSimon added inline comments. Comment at: lib/Headers/immintrin.h:251 +#if !defined(_MSC_VER) || __has_feature(modules) || defined(__RDPID__) +static __inline__ unsigned int __attribute__((__always_inline__, __nodebug__, __target__("rdpid"))) +_rdpid_u32(void) { ---

[PATCH] D42272: [X86] Add rdpid command line option and intrinsics.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D42272 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D27304: [PATCH] [Sema][X86] Don't allow floating-point return types when SSE is disabled

RKSimon added reviewers: mkuper, dim, RKSimon. RKSimon added a comment. https://llvm.org/bugs/show_bug.cgi?id=30426#c3 On PR30426 the proposal was that we should just not accept x86_64 triples with no-sse/no-sse2 at the command line parsing level - we just have no way to guess what the coder wa

[PATCH] D32770: [X86][LWP] Add clang support for LWP instructions.

RKSimon created this revision. Herald added a subscriber: mgorny. This patch adds support for the the LightWeight Profiling (LWP) instructions which are available on all AMD Bulldozer class CPUs (bdver1 to bdver4). Repository: rL LLVM https://reviews.llvm.org/D32770 Files: include/clang/B

[PATCH] D32770: [X86][LWP] Add clang support for LWP instructions.

RKSimon added a comment. llvm patch: https://reviews.llvm.org/D32769 Repository: rL LLVM https://reviews.llvm.org/D32770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32770: [X86][LWP] Add clang support for LWP instructions.

RKSimon added a comment. ping? llvm support landed at https://reviews.llvm.org/rL302041 Repository: rL LLVM https://reviews.llvm.org/D32770 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D32770: [X86][LWP] Add clang support for LWP instructions.

This revision was automatically updated to reflect the committed changes. Closed by commit rL302418: [X86][LWP] Add clang support for LWP instructions. (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D32770?vs=97521&id=98156#toc Repository: rL LLVM https://reviews.l

[PATCH] D32770: [X86][LWP] Add clang support for LWP instructions.

RKSimon added a comment. In https://reviews.llvm.org/D32770#748762, @craig.topper wrote: > Sorry I missed this patch, but shouldn't we had __LWP__ to the relevant > processors in test/Preprocessor/predefined-arch-macros.c and the command > line switch testing to test/Preprocessor/x86_target_fe

[PATCH] D33406: PR28129 expand vector oparation to an IR constant.

RKSimon added a comment. Test _mm256_cmp_pd as well? Comment at: lib/CodeGen/CGBuiltin.cpp:7922 case X86::BI__builtin_ia32_cmpps256: + if (CC == 0xf) { + Value *Vec = Builder.CreateVectorSplat(Ops[0]->getType()->getVectorNumElements(), You ne

[PATCH] D117301: [clang][NFC] Wrap TYPE_SWITCH in "do while (0)" in the interpreter

RKSimon added a comment. what about COMPOSITE_TYPE_SWITCH and INT_TYPE_SWITCH - should they be updated as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117301/new/ https://reviews.llvm.org/D117301 ___

[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper, fhahn. RKSimon requested review of this revision. Herald added a project: clang. D111986 added the generic `__builtin_elementwise_abs()` intrinsic with the same integer absolute beha

[PATCH] D117798: [X86] Remove __builtin_ia32_pmax/min intrinsics and use generic __builtin_elementwise_max/min

RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper, fhahn. RKSimon requested review of this revision. Herald added a project: clang. D111985 added the generic `__builtin_elementwise_max` and `__builtin_elementwise_min` intrinsics with

[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

RKSimon added a comment. In D117791#3258602 , @craig.topper wrote: > Just to confirm since I can't see the test CHECK lines. > builtin_elementwise_abs is not undefined for INT_MIN? That's why I added a copy of the check (from llvm-project\clang\test\C

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon created this revision. RKSimon added reviewers: fhahn, scanon, aaron.ballman, craig.topper. RKSimon requested review of this revision. Herald added a project: clang. Similar to the existing bitwise reduction builtins, these are lowered to the llvm.vector.reduce.add/mul intrinsic calls. F

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon added a comment. I should mention - according to https://clang.llvm.org/docs/LanguageExtensions.html `__builtin_reduce_add()` already exists, which I don't think is true. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/ https://r

[PATCH] D117798: [X86] Remove __builtin_ia32_pmax/min intrinsics and use generic __builtin_elementwise_max/min

RKSimon added a comment. Thanks! Comment at: clang/lib/Headers/avx512bwintrin.h:894 return (__m512i)__builtin_ia32_selectb_512((__mmask64)__M, (__v64qi)_mm512_min_epu8(__A, __B), (__

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon added a comment. I'm happy to continue with this just for integers or wait until we have a plan for floats as well. I guess we need to decide if we want to support the starting value in the fadd/fmul intrinsics from the builtin or not? If we don't then adding float support to the add/mu

[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4727d29d908f: [X86] Remove __builtin_ia32_pabs intrinsics and use generic… (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D117798: [X86] Remove __builtin_ia32_pmax/min intrinsics and use generic __builtin_elementwise_max/min

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ee135dcf8ff: [X86] Remove `__builtin_ia32_pmax/min` intrinsics and use generic… (authored by RKSimon). Changed prior to commit: https://reviews.l

[PATCH] D117881: [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and use generic equivalents

RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper, fhahn. RKSimon requested review of this revision. Herald added a project: clang. None of these have any reordering issues, and they still emit the same reduction intrinsics without any change in the existing test cover

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

RKSimon created this revision. RKSimon added reviewers: fhahn, aaron.ballman, scanon, craig.topper. Herald added subscribers: pengfei, sunfish, kristof.beyls, dschuff. RKSimon requested review of this revision. Herald added a subscriber: aheejin. Herald added a project: clang. This patch implement

[PATCH] D117791: [X86] Remove __builtin_ia32_pabs intrinsics and use generic __builtin_elementwise_abs

RKSimon added a comment. Quick update: we're hitting an issue with the libc-x86_64-debian-fullbuild-dbg and asan build bots which is using the wrong headers and breaks when the `__builtin_ia32_pabs*` builtins are removed. Once that has been addressed I'll recommit. Repository: rG LLVM Githu

[PATCH] D117881: [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and use generic equivalents

RKSimon added a comment. In D117881#3263152 , @pengfei wrote: > What's the difference between `__builtin_reduce_and` and generating a > `Intrinsic::vector_reduce_and` in code? If this is just a simplification, why > can't be applied to `add` too? There

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

RKSimon updated this revision to Diff 402313. RKSimon added a comment. address feedback Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117898/new/ https://reviews.llvm.org/D117898 Files: clang/docs/LanguageExtensions.rst clang/include/clang/Bas

[PATCH] D117881: [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and use generic equivalents

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe4074432d5bf: [X86] Remove avx512f integer and/or/xor/min/max reduction intrinsics and use… (authored by RKSimon). Repository: rG LLVM Github Mono

[PATCH] D117301: [clang][NFC] Wrap TYPE_SWITCH in "do while (0)" in the interpreter

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - cheers CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117301/new/ https://reviews.llvm.org/D117301 ___ cfe-commits mailing list cf

[PATCH] D89105: [X86] Support Intel avxvnni

RKSimon added inline comments. Comment at: clang/lib/Headers/cpuid.h:199 /* Features in %eax for leaf 7 sub-leaf 1 */ +#define bit_AVXVNNI 0x0008 #define bit_AVX512BF160x0020 @liuchen3 https://github.com/llvm/llvm-project/issues/53392 reports

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. In D114639#3273761 , @stella.stamenova wrote: > Can we update the lldb instructions as part of this change to also point to > VS2019? Alternatively, I can send a separate change for that. I'll add it to this patch - are people

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 403574. RKSimon added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. update lldb docs as well Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.or

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

RKSimon added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117898/new/ https://reviews.llvm.org/D117898 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 403924. RKSimon added a comment. update lldb cmake command Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst clang/doc

[PATCH] D118464: [Sema] Add signed/unsigned integer mismatch tests for min/max elementwise builtins

RKSimon created this revision. RKSimon added reviewers: fhahn, scanon, craig.topper, aaron.ballman. RKSimon requested review of this revision. Herald added a project: clang. As suggested on D117898 Repository: rG LLVM Github Monorepo https://reviews.llvm.org

[PATCH] D118464: [Sema] Add signed/unsigned integer mismatch tests for min/max elementwise builtins

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9d75ee1cd597: [Sema] Add signed/unsigned integer mismatch tests for min/max elementwise… (authored by RKSimon). Repository: rG LLVM Github Monorep

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

RKSimon updated this revision to Diff 404013. RKSimon added a comment. rebase and add signed/unsigned integer mismatch tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117898/new/ https://reviews.llvm.org/D117898 Files: clang/docs/LanguageExt

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon updated this revision to Diff 404076. RKSimon added a comment. fix cut+paste typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 Files: clang/docs/ClangFormatStyleOptions.rst clang/docs/Users

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG058c5dfc78cd: Raise the minimum Visual Studio version to VS2019 (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D114639?v

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. @stella.stamenova It looks like the mlir-windows buildbot is still using VS2017: CMake Error at cmake/modules/CheckCompilerVersion.cmake:39 (message): Host Visual Studio version must be at least 19.20, your version is 19.16.27045.0. Are you able to make the fix

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. mlir-windows buildbot looks to be green now - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 ___ cfe-commits mailing list cfe-

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

RKSimon added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1534 } else if (StoreInst *SI = dyn_cast(I)) { -if (!ClInstrumentWrites || ignoreAccess(SI->getPointerOperand())) +if (!ClInstrumentWrites || ignoreAccess(LI, SI->getPoi

[PATCH] D118609: Remove redundant LLVM_HAS_RVALUE_REFERENCE_THIS and LLVM_LVALUE_FUNCTION defines

RKSimon created this revision. RKSimon added reviewers: rnk, aaron.ballman, zturner, jhenderson. Herald added a subscriber: dexonsmith. RKSimon requested review of this revision. Herald added projects: clang, LLVM. Herald added a subscriber: cfe-commits. Now that VS2017 support has been dropped (D

[PATCH] D118609: Remove redundant LLVM_HAS_RVALUE_REFERENCE_THIS and LLVM_LVALUE_FUNCTION defines

RKSimon updated this revision to Diff 404885. RKSimon added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118609/new/ https://reviews.llvm.org/D118609 Files: clang/include/clang/ASTMatchers/ASTMatchersInternal.h clang/i

[PATCH] D118609: Remove redundant LLVM_HAS_RVALUE_REFERENCE_THIS and LLVM_LVALUE_FUNCTION defines

This revision was automatically updated to reflect the committed changes. Closed by commit rG675a557316ef: Remove redundant LLVM_HAS_RVALUE_REFERENCE_THIS and LLVM_LVALUE_FUNCTION defines (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D120307: [X86] Add helper macros for ternary intrinsics

RKSimon added a comment. Are similar macros used by any other compilers at all? Comment at: clang/lib/Headers/avx512fintrin.h:5932 -#define _mm512_ternarylogic_epi32(A, B, C, imm) \ - ((__m512i)__builtin_ia32_pternlogd512_mask((__v16si)(__m512i)(A), \ -

[PATCH] D119063: [SemaCXX] Properly scope ArgumentPackSubstitutionIndex when expanding base types

RKSimon added inline comments. Comment at: clang/lib/Sema/SemaTemplateInstantiate.cpp:2536 - TypeSourceInfo *BaseTypeLoc = SubstType(Base.getTypeSourceInfo(), - TemplateArgs, -

[PATCH] D120395: [X86] Prohibit arithmatic operations on type `__bfloat16`

RKSimon added a comment. but its still OK to perform arithmetic with __m128bh ? https://simd.godbolt.org/z/Ef59Ws4M3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120395/new/ https://reviews.llvm.org/D120395 __

[PATCH] D120375: Trim unnecessary component/library dependencies.

RKSimon added a comment. Relying on implicit dependencies doesn't often work very well - please can you confirm what kind of builds you have tested this with? Which projects? shared libs? build types? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

RKSimon added a comment. @MaskRay The ppc buildbots have been red since these patches - please can you take a look? https://lab.llvm.org/buildbot/#/builders/57/builds/15454 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120305/new/ https://reviews.

[PATCH] D120307: [X86] Add helper enum for ternary intrinsics

RKSimon accepted this revision. RKSimon added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120307/new/ https://reviews.llvm.org/D120307 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D112098: [ASan] Added stack safety support in address sanitizer.

RKSimon added inline comments. Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:1534 } else if (StoreInst *SI = dyn_cast(I)) { -if (!ClInstrumentWrites || ignoreAccess(SI->getPointerOperand())) +if (!ClInstrumentWrites || ignoreAccess(LI, SI->getPoi

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. @rnk @stella.stamenova How long do you think it will be before you can update your buildbots to VS2019 or VS2022 please? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 _

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

RKSimon added a comment. Any reason not to handle __builtin_reduce_xor + __builtin_reduce_or as well in the same patch since they are very similar? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115231/new/ https://reviews.llvm.org/D115231 ___

[PATCH] D115231: [Clang] Add __builtin_reduce_xor

RKSimon added a comment. In D115231#3194439 , @junaire wrote: > In D115231#3194372 , @RKSimon wrote: > >> Any reason not to handle __builtin_reduce_xor + __builtin_reduce_or as well >> in the same patch since the

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

RKSimon added a comment. @rnk I'm not certain but I think the only buildbot still using VS2017 is windows-gcebot2 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114639/new/ https://reviews.llvm.org/D114639 ___

[PATCH] D114425: [clang] Add __builtin_bswap128

RKSimon added a comment. please can you add a constexpr test? Existing bswap tests are in clang/test/Sema/constant-builtins-2.c Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114425/new/ https://reviews.llvm.org/D114425 ___

[PATCH] D114425: [clang] Add __builtin_bswap128

RKSimon added inline comments. Comment at: clang/test/Sema/constant-builtins-2.c:219 int h5 = __builtin_bswap64(0x1234) == 0x3412 ? 1 : f(); +int h6 = __builtin_bswap128(0x1234) == (((__int128)0x3412) << 112) ? 1 : f(); extern long int bi0; ``` #if

[PATCH] D99409: [clang] Speedup line offset mapping computation

RKSimon added a comment. @serge-sans-paille Please can you look at the clang-ppc buildbot breakages: http://lab.llvm.org:8011/#/builders/52/builds/6108 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99409/new/ https://reviews.llvm.org/D99409 _

[PATCH] D100085: [X86] Support -march=rocketlake

RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86.td:790 + FeatureFSRM]; + list RKLTuning = ICLTuning; + list RKLFeatures = Using ICLTuning suggests we should still be avoiding 512-bit ops (Feat

[PATCH] D100172: Fix static code analysis concerns with uninitialized variables

This revision was automatically updated to reflect the committed changes. Closed by commit rG5d7cb79416ad: RISCVABIInfo::classifyArgumentType: Fix static analyzer warnings with… (authored by Manna, committed by RKSimon). Herald added a project: clang. Herald added a subscriber: cfe-commits. Repos

[PATCH] D100368: [X86] Support some missing intrinsics

RKSimon added a comment. Add _mm512_i32loscatter_epi64 and _mm512_mask_i32loscatter_epi64 for completeness? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100368/new/ https://reviews.llvm.org/D100368 __

[PATCH] D100368: [X86] Support some missing intrinsics

RKSimon added a comment. That's why I said "completeness" :) Comment at: clang/lib/Headers/avx512fintrin.h:9692 + (scale)) +/// Stores 8 packed double-precision (64-bit) floating-point elements in \a v1 +/// to memory locations starting at location \a base

[PATCH] D93179: [X86] Convert fmin/fmax _mm_reduce_* intrinsics to emit llvm.reduction intrinsics (PR47506)

RKSimon added a comment. In D93179#2473342 , @pengfei wrote: > Hi Simon, I found we have the same problem for fadd/fmul. See > https://godbolt.org/z/3YKaGx > X86 Intrinsics imply `reassoc` flag, but `llvm.vector.reduce.*` doesn't. I'm not surprised - my

[PATCH] D72281: [Matrix] Add matrix type to Clang.

RKSimon added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7855 + return; +RowsExpr = Columns.get(); + } else { @fhahn Should this be ColsExpr? ``` ColsExpr = Columns.get(); ``` Noticed when looking at https://llvm.org/reports/scan-build/re

[PATCH] D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC)

RKSimon added a comment. Does anyone have any feedback before I expand this to cover all the SSE2/AVX equivalents? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93597/new/ https://reviews.llvm.org/D93597 __

[PATCH] D93597: [X86][SSE] Enable constexpr on some basic SSE intrinsics (RFC)

RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/sse-builtins.c:815 +// Test constexpr handling. +#if defined(__cplusplus) && (__cplusplus >= 201103L) +constexpr __m128 test_constexpr_mm_add_ps(__m128 A, __m128 B) { pengfei wrote: > What are thes

[PATCH] D94092: [Clang] Remove unnecessary Attr.isArgIdent checks.

RKSimon added inline comments. Comment at: clang/lib/Sema/SemaType.cpp:7662 - Expr *sizeExpr; - - // Special case where the argument is a template id. - if (Attr.isArgIdent(0)) { -CXXScopeSpec SS; -SourceLocation TemplateKWLoc; -UnqualifiedId id; -id.setIdent

[PATCH] D92812: [X86] AMD Znver3 (Family 19H) Enablement

RKSimon accepted this revision. RKSimon added a comment. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92812/new/ https://reviews.llvm.org/D92812 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D94213: Clang: Remove support for 3DNow!, both intrinsics and builtins.

RKSimon added a comment. This all needs properly documenting in the release notes, and possibly in the clang docs as well explaining that mmx/3dnow is supported only inside assembly, Are we likely to get all of the 3dnow and mmx changes done before the 12.00 branch? Otherwise I'm tempted to sug

[PATCH] D92080: [Clang] Mutate long-double math builtins into f128 under IEEE-quad

RKSimon added a reviewer: hfinkel. RKSimon added a comment. LGTM but a PPC-guru needs to signoff CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92080/new/ https://reviews.llvm.org/D92080 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D107347: [Sema] haveSameParameterTypes - fix repeated isNull() test

RKSimon added inline comments. Comment at: clang/lib/Sema/SemaOverload.cpp:9528 QualType T2 = NextParam(F2, I2, I == 0); -if (!T1.isNull() && !T1.isNull() && !Context.hasSameUnqualifiedType(T1, T2)) +if (!T1.isNull() && !T2.isNull() && !Context.hasSameUnqualifiedTyp

[PATCH] D107347: [Sema] haveSameParameterTypes - replace repeated isNull() test with assertions

RKSimon updated this revision to Diff 380338. RKSimon retitled this revision from "[Sema] haveSameParameterTypes - fix repeated isNull() test" to "[Sema] haveSameParameterTypes - replace repeated isNull() test with assertions". RKSimon edited the summary of this revision. Repository: rG LLVM G

[PATCH] D107347: [Sema] haveSameParameterTypes - replace repeated isNull() test with assertions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b3509b3cba2: [Sema] haveSameParameterTypes - replace repeated isNull() test with assertions (authored by RKSimon). Repository: rG LLVM Github Mon

[PATCH] D107878: [SampleFDO] Flow Sensitive Sample FDO (FSAFDO) profile loader

RKSimon added inline comments. Comment at: llvm/lib/LTO/LTOBackend.cpp:234 + if (TM) +TM->setPGOOption(PGOOpt); @xur Why does TM need a null check - afaict it's already been dereferenced in the call tree, and will be again below. Noticed in a scan-build

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

RKSimon added a comment. Something I noticed is that we don't have much test coverage in clang/test/codegen for the fpclass intrinsics - including no constexpr testing afaict (although I don't think __builtin_fpclassify is constexpr yet) - is that something you'd be willing to take a look at?

[PATCH] D104601: [Preprocessor] Implement -fminimize-whitespace.

RKSimon added inline comments. Comment at: clang/lib/Frontend/PrintPreprocessedOutput.cpp:680 +if (RequireSpace || (!MinimizeWhitespace && Tok.hasLeadingSpace()) || +((EmittedTokensOnThisLine || EmittedTokensOnThisLine) && + AvoidConcat(PrevPrevTok, PrevTok, T

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

RKSimon added inline comments. Comment at: llvm/include/llvm/Support/X86TargetParser.def:220 + +// FIXME: When commented out features are supported in LLVM, enable them here. +CPU_SPECIFIC("generic", 'A', "") what commented out features? Repository: rG LLVM G

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

RKSimon added a comment. There's nothing later than CannonLake here - does Intel need to at least reference up to Tiger/Rocketlake? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108422/new/ https://reviews.llvm.org/D108422 ___

[PATCH] D69560: [clang-tidy] Add 'bugprone-easily-swappable-parameters' check

RKSimon added inline comments. Comment at: clang-tools-extra/clang-tidy/bugprone/EasilySwappableParametersCheck.cpp:57 + "Const_Reverse_Iterator", + "const_reverse_iterator" + "

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

RKSimon added a comment. In D108422#2958591 , @LuoYuanke wrote: > In D108422#2957541 , @erichkeane > wrote: > >> In D108422#2957528 , @RKSimon >> wrote: >> >>> There's n

[PATCH] D108422: [NFC][clang] Move remaining part of X86Target.def to llvm/Support/X86TargetParser.def

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108422/new/ https://reviews.llvm.org/D108422

[PATCH] D107347: [Sema] haveSameParameterTypes - fix repeated isNull() test

RKSimon added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107347/new/ https://reviews.llvm.org/D107347 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D105269: [X86] AVX512FP16 instructions enabling 6/6

RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:47419 + : X86ISD::VFCMADDC; + // FIXME: How we handle when FMF of FADD is different from CFMUL's? + CFmul = DAG.getNode(newOp, SDLoc(N), CVT,

[PATCH] D109497: [X86][AVX] Update _mm256_loadu2_m128* intrinsics to use _mm256_set_m128* (PR51796)

RKSimon created this revision. RKSimon added reviewers: craig.topper, pengfei, spatel. RKSimon requested review of this revision. Herald added a project: clang. As reported on PR51796, the _mm256_loadu2_m128i in particular was inserting bitcasts and shuffles with different types making it trickie

[PATCH] D106804: [test-suite] Add tests for FP classification intrinsics

RKSimon added a comment. I've no objections to this - it seems to be orthogonal to the isnan ir intrinsic conversation. Do we have test-suite buildbot coverage on anything other than x86? Cross platform uses of long double is always fun Any other comments? Repository: rT test-suite

[PATCH] D109225: [clang-nvlink-wrapper] Add documentation in clang docs

RKSimon added inline comments. Comment at: clang/docs/ClangNvlinkWrapper.rst:17 +files. It reads each input archive file to extract the archived cubin files as +temporary files. These temporary (*.cubin) files are passed to ``nvlink``. + @saiislam The "(*.cubin)"

<    1   2   3   4   5   6   7   >