[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

RKSimon updated this revision to Diff 494917. RKSimon added a comment. Add bazel build fix for llvm-cxxmap Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143318/new/ https://reviews.llvm.org/D143318 Files: clang/docs/tools/clang-formatted-files.t

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

RKSimon updated this revision to Diff 494925. RKSimon added a comment. fix the git diff lost renames Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143318/new/ https://reviews.llvm.org/D143318 Files: clang/docs/tools/clang-formatted-files.txt l

[PATCH] D143318: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from Support to ProfileData

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c8fe9658236: [Support] Move ItaniumManglingCanonicalizer and SymbolRemappingReader from… (authored by RKSimon). Changed prior to commit: https://

[PATCH] D141798: Drop the ZeroBehavior parameter from countLeadingZeros and the like (NFC)

RKSimon added a comment. @kazu Thanks for dealing with this! I'd like to build on this and create llvm variants of the C++20 countl_zero/countr_zero/countl_one/countr_one template functions similar to what I did for popcount in D132407 (and have MathExtras.h

[PATCH] D78028: move shebangs from python2 to python3

RKSimon added a comment. @LocutusOfBorg - a grep of llvm-project *.py files is not finding many matches for python2 - I'm assuming this was handled (e.g. update_cc_test_checks.py was updated in D129590 ). There might still be a few missed cases (or references t

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

RKSimon added inline comments. Comment at: llvm/lib/IR/Function.cpp:1430 +// This defines the "Intrinsic::getIntrinsicForClangBuiltin()" method. #define GET_LLVM_INTRINSIC_FOR_GCC_BUILTIN #include "llvm/IR/IntrinsicImpl.inc" Should this be updated to use GET_LL

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

RKSimon added a comment. @pratlucas I'm seeing errors on my EXPENSIVE_CHECKS builds - please can you take a look? Command Output (stdout): -- $ ":" "RUN: at line 1" $ "e:\llvm\ninja\bin\llc.exe" "-mtriple" "thumb-arm-none-eabi" "-filetype" "asm" "-o" "-" "E:\llvm\llvm-project\llvm\test\

[PATCH] D125094: [ARM][Thumb] Command-line option to ensure AAPCS compliant Frame Records

RKSimon added a comment. Cheers! Are you looking at a fix or please can you raise a ticket? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125094/new/ https://reviews.llvm.org/D125094 ___ cfe-commits mail

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

RKSimon added inline comments. Comment at: llvm/utils/TableGen/IntrinsicEmitter.cpp:883 void IntrinsicEmitter::EmitIntrinsicToBuiltinMap( const CodeGenIntrinsicTable &Ints, bool IsGCC, raw_ostream &OS) { + StringRef CompilerName = (IsGCC ? "Clang" : "MS");

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

RKSimon added a comment. LGTM (with one minor) - @efriedma any more feedback? Comment at: llvm/utils/TableGen/IntrinsicEmitter.cpp:82 // Emit code to translate GCC builtins into LLVM intrinsics. EmitIntrinsicToBuiltinMap(Ints, true, OS); "Clang buil

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

RKSimon accepted this revision. RKSimon added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127460/new/ https://reviews.llvm.org/D127460 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

RKSimon added a comment. I don't think this is really blocked on the libc team any more? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127460/new/ https://reviews.llvm.org/D127460 ___ cfe-commits mailing

[PATCH] D127460: Rename GCCBuiltin into ClangBuiltin

RKSimon added a comment. It looks like this is good to go - do you have commit access? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127460/new/ https://reviews.llvm.org/D127460 ___ cfe-commits mailing l

[PATCH] D155147: [X86] Add SM3 instructions.

RKSimon added inline comments. Comment at: clang/lib/Headers/sm3intrin.h:31 +/// +/// This intrinsic corresponds to the \c VPDPBSSD instruction. +/// VPDPBSSD ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/

[PATCH] D155146: [X86] Add SHA512 instructions.

RKSimon accepted this revision. RKSimon added a comment. LGTM - but I'd prefer more complete 32-bit vs 64-bit test coverage (similar to the SM3/SM4 patches) if its possible. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155146/new/ https://reviews

[PATCH] D155148: [X86] Add SM4 instructions.

RKSimon added inline comments. Comment at: clang/lib/Headers/sm4intrin.h:26 +/// +/// This intrinsic corresponds to the \c VPDPBSSD instruction. +/// VPDPBSSD ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/

[PATCH] D155148: [X86] Add SM4 instructions.

RKSimon added a comment. @pengfei Are you happy with the intrinsics doxygen descriptions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155148/new/ https://reviews.llvm.org/D155148 ___ cfe-commits mailin

[PATCH] D155147: [X86] Add SM3 instructions.

RKSimon added a comment. @pengfei Are you happy with the intrinsics doxygen descriptions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155147/new/ https://reviews.llvm.org/D155147 ___ cfe-commits mailin

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

RKSimon added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1922 +// RUN: --target=x86_64 \ +// RUN: | FileCheck -match-full-lines %s -check-prefix=CHECK_GNRD_M64 // CHECK_GNR_M64: #define __AES__ 1 Maybe create a common CHE

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

RKSimon added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:1925 // CHECK_GNR_M64: #define __AMX_BF16__ 1 -// CHECK_GNR_M64: #define __AMX_COMPLEX__ 1 +// CHECK_GNR_M64-NOT: #define __AMX_COMPLEX__ 1 +// CHECK_GNRD_M64: #define __AMX_COMPLEX__ 1 -

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

RKSimon added inline comments. Comment at: llvm/lib/Target/X86/X86.td:1082 FeaturePREFETCHI, - FeatureSHA512, FeatureAMXCOMPLEX];

[PATCH] D155798: [X86] Support -march=graniterapids-d and update -march=graniterapids

RKSimon accepted this revision. RKSimon added a comment. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155798/new/ https://reviews.llvm.org/D155798 ___ cfe-commits mailing list cfe-commits@

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

RKSimon added inline comments. Comment at: clang/test/Preprocessor/predefined-arch-macros.c:2570 // CHECK_SRF_M64: #define __AVXNECONVERT__ 1 +// CHECK_ARLS_M64: #define __AVXVNNIINT16__ 1 // CHECK_SRF_M64: #define __AVXVNNIINT8__ 1 Do the CHECK_SRF_M64-NOT tri

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

RKSimon added inline comments. Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:37 +; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=arrowlake-s 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty +; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unk

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

RKSimon added inline comments. Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:37 +; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=arrowlake-s 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty +; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unk

[PATCH] D156239: [X86] Support -march=arrowlake, arrowlake-s, lunarlake

RKSimon added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:430 + { {"arrowlake-s"}, CK_ArrowlakeS, FEATURE_AVX2, FeaturesArrowlakeS, '\0', false }, + { {"arrowlake_s"}, CK_Lunarlake, FEATURE_AVX2, FeaturesArrowlakeS, 'p', true }, + // Lunarlake micr

[PATCH] D157420: [clang] Enable constexpr on LZCNT/POPCNT MS extension intrinsics

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - cheers @alexguirre Please post your full name / email and I'll commit this for you Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D15742

[PATCH] D157420: [clang] Enable constexpr on LZCNT/POPCNT MS extension intrinsics

This revision was automatically updated to reflect the committed changes. Closed by commit rG00158ae236dd: [clang] Enable constexpr on LZCNT/POPCNT MS extension intrinsics (authored by alexguirre, committed by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D158046: [X86] Support -march=gracemont

RKSimon added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:551 case CK_Lunarlake: + case CK_Gracemont: case CK_Sierraforest: Why not handle this above (below tremont) as the next in the *mont series? Repository: rG LLVM Github Monorepo

[PATCH] D158046: [X86] Support -march=gracemont

RKSimon added inline comments. Comment at: clang/lib/Basic/Targets/X86.cpp:551 case CK_Lunarlake: + case CK_Gracemont: case CK_Sierraforest: FreddyYe wrote: > RKSimon wrote: > > Why not handle this above (below tremont) as the next in the *mont series? > G

[PATCH] D158046: [X86] Support -march=gracemont

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D158046/new/ https://reviews.llvm.org/D158046

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

RKSimon added a comment. @MrTrillian This is failing for me with: C:\LLVM\ninja>ninja check-llvm-codegen-x86 [0/1/0/1] Running lit suite C:/LLVM/llvm-project/llvm/test/CodeGen/X86llvm-lit.py: C:\LLVM\llvm-project\llvm\utils\lit\lit\TestingConfig.py:151: fatal: unable to parse config file '

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

RKSimon added inline comments. Comment at: llvm/utils/lit/lit/discovery.py:60 +cfgpath = util.abs_path_preserve_drive(cfgpath) +target = config_map.get(cfgpath) if target: Found the problem - you have moved the os.path.normpat

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

RKSimon added inline comments. Comment at: llvm/utils/lit/lit/discovery.py:60 +cfgpath = util.abs_path_preserve_drive(cfgpath) +target = config_map.get(cfgpath) if target: RKSimon wrote: > Found the problem - you have moved th

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

RKSimon added inline comments. Comment at: llvm/utils/lit/lit/discovery.py:60 +cfgpath = util.abs_path_preserve_drive(cfgpath) +target = config_map.get(cfgpath) if target: RKSimon wrote: > RKSimon wrote: > > Found the problem

[PATCH] D157078: [include-cleaner] Handle files with unnamed buffers

RKSimon added a comment. In D157078#4562788 , @tylanphear wrote: > Seeing the link error downstream. I think clangSerialization needs to be > added to the link libraries. Should be fixed by 36daf3532d91bb

[PATCH] D157420: [clang] Enable constexpr on LZCNT/POPCNT MS extension intrinsics

RKSimon added reviewers: erichkeane, aaron.ballman. RKSimon added a comment. Please can you add them to the constexpr lists in LanguageExtensions.rst ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157420/new/ https://reviews.llvm.org/D157420

[PATCH] D157297: [clang] Fixes compile error like error: expected unqualified-id for ::_tzcnt_u32(mask);

RKSimon added a comment. Would we be better off creating proper function definitions - we already have similar duplicates for `_bextr_u64` (Intel) vs `__bextr_u64` (AMD) names that do this Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D157297/new/

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - but it would be good to fix silvermont / westmere cases as well with suitable test coverage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

RKSimon added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:378 + { {"core_3rd_gen_avx"}, CK_IvyBridge, FEATURE_AVX, FeaturesIvyBridge, 'S', true }, + { {"core-avx-i"}, CK_IvyBridge, FEATURE_AVX, FeaturesIvyBridge, '\0', false }, // Haswell microar

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

RKSimon added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific-cpus.c:40 ATTR(cpu_specific(knm)) void CPU(void){} +ATTR(cpu_specific(cascadelake)) void CPU(void){} +ATTR(cpu_specific(cooperlake)) void CPU(void){} FreddyYe wrote: > In this patch,

[PATCH] D151696: [X86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

RKSimon accepted this revision. RKSimon added a comment. LGTM - cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https://reviews.llvm.org/D151696 ___ cfe-commits mailing list cfe-commits@

[PATCH] D154493: [X86] Support some Intel CPUs for cpu_specific/dispatch feature

RKSimon added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:333 { {"pentium"}, CK_Pentium, ~0U, FeatureX87 | FeatureCMPXCHG8B, 'B', false }, { {"pentium-mmx"}, CK_PentiumMMX, ~0U, FeaturesPentiumMMX, '\0', false }, { {"pentium_mmx"}, CK_PentiumMM

[PATCH] D154493: [X86] Support some Intel CPUs for cpu_specific/dispatch feature

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:333 { {"pentium"}, CK_Pentium, ~0U, FeatureX87 | FeatureCMPXCHG8B, 'B', false }, { {"pentium-mmx"}, CK_Pent

[PATCH] D155147: Add SM3 instructions.

RKSimon added inline comments. Comment at: clang/lib/Headers/sm3intrin.h:21 + +static __inline__ __m128i __DEFAULT_FN_ATTRS128 _mm_sm3msg1_epi32(__m128i __A, + __m128i __B, Doxygen descriptions? =

[PATCH] D155148: Add SM4 instructions.

RKSimon added inline comments. Comment at: clang/lib/Headers/sm4intrin.h:17 + +#define _mm_sm4key4_epi32(A, B) \ + (__m128i) __builtin_ia32_vsm4key4128((__v4su)A, (__v4su)B) doxygen descriptions?

[PATCH] D155146: Add SHA512 instructions.

RKSimon added inline comments. Comment at: clang/lib/Headers/sha512intrin.h:21 + +static __inline__ __m256i __DEFAULT_FN_ATTRS256 +_mm256_sha512msg1_epi64(__m256i __A, __m128i __B) { doxygen descriptions? Comment at: clang/test/CodeGen/X86/sha5

[PATCH] D155145: [X86] Add AVX-VNNI-INT16 instructions.

RKSimon added inline comments. Comment at: clang/lib/Headers/avxvnniint16intrin.h:26 + +static __inline__ __m128i __DEFAULT_FN_ATTRS128 _mm_dpwsud_epi32(__m128i __A, + __m128i __B, doxygen descriptio

[PATCH] D159250: [X86][RFC] Add new option `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features

RKSimon added a comment. Would it be possible to add function multiversioning tests to ensure the evex512 attribute would work with it? Comment at: clang/lib/CodeGen/Targets/X86.cpp:1517 + bool Caller256 = CallerMap.lookup("avx512f") && !CallerMap.lookup("evex512"); + bool C

[PATCH] D159250: [X86][RFC] Add new option `-m[no-]evex512` to disable ZMM and 64-bit mask instructions for AVX512 features

RKSimon accepted this revision. RKSimon added a comment. LGTM with a couple of minors Comment at: clang/lib/CodeGen/Targets/X86.cpp:1493 const llvm::StringMap &CalleeMap, QualType Ty, StringRef Feature,

[PATCH] D139073: [X86] AMD Zen 4 Initial enablement

RKSimon added a comment. Thank you @gganesh I thought you'd forgotten about us :) Please add znver4 test coverage to: llvm/test/CodeGen/X86/cpus-amd.ll llvm/test/CodeGen/X86/slow-unaligned-mem.ll Comment at: llvm/lib/Target/X86/X86.td:1619 ProcessorFeatures.Z

[PATCH] D76622: ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard

RKSimon created this revision. RKSimon added reviewers: Charusso, ddcc, rnk, xbolva00. Herald added a project: clang. This was noticed on D71817 , which removed another use of __OPTIMIZE__ Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D76622 F

[PATCH] D76622: [analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard

This revision was automatically updated to reflect the committed changes. Closed by commit rG1a4421a5e860: [analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific)… (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D76622: [analyzer] ConstraintManager - use EXPENSIVE_CHECKS instead of (gcc specific) __OPTIMIZE__ guard

RKSimon added a comment. In D76622#1938009 , @NoQ wrote: > Sounds good but eventually i hope we re-enable this assert in release+assert > builds (D57062 ). SGTM as long as you don't reintroduce a compiler specific guard

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

RKSimon created this revision. RKSimon added reviewers: craig.topper, spatel. Herald added subscribers: cfe-commits, hiraditya. Herald added projects: clang, LLVM. This removes everything but int_x86_avx512_mask_vcvtph2ps_512 which provides the SAE variant, but even this can use the fpext generic

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

RKSimon added a comment. In D75162#1896365 , @craig.topper wrote: > Should we check that this generates constrained.fpext in strict mode? Sure - where is the best place(s) to test this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

RKSimon updated this revision to Diff 247288. RKSimon added a comment. Add strict fp codegen tests - this means the patch is now dependent on D75304 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D75162/new/ https:/

[PATCH] D75162: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion (PR37554)

This revision was automatically updated to reflect the committed changes. Closed by commit rG7e9747b50bcb: [X86][F16C] Remove cvtph2ps intrinsics and use generic half2float conversion… (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D75162?vs=247288&id=247454#toc Repos

[PATCH] D68854: [X86] add mayRaiseFPException flag and FPCW registers for X87 instructions

RKSimon added a comment. @LiuChen3 @craig.topper This has broken EXPENSIVE_CHECKS builds, please can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-ubuntu/builds/184/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D75786: [clang-tidy] Move fuchsia-restrict-system-includes to portability module for general use.

RKSimon added a comment. @PaulkaToast This patch appears to have caused a buildbot issue, please can you investigate/revert: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/63869 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D74046: [clang][driver] Fix null pointer dereference warning inside PrintActions1 (PR43462)

RKSimon created this revision. RKSimon added reviewers: sfantao, tra, ABataev, jlebar. Herald added a project: clang. As detailed on PR43462, clang static analyzer is complaining about a null pointer dereference as we provide a 'host' toolchain fallback if the ToolChain pointer is null, but then

[PATCH] D74046: [clang][driver] Fix null pointer dereference warning inside PrintActions1 (PR43462)

This revision was automatically updated to reflect the committed changes. Closed by commit rGe63abde39f53: [clang][driver] Fix null pointer dereference warning inside PrintActions1… (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/

[PATCH] D68720: Support -fstack-clash-protection for x86

RKSimon added a comment. @serge-sans-paille Please can you fix the issues with EXPENSIVE_CHECKS builds: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-debian/builds/2604 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68720/new/

[PATCH] D72897: List implicit operator== after implicit destructors in a vtable.

RKSimon added a comment. @rsmith This is failing on http://lab.llvm.org:8011/builders/llvm-clang-win-x-armv7l/builds/3169 - please can you take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72897/new/ https://reviews.llvm.org/D72897 __

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

RKSimon added a comment. Add to isNegatibleForFree/getNegatedExpression as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72824/new/ https://reviews.llvm.org/D72824 ___ cfe-commits mailing list cf

[PATCH] D72824: [X86] Add combination for fma and fneg on X86 under strict FP.

RKSimon added a comment. In D72824#1835633 , @pengfei wrote: > In D72824#1835568 , @RKSimon wrote: > > > Add to isNegatibleForFree/getNegatedExpression as well? > > > We don't need to add them to isNegatibleForFree/

[PATCH] D73335: clang-format: [JS] options for arrow functions.

RKSimon added inline comments. Comment at: clang/lib/Format/TokenAnnotator.cpp:3165 + } +} + @mprobst - this is breaking buildbots: http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-android/builds/27196/steps/bootstrap%20clang/logs/stdio Please

[PATCH] D45421: [X86] Emit native IR for pmuldq/pmuludq builtins.

RKSimon added a comment. IIRC the SSE pmovsx/pmovzx generic implementations do this? Repository: rC Clang https://reviews.llvm.org/D45421 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-c

[PATCH] D38824: [X86] Synchronize the existing CPU predefined macros with the cases that gcc defines them

RKSimon added inline comments. Comment at: lib/Basic/Targets/X86.cpp:835 defineCPUMacros(Builder, "slm"); +// gcc also defineds 'silvermont', but we never have. See comment below. break; defines https://reviews.llvm.org/D38824 _

[PATCH] D38824: [X86] Synchronize the existing CPU predefined macros with the cases that gcc defines them

RKSimon added a comment. Where is the best place to document this policy so people have a chance of understanding it going forward? https://reviews.llvm.org/D38824 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D38683: [X86][AVX512] lowering broadcastm intrinsic - clang part

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D38683 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[PATCH] D39719: [X86][AVX512] lowering kunpack intrinsic - clang part

RKSimon added inline comments. Comment at: lib/Headers/avx512bwintrin.h:2045 { - return (__mmask64) __builtin_ia32_kunpckdi ((__mmask64) __A, -(__mmask64) __B); + return (__mmask64) (( __B & 0x) | ((__mmask64) __A << 32)); } Is this

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

RKSimon added a comment. In D143287#4150186 , @ManuelJBrito wrote: > There are some performance regressions with casts from 128 to 512. The > backend inserts vinsertf instructions. So that has to be fixed. > In D130339

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/avx-cast-builtins.c:1 -// RUN: %clang_cc1 %s -O3 -flax-vector-conversions=none -ffreestanding %s -triple=x86_64-unknown-unknown -target-feature +avx -target-feature +avx512f -target-feature +avx512fp16 -S -o - |

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144903/new/ https://reviews.llvm.org/D144903 _

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

RKSimon added a comment. @ManuelJBrito Any luck with getting this committed? Your first attempt was reverted but was it just because of the bad Differential Revision tag? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144903/new/ https://reviews.ll

[PATCH] D144903: [X86] Drop single use check for freeze(undef) in LowerAVXCONCAT_VECTORS

RKSimon added a comment. In D144903#4169623 , @ManuelJBrito wrote: > It seems the build failure was caused by a known crash > https://github.com/llvm/llvm-project/issues/55263. I tried to find some > workaround but unsuccessfully. @pengfei Do you kno

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

RKSimon added a comment. It might be worth adding something to the release notes explaining that removal of the flag Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145715/new/ https://reviews.llvm.org/D145715 __

[PATCH] D145715: Remove -lower-global-dtors-via-cxa-atexit flag

RKSimon added a comment. In D145715#4185070 , @thetruestblue wrote: > This looks good to me. I'm not sure the policy on what should be added to the > release notes. But this was a temporary flag only added to slowly deprecate > this, and was noted when

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

RKSimon added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:110 FeatureBitset Features; + char Mangling; + bool OnlyForCPUDispatchSpecific; Do we have a documented list of the mangling values anywhere? The values below look too much

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

RKSimon added a comment. Please can you cleanup the summary, as it isn't very easy to understand at the moment. Possibly split into a series of bullet points describing the changes? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D151696/new/ https:/

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

RKSimon added a comment. In D151696#4458751 , @FreddyYe wrote: > In D151696#4458443 , @pengfei wrote: > >> It looks to me the failed unit tests might be related to this patch, please >> take a look. > > This is d

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

RKSimon added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific.c:47 // LINUX: %[[FEAT_INIT:.+]] = load i32, ptr getelementptr inbounds ({ i32, i32, i32, [1 x i32] }, ptr @__cpu_model, i32 0, i32 3, i32 0), align 4 -// LINUX: %[[FEAT_JOIN:.+]] = and i32 %[[FEAT_I

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getCPUDispatchMangling

RKSimon added inline comments. Comment at: clang/test/CodeGen/attr-cpuspecific.c:47 // LINUX: %[[FEAT_INIT:.+]] = load i32, ptr getelementptr inbounds ({ i32, i32, i32, [1 x i32] }, ptr @__cpu_model, i32 0, i32 3, i32 0), align 4 -// LINUX: %[[FEAT_JOIN:.+]] = and i32 %[[FEAT_I

[PATCH] D154209: [X86] Add missing features for ivybridge, sandybridge and knl in X86TargetParser.def.

RKSimon added inline comments. Comment at: llvm/include/llvm/TargetParser/X86TargetParser.def:262 CPU_SPECIFIC("core_i7_sse4_2", "nehalem", 'P', "+cmov,+mmx,+sse,+sse2,+sse3,+ssse3,+sse4.1,+sse4.2,+popcnt") CPU_SPECIFIC("core_aes_pclmulqdq", "westmere", 'Q', "+cmov,+mmx,+sse,

[PATCH] D153006: [clang][dataflow] Perform deep copies in copy and move operations.

RKSimon added a comment. @mboehme https://lab.llvm.org/buildbot/#/builders/124 is still broken - please can you revert the patch series? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153006/new/ https://reviews.llvm.org/D153006 __

[PATCH] D147481: [M68k] Add basic Clang supports for M68881/2

RKSimon added inline comments. Comment at: clang/test/Driver/m68k-macros.cpp:2 // Check macro definitions // RUN: %clang -target m68k-unknown-linux -m68000 -dM -E %s | FileCheck --check-prefix=CHECK-MX %s +// RUN: %clang -target m68k-unknown-linux -m68000 -mhard-float -dM -E %

[PATCH] D147901: [NFC][CLANG][API] Fix coverity remarks about large copies by values

RKSimon added inline comments. Comment at: clang/include/clang/ExtractAPI/API.h:138 APIRecord(RecordKind Kind, StringRef USR, StringRef Name, -PresumedLoc Location, AvailabilitySet Availabilities, +PresumedLoc Location, const AvailabilitySet &Availabili

[PATCH] D143287: [Clang][X86] Change X86 cast intrinsics to use __builtin_nondeterministic_value

RKSimon accepted this revision. RKSimon added a comment. LGTM - just simplify the shuffle masks (even if it break 80-col). Please keep an eye out for any regressions, I'm not certain we've shaken out every possible issue. Comment at: clang/lib/Headers/avx512fintrin.h:401 + r

[PATCH] D143287: [Clang][x86] Change x86 cast intrinsics to use __builtin_nondeterministic_value

RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/avx-builtins.c:146 // CHECK-LABEL: test_mm256_castpd128_pd256 - // CHECK: shufflevector <2 x double> %{{.*}}, <2 x double> %{{.*}}, <4 x i32> + // CHECK: shufflevector <2 x double> %{{.*}}, <2 x double> %{{.

[PATCH] D150114: [Headers][doc] Add "add/sub/mul" intrinsic descriptions to avx2intrin.h

RKSimon added a comment. @pengfei Any objections? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150114/new/ https://reviews.llvm.org/D150114 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

RKSimon added inline comments. Comment at: llvm/lib/TargetParser/X86TargetParser.cpp:15 #include "llvm/ADT/StringSwitch.h" +#include "llvm/ADT/StringExtras.h" #include (clang-format) - include order Comment at: llvm/lib/TargetParser/X86Targe

[PATCH] D151696: [x86] Remove CPU_SPECIFIC* MACROs and add getManglingForCPU

RKSimon added inline comments. Comment at: llvm/test/CodeGen/X86/cpus-intel.ll:8 ; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown -mcpu=pentium 2>&1 | FileCheck %s --check-prefix=CHECK-NO-ERROR --allow-empty -; RUN: llc < %s -o /dev/null -mtriple=i686-unknown-unknown

[PATCH] D139507: [Intrinsic] Add get.rounding as alias to flt.rounds and rename related DAG nodes

RKSimon added a comment. In D139507#3978449 , @sepavloff wrote: > Thank you for working on this! > > Is there any reason why we should keep the old intrinsic? I'm not clear on the general policy, but for x86 we tend to provide bc of old intrinsics/sigta

[PATCH] D139073: [X86] AMD Zen 4 Initial enablement

RKSimon added a comment. @GGanesh reverse-ping Comment at: llvm/lib/Target/X86/X86.td:1619 ProcessorFeatures.ZN3Tuning>; +def : ProcModel<"znver4", Znver3Model, ProcessorFeatures.ZN4Features, +ProcessorFeatures.ZN4Tuning>; RKSim

[PATCH] D139073: [X86] AMD Zen 4 Initial enablement

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. Thanks @GGanesh - LGTM with one minor - the orphan ZNVER4 checks from the llvm-mca tests need removing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D139073: [X86] AMD Zen 4 Initial enablement

RKSimon accepted this revision. RKSimon added a comment. cheers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139073/new/ https://reviews.llvm.org/D139073 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D28018: AMD family 17h (znver1) enablement

RKSimon added a reviewer: RKSimon. RKSimon added a comment. Also, I don't think there is any clzero support on clang yet so adding that feature probably isn't safe. You may need to put up a separate clzero patch for review, preferably including _mm_clzero support to the headers as well. Reposi

[PATCH] D28018: AMD family 17h (znver1) enablement

RKSimon added inline comments. Comment at: lib/Basic/Targets.cpp:3189 break; + case CK_ZNVER1: +setFeatureEnabledImpl(Features, "adx", true); Same as what I asked on D28017 - is there an accepted order that we should be using here? https://reviews.ll

[PATCH] D28018: AMD family 17h (znver1) enablement

RKSimon added inline comments. Comment at: lib/Basic/Targets.cpp:3189 break; + case CK_ZNVER1: +setFeatureEnabledImpl(Features, "adx", true); GGanesh wrote: > RKSimon wrote: > > Same as what I asked on D28017 - is there an accepted order that we should

<    1   2   3   4   5   6   7   >