[PATCH] D55937: [X86] Auto upgrade XOP/AVX512 rotation intrinsics to generic funnel shift intrinsics (clang)

This revision was automatically updated to reflect the committed changes. Closed by commit rC349796: [X86] Auto upgrade XOP/AVX512 rotation intrinsics to generic funnel shift… (authored by RKSimon, committed by ). Changed prior to commit: https://reviews.llvm.org/D55937?vs=179089&id=179105#toc

[PATCH] D56365: [X86] Use funnel shift intrinsics for the VBMI2 vshld/vshrd intrinsics.

RKSimon added inline comments. Comment at: test/CodeGen/avx512vlvbmi2-builtins.c:415 // CHECK-LABEL: @test_mm256_mask_shldv_epi64 - // CHECK: @llvm.x86.avx512.mask.vpshldv.q.256 + // CHECK: @llvm.fshl.v4i64(<4 x i64> %{{.*}}, <4 x i64> %{{.*}}, <4 x i64> %{{.*}}) return

[PATCH] D56365: [X86] Use funnel shift intrinsics for the VBMI2 vshld/vshrd builtins.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM in conjunction with the fast-isel changes in D56377 Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D56365/new/ https://

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

RKSimon added a comment. In D64146#1665003 , @nand wrote: > Totally missed that - thanks for noticing. I must have forgotten to remove > stuff from the header since clang/gcc don't warn about it. > I'll get hold of a Windows machine soon-ish and I'll mak

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

RKSimon added a comment. rebase? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64146/new/ https://reviews.llvm.org/D64146 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

RKSimon added a comment. Thanks - this builds cleanly on MSVC now Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64146/new/ https://reviews.llvm.org/D64146 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

RKSimon added a comment. In D64146#1667567 , @nand wrote: > Thanks for looking into the problem - sorry for the delay! No problem, you still need a specialist to approve the patch though Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D64146: [Clang Interpreter] Initial patch for the constexpr interpreter

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. Accepting this to remove the block Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D64146/new/ https://reviews.llvm.org/D64146 ___

[PATCH] D67854: Ensure AtomicExpr goes through SEMA checking after TreeTransform

RKSimon added a comment. @erichkeane The atomic-expr.cpp test is failing on some MSVC buildbots, please can you take a look? http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/ Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67854/ne

[PATCH] D66951: [ASTImporter] Add comprehensive tests for ODR violation handling strategies

RKSimon added a comment. @martong This is failing on windows buildbots: http://lab.llvm.org:8011/builders/llvm-clang-x86_64-expensive-checks-win/builds/19808 Repository: rL LLVM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66951/new/ https://reviews.llvm.org/D66951 _

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGcb3d969453c9: Revert rL372693 : [clang-tidy] New bugprone-infinite-loop check for detecting… (authored by RKSimon). Chang

[PATCH] D64736: [clang-tidy] New bugprone-infinite-loop check for detecting obvious infinite loops

RKSimon reopened this revision. RKSimon added a comment. @baloghadamsoftware I'm sorry but I've reverted this at as rL372704 it was causing buildbot failures in cmake: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/18147 Repository: rL L

[PATCH] D45619: [Time-report] (1) Use special new Clang flag 'FrontendTimesIsEnabled' instead of 'llvm::TimePassesIsEnabled' inside -ftime-report feature

RKSimon closed this revision. RKSimon added a comment. This was committed at https://reviews.llvm.org/rL330571 Repository: rL LLVM https://reviews.llvm.org/D45619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-b

[PATCH] D48712: [X86] Lowering integer truncation intrinsics to native IR

RKSimon added inline comments. Comment at: clang/lib/Headers/avx512vlbwintrin.h:1501 + (__v8qi){0, 0, 0, 0, 0, 0, 0, 0}, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, + 12, 13, 14, 15); } Are we happy with using illegal types like this? What about flipping the

[PATCH] D48712: [X86] Lowering integer truncation intrinsics to native IR

RKSimon added a comment. Please can you create a llvm side parallel patch that updates the relevant fast-isel tests Comment at: clang/lib/Headers/avx512vlbwintrin.h:1501 + (__v8qi){0, 0, 0, 0, 0, 0, 0, 0}, 0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, + 12, 13, 14, 15); } -

[PATCH] D48712: [X86] Lowering integer truncation intrinsics to native IR

RKSimon added a comment. LGTM - @craig.topper any comments? https://reviews.llvm.org/D48712 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

RKSimon added a comment. Can we add -Wsign-conversion checks to the tests? That was mentioned on PR45931 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80251/new/ https://reviews.llvm.org/D80251 ___ cfe-commits mailing list cfe-commits@lists

[PATCH] D80251: [X86] Update some av512 shift intrinsics to use "unsigned int" parameter instead of int to match Intel documentaiton

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. In D80251#2049975 , @craig.topper wrote: > In D80251#2049418 , @RKSimon wrote: > > > Can we add -Wsign-conve

[PATCH] D77572: [clang-tidy] add new check readability-use-anyofallof

RKSimon added a comment. @mgehre Please can you take at the remaining buildbot failures here : http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/68662 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77572/new/ https

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

RKSimon added a reviewer: RKSimon. RKSimon added a comment. Rename test file to x86-header-warnings.c or something similarly specific? Comment at: clang/test/Headers/warn-cleanup.c:10 +#include +#include + Use x8intrin.h directly so its easier to expand in th

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

RKSimon added a comment. @craig.topper Any comments? Hopefully we can add extra tests as time goes on (for instance I'm intending to add Wdocumentation test coverage for PR35949). Comment at: clang/test/Headers/x86-header-warnings.c:12 +void test() { + // CHECK-NOT: warning:

[PATCH] D77393: [X86] Fix implicit sign conversion warnings in X86 headers.

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM with the minor addition an extra CHECK-LABEL CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77393/new/ https://reviews.llvm.org/D77393 ___

[PATCH] D69171: [clang-fuzzer] Add new fuzzer target for Objective-C

RKSimon added inline comments. Comment at: clang/tools/clang-fuzzer/ClangObjectiveCFuzzer.cpp:19 -extern "C" int LLVMFuzzerInitialize(int *argc, char ***argv) { return 0; } - @dgoldman @morehouse Removing this has been causing link failures ever since it was c

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

RKSimon edited reviewers, added: efriedma; removed: eli.friedman. RKSimon added a comment. Any frontend people got any comments on this? I'm keen to see constexpr vector support added but know next to nothing about the frontend. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79755/new/

[PATCH] D83254: [X86] Enabled a bunch of 64-bit Interlocked* functions intrinsics on 32-bit Windows to match recent MSVC

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83254/new/ https://reviews.llvm.org/D83254 ___ cfe-commits mailing list cfe-commits

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

RKSimon closed this revision. RKSimon added a comment. Committed at rGb30c16670e428d09a0854a8f418e46a3e705e4d1 (with a typo in the Differential Revision tag so phab didn't catch it) CHANGES SINCE LAST ACTION https://review

[PATCH] D82731: [X86] Move frontend CPU feature initialization to a look up table based implementation.

RKSimon added a comment. LGTM with a couple of minors Comment at: clang/test/Preprocessor/predefined-arch-macros.c:2835 // CHECK_ZNVER1_M32: #define __F16C__ 1 +// CHECK_ZNVER1_M32-NOT: #define __FMA4__ 1 // CHECK_ZNVER1_M32: #define __FMA__ 1 The additional

[PATCH] D78533: [i386] Fix bug that get __m128/__m256/__m512 with wrong alignment for variadic functions.

RKSimon added a subscriber: cfe-commits. RKSimon added a comment. CCing cfe-commits CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78533/new/ https://reviews.llvm.org/D78533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[PATCH] D78982: [clang-format] Fix Microsoft style for enums

RKSimon added a comment. @asmith I'm seeing MSVC warnings from this patch: E:\llvm\llvm-project\clang\lib\Format\UnwrappedLineParser.cpp(1475): warning C4305: 'argument': truncation from 'clang::tok::TokenKind' to 'bool' E:\llvm\llvm-project\clang\lib\Format\UnwrappedLineParser.cpp(1828): warnin

[PATCH] D55307: [analyzer] MoveChecker Pt.6: Suppress the warning for the few move-safe STL classes.

RKSimon added inline comments. Herald added subscribers: steakhal, ASDenysPetrov, martong, Charusso. Comment at: lib/StaticAnalyzer/Checkers/MoveChecker.cpp:81 + "optional", + "packaged_task" + "promise", @NoQ https://bugs.llvm.org/show_bug.cgi?id=

[PATCH] D79755: Implement constexpr BinaryOperator for vector types

RKSimon added reviewers: rsmith, void. RKSimon added a comment. Adding some people who know more about this CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79755/new/ https://reviews.llvm.org/D79755 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D79830: Add support of __builtin_expect_with_probability

RKSimon added a comment. Add a description in our documentation? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79830/new/ https://reviews.llvm.org/D79830 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D133737: [HLSL] [clang] Add vector version of abs for HLSL

RKSimon added a comment. The elementwise builtins should work for scalars as well (and IIRC we do test this as well). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D133737/new/ https://reviews.llvm.org/D133737 _

[PATCH] D117522: [clang-tidy] Add modernize-macro-to-enum check

RKSimon added inline comments. Comment at: clang-tools-extra/clang-tidy/modernize/MacroToEnumCheck.cpp:216 + MacroToEnumCheck *Check; + const LangOptions &LangOptions; + const SourceManager &SM; @LegalizeAdulthood I'm seeing errors in https://lab.llvm.org/bu

[PATCH] D122077: [InstCombine] Fold (ctpop(X) == 1) | (X == 0) into ctpop(X) < 2

RKSimon added a comment. rebase? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122077/new/ https://reviews.llvm.org/D122077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[PATCH] D122874: [clang] Add GNU spelling for no_unqiue_address attribute

RKSimon resigned from this revision. RKSimon added a comment. Sorry but this is not an area I know enough about to review Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122874/new/ https://reviews.llvm.org/D122874 __

[PATCH] D122139: [pseudo] Introduce parse forest.

RKSimon added inline comments. Comment at: clang-tools-extra/pseudo/include/clang-pseudo/Forest.h:158 + size_t nodeCount() const { return NodeCount; } + size_t bytes() const { return Arena.getBytesAllocated() + sizeof(this); } + @hokein Static analysis is warni

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

RKSimon added a comment. Are you intending to AutoUpgrade the existing intrinsics in IR? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131547/new/ https://reviews.llvm.org/D131547 ___ cfe-commits mailing

[PATCH] D118996: [clang-tidy] Support C++14 in bugprone-signal-handler.

RKSimon added a comment. @balazske This is failing on https://lab.llvm.org/buildbot/#/builders/139/builds/26335 - do you have a fix in progress or should I revert? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118996/new/ https://reviews.llvm.org

[PATCH] D131547: [Clang][AArch64] Use generic extract/insert vector for svget/svset/svcreate tuples

RKSimon added a comment. In D131547#3712509 , @CarolineConcatto wrote: >> Are you intending to AutoUpgrade the existing intrinsics in IR? > > @RKSimon > AFAIK we want to remove them altogether. > It is not expected that external projects depend on the

[PATCH] D104854: Introduce intrinsic llvm.isnan

RKSimon added inline comments. Comment at: llvm/test/CodeGen/X86/x86-fpclass.ll:173 + +define <1 x i1> @isnan_double_vec1(<1 x double> %x) { +; CHECK-32-LABEL: isnan_double_vec1: add nounwind to reduce cfi noise (other tests would benefit as well)?

[PATCH] D107004: Turn off fp reassociation in IA intrinsic header files.

RKSimon requested changes to this revision. RKSimon added a comment. This revision now requires changes to proceed. I really don't support this change - -ffast-math should be allowed to perform aggressive folds and it makes no sense to make an exception for common intrinsics like these. We shou

[PATCH] D104854: Introduce intrinsic llvm.isnan

RKSimon added inline comments. Comment at: llvm/test/Transforms/InstCombine/fpclass.ll:29 + ret <2 x i1> %t +} + You probably need some negative tests (no flags, ninf instead of nnan etc.)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

RKSimon added a comment. Herald added a subscriber: asb. @yln I've reverted your commit at rG7262eacd41997d7ca262d83367e28998662c1b21 to try and get the buildbots green again Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D121327: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

RKSimon added a comment. In D121327#3383733 , @yln wrote: > New revision here: D121736 FYI - you could have continued to use this phab for review, it makes it easier to compare the changes you've made Repository: r

[PATCH] D121815: [X86] Use the unaligned vector typedefs for the lddqu intrinsics pointer arguments (PR20670)

RKSimon created this revision. RKSimon added reviewers: craig.topper, pengfei. Herald added a project: All. RKSimon requested review of this revision. Herald added a project: clang. Extension to rG4390c721cba09597037578100948bbc83cc41b16

[PATCH] D121815: [X86] Use the unaligned vector typedefs for the lddqu intrinsics pointer arguments (PR20670)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4e4f839ac2a9: [X86] Use the unaligned vector typedefs for the lddqu intrinsics pointer… (authored by RKSimon). Repository: rG LLVM Github Monorepo

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon added a comment. In D117829#3386398 , @fhahn wrote: > @RKSimon are you planning on pushing this patch through? From my perspective, > it looks good with splitting off `__builtin_reduce_mul` and adding a TODO to > also implement it for floating p

[PATCH] D121736: Lower `@llvm.global_dtors` using `__cxa_atexit` on MachO

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - but please hang around after you commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121736/new/ https://reviews.llvm.org/D121736 ___

[PATCH] D122077: [InstCombine] Fold (ctpop(X) == 1) | (X == 0) into ctpop(X) < 2

RKSimon added inline comments. Comment at: llvm/test/Transforms/InstCombine/icmp-or.ll:382 + ret i1 %5 +} + What about if the ctpop has multi uses? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122077/new/ https:

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon added a comment. Herald added a subscriber: StephenFan. @fhahn Remind me - why did you want me to split these? If we're initially just going for integer support, can't both be done at the same time in this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon updated this revision to Diff 421556. RKSimon added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/ https://reviews.llvm.org/D117829 Files: clang/include/clang/Basic/Builtins.def clang/lib/CodeGen/CGBuiltin.

[PATCH] D123436: [Clang] Pass llvm::BitstreamCursor by reference. NFC

RKSimon added inline comments. Comment at: clang/lib/Serialization/GlobalModuleIndex.cpp:130 std::unique_ptr IndexBuffer, -llvm::BitstreamCursor Cursor) +llvm::BitstreamCursor &Cursor) : Buffer(std::move(IndexBuffer)), IdentifierIndex(), NumIdentifierLookups(),

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

RKSimon added a comment. I'm updating the sse builtin test files to include i386 coverage - should be done in an hour or so CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124067/new/ https://reviews.llvm.org/D124067 ___ cfe-commits mailing li

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

RKSimon added a comment. OK - SSE2/SSE41 now have i386 coverage - please can you rebase and update the checks to use CHECK/X64/X86 ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124067/new/ https://reviews.llvm.org/D124067 ___ cfe-commits m

[PATCH] D124067: [x86] Support 3 builtin functions for 32-bits targets

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM with one minor typo Comment at: clang/lib/Headers/emmintrin.h:3476 +/// This intrinsic corresponds to the VMOVQ / MOVQ instruction +/// in 64 bits. ///

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

RKSimon updated this revision to Diff 406264. RKSimon added a comment. rebase, simplify description in documentation and add _BitInt test coverage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117898/new/ https://reviews.llvm.org/D117898 Files:

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

RKSimon added inline comments. Comment at: clang/docs/LanguageExtensions.rst:549 + T __builtin_elementwise_add_sat(T x, T y) return the sum of x and y, clamped to the range of signed or integer types + values representable by the bit

[PATCH] D117898: [Clang] Add elementwise saturated add/sub builtins

This revision was automatically updated to reflect the committed changes. Closed by commit rGc00db9715975: [Clang] Add elementwise saturated add/sub builtins (authored by RKSimon). Changed prior to commit: https://reviews.llvm.org/D117898?vs=406264&id=406756#toc Repository: rG LLVM Github Mo

[PATCH] D110869: [X86] Implement -fzero-call-used-regs option

RKSimon added a comment. @void This buildbot appears to be still broken due to this change: https://lab.llvm.org/buildbot/#/builders/110/builds/10271 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110869/new/ https://reviews.llvm.org/D110869 _

[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

RKSimon added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:453 +return "uwtable"; + return ("uwtable(" + Twine(Kind == UWTableKind::Sync ? "sync" : "async") + + ")") @chill Static analysis is warning that its impossible to hi

[PATCH] D123436: [Clang] Use std::move in GlobalModuleIndex::readIndex. NFC

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123436/new/ https://reviews.llvm.org/D123436 _

[PATCH] D124469: [NFC] Cleanup miscellaneous header items

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM Comment at: clang/lib/Headers/__wmmintrin_pclmul.h:25 /// \code -/// __m128i _mm_clmulepi64_si128(__m128i __X, __m128i __Y, const int __I); +/// __m128i _mm_clmulepi6

[PATCH] D117829: [Clang] Add integer add/mul reduction builtins

RKSimon added a comment. ping? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/ https://reviews.llvm.org/D117829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[PATCH] D124164: [include-cleaner] Include-cleaner library structure, and simplistic AST walking.

RKSimon added a comment. @sammccall It looks like this is causing a link error on some PPC builds: https://lab.llvm.org/buildbot/#/builders/57/builds/17387 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124164/new/ https://reviews.llvm.org/D124164

[PATCH] D124741: [Clang] Add integer add reduction builtin

RKSimon created this revision. RKSimon added reviewers: fhahn, scanon, aaron.ballman, craig.topper. Herald added a subscriber: StephenFan. Herald added a project: All. RKSimon requested review of this revision. Herald added a project: clang. Similar to the existing bitwise reduction builtins, this

[PATCH] D124741: [Clang] Add integer add reduction builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rGa23291b7db48: [Clang] Add integer add reduction builtin (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D124741/new/ https://reviews.llv

[PATCH] D117829: [Clang] Add integer mul reduction builtin

RKSimon updated this revision to Diff 426366. RKSimon retitled this revision from "[Clang] Add integer add/mul reduction builtins" to "[Clang] Add integer mul reduction builtin". RKSimon edited the summary of this revision. RKSimon added a comment. Just handle the mul case now that D124741

[PATCH] D117829: [Clang] Add integer mul reduction builtin

RKSimon updated this revision to Diff 426367. RKSimon added a comment. Add "__builtin_reduce_mul" to the docs listing supported reductions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/ https://reviews.llvm.org/D117829 Files: clang/do

[PATCH] D124757: [X86] Replace avx512f integer add reduction builtins with generic builtin

RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper. Herald added a subscriber: StephenFan. Herald added a project: All. RKSimon requested review of this revision. Herald added a project: clang. D124741 added the generic "__builtin_redu

[PATCH] D124757: [X86] Replace avx512f integer add reduction builtins with generic builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a14c369c422: [X86] Replace avx512f integer add reduction builtins with generic builtin (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

RKSimon added inline comments. Comment at: clang/test/CodeGen/X86/sse-builtins-constrained.c:5 +// RUN: %clang_cc1 -ffreestanding %s -triple=x86_64-unknown-linux-gnu -target-feature +sse -S -o - -Wall -Werror | FileCheck %s --check-prefix=CHECK-ASM --check-prefix=COMMON +// RUN

[PATCH] D124916: [X86] Fix uninitialized variable warnings in cetintrin.h reported by #55224

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - I'm intending to add -Wsystem-headers to the clang x86 builtins tests once everything is clean. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D117829: [Clang] Add integer mul reduction builtin

RKSimon added a comment. ping @scanon Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/ https://reviews.llvm.org/D117829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper. Herald added a subscriber: StephenFan. Herald added a project: All. RKSimon requested review of this revision. Herald added a project: clang. Another step toward enabling -Wsystem-headers testing across all x86 headers

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon updated this revision to Diff 427844. RKSimon added a comment. Remove a couple of superfluous casts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://reviews.llvm.org/D125164 Files: clang/lib/Headers/avx512bwintrin.h cl

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon added inline comments. Comment at: clang/lib/Headers/cetintrin.h:26 #ifdef __x86_64__ static __inline__ void __DEFAULT_FN_ATTRS _incsspq(unsigned long long __a) { __builtin_ia32_incsspq(__a); @pengfei The Intel Intrisics guide has this taking a int ?

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon added a comment. In D125164#3498723 , @pengfei wrote: > One question: is it better to change the define of builtins than explicit > casts? I can fix the signedness of the cet / rdseed / xbgen / tzcnt x86 builtins if there's a consensus. What d

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon added a comment. Actually the ia32_tzcnt builtins should stay the way they are - other C/C++ intrinsics return unsigned so we'd still end up with adding explicit casts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://revie

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon updated this revision to Diff 427860. RKSimon added a comment. Fix signedness on 32-bit cet tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://reviews.llvm.org/D125164 Files: clang/lib/Headers/avx512bwintrin.h clan

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon updated this revision to Diff 427863. RKSimon added a comment. Move the exhaustive headers checks into x86-intrinsics-headers-clean.cpp as that's what its for Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://reviews.llvm.o

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon added inline comments. Comment at: clang/lib/Headers/cetintrin.h:37 static __inline__ void __DEFAULT_FN_ATTRS _inc_ssp(unsigned int __a) { - __builtin_ia32_incsspd((int)__a); + __builtin_ia32_incsspd((unsigned int)__a); } pengfei wrote: > Unnecessary

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

RKSimon updated this revision to Diff 427868. RKSimon added a comment. Remove superflouous cast from "_inc_ssp" Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125164/new/ https://reviews.llvm.org/D125164 Files: clang/lib/Headers/avx512bwintrin.h

[PATCH] D125170: [Headers][X86] Replace \operation with \verbatim

RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper, tianqing, xiangzhangllvm, LiuChen3. Herald added a subscriber: StephenFan. Herald added a project: All. RKSimon requested review of this revision. Herald added a project: clang. \operation ... \endoperation are not val

[PATCH] D125170: [Headers][X86] Replace \operation with \verbatim

RKSimon added a comment. If people prefer we can alternatively use \code{.unparsed} .. \endcode blocks - I'm unsure if these operation blocks are being used in a particular way downstream Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125170/new/

[PATCH] D125164: [X86] Fix some signedness errors in x86 headers

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf2b16488129e: [X86] Fix some signedness errors in x86 headers (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D125170: [Headers][X86] Replace \operation with \verbatim

RKSimon updated this revision to Diff 427913. RKSimon edited the summary of this revision. RKSimon added a comment. Use \code{.operation} ... \endcode Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125170/new/ https://reviews.llvm.org/D125170 Files

[PATCH] D125170: [Headers][X86] Replace \operation with \code{.operation}

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6b3a111a2867: [Headers][X86] Replace \operation with \code{.operation} (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D129891: [test-suite] Update the test suite for changes to -Wint-conversion

RKSimon added a comment. @aaron.ballman It looks like this broke the clang-ppc64-aix buildbot https://lab.llvm.org/buildbot/#/builders/214 /home/powerllvm/powerllvm_env/aix-ppc64/clang-ppc64-aix/test/sandbox/test-suite/tools/timeit --summary MultiSource/Applications/siod/CMakeFiles/siod.dir/

[PATCH] D117829: [Clang] Add integer mul reduction builtin

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a92c45e07dc: [Clang] Add integer mul reduction builtin (authored by RKSimon). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117829/new/ https://reviews.llv

[PATCH] D125222: [X86] Replace avx512f integer mul reduction builtins with generic builtin

RKSimon created this revision. RKSimon added reviewers: pengfei, craig.topper. Herald added a subscriber: StephenFan. Herald added a project: All. RKSimon requested review of this revision. Herald added a project: clang. D117829 added the generic "__builtin_redu

[PATCH] D125222: [X86] Replace avx512f integer mul reduction builtins with generic builtin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec6024d0811b: [X86] Replace avx512f integer mul reduction builtins with generic builtin (authored by RKSimon). Repository: rG LLVM Github Monorepo

[PATCH] D125429: Comment parsing: Allow inline commands to have 0 or more than 1 argument

RKSimon added a comment. Thanks @aaronpuchert ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125429/new/ https://reviews.llvm.org/D125429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[PATCH] D125256: [OpenMP] Add `__CUDA_ARCH__` definition when offloading with OpenMP

RKSimon added a comment. @jhuber6 I think this or one of your other openmp commits has caused the Driver/cuda-openmp-driver.cu test failure here: https://lab.llvm.org/buildbot/#/builders/214/builds/1274/steps/6/logs/stdio Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[PATCH] D125256: [OpenMP] Add `__CUDA_ARCH__` definition when offloading with OpenMP

RKSimon added a comment. Sorry - my mistake - its a different test failure now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125256/new/ https://reviews.llvm.org/D125256 ___ cfe-commits mailing list cfe

[PATCH] D125604: [FileCheck] Catch missspelled directives.

RKSimon added a comment. Thanks @kosarev - CodeGen\X86 should be clean now! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125604/new/ https://reviews.llvm.org/D125604 ___ cfe-commits mailing list cfe-com

[PATCH] D125604: [FileCheck] Catch missspelled directives.

RKSimon added inline comments. Comment at: llvm/test/DebugInfo/X86/debug-info-template-parameter.ll:36 ; CHECK-NEXT: DW_AT_name {{.*}} "i" -; CHECK_NEXT: DW_AT_default_value {{.*}} true +; TODO-NEXT: DW_AT_default_value {{.*}} true Should be fixed by rGf718664

[PATCH] D125604: [FileCheck] Catch missspelled directives.

RKSimon added inline comments. Comment at: llvm/test/CodeGen/AArch64/fp16-v8-instructions.ll:682-688 +; TODO-CVT-DAG: fcvtl [[LO:v[0-9]+\.4s]], v0.4h +; TODO-CVT-DAG: fcvtl2 [[HI:v[0-9]+\.4s]], v0.8h +; TODO-CVT-DAG: fcvtzs [[LOF32:v[0-9]+\.4s]], [[LO]] +; TODO-CVT-DAG:

[PATCH] D63638: [clang][NewPM] Add new pass manager RUN lines to avx512f-builtins.c

RKSimon added a comment. In D63638#1596313 , @leonardchan wrote: > I created D65110 if we're ok with just > using the new PM. @craig.topper Is this patch still relevant? CHANGES SINCE LAST ACTION https://reviews.llv

[PATCH] D66669: [X86] Remove what little support we had for MPX

RKSimon accepted this revision. RKSimon added a comment. This revision is now accepted and ready to land. LGTM - please reword the X86InstrMPX.td comment like @xbolva00 suggested Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D9/new/ https://revi

<    1   2   3   4   5   6   7   >