smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
This is a generalization of `_LIBCPP_NEW_DELETE_VIS`; the new macro name
captures the semantics better, and also allows us to get rid of the
`_WIN32` check in `include/ne
smeenai added a comment.
In https://reviews.llvm.org/D26657#596759, @hans wrote:
> > On MSVC, if an implicit instantiation already exists and an explicit
> > instantiation definition with a DLL attribute is created, the DLL
> > attribute still takes effect. Make clang match this behavior.
>
> T
smeenai added a comment.
In https://reviews.llvm.org/D26702#597377, @EricWF wrote:
> What happens on windows when `operator new` isn't overridden and has to be
> imported from the DLL? Does that work?
Yup. If you have a function that isn't marked `dllimport` and it's not found
locally, the li
smeenai added a comment.
In https://reviews.llvm.org/D26657#597523, @hans wrote:
> In https://reviews.llvm.org/D26657#596897, @smeenai wrote:
>
> > In https://reviews.llvm.org/D26657#596759, @hans wrote:
> >
> > > > On MSVC, if an implicit instantiation already exists and an explicit
> > > > ins
Author: smeenai
Date: Wed Nov 16 16:18:10 2016
New Revision: 287164
URL: http://llvm.org/viewvc/llvm-project?rev=287164&view=rev
Log:
[libc++] Introduce `_LIBCPP_OVERRIDABLE_FUNC_VIS`
This is a generalization of `_LIBCPP_NEW_DELETE_VIS`; the new macro name
captures the semantics better, and also
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287164: [libc++] Introduce `_LIBCPP_OVERRIDABLE_FUNC_VIS`
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D26702?vs=78079&id=78264#toc
Repository:
rL LLVM
https://reviews.ll
smeenai added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7670-7673
+if ((Old_TSK == TSK_ExplicitInstantiationDeclaration ||
+ Old_TSK == TSK_ImplicitInstantiation) &&
(TSK == TSK_ExplicitInstantiationDefinition ||
DLLImportExplicitInstan
smeenai updated this revision to Diff 78322.
smeenai added a comment.
Limiting to dllexport after discussion with @hans
https://reviews.llvm.org/D26657
Files:
lib/Sema/SemaTemplate.cpp
test/CodeGenCXX/dllexport.cpp
test/CodeGenCXX/windows-itanium-dllexport.cpp
Index: test/CodeGenCXX/win
smeenai updated this revision to Diff 78324.
smeenai added a comment.
Moving explanation to comment instead of referencing Phabricator
https://reviews.llvm.org/D26657
Files:
lib/Sema/SemaTemplate.cpp
test/CodeGenCXX/dllexport.cpp
test/CodeGenCXX/windows-itanium-dllexport.cpp
Index: test
smeenai added a comment.
Ping.
I used @EricWF's ABI list verification work to confirm that this diff doesn't
change the ABI of libc++ on both Darwin and Linux, so it should be completely
safe.
Building with hidden visibility on top of this patch gives the following ABI
removals: https://revie
smeenai added a comment.
I should clarify that the ABI omissions are for Linux.
https://reviews.llvm.org/D25208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai created this revision.
smeenai added reviewers: mclow.lists, EricWF.
smeenai added a subscriber: cfe-commits.
Fix a typo in the conditional. Caught by going through list of removed
symbols when building with hidden visibility.
https://reviews.llvm.org/D26825
Files:
include/new
Inde
Author: smeenai
Date: Thu Nov 17 22:31:09 2016
New Revision: 287309
URL: http://llvm.org/viewvc/llvm-project?rev=287309&view=rev
Log:
[libc++] Fix preprocessor guard for overload declaration
Fix a typo in the conditional. Caught by going through list of removed
symbols when building with hidden
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287309: [libc++] Fix preprocessor guard for overload
declaration (authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D26825?vs=78447&id=78461#toc
Repository:
rL LLVM
https://rev
smeenai added inline comments.
Comment at: lib/Sema/SemaTemplate.cpp:7670-7673
+if ((Old_TSK == TSK_ExplicitInstantiationDeclaration ||
+ Old_TSK == TSK_ImplicitInstantiation) &&
(TSK == TSK_ExplicitInstantiationDefinition ||
DLLImportExplicitInstan
smeenai updated this revision to Diff 78620.
smeenai updated the summary for this revision.
smeenai added a comment.
Addressing comments
https://reviews.llvm.org/D26657
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaTemplate.cpp
test/CodeGenCXX/dllexport.cpp
test/CodeGenCXX/windows-itani
smeenai updated this revision to Diff 78621.
smeenai added a comment.
Typo in comment
https://reviews.llvm.org/D26657
Files:
include/clang/Sema/Sema.h
lib/Sema/SemaTemplate.cpp
test/CodeGenCXX/dllexport.cpp
test/CodeGenCXX/windows-itanium-dllexport.cpp
Index: test/CodeGenCXX/windows-it
smeenai created this revision.
smeenai added reviewers: mclow.lists, EricWF.
smeenai added a subscriber: cfe-commits.
It's useful to be able to disable visibility annotations entirely; for
example, if we're building libc++ static to include in another library,
and we don't want any libc++ function
smeenai updated this revision to Diff 78785.
smeenai added a comment.
Adding documentation per @EricWF's comment
https://reviews.llvm.org/D26934
Files:
docs/UsingLibcxx.rst
include/__config
Index: include/__config
===
--- incl
smeenai created this revision.
smeenai added reviewers: EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
The function definitions being guarded by the pragma were all static, so
they wouldn't be exported anyway. In any case, we should prefer the
visibility macros. No functional change
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, howard.hinnant, mclow.lists.
smeenai added a subscriber: cfe-commits.
Use the libc++abi visibility macros instead of pragmas or using
visibility attributes directly. Clean up redundant attributes on
definitions (where the de
smeenai created this revision.
smeenai added reviewers: EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
It's useful to be able to disable visibility annotations entirely; for
example, if we're building libc++abi static to include in another library,
and we don't want any libc++abi fu
smeenai added a comment.
General coding style question. Over here, I'm creating a local helper function.
However, that helper needs to access member functions of Sema, which is why I
made it a private member function right now, which also unfortunately makes the
change somewhat non-local (since
Author: smeenai
Date: Wed Nov 23 10:11:15 2016
New Revision: 287768
URL: http://llvm.org/viewvc/llvm-project?rev=287768&view=rev
Log:
[libc++] Remove unneeded visibility pragmas
The function definitions being guarded by the pragma were all static, so
they wouldn't be exported anyway. In any case,
This revision was automatically updated to reflect the committed changes.
Closed by commit rL287768: [libc++] Remove unneeded visibility pragmas
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D26940?vs=78792&id=79090#toc
Repository:
rL LLVM
https://reviews.llvm.org
smeenai added a comment.
In https://reviews.llvm.org/D26934#603997, @EricWF wrote:
> There are two usages of `_LIBCPP_DISABLE_DLL_IMPORT_EXPORT` in
> `CMakeLists.txt` and `__config_site.in` that need to be changed as well.
Oops, will fix.
> Also what about users of the existing name
> `_LIBC
Author: smeenai
Date: Mon Dec 5 12:01:35 2016
New Revision: 288682
URL: http://llvm.org/viewvc/llvm-project?rev=288682&view=rev
Log:
[Sema] Respect DLL attributes more faithfully
On MSVC, if an implicit instantiation already exists and an explicit
instantiation definition with a DLL attribute is
Author: smeenai
Date: Mon Dec 5 13:40:12 2016
New Revision: 288690
URL: http://llvm.org/viewvc/llvm-project?rev=288690&view=rev
Log:
[libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS
It's useful to be able to disable visibility annotations entirely; for
example, if we're building libc++ static
Author: smeenai
Date: Mon Dec 5 13:42:11 2016
New Revision: 288692
URL: http://llvm.org/viewvc/llvm-project?rev=288692&view=rev
Log:
[libc++abi] Add _LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS
It's useful to be able to disable visibility annotations entirely; for
example, if we're building libc++a
Author: smeenai
Date: Mon Dec 12 20:43:04 2016
New Revision: 289513
URL: http://llvm.org/viewvc/llvm-project?rev=289513&view=rev
Log:
[libc++abi] Mark failing test on Darwin as XFAIL
The macOS thread-local variable finalizer routines do not handle the
case where a termination function registers a
Author: smeenai
Date: Wed Apr 19 15:11:04 2017
New Revision: 300743
URL: http://llvm.org/viewvc/llvm-project?rev=300743&view=rev
Log:
[libc++] Use _LIBCPP_ABI_MICROSOFT instead of _MSC_VER
_LIBCPP_ABI_MICROSOFT is more appropriate to use here, since the
conditionals are controlling Microsoft mang
Author: smeenai
Date: Wed Apr 19 20:11:42 2017
New Revision: 300804
URL: http://llvm.org/viewvc/llvm-project?rev=300804&view=rev
Log:
[Sema] Use MSVC inner class behavior on Itanium
Windows Itanium aims to use MSVC export and import semantics. Inner
class members shouldn't be exported on a dllexp
Author: smeenai
Date: Thu Apr 20 18:33:49 2017
New Revision: 300921
URL: http://llvm.org/viewvc/llvm-project?rev=300921&view=rev
Log:
[libc++] Default to vcruntime when targeting MSVC
Summary:
libc++abi is never the right option for LIBCXX_TARGETING_MSVC, since it
targets the Itanium ABI, whereas
Author: smeenai
Date: Wed May 10 16:52:39 2017
New Revision: 302739
URL: http://llvm.org/viewvc/llvm-project?rev=302739&view=rev
Log:
[libc++abi] Disable libc++ extern templates project-wide
libc++abi can't depend on libc++, so disable extern templates in libc++
headers project-wide. This was pre
smeenai created this revision.
smeenai added reviewers: EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Create this define in __config and use it elsewhere, instead of checking
the operating system/library defines in other files. The aim is to
reduce the usage of _WIN32 outside __con
smeenai added a comment.
Ping.
The way I see it, this doesn't change anything for people not building with
hidden visibility (which should be most people, including the buildbots), but
it does make `_LIBCPP_TYPE_VIS` more useful (and consistent with the existing
Windows behavior) for people bu
smeenai updated this revision to Diff 75142.
smeenai added a comment.
Addressing @mclow.lists's comment
https://reviews.llvm.org/D25741
Files:
include/__config
include/fstream
Index: include/fstream
===
--- include/fstream
++
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, howard.hinnant, ikudrin, mclow.lists.
smeenai added a subscriber: cfe-commits.
Mach-O defaults to two-level namespaces, so `calloc` cannot be
interpositoned. Override it via the default malloc zone instead.
Note: `DYLD_FORC
Author: smeenai
Date: Mon Oct 31 10:09:10 2016
New Revision: 285582
URL: http://llvm.org/viewvc/llvm-project?rev=285582&view=rev
Log:
[libc++] Add configuration define for off_t functions
Create this define in __config and use it elsewhere, instead of checking
the operating system/library defines
This revision was automatically updated to reflect the committed changes.
Closed by commit rL285582: [libc++] Add configuration define for off_t
functions (authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D25741?vs=75142&id=76411#toc
Repository:
rL LLVM
https://review
smeenai added a comment.
Ping :)
https://reviews.llvm.org/D25208
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai added a comment.
In https://reviews.llvm.org/D26150#587973, @ikudrin wrote:
> This test is extremely fragile. Maybe, it is better to disable it, or even
> delete it altogether.
I'll take your word for it, as the original author of the test, though I'm
curious about where the fragility
smeenai created this revision.
smeenai added reviewers: beanz, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
When ensuring an out-of-source build, compare to the libc++ source
directory instead of the top-level cmake source directory (which would
smeenai created this revision.
smeenai added reviewers: compnerd, EricWF, mclow.lists.
smeenai added a subscriber: cfe-commits.
Visual Studio 2013 and up have these functions, and we don't need to
support older versions.
https://reviews.llvm.org/D26377
Files:
include/cstdio
Index: include/c
smeenai updated this revision to Diff 77119.
smeenai updated the summary for this revision.
smeenai added a comment.
Fixing some more exclusions
https://reviews.llvm.org/D26377
Files:
include/cmath
include/cstdio
include/cwchar
Index: include/cwchar
=
Author: smeenai
Date: Mon Nov 7 21:31:42 2016
New Revision: 286202
URL: http://llvm.org/viewvc/llvm-project?rev=286202&view=rev
Log:
[libc++] Remove unnecessary MSVCRT exclusions
Visual Studio 2013 and up have these functions, and we don't need to
support older versions.
There are some remainin
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286202: [libc++] Remove unnecessary MSVCRT exclusions
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D26377?vs=77119&id=77136#toc
Repository:
rL LLVM
https://reviews.llvm.o
smeenai added a comment.
In https://reviews.llvm.org/D26375#588949, @beanz wrote:
> This patch doesn't make sense to me.
>
> In an in-tree build `CMAKE_SOURCE_DIR` would be the LLVM source directory
> which shouldn't match your `CMAKE_BINARY_DIR`.
>
> In an out-of-tree build `CMAKE_SOURCE_DIR` w
smeenai abandoned this revision.
smeenai added a comment.
Abandoning this then. In case the new incarnation of the test needs to
overwrite any memory allocation methods, this diff has the most reliable way to
do it on OS X :)
https://reviews.llvm.org/D26150
_
smeenai created this revision.
smeenai added a reviewer: compnerd.
smeenai added a subscriber: cfe-commits.
Similar to r284288, make the Itanium ABI follow MS ABI dllexport
semantics in the case of an explicit instantiation declaration followed
by a dllexport explicit instantiation definition.
h
Author: smeenai
Date: Wed Nov 9 17:52:20 2016
New Revision: 286419
URL: http://llvm.org/viewvc/llvm-project?rev=286419&view=rev
Log:
[Sema] Use MS ABI behavior for dllexport in Itanium
Similar to r284288, make the Itanium ABI follow MS ABI dllexport
semantics in the case of an explicit instantia
This revision was automatically updated to reflect the committed changes.
Closed by commit rL286419: [Sema] Use MS ABI behavior for dllexport in Itanium
(authored by smeenai).
Changed prior to commit:
https://reviews.llvm.org/D26471?vs=77392&id=77418#toc
Repository:
rL LLVM
https://reviews.
https://github.com/smeenai created
https://github.com/llvm/llvm-project/pull/102571
The previous logic could fail in some edge cases.
>From 28297fc4e0b3b21990f1d614115b8eb946989479 Mon Sep 17 00:00:00 2001
From: Shoaib Meenai
Date: Wed, 13 Dec 2023 18:59:25 -0800
Subject: [PATCH] [hmaptool] F
https://github.com/smeenai created
https://github.com/llvm/llvm-project/pull/102648
The idea is that the output of `hmaptool dump --json` can be fed
directly back to `hmaptool write` for easy round-tripping.
>From 140a930607b34d2795defee00bbac59baf4c23c5 Mon Sep 17 00:00:00 2001
From: Shoaib M
https://github.com/smeenai closed
https://github.com/llvm/llvm-project/pull/104899
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smeenai approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/106603
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2900,7 +2900,7 @@ defm clangir : BoolFOption<"clangir",
PosFlag,
NegFlag LLVM
pipeline to compile">,
BothFlags<[], [ClangOption, CC1Option], "">>;
-def emit_cir : Flag<["-"], "emit-cir">, Visibility<[CC1Option]>,
+def emit_cir : Flag<["-"], "emit-cir">, Visibility<[C
https://github.com/smeenai closed
https://github.com/llvm/llvm-project/pull/102056
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Dave
Date: 2022-01-22T17:30:34-08:00
New Revision: b8467952404c3598c9c901332607eb1886e1721c
URL:
https://github.com/llvm/llvm-project/commit/b8467952404c3598c9c901332607eb1886e1721c
DIFF:
https://github.com/llvm/llvm-project/commit/b8467952404c3598c9c901332607eb1886e1721c.diff
LOG: [do
Author: Shoaib Meenai
Date: 2022-03-03T15:18:09-08:00
New Revision: 0c1d330431f59011fd861e291d5048858a973c5a
URL:
https://github.com/llvm/llvm-project/commit/0c1d330431f59011fd861e291d5048858a973c5a
DIFF:
https://github.com/llvm/llvm-project/commit/0c1d330431f59011fd861e291d5048858a973c5a.diff
Author: Shoaib Meenai
Date: 2022-03-03T15:18:21-08:00
New Revision: b4c1cbff79d0631c35ca2efa97bd2a47929945b8
URL:
https://github.com/llvm/llvm-project/commit/b4c1cbff79d0631c35ca2efa97bd2a47929945b8
DIFF:
https://github.com/llvm/llvm-project/commit/b4c1cbff79d0631c35ca2efa97bd2a47929945b8.diff
Author: Shoaib Meenai
Date: 2021-03-25T11:36:00-07:00
New Revision: 0135bc996d82ff68677820c421b4d666590e4f31
URL:
https://github.com/llvm/llvm-project/commit/0135bc996d82ff68677820c421b4d666590e4f31
DIFF:
https://github.com/llvm/llvm-project/commit/0135bc996d82ff68677820c421b4d666590e4f31.diff
Author: Shoaib Meenai
Date: 2021-03-25T11:36:06-07:00
New Revision: 33930a0787f6007ba7ebf36384115bebb412e08a
URL:
https://github.com/llvm/llvm-project/commit/33930a0787f6007ba7ebf36384115bebb412e08a
DIFF:
https://github.com/llvm/llvm-project/commit/33930a0787f6007ba7ebf36384115bebb412e08a.diff
Author: Shoaib Meenai
Date: 2021-01-09T11:57:27-08:00
New Revision: 4dbb3f57c6fe581ef525dbe49a401f4bab834eff
URL:
https://github.com/llvm/llvm-project/commit/4dbb3f57c6fe581ef525dbe49a401f4bab834eff
DIFF:
https://github.com/llvm/llvm-project/commit/4dbb3f57c6fe581ef525dbe49a401f4bab834eff.diff
https://github.com/smeenai updated
https://github.com/llvm/llvm-project/pull/104899
>From e0a1a4d57d2801f68adc0f4fe26d33d509956490 Mon Sep 17 00:00:00 2001
From: Shoaib Meenai
Date: Mon, 19 Aug 2024 18:05:52 -0700
Subject: [PATCH 1/2] [clang] Add support for omitting only global destructors
Fo
@@ -24,9 +27,149 @@ CIRGenModule::CIRGenModule(mlir::MLIRContext &context,
clang::ASTContext &astctx,
const clang::CodeGenOptions &cgo,
DiagnosticsEngine &diags)
-: astCtx(astctx), langOpts(ast
https://github.com/smeenai commented:
Very minor nits :)
Is it at all possible to write a test to exercise the new functionality, or
will it just run into an NYI?
https://github.com/llvm/llvm-project/pull/113483
___
cfe-commits mailing list
cfe-commi
https://github.com/smeenai edited
https://github.com/llvm/llvm-project/pull/113483
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -37,14 +40,39 @@ class CIRGenConsumer : public clang::ASTConsumer {
const LangOptions &LangOptions,
const FrontendOptions &FEOptions,
std::unique_ptr OS)
- : OutputStream(std::move(OS)), FS(VFS),
+ : Action(Action)
smeenai wrote:
I created https://github.com/llvm/clangir/issues/1062 to track the location
discussion in the incubator so that we can come back to it when the time is
right.
https://github.com/llvm/llvm-project/pull/113483
___
cfe-commits mailing lis
https://github.com/smeenai closed
https://github.com/llvm/llvm-project/pull/115568
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smeenai created
https://github.com/llvm/llvm-project/pull/115385
https://github.com/llvm/clangir/issues/1025 explains why we want to move
the CIR dialect from the `mlir::cir` to the `cir` namespace. To avoid
overloading the `cir` namespace too much afterwards, move all symbols
smeenai wrote:
Stack from [ghstack](https://github.com/ezyang/ghstack) (oldest at bottom):
* (to be filled)
https://github.com/llvm/llvm-project/pull/115385
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/
https://github.com/smeenai created
https://github.com/llvm/llvm-project/pull/115568
The buildX naming convention originated when the CIRGen implementation
was planned to be substantially different from original CodeGen. CIRGen
is now a much closer adaption of CodeGen, and the emitX to buildX
ren
smeenai wrote:
Do you need me to merge this for you? Could you also fix the message about
private email addresses above?
https://github.com/llvm/llvm-project/pull/116221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/smeenai closed
https://github.com/llvm/llvm-project/pull/116221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smeenai approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/116221
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smeenai wrote:
I think this makes sense in that case, though I'd wait for @llvm-beanz and
@petrhosek too.
https://github.com/llvm/llvm-project/pull/71653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/li
https://github.com/smeenai commented:
The runtimes build already builds the toolchain and then builds the runtimes
with the just-built toolchain. Can we build the LTO-optimized libc++ as part of
stage1 and have stage2 be what the current stage3 is, to avoid any redundancy?
I really like the di
@@ -74,6 +75,32 @@ class LLVMLoweringInfo {
class CIR_Op traits = []> :
Op, LLVMLoweringInfo;
+//===--===//
+// GlobalOp
+//===--===//
+
@@ -0,0 +1,27 @@
+//===- CIRTypes.h - MLIR CIR Types --*- C++
-*-===//
smeenai wrote:
Per
https://github.com/llvm/llvm-project/commit/e2c3d16282aca0f7e13f58170140647632d627c9,
we should remove the name and description and C++ from t
https://github.com/smeenai approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/119450
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smeenai closed
https://github.com/llvm/llvm-project/pull/137853
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smeenai created
https://github.com/llvm/llvm-project/pull/137853
The `llvm-headers` target wasn't depending on the generated TargetParser
headers, so they'd be flakily installed or not installed depending on
which order the build steps ran in. Add an explicit dependency to fix
@@ -862,13 +862,12 @@ void tools::addLTOOptions(const ToolChain &ToolChain,
const ArgList &Args,
const llvm::Triple &Triple = ToolChain.getTriple();
smeenai wrote:
Yeah, I think it's best to keep the old check as well as adding the new one.
https://github.co
301 - 385 of 385 matches
Mail list logo
