[clang] 1d62be2 - [clang][xray] Add -fxray-ignore-loops option

Author: Ian Levesque Date: 2020-01-17T13:32:24-08:00 New Revision: 1d62be244108547558c6d42ddcf2e4a7f3c6dd03 URL: https://github.com/llvm/llvm-project/commit/1d62be244108547558c6d42ddcf2e4a7f3c6dd03 DIFF: https://github.com/llvm/llvm-project/commit/1d62be244108547558c6d42ddcf2e4a7f3c6dd03.diff

[clang-tools-extra] c72a6ac - Revert "[clang-tidy] readability-identifier-naming disregards parameters restrictions on main like functions"

Author: Shoaib Meenai Date: 2020-01-27T11:50:25-08:00 New Revision: c72a6ac4b630d2344dbea44a7d75fa61795dcd76 URL: https://github.com/llvm/llvm-project/commit/c72a6ac4b630d2344dbea44a7d75fa61795dcd76 DIFF: https://github.com/llvm/llvm-project/commit/c72a6ac4b630d2344dbea44a7d75fa61795dcd76.diff

r328654 - [Sema] Avoid crash for category implementation without interface

Author: smeenai Date: Tue Mar 27 11:58:28 2018 New Revision: 328654 URL: http://llvm.org/viewvc/llvm-project?rev=328654&view=rev Log: [Sema] Avoid crash for category implementation without interface When we have a category implementation without a corresponding interface (which is an error by its

r329836 - [CodeGen] Handle __func__ inside __finally

Author: smeenai Date: Wed Apr 11 11:17:35 2018 New Revision: 329836 URL: http://llvm.org/viewvc/llvm-project?rev=329836&view=rev Log: [CodeGen] Handle __func__ inside __finally When we enter a __finally block, the CGF's CurCodeDecl will be null (because CodeGenFunction::StartFunction is given an

[clang-tools-extra] r317149 - [clang-reorder-fields] Switch to add_clang_tool

Author: smeenai Date: Wed Nov 1 18:10:05 2017 New Revision: 317149 URL: http://llvm.org/viewvc/llvm-project?rev=317149&view=rev Log: [clang-reorder-fields] Switch to add_clang_tool `add_clang_tool` invokes `add_clang_executable` internally, but it also takes care of setting up the install rule.

r317150 - [clang-rename] Use add_clang_tool

Author: smeenai Date: Wed Nov 1 18:11:40 2017 New Revision: 317150 URL: http://llvm.org/viewvc/llvm-project?rev=317150&view=rev Log: [clang-rename] Use add_clang_tool `add_clang_tool` includes a call to `add_clang_executable`, but it also sets up the install rule, and adds an `install-*` target.

[clang-tools-extra] r317155 - [clang-tidy] Clean up installation rules

Author: smeenai Date: Wed Nov 1 18:48:20 2017 New Revision: 317155 URL: http://llvm.org/viewvc/llvm-project?rev=317155&view=rev Log: [clang-tidy] Clean up installation rules An installation rule for the executable with the correct component is already created by `add_clang_tool`, so the rule in

[clang-tools-extra] r317187 - [clangd] Remove redundant install

Author: smeenai Date: Wed Nov 1 22:02:24 2017 New Revision: 317187 URL: http://llvm.org/viewvc/llvm-project?rev=317187&view=rev Log: [clangd] Remove redundant install `add_clang_tool` already adds the install command, so the one here is redundant. Modified: clang-tools-extra/trunk/clangd/to

r317188 - [libclang] Add dummy libclang-headers target

Author: smeenai Date: Wed Nov 1 22:04:00 2017 New Revision: 317188 URL: http://llvm.org/viewvc/llvm-project?rev=317188&view=rev Log: [libclang] Add dummy libclang-headers target `LLVM_DISTRIBUTION_COMPONENTS` assumes that each component has both `component` and `install-component` targets. Add a

[clang] 67a1129 - [Frontend] Don't output skipped includes from predefines

Author: Shoaib Meenai Date: 2023-06-21T15:48:27-07:00 New Revision: 67a11290df64fec44e671a1bdc3a225ed8a02962 URL: https://github.com/llvm/llvm-project/commit/67a11290df64fec44e671a1bdc3a225ed8a02962 DIFF: https://github.com/llvm/llvm-project/commit/67a11290df64fec44e671a1bdc3a225ed8a02962.diff

[clang] 1df10f1 - [Frontend] Remove ShowIncludesPretendHeader

Author: Shoaib Meenai Date: 2023-06-21T15:48:28-07:00 New Revision: 1df10f15807f9b7deba3f714d27e21578a8b4748 URL: https://github.com/llvm/llvm-project/commit/1df10f15807f9b7deba3f714d27e21578a8b4748 DIFF: https://github.com/llvm/llvm-project/commit/1df10f15807f9b7deba3f714d27e21578a8b4748.diff

[clang] 8f7b51e - [CodeGen] Make __clang_call_terminate have an unwind table entry

Author: Shoaib Meenai Date: 2023-05-25T10:56:23-07:00 New Revision: 8f7b51e4ec09f6f50ea6508a196ec607f0659179 URL: https://github.com/llvm/llvm-project/commit/8f7b51e4ec09f6f50ea6508a196ec607f0659179 DIFF: https://github.com/llvm/llvm-project/commit/8f7b51e4ec09f6f50ea6508a196ec607f0659179.diff

[libcxx] r290503 - [libc++] Make __num_get_float hidden

Author: smeenai Date: Sat Dec 24 12:05:32 2016 New Revision: 290503 URL: http://llvm.org/viewvc/llvm-project?rev=290503&view=rev Log: [libc++] Make __num_get_float hidden It's an internal function and shouldn't be exported. It's also a source of discrepancy in the published ABI list; these symbol

[libcxx] r291330 - [libc++] Correct macro name in documenation

Author: smeenai Date: Fri Jan 6 20:45:35 2017 New Revision: 291330 URL: http://llvm.org/viewvc/llvm-project?rev=291330&view=rev Log: [libc++] Correct macro name in documenation The macro is named `_LIBCPP_TEMPLATE_VIS`, not `_LIBCPP_TEMPLATE_ONLY`. No functional change. Modified: libcxx/tru

Re: [libcxx] r291329 - Add _LIBCPP_ABI_[ITANIUM|MICROSOFT] macros.

Do you think it's worth also checking for the presence of cxxabi.h and assuming the Itanium ABI if it's found, since the MS ABI shouldn't be using any ABI library? (_LIBCPP_BUILDING_HAS_NO_ABI_LIBRARY would have been ideal were it available persistently rather than only during the build of libc++

[libcxx] r291743 - [libc++] Pair _aligned_malloc with _aligned_free

Author: smeenai Date: Thu Jan 12 00:22:36 2017 New Revision: 291743 URL: http://llvm.org/viewvc/llvm-project?rev=291743&view=rev Log: [libc++] Pair _aligned_malloc with _aligned_free Attempting to pair an `_aligned_malloc` with a regular free causes heap corruption. Pairing with `_aligned_free` i

Re: [libcxx] r291072 - Get test-suite configuring on Windows with clang-cl

What was the rationale for forcing the use of lld? Were errors encountered with link? It's slightly annoying to have the extra dependency; I don't have lld built on my Windows box, for example, and while I could do so, I've also found link to work fine in my testing. On 1/4/17, 7:57 PM, "cfe-commi

[PATCH] D23719: [libc++] Use C11 for atomics check

smeenai created this revision. smeenai added reviewers: beanz, compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. The purpose of the check is to see if atomics are present and if they require an explicit -latomic to link. We can achieve this equally well by testing for C11 ato

Re: [PATCH] D23719: [libc++] Use C11 for atomics check

smeenai added a comment. @bcraig: `__STDC_NO_ATOMICS__` wouldn't be defined for pre-C11 compilers either, right? From what I understand of the original code sample, one of the purposes was to check for 64-bit atomic support on 32-bit systems (hence the use of `uintmax_t` and the check for `__a

Re: [PATCH] D23719: [libc++] Use C11 for atomics check

smeenai planned changes to this revision. smeenai added a comment. @rsmith: I think your points are valid, and I should have been more explicit with the motivation :) The issue is with linking, not with compiling. When we call `check_cxx_source_compiles`, the compiler driver passes all the stan

Re: [PATCH] D23719: [libc++] Use C11 for atomics check

smeenai added a comment. In https://reviews.llvm.org/D23719#521250, @rsmith wrote: > Is there a -nodefaultlib analogue of -nostdinc++ to turn off just the C++ > standard library portion of the link? There's `-nostdlib`, but if I'm parsing the GCC documentation

Re: [PATCH] D23719: [libc++] Use C11 for atomics check

smeenai abandoned this revision. smeenai added a comment. Will create a different change with the other config change, since it's completely different conceptually. https://reviews.llvm.org/D23719 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D23791: [libc++] Perform configuration checks with -nodefaultlibs

smeenai created this revision. smeenai added reviewers: beanz, compnerd, EricWF, mclow.lists, rsmith. smeenai added a subscriber: cfe-commits. We're compiling libc++ with -nodefaultlibs, so we should also pass this option during the configuration checks to ensure those checks are consistent with t

Re: [PATCH] D23791: [libc++] Perform configuration checks with -nodefaultlibs

I tested on OS X 10.11 and Ubuntu 16.04. Get Outlook for iOS On Mon, Aug 22, 2016 at 8:37 PM -0700, "Eric Fiselier" mailto:e...@efcs.ca>> wrote: What platforms was this tested on? On Aug 22, 2016 9:20 PM, "Shoaib Meenai" mailto:smee...@fb.com>> wrote: smeenai create

Re: [PATCH] D23791: [libc++] Perform configuration checks with -nodefaultlibs

via cfe-commits Reply-To: Shoaib Meenai Date: Tuesday, August 23, 2016 at 10:18 AM To: "reviews+d23791+public+1be7b6c753063...@reviews.llvm.org" , Eric Fiselier Cc: "mclow.li...@gmail.com" , Richard Smith , "cfe-commits@lists.llvm.org" Subject: Re: [P

[PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

smeenai created this revision. smeenai added reviewers: EricWF, compnerd. smeenai added subscribers: cfe-commits, kastiglione. We're compiling libc++ with -nodefaultlibs, so we should also pass this option during the configuration checks to ensure those checks are consistent with the actual build.

[PATCH] D23878: [libc++abi] Fix test under ASAN and MSAN

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, rsmith. smeenai added a subscriber: cfe-commits. When we're running tests under ASAN or MSAN, they're compiled with -O1, which enables tail call elimination. This causes backtrace_test to fail: the compiler performs tail cal

Re: [PATCH] D23878: [libc++abi] Fix test under ASAN and MSAN

smeenai updated this revision to Diff 69275. smeenai added a comment. Using attributes instead of compile flags, per compnerd's suggestion https://reviews.llvm.org/D23878 Files: test/backtrace_test.pass.cpp Index: test/backtrace_test.pass.cpp =

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

smeenai added inline comments. Comment at: cmake/config-ix.cmake:18 @@ +17,3 @@ +if (LIBCXX_SUPPORTS_NODEFAULTLIBS_FLAG) + list(APPEND CMAKE_REQUIRED_LIBRARIES -nodefaultlibs) + if (LIBCXX_HAS_C_LIB) compnerd wrote: > Can we not use `CMAKE_SHARED_LINKER_FLAGS` i

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

smeenai marked an inline comment as done. Comment at: cmake/config-ix.cmake:18 @@ +17,3 @@ +if (LIBCXX_SUPPORTS_NODEFAULTLIBS_FLAG) + list(APPEND CMAKE_REQUIRED_LIBRARIES -nodefaultlibs) + if (LIBCXX_HAS_C_LIB) smeenai wrote: > compnerd wrote: > > Can we not use

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

smeenai added inline comments. Comment at: cmake/config-ix.cmake:18 @@ +17,3 @@ +if (LIBCXX_SUPPORTS_NODEFAULTLIBS_FLAG) + list(APPEND CMAKE_REQUIRED_LIBRARIES -nodefaultlibs) + if (LIBCXX_HAS_C_LIB) EricWF wrote: > smeenai wrote: > > smeenai wrote: > > > compne

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

smeenai updated this revision to Diff 69607. smeenai added a comment. Putting -nodefaultlibs in CMAKE_REQUIRED_FLAGS https://reviews.llvm.org/D23856 Files: cmake/Modules/CheckLibcxxAtomic.cmake cmake/config-ix.cmake Index: cmake/config-ix.cmake =

Re: [PATCH] D23856: [libc++] Perform configuration checks with -nodefaultlibs

smeenai marked an inline comment as done. smeenai added a comment. https://reviews.llvm.org/D23856 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24065: [libc++] Don't attempt to dllexport enum class

smeenai created this revision. smeenai added reviewers: abdulras, EricWF, mclow.lists. smeenai added subscribers: cfe-commits, kastiglione. An enum class can't be dllexport'ed, and attempting to do so produces warnings. https://reviews.llvm.org/D24065 Files: include/__config Index: include/__

Re: [PATCH] D24065: [libc++] Don't attempt to dllexport enum class

smeenai added inline comments. Comment at: include/__config:719 @@ -718,3 +718,3 @@ #else // _LIBCPP_HAS_NO_STRONG_ENUMS -#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS x +#define _LIBCPP_DECLARE_STRONG_ENUM(x) enum class _LIBCPP_TYPE_VIS_ONLY x #define _LIB

Re: [PATCH] D24065: [libc++] Don't attempt to dllexport enum class

smeenai updated this revision to Diff 69797. smeenai updated the summary for this revision. smeenai added a comment. Removing export entirely, per compnerd's suggestion https://reviews.llvm.org/D24065 Files: include/__config Index: include/__config ===

Re: [PATCH] D24065: [libc++] Don't attempt to dllexport enum class

smeenai marked 3 inline comments as done. smeenai added a comment. https://reviews.llvm.org/D24065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24099: [libc++] Don't add -fPIC on Windows

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. -fPIC doesn't make much sense for Windows, since Windows DLLs aren't compiled position independent and are instead relocated at runtime instead. https://reviews.llvm.org

[PATCH] D24105: [libc++] Limit gets to CRT versions below 14

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added subscribers: cfe-commits, kastiglione. Microsoft removed gets from the CRT in Visual Studio 2015 onwards [1]. Attempting to reference it when targeting CRT versions 14 and above will cause compile

Re: [PATCH] D24065: [libc++] Use _LIBCPP_TYPE_VIS_ONLY with enum class

smeenai updated this revision to Diff 70087. smeenai retitled this revision from "[libc++] Don't attempt to dllexport enum class" to "[libc++] Use _LIBCPP_TYPE_VIS_ONLY with enum class". smeenai updated the summary for this revision. smeenai added a comment. Switching back to _LIBCPP_TYPE_VIS_ONL

[PATCH] D24314: [libc++] Clean up MSVC support

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. Visual Studio 2013 (CRT version 12) added support for many C99 long long and long double functions. Visual Studio 2015 (CRT version 14) increased C99 and C11 compliance f

Re: [PATCH] D24314: [libc++] Clean up MSVC support

smeenai added inline comments. Comment at: include/support/win32/support.h:48 @@ -47,2 +47,3 @@ #if defined(_LIBCPP_MSVCRT) +#if _VC_CRT_MAJOR_VERSION < 14 #define snprintf _snprintf EricWF wrote: > Maybe fold these to `#if`'s into `#if defined(_VC_CRT_MAJOR_VER

Re: [PATCH] D24314: [libc++] Clean up MSVC support

smeenai updated this revision to Diff 70598. smeenai added a comment. Simpliying conditional per EricWF's suggestion https://reviews.llvm.org/D24314 Files: include/support/win32/support.h Index: include/support/win32/support.h =

Re: [PATCH] D24314: [libc++] Clean up MSVC support

smeenai marked 2 inline comments as done. smeenai added a comment. https://reviews.llvm.org/D24314 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24065: [libc++] Use _LIBCPP_TYPE_VIS_ONLY with enum class

smeenai added a comment. Friendly ping :) https://reviews.llvm.org/D24065 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24374: [libc++] Avoid include in locale_win32.h

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. When `_LIBCPP_NO_EXCEPTIONS` is defined, we end up with compile errors when targeting MSVCRT: * Code includes `` * `` includes `` in order to get `abort` * `` includes `

Re: [PATCH] D24374: [libc++] Avoid include in locale_win32.h

smeenai added a comment. I'm aware that my replacement code isn't entirely equivalent, since it won't restore the locale in case `MB_CUR_MAX` throws. However, I'm quite certain the `MB_CUR_MAX` implementation won't throw. I can make my own RAII wrapper if desired, however. Alternatively, MSDN

Re: [PATCH] D24374: [libc++] Avoid include in locale_win32.h

smeenai added a comment. Cool. Any thoughts on this implementation vs. `___mb_cur_max_l_func`? In other words, do we have a general policy on using internal CRT functionality? FWIW, `support/win32/support.h` was using `xlocinfo.h` before my recent cleanup, which is also an internal header. ht

Re: [PATCH] D24374: [libc++] Avoid include in locale_win32.h

smeenai planned changes to this revision. smeenai added a comment. @bcraig thanks for pointing me to that diff; there's a lot of nice cleanup going on there. Were you planning on updating and following up on it? I also realized I forgot to adjust `locale_win32.cpp` for this diff. Will re-upload

Re: [PATCH] D24374: [libc++] Avoid include in locale_win32.h

smeenai updated this revision to Diff 70899. smeenai added a comment. Correcting support_win32.cpp https://reviews.llvm.org/D24374 Files: include/support/win32/locale_win32.h src/support/win32/locale_win32.cpp Index: src/support/win32/locale_win32.cpp ==

Re: [PATCH] D24374: [libc++] Avoid include in locale_win32.h

smeenai added a comment. In https://reviews.llvm.org/D24374#538534, @bcraig wrote: > In https://reviews.llvm.org/D24374#538521, @smeenai wrote: > > > @bcraig thanks for pointing me to that diff; there's a lot of nice cleanup > > going on there. Were you planning on updating and following up on i

[libcxx] r281250 - config: Fix typo in comment

Author: smeenai Date: Mon Sep 12 15:14:44 2016 New Revision: 281250 URL: http://llvm.org/viewvc/llvm-project?rev=281250&view=rev Log: config: Fix typo in comment Testing commit access. NFC. Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__config URL: http://llvm.org

[libcxx] r281264 - config: Use _LIBCPP_TYPE_VIS_ONLY with enum class

Author: smeenai Date: Mon Sep 12 16:41:12 2016 New Revision: 281264 URL: http://llvm.org/viewvc/llvm-project?rev=281264&view=rev Log: config: Use _LIBCPP_TYPE_VIS_ONLY with enum class An enum class has associated type info. In the Microsoft ABI, type info is emitted in the COMDAT section and isn'

Re: [PATCH] D24065: [libc++] Use _LIBCPP_TYPE_VIS_ONLY with enum class

This revision was automatically updated to reflect the committed changes. Closed by commit rL281264: config: Use _LIBCPP_TYPE_VIS_ONLY with enum class (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D24065?vs=70087&id=71059#toc Repository: rL LLVM https://reviews.ll

[libcxx] r281641 - [libc++] Avoid include in locale_win32.h

Author: smeenai Date: Thu Sep 15 13:36:13 2016 New Revision: 281641 URL: http://llvm.org/viewvc/llvm-project?rev=281641&view=rev Log: [libc++] Avoid include in locale_win32.h When `_LIBCPP_NO_EXCEPTIONS` is defined, we end up with compile errors when targeting MSVCRT: * Code includes `` * `` in

Re: [PATCH] D24374: [libc++] Avoid include in locale_win32.h

This revision was automatically updated to reflect the committed changes. Closed by commit rL281641: [libc++] Avoid include in locale_win32.h (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D24374?vs=70899&id=71530#toc Repository: rL LLVM https://reviews.llvm.org/D

Re: [PATCH] D24602: [libc++] Fix and document visibility attributes for Clang, GCC and Windows.

smeenai added a subscriber: smeenai. Comment at: docs/DesignDocs/VisibilityMacros.rst:33 @@ +32,3 @@ + Mark a type's typeinfo and vtable as having default visibility. + `_LIBCPP_TYPE_VIS`. This macro has no effect on the visibility of the + type's member functions. This attribu

[PATCH] D24678: [libc++] Fix inline attribute for non-MSVC Windows

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. gcc and clang in gcc compatibility mode do not accept __forceinline. Use the gcc attribute for them instead. https://reviews.llvm.org/D24678 Files: include/__config

[PATCH] D24679: [libc++] Fix extern template visibility for Windows

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. On Windows, marking an `extern template class` declaration as exported actually forces an instantiation, which is not the desired behavior. Instead, the actual explicit i

[libcxx] r281766 - [libc++] Fix inline attribute for non-MSVC Windows

Author: smeenai Date: Fri Sep 16 14:12:54 2016 New Revision: 281766 URL: http://llvm.org/viewvc/llvm-project?rev=281766&view=rev Log: [libc++] Fix inline attribute for non-MSVC Windows gcc and clang in gcc compatibility mode do not accept __forceinline. Use the gcc attribute for them instead. Di

Re: [PATCH] D24678: [libc++] Fix inline attribute for non-MSVC Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rL281766: [libc++] Fix inline attribute for non-MSVC Windows (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D24678?vs=71680&id=71687#toc Repository: rL LLVM https://reviews.l

[libcxx] r298762 - [libc++] Update package version

Author: smeenai Date: Fri Mar 24 22:12:37 2017 New Revision: 298762 URL: http://llvm.org/viewvc/llvm-project?rev=298762&view=rev Log: [libc++] Update package version Make it consistent with the rest of LLVM. Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeLists.txt URL: h

[libcxx] r298763 - [libc++] Fix capitalization in comment

Author: smeenai Date: Fri Mar 24 22:22:35 2017 New Revision: 298763 URL: http://llvm.org/viewvc/llvm-project?rev=298763&view=rev Log: [libc++] Fix capitalization in comment Fix a stray capital letter in the middle of a sentence. No functional change. Modified: libcxx/trunk/CMakeLists.txt Mo

[libcxx] r298764 - [libc++] Fix word transposition in comment

Author: smeenai Date: Fri Mar 24 22:29:51 2017 New Revision: 298764 URL: http://llvm.org/viewvc/llvm-project?rev=298764&view=rev Log: [libc++] Fix word transposition in comment "to due" -> "due to". No functional change. Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/trunk/CMakeList

[libcxx] r298766 - [libc++] Fix some comment typos

Author: smeenai Date: Fri Mar 24 22:42:20 2017 New Revision: 298766 URL: http://llvm.org/viewvc/llvm-project?rev=298766&view=rev Log: [libc++] Fix some comment typos Remove a stray letter, add a missing letter. No functional change. Modified: libcxx/trunk/CMakeLists.txt Modified: libcxx/tru

[libcxx] r298937 - [libc++] Add a key function for bad_function_call

Author: smeenai Date: Tue Mar 28 14:33:31 2017 New Revision: 298937 URL: http://llvm.org/viewvc/llvm-project?rev=298937&view=rev Log: [libc++] Add a key function for bad_function_call Summary: bad_function_call is currently an empty class, so any object files using that class will end up with the

[libcxxabi] r299087 - [libc++abi] Remove unistd.h include

Author: smeenai Date: Thu Mar 30 11:27:09 2017 New Revision: 299087 URL: http://llvm.org/viewvc/llvm-project?rev=299087&view=rev Log: [libc++abi] Remove unistd.h include This was originally there for the _POSIX_THREADS define, to detect the presence of pthreads. That went away with the externaliz

[libcxxabi] r299129 - [libc++abi] Delete config.h

Author: smeenai Date: Thu Mar 30 18:31:33 2017 New Revision: 299129 URL: http://llvm.org/viewvc/llvm-project?rev=299129&view=rev Log: [libc++abi] Delete config.h Summary: It's now completely empty, so we can remove it entirely. Reviewers: mclow.lists, EricWF Subscribers: cfe-commits Differenti

[libcxxabi] r299143 - [libc++abi] Remove missed use of config.h

Author: smeenai Date: Thu Mar 30 19:29:25 2017 New Revision: 299143 URL: http://llvm.org/viewvc/llvm-project?rev=299143&view=rev Log: [libc++abi] Remove missed use of config.h Modified: libcxxabi/trunk/src/cxa_noexception.cpp Modified: libcxxabi/trunk/src/cxa_noexception.cpp URL: http://llv

[libcxx] r299348 - [libc++] Explicitly mark specializations as dllexport

Author: smeenai Date: Sun Apr 2 23:04:24 2017 New Revision: 299348 URL: http://llvm.org/viewvc/llvm-project?rev=299348&view=rev Log: [libc++] Explicitly mark specializations as dllexport Method specializations don't get exported even if there's an exported extern template instantiation on Window

[libcxx] r299625 - [libc++] Respect Windows Store app CRT restrictions

Author: smeenai Date: Wed Apr 5 23:47:49 2017 New Revision: 299625 URL: http://llvm.org/viewvc/llvm-project?rev=299625&view=rev Log: [libc++] Respect Windows Store app CRT restrictions Some CRT APIs are unavailable for Windows Store apps [1]. Detect when we're targeting the Windows Store and don

[libcxx] r299743 - [libc++] Drop support for CRTs older than VS 2015

Author: smeenai Date: Thu Apr 6 21:20:52 2017 New Revision: 299743 URL: http://llvm.org/viewvc/llvm-project?rev=299743&view=rev Log: [libc++] Drop support for CRTs older than VS 2015 LLVM dropped support for Visual Studio versions older than 2015 quite some time ago, so I consider it safe to dro

[libcxx] r300097 - [libc++] Use more appropriate conditional for ABI macro definition

Author: smeenai Date: Wed Apr 12 14:56:37 2017 New Revision: 300097 URL: http://llvm.org/viewvc/llvm-project?rev=300097&view=rev Log: [libc++] Use more appropriate conditional for ABI macro definition The inline function definition ABI macro is gated on COFF dllexport semantics, so it's more appr

[libcxx] r300206 - [libc++] Explicitly set output directory for DLL

Author: smeenai Date: Thu Apr 13 11:27:38 2017 New Revision: 300206 URL: http://llvm.org/viewvc/llvm-project?rev=300206&view=rev Log: [libc++] Explicitly set output directory for DLL DLLs on Windows are treated as runtime targets. Explicitly set the output directory for them, to be consistent wit

[libcxx] r300246 - [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option

Author: smeenai Date: Thu Apr 13 15:13:32 2017 New Revision: 300246 URL: http://llvm.org/viewvc/llvm-project?rev=300246&view=rev Log: [libc++] Add _LIBCPP_DISABLE_EXTERN_TEMPLATE config option When the libc++ extern template macros were added, the intent was for it to be possible for consumers of

r291877 - [Sema] Restrict explicit instantation definition dllexport

Author: smeenai Date: Thu Jan 12 19:28:34 2017 New Revision: 291877 URL: http://llvm.org/viewvc/llvm-project?rev=291877&view=rev Log: [Sema] Restrict explicit instantation definition dllexport In the case where the template class itself is already `dllexport`, the implicit instantiation will have

Re: r291877 - [Sema] Restrict explicit instantation definition dllexport

Requesting a merge to the 4.0 branch. This is a pretty small change, and it fixes an assertion failure on Windows (see PR31608 for details). On 1/12/17, 5:28 PM, "cfe-commits on behalf of Shoaib Meenai via cfe-commits" wrote: Author: smeenai Date: Thu Jan 12 19:28:34 20

Re: [libcxx] r291072 - Get test-suite configuring on Windows with clang-cl

Ah. lld-link actually only accepts link-style options, so it wouldn't solve that particular problem. Happily, it seems like we aren't relying on ld-style options to begin with. From: Eric Fiselier Date: Friday, January 13, 2017 at 5:52 PM To: Shoaib Meenai Cc: "cfe-commits@lists.llvm.org" Subje

[libcxx] r306632 - [libc++] Hoist explicit instantiation above implicit. NFC

Author: smeenai Date: Wed Jun 28 19:52:46 2017 New Revision: 306632 URL: http://llvm.org/viewvc/llvm-project?rev=306632&view=rev Log: [libc++] Hoist explicit instantiation above implicit. NFC The string literal operators have implicit instantiations of basic_string and basic_string, which prevent

r306770 - [CodeGen] Propagate dllexport to thunks

Author: smeenai Date: Thu Jun 29 17:07:54 2017 New Revision: 306770 URL: http://llvm.org/viewvc/llvm-project?rev=306770&view=rev Log: [CodeGen] Propagate dllexport to thunks Under Windows Itanium, we need to export virtual and non-virtual thunks if the functions being thunked are exported. These

r307052 - [CodeGen] Check key function for typeinfo import

Author: smeenai Date: Mon Jul 3 18:02:19 2017 New Revision: 307052 URL: http://llvm.org/viewvc/llvm-project?rev=307052&view=rev Log: [CodeGen] Check key function for typeinfo import If the imported class does not have a key function, we should emit its typeinfo locally instead of attempting to i

Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

The thunks are (as far as I know, at least) only referenced from vtables, so there's no opportunity to perform indirect calls via the IAT for them. The vtable would just end up referencing the linker-generated import thunk instead. I can play around with marking the thunks as dllimport if the func

Re: [PATCH] D34972: [CodeGen] Propagate dllexport to thunks

I had initially also thought that thunks wouldn't need to be exported, since you should always have one of two scenarios: 1. The class doesn't have a key function, in which case both its vtable and its thunks will just be emitted wherever they're needed. 2. The class has a key function, in whic

Re: [libcxx] r307751 - Fix unrepresentable enum for clang-cl unstable ABI

That was what the diff was doing originally (see https://reviews.llvm.org/D35174?id=105752), but Eric suggested switching to static consts (presumably to work regardless of enum class availability). From: cfe-commits on behalf of David Majnemer via cfe-commits Reply-To: David Majnemer Date:

[libcxx] r307954 - [libc++] Use proper template terminology. NFC

Author: smeenai Date: Thu Jul 13 13:47:24 2017 New Revision: 307954 URL: http://llvm.org/viewvc/llvm-project?rev=307954&view=rev Log: [libc++] Use proper template terminology. NFC It's supposed to be "class template" and "function template" instead of "template class" and "template function". Mo

[libcxx] r307965 - [libc++] Remove unused _LIBCPP_FUNC_VIS_ONLY

Author: smeenai Date: Thu Jul 13 14:28:17 2017 New Revision: 307965 URL: http://llvm.org/viewvc/llvm-project?rev=307965&view=rev Log: [libc++] Remove unused _LIBCPP_FUNC_VIS_ONLY This has been unused since r282644. Modified: libcxx/trunk/include/__config Modified: libcxx/trunk/include/__con

[libcxx] r307966 - [libc++] Mark string operator+ _LIBCPP_FUNC_VIS

Author: smeenai Date: Thu Jul 13 14:35:52 2017 New Revision: 307966 URL: http://llvm.org/viewvc/llvm-project?rev=307966&view=rev Log: [libc++] Mark string operator+ _LIBCPP_FUNC_VIS It has an extern template instantiation declaration in the headers and a corresponding instantiation definition in

[libcxx] r307972 - [libc++] class template -> template class. NFC

Author: smeenai Date: Thu Jul 13 15:08:59 2017 New Revision: 307972 URL: http://llvm.org/viewvc/llvm-project?rev=307972&view=rev Log: [libc++] class template -> template class. NFC Modified: libcxx/trunk/docs/DesignDocs/VisibilityMacros.rst Modified: libcxx/trunk/docs/DesignDocs/VisibilityMa

[libcxx] r307997 - [libc++] Clean up cl warning 4231 disabling

Author: smeenai Date: Thu Jul 13 20:56:54 2017 New Revision: 307997 URL: http://llvm.org/viewvc/llvm-project?rev=307997&view=rev Log: [libc++] Clean up cl warning 4231 disabling Once upon a time, extern templates used to be a Microsoft extension, so cl would warn about their usage, and libc++ sup

r308899 - [CodeGen] Propagate dllexport to thunks

Author: smeenai Date: Mon Jul 24 10:16:27 2017 New Revision: 308899 URL: http://llvm.org/viewvc/llvm-project?rev=308899&view=rev Log: [CodeGen] Propagate dllexport to thunks Under Windows Itanium, we need to export virtual and non-virtual thunks if the functions being thunked are exported. These

Re: [libcxx] r323453 - [cmake] [libcxx] Call llvm_setup_rpath() when adding shared libraries.

This is going to break building libc++ standalone (i.e. without any LLVM repository or even its CMake modules), right? Some upstream users care a lot about that use case (CC beanz and Duncan). From: cfe-commits on behalf of Don Hinton via cfe-commits Reply-To: Don Hinton Date: Thursday, Janu

Re: [libcxxabi] r323455 - [cmake] [libcxxabi] Call llvm_setup_rpath() when adding shared libraries.

Same concerns about building standalone as r323453. From: cfe-commits on behalf of Don Hinton via cfe-commits Reply-To: Don Hinton Date: Thursday, January 25, 2018 at 10:45 AM To: "cfe-commits@lists.llvm.org" Subject: [libcxxabi] r323455 - [cmake] [libcxxabi] Call llvm_setup_rpath() when add

Re: r323935 - PR36181: Teach CodeGen to properly ignore requests to emit dependent entities.

Is this viable for backporting to 6.0? It fixes a bug that's been hit in various forms by quite a few people: https://bugs.llvm.org/show_bug.cgi?id=36181, https://bugs.llvm.org/show_bug.cgi?id=35473, and https://bugs.llvm.org/show_bug.cgi?id=35939. From: cfe-commits on behalf of Richard Smit

[libcxxabi] r296576 - [libc++abi] Clean up visibility

Author: smeenai Date: Tue Feb 28 21:55:57 2017 New Revision: 296576 URL: http://llvm.org/viewvc/llvm-project?rev=296576&view=rev Log: [libc++abi] Clean up visibility Use the libc++abi visibility macros instead of pragmas or using visibility attributes directly. Clean up redundant attributes on de

[libcxx] r296729 - [libc++] Mark some std::num_get method templates inline

Author: smeenai Date: Wed Mar 1 20:51:27 2017 New Revision: 296729 URL: http://llvm.org/viewvc/llvm-project?rev=296729&view=rev Log: [libc++] Mark some std::num_get method templates inline D29157 will make explicit template instantiations expand to default visibility, at which point these method

[libcxx] r296731 - [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

Author: smeenai Date: Wed Mar 1 21:02:50 2017 New Revision: 296731 URL: http://llvm.org/viewvc/llvm-project?rev=296731&view=rev Log: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members When building libc++ with hidden visibility, we want explicit template instantiations to export membe

[libcxx] r296732 - [libc++] Make _LIBCPP_TYPE_VIS export members

Author: smeenai Date: Wed Mar 1 21:22:18 2017 New Revision: 296732 URL: http://llvm.org/viewvc/llvm-project?rev=296732&view=rev Log: [libc++] Make _LIBCPP_TYPE_VIS export members Summary: Most classes annotated with _LIBCPP_TYPE_VIS need to have at least some of their members exported, otherwise

[libcxx] r297330 - [libc++] Avoid double defining macro on Windows

Author: smeenai Date: Wed Mar 8 18:18:00 2017 New Revision: 297330 URL: http://llvm.org/viewvc/llvm-project?rev=297330&view=rev Log: [libc++] Avoid double defining macro on Windows Put proper guards around _LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS. No functional change on non-Windows. A

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

smeenai created this revision. smeenai added reviewers: compnerd, hans. smeenai added a subscriber: cfe-commits. On MSVC, if an implicit instantiation already exists and an explicit instantiation definition with a DLL attribute is created, the DLL attribute still takes effect. Make clang match thi

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

smeenai added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7669 +// Fix a TSK_ExplicitInstantiationDeclaration or a TSK_ImplicitInstantiation +// followed by a TSK_ExplicitInstantiationDefinition +if ((Old_TSK == TSK_ExplicitInstantiationDeclaration ||

<    1   2   3   4   >