[libcxx] r282644 - [libc++] Clarify _LIBCPP_NEW_DELETE_VIS for Windows

Author: smeenai Date: Wed Sep 28 17:28:51 2016 New Revision: 282644 URL: http://llvm.org/viewvc/llvm-project?rev=282644&view=rev Log: [libc++] Clarify _LIBCPP_NEW_DELETE_VIS for Windows Replace a stale reference to cxx_EXPORTS with _LIBCPP_BUILDING_LIBRARY, and clarify why the operator new and de

[PATCH] D25053: [libc++] Correct alignment condition

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. The max alignment is a PE/COFF restriction, not an MSVC-specific restriction; it also applies to gcc and clang when compiling for Windows. Change the conditional to _WIN3

Re: [PATCH] D25053: [libc++] Correct alignment condition

smeenai added a comment. It's not – I just wasn't aware of the existence of the other one :) That one's been stagnant for a long time though. One of these changes should be abandoned in favor of the other, and I'm fine doing it either way. https://reviews.llvm.org/D25053 ___

[PATCH] D25059: [libc++] Add missing locale aliases

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. Add underscore aliases for strtof_l and strtod_l. _strtold_l exists in VS 2013 and above, so fix that definition as a drive-by fix. https://reviews.llvm.org/D25059 File

Re: [PATCH] D25059: [libc++] Add missing locale aliases

This revision was automatically updated to reflect the committed changes. Closed by commit rL282681: [libc++] Add missing locale aliases (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D25059?vs=72942&id=72948#toc Repository: rL LLVM https://reviews.llvm.org/D25059

[libcxx] r282681 - [libc++] Add missing locale aliases

Author: smeenai Date: Wed Sep 28 22:35:41 2016 New Revision: 282681 URL: http://llvm.org/viewvc/llvm-project?rev=282681&view=rev Log: [libc++] Add missing locale aliases Add underscore aliases for strtof_l and strtod_l. _strtold_l exists in VS 2013 and above, so fix that definition as a drive-by

[PATCH] D25053: [libc++] Correct alignment condition

smeenai added a comment. @mclow.lists Do you have any preference between this and https://reviews.llvm.org/D14259? I'm fine either way, but I'd want one of them to be committed sooner rather than later. https://reviews.llvm.org/D25053 ___ cfe-comm

[PATCH] D25145: [libc++] Correct explanation of _LIBCPP_NEW_DELETE_VIS

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. The behavior of this macro actually needs to apply universally on Windows and not just when using the Microsoft CRT. Update the macro definition and documentation accordi

[PATCH] D25145: [libc++] Correct explanation of _LIBCPP_NEW_DELETE_VIS

smeenai added a comment. My initial understanding of the problem was incorrect; I did some further experimentation and I think I properly understand what's going on here now. Sorry for the churn. https://reviews.llvm.org/D25145 ___ cfe-commits mai

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

smeenai created this revision. smeenai added reviewers: compnerd, EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. Most classes annotated with _LIBCPP_TYPE_VIS need to have at least some of their members exported, otherwise we have a lot of link errors when linking against a libc++ bu

[PATCH] D25145: [libc++] Correct explanation of _LIBCPP_NEW_DELETE_VIS

smeenai added a comment. In https://reviews.llvm.org/D25145#565027, @mclow.lists wrote: > Sigh. Make an expedient choice that you don't really agree with, and you get > immediately reminded of it. I suggested on an earlier review (not this > patch) that I really didn't want to see `_WIN32` in

[libcxx] r284016 - [libc++] Correct explanation of _LIBCPP_NEW_DELETE_VIS

Author: smeenai Date: Wed Oct 12 08:48:14 2016 New Revision: 284016 URL: http://llvm.org/viewvc/llvm-project?rev=284016&view=rev Log: [libc++] Correct explanation of _LIBCPP_NEW_DELETE_VIS The behavior of this macro actually needs to apply universally on Windows and not just when using the Micros

[PATCH] D25145: [libc++] Correct explanation of _LIBCPP_NEW_DELETE_VIS

smeenai closed this revision. smeenai added a comment. Not sure why Phabricator isn't closing this out, but this was committed as SVN r284016 https://reviews.llvm.org/D25145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

smeenai added a comment. In https://reviews.llvm.org/D25208#564930, @EricWF wrote: > Why do you want to build `libc++.so` with hidden visibility? What's wrong > with the existing way we build `libc++.so`? There's nothing wrong with the existing way, per se. I personally prefer hidden visibil

r319489 - [clang] Use add_llvm_install_targets

Author: smeenai Date: Thu Nov 30 14:35:02 2017 New Revision: 319489 URL: http://llvm.org/viewvc/llvm-project?rev=319489&view=rev Log: [clang] Use add_llvm_install_targets Use this function to create the install targets rather than doing so manually, which gains us the `-stripped` install targets

[libunwind] r319498 - [libunwind] Switch to add_llvm_install_targets

Author: smeenai Date: Thu Nov 30 15:24:08 2017 New Revision: 319498 URL: http://llvm.org/viewvc/llvm-project?rev=319498&view=rev Log: [libunwind] Switch to add_llvm_install_targets This gains us the install-unwind-stripped target, to perform stripping during installation. Differential Revision:

[libcxxabi] r319499 - [libc++abi] Add install-cxxabi-stripped target

Author: smeenai Date: Thu Nov 30 15:25:51 2017 New Revision: 319499 URL: http://llvm.org/viewvc/llvm-project?rev=319499&view=rev Log: [libc++abi] Add install-cxxabi-stripped target LLVM is gaining install-*-stripped targets to perform stripped installs, and in order for this to be useful for inst

[libcxx] r319802 - [libcxx] Fix intrinsics for MSVC

Author: smeenai Date: Tue Dec 5 09:46:23 2017 New Revision: 319802 URL: http://llvm.org/viewvc/llvm-project?rev=319802&view=rev Log: [libcxx] Fix intrinsics for MSVC The parameter was previously renamed but MSVC path was not updated. Patch by Andrey Khalyavin. Differential Revision: https://re

[clang-tools-extra] r319840 - [CMake] Use PRIVATE in target_link_libraries for executables

Author: smeenai Date: Tue Dec 5 13:49:56 2017 New Revision: 319840 URL: http://llvm.org/viewvc/llvm-project?rev=319840&view=rev Log: [CMake] Use PRIVATE in target_link_libraries for executables We currently use target_link_libraries without an explicit scope specifier (INTERFACE, PRIVATE or PUBL

r319840 - [CMake] Use PRIVATE in target_link_libraries for executables

Author: smeenai Date: Tue Dec 5 13:49:56 2017 New Revision: 319840 URL: http://llvm.org/viewvc/llvm-project?rev=319840&view=rev Log: [CMake] Use PRIVATE in target_link_libraries for executables We currently use target_link_libraries without an explicit scope specifier (INTERFACE, PRIVATE or PUBL

r319950 - [clang] Use PRIVATE in target_link_libraries

Author: smeenai Date: Wed Dec 6 12:05:42 2017 New Revision: 319950 URL: http://llvm.org/viewvc/llvm-project?rev=319950&view=rev Log: [clang] Use PRIVATE in target_link_libraries I'd missed this one in r319840 because I hadn't been configuring with an order file before. Modified: cfe/trunk/t

[libcxx] r319959 - [libc++] Create install-stripped targets

Author: smeenai Date: Wed Dec 6 13:03:42 2017 New Revision: 319959 URL: http://llvm.org/viewvc/llvm-project?rev=319959&view=rev Log: [libc++] Create install-stripped targets LLVM is gaining install-*-stripped targets to perform stripped installs, and in order for this to be useful for install-di

r319983 - [clang] Add PRIVATE to target_link_libraries

Author: smeenai Date: Wed Dec 6 15:02:00 2017 New Revision: 319983 URL: http://llvm.org/viewvc/llvm-project?rev=319983&view=rev Log: [clang] Add PRIVATE to target_link_libraries Another follow-up to r319840. I'd done a test configure with LLVM_BUILD_STATIC, so I'm not sure why this didn't show u

[libunwind] r320163 - [libunwind] Create install-unwind-stripped target manually

Author: smeenai Date: Fri Dec 8 09:15:05 2017 New Revision: 320163 URL: http://llvm.org/viewvc/llvm-project?rev=320163&view=rev Log: [libunwind] Create install-unwind-stripped target manually This supports using a newer libunwind with an older installation of LLVM (whose cmake modules wouldn't h

[libcxx] r320201 - [libc++] Unbreak Apple buildbots

Author: smeenai Date: Fri Dec 8 13:50:32 2017 New Revision: 320201 URL: http://llvm.org/viewvc/llvm-project?rev=320201&view=rev Log: [libc++] Unbreak Apple buildbots These buildbots are using the deprecated target name install-libcxx-headers instead of the more up to date install-cxx-headers, so

[clang] 55ac332 - Revert "Revert "[Clang] Generate test checks (NFC)""

Author: Shoaib Meenai Date: 2023-11-10T17:24:39-08:00 New Revision: 55ac33235db3635a797f98f4539d665bfacf92df URL: https://github.com/llvm/llvm-project/commit/55ac33235db3635a797f98f4539d665bfacf92df DIFF: https://github.com/llvm/llvm-project/commit/55ac33235db3635a797f98f4539d665bfacf92df.diff

[clang] c5dd1bb - Revert "Revert "[IR] Mark lshr and ashr constant expressions as undesirable""

Author: Shoaib Meenai Date: 2023-11-10T17:26:14-08:00 New Revision: c5dd1bbcc37e8811e7c6050159014d084eac6438 URL: https://github.com/llvm/llvm-project/commit/c5dd1bbcc37e8811e7c6050159014d084eac6438 DIFF: https://github.com/llvm/llvm-project/commit/c5dd1bbcc37e8811e7c6050159014d084eac6438.diff

[clang] bdd396f - [Analysis] Make test require asserts

Author: Shoaib Meenai Date: 2023-11-10T17:29:32-08:00 New Revision: bdd396f353582b50d0a9af5e5e809aeacc2848bf URL: https://github.com/llvm/llvm-project/commit/bdd396f353582b50d0a9af5e5e809aeacc2848bf DIFF: https://github.com/llvm/llvm-project/commit/bdd396f353582b50d0a9af5e5e809aeacc2848bf.diff

[clang] 8ee07a4 - Revert "[IR] Mark lshr and ashr constant expressions as undesirable"

Author: Shoaib Meenai Date: 2023-11-10T17:08:35-08:00 New Revision: 8ee07a4be7f7d8654ecf25e7ce0a680975649544 URL: https://github.com/llvm/llvm-project/commit/8ee07a4be7f7d8654ecf25e7ce0a680975649544 DIFF: https://github.com/llvm/llvm-project/commit/8ee07a4be7f7d8654ecf25e7ce0a680975649544.diff

[clang] 3bb7ecc - Revert "[Clang] Generate test checks (NFC)"

Author: Shoaib Meenai Date: 2023-11-10T17:08:35-08:00 New Revision: 3bb7ecc5a515d2ddd2708257096e14e3fe3b839d URL: https://github.com/llvm/llvm-project/commit/3bb7ecc5a515d2ddd2708257096e14e3fe3b839d DIFF: https://github.com/llvm/llvm-project/commit/3bb7ecc5a515d2ddd2708257096e14e3fe3b839d.diff

Re: [clang] cd7ba9f - [Clang] Generate test checks (NFC)

This is breaking tests when building without assertions enabled, e.g. https://lab.llvm.org/buildbot/#/builders/67/builds/13266/steps/7/logs/stdio, I think because the initial entry: label isn’t generated in such builds. Could you please take a look? From: cfe-commits on behalf of Nikita Popov

[clang] [clang] Only build static analyzer sources if requested (PR #71653)

@@ -23,7 +23,9 @@ add_subdirectory(Tooling) add_subdirectory(DirectoryWatcher) add_subdirectory(Index) add_subdirectory(IndexSerialization) -add_subdirectory(StaticAnalyzer) +if(CLANG_ENABLE_STATIC_ANALYZER) smeenai wrote: I agree with Chris in general. This c

[clang] 863b938 - [clang] Remove stale release note

Author: Shoaib Meenai Date: 2023-12-11T15:37:49-08:00 New Revision: 863b9388687d01c67de1248e48cee0df698515c0 URL: https://github.com/llvm/llvm-project/commit/863b9388687d01c67de1248e48cee0df698515c0 DIFF: https://github.com/llvm/llvm-project/commit/863b9388687d01c67de1248e48cee0df698515c0.diff

[libcxx] [clang] [llvm] [compiler-rt] [libc] [compiler-rt]Add lld into dependency for apple builds now that lld Mach-O backend is available (PR #75884)

https://github.com/smeenai approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/75884 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Always use CLANG_VENDOR as a quoted string (PR #75935)

https://github.com/smeenai requested changes to this pull request. IIRC, applying definitions like this only to a small set of files was an intentional decision, to minimize rebuilding when their values changed. It matters much more for the commit hash than the vendor, but passing defines like

[clang] [clang] Add getClangVendor() and use it in CodeGenModule.cpp (PR #75935)

https://github.com/smeenai approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/75935 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 42b3a5f - [clang] Add missing header include

Author: Shoaib Meenai Date: 2022-07-14T00:21:09-07:00 New Revision: 42b3a5fb463fd616d981888abaf0f48ab0065a8d URL: https://github.com/llvm/llvm-project/commit/42b3a5fb463fd616d981888abaf0f48ab0065a8d DIFF: https://github.com/llvm/llvm-project/commit/42b3a5fb463fd616d981888abaf0f48ab0065a8d.diff

[llvm] [lld] [libcxxabi] [clang] [libcxx] [mlir] [openmp] [compiler-rt] [runtimes] Use LLVM libunwind from libc++abi by default (PR #77687)

@@ -22,6 +22,9 @@ set(LIBCXX_ENABLE_ABI_LINKER_SCRIPT OFF CACHE BOOL "") set(LIBCXX_STATICALLY_LINK_ABI_IN_SHARED_LIBRARY ON CACHE BOOL "") set(LIBCXXABI_ENABLE_SHARED OFF CACHE BOOL "") +# Android uses its own unwinder library +set(LIBCXXABI_USE_LLVM_UNWINDER OFF CACHE BOOL "

[lldb] [clang] [libc] [flang] [lld] [clang-tools-extra] [llvm] [libcxx] [compiler-rt] [lld-macho] Find objects in library search path (PR #78628)

@@ -0,0 +1,14 @@ +# REQUIRES: x86 +# RUN: mkdir -p %t +# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %p/Inputs/libhello.s -o %t/hello.o +# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %s -o %t/main.o +# RUN: %lld -L %t %t/main.o %t/hello.o -o %t/a.out ---

[libcxx] r309474 - [libc++] Hoist extern template above first use

Author: smeenai Date: Fri Jul 28 19:54:41 2017 New Revision: 309474 URL: http://llvm.org/viewvc/llvm-project?rev=309474&view=rev Log: [libc++] Hoist extern template above first use This function template is referenced inside class basic_string as a friend function. The extern template declaration

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

Marshall, Eric, Hans, Any objections to backporting this to 5.0? It fixes a potential visibility issue for clients of the header. On 7/28/17, 7:54 PM, "cfe-commits on behalf of Shoaib Meenai via cfe-commits" wrote: Author: smeenai Date: Fri Jul 28 19:54:41 2017 Ne

Re: [libcxx] r307357 - cmath: Support clang's -fdelayed-template-parsing

This particular issue isn't clang-specific; it affects MSVC as well, and I believe clang's -fdelayed-template-parsing attempts to model MSVC's behavior. See https://godbolt.org/g/xrbpgX (code in https://reviews.llvm.org/P8012). On 7/6/17, 10:13 PM, "cfe-commits on behalf of Duncan P. N. Exon Smith

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

Ping. On 7/28/17, 7:57 PM, "Shoaib Meenai" wrote: Marshall, Eric, Hans, Any objections to backporting this to 5.0? It fixes a potential visibility issue for clients of the header. On 7/28/17, 7:54 PM, "cfe-commits on behalf of Shoaib Meenai via cfe-

[libcxx] r310290 - [libc++] Don't hardcode namespace in manual mangling

Author: smeenai Date: Mon Aug 7 12:59:58 2017 New Revision: 310290 URL: http://llvm.org/viewvc/llvm-project?rev=310290&view=rev Log: [libc++] Don't hardcode namespace in manual mangling libc++'s inline namespace can change depending on the ABI version. Instead of hardcoding __1 in the manual Mic

[libcxxabi] r310329 - [libc++abi] Use proper calling convention for TLS destructor

Author: smeenai Date: Mon Aug 7 17:54:33 2017 New Revision: 310329 URL: http://llvm.org/viewvc/llvm-project?rev=310329&view=rev Log: [libc++abi] Use proper calling convention for TLS destructor This is needed when using Windows threading. Modified: libcxxabi/trunk/src/cxa_exception_storage.

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

, 2017 at 10:20 AM, Hans Wennborg mailto:h...@chromium.org>> wrote: > Sounds good to me, but Eric or Marshall need to sign off. > > On Thu, Aug 3, 2017 at 10:15 AM, Shoaib Meenai > mailto:smee...@fb.com>> wrote: >> Ping. >> >> On 7/28/17, 7:57 PM, &q

Re: [libcxx] r309474 - [libc++] Hoist extern template above first use

to:smee...@fb.com>> wrote: >> Ping. >> >> On 7/28/17, 7:57 PM, "Shoaib Meenai" mailto:smee...@fb.com>> >> wrote: >> >> Marshall, Eric, Hans, >> >> Any objections to backporting this to 5.0? It fixes a potential >>

Re: [libcxx] r307966 - [libc++] Mark string operator+ _LIBCPP_FUNC_VIS

ringIT_T0_T1_EEPKS6_RKS9_ 0030 (__TEXT,__text) weak external __ZNSt3__1plIcNS_11char_traitsIcEENS_9allocatorIcNS_12basic_stringIT_T0_T1_EEPKS6_RKS9_ The symbol used to be “weak private external”, but it is “weak external” now. On Jul 13, 2017, at 2:35 PM, Shoaib Meenai via cfe-co

[clang] 4e4ab8e - [clang] Limit scope of CLANG_VENDOR definition

Author: Shoaib Meenai Date: 2020-11-02T09:04:43-08:00 New Revision: 4e4ab8e0152b42baef5e5a1e2484d865e1a57e90 URL: https://github.com/llvm/llvm-project/commit/4e4ab8e0152b42baef5e5a1e2484d865e1a57e90 DIFF: https://github.com/llvm/llvm-project/commit/4e4ab8e0152b42baef5e5a1e2484d865e1a57e90.diff

[clang-tools-extra] 6bd01b8 - [clangd] Account for vendor in version string

Author: Shoaib Meenai Date: 2020-11-02T09:04:44-08:00 New Revision: 6bd01b8184de93979756331c71af69b422f71103 URL: https://github.com/llvm/llvm-project/commit/6bd01b8184de93979756331c71af69b422f71103 DIFF: https://github.com/llvm/llvm-project/commit/6bd01b8184de93979756331c71af69b422f71103.diff

[clang] 56f7e5a - [cmake] Add support for multiple distributions

Author: Shoaib Meenai Date: 2021-05-12T11:13:18-07:00 New Revision: 56f7e5a822b43578e086c40d063af2a2c0d214ee URL: https://github.com/llvm/llvm-project/commit/56f7e5a822b43578e086c40d063af2a2c0d214ee DIFF: https://github.com/llvm/llvm-project/commit/56f7e5a822b43578e086c40d063af2a2c0d214ee.diff

[libunwind] adf1561 - [libunwind] Inform ASan that resumption is noreturn

Author: Shoaib Meenai Date: 2021-05-26T09:31:39-07:00 New Revision: adf1561d6ce8af057127c65af863b3f0e1c77e60 URL: https://github.com/llvm/llvm-project/commit/adf1561d6ce8af057127c65af863b3f0e1c77e60 DIFF: https://github.com/llvm/llvm-project/commit/adf1561d6ce8af057127c65af863b3f0e1c77e60.diff

[clang-tools-extra] ba94b8b - [clangd] Attempt to fix buildbots

Author: Shoaib Meenai Date: 2021-10-25T20:16:59-07:00 New Revision: ba94b8bdffb4c65d5475746a6ba43d279683e5bd URL: https://github.com/llvm/llvm-project/commit/ba94b8bdffb4c65d5475746a6ba43d279683e5bd DIFF: https://github.com/llvm/llvm-project/commit/ba94b8bdffb4c65d5475746a6ba43d279683e5bd.diff

[clang] 9a2a167 - [DirectoryWatcher] Increase timeout to make test less flaky

Author: Shoaib Meenai Date: 2021-03-05T17:49:14-08:00 New Revision: 9a2a167b6ca7c35b60846592d7c11332c1f424e3 URL: https://github.com/llvm/llvm-project/commit/9a2a167b6ca7c35b60846592d7c11332c1f424e3 DIFF: https://github.com/llvm/llvm-project/commit/9a2a167b6ca7c35b60846592d7c11332c1f424e3.diff

[clang-tools-extra] 4baae16 - [pseudo] Fix pseudo-gen usage when cross-compiling

Author: Shoaib Meenai Date: 2022-05-25T11:08:21-07:00 New Revision: 4baae166ce33ac763bfc1813cf56b8d26e07fb1f URL: https://github.com/llvm/llvm-project/commit/4baae166ce33ac763bfc1813cf56b8d26e07fb1f DIFF: https://github.com/llvm/llvm-project/commit/4baae166ce33ac763bfc1813cf56b8d26e07fb1f.diff

[libunwind] 3d2b5b7 - [libunwind] Factor out sigreturn check condition. NFC

Author: Shoaib Meenai Date: 2022-05-26T09:12:50-07:00 New Revision: 3d2b5b7b87857b0cc4c322cfc145c46c42fe2bbf URL: https://github.com/llvm/llvm-project/commit/3d2b5b7b87857b0cc4c322cfc145c46c42fe2bbf DIFF: https://github.com/llvm/llvm-project/commit/3d2b5b7b87857b0cc4c322cfc145c46c42fe2bbf.diff

[libunwind] 0be0a53 - [libunwind] Use process_vm_readv to avoid potential segfaults

Author: Shoaib Meenai Date: 2022-05-26T09:12:51-07:00 New Revision: 0be0a53df65cb402359c257922d80ab93d86fb40 URL: https://github.com/llvm/llvm-project/commit/0be0a53df65cb402359c257922d80ab93d86fb40 DIFF: https://github.com/llvm/llvm-project/commit/0be0a53df65cb402359c257922d80ab93d86fb40.diff

[clang] b1e3cd1 - [driver] Conditionally include installed libc++ headers for Android

Author: Shoaib Meenai Date: 2023-09-18T12:18:45-07:00 New Revision: b1e3cd1d79443603dc003441e07cdd8d30bb7f26 URL: https://github.com/llvm/llvm-project/commit/b1e3cd1d79443603dc003441e07cdd8d30bb7f26 DIFF: https://github.com/llvm/llvm-project/commit/b1e3cd1d79443603dc003441e07cdd8d30bb7f26.diff

[clang] 1212d1b - [driver] Perform fallback target searches for stdlib

Author: Shoaib Meenai Date: 2023-09-18T12:18:51-07:00 New Revision: 1212d1b511251de69939c8aa380f660373e26419 URL: https://github.com/llvm/llvm-project/commit/1212d1b511251de69939c8aa380f660373e26419 DIFF: https://github.com/llvm/llvm-project/commit/1212d1b511251de69939c8aa380f660373e26419.diff

[clang] 58288c6 - [driver] Search for compatible Android runtime directories

Author: Shoaib Meenai Date: 2023-09-18T16:14:18-07:00 New Revision: 58288c6c1214f8a3a0e32e003406437652e098bd URL: https://github.com/llvm/llvm-project/commit/58288c6c1214f8a3a0e32e003406437652e098bd DIFF: https://github.com/llvm/llvm-project/commit/58288c6c1214f8a3a0e32e003406437652e098bd.diff

[clang] 915ebb0 - [driver] Address missed feedback from https://reviews.llvm.org/D158476

Author: Shoaib Meenai Date: 2023-09-18T16:28:04-07:00 New Revision: 915ebb07dfc53486eccf0dc09b6411929a463e98 URL: https://github.com/llvm/llvm-project/commit/915ebb07dfc53486eccf0dc09b6411929a463e98 DIFF: https://github.com/llvm/llvm-project/commit/915ebb07dfc53486eccf0dc09b6411929a463e98.diff

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

https://github.com/smeenai created https://github.com/llvm/llvm-project/pull/66853 `Lexer::getLocForEndOfToken` is documented as returning an invalid source location when the end of the token is inside a macro expansion. We don't want that for this particular application, so just calculate the e

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

https://github.com/smeenai edited https://github.com/llvm/llvm-project/pull/66853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

smeenai wrote: I updated the PR description with an example. https://github.com/llvm/llvm-project/pull/66853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

smeenai wrote: Sorry about the breakage. The `sys::path::append` behavior here is surprising. I think it'd be better to change the computation of `SysRoot` in the function above (line 3102, which I can't comment because of GitHub, sigh) to default to `llvm::sys::path::get_separator()` if it's

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

smeenai wrote: > Thanks for the quick response! > > > The `sys::path::append` behavior here is surprising. I think it'd be better > > to change the computation of `SysRoot` in the function above (line 3102, > > which I can't comment because of GitHub, sigh) to default to > > `llvm::sys::path:

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/66853 >From 701b1d99515e40eec8dcbaba3a0b2dc436bf9652 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Tue, 19 Sep 2023 19:46:56 -0700 Subject: [PATCH] [Sema] Fix fixit cast printing inside macros `Lexer::getLocForEn

[clang] [Sema] Fix fixit cast printing inside macros (PR #66853)

https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/66853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

@@ -316,6 +318,52 @@ TEST(ToolChainTest, VFSSolarisMultiGCCInstallation) { } } +MATCHER_P(jobHasArgs, Substr, "") { + const driver::Command &C = arg; + std::string Args = ""; + llvm::ListSeparator Sep(" "); + for (const char *Arg : C.getArguments()) { +Args += Sep; +

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

smeenai wrote: LGTM, thanks! https://github.com/llvm/llvm-project/pull/66947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

https://github.com/smeenai approved this pull request. https://github.com/llvm/llvm-project/pull/66947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

https://github.com/smeenai resolved https://github.com/llvm/llvm-project/pull/66947 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix detection of libc++ with empty sysroot. (PR #66947)

@@ -316,6 +318,52 @@ TEST(ToolChainTest, VFSSolarisMultiGCCInstallation) { } } +MATCHER_P(jobHasArgs, Substr, "") { + const driver::Command &C = arg; + std::string Args = ""; + llvm::ListSeparator Sep(" "); + for (const char *Arg : C.getArguments()) { +Args += Sep; +

[clang] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

https://github.com/smeenai created https://github.com/llvm/llvm-project/pull/67378 Right now, `-Wformat` for a scoped enum will suggest a cast based on the format specifier being used. This can lead to incorrect results, e.g. attempting to format a scoped enum with `%s` would suggest casting to

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

smeenai wrote: Ping. https://github.com/llvm/llvm-project/pull/67378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/67378 >From a1c307ddcc309b6b915feaad6d09f74ecc3f6e79 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 25 Sep 2023 13:48:10 -0700 Subject: [PATCH 1/2] [Sema] Use underlying type of scoped enum for -Wformat diagn

[clang-tools-extra] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

smeenai wrote: I updated the release notes. I was planning to ask for a pick into 17, but I'll just tweak the release notes for the pick and modify the Clang 18 release notes afterwards if it's accepted. https://github.com/llvm/llvm-project/pull/67378 __

[clang-tools-extra] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

smeenai wrote: I have commit access. Thanks for the review! https://github.com/llvm/llvm-project/pull/67378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Use underlying type of scoped enum for -Wformat diagnostics (PR #67378)

https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/67378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/smeenai created https://github.com/llvm/llvm-project/pull/68060 The C23 standard supports enums with fixed underlying types (N3030 [1]), so we shouldn't emit `-Wfixed-enum-extension` in C23 mode (since it's no longer a Clang extension at that point). [1] https://thephd.dev/_

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/2] [diag] Silence `-Wfixed-enum-extension` in C23 The C23 standa

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

@@ -5019,7 +5019,7 @@ void Parser::ParseEnumSpecifier(SourceLocation StartLoc, DeclSpec &DS, else if (getLangOpts().MicrosoftExt) Diag(ColonLoc, diag::ext_ms_c_enum_fixed_underlying_type) << BaseRange; -else +else if (!getLangOpt

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/3] [diag] Silence `-Wfixed-enum-extension` in C23 The C23 standa

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/4] [diag] Silence `-Wfixed-enum-extension` in C23 The C23 standa

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/smeenai updated https://github.com/llvm/llvm-project/pull/68060 >From b931e047168d2312f05c0fbf2813915cc4e06ae8 Mon Sep 17 00:00:00 2001 From: Shoaib Meenai Date: Mon, 2 Oct 2023 17:50:36 -0700 Subject: [PATCH 1/4] [diag] Silence `-Wfixed-enum-extension` in C23 The C23 standa

[clang] [diag] Silence `-Wfixed-enum-extension` in C23 (PR #68060)

https://github.com/smeenai closed https://github.com/llvm/llvm-project/pull/68060 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] 3da76c2 - [libunwind] Fix build with -Wunused-function

Author: Shoaib Meenai Date: 2023-07-27T20:22:16-07:00 New Revision: 3da76c2116179fdb3fff8feb4551209e4218746e URL: https://github.com/llvm/llvm-project/commit/3da76c2116179fdb3fff8feb4551209e4218746e DIFF: https://github.com/llvm/llvm-project/commit/3da76c2116179fdb3fff8feb4551209e4218746e.diff

[clang] [clang] Enable Wenum-constexpr-conversion also in system headers and … (PR #67528)

Carlos =?utf-8?q?G=C3=A1lvez?= Message-ID: In-Reply-To: smeenai wrote: https://github.com/boostorg/mpl/issues/69 is still a problem, unfortunately. https://github.com/llvm/llvm-project/pull/67528 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/smeenai review_requested https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/smeenai review_requested https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Modify BoundsSan to improve debuggability (PR #65972)

https://github.com/smeenai review_requested https://github.com/llvm/llvm-project/pull/65972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b6a1473 - [driver] Refactor getRuntimePaths. NFC

Author: Shoaib Meenai Date: 2023-08-28T17:34:50-07:00 New Revision: b6a1473f97d38471b08331dee7ae7f6112c495c0 URL: https://github.com/llvm/llvm-project/commit/b6a1473f97d38471b08331dee7ae7f6112c495c0 DIFF: https://github.com/llvm/llvm-project/commit/b6a1473f97d38471b08331dee7ae7f6112c495c0.diff

[clang] f41cd47 - [Driver] Enable stdlibxx-isystem test on Windows

Author: Shoaib Meenai Date: 2023-08-30T14:39:00-07:00 New Revision: f41cd477361b1891ca2702b66a8a66915258f15b URL: https://github.com/llvm/llvm-project/commit/f41cd477361b1891ca2702b66a8a66915258f15b DIFF: https://github.com/llvm/llvm-project/commit/f41cd477361b1891ca2702b66a8a66915258f15b.diff

[clang] df43ec3 - [Driver] Add test for -stdlib++-isystem with -nostdinc

Author: Shoaib Meenai Date: 2022-11-30T23:09:28-08:00 New Revision: df43ec30ab66f5af7bbf87e121e0fe26aad478b4 URL: https://github.com/llvm/llvm-project/commit/df43ec30ab66f5af7bbf87e121e0fe26aad478b4 DIFF: https://github.com/llvm/llvm-project/commit/df43ec30ab66f5af7bbf87e121e0fe26aad478b4.diff

[clang] a299178 - [cmake] Fix -stripped for umbrella library install targets

Author: Shoaib Meenai Date: 2020-03-20T18:46:48-07:00 New Revision: a299178ae77a9d0c7d66f50d17483b7d18898ef0 URL: https://github.com/llvm/llvm-project/commit/a299178ae77a9d0c7d66f50d17483b7d18898ef0 DIFF: https://github.com/llvm/llvm-project/commit/a299178ae77a9d0c7d66f50d17483b7d18898ef0.diff

[clang] 61c8ee6 - [clang] Move CLANG_BOOTSTRAP_CMAKE_ARGS above PASSTHROUGH_VARIABLES

Author: Xin-Xin Wang Date: 2019-12-13T19:05:04-08:00 New Revision: 61c8ee6a2fa490bc224d006cd03efd650f6561bb URL: https://github.com/llvm/llvm-project/commit/61c8ee6a2fa490bc224d006cd03efd650f6561bb DIFF: https://github.com/llvm/llvm-project/commit/61c8ee6a2fa490bc224d006cd03efd650f6561bb.diff

[clang] 2c59c4f - [perf-training] Make training data location configurable

Author: Shoaib Meenai Date: 2019-12-14T09:46:41-08:00 New Revision: 2c59c4ffb9c111f8d87a65839697d03fc485c51c URL: https://github.com/llvm/llvm-project/commit/2c59c4ffb9c111f8d87a65839697d03fc485c51c DIFF: https://github.com/llvm/llvm-project/commit/2c59c4ffb9c111f8d87a65839697d03fc485c51c.diff

Re: [clang] 0130b6c - Don't assume a reference refers to at least sizeof(T) bytes.

Should this be cherry-picked to 10.0? On 1/31/20, 7:09 PM, "cfe-commits on behalf of Richard Smith via cfe-commits" wrote: Author: Richard Smith Date: 2020-01-31T19:08:17-08:00 New Revision: 0130b6cb5a8d94511e2bb09ac2f5a613a59f70b4 URL: https://github.com/llvm/llvm-

[clang] 14f8703 - [xray][clang] Always add xray-skip-entry/exit and xray-ignore-loops attrs

Author: Ian Levesque Date: 2020-02-11T14:00:41-08:00 New Revision: 14f870366a93ba0c6311883d900e24339681ba76 URL: https://github.com/llvm/llvm-project/commit/14f870366a93ba0c6311883d900e24339681ba76 DIFF: https://github.com/llvm/llvm-project/commit/14f870366a93ba0c6311883d900e24339681ba76.diff

<    1   2   3   4   >