[PATCH] D99322: [clang] Pass option directly to command. NFC

2021-03-25 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG33930a0787f6: [clang] Pass option directly to command. NFC (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

2021-01-11 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. Sorry, I seem to have somehow blanked out on this diff entirely. Is it still relevant? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35388/new/ https://reviews.llvm.org/D35388 _

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

2021-01-12 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai updated this revision to Diff 316161. smeenai added a comment. Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Herald added a reviewer: libc++. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35388/new/ https

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

2021-01-12 Thread Shoaib Meenai via Phabricator via cfe-commits
smeenai added a comment. It's been a long time since I've contributed to libc++, and the pre-merge CI setup is a massive improvement over what we had before. A huge kudos to everyone who made it possible :) This is still showing up as Needs Review. I'm not sure if that's because of @EricWF's p

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

2021-01-12 Thread Shoaib Meenai via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG0066a09579ca: [libc++] Give extern templates default visibility on gcc (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D35388/new/ https

<    3   4   5   6   7   8