[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai updated this revision to Diff 87912. smeenai added a comment. Rebase and ping https://reviews.llvm.org/D29157 Files: include/__config include/locale include/string Index: include/string === --- include/string +++ inc

[PATCH] D32411: [libcxx] Provide #include_next alternative for MSVC

smeenai resigned from this revision. smeenai added a comment. Sorry, I've been meaning to respond for a while. This is kinda ugly, but I can't think of a better way to do it. I'm fine with this, but given that it's a pretty invasive change, I'm not comfortable accepting. You may wanna ping @Eri

[PATCH] D34850: [CodeGen] Propagate dllexport to thunks

smeenai created this revision. Under Windows Itanium, we need to export virtual and non-virtual thunks if the functions being thunked are exported. These thunks would previously inherit their dllexport attribute from the declaration, but r298330 changed declarations to not have dllexport attribute

[PATCH] D34850: [CodeGen] Propagate dllexport to thunks

This revision was automatically updated to reflect the committed changes. Closed by commit rL306770: [CodeGen] Propagate dllexport to thunks (authored by smeenai). Repository: rL LLVM https://reviews.llvm.org/D34850 Files: cfe/trunk/lib/CodeGen/CGVTables.cpp cfe/trunk/test/CodeGenCXX/wind

[PATCH] D34850: [CodeGen] Propagate dllexport to thunks

smeenai added a comment. Sorry about the breakage. I'll redo this limiting it to windows-itanium (and add a comment explaining why we want it). Repository: rL LLVM https://reviews.llvm.org/D34850 ___ cfe-commits mailing list cfe-commits@lists.ll

[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

smeenai created this revision. Under Windows Itanium, we need to export virtual and non-virtual thunks if the functions being thunked are exported. These thunks would previously inherit their dllexport attribute from the declaration, but r298330 changed declarations to not have dllexport attribute

[PATCH] D34210: Add __has_feature(leak_sanitizer)

smeenai added a comment. COFF supports weak externals: https://stackoverflow.com/a/11529277/382079. Would it suffice here? https://reviews.llvm.org/D34210 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D35388: [libc++] Give extern templates default visibility on gcc

smeenai created this revision. Contrary to the current visibility macro documentation, it appears that gcc does handle visibility attribute on extern templates correctly, e.g. https://godbolt.org/g/EejuV7. We need this so that extern template instantiations of classes not marked _LIBCPP_TEMPLATE_V

[PATCH] D35757: Work around an MSVC2017 update 3 codegen bug.

smeenai added inline comments. Comment at: lib/AST/StmtProfile.cpp:1367 +#if defined(_MSC_VER) && _MSC_VER == 1911 +// Work around https://developercommunity.visualstudio.com/content/problem/84002/clang-cl-when-built-with-vc-2017-crashes-cause-vc.html Is it wo

[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

smeenai added a comment. Ping. I updated the description based on the email discussion with @majnemer. https://reviews.llvm.org/D34972 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

smeenai updated this revision to Diff 107795. smeenai edited the summary of this revision. smeenai added a comment. Add comment https://reviews.llvm.org/D34972 Files: lib/CodeGen/ItaniumCXXABI.cpp test/CodeGenCXX/dllexport-vtable-thunks.cpp Index: test/CodeGenCXX/dllexport-vtable-thunks.c

[PATCH] D34972: [CodeGen] Propagate dllexport to thunks

This revision was automatically updated to reflect the committed changes. Closed by commit rL308899: [CodeGen] Propagate dllexport to thunks (authored by smeenai). Repository: rL LLVM https://reviews.llvm.org/D34972 Files: cfe/trunk/lib/CodeGen/ItaniumCXXABI.cpp cfe/trunk/test/CodeGenCXX/

[PATCH] D42614: AST: support ObjC lifetime qualifiers in MS ABI

smeenai added a comment. pin_ptr is technically not supposed to appear as a function parameter, and having it in that position can screw up demangling. Considering __strong is the default, it's probably not a good idea to map that one to pin_ptr; whichever qualifier is least likely to appear as

[PATCH] D42768: AST: add an extension to support SwiftCC on MS ABI

smeenai added a comment. Some cases that drop the additional namespacing entirely, which is I think what @rjmccall was pointing out: // mangles to ?f@n@@YAXXZ namespace n { void __attribute__((__swiftcall__)) f(void) {} }; // mangles to ?f@s@@QEAAXXZ struct __declspec(dllexport)

[PATCH] D28785: Split exception.cpp and new.cpp implementation into different files for different runtimes

smeenai added a comment. Still not a fan of the amount of vcruntime dependencies this is taking on, but I guess that can be followed up on. Was the `get_new_handler`/`set_new_handler` issue resolved? (The issue being that those functions are in msvcprt, which our tests were silently linking ag

[PATCH] D27387: [libc++] Add a key function for bad_function_call

smeenai updated this revision to Diff 88627. smeenai edited the summary of this revision. smeenai removed a reviewer: dexonsmith. smeenai removed a subscriber: dexonsmith. smeenai added a comment. Guarding behind ABI macro https://reviews.llvm.org/D27387 Files: include/__config include/func

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai added a comment. Will do the rebase. Comment at: include/locale:626 template +_LIBCPP_HIDDEN iter_type __do_get_floating_point EricWF wrote: > After applying the changes to `__config` but not this header > `check-cxx-abilist` didn't repo

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai updated this revision to Diff 88854. smeenai added a comment. Rebase https://reviews.llvm.org/D29157 Files: include/__config include/locale include/string Index: include/string === --- include/string +++ include/str

[PATCH] D27387: [libc++] Add a key function for bad_function_call

smeenai added a comment. Ping. https://reviews.llvm.org/D27387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai added inline comments. Comment at: include/string:1100 template +inline _LIBCPP_INLINE_VISIBILITY typename enable_if EricWF wrote: > smeenai wrote: > > EricWF wrote: > > > Why `inline _LIBCPP_INLINE_VISIBILITY` here but `_LIBCPP_HIDD

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai updated this revision to Diff 90108. smeenai edited the summary of this revision. smeenai added a comment. Addressing comments https://reviews.llvm.org/D29157 Files: docs/DesignDocs/VisibilityMacros.rst include/__config include/locale include/string Index: include/string ==

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

smeenai updated this revision to Diff 90109. smeenai added a comment. Rebase atop https://reviews.llvm.org/D29157 and switch to _LIBCPP_METHOD_TEMPLATE_IMPLICIT_INSTANTIATION_VIS https://reviews.llvm.org/D25208 Files: docs/DesignDocs/VisibilityMacros.rst include/__config include/__locale

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai updated this revision to Diff 90114. smeenai added a comment. Rebase https://reviews.llvm.org/D26949 Files: include/__cxxabi_config.h src/abort_message.cpp src/abort_message.h src/cxa_exception.cpp src/cxa_exception.hpp src/cxa_handlers.cpp src/cxa_handlers.hpp src/cxa_n

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai added inline comments. Comment at: src/abort_message.h:19 -__attribute__((visibility("hidden"), noreturn)) - void abort_message(const char* format, ...) -__attribute__((format(printf, 1, 2))); - +_LIBCXXABI_HIDDEN __attribute__((noreturn)) void +abort

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai updated this revision to Diff 90119. smeenai added a comment. Addressing inline comment https://reviews.llvm.org/D26949 Files: include/__cxxabi_config.h src/abort_message.cpp src/abort_message.h src/cxa_exception.cpp src/cxa_exception.hpp src/cxa_handlers.cpp src/cxa_handl

[PATCH] D26949: [libc++abi] Clean up visibility

This revision was automatically updated to reflect the committed changes. Closed by commit rL296576: [libc++abi] Clean up visibility (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D26949?vs=90119&id=90120#toc Repository: rL LLVM https://reviews.llvm.org/D26949 Fil

[PATCH] D27387: [libc++] Add a key function for bad_function_call

smeenai added inline comments. Comment at: include/functional:1393 +public: +virtual ~bad_function_call() _NOEXCEPT; + EricWF wrote: > What's the rationale for making the dtor out-of-line? Couldn't we just use > `what()` as the key function? We could, but th

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai updated this revision to Diff 90264. smeenai added a comment. Changing more instances to new macro, per IRC discussion with Eric https://reviews.llvm.org/D29157 Files: docs/DesignDocs/VisibilityMacros.rst include/__config include/locale include/string Index: include/string

[PATCH] D30523: [libc++] Mark some std::num_get method templates inline

smeenai created this revision. https://reviews.llvm.org/D29157 will make explicit template instantiations expand to default visibility, at which point these method templates will need to be explicitly marked hidden visibility to avoid leaking into other DSOs. Unfortunately, because of clang PR321

[PATCH] D30523: [libc++] Mark some std::num_get method templates inline

This revision was automatically updated to reflect the committed changes. Closed by commit rL296729: [libc++] Mark some std::num_get method templates inline (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D30523?vs=90270&id=90271#toc Repository: rL LLVM https://revi

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

smeenai updated this revision to Diff 90272. smeenai added a comment. Including inline in macro to work around PR32114 https://reviews.llvm.org/D29157 Files: docs/DesignDocs/VisibilityMacros.rst include/__config include/locale include/string Index: include/string ==

[PATCH] D29157: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members

This revision was automatically updated to reflect the committed changes. Closed by commit rL296731: [libc++] Make _LIBCPP_EXTERN_TEMPLATE_TYPE_VIS export members (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D29157?vs=90272&id=90274#toc Repository: rL LLVM https:

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

smeenai updated this revision to Diff 90275. smeenai added a comment. Rebase https://reviews.llvm.org/D25208 Files: docs/DesignDocs/VisibilityMacros.rst include/__config include/__locale include/__mutex_base include/condition_variable include/future include/mutex include/shared_

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

This revision was automatically updated to reflect the committed changes. Closed by commit rL296732: [libc++] Make _LIBCPP_TYPE_VIS export members (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D25208?vs=90275&id=90276#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D27387: [libc++] Add a key function for bad_function_call

smeenai updated this revision to Diff 90524. smeenai added a comment. Address comments https://reviews.llvm.org/D27387 Files: include/__config include/functional lib/CMakeLists.txt src/functional.cpp Index: src/functional.cpp ===

[PATCH] D27387: [libc++] Add a key function for bad_function_call

smeenai added a comment. Ping. https://reviews.llvm.org/D27387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26934: [libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS

smeenai updated this revision to Diff 79358. smeenai added a comment. Herald added a subscriber: mgorny. Addressing comments https://reviews.llvm.org/D26934 Files: CMakeLists.txt docs/UsingLibcxx.rst include/__config include/__config_site.in Index: include/__config_site.in

[PATCH] D26934: [libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS

smeenai added inline comments. Comment at: include/__config:513-516 #if defined(_LIBCPP_DISABLE_DLL_IMPORT_EXPORT) +// this can be removed once any existing users have switched to the new macro +# error "Use _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS instead of _LIBCPP_DISABLE_DLL_

[PATCH] D26934: [libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS

smeenai updated this revision to Diff 79359. smeenai added a comment. Not changing non-Windows behavior, to make sure I'm not breaking anyone https://reviews.llvm.org/D26934 Files: CMakeLists.txt docs/UsingLibcxx.rst include/__config include/__config_site.in Index: include/__config_sit

[PATCH] D27153: [libc++] Make __num_get_float hidden

smeenai created this revision. smeenai added reviewers: EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. It's an internal function and shouldn't be exported. It's also a source of discrepancy in the published ABI list; these symbols aren't exported for me on CentOS 7 or Ubuntu 16.04,

[PATCH] D27153: [libc++] Make __num_get_float hidden

smeenai added a comment. I'm having some second thoughts about this. Visibility for template functions makes my head spin :/ Is there a general policy we've been following for these? I didn't find much just scanning through other definitions. https://reviews.llvm.org/D27153

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

smeenai added a comment. Ping. https://reviews.llvm.org/D26657 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai added a comment. Ping. Lmk if there's any other tests I should run on this to ensure there's no functional difference. https://reviews.llvm.org/D26949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/ma

[PATCH] D26950: [libc++abi] Add _LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS

smeenai added a comment. Ping. https://reviews.llvm.org/D26950 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

smeenai added inline comments. Comment at: include/clang/Sema/Sema.h:7494 + /// \brief Make an existing DLL attribute on a class take effect. + void ActOnDLLAttr(ClassTemplateSpecializationDecl *Def, hans wrote: > Nit: I think `///` implies `\brief`, so we do

[PATCH] D27387: [libc++] Add a key function for bad_function_call

smeenai created this revision. smeenai added reviewers: EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. Herald added a subscriber: mgorny. bad_function_call is currently an empty class, so any object files using that class will end up with their own copy of its typeinfo, typeinfo nam

[PATCH] D27387: [libc++] Add a key function for bad_function_call

smeenai added inline comments. Comment at: lib/CMakeLists.txt:162 -# Add a object library that contains the compiled source files. +# Add an object library that contains the compiled source files. add_library(cxx_objects OBJECT ${exclude_from_all} ${LIBCXX_SOURCES} ${LIBCXX_H

[PATCH] D27387: [libc++] Add a key function for bad_function_call

smeenai added inline comments. Comment at: src/functional.cpp:1 +//===--- functional.cpp ---===// +// Should I clang-format new files? I based the style of this file on the existing source files, but clang-format

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

smeenai updated this revision to Diff 80193. smeenai added a comment. Addressing comments https://reviews.llvm.org/D26657 Files: lib/Sema/SemaTemplate.cpp test/CodeGenCXX/dllexport.cpp test/CodeGenCXX/windows-itanium-dllexport.cpp Index: test/CodeGenCXX/windows-itanium-dllexport.cpp

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

smeenai added inline comments. Comment at: lib/Sema/SemaTemplate.cpp:7710 +(Context.getTargetInfo().getCXXABI().isMicrosoft() || + Context.getTargetInfo().getTriple().isWindowsItaniumEnvironment())) { + // In the MS ABI, an explicit instantiation definition c

[PATCH] D27387: [libc++] Add a key function for bad_function_call

smeenai added a comment. In https://reviews.llvm.org/D27387#612975, @EricWF wrote: > I wonder if we should consider this a breaking ABI change and control it > using a `_LIBCPP_ABI` macro. @mclow.lists thoughts? This is forward-compatible (as in clients built against an older libc++ would be

[PATCH] D26657: [Sema] Respect DLL attributes more faithfully

This revision was automatically updated to reflect the committed changes. Closed by commit rL288682: [Sema] Respect DLL attributes more faithfully (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D26657?vs=80193&id=80289#toc Repository: rL LLVM https://reviews.llvm.o

[PATCH] D27153: [libc++] Make __num_get_float hidden

smeenai added a comment. In https://reviews.llvm.org/D27153#613140, @EricWF wrote: > In https://reviews.llvm.org/D27153#606296, @smeenai wrote: > > > I'm having some second thoughts about this. Visibility for template > > functions makes my head spin :/ Is there a general policy we've been > >

[PATCH] D26934: [libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS

This revision was automatically updated to reflect the committed changes. Closed by commit rL288690: [libc++] Add _LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D26934?vs=79359&id=80304#toc Repository: rL LLVM https://reviews.

[PATCH] D26950: [libc++abi] Add _LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS

This revision was automatically updated to reflect the committed changes. Closed by commit rL288692: [libc++abi] Add _LIBCXXABI_DISABLE_VISIBILITY_ANNOTATIONS (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D26950?vs=78809&id=80306#toc Repository: rL LLVM https://re

[PATCH] D27430: [libc++] Annotate template methods with visibility

smeenai created this revision. smeenai added reviewers: EricWF, mclow.lists. smeenai added subscribers: cfe-commits, thakis. https://reviews.llvm.org/D25208 switches `_LIBCPP_TYPE_VIS` to expand to default visibility instead of default type visibility, in order to ease building libc++ with hidden

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

smeenai updated this revision to Diff 80334. smeenai added a comment. Rebasing https://reviews.llvm.org/D25208 Files: docs/DesignDocs/VisibilityMacros.rst include/__config Index: include/__config === --- include/__config +++

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

smeenai added a comment. https://reviews.llvm.org/D27430 should unblock this. https://reviews.llvm.org/D25208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27434: [libc++abi] Disable failing test on Darwin

smeenai created this revision. smeenai added reviewers: EricWF, mclow.lists. smeenai added a subscriber: cfe-commits. The macOS thread-local variable finalizer routines do not handle the case where a termination function registers another termination function correctly, causing this test to fail.

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai updated this revision to Diff 80361. smeenai added a comment. Addressing @compnerd's comments https://reviews.llvm.org/D26949 Files: src/abort_message.cpp src/abort_message.h src/cxa_exception.cpp src/cxa_exception.hpp src/cxa_handlers.cpp src/cxa_handlers.hpp src/cxa_new_

[PATCH] D27153: [libc++] Make __num_get_float hidden

smeenai added a comment. Pinging above question. https://reviews.llvm.org/D27153 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26949: [libc++abi] Clean up visibility

smeenai added a comment. Ping. https://reviews.llvm.org/D26949 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27430: [libc++] Annotate template methods with visibility

smeenai planned changes to this revision. smeenai added a comment. Hidden visibility also requires extern template declarations to expand to default visibility (as opposed to just default type visibility) to be feasible. Will fix annotations there and add those to this diff. https://reviews.ll

[PATCH] D25208: [libc++] Make _LIBCPP_TYPE_VIS export members

smeenai planned changes to this revision. smeenai added a comment. Hidden visibility also requires extern template declarations to expand to default visibility (as opposed to just default type visibility) to be feasible. Will fix annotations there and then roll that macro change into this diff.

[PATCH] D27434: [libc++abi] Disable failing test on Darwin

This revision was automatically updated to reflect the committed changes. Closed by commit rL289513: [libc++abi] Mark failing test on Darwin as XFAIL (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D27434?vs=80344&id=81174#toc Repository: rL LLVM https://reviews.llv

[PATCH] D32213: [Sema] Use MSVC inner class behavior on Itanium

This revision was automatically updated to reflect the committed changes. Closed by commit rL300804: [Sema] Use MSVC inner class behavior on Itanium (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D32213?vs=95689&id=95867#toc Repository: rL LLVM https://reviews.llvm

[PATCH] D32265: Add __CLANG_ATOMIC__LOCK_FREE macros for use in MSVC compatibility mode.

smeenai resigned from this revision. smeenai edited reviewers, added: compnerd; removed: smeenai. smeenai added a comment. This looks good to me, but I'm not familiar enough with this part of clang to be comfortable accepting. https://reviews.llvm.org/D32265 _

[PATCH] D32320: [libc++] Default to vcruntime when targeting MSVC

smeenai created this revision. Herald added a subscriber: mgorny. libc++abi is never the right option for LIBCXX_TARGETING_MSVC, since it targets the Itanium ABI, whereas MSVC uses the Microsoft ABI. Make the default ABI be vcruntime when targeting MSVC even if libc++abi is present in the tree.

[PATCH] D32320: [libc++] Default to vcruntime when targeting MSVC

smeenai added inline comments. Comment at: CMakeLists.txt:119 +set(LIBCXX_CXX_ABI_LIBNAME "vcruntime") else() +find_path( EricWF wrote: > Nit: I would rather see this be > ``` > elseif ((NOT LIBCXX_STANDALONE_BUILD OR HAVE_LIBCXXABI) AND > IS_D

[PATCH] D32320: [libc++] Default to vcruntime when targeting MSVC

smeenai updated this revision to Diff 96055. smeenai added a comment. Reduce nesting (address comments) https://reviews.llvm.org/D32320 Files: CMakeLists.txt Index: CMakeLists.txt === --- CMakeLists.txt +++ CMakeLists.txt @@ -1

[PATCH] D32320: [libc++] Default to vcruntime when targeting MSVC

This revision was automatically updated to reflect the committed changes. Closed by commit rL300921: [libc++] Default to vcruntime when targeting MSVC (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D32320?vs=96055&id=96056#toc Repository: rL LLVM https://reviews.ll

[PATCH] D32329: [libc++abi] Disable libc++ extern templates project-wide

smeenai created this revision. Herald added a subscriber: mgorny. libc++abi can't depend on libc++, so disable extern templates in libc++ headers project-wide. This was previously done in cxa_demangle.cpp, but I consider it more appropriate to do at the cmake level (since none of libc++abi's sourc

[PATCH] D32109: [Driver] Limit .exe extension addition to Windows hosts

smeenai added a comment. > Why not always replace the extension? Windows doesnt require the .exe suffix > IIRC. CreateProcess documentation says "This parameter must include the file name extension; no default extension is assumed.". That's kinda surprising to me, since LoadLibrary assumes a `

[PATCH] D32329: [libc++abi] Disable libc++ extern templates project-wide

smeenai added a comment. Ping. https://reviews.llvm.org/D32329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32329: [libc++abi] Disable libc++ extern templates project-wide

smeenai added a comment. Ping. https://reviews.llvm.org/D32329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32329: [libc++abi] Disable libc++ extern templates project-wide

smeenai added a comment. Fair enough. I'll probably get to that tomorrow. https://reviews.llvm.org/D32329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32329: [libc++abi] Disable libc++ extern templates project-wide

smeenai added a comment. Also ABI list checks for libc++abi sound awesome. https://reviews.llvm.org/D32329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32329: [libc++abi] Disable libc++ extern templates project-wide

smeenai added a comment. Confirmed that there are no ABI changed on both Linux and macOS. https://reviews.llvm.org/D32329 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D32329: [libc++abi] Disable libc++ extern templates project-wide

This revision was automatically updated to reflect the committed changes. Closed by commit rL302739: [libc++abi] Disable libc++ extern templates project-wide (authored by smeenai). Changed prior to commit: https://reviews.llvm.org/D32329?vs=96061&id=98540#toc Repository: rL LLVM https://rev

[PATCH] D33082: Fix Libc++ build with MinGW64

smeenai added a comment. @EricWF and I discussed this on IRC a bit. I'm not a fan of overloading `_LIBCPP_WIN32API` for this purpose, since to me that macro is meant for guarding Windows API functions, not for CRT functions. Eric suggested adding a new macro `_LIBCPP_MSVCRT_LIKE`, which I'd be

[PATCH] D33082: Fix Libc++ build with MinGW64

smeenai added a comment. @compnerd see my previous comment: > @EricWF and I discussed this on IRC a bit. I'm not a fan of overloading > _LIBCPP_WIN32API for this purpose, since to me that macro is meant for > guarding Windows API functions, not for CRT functions. Eric suggested adding > a new

[PATCH] D33082: Fix Libc++ build with MinGW64

smeenai added a comment. In https://reviews.llvm.org/D33082#754451, @compnerd wrote: > Sure, a `_LIBCPP_MSVCRT_LIKE` WFM. I just want to make sure that we don''t > conflate the underlying libc implementation with the Win32 API set. Yup, that was my concern as well. In https://reviews.llvm.or

[PATCH] D93164: [AST] Add generator for source location introspection

smeenai added a comment. In D93164#3252509 , @lancethepants wrote: > In D93164#3250945 , @andrew-wja > wrote: > >> In D93164#3048130 , @lancethepants >> wrote: >> >>> In D

[PATCH] D116882: [docs] [clang] Small documentation change for compilation databases

This revision was automatically updated to reflect the committed changes. Closed by commit rGb8467952404c: [docs] [clang] Small documentation change for compilation databases (authored by croepha, committed by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D118004: [hmaptool] Fix dumping

smeenai created this revision. smeenai added a reviewer: bruno. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. It was complaining about too many values to unpack, since our struct unpack format string specified six members, but we

[PATCH] D118005: [hmaptool] Fix string decoding for Python 3

smeenai created this revision. smeenai added a reviewer: bruno. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Our "strings" were actually bytes, which made verbose dumping fail. Decode them so they actually become strings. Repos

[PATCH] D118004: [hmaptool] Fix dumping

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c1d330431f5: [hmaptool] Fix dumping (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118004/new/ https://reviews.llvm.org/D118004 Files

[PATCH] D118005: [hmaptool] Fix string decoding for Python 3

This revision was automatically updated to reflect the committed changes. Closed by commit rGb4c1cbff79d0: [hmaptool] Fix string decoding for Python 3 (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118005/new/ https://reviews.l

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 343946. smeenai added a comment. Herald added subscribers: dcaballe, cota, teijeong. Rebase (comments not addressed yet; uploading a pure rebase for easier version comparison) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 343949. smeenai added a comment. Helper function to get install arg. TODO: Address other review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 Files: clang/

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai updated this revision to Diff 344299. smeenai added a comment. Uppercase variable names Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89177/new/ https://reviews.llvm.org/D89177 Files: clang/cmake/caches/MultiDistributionExample.cmake c

[PATCH] D89177: [cmake] Add support for multiple distributions

smeenai marked 3 inline comments as done. smeenai added inline comments. Comment at: llvm/cmake/modules/LLVMDistributionSupport.cmake:39 +# default (unnamed) distribution. +set_property(GLOBAL PROPERTY LLVM_DISTRIBUTION_FOR_${target} " ") + endforeach()

[PATCH] D116547: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

smeenai requested changes to this revision. smeenai added a comment. This revision now requires changes to proceed. Herald added a subscriber: JDevlieghere. This doesn't seem like a correct revert. What command are you using to generate this? `git revert` is what you should be using, e.g. git

[PATCH] D115960: Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`."

smeenai added a comment. Herald added a subscriber: JDevlieghere. I believe you landed the wrong commit. rG859ebca744e634dcc89a2294ffa41574f947bd62 looks like the previous versions of this diff, where lots of extraneous chang

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

smeenai added subscribers: lanza, smeenai. smeenai added a comment. With NDK r22, I only see libunwind.a for armv7. Will it be provided for other architectures in future NDK versions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96403/new/ https:

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

smeenai added a comment. In D96403#2638932 , @rprichard wrote: > In D96403#2638883 , @smeenai wrote: > >> With NDK r22, I only see libunwind.a for armv7. Will it be provided for >> other architectures in future NDK

[PATCH] D96403: [Android] Use -l:libunwind.a with --rtlib=compiler-rt

smeenai added a comment. Got it, thanks for all the info! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96403/new/ https://reviews.llvm.org/D96403 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D99321: [clang] Always execute multi-stage install steps

smeenai created this revision. smeenai added reviewers: beanz, phosek, tstellar. Herald added a subscriber: mgorny. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. We want installs to be executed even if binaries haven't changed, e.

[PATCH] D99322: [clang] Pass option directly to command. NFC

smeenai created this revision. smeenai added reviewers: beanz, phosek, tstellar. Herald added a subscriber: mgorny. smeenai requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This code was written back when LLVM's minimum required CMake versio

[PATCH] D99321: [clang] Always execute multi-stage install steps

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0135bc996d82: [clang] Always execute multi-stage install steps (authored by smeenai). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTI

<    2   3   4   5   6   7   8   >