This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc5348355ee66: [www] Fix Ninja build instructions on Windows
(authored by triplef, committed by xgupta).
Repository:
rG LLVM Github Monorepo
CHANG
xgupta added a comment.
(If you pass --draft flag to arc while updating revision it becomes WIP so you
don't need to retitle or remove reviewers. Buildbot also work in that case. And
to again ask for review you can use `Add Action` drop down menu.)
Repository:
rG LLVM Github Monorepo
CHANGE
xgupta accepted this revision.
xgupta added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102836/new/
https://reviews.llvm.org/D102836
___
This revision was automatically updated to reflect the committed changes.
Closed by commit rG4a6d8a11f89b: [clang] Fix Typo in AST Matcher Reference
(authored by xgupta).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102836/new/
https://reviews.llvm
xgupta accepted this revision.
xgupta added a comment.
This revision is now accepted and ready to land.
Thanks, LGTM!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98254/new/
https://reviews.llvm.org/D98254
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe01ac501af20: Fix typo in two files in Clang, patch by
FusionBolt (authored by xgupta).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98254/new/
https://rev
xgupta accepted this revision.
xgupta added a comment.
This revision is now accepted and ready to land.
LGTM, Thank!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D77470/new/
https://reviews.llvm.org/D77470
_
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8f77dc459e31: [clang] NFC: Fix trivial typo in comments and
document (authored by kiszk, committed by xgupta).
Changed prior to commit:
https://re
xgupta accepted this revision.
xgupta added a comment.
This revision is now accepted and ready to land.
Thanks!
ref - https://www.microchip.com/en-us/product/ATxmega16A4U
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109653/new/
https://reviews.ll
xgupta added a comment.
Yeah, Such patches are OK to commit by just adding a [NFC] tag in commit
message. Though if you spend some time on Phabricator, you will be aware of
which kind of patches need reviews and which can be committed directly.
Repository:
rG LLVM Github Monorepo
CHANGES SI
201 - 210 of 210 matches
Mail list logo