[PATCH] D112257: [www] Fix Ninja build instructions on Windows

2021-10-23 Thread Shivam Gupta via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc5348355ee66: [www] Fix Ninja build instructions on Windows (authored by triplef, committed by xgupta). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D108742: [WIP] Reclassify form-feed and vertical tab as vertical WS for the purposes of lexing.

2021-08-27 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta added a comment. (If you pass --draft flag to arc while updating revision it becomes WIP so you don't need to retitle or remove reviewers. Buildbot also work in that case. And to again ask for review you can use `Add Action` drop down menu.) Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D102836: [clang] Fix Typo in AST Matcher Reference

2021-08-30 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. lgtm Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102836/new/ https://reviews.llvm.org/D102836 ___

[PATCH] D102836: [clang] Fix Typo in AST Matcher Reference

2021-08-30 Thread Shivam Gupta via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG4a6d8a11f89b: [clang] Fix Typo in AST Matcher Reference (authored by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102836/new/ https://reviews.llvm

[PATCH] D98254: Fix typo in two files in Clang

2021-08-30 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. Thanks, LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98254/new/ https://reviews.llvm.org/D98254

[PATCH] D98254: Fix typo in two files in Clang

2021-08-31 Thread Shivam Gupta via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGe01ac501af20: Fix typo in two files in Clang, patch by FusionBolt (authored by xgupta). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98254/new/ https://rev

[PATCH] D77470: [clang] NFC: Fix trivial typo in comments and document

2021-08-31 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. LGTM, Thank! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77470/new/ https://reviews.llvm.org/D77470 _

[PATCH] D77470: [clang] NFC: Fix trivial typo in comments and document

2021-09-04 Thread Shivam Gupta via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8f77dc459e31: [clang] NFC: Fix trivial typo in comments and document (authored by kiszk, committed by xgupta). Changed prior to commit: https://re

[PATCH] D109653: Fix some definitions on AVR target

2021-09-11 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta accepted this revision. xgupta added a comment. This revision is now accepted and ready to land. Thanks! ref - https://www.microchip.com/en-us/product/ATxmega16A4U Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109653/new/ https://reviews.ll

[PATCH] D109653: Fix some definitions on AVR target

2021-09-12 Thread Shivam Gupta via Phabricator via cfe-commits
xgupta added a comment. Yeah, Such patches are OK to commit by just adding a [NFC] tag in commit message. Though if you spend some time on Phabricator, you will be aware of which kind of patches need reviews and which can be committed directly. Repository: rG LLVM Github Monorepo CHANGES SI

<    1   2   3