[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 updated this revision to Diff 499555. tianshilei1992 marked 2 inline comments as done. tianshilei1992 added a comment. rebase and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569

[PATCH] D144590: Fix shared memory allocation on AMDGPU

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. I think this looks reasonable to me. @jdoerfert WDYT? I'm not sure if you need to fix some clang tests. Let's see if Buildbot is happy. Repository: rG LLVM Github Monorepo

[PATCH] D150156: [OpenMP] Fix incorrect interop type for number of dependencies

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. Does this cause the IR issue? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150156/new/ https://reviews.llvm.org/D150156 __

[PATCH] D150461: [OpenMP] Naturally align internal global variables in the OpenMPIRBuilder

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150461/new/ https://reviews.llvm.org/D150461 _

[PATCH] D130545: [cmake] Slight fix ups to make robust to the full range of GNUInstallDirs

tianshilei1992 added a comment. Herald added subscribers: ekilmer, jplehr, StephenFan. This patch breaks the assumption that some projects are supposed to support to be built as a standalone project. For example, we do have a standalone release for OpenMP (https://github.com/llvm/llvm-project/r

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 updated this revision to Diff 515854. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp clang/test/H

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 updated this revision to Diff 515876. tianshilei1992 added a comment. update more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp c

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 updated this revision to Diff 516086. tianshilei1992 added a comment. Herald added subscribers: jplehr, sunshaoce. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627 Files: clang/lib/

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. After reading some threads (https://github.com/OpenMP/spec/issues/2178#issue-622053885 and https://github.com/OpenMP/spec/issues/1870), I think `has_device_addr` is not supposed to have any semantics about creating a mapping, especially in `https://github.com/Op

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 updated this revision to Diff 516088. tianshilei1992 added a comment. add the last test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142569/new/ https://reviews.llvm.org/D142569 Files: clang/lib/CodeGen/CGOpenMPRuntimeGPU.cpp c

[PATCH] D142569: [OpenMP] Introduce kernel environment

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35cfadfbe2de: [OpenMP] Introduce kernel environment (authored by tianshilei1992). Herald added a subscriber: hoy. Repository: rG LLVM Github Monor

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 reopened this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. In D142569#4290109 , @ronlieb wrote: > @tianshilei1992 this seems to have broken the amdgpu buildbot, could you > please address qui

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 updated this revision to Diff 516110. tianshilei1992 added a comment. Fix two test failres. It looks like not working on AMDGPU because of the global read on the host is not correct. Needs to investigate more. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D141627: [Clang][OpenMP] Fix the issue that list items in `has_device_addr` are still mapped to the target device

tianshilei1992 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141627/new/ https://reviews.llvm.org/D141627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D142569: [OpenMP] Introduce kernel environment

tianshilei1992 added inline comments. Comment at: llvm/test/Transforms/OpenMP/always_inline_device.ll:11 -; Function Attrs: norecurse nounwind +@kernel_environment = local_unnamed_addr constant %struct.KernelEnvironmentTy { %struct.ConfigurationEnvironmentTy { i8 1, i8 0, i8 1

[PATCH] D149641: [docs] Hide collaboration and include graphs in doxygen docs

tianshilei1992 added a comment. Looks good on the OpenMP side as we don’t generally have a good API doc anyway. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149641/new/ https://reviews.llvm.org/D149641

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ggeorgakoudis, jhuber6. Herald added subscribers: guansong, yaxunl. Herald added a project: All. tianshilei1992 requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1. Herald

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added inline comments. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:879 "Cannot embed bitcode with multiple files."); -OutputFiles.push_back(static_cast(BitcodeOutput.front())); +OutputFiles.push_back(A

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp:685 + auto TgtImageOrErr = jit::compile(TgtImage, Triple, Arch, +/* OptLevel */ 3, PostProcessing); +

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:228 +namespace jit { +bool checkBitcodeImage(__tgt_device_image *Image, std::string Triple) { + TimeTraceScope TimeScope("Check bitcode image");

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added a comment. In D139287#3970996 , @jhuber6 wrote: > Why do we have the JIT in the nextgen plugins? I figured that JIT would be > handled by `libomptarget` proper rather than the plugins. I guess this is > needed for per-kernel special

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added a comment. In D139287#3971062 , @jhuber6 wrote: > In D139287#3971024 , > @tianshilei1992 wrote: > >> In D139287#3970996 , @jhuber6 >> wrote: >> >>>

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:184 + + auto AddStream = + [&](size_t Task, jhuber6 wrote: > tianshilei1992 wrote: > > jhuber6 wrote: > > > tianshilei1992 wrote: > > > > I

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 481014. tianshilei1992 added a comment. Herald added a subscriber: aheejin. drop LTO and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files:

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 marked 5 inline comments as done. tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/CMakeLists.txt:24 else() llvm_map_components_to_libnames(llvm_libs Support) endif() Have to figure

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 481023. tianshilei1992 added a comment. add build components Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files: openmp/libomptarget/plugins-nextgen/CMake

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 added a comment. We probably want to enable a new test configuration to have each test run in JIT mode. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 481686. tianshilei1992 added a comment. Herald added a subscriber: pcwang-thead. rebase and refine It currently crashes in `setupLLVMOptimizationRemarks` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 481960. tianshilei1992 added a comment. rebase and fix opt error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files: openmp/libomptarget/plugins-nextgen/C

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 481980. tianshilei1992 added a comment. rebase and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files: openmp/libomptarget/plugins-nextgen/CM

[PATCH] D139287: [WIP][OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 482158. tianshilei1992 added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files: openmp/cmake/OpenMPTesting.cmake openmp/libomptarge

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 updated this revision to Diff 482168. tianshilei1992 added a comment. add env for opt level Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139287/new/ https://reviews.llvm.org/D139287 Files: openmp/cmake/OpenMPTesting.cmake openm

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 marked an inline comment as done and an inline comment as not done. tianshilei1992 added inline comments. Comment at: openmp/cmake/OpenMPTesting.cmake:6 function(find_standalone_test_dependencies) - include(FindPythonInterp) + find_package(Python3 COMPONENTS In

[PATCH] D139287: [OpenMP] Introduce basic JIT support to OpenMP target offloading

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: openmp/libomptarget/plugins-nextgen/common/PluginInterface/JIT.cpp:184 + + auto AddStream = + [&](size_t Task, jdoerfert wrote: > jhuber6 wrote: > > tianshil

[PATCH] D139730: [OpenMP][DeviceRTL][AMDGPU] Support code object version 5

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/DeviceRTL/src/Mapping.cpp:19 #pragma omp begin declare target device_type(nohost) - +extern const uint16_t __oclc_ABI_version; #include "llvm/Frontend/OpenMP/OMPGridValues.h" jhuber6 wrote: >

[PATCH] D105876: OMPIRBuilder for Interop directive

tianshilei1992 updated this revision to Diff 403737. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105876/new/ https://reviews.llvm.org/D105876 Files: clang/lib/CodeGen/CGStmt.cpp clang/lib/CodeGen/CGStmt

[PATCH] D105876: OMPIRBuilder for Interop directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5aa24558cfa6: OMPIRBuilder for Interop directive (authored by sriharikrishna, committed by tianshilei1992). Repository: rG LLVM Github Monorepo C

[PATCH] D106674: Runtime for Interop directive

tianshilei1992 updated this revision to Diff 403750. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106674/new/ https://reviews.llvm.org/D106674 Files: openmp/libomptarget/include/interop.h openmp/libompta

[PATCH] D106674: Runtime for Interop directive

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf44e41af4121: Runtime for Interop directive (authored by sriharikrishna, committed by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D118399: [OpenMP] Introduce new flag to indicate OpenMP runtime compilation

tianshilei1992 added a comment. Do we have an alternative w/o need to add a flag dedicated for building a very specific target, OpenMP device runtime? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118399/new/ https://reviews.llvm.org/D118399

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 updated this revision to Diff 404601. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116637/new/ https://reviews.llvm.org/D116637 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clan

[PATCH] D118632: [WIP][Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 created this revision. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. Depends on D116637

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3284773 , @ABataev wrote: > sema and parsing tests? Tests will be in the patch for code gen. Comment at: clang/lib/Sema/SemaOpenMP.cpp:10921 +/// Get the node id of the fixed point of an expr

[PATCH] D117048: [OpenMP] Link the bitcode library late for device LTO

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LGTM with two nits. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:75 +static cl::opt +BitcodeLibrary("target-library", +

[PATCH] D118197: [OpenMP] Replace sysmtem call to `llc` with target machine

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118197/new/ https://reviews.llvm.org/D118197 _

[PATCH] D117156: [OpenMP] Add extra flag handling to linker wrapper

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG. One nit. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:98 +static cl::opt +PtxasOption("ptxas-option", cl::ZeroOrMore, +

[PATCH] D117246: [OpenMP] Add support for linking AMDGPU images

tianshilei1992 added a comment. @JonChesterfield can we just accept the patch and make it in 14? If we later find anything broken, we could have bug fix. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117246/new/ https://reviews.llvm.org/D117246 _

[PATCH] D118198: [OpenMP] Remove call to 'clang-offload-wrapper' binary

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118198/new/ https://reviews.llvm.org/D118198 _

[PATCH] D118155: [OpenMP] Improve symbol resolution for OpenMP Offloading LTO

tianshilei1992 added a comment. LG with one nit. Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:777-781 +// Record if we've seen these symbols in any object or shared libraries. +if ((*ObjFile)->isRelocatableObject()) { + UsedInReg

[PATCH] D117049: [OpenMP] Add support for embedding bitcode images in wrapper tool

tianshilei1992 accepted this revision. tianshilei1992 added a comment. This revision is now accepted and ready to land. I'm gonna accept it for now to make it in 14. We can always come back later if we see anything wrong. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D118632: [WIP][Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 updated this revision to Diff 405377. tianshilei1992 added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. rebase and finish the functionality Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[PATCH] D118632: [WIP][Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 updated this revision to Diff 405378. tianshilei1992 added a comment. remove unrelated changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118632/new/ https://reviews.llvm.org/D118632 Files: clang/include/clang/AST/StmtOpenMP.h

[PATCH] D118632: [WIP][Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 updated this revision to Diff 405379. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118632/new/ https://reviews.llvm.org/D118632 Files: clang/include/clang/AST/StmtOpenMP.h clang/lib/AST/St

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 added a comment. In D116637#3291608 , @jdoerfert wrote: > In D116637#3284823 , > @tianshilei1992 wrote: > >> In D116637#3284773 , @ABataev >> wrote: >> >>

[PATCH] D118632: [WIP][Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 updated this revision to Diff 405393. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118632/new/ https://reviews.llvm.org/D118632 Files: clang/include/clang/AST/StmtOpenMP.h clang/lib/AST/St

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 added a comment. We don't have Sema yet, so there is no erroneous test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 ___ cfe-commits mailing l

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:6 + +// RUN: %clang_cc1 -verify -triple x86_64-apple-darwin10 -target-cpu core2 -fopenmp-simd -fopenmp-version=51 -x c -emit-llvm %s -o

[PATCH] D119392: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

tianshilei1992 updated this revision to Diff 409784. tianshilei1992 added a comment. add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119392/new/ https://reviews.llvm.org/D119392 Files: clang/lib/Sema/SemaOpenMP.cpp clang/test/OpenMP/a

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 409791. tianshilei1992 added a comment. add a small test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/li

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGccebf8ac8c61: [Clang][OpenMP] Add support for compare capture in parser (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D119392: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare

This revision was automatically updated to reflect the committed changes. Closed by commit rG68b7b357fdfc: [Clang][OpenMP][Sema] Remove support for floating point values in atomic compare (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://revi

[PATCH] D120200: [WIP][Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds Sema support for `

[PATCH] D120200: [WIP][Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 updated this revision to Diff 410124. tianshilei1992 added a comment. reorg code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 Files: clang/lib/Sema/SemaOpenMP.cpp Index: clang/lib/Sem

[PATCH] D120200: [WIP][Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 updated this revision to Diff 410180. tianshilei1992 added a comment. fnish all checks and add note messages Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 Files: clang/include/clang/Bas

[PATCH] D120200: [WIP][Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 updated this revision to Diff 410191. tianshilei1992 added a comment. add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td cl

[PATCH] D120200: [Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 updated this revision to Diff 410200. tianshilei1992 added a comment. fix error message Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 Files: clang/include/clang/Basic/DiagnosticSemaKind

[PATCH] D120200: [Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 updated this revision to Diff 410203. tianshilei1992 added a comment. set `C` accordingly Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 Files: clang/include/clang/Basic/DiagnosticSemaKi

[PATCH] D120225: [Clang][Sema] Check unexpected else statement in cond-update-stmt

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. tianshilei1992 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. In 'cond-update-stmt', `else` statement is not expected. This patch adds the check in S

[PATCH] D120200: [Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 added a comment. In D120200#3335250 , @ABataev wrote: > Do we have ast print/dump tests for correct constructs? It's in the parser patch which has already been merged. https://reviews.llvm.org/D116261 Repository: rG LLVM Github Monore

[PATCH] D120225: [Clang][Sema] Check unexpected else statement in cond-update-stmt

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6da60647cda2: [Clang][Sema] Check unexpected else statement in cond-update-stmt (authored by tianshilei1992). Repository: rG LLVM Github Monorepo

[PATCH] D120252: [Clang][OpenMP] Fix wrong form of 'cond-update-stmt' in atomic_ast_print.cpp

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. In `clang/test/OpenMP/atomic_ast_p

[PATCH] D120200: [Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 updated this revision to Diff 410313. tianshilei1992 added a comment. fix tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td c

[PATCH] D120252: [Clang][OpenMP] Fix wrong form of 'cond-update-stmt' in atomic_ast_print.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3a3d9ae54592: [Clang][OpenMP] Fix wrong form of 'cond-update-stmt' in atomic_ast_print.cpp (authored by tianshilei1992). Repository: rG LLVM Gith

[PATCH] D120200: [Clang][OpenMP] Add Sema support for atomic compare capture

tianshilei1992 updated this revision to Diff 410318. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120200/new/ https://reviews.llvm.org/D120200 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clan

[PATCH] D120200: [Clang][OpenMP] Add Sema support for atomic compare capture

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe2855e17601e: [Clang][OpenMP] Add Sema support for atomic compare capture (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANG

[PATCH] D118632: [Clang]OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 added a comment. In D118632#3336094 , @ABataev wrote: > LG with a nit Actually I got two question in the inline comments. Can you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 added a comment. In D118632#3336145 , @ABataev wrote: > In D118632#3336133 , > @tianshilei1992 wrote: > >> In D118632#3336094 , @ABataev >> wrote: >> >>>

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEX

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEX

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6041 + llvm::Value *EVal = CGF.EmitScalarExpr(E->IgnoreImpCasts()); + llvm::Value *DVal = D ? CGF.EmitScalarExpr(D->IgnoreImpCasts()) : nullptr;

[PATCH] D120290: [WIP][Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the codegen suppor

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEX

[PATCH] D118632: [Clang][OpenMP] Add the codegen support for `atomic compare`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/test/OpenMP/atomic_compare_codegen.cpp:1990 +// CHECK-NEXT:[[DD:%.*]] = alloca double, align 8 +// CHECK-NEXT:[[TMP0:%.*]] = load i8, i8* [[CE]], align 1 +// CHECK-NEX

[PATCH] D120290: [WIP][Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 updated this revision to Diff 410448. tianshilei1992 added a comment. add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290 Files: clang/include/clang/AST/StmtOpenMP.h clang/lib/AST

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11556 X = ThenBO->getLHS(); - D = ThenBO->getRHS(); + D = ThenBO->getRHS()->IgnoreImpCasts(); ABataev wrote: > Need to be caref

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:2835-2847 bool IsXLHSInRHSPart = false; /// Used for 'atomic update' or 'atomic capture' constructs. They may /// have atomic expressio

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 updated this revision to Diff 410986. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. rebase and fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6067 + if (VPtr) { +VOpVal = {VPtr, VPtr->getType()->getPointerElementType(), + V->getType().isVolatileQualified(),

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 updated this revision to Diff 411688. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120290/new/ https://reviews.llvm.org/D120290 Files: clang/

[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

tianshilei1992 added inline comments. Comment at: clang/include/clang/AST/StmtOpenMP.h:2917-2920 Create(const ASTContext &C, SourceLocation StartLoc, SourceLocation EndLoc, ArrayRef Clauses, Stmt *AssociatedStmt, Expr *X, Expr *V, - Expr *E, Expr *UE, Expr *D

[PATCH] D100768: [Clang][OpenMP] Remove the mandatory flush for capture for OpenMP 5.1

tianshilei1992 added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100768/new/ https://reviews.llvm.org/D100768 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[PATCH] D97680: [OpenMP] Simplify GPU memory globalization

tianshilei1992 added a comment. Is it better to split the patch? For example, the new alloc/free shared can be in a separate patch, and the globalization can be in another one. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97680/new/ https://revie

[PATCH] D101935: [clang] Search runtimes build tree for openmp runtime

tianshilei1992 requested changes to this revision. tianshilei1992 added a comment. This revision now requires changes to proceed. From my perspective, this is not a good direction. No need to bother Clang driver for one case of testing. `LIBRARY_PATH` needs to be set correctly by lit instead of

[PATCH] D101935: [clang] Search runtimes build tree for openmp runtime

tianshilei1992 added a comment. Unlike others, such as `/usr/local/lib` or `/usr/local/cuda`, it is not a standard place. It doesn't make too much sense to hardcode it in the driver. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101935/new/ https:

[PATCH] D116637: [Clang][Sema][OpenMP] Sema support for `atomic compare`

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev. Herald added subscribers: guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: cfe-commits, sstefan1. Herald added a project: clang. This patch adds the Sema support f

[PATCH] D113359: [Libomptarget][WIP] Introduce VGPU Plugin

tianshilei1992 added inline comments. Comment at: openmp/libomptarget/DeviceRTL/CMakeLists.txt:231 + +compileDeviceRTLLibrary(x86_64 vgpu -target x86_64-vgpu -std=c++20 -stdlib=libc++ -I${devicertl_base_directory}/../plugins/vgpu/src) It's not a good practice to

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev, carlo.bertolli. Herald added subscribers: arphaman, guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: cla

[PATCH] D102449: [WIP][Clang][OpenMP] Add the support for compare clause in atomic directive

tianshilei1992 added a comment. I created a patch D115561 for parser. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102449/new/ https://reviews.llvm.org/D102449 ___ cfe

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 393629. tianshilei1992 added a comment. remove useless code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files: clang/include/clang/AST/OpenMPClause.h c

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 393633. tianshilei1992 added a comment. further remove code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files: clang/include/clang/AST/OpenMPClause.h c

<    1   2   3   4   5   6   >