[PATCH] D141698: doc: Rewrite opening paragraph of CFI Design Doc

2023-02-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. I tend to keep it as it is. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D141698/new/ https://reviews.llvm.org/D141698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

2023-04-24 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. I would like to help land this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

2023-04-24 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 516476. sunshaoce added a comment. This revision is now accepted and ready to land. Herald added subscribers: pcwang-thead, s.egerton, simoncook, asb. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

2023-04-25 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 516651. sunshaoce added a comment. Address @awarzynski's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 Files: clang/lib/Driver/ToolChains/Gnu.cpp fla

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

2023-04-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. Any further suggestions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D134821/new/ https://reviews.llvm.org/D134821 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

2023-04-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG876df74dd471: [flang][driver] Allow main program to be in an archive (authored by sunshaoce). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D134821: [flang][driver] Allow main program to be in an archive

2023-04-28 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. In D134821#4304690 , @awarzynski wrote: > I've just reverted this patch - for context please see > https://reviews.llvm.org/D149429. > > @sunshaoce This was committed >

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-01-17 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 400733. achieveartificialintelligence added a comment. Herald added subscribers: alextsao1999, eopXD. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.o

[PATCH] D117740: [NFC][clang] Simplify `isOneOf` function

2022-01-19 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: alexfh, danielmarjamaki. achieveartificialintelligence requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-01-19 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Ping. Any other suggestions? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list cfe-commi

[PATCH] D112408: [RISCV] Add the zve extension according to the v1.0 spec

2022-01-19 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added inline comments. Comment at: llvm/test/CodeGen/RISCV/rvv/vloxseg-rv32.ll:2 ; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py -; RUN: llc -mtriple=riscv32 -mattr=+d,+experimental-zvlsseg,+zfh \ +; RUN: llc -mtriple=r

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-01-20 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 401528. achieveartificialintelligence added a comment. Address @craig.topper's comments. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 F

[PATCH] D113237: [RISCV] Support I extension version 2.1

2022-01-24 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. > @achieveartificialintelligence Do you know what is the relation between your > patch and D115921 ? This commit doesn't depend on D115921 , but if D115921

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-01-24 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 402739. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. @asb Thank you very much! Could you please take a look at what needs to be modified now? Repository: rG LLVM Githu

[PATCH] D118578: [RISCV] Make Zfhmin in march imply F.

2022-01-31 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence accepted this revision. achieveartificialintelligence added a comment. This revision is now accepted and ready to land. LGTM. I think this is indeed a better way to implement `Zfhmin`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D117740: [NFC][clang] Simplify `isOneOf` function

2022-01-31 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117740/new/ https://reviews.llvm.org/D117740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-01 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 404910. achieveartificialintelligence added a comment. Separate the Zhinxmin and Zhinx extensions. Inspired by D118581 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-18 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. @krasimir Since I don't have a rust environment, can you help me to test if D120130 works? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.l

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-21 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 410444. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files: clang/include/clang/Basic

[PATCH] D117740: [NFC][clang] Simplify `isOneOf` function

2022-02-23 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117740/new/ https://reviews.llvm.org/D117740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-24 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. In D93298#3342452 , @krasimir wrote: > @achieveartificialintelligence any progress with the problematic IR? Have you > been able to reproduce using nikic's reduced example? Sorry, I don't have a solution rig

[PATCH] D117740: [NFC][clang] Simplify `isOneOf` function

2022-02-24 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGa8b4b9104c8f: [NFC][clang] Simplify `isOneOf` function (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117740/new/

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-25 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 411375. achieveartificialintelligence added a comment. Thanks for @craig.topper's patch! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files:

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-25 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 411379. achieveartificialintelligence added a comment. Ping & Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files: clang/include/clan

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 411675. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Thanks for @craig.topper's detailed advice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 411676. achieveartificialintelligence added a comment. Fix typo Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files: clang/include/clang/Bas

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Can you help test if this patch works fine now? @krasimir Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-c

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 411719. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/lib/Support/RISCVISAIn

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 411734. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Address @jrtc27's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-28 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Are there any other errors now? @krasimir @nikic Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits ma

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-28 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 411959. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Address @craig.topper's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-03-01 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0e38b295435b: [RISCV] add the MC layer support of Zfinx extension (authored by achieveartificialintelligence). Herald added a project: All. Reposito

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-03-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 412698. achieveartificialintelligence marked 7 inline comments as done. achieveartificialintelligence added a comment. Address @craig.topper's comments. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-03-04 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfa9c8bab0c7a: [RISCV] Support k-ext clang intrinsics (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 397191. achieveartificialintelligence added a comment. Address @craig.topper 's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files:

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 397193. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/lib/Support/RISCVISAIn

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoF.td:217 +let Predicates = [HasStdExtF] in { +def : FPFMADynFrmAlias; +def : FPFMADynFrmAlias; craig.topper wrote: > Why do the aliases not apply to Zfinx? Becaus

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 397206. achieveartificialintelligence added a comment. Use `DAGOperand` instead of `RegisterOperand` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D9329

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-05 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 397469. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Fix issue in RISCVISAInfo.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-06 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 398031. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Inspired by D116019 , use multiclass in Alias Repository: rG LLVM Github Monorepo

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

2022-01-06 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added inline comments. Comment at: llvm/lib/Target/RISCV/RISCV.td:155-187 +def FeatureStdExtZvl64b : SubtargetFeature<"experimental-zvl64b", "ZvlLen", "ExtZvl::Zvl64b", + "'Zvl' (Minimum Vector Length) 64", +

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2022-01-10 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 398824. achieveartificialintelligence added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/lib/Support/RISCVISAIn

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-01-12 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Ping. `Zfinx` has been ratified, could we spend some time on this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 __

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-01-12 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 399270. achieveartificialintelligence added a comment. update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/lib/Support/RISCVISAIn

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-01-12 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 399527. achieveartificialintelligence marked 3 inline comments as done. achieveartificialintelligence added a comment. Address @craig.topper's comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[PATCH] D117199: [RISCV] Add missing namespace (NFC)

2022-01-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added inline comments. Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:300 if (Log2ScaleResult < 0) -return None; +return llvm::None; return 1 << Log2ScaleResult; We have used using namespace llvm; Repository: rG

[PATCH] D117199: [RISCV] Add missing namespace (NFC)

2022-01-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence accepted this revision. achieveartificialintelligence added a comment. This revision is now accepted and ready to land. OK, LGTM. Thanks! @fakepaper56 @khchen Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117199/new/ h

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-01-15 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 400256. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/lib/Support/RISCVISAIn

[PATCH] D113237: [RISCV] Support I extension version 2.1

2021-12-14 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 394174. achieveartificialintelligence added a comment. Support both i2p0 and i2p1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113237/new/ https://reviews.llvm.org/D113237 Files: clang

[PATCH] D115709: [RISCV] Remove Vamo Extention

2021-12-14 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: kito-cheng, HsiangKai, arcbbb, jrtc27, craig.topper. Herald added subscribers: VincentWu, luke957, vkmr, frasercrmck, jdoerfert, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna,

[PATCH] D115709: [RISCV] Remove Vamo Extention

2021-12-15 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. I've updated the description. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115709/new/ https://reviews.llvm.org/D115709 ___ cfe-commits mailing lis

[PATCH] D115709: [RISCV] Remove Zvamo Extention

2021-12-19 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. In D115709#3200212 , @craig.topper wrote: > LGTM Should I land it now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115709/new/ https://reviews.llvm.org/D1

[PATCH] D115709: [RISCV] Remove Zvamo Extention

2021-12-19 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68bc6d7cae6d: [RISCV] Remove Zvamo Extention (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116014: Remove the signed version of createExpression

2021-12-19 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence created this revision. achieveartificialintelligence added a reviewer: dexonsmith. Herald added a reviewer: deadalnix. Herald added a subscriber: hiraditya. achieveartificialintelligence requested review of this revision. Herald added projects: clang, LLVM. Herald adde

[PATCH] D116014: [clang][CodeGen] Remove the signed version of createExpression

2021-12-26 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116014/new/ https://reviews.llvm.org/D116014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D116014: [clang][CodeGen] Remove the signed version of createExpression

2021-12-26 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGec501f15a8b8: [clang][CodeGen] Remove the signed version of createExpression (authored by achieveartificialintelligence). Changed prior to commit:

[PATCH] D116014: [clang][CodeGen] Remove the signed version of createExpression

2021-12-26 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. In D116014#3210212 , @CodaFi wrote: > C API changes LGTM. Thanks for your review! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116014/new/ https://reviews.l

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2021-12-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 396373. achieveartificialintelligence added a comment. Update Part of Zfinx Codes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/li

[PATCH] D93298: [RISCV] add the part of MC layer support of Zfinx extension

2021-12-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. I'll finish the rest of code, if this patch is acceptable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-

[PATCH] D108694: [RISCV] Add the zvl extension according to the v1.0 spec

2021-12-29 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:741-751 +{{"zvl1024b"}, {ImpliedExtsZvl1024b}}, +{{"zvl128b"}, {ImpliedExtsZvl128b}}, +{{"zvl16384b"}, {ImpliedExtsZvl16384b}}, +{{"zvl2048b"}, {ImpliedExtsZvl2048b}

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2021-01-04 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 314349. achieveartificialintelligence marked 2 inline comments as done. achieveartificialintelligence added a comment. Including Zfinx, zdinx. Zfhinx. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llv

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2021-01-04 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. In D93298#2457925 , @kito-cheng wrote: > Do you have implement register pair for rv32ifd_zfinx? I didn't saw the > related implementation, but I

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2021-01-04 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence added a comment. In D93298#2477105 , @jrtc27 wrote: > Your tests look like copies of the F/D/Zfh tests with not all the comments > updated and instances of tests that just don't make sense for Zfinx. I only > skimmed them an

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2021-01-06 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 314879. achieveartificialintelligence marked 5 inline comments as done. achieveartificialintelligence added a comment. Thanks for suggestions. We updated the code again. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2021-10-08 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence added a comment. In D93298#3020917 , @frasercrmck wrote: > In D93298#3014160 , @jrtc27 wrote: > >> The amount of duplication here really depresses me and is only going to get >> worse

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2021-10-12 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 379272. achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Add arch info Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/

[PATCH] D110669: [RISCV] Update Zba, Zbb, Zbc, and Zbs version from 0.93 to 1.0.

2021-10-12 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added inline comments. Comment at: clang/lib/Driver/ToolChains/Arch/RISCV.cpp:63-65 + if (Ext == "zbe" || Ext == "zbf" || Ext == "zbm" || Ext == "zbp" || Ext == "zbr" || + Ext == "zbt") Need format here? Repository:

[PATCH] D111866: [RISCV] Support Zfhmin extension

2021-10-14 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: craig.topper, jrtc27, kito-cheng, asb, luismarques. Herald added subscribers: vkmr, frasercrmck, evandro, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, Ma

[PATCH] D111866: [RISCV] Support Zfhmin extension

2021-10-14 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 379924. achieveartificialintelligence added a comment. add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files: clang/lib/Basic/Target

[PATCH] D111866: [RISCV] Support Zfhmin extension

2021-10-18 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 380323. achieveartificialintelligence added a comment. Herald added a subscriber: jdoerfert. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D1118

[PATCH] D111866: [RISCV] Support Zfhmin extension

2021-10-24 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Is there any suggestion? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 ___ cfe-commits mailing list cfe-commits

[PATCH] D109681: [RISCV] add Half-precision test for vle/vse

2021-09-13 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: craig.topper, HsiangKai. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, r

[PATCH] D109681: [RISCV] add Half-precision test for vle/vse

2021-09-13 Thread Shao-Ce Sun via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd4f25d0046fc: [RISCV] add Half-precision test for vle/vse (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D109799: [RISCV] add Half-precision test for load/store

2021-09-14 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: craig.topper, HsiangKai. Herald added subscribers: vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, r

<    1   2