[PATCH] D128604: [WIP][RISCV] Support Zbpbo extension

2022-06-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 440267. sunshaoce added a comment. Add more tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang/test/

[PATCH] D128604: [RISCV] Support Zbpbo extension

2022-06-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added inline comments. Comment at: llvm/lib/Support/RISCVISAInfo.cpp:352 MinorStr = In.take_while(isDigit); -In = In.substr(MajorStr.size() + 1); +In = In.substr(MajorStr.size() + MinorStr.size() - 1); Modifications here have been submitt

[PATCH] D128604: [WIP][RISCV] Support Zbpbo extension

2022-06-27 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 440324. sunshaoce added a comment. Herald added a subscriber: jdoerfert. Fully supported Zbpbo v0.9.11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clan

[PATCH] D128604: [RISCV] Support Zbpbo extension

2022-06-28 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 440613. sunshaoce added a comment. Rebased on D128644 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clang/include/clan

[PATCH] D128604: [RISCV] Support Zbpbo extension

2022-06-28 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 440714. sunshaoce marked an inline comment as done. sunshaoce added a comment. Address @craig.topper's comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D1286

[PATCH] D128604: [RISCV] Support Zbpbo extension

2022-06-29 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 441052. sunshaoce added a comment. Add alias instructions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clang/include/clang/Basic/BuiltinsRISCV.def cla

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

2022-06-30 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. Hello @Jim! We are developing the P extension, are you still maintaining this patch? Or would you mind co-development together? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95588/new/ https://reviews.llvm.org/D95588 __

[PATCH] D128604: [RISCV] Support Zbpbo extension

2022-07-02 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 441872. sunshaoce added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang/lib/Sema/Sema

[PATCH] D108189: [RISCV] Support experimental 'P' extension 0.9.11

2022-07-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 441925. sunshaoce added a comment. Support for P extension version 0.9.11 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108189/new/ https://reviews.llvm.org/D108189 Files: clang/test/Driver/riscv-arch.c

[PATCH] D128604: [RISCV] Support Zbpbo extension

2022-07-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 441931. sunshaoce added a comment. Rebase on D99158 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clang/include/clang/B

[PATCH] D121670: [RISCV] Add zihintntl instructions

2022-03-15 Thread Shao-Ce SUN via Phabricator via cfe-commits
s updated this revision to Diff 415703. s added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Add preprocessor test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121670/new/ https://reviews.llvm.org/D121670 File

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-03 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 405605. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files: clang/include/clang/Basic

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-04 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. In D93298#3296515 , @luismarques wrote: > Assuming this will be merged soon, do you want to submit a backport request > for the 14.0 branch? Yes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-04 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 405989. achieveartificialintelligence marked 3 inline comments as done. achieveartificialintelligence added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-04 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 405997. achieveartificialintelligence added a comment. Amend tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files: clang/include/clang

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-10 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 407482. achieveartificialintelligence marked 2 inline comments as done. achieveartificialintelligence added a comment. Address comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-10 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:555 +def GPRF64 : RegisterClass<"RISCV", [f64], 64, (add GPR)>; +def GPRPF64 : RegisterClass<"RISCV", [f64], 64, (add +X10_PD, X12_PD, X14_PD, X16_PD,

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.td:557 + +let RegInfos = RegInfoByHwMode<[RV64], [RegInfo<64, 64, 64>]> in +def GPRPF64 : RegisterClass<"RISCV"

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 408310. achieveartificialintelligence added a comment. Ping & Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112774/new/ https://reviews.llvm.org/D112774 Files: clang/include/cla

[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

2022-02-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 408319. achieveartificialintelligence marked 4 inline comments as done. achieveartificialintelligence added a comment. Address @craig.topper's comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[PATCH] D119846: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`

2022-02-15 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: grosbach, Eugene.Zelenko, asb, jrtc27, craig.topper. Herald added subscribers: ayermolo, sdasgup3, wenzhicui, wrengr, Chia-hungDuan, dcaballe, cota, teijeong, frasercrmck, rdzhabarov, tatianashp, m

[PATCH] D119846: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`

2022-02-15 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe25c06cc5bd: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter` (authored by achieveartificialintelligence). Repository: rG LLV

[PATCH] D119846: [NFC][MC] remove unused argument `MCRegisterInfo` in `MCCodeEmitter`

2022-02-15 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. In D119846#3325334 , @skan wrote: > @achieveartificialintelligence Please explain why a patch is reverted in the > commit message next time. OK, thanks for your guidance! Repository: rG LLVM Github Mon

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-17 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. achieveartificialintelligence marked an inline comment as done. Closed by commit rG7798ecca9c3d: [RISCV] add the MC layer support of Zfinx extension (authored by achiev

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2022-02-17 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Thanks all! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D108189: [RISCV] Support experimental 'P' extension 0.9.11

2022-07-10 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 443552. sunshaoce added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108189/new/ https://reviews.llvm.org/D108189 Files: clang/test/Driver/riscv-arch.c clang/test/Preprocessor/riscv-ta

[PATCH] D128604: [RISCV] Support Zbpbo extension v0.9.11

2022-07-10 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 443555. sunshaoce added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D128604/new/ https://reviews.llvm.org/D128604 Files: clang/include/clang/Basic/BuiltinsRISCV.def clang/lib/Sema/Sema

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

2022-07-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. In D95588#3641900 , @Jim wrote: > In D95588#3622052 , @sunshaoce wrote: > >> Hello @Jim! We are developing the P extension, are you still maintaining >> this patch? Or would you mind co-d

[PATCH] D125157: [RISCV][NFC] Add more tests for clang driver.

2022-05-08 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added inline comments. Comment at: clang/test/Driver/riscv-arch.c:583 +// RV32-ZHINX-BADVERS: unsupported version number 0.1 for extension 'zhinx' \ No newline at end of file Add a newline here. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2021-02-01 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Herald added a subscriber: vkmr. Ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://list

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2021-09-15 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 372863. achieveartificialintelligence added a comment. support zfinx-1.0-rc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/lib/Targ

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2021-09-15 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 372866. achieveartificialintelligence added a comment. Updating D93298 : [RISCV] add the MC layer support of Zfinx extension Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D109799: [RISCV] add Half-precision test for load/store

2021-09-16 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 373129. achieveartificialintelligence added a comment. add Half-precision test for segment load/store Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109799/new/ https://reviews.llvm.org/D10

[PATCH] D109799: [RISCV] add Half-precision test for load/store

2021-09-17 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 373161. achieveartificialintelligence added a comment. add more Half-precision tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109799/new/ https://reviews.llvm.org/D109799 Files: cl

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2021-09-17 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 373170. achieveartificialintelligence added a comment. fix CI error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/lib/Target/RISCV

[PATCH] D109799: [RISCV] add Half-precision test for clang

2021-09-21 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 374095. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109799/new/ https://reviews.llvm.org/D109799 Files: clang/test/CodeGen/RISCV/

[PATCH] D109799: [RISCV] add Half-precision test for clang

2021-09-21 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence added a comment. In D109799#3008067 , @craig.topper wrote: > This patch is really large and touches tests for integer operations. Can you > just pre-commit the removal of lines with just comment characters. No need to > re

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2021-09-21 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence added a comment. ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[PATCH] D109799: [RISCV] add Half-precision test for clang

2021-09-21 Thread Shao-Ce Sun via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe247fed23b92: [RISCV] add Half-precision test for clang (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2021-09-22 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 374131. achieveartificialintelligence added a comment. Address @jrtc27 's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 Files: llvm/l

[PATCH] D97138: [Driver] replace argc_ with argc

2021-02-21 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: MaskRay, jhenderson, aganea, richard.barton.arm, sameeranjoshi. Herald added a reviewer: awarzynski. achieveartificialintelligence requested review of this revision. Herald added a project: clang. H

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

2021-02-22 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 325609. achieveartificialintelligence retitled this revision from "[Driver] replace argc_ with argc" to "[clang][flang] Improve the consistency of the code-base". achieveartificialintelligence edited the summary of this revision. achievea

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

2021-02-22 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence added a comment. In D97138#2578563 , @awarzynski wrote: > Thank you for submitting this @achieveartificialintelligence ! > > The aim of these changes is to improve the consistency of the code-base with > respect to the coding

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

2021-02-25 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 326313. achieveartificialintelligence edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97138/new/ https://reviews.llvm.org/D97138 Files: clang/tools/driver/driver.cpp flang/tools/flang-drive

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

2021-02-25 Thread Shao-Ce Sun via Phabricator via cfe-commits
achieveartificialintelligence marked an inline comment as done. achieveartificialintelligence added a comment. Thanks @aganea. And I have a question that, should I use `argc` & `argv` or `argC` & `argV` in the flang part now ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97138/new/ ht

[PATCH] D97138: [clang][flang] Improve the consistency of the code-base

2021-02-25 Thread Shao-Ce Sun via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGad14ccc8c22e: [clang][flang] Improve the consistency of the code-base (authored by achieveartificialintelligence). Repository: rG LLVM Github Mono

[PATCH] D111866: [RISCV] Support Zfhmin extension

2021-10-25 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 382195. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files: clang/test/Driver/riscv-a

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2021-10-26 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence marked 6 inline comments as done. achieveartificialintelligence added inline comments. Comment at: llvm/lib/Target/RISCV/Disassembler/RISCVDisassembler.cpp:164 +static DecodeStatus DecodeGPRF16RegisterClass(MCInst &Inst, uint64_t RegNo, +

[PATCH] D111866: [RISCV] Support Zfhmin extension

2021-10-28 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 383040. achieveartificialintelligence added a comment. Address @asb 's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files: clang/te

[PATCH] D112774: Support k-ext clang intrinsics

2021-10-28 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: HsiangKai, kito-cheng, craig.topper, jrtc27, luismarques, asb. Herald added subscribers: frasercrmck, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer

[PATCH] D111866: [RISCV] Support Zfhmin extension

2021-11-02 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 384337. achieveartificialintelligence added a comment. Address @asb 's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files: clang/t

[PATCH] D111866: [RISCV] Support Zfhmin extension

2021-11-02 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence marked 4 inline comments as done. achieveartificialintelligence added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 _

[PATCH] D111866: [RISCV] Support Zfhmin extension

2021-11-04 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 384729. achieveartificialintelligence added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files: clang/test/Driver/riscv-a

[PATCH] D111866: [RISCV] Support Zfhmin extension

2021-11-05 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 385121. achieveartificialintelligence added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111866/new/ https://reviews.llvm.org/D111866 Files: clang/test/Driver/riscv-arch

[PATCH] D111866: [RISCV] Support Zfhmin extension

2021-11-05 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c3d7184b435: [RISCV] Support Zfhmin extension (authored by achieveartificialintelligence). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D111866: [RISCV] Support Zfhmin extension

2021-11-05 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. In D111866#3111243 , @asb wrote: > LGTM, modulo one tiny nit on a comment. Thanks! Thank you for your detailed suggestions! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[PATCH] D93298: [RISCV] add the MC layer support of Zfinx extension

2021-11-14 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93298/new/ https://reviews.llvm.org/D93298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D114408: Fold a lot of ffixed_x if judgments

2021-11-22 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence created this revision. achieveartificialintelligence added reviewers: simoncook, asb, lenary, luismarques. Herald added subscribers: frasercrmck, apazos, sameer.abuasal, s.egerton, Jim, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng,

[PATCH] D114408: Fold a lot of ffixed_x if judgments

2021-11-22 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 389091. achieveartificialintelligence added a comment. Fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114408/new/ https://reviews.llvm.org/D114408 Files: clang/lib/Driver/ToolChains/

[PATCH] D114408: Fold a lot of ffixed_x if judgments

2021-11-29 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence abandoned this revision. achieveartificialintelligence added a comment. In D114408#3148311 , @jrtc27 wrote: > This has clearly not been tested whatsoever, it’s totally broken, the > preprocessor does not work like that Than

[PATCH] D113237: [RISCV] Support Zifencei extension

2021-12-05 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence updated this revision to Diff 391951. achieveartificialintelligence added a comment. Herald added subscribers: cfe-commits, jdoerfert, rupprecht, emaste, qcolombet. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Herald added a project: clang. U

[PATCH] D113237: [RISCV] Support I extension version 2.1

2021-12-05 Thread Shao-Ce SUN via Phabricator via cfe-commits
achieveartificialintelligence added a comment. In D113237#3124232 , @luismarques wrote: > In D113237#3124188 , @luismarques > wrote: > >> Should we also support `fence.i` with RVI 2.0, without zifencei? > > Here

[PATCH] D95588: [RISCV] Implement the MC layer support of P extension

2022-10-24 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoP.td:599 + Sched<[]>; +def UKSTSA32 : RVPBinary<0b1110001, 0b011, "ukstsa32">, + Sched<[]>; `0b011` should be `0b010`. https://github.com/riscv/riscv-p-s

[PATCH] D121670: [RISCV] Add zihintntl instructions

2022-08-21 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7167a4207ee2: [RISCV] Add zihintntl instructions (authored by sunshaoce). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D127589: [RISCV] Compatible with more RISCV related ld in the test

2022-06-12 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce created this revision. Herald added subscribers: VincentWu, luke957, vkmr, frasercrmck, evandro, luismarques, apazos, sameer.abuasal, s.egerton, Jim, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, jrtc27, shiva0217, kito-cheng, niosHD, s

[PATCH] D127589: [RISCV] Compatible with more RISCV related ld in the test

2022-06-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 436469. sunshaoce added a comment. Address @StephenFan's comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127589/new/ https://reviews.llvm.org/D127589 Files: clang/test/Driver/riscv64-toolchain.c I

[PATCH] D127684: [NFC] Use `https` instead of `http` in the urls

2022-06-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce created this revision. Herald added subscribers: libc-commits, libcxx-commits, jsji, Enna1, bzcheeseman, kosarev, jsilvanus, mattd, gchakrabarti, hsmhsm, ThomasRaoux, pmatos, asb, ayermolo, awarzynski, sdasgup3, asavonic, carlosgalvezp, jeroen.dobbelaere, abrachet, wenzhicui, wrengr, C

[PATCH] D127684: [NFC] Use `https` instead of `http` in the `LLVM.org` URLs

2022-06-14 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce abandoned this revision. sunshaoce added a comment. Thanks for comments! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D127684/new/ https://reviews.llvm.org/D127684 ___ cfe-commits mailing list

[PATCH] D127589: [Driver][test] Make RISCV tests robust with PATH=

2022-06-15 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe180cc5ff1a1: [Driver][test] Make RISCV tests robust with PATH= (authored by sunshaoce). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D121670: [RISCV] Add zihintntl instructions

2022-06-20 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 438563. sunshaoce added a comment. Herald added a subscriber: shiva0217. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121670/new/ https://reviews.llvm.org/D121670 Files: clang/test/Preprocessor/ris

[PATCH] D128604: [WIP][RISCV] Support Zbpbo extension

2022-06-26 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce created this revision. sunshaoce added reviewers: asb, craig.topper, jrtc27, Jim, luismarques, kito-cheng, frasercrmck. Herald added subscribers: VincentWu, luke957, StephenFan, vkmr, evandro, apazos, sameer.abuasal, s.egerton, benna, psnobl, jocewei, PkmX, the_o, brucehoult, MartinMos

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-14 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. Any other opinions? If not, I will land it later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/ https://reviews.llvm.org/D145883 ___ cfe-commits mailing list cfe-co

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-14 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 505363. sunshaoce added a comment. Address @MaskRay's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/ https://reviews.llvm.org/D145883 Files: clang/lib/Driver/ToolChains/Flang.cpp flang

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-15 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. sunshaoce marked an inline comment as done. Closed by commit rG36278b735fa1: [Flang][RISCV] Emit target features for RISC-V (authored by sunshaoce). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-16 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added inline comments. Comment at: flang/test/Driver/code-gen-rv64.f90:1 +! Test -emit-obj (RISC-V 64) + awarzynski wrote: > mamrami wrote: > > Hi :) > > It seems like the test fails: > > https://buildkite.com/llvm-project/premerge-checks/builds/141302

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-19 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a subscriber: DavidSpickett. sunshaoce added inline comments. Comment at: flang/test/Driver/code-gen-rv64.f90:1 +! Test -emit-obj (RISC-V 64) + mamrami wrote: > sunshaoce wrote: > > awarzynski wrote: > > > mamrami wrote: > > > > Hi :) > > > > It s

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce created this revision. sunshaoce added reviewers: awarzynski, klausler, clementval, sscalpone. Herald added a project: All. sunshaoce requested review of this revision. Herald added subscribers: cfe-commits, MaskRay. Herald added a project: clang. Fix issue #61260 Repository: rG LLVM

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504359. sunshaoce added a comment. Add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 Files: clang/lib/Driver/Types.cpp flang/test/Driver/f03-suffix.f03

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. Before $ /home/sunshaoce/dev/llvm-project/build/bin/flang-new /home/sunshaoce/dev/llvm-project/build/temp.f03 -flang-experimental-exec -o temp.out -### flang-new version 17.0.0 (https://github.com/llvm/llvm-project.git 890e6c871d31dca9e461c01118cf25fb303b9cad)

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504360. sunshaoce added a comment. Remove -flang-experimental-exec Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 Files: clang/lib/Driver/Types.cpp flang/test/

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504362. sunshaoce added a comment. Address @awarzynski's comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 Files: clang/lib/Driver/Types.cpp flang/test/Dr

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504363. sunshaoce marked 2 inline comments as done. sunshaoce added a comment. Sorry, I just missed a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 Files

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. sunshaoce marked an inline comment as done. Closed by commit rG171794de533b: [Flang] Allow compile *.f03, *.f08 file (authored by sunshaoce). Repository: rG LLVM Git

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce reopened this revision. sunshaoce added a comment. This revision is now accepted and ready to land. Sorry! My previous tests were not comprehensive enough, which resulted in failures in the MSVC environment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504372. sunshaoce added a comment. Fix the issue of failing in the MSVC environment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llvm.org/D145845 Files: clang/lib/Driver/Types

[PATCH] D145845: [Flang] Allow compile *.f03, *.f08 file

2023-03-11 Thread Shao-Ce SUN via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGb1fdcd5fbc09: [Flang] Allow compile *.f03, *.f08 file (authored by sunshaoce). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145845/new/ https://reviews.llv

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-12 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce created this revision. sunshaoce added reviewers: awarzynski, klausler, clementval, sscalpone, craig.topper, jrtc27, kito-cheng. Herald added subscribers: VincentWu, vkmr, evandro, luismarques, sameer.abuasal, s.egerton, Jim, benna, psnobl, PkmX, rogfer01, shiva0217, simoncook, arichar

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504548. sunshaoce added a comment. Based on everyone's comments, I merged the test into `target-cpu-features.f90` and only kept the generic `-target-feature`. At the same time, I removed the `switch (TC.getArch())` and passed the test on x86 and RISC-V 64.

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504616. sunshaoce added a comment. Add test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/ https://reviews.llvm.org/D145883 Files: clang/lib/Driver/ToolChains/Flang.cpp flang/test/Driver/code-

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504672. sunshaoce marked an inline comment as done. sunshaoce added a comment. Address @awarzynski's comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/ https://reviews.llvm.org/D145883

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504695. sunshaoce added a comment. Add `REQUIRES` in tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/ https://reviews.llvm.org/D145883 Files: clang/lib/Driver/ToolChains/Flang.cpp flang/te

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added inline comments. Comment at: flang/test/Driver/code-gen-rv64.f90:12 + +! CHECK: Flags: 0x5, RVC, double-float ABI +end program awarzynski wrote: > awarzynski wrote: > > For those of us less familiar with RISC-V - could you explain what's > > sign

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce marked 5 inline comments as done. sunshaoce added inline comments. Comment at: flang/test/Driver/target-cpu-features.f90:33 ! RUN: -o /dev/null -S %s 2>&1 | FileCheck %s -check-prefix=CHECK-INVALID-CPU ! RUN: %flang_fc1 -triple aarch64-linux-gnu -target-feature +sup

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 504756. sunshaoce marked 2 inline comments as done. sunshaoce added a comment. Add `target-cpu-features-invalid.f90` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145883/new/ https://reviews.llvm.org/D145883

[PATCH] D145883: [Flang][RISCV] Emit target features for RISC-V

2023-03-13 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added inline comments. Comment at: flang/test/Driver/code-gen-rv64.f90:7 +! RUN: %flang_fc1 -triple riscv64-unknown-linux-gnu \ +! RUN: -target-feature +d -target-feature +c -emit-obj %s -o %t.o +! RUN: llvm-readelf -h %t.o | FileCheck %s awarzynski w

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

2023-02-07 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce created this revision. sunshaoce added reviewers: rovka, kiranchandramohan, Leporacanthicus, awarzynski, sscalpone, liaolucy. Herald added projects: Flang, All. sunshaoce requested review of this revision. Herald added subscribers: cfe-commits, jdoerfert, MaskRay. Herald added a project:

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

2023-02-07 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. In D143478#4109479 , @awarzynski wrote: > Thanks for working on this! Before diving any deeper > > - Does LLVM Flang require `flang-new -fc1as`? > - If yes, why can't Flang and Clang share it? > > For better visibility, I sugge

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

2023-02-07 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce added a comment. In D143478#4109412 , @clementval wrote: > There should be some tests. I'm not sure how to check the generated binaries, can you provide a test case for reference? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

2023-02-07 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce updated this revision to Diff 495522. sunshaoce added a comment. Add a test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143478/new/ https://reviews.llvm.org/D143478 Files: clang/include/clang/Driver/Options.h clang/include/clang/Dr

[PATCH] D143478: [RFC][Flang][driver] Try to support `flang -fc1as`

2023-02-08 Thread Shao-Ce SUN via Phabricator via cfe-commits
sunshaoce abandoned this revision. sunshaoce added a comment. A better implementation is in D143572 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D143478/new/ https://reviews.llvm.org/D143478 _

  1   2   >