[PATCH] D150733: [clang] Convert remaining OpenMP tests to opaque pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG8be4bd16ca41: [clang] Convert remaining OpenMP tests to opaque pointers (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150733/new/

[PATCH] D148089: [clang][CodeGen] Break up TargetInfo.cpp [1/8]

barannikov88 updated this revision to Diff 523153. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148089/new/ https://reviews.llvm.org/D148089 Files: clang/lib/CodeGen/TargetInfo.cpp Index: clang/lib/CodeGen

[PATCH] D148090: [clang][CodeGen] Break up TargetInfo.cpp [2/8]

barannikov88 updated this revision to Diff 523155. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148090/new/ https://reviews.llvm.org/D148090 Files: clang/lib/CodeGen/TargetInfo.cpp Index: clang/lib/CodeGen/

[PATCH] D148091: [clang][CodeGen] Break up TargetInfo.cpp [3/8]

barannikov88 updated this revision to Diff 523157. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148091/new/ https://reviews.llvm.org/D148091 Files: clang/lib/CodeGen/TargetInfo.cpp Index: clang/lib/CodeGen

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/8]

barannikov88 updated this revision to Diff 523158. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148092/new/ https://reviews.llvm.org/D148092 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Target

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/8]

barannikov88 updated this revision to Diff 523159. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148093/new/ https://reviews.llvm.org/D148093 Files: clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/TargetInfo.

[PATCH] D150178: [clang][CodeGen] Break up TargetInfo.cpp [6/8]

barannikov88 updated this revision to Diff 523160. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150178/new/ https://reviews.llvm.org/D150178 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Target

[PATCH] D150215: [clang][CodeGen] Break up TargetInfo.cpp [7/8]

barannikov88 updated this revision to Diff 523161. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150215/new/ https://reviews.llvm.org/D150215 Files: clang/lib/CodeGen/TargetInfo.cpp clang/lib/CodeGen/Target

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523163. barannikov88 added a comment. Rebase & ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-

[PATCH] D150829: [clang] Convert several tests to opaque pointers

barannikov88 created this revision. barannikov88 added a reviewer: nikic. Herald added a subscriber: StephenFan. Herald added a project: All. barannikov88 requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo

[PATCH] D150829: [clang] Convert several tests to opaque pointers

barannikov88 added a comment. These did require some intellectual work. I've noted changes that might be worth noticing. Comment at: clang/test/CodeGenCXX/2011-12-19-init-list-ctor.cpp:22 +// CHECK: store i32 0, ptr @arr +// CHECK: call void @_ZN1AC1EPKc(ptr {{[^,]*}} geteleme

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523227. barannikov88 added a comment. Move complexTempStructure to its only user (PPC.cpp) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/Us

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523230. barannikov88 added a comment. Add a virtual destructor to DefaultABIInfo to pin the vtable to a cpp file Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523232. barannikov88 added a comment. Update BUILD.gn Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clan

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/8]

barannikov88 updated this revision to Diff 523235. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148093/new/ https://reviews.llvm.org/D148093 Files: clang/lib/CodeGen/ABIInfo.h clang/lib/CodeGen/TargetInfo.

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523236. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.rst clang/docs/tools/clang-formatt

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 523240. barannikov88 added a comment. Undo remaining unintended formatting changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManua

[PATCH] D150829: [clang] Convert several tests to opaque pointers

This revision was automatically updated to reflect the committed changes. Closed by commit rG0bf5f632ed53: [clang] Convert several tests to opaque pointers (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150829/new/ https:/

[PATCH] D150887: [clang] Convert a few tests to opaque pointers

barannikov88 added inline comments. Comment at: clang/test/CodeGenCXX/const-init-cxx11.cpp:353 }; - // CHECK: @_ZN14VirtualMembersL13sGlobalMemoryE = internal global { i8** } { i8** getelementptr inbounds ({ [3 x i8*] }, { [3 x i8*] }* @_ZTVN14VirtualMembers12nsMemoryImplE,

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 added a comment. Kindly ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 added a comment. ping Does the approach look right? Would it be better to put everything into cpp files and only expose a factory method e.g. createMyTargetCodeGenInfo? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https:/

[PATCH] D148954: [clang] Make access to submodules via `iterator_range`

barannikov88 added inline comments. Comment at: clang/include/clang/Basic/Module.h:744-747 - submodule_iterator submodule_begin() { return SubModules.begin(); } - submodule_const_iterator submodule_begin() const {return SubModules.begin();} - submodule_iterator submodule_end()

[PATCH] D148093: [clang][CodeGen] Break up TargetInfo.cpp [5/6]

barannikov88 updated this revision to Diff 518187. barannikov88 added a comment. Upload the correct diff Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148093/new/ https://reviews.llvm.org/D148093 Files: clang/lib/CodeGen/ABIInfo.h clang/lib/Co

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

barannikov88 added a comment. In D148092#4302861 , @efriedma wrote: > Is this supposed to be different from D148093 > ? Yes indeed. I've updated D148093 . Repository: rG LLVM Github

[PATCH] D148089: [clang][CodeGen] Break up TargetInfo.cpp [1/6]

barannikov88 updated this revision to Diff 518188. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148089/new/ https://reviews.llvm.org/D148089 Files: clang/lib/CodeGen/TargetInfo.cpp Index: clang/lib/CodeGen

[PATCH] D148090: [clang][CodeGen] Break up TargetInfo.cpp [2/6]

barannikov88 updated this revision to Diff 518189. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148090/new/ https://reviews.llvm.org/D148090 Files: clang/lib/CodeGen/TargetInfo.cpp Index: clang/lib/CodeGen/

[PATCH] D148091: [clang][CodeGen] Break up TargetInfo.cpp [3/6]

barannikov88 updated this revision to Diff 518190. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148091/new/ https://reviews.llvm.org/D148091 Files: clang/lib/CodeGen/TargetInfo.cpp Index: clang/lib/CodeGen

[PATCH] D148092: [clang][CodeGen] Break up TargetInfo.cpp [4/6]

barannikov88 updated this revision to Diff 518191. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148092/new/ https://reviews.llvm.org/D148092 Files: clang/lib/CodeGen/TargetInfo.cpp Index: clang/lib/CodeGen

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 updated this revision to Diff 518199. barannikov88 added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/lib/CodeGen/ABIInfo.cpp clang/lib/CodeGen/ABIInfoIm

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 added a comment. Thank you all for taking a look! In D148094#4296346 , @aaron.ballman wrote: > I did not verify that the refactoring didn't change functionality, but > spot-checking did not find any differences. In D148094#4302879

[PATCH] D148094: [DRAFT][clang][CodeGen] Break up TargetInfo.cpp [6/6]

barannikov88 updated this revision to Diff 518264. barannikov88 added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. - Update references to modified files in non-code files - Add LLVM_LIBRARY_VISIBILITY to classes in header files Repository: rG LLVM Github Mo

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

barannikov88 added inline comments. Comment at: clang-tools-extra/test/clang-tidy/checkers/cppcoreguidelines/pro-type-vararg.cpp:55 void ignoredBuiltinsTest() { - (void)__builtin_assume_aligned(0, 8); (void)__builtin_constant_p(0); The test should not be re

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

barannikov88 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7986 + +if (!firstArgType->isAnyPointerType()) { + QualType expectedType = Context.getPointerType(firstArgType); barannikov88 wrote: > Instead of directly checking for the po

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

barannikov88 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7982 DefaultFunctionArrayLvalueConversion(FirstArg); if (FirstArgResult.isInvalid()) return true; This check is likely also done by `checkBuiltinArgument`. ===

[PATCH] D93031: Enable fexec-charset option

barannikov88 added a comment. @abhina.sreeskantharajan What is the status of this patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93031/new/ https://reviews.llvm.org/D93031 ___ cfe-commits mailing l

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

barannikov88 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7985 return true; TheCall->setArg(0, FirstArgResult.get()); } This looks suspicious to me, but I'm no clang expert. Is it safe to ignore casts inserted by checkBuiltinA

[PATCH] D93031: Enable fexec-charset option

barannikov88 added a comment. In D93031#4309546 , @abhina.sreeskantharajan wrote: > In D93031#4308764 , @barannikov88 > wrote: > >> @abhina.sreeskantharajan >> What is the status of this patch? > > Hello, I was wa

[PATCH] D148767: Restore CodeGen/LowLevelType

barannikov88 added a comment. Adding CodeGen dependency to MCTargetDesc layer does not seem right. Why is it necessary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148767/new/ https://reviews.llvm.org/D148767 ___

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

barannikov88 added a comment. In D148767#4311589 , @chapuni wrote: > In D148767#4311564 , @barannikov88 > wrote: > >> Adding CodeGen dependency to MCTargetDesc/AsmParser/Disassembler does not >> seem right. Why

[PATCH] D149514: Check if First argument in _builtin_assume_aligned_ is of pointer type

barannikov88 added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:7979-7986 { ExprResult FirstArgResult = DefaultFunctionArrayLvalueConversion(FirstArg); -if (FirstArgResult.isInvalid()) +if (checkBuiltinArgument(*this, TheCall, 0)) r

[PATCH] D148767: Restore CodeGen/LowLevelType from `Support`

barannikov88 added a comment. In D148767#4316464 , @chapuni wrote: > In D148767#4312692 , @barannikov88 > wrote: > >> Sorry, I don't follow. They may theoretically depend on anything. Why >> CodeGen/CodeGenTypes

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 added a comment. @efriedma Thank you for all your reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 ___ cfe-commits mailing list cfe-commits

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

barannikov88 added a comment. In D151047#4396739 , @Sedeniono wrote: > Oh damn, I executed `arc diff --update D151047` on the main branch instead of > my own local branch... Sorry. > Can I somehow revert that? Or should I simply use the "abandon review"

[PATCH] D151047: [clang-format] Fix indentation for selective formatting.

barannikov88 added inline comments. Comment at: clang/lib/Format/UnwrappedLineFormatter.cpp:169-170 /// The indent in characters for each level. + /// It remembers the indent of previous lines (that are not PP directives) of + /// equal or lower levels. This is used to ali

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 added a comment. Please use clang-format on the modified lines. Comment at: clang/lib/CodeGen/CGBuilder.h:170 Address CreateElementBitCast(Address Addr, llvm::Type *Ty, const llvm::Twine &Name = "") { +return Address(Addr.getP

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 accepted this revision. barannikov88 added a comment. This revision is now accepted and ready to land. LGTM with CI fixed, thanks. I'd like @nikic to also take a look though. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/ ht

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 added a comment. I guess you need to rebase onto 066fb7a5 at least. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D152321/new/ https://reviews.llvm.org/D152321

[PATCH] D153008: [RISCV] Allow slash-star comments in instruction operands

barannikov88 added a comment. Herald added a subscriber: wangpc. Does the test have to be a C source? Why not just plain asm (fed into llvm-mc)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153008/new/ https://reviews.llvm.org/D153008 ___

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 requested changes to this revision. barannikov88 added a comment. This revision now requires changes to proceed. @JOE1994 Please run the testsuite locally (`ninja check-clang`), there is at least one test that crashes. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/ItaniumCXXABI.cpp:2552-2554 auto AddrAS = addr ? addr->getType()->getPointerAddressSpace() : 0; - auto AddrInt8PtrTy = - AddrAS ? CGF.Int8Ty->getPointerTo(AddrAS) : CGF.Int8PtrTy; + auto AddrPtrTy = +

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

barannikov88 added a comment. In D152321#4428398 , @JOE1994 wrote: > With the updated revision, I don't see new test failures from `ninja > check-clang` & `ninja check-llvm` & `ninja check-clang-unit` & `ninja > check-llvm-unit` . Thank you, it was my

[PATCH] D152321: [clang] Replace use of Type::getPointerTo() (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f4d48d73d39: [clang] Replace use of Type::getPointerTo() (NFC) (authored by JOE1994, committed by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D150215: [clang][CodeGen] Break up TargetInfo.cpp [7/8]

barannikov88 updated this revision to Diff 532357. barannikov88 added a comment. Herald added a subscriber: wangpc. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150215/new/ https://reviews.llvm.org/D150215 Files: clang/lib/CodeGen/Target

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

barannikov88 updated this revision to Diff 532358. barannikov88 added a comment. Herald added a subscriber: wangpc. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148094/new/ https://reviews.llvm.org/D148094 Files: clang/docs/UsersManual.r

[PATCH] D150215: [clang][CodeGen] Break up TargetInfo.cpp [7/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG63534779b4ef: [clang][CodeGen] Break up TargetInfo.cpp [7/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D148094: [clang][CodeGen] Break up TargetInfo.cpp [8/8]

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG992cb98462ab: [clang][CodeGen] Break up TargetInfo.cpp [8/8] (authored by barannikov88). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST A

[PATCH] D147962: [RFC][clang] Pull experimental targets' info out of TargetInfo.cpp (NFC)

barannikov88 abandoned this revision. barannikov88 added a comment. Abandoning as D148094 landed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147962/new/ https://reviews.llvm.org/D147962 ___

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

barannikov88 accepted this revision. barannikov88 added a comment. This needs to be rebased, there will be conflicts with 992cb984 . Comment at: clang/lib/CodeGen/CGBlocks.cpp:1264 -addr = Builder.Creat

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:1262-1263 auto &byrefInfo = getBlockByrefInfo(variable); addr = Address(Builder.CreateLoad(addr), Int8Ty, byrefInfo.ByrefAlignment); - -addr = Builder.CreateElementBitCast(addr, byrefInfo

[PATCH] D153196: [clang] Replace uses of CGBuilderTy::CreateElementBitCast (NFC)

barannikov88 added inline comments. Comment at: clang/lib/CodeGen/CGBlocks.cpp:1262-1263 auto &byrefInfo = getBlockByrefInfo(variable); addr = Address(Builder.CreateLoad(addr), Int8Ty, byrefInfo.ByrefAlignment); - -addr = Builder.CreateElementBitCast(addr, byrefInfo

[PATCH] D140104: [clang][dataflow] Remove unused argument in getNullability

barannikov88 added inline comments. Comment at: clang/lib/Sema/SemaExpr.cpp:9072 auto GetNullability = [&Ctx](QualType Ty) { +Optional Kind = Ty->getNullability(); This now gives a warning `clang/lib/Sema/SemaExpr.cpp:9072:27: warning: lambda capture 'Ct

<    1   2   3