On Mon, Apr 4, 2016 at 11:33 AM, John McCall via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rjmccall
> Date: Mon Apr 4 13:33:00 2016
> New Revision: 265323
>
> URL: http://llvm.org/viewvc/llvm-project?rev=265323&view=rev
> Log:
> Add a couple of convenience operations to CharUnits
Author: silvas
Date: Wed Apr 6 16:06:52 2016
New Revision: 265601
URL: http://llvm.org/viewvc/llvm-project?rev=265601&view=rev
Log:
Revert "Set the default C standard to C99 when targeting the PS4."
This reverts r265359.
It breaks
- llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast
- llvm-clang-lld-x8
I've had to revert this in r265601 because it was breaking the PS4 bots.
In the future, please keep an eye on them! It's a total bummer leaving them
red for 2 days.
http://lab.llvm.org:8011/waterfall?builder=llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast&builder=llvm-clang-lld-x86_64-scei-ps4-windows
We also have toUppercase in include/clang/Basic/CharInfo.h
-- Sean Silva
On Wed, Apr 6, 2016 at 6:04 PM, Bruno Cardoso Lopes via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: bruno
> Date: Wed Apr 6 20:04:09 2016
> New Revision: 265630
>
> URL: http://llvm.org/viewvc/llvm-project?r
On Wed, Apr 6, 2016 at 6:10 PM, Bruno Cardoso Lopes via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Attempt to fix in r265630.
>
Did you ever fix PATH_MAX?
>
> On Wed, Apr 6, 2016 at 5:51 PM, Bruno Cardoso Lopes <
> bruno.card...@gmail.com> wrote:
>
>> Thanks Hans, taking a look!
>>
>> O
On Wed, Mar 16, 2016 at 7:20 PM, Bruno Cardoso Lopes via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: bruno
> Date: Wed Mar 16 21:20:43 2016
> New Revision: 263686
>
> URL: http://llvm.org/viewvc/llvm-project?rev=263686&view=rev
> Log:
> Reapply [2]: [VFS] Add support for handling pa
On Wed, Apr 6, 2016 at 6:56 PM, Sean Silva wrote:
>
>
> On Wed, Apr 6, 2016 at 6:10 PM, Bruno Cardoso Lopes via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Attempt to fix in r265630.
>>
>
> Did you ever fix PATH_MAX?
>
I've fixed it in r265634.
-- Sean Silva
>
>>
>> On Wed, Apr 6,
Author: silvas
Date: Wed Apr 6 20:58:14 2016
New Revision: 265634
URL: http://llvm.org/viewvc/llvm-project?rev=265634&view=rev
Log:
Don't use PATH_MAX.
This is a SmallVector anyway, and so the exact size doesn't matter.
clang\lib\Frontend\ModuleDependencyCollector.cpp(83) : error C2065: 'PATH_M
On Thu, Apr 7, 2016 at 5:09 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Thu Apr 7 19:09:53 2016
> New Revision: 265756
>
> URL: http://llvm.org/viewvc/llvm-project?rev=265756&view=rev
> Log:
> [modules] Don't write @import in -E output if the cu
Thanks!
-- Sean Silva
On Wed, Apr 13, 2016 at 12:47 AM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Wed Apr 13 02:47:38 2016
> New Revision: 266178
>
> URL: http://llvm.org/viewvc/llvm-project?rev=266178&view=rev
> Log:
> constexpr -> const to appe
On Tue, Apr 19, 2016 at 7:28 AM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> (sorry, accidentally sent this mid-mail)
>
> ../../v8/src/crankshaft/lithium.h:322:45: error: instantiation of variable
> 'v8::internal::LSubKindOperand 128>::cache' required here, but no definition
On Tue, Apr 19, 2016 at 7:28 AM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> (sorry, accidentally sent this mid-mail)
>
> ../../v8/src/crankshaft/lithium.h:322:45: error: instantiation of variable
> 'v8::internal::LSubKindOperand 128>::cache' required here, but no definition
Author: silvas
Date: Fri Apr 22 21:11:16 2016
New Revision: 267262
URL: http://llvm.org/viewvc/llvm-project?rev=267262&view=rev
Log:
[profile] Use cc1 in these tests instead of the driver.
I ran into this when seeing what tests would break if we make a
driver-level decision about whether FEPGO or
Author: silvas
Date: Fri Apr 22 21:13:48 2016
New Revision: 267263
URL: http://llvm.org/viewvc/llvm-project?rev=267263&view=rev
Log:
[profile] Fix another use of the driver.
Follow-on to r267262.
Modified:
cfe/trunk/test/Profile/cxx-indirect-call.cpp
Modified: cfe/trunk/test/Profile/cxx-ind
What was the issue?
On Wed, May 25, 2016 at 12:17 PM, Galina Kistanova via llvm-commits <
llvm-comm...@lists.llvm.org> wrote:
> Hello,
>
> Builder
> http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast
> is back to normal.
> Sorry for the noise.
>
> Thanks
>
> Galina
silvas added subscribers: MaggieYi, phillip.power.
silvas added a comment.
This is looking really good. So based on reading this, a rough sketch of how we
can expand this to PGO would be something like:
- there is a separate PGO page that has similar structure, but is more tuned
for the PGO use
On Thu, Jun 2, 2016 at 10:19 AM, Vedant Kumar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: vedantk
> Date: Thu Jun 2 12:19:45 2016
> New Revision: 271544
>
> URL: http://llvm.org/viewvc/llvm-project?rev=271544&view=rev
> Log:
> [docs] Add a limitations section to SourceBasedCode
silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.
Overall this LGTM, but let Manuel or one of the other libTooling folks sign off.
Comment at: docs/LibASTMatchersTutorial.rst:46
@@ -45,3 +45,3 @@
cd ~/clang-llvm
On Mon, Jun 6, 2016 at 11:23 AM, Rafael Espindola via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rafael
> Date: Mon Jun 6 13:23:11 2016
> New Revision: 271918
>
> URL: http://llvm.org/viewvc/llvm-project?rev=271918&view=rev
> Log:
> Add a release note about the --build-id change.
silvas added a subscriber: silvas.
silvas added a comment.
> It has no RTTI, so the test would always fail in a non-interesting way.
It does. There is a call to dynamic_cast on lines 20 and 21 of this test. You
can fix this by explicitly adding -frtti I believe.
http://reviews.llvm.org/D21186
silvas added a comment.
In http://reviews.llvm.org/D21186#454497, @silvas wrote:
> > It has no RTTI, so the test would always fail in a non-interesting way.
>
>
> It does. There is a call to dynamic_cast on lines 20 and 21 of this test. You
> can fix this by explicitly adding -frtti I believe.
silvas accepted this revision.
silvas added a reviewer: silvas.
silvas added a comment.
This revision is now accepted and ready to land.
LGTM
http://reviews.llvm.org/D21186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.or
On Mon, Jun 13, 2016 at 5:42 PM, Vedant Kumar via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: vedantk
> Date: Mon Jun 13 19:42:12 2016
> New Revision: 272604
>
> URL: http://llvm.org/viewvc/llvm-project?rev=272604&view=rev
> Log:
> [docs] Coverage: Document the profile merge pool sp
Some of these tables are getting quite mangled somewhere along the line
(email client? mailing list handling? idk). Could you re-send with the
tables also attached or something else that avoids that problem?
-- Sean Silva
On Tue, Jun 14, 2016 at 4:23 PM, Galina Kistanova via cfe-commits <
cfe-co
Thanks!
On Tue, Jun 14, 2016 at 10:30 AM, Vedant Kumar wrote:
> I think David got rid of that limitation.
>
> The related warning in compiler-rt does not reflect this:
>
> PROF_WARN("%%m specifier can only be specified once at the end of
> %s.\n", ...);
>
> Fixed the warning in r272685.
>
> th
-def fpie : Flag<["-"], "fpie">, Group;
+def fpie : Flag<["-"], "fpie">, Group, Flags<[CC1Option]>;
I don't think this is the right solution as "-fpie" doesn't mean the same
thing to the driver and CC1 is sort of confusing (in CC1 it doesn't mean
anything by itself). Can you change the existing `
Author: silvas
Date: Tue Jun 28 19:29:23 2016
New Revision: 274084
URL: http://llvm.org/viewvc/llvm-project?rev=274084&view=rev
Log:
Revert "[PS4] Tighten up a test (noticed in passing)"
This reverts commit r269709.
r262285 changed this deliberately so that the test would not be
sensitive to whi
silvas added a comment.
Some basic comments.
Comment at: include/clang/Driver/Options.td:483
@@ +482,3 @@
+Group, Flags<[DriverOption]>, MetaVarName<"">,
+HelpText<"Generate instrumented code to collect execution counts into
(overridden by LLVM_PROFILE_FILE env var)">;
On Wed, Jun 29, 2016 at 12:09 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hi all!
>
> I'd like to establish a policy for Clang's default language standard (if
> none is specified with -std), as follows:
>
> Clang defaults to the most recent published standard for the
On Wed, Jun 29, 2016 at 12:51 PM, Richard Smith
wrote:
> On Wed, Jun 29, 2016 at 12:30 PM, Sean Silva
> wrote:
>
>>
>>
>> On Wed, Jun 29, 2016 at 12:09 PM, Richard Smith via cfe-commits <
>> cfe-commits@lists.llvm.org> wrote:
>>
>>> Hi all!
>>>
>>> I'd like to establish a policy for Clang's defa
On Wed, Jun 29, 2016 at 1:34 PM, Sean Silva wrote:
>
>
> On Wed, Jun 29, 2016 at 12:51 PM, Richard Smith
> wrote:
>
>> On Wed, Jun 29, 2016 at 12:30 PM, Sean Silva
>> wrote:
>>
>>>
>>>
>>> On Wed, Jun 29, 2016 at 12:09 PM, Richard Smith via cfe-commits <
>>> cfe-commits@lists.llvm.org> wrote:
>
On Thu, Jun 30, 2016 at 3:52 PM, Robinson, Paul
wrote:
>
>
> > -Original Message-
> > From: cfe-commits [mailto:cfe-commits-boun...@lists.llvm.org] On Behalf
> Of
> > Sean Silva via cfe-commits
> > Sent: Tuesday, June 28, 2016 5:29 PM
> > To:
gt; *Subject:* Re: r274084 - Revert "[PS4] Tighten up a test (noticed in
> passing)"
>
>
>
>
>
>
>
> On Thu, Jun 30, 2016 at 3:52 PM, Robinson, Paul
> wrote:
>
>
>
> > -Original Message-
> > From: cfe-commits [mailto:cfe-commits-bo
silvas added inline comments.
Comment at: lib/Driver/Tools.cpp:3560
@@ +3559,3 @@
+if (PGOTrainArg->getOption().matches(options::OPT_fpgo_train_EQ)) {
+ if (StringRef(PGOTrainArg->getValue()) == "source-cfg")
+CmdArgs.push_back("-fprofile-instrument=clang");
-
On Sat, Jul 2, 2016 at 1:57 PM, Xinliang David Li
wrote:
>
>
> On Fri, Jul 1, 2016 at 4:32 PM, Sean Silva wrote:
>
>> silvas added inline comments.
>>
>>
>> Comment at: lib/Driver/Tools.cpp:3560
>> @@ +3559,3 @@
>> +if (PGOTrainArg->getOption().matches(options::OPT_fpgo_trai
On Sat, Jul 2, 2016 at 7:38 PM, Xinliang David Li
wrote:
> Sanitizers are different IMO. Different santizers are rather independent,
> and there is no such thing as -fsantize to mean -fsantize=all
>
> For PGO, in most of the cases, users do not need to care about the
> sub-options implied -- by d
Btw we do have some advice for these situations in the programmer's manual:
http://llvm.org/docs/CodingStandards.html#don-t-use-default-labels-in-fully-covered-switches-over-enumerations
-- Sean Silva
On Thu, Jul 7, 2016 at 4:24 AM, Simon Pilgrim via cfe-commits <
cfe-commits@lists.llvm.org> wrot
On Fri, Jul 8, 2016 at 10:22 AM, Xinliang David Li
wrote:
>
>
> On Sun, Jul 3, 2016 at 1:50 PM, Sean Silva wrote:
>
>>
>>
>> On Sat, Jul 2, 2016 at 7:38 PM, Xinliang David Li
>> wrote:
>>
>>> Sanitizers are different IMO. Different santizers are rather
>>> independent, and there is no such thin
silvas added a subscriber: cfe-commits.
silvas added a comment.
Actually add cfe-commits. Oops.
Thanks to Chandler for pointing out I had added llvm-commits instead.
http://reviews.llvm.org/D21954
___
cfe-commits mailing list
cfe-commits@lists.llvm
silvas added a comment.
In http://reviews.llvm.org/D21823#479418, @davidxl wrote:
> I should have brought it up earlier, but I forgot.I think a better (and
> simpler) proposal is to make -fprofile-generate and -fprofile-use turn on IR
> based PGO.
>
> -fprofile-generate and -fprofile-use op
Author: silvas
Date: Sat Jul 9 19:57:52 2016
New Revision: 275005
URL: http://llvm.org/viewvc/llvm-project?rev=275005&view=rev
Log:
Delete dead code.
We were just setting DisableUnitAtATime to its default value.
Modified:
cfe/trunk/include/clang/Frontend/CodeGenOptions.def
cfe/trunk/lib
silvas added a comment.
Ping.
https://reviews.llvm.org/D21954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.
Once all of David's comments are addressed this LGTM.
Repository:
rL LLVM
https://reviews.llvm.org/D21823
___
cfe-commits mailing list
cfe-com
Author: silvas
Date: Fri Jul 15 21:54:58 2016
New Revision: 275668
URL: http://llvm.org/viewvc/llvm-project?rev=275668&view=rev
Log:
[Driver] Add flags for enabling both types of PGO Instrumentation
The flags:
Enable IR-level instrumentation -fprofile-generate or -fprofile-generate=
When applying
This revision was automatically updated to reflect the committed changes.
Closed by commit rL275668: [Driver] Add flags for enabling both types of PGO
Instrumentation (authored by silvas).
Changed prior to commit:
https://reviews.llvm.org/D21823?vs=64056&id=64222#toc
Repository:
rL LLVM
htt
silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.
Thanks. LGTM.
http://reviews.llvm.org/D17622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listin
silvas added a comment.
Thanks, this is looking good. I have some naming suggestions and nits, but the
overall content of the patch LGTM.
Comment at: include/clang/Driver/CC1Options.td:286
@@ +285,3 @@
+def fprofile_instrument_usepath_EQ :
+Joined<["-"], "fprofile-instrumen
Author: silvas
Date: Mon Feb 29 19:20:15 2016
New Revision: 262285
URL: http://llvm.org/viewvc/llvm-project?rev=262285&view=rev
Log:
Make test more robust.
Really all these tests are checking is that we find a file path. The
behavior when we don't find one will have `"ps4-ld"` in it. We just need
This seems to be causing a substantial amount of warning spew from MSVC:
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/955
I think our recommended "portable" method of using llvm_unreachable is
outside the switch, instead of in the default case:
http://l
silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.
Thanks!
http://reviews.llvm.org/D17737
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
All green on the two latest commits. Thanks!
http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/961
-- Sean Silva
On Mon, Feb 29, 2016 at 6:14 PM, John McCall wrote:
> On Feb 29, 2016, at 5:44 PM, Sean Silva wrote:
> This seems to be causing a substantial
silvas added a comment.
Some comments but otherwise feel free to commit.
Comment at: lib/CodeGen/CodeGenModule.cpp:154
@@ +153,3 @@
+assert(!CodeGenOpts.ProfileInstrumentUsePath.empty() &&
+ "Need to explicitly specify the profile name.");
+auto ReaderOrErr = l
On Tue, Mar 1, 2016 at 10:54 AM, Nico Weber via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> thakis added a comment.
>
> > I think we can do this separately. A "basename" macro is easier for
> programmers to use and no build system change needed.
>
>
> Hm, I would think that adding a flag to
silvas added a subscriber: silvas.
silvas added a comment.
Random question:
> We plan to enable dllimport/dllexport support for the PS4
How are you planning on codegenning them? The same way as we do in our private
branch?
http://reviews.llvm.org/D17775
___
On Tue, Mar 1, 2016 at 1:00 PM, Warren Ristow <
warren_ris...@playstation.sony.com> wrote:
> wristow added a comment.
>
> In http://reviews.llvm.org/D17775#365611, @silvas wrote:
>
> > Random question:
> >
> > > We plan to enable dllimport/dllexport support for the PS4
> >
> >
> > How are you plan
silvas added a comment.
makes sense. can you include a testcase? I assume we are forgetting some sort
of diagnostic without this patch.
Also, if learning about Clang's modules, I would start with `addHeaderInclude`
in lib/Frontend/FrontendActions.cpp. The module map stuff ultimately boils down
silvas added a comment.
This makes sense. LGTM.
http://reviews.llvm.org/D17787
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
silvas accepted this revision.
silvas added a comment.
This revision is now accepted and ready to land.
Nice cleanup. LGTM.
http://reviews.llvm.org/D17794
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/
silvas added a comment.
I agree, David's suggestion has simplified things. This LGTM (with a couple
nits) but I'll let David give the final approval.
Comment at: lib/CodeGen/CodeGenModule.cpp:153
@@ +152,3 @@
+ if (CodeGenOpts.hasProfileClangUse()) {
+assert(!CodeGenOpts.P
silvas added a subscriber: silvas.
silvas added a comment.
Some nits but this looks fine to me. I've been wanting this for a while now.
Comment at: cfe/trunk/lib/Driver/ToolChain.cpp:347
@@ +346,3 @@
+
+if (UseLinker[0] == '/') {
+ // If we're passed -fuse-ld= with what
silvas added inline comments.
Comment at: cfe/trunk/lib/Driver/ToolChain.cpp:352
@@ +351,3 @@
+return UseLinker;
+} else {
+ // If we're passed -fuse-ld= with no argument, or with the argument ld,
Makes sense.
Repository:
rL LLVM
http://revie
silvas added a comment.
Isn't there a `read` call or something that fails down the road? How can it be
silent?
http://reviews.llvm.org/D18011
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
On Fri, Jan 15, 2016 at 1:21 PM, Chris Bieneman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: cbieneman
> Date: Fri Jan 15 15:21:12 2016
> New Revision: 257934
>
> URL: http://llvm.org/viewvc/llvm-project?rev=257934&view=rev
> Log:
> [CMake] Support generation of linker order file
Thanks!
On Tue, Mar 22, 2016 at 9:34 AM, Chris Bieneman wrote:
> Sean,
>
> All good feedback.
>
> Using print_function was done in r257936 with some other feedback from
> Bogner.
>
> The rest of your feedback I believe I have addressed in r264063.
>
> -Chris
>
> On Mar 21, 2016, at 9:21 PM, Sean
silvas added a subscriber: silvas.
silvas added a comment.
This may sound stupid, but: can you benchmark the time it takes to build some
project (that actually uses intrinsics in most translation units, e.g. a game)
with the headers w/ and w/o the doxygen comments to check that all the extra
co
silvas added a comment.
In http://reviews.llvm.org/D15999#331601, @kromanova wrote:
> In http://reviews.llvm.org/D15999#330794, @silvas wrote:
>
> > This may sound stupid, but: can you benchmark the time it takes to build
> > some project (that actually uses intrinsics in most translation units,
silvas added a comment.
In http://reviews.llvm.org/D15999#331512, @kromanova wrote:
> In http://reviews.llvm.org/D15999#330794, @silvas wrote:
>
> > This may sound stupid, but: can you benchmark the time it takes to build
> > some project (that actually uses intrinsics in most translation units,
On Wed, Jan 20, 2016 at 3:14 PM, Eric Christopher
wrote:
>
>
> On Wed, Jan 20, 2016 at 3:12 PM Sean Silva wrote:
>
>> silvas added a comment.
>>
>> In http://reviews.llvm.org/D15999#331601, @kromanova wrote:
>>
>> > In http://reviews.llvm.org/D15999#330794, @silvas wrote:
>> >
>> > > This may so
silvas added a comment.
This needs tests showing that the IR gen/use passes get run. Maybe use
-debug-pass=Structure like test/CodeGen/thinlto_backend.c?
My biggest concern is the naming and user visible parts. I can't come up with
anything better than `-fprofile-ir-instr` TBH. Overall, from a
silvas added inline comments.
Comment at: include/clang/Frontend/CodeGenOptions.def:108
@@ -107,2 +107,3 @@
///< execution counts to use with PGO.
+CODEGENOPT(ProfileIRInstr, 1, 0) ///< IR level code PGO instrumentation and
use.
CODEGENOP
silvas added a comment.
@slingn and I had a discussion offline about the potential names and came up
with some ideas, but none is a clear winner.
Overall, my feeling is that from a user's perspective, the frontend stuff is
probably best referred to as "coverage-based". It's not as clear for the
silvas added a comment.
@bogner btw, did you say that at Apple you guys have a requirement of
supporting existing profdata? I.e. users can pass older profdata to a newer
compiler?
Realistically, it would be nice if our PGO offering defaulted to the IR stuff
(since it seems like it is going to
silvas added a comment.
For the preview of all the changes, can you please put that in a separate patch
from this one?
Repository:
rL LLVM
http://reviews.llvm.org/D15999
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.o
silvas added inline comments.
Comment at: lib/Driver/Tools.cpp:3279
@@ -3278,1 +3278,3 @@
+
+ Args.AddAllArgs(CmdArgs, options::OPT_fprofile_ir_instr);
}
xur wrote:
> mcrosier wrote:
> > I don't think AddAllArgs is what you really want. What if the user
> > sp
silvas added a comment.
In http://reviews.llvm.org/D15829#333902, @davidxl wrote:
> For the longer term, one possible solution is to make FE based
> instrumentation only used for coverage testing which can be turned on
> with -fcoverage-mapping option (currently, -fcoverage-mapping can not
> b
silvas added inline comments.
Comment at: lib/CodeGen/BackendUtil.cpp:440
@@ +439,3 @@
+ if (CodeGenOpts.ProfileIRInstr) {
+// Should not have ProfileInstrGenerate set -- it is for clang
+// instrumentation only.
Then change the existing references in cla
silvas added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:487
@@ +486,3 @@
+ // Opts.ProfileInstrGenerate will be used for Clang instrumentation only.
+ if (!Opts.ProfileIRInstr)
+Opts.ProfileInstrGenerate = Args.hasArg(OPT_fprofile_instr_generate) ||
---
On Mon, Jan 25, 2016 at 12:52 PM, Rong Xu wrote:
> OK. Now I understand what you meant. I was trying to avoid driver changes.
> It seems you are saying I can change the driver to support cc1 options more
> cleanly. This can be done.
>
Great! Sorry for the confusion.
-- Sean Silva
> Thanks,
>
>
On Mon, Jan 25, 2016 at 11:00 AM, Xinliang David Li
wrote:
> On Fri, Jan 22, 2016 at 1:43 PM, Sean Silva wrote:
> > silvas added a comment.
> >
> > In http://reviews.llvm.org/D15829#333902, @davidxl wrote:
> >
> >> For the longer term, one possible solution is to make FE based
> >> instrumentat
silvas added inline comments.
Comment at: lib/Driver/Tools.cpp:5520
@@ +5519,3 @@
+A->claim();
+if ((StringRef(A->getValue(0)) == "-fprofile-ir-instr") &&
+(Args.hasArg(options::OPT_fprofile_instr_generate) ||
This is definitely not the right thing
silvas added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:483
@@ +482,3 @@
+Opts.ProfileIRInstr = true;
+ else
+// Opts.ClangProfInstrGen will be used for Clang instrumentation only.
davidxl wrote:
> silvas wrote:
> > This still isn't
silvas added inline comments.
Comment at: include/clang/Frontend/CodeGenOptions.def:106
@@ -105,3 +105,3 @@
-CODEGENOPT(ProfileInstrGenerate , 1, 0) ///< Instrument code to generate
-///< execution counts to use with PGO.
+CODEGENOPT(Profi
On Thu, Nov 12, 2015 at 9:14 PM, Richard Smith via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: rsmith
> Date: Thu Nov 12 23:14:45 2015
> New Revision: 253012
>
> URL: http://llvm.org/viewvc/llvm-project?rev=253012&view=rev
> Log:
> [modules] When a declaration has non-trivial visibi
On Sat, Nov 14, 2015 at 2:30 PM, Richard Smith
wrote:
> On Nov 13, 2015 7:23 PM, "Sean Silva" wrote:
> >
> >
> >
> > On Thu, Nov 12, 2015 at 9:14 PM, Richard Smith via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
> >>
> >> Author: rsmith
> >> Date: Thu Nov 12 23:14:45 2015
> >> New Revisio
On Mon, Nov 16, 2015 at 7:09 PM, Richard Smith
wrote:
> On Mon, Nov 16, 2015 at 7:00 PM, Sean Silva wrote:
>
>> On Sat, Nov 14, 2015 at 2:30 PM, Richard Smith
>> wrote:
>>
>>> On Nov 13, 2015 7:23 PM, "Sean Silva" wrote:
>>> >
>>> >
>>> >
>>> > On Thu, Nov 12, 2015 at 9:14 PM, Richard Smith vi
On Fri, Nov 20, 2015 at 2:09 PM, Chris Bieneman via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: cbieneman
> Date: Fri Nov 20 16:09:06 2015
> New Revision: 253721
>
> URL: http://llvm.org/viewvc/llvm-project?rev=253721&view=rev
> Log:
> [CMake] Add support for specifying arguments to
In the future can you also attach the data in CSV format?
On Mon, Nov 23, 2015 at 3:46 PM, Galina Kistanova via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Hello everyone,
>
> Below are some buildbot numbers for the last week of 11/15/2015 -
> 11/21/2015.
>
> Thanks
>
> Galina
>
>
>
> Numb
silvas accepted this revision.
silvas added a comment.
Thanks for working on this!
A tiny nit, but otherwise this LGTM.
Comment at: docs/UndefinedBehaviorSanitizer.rst:33
@@ +32,3 @@
+
+Use ``clang++`` to compile and link your program with ``-fsanitize=undefined``
+flag. Make s
On Fri, Dec 4, 2015 at 2:42 PM, John Thompson via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: jtsoftware
> Date: Fri Dec 4 16:42:18 2015
> New Revision: 254785
>
> URL: http://llvm.org/viewvc/llvm-project?rev=254785&view=rev
> Log:
> Added coverage check for extensionless headers,
On Fri, Dec 4, 2015 at 6:04 PM, John Thompson <
john.thompson.jtsoftw...@gmail.com> wrote:
> >Aren't we already rejecting directories in the line `if (type ==
> sys::fs::file_type::directory_file)` above? Why check the filename?
>
> The iterator will walk the directories. That statement just keep
On Fri, Dec 11, 2015 at 11:53 AM, Xinliang David Li via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: davidxl
> Date: Fri Dec 11 13:53:35 2015
> New Revision: 255366
>
> URL: http://llvm.org/viewvc/llvm-project?rev=255366&view=rev
> Log:
> [PGO] Stop using invalid char in instr variab
On Fri, Dec 11, 2015 at 2:05 PM, Ben Langmuir via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: benlangmuir
> Date: Fri Dec 11 16:05:13 2015
> New Revision: 255377
>
> URL: http://llvm.org/viewvc/llvm-project?rev=255377&view=rev
> Log:
> Reapply "[Modules] Fix regression when an elabo
silvas added a comment.
Can you elaborate on why this patch is restricted to unix?
Also, this probably requires some documentation in
http://llvm.org/docs/CMake.html
(we don't really have an analogous page just for clang currently, so the llvm
one is probably the best place right now)
silvas added a comment.
In http://reviews.llvm.org/D15462#309889, @beanz wrote:
> Sean,
>
> The reason for restricting to Unix is two fold. (1) the shell script goop,
> which I can replace with python and (2) I don't have a windows box to test
> on, so I didn't want people to think it worked.
>
silvas added a comment.
Thanks. This LGTM but I'd wait for Duncan or Justin to sign off on it; they're
likely to have more higher-level thoughts.
Comment at: utils/perf-training/perf-helper.py:36
@@ +35,3 @@
+ cmd.extend(findProfrawFiles(args[2]))
+ subprocess.check_call(cmd,
101 - 195 of 195 matches
Mail list logo
