Re: [PATCH] D31702: Append -w when LLVM_ENABLE_WARNINGS is Off.

Can we revert this? In our downstream project we were bitten by this: https://github.com/google/mlir-npcomp/commit/cd7258dbd48bd9254c6741cab2d3f4e36cbd3c84 It seems that now by default anybody that depends on LLVM with CMake will globally get a `-w` passed to their compiler. That doesn't seem lik

Re: r284137 - [ThinLTO] Update doc to include lld (now supported).

Nice to see this land! One nit: Currently, doesn't LLD/ELF ignore -plugin-opt? That will mean that if a user uses the "gold syntax" then LLD will silently ignore it, which isn't good. At the very least, can we issue an error if we see `-plugin-opt jobs=N` and suggest the LLD spelling? Or maybe ju

Re: r290792 - [c++17] Implement P0522R0 as written. This allows a template template argument

On Sat, Dec 31, 2016 at 1:41 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Sat Dec 31 15:41:23 2016 > New Revision: 290792 > > URL: http://llvm.org/viewvc/llvm-project?rev=290792&view=rev > Log: > [c++17] Implement P0522R0 as written. This allows a

Re: r291123 - CodeGen: plumb header search down to the IAS

On Sat, Jan 7, 2017 at 1:27 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > I agree with Eric, I don't think that serializing the structure to > std::cout is the right way to handle this. > > What were you thinking of mocking? Wouldn't you really end up mocking the >

Re: r278882 - If possible, set the stack rlimit to at least 8MiB on cc1 startup, and work

On Fri, Aug 19, 2016 at 4:33 PM, Joerg Sonnenberger via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Fri, Aug 19, 2016 at 03:30:42PM -0700, Richard Smith wrote: > > It typically does; the default stack ulimit is likely tuned for "normal" > > applications that are not expected (by an ISO s

Re: r293065 - Clarify how to forward-declare __llvm_profile symbols.

Thanks! On Wed, Jan 25, 2017 at 8:01 AM, Nico Weber via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: nico > Date: Wed Jan 25 10:01:32 2017 > New Revision: 293065 > > URL: http://llvm.org/viewvc/llvm-project?rev=293065&view=rev > Log: > Clarify how to forward-declare __llvm_profile s

Re: r294401 - Sema: add warning for c++ member variable shadowing

Nice! On Tue, Feb 7, 2017 at 7:30 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Tue Feb 7 21:30:13 2017 > New Revision: 294401 > > URL: http://llvm.org/viewvc/llvm-project?rev=294401&view=rev > Log: > Sema: add warning for c++ member varia

Re: r296554 - [PS4] Set our default dialect to C++11. NFC for other targets.

Nice! -- Sean Silva On Tue, Feb 28, 2017 at 5:01 PM, Paul Robinson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: probinson > Date: Tue Feb 28 19:01:10 2017 > New Revision: 296554 > > URL: http://llvm.org/viewvc/llvm-project?rev=296554&view=rev > Log: > [PS4] Set our default dial

Re: r296554 - [PS4] Set our default dialect to C++11. NFC for other targets.

, even though users already know to pass the right flags and expect to have to). -- Sean Silva > > — > Mehdi > > > > On Feb 28, 2017, at 11:22 PM, Sean Silva via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > Nice! > > -- Sean Silva > > O

Re: r288093 - Use ${:uid} to generate unique MS asm labels, not {:uid}

what is this ${:uid} thing? Could the comment in Sema::GetOrCreateMSAsmLabel explain it? -- Sean Silva On Mon, Nov 28, 2016 at 4:39 PM, Reid Kleckner via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rnk > Date: Mon Nov 28 18:39:37 2016 > New Revision: 288093 > > URL: http://llvm.or

Re: r288093 - Use ${:uid} to generate unique MS asm labels, not {:uid}

Thanks. 2016-12-06 16:28 GMT-08:00 Reid Kleckner : > Comments in r288868. It implements GCC's %= inline asm feature, and we're > just using it from MS-style inline asm to avoid duplicate labels clashing. > > 2016-12-01 0:37 GMT-08:00 Sean Silva : > >> what is this ${:uid} thing? Could the comment

Re: r285341 - Add documentation describing the components of a complete toolchain including Clang.

This is awesome Richard. Thanks! -- Sean Silva On Thu, Oct 27, 2016 at 1:55 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Oct 27 15:55:56 2016 > New Revision: 285341 > > URL: http://llvm.org/viewvc/llvm-project?rev=285341&view=rev > Log: > Ad

r247498 - Clean up trailing whitespace in the builtin headers

Author: silvas Date: Fri Sep 11 21:55:19 2015 New Revision: 247498 URL: http://llvm.org/viewvc/llvm-project?rev=247498&view=rev Log: Clean up trailing whitespace in the builtin headers Modified: cfe/trunk/lib/Headers/altivec.h cfe/trunk/lib/Headers/ammintrin.h cfe/trunk/lib/Headers/av

Re: r247765 - [modules] Fix a corner case in the macro override rules: properly handle overridden leaf module macros.

On Tue, Sep 15, 2015 at 5:55 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Tue Sep 15 19:55:50 2015 > New Revision: 247765 > > URL: http://llvm.org/viewvc/llvm-project?rev=247765&view=rev > Log: > [modules] Fix a corner case in the macro override r

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

silvas requested changes to this revision. silvas added a reviewer: silvas. This revision now requires changes to proceed. Comment at: include/clang/Basic/DiagnosticSemaKinds.td:7774 @@ -7771,1 +7773,3 @@ "@import of module '%0' in implementation of '%1'; use #import">; +def no

Re: [PATCH] D11279: Initial patch for PS4 toolchain

silvas added a subscriber: silvas. silvas added a comment. Once this lands, I think we can revert r247977 http://reviews.llvm.org/D11279 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

Re: [clang-tools-extra] r248080 - clang-tools-extra: Appease PR24881. [-Wdocumentation]

Thanks! -- Sean Silva On Fri, Sep 18, 2015 at 7:21 PM, NAKAMURA Takumi via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: chapuni > Date: Fri Sep 18 21:21:28 2015 > New Revision: 248080 > > URL: http://llvm.org/viewvc/llvm-project?rev=248080&view=rev > Log: > clang-tools-extra: Appea

Re: r248953 - [Sema] Don't crash when friending an unqualified templated constructor

On Wed, Sep 30, 2015 at 3:07 PM, David Majnemer via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: majnemer > Date: Wed Sep 30 17:07:43 2015 > New Revision: 248953 > > URL: http://llvm.org/viewvc/llvm-project?rev=248953&view=rev > Log: > [Sema] Don't crash when friending an unqualified

Re: [PATCH] D12747: Implement [depr.c.headers]

+extern "C++" { +#include <__nullptr> +using std::nullptr_t; +} Does this even compile with modules? -- Sean Silva On Tue, Oct 6, 2015 at 3:57 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > . This one is tricky: > > 1) There's an (undocumented) interface between the C

Re: [PATCH] D12747: Implement [depr.c.headers]

On Tue, Oct 6, 2015 at 4:13 PM, Richard Smith wrote: > On Tue, Oct 6, 2015 at 4:11 PM, Sean Silva wrote: > >> +extern "C++" { >> +#include <__nullptr> >> +using std::nullptr_t; >> +} >> >> Does this even compile with modules? >> > > Yes. You're allowed to import a C++ module within an 'extern "C

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

silvas added a subscriber: silvas. Comment at: lib/Parse/Parser.cpp:2003 @@ +2002,3 @@ +Diag(Tok, diag::err_unexpected_module_start); +// Recover by skipping content of the included submodule. +unsigned ModuleNesting = 1; rsmith wrote: > This is liable

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

On Wed, Aug 12, 2015 at 2:43 PM, Richard Smith wrote: > On Wed, Aug 12, 2015 at 12:08 AM, Sean Silva > wrote: > >> silvas added a subscriber: silvas. >> >> >> Comment at: lib/Parse/Parser.cpp:2003 >> @@ +2002,3 @@ >> +Diag(Tok, diag::err_unexpected_module_start); >> +//

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

On Wed, Aug 12, 2015 at 6:00 PM, Sean Silva wrote: > > > On Wed, Aug 12, 2015 at 2:43 PM, Richard Smith > wrote: > >> On Wed, Aug 12, 2015 at 12:08 AM, Sean Silva >> wrote: >> >>> silvas added a subscriber: silvas. >>> >>> >>> Comment at: lib/Parse/Parser.cpp:2003 >>> @@ +2002,

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

On Wed, Aug 12, 2015 at 6:05 PM, Richard Smith wrote: > On Wed, Aug 12, 2015 at 6:00 PM, Sean Silva wrote: > >> >> >> On Wed, Aug 12, 2015 at 2:43 PM, Richard Smith >> wrote: >> >>> On Wed, Aug 12, 2015 at 12:08 AM, Sean Silva >>> wrote: >>> silvas added a subscriber: silvas. ==

Re: r244912 - [Modules] Add Darwin-specific compatibility module map parsing hacks

This was the last thing blocking http://reviews.llvm.org/D10423, right? -- Sean Silva On Thu, Aug 13, 2015 at 10:13 AM, Ben Langmuir via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: benlangmuir > Date: Thu Aug 13 12:13:33 2015 > New Revision: 244912 > > URL: http://llvm.org/viewvc/

Re: r244912 - [Modules] Add Darwin-specific compatibility module map parsing hacks

This was the last thing blocking http://reviews.llvm.org/D10423 on your side, right? -- Sean Silva On Thu, Aug 13, 2015 at 10:13 AM, Ben Langmuir via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: benlangmuir > Date: Thu Aug 13 12:13:33 2015 > New Revision: 244912 > > URL: http://llv

Re: r244912 - [Modules] Add Darwin-specific compatibility module map parsing hacks

On Thu, Aug 13, 2015 at 4:47 PM, Ben Langmuir wrote: > Yep, that should be it! > Great! -- Sean Silva > > On Aug 13, 2015, at 4:45 PM, Sean Silva wrote: > > This was the last thing blocking http://reviews.llvm.org/D10423 on your > side, right? > > -- Sean Silva > > On Thu, Aug 13, 2015 at 10

Re: r244923 - [modules] Change the way we deal with .d output for explicitly-specified module

On Thu, Aug 13, 2015 at 10:57 AM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Thu Aug 13 12:57:10 2015 > New Revision: 244923 > > URL: http://llvm.org/viewvc/llvm-project?rev=244923&view=rev > Log: > [modules] Change the way we deal with .d output fo

r245228 - [modules] PR20507: Avoid silent textual inclusion.

Author: silvas Date: Mon Aug 17 11:39:30 2015 New Revision: 245228 URL: http://llvm.org/viewvc/llvm-project?rev=245228&view=rev Log: [modules] PR20507: Avoid silent textual inclusion. Summary: If a module was unavailable (either a missing requirement on the module being imported, or a missing fil

Re: [PATCH] D10423: [modules] PR20507: Avoid silent textual inclusion.

This revision was automatically updated to reflect the committed changes. Closed by commit rL245228: [modules] PR20507: Avoid silent textual inclusion. (authored by silvas). Changed prior to commit: http://reviews.llvm.org/D10423?vs=30196&id=32317#toc Repository: rL LLVM http://reviews.llvm

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

On Wed, Aug 12, 2015 at 6:05 PM, Richard Smith wrote: > On Wed, Aug 12, 2015 at 6:00 PM, Sean Silva wrote: > >> >> >> On Wed, Aug 12, 2015 at 2:43 PM, Richard Smith >> wrote: >> >>> On Wed, Aug 12, 2015 at 12:08 AM, Sean Silva >>> wrote: >>> silvas added a subscriber: silvas. ==

Re: [PATCH] D11944: Nativize filename in FileManager::getFile().

On Thu, Aug 13, 2015 at 10:50 AM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > rsmith added a comment. > > I would think most Windows users would be surprised if we showed them > paths with /s instead of \s, but I'm fine with us using / internally if it > doesn't leak out t

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

silvas added a subscriber: silvas. silvas added a comment. From a Sphinx perspective, this looks fine to me. You may want to consider using `html_theme = 'haiku'` for consistency with clang, but reusing LLVM's is fine. (the reason I had clang use 'haiku' is that it is a bit better put together

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

silvas added inline comments. Comment at: docs/BuildingLibcxx.rst:57 @@ +56,3 @@ + select a safe place to install libc++. + + * ``make install-libcxx install-libcxxabi`` --- Will install the libraries and the headers jroelofs wrote: > I feel like a warning is n

Re: [PATCH] D12129: [libcxx] Add new Sphinx documentation

silvas added inline comments. Comment at: docs/BuildingLibcxx.rst:57 @@ +56,3 @@ + select a safe place to install libc++. + + * ``make install-libcxx install-libcxxabi`` --- Will install the libraries and the headers silvas wrote: > jroelofs wrote: > > I feel l

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

silvas added inline comments. Comment at: test/Modules/auto-module-import.m:89 @@ +88,3 @@ + expected-error {{import of module 'NoUmbrella.A' appears within function 'includeNotAtTopLevel'}} \ + expected-note {{consider ma

Re: r245821 - [modules] Stop updating all identifiers when writing a module. This is

On Sun, Aug 23, 2015 at 8:33 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Sun Aug 23 22:33:22 2015 > New Revision: 245821 > > URL: http://llvm.org/viewvc/llvm-project?rev=245821&view=rev > Log: > [modules] Stop updating all identifiers when writin

Re: [PATCH] D12271: [X86] Expose the various _rot intrinsics on non-MS platforms

silvas added a subscriber: silvas. silvas added a comment. In http://reviews.llvm.org/D12271#231204, @rnk wrote: > This looks good. > > As a larger issue, LLVM fast isel definitely won't pattern match this series > of shifts and selects to rotl at -O0. There are some users who want > branchless

Re: [PATCH] D11844: [Modules] More descriptive diagnostics for misplaced import directive

silvas added a comment. ping? http://reviews.llvm.org/D11844 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

r246702 - [modules] Tighten up this test a bit.

Author: silvas Date: Wed Sep 2 15:16:09 2015 New Revision: 246702 URL: http://llvm.org/viewvc/llvm-project?rev=246702&view=rev Log: [modules] Tighten up this test a bit. Modified: cfe/trunk/test/Modules/module-map-path-hash.cpp Modified: cfe/trunk/test/Modules/module-map-path-hash.cpp URL:

Re: [PATCH] D12326: [Modules] Emit warning if module cannot instantiate static class member.

silvas added a subscriber: silvas. silvas added a comment. How expensive is this check? http://reviews.llvm.org/D12326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: r250252 - This patch adds missing pieces to clang, including the PS4 toolchain

Looks like this doesn't even compile: http://lab.llvm.org:8011/builders/clang-x86_64-debian-fast/builds/32311/steps/compile/logs/stdio Can you revert? On Tue, Oct 13, 2015 at 4:40 PM, Ekaterina Romanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: kromanova > Date: Tue Oct 13 1

Re: [libcxx] r249738 - Split out of .

On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Tue, Oct 13, 2015 at 2:10 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Hi Richard, >> >> this commit appears to break the module self-host on Darwin. >> >> When

Re: [libcxx] r249738 - Split out of .

On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith wrote: > On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva wrote: > >> On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> On Tue, Oct 13, 2015 at 2:10 PM, Adrian Prantl via cfe-commits < >>> cfe-c

Re: [libcxx] r249738 - Split out of .

On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva wrote: > > > On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith > wrote: > >> On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva >> wrote: >> >>> On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>> On

Re: [libcxx] r249738 - Split out of .

(and assert.h probably isn't the best example, since it is textual) On Tue, Oct 13, 2015 at 7:00 PM, Sean Silva wrote: > > > On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva wrote: > >> >> >> On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith >> wrote: >> >>> On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva

Re: r250262 - I took care of the build problem in the commit 250252.

This is breaking llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/1358/steps/test/logs/stdio On Tue, Oct 13, 2015 at 6:09 PM, Ekaterina Romanova via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: kromanova

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

On Tue, Oct 13, 2015 at 7:51 PM, Katya Romanova < katya_roman...@playstation.sony.com> wrote: > kromanova added a comment. > > Hi, > > The initial PS4 patch caused a test failure (debug-options.c) on the PS4 > bot. I suspect that I know why the problem happens, but I'm not sure what > will be the

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

On Tue, Oct 13, 2015 at 11:33 PM, Eric Christopher wrote: > It was already reverted, but I agree, let's get this fixed first. > It was reintroduced in r250252. It is breaking http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast/builds/1362 -- Sean Silva > > Thanks! > >

r250273 - Revert-to-green r250262 (PS4 toolchain patch)

Author: silvas Date: Wed Oct 14 01:45:07 2015 New Revision: 250273 URL: http://llvm.org/viewvc/llvm-project?rev=250273&view=rev Log: Revert-to-green r250262 (PS4 toolchain patch) It is breaking llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast e.g. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_6

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

On Tue, Oct 13, 2015 at 11:40 PM, Eric Christopher wrote: > > > On Tue, Oct 13, 2015 at 11:38 PM Sean Silva wrote: > >> On Tue, Oct 13, 2015 at 11:33 PM, Eric Christopher >> wrote: >> >>> It was already reverted, but I agree, let's get this fixed first. >>> >> >> It was reintroduced in r250252.

Re: [libcxx] r249738 - Split out of .

On Wed, Oct 14, 2015 at 3:32 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Wed, Oct 14, 2015 at 2:03 PM, Adrian Prantl via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Oct 14, 2015, at 11:37 AM, Adrian Prantl via cfe-commits < >> cfe-commits@lists.llvm.o

Re: [libcxx] r249738 - Split out of .

On Tue, Oct 13, 2015 at 7:43 PM, Richard Smith wrote: > On Tue, Oct 13, 2015 at 6:54 PM, Sean Silva wrote: > >> On Tue, Oct 13, 2015 at 6:14 PM, Richard Smith >> wrote: >> >>> On Tue, Oct 13, 2015 at 5:31 PM, Sean Silva >>> wrote: >>> On Tue, Oct 13, 2015 at 3:17 PM, Richard Smith via cfe

Re: [PATCH] D13482: Revised Initial patch for PS4 toolchain

On Wed, Oct 14, 2015 at 12:54 AM, Romanova, Katya < katya_roman...@playstation.sony.com> wrote: > Hi Sean, > > > > I don’t think that the whole patch should have been reverted. There were > much easier way to make the PS4 bot green. A single test could have been > marked as “XFAIL: ps4” for a few

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Fri, Oct 16, 2015 at 4:20 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Fri Oct 16 18:20:19 2015 > New Revision: 250577 > > URL: http://llvm.org/viewvc/llvm-project?rev=250577&view=rev > Log: > [modules] Allow the error when explicitly loading a

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Fri, Oct 16, 2015 at 6:12 PM, Richard Smith wrote: > On Fri, Oct 16, 2015 at 4:43 PM, Sean Silva wrote: > >> On Fri, Oct 16, 2015 at 4:20 PM, Richard Smith via cfe-commits < >> cfe-commits@lists.llvm.org> wrote: >> >>> Author: rsmith >>> Date: Fri Oct 16 18:20:19 2015 >>> New Revision: 250577

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Fri, Oct 16, 2015 at 6:26 PM, Richard Smith wrote: > On Fri, Oct 16, 2015 at 6:25 PM, Sean Silva wrote: > >> On Fri, Oct 16, 2015 at 6:12 PM, Richard Smith >> wrote: >> >>> On Fri, Oct 16, 2015 at 4:43 PM, Sean Silva >>> wrote: >>> On Fri, Oct 16, 2015 at 4:20 PM, Richard Smith via cfe

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Fri, Oct 16, 2015 at 6:41 PM, Richard Smith wrote: > On Fri, Oct 16, 2015 at 6:30 PM, Sean Silva wrote: > >> On Fri, Oct 16, 2015 at 6:26 PM, Richard Smith >> wrote: >> >>> On Fri, Oct 16, 2015 at 6:25 PM, Sean Silva >>> wrote: >>> On Fri, Oct 16, 2015 at 6:12 PM, Richard Smith w

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Mon, Oct 19, 2015 at 2:10 AM, Manuel Klimek wrote: > On Sat, Oct 17, 2015 at 3:41 AM Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Fri, Oct 16, 2015 at 6:30 PM, Sean Silva >> wrote: >> >>> On Fri, Oct 16, 2015 at 6:26 PM, Richard Smith >>> wrote: >>> On Fr

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Tue, Oct 20, 2015 at 1:38 AM, Manuel Klimek wrote: > On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote: > >> On Mon, Oct 19, 2015 at 2:10 AM, Manuel Klimek wrote: >> >>> On Sat, Oct 17, 2015 at 3:41 AM Richard Smith via cfe-commits < >>> cfe-commits@lists.llvm.org> wrote: >>> On Fri, Oct

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Tue, Oct 20, 2015 at 6:45 AM, Manuel Klimek wrote: > On Tue, Oct 20, 2015 at 3:38 PM Brad King wrote: > >> On 10/20/2015 04:38 AM, Manuel Klimek wrote: >> > On Tue, Oct 20, 2015 at 5:52 AM Sean Silva wrote: >> >> get cmake to generate clang module map files and add explicit module >> build st

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Tue, Oct 20, 2015 at 1:52 AM, Manuel Klimek wrote: > On Tue, Oct 20, 2015 at 10:41 AM Sean Silva wrote: > >> On Tue, Oct 20, 2015 at 1:38 AM, Manuel Klimek wrote: >> >>> On Tue, Oct 20, 2015 at 5:52 AM Sean Silva >>> wrote: >>> On Mon, Oct 19, 2015 at 2:10 AM, Manuel Klimek wrote

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Sun, Nov 1, 2015 at 10:20 AM, Manuel Klimek wrote: > > > On Fri, Oct 23, 2015 at 9:31 PM Sean Silva wrote: > >> On Tue, Oct 20, 2015 at 1:52 AM, Manuel Klimek wrote: >> >>> On Tue, Oct 20, 2015 at 10:41 AM Sean Silva >>> wrote: >>> On Tue, Oct 20, 2015 at 1:38 AM, Manuel Klimek w

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Wed, Nov 4, 2015 at 1:07 PM, Richard Smith wrote: > On Sun, Nov 1, 2015 at 10:20 AM, Manuel Klimek wrote: > >> On Fri, Oct 23, 2015 at 9:31 PM Sean Silva wrote: >> >>> On Tue, Oct 20, 2015 at 1:52 AM, Manuel Klimek >>> wrote: >>> On Tue, Oct 20, 2015 at 10:41 AM Sean Silva wrote:

Re: r250577 - [modules] Allow the error when explicitly loading an incompatible module file

On Thu, Nov 5, 2015 at 1:12 PM, Richard Smith wrote: > On Wed, Nov 4, 2015 at 7:14 PM, Sean Silva via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> On Wed, Nov 4, 2015 at 1:07 PM, Richard Smith >> wrote: >> >>> On Sun, Nov 1, 2015 at 10:20 AM,

Re: [PATCH] D21954: [PM] Add some internal options for testing out the new PM.

silvas updated this revision to Diff 64420. silvas added a comment. Rebase after r275507. https://reviews.llvm.org/D21954 Files: include/clang/Driver/CC1Options.td include/clang/Frontend/CodeGenOptions.h lib/CodeGen/BackendUtil.cpp lib/CodeGen/CMakeLists.txt lib/Frontend/CompilerInvoc

Re: [PATCH] D21823: [Driver] Add flags for enabling both types of PGO Instrumentation

On Tue, Jul 19, 2016 at 5:01 PM, Xinliang David Li wrote: > The new behavior works really well. There is one follow up change I would > like to discuss. > > The EQ form of the option -fprofile-generate= takes a directory name as > the argument instead of the filename. Currently the compiler will

Re: [PATCH] D22593: [Profile] document %h and %m

silvas added a comment. LGTM with some small wording nits. We may want to extend this to mention number modifier to `%m` (e.g. `%4m`). Perhaps it is better to leave that to more advanced documentation -- your experiments showed that even just 1 merge pool is quite scalable IIRC. =

Re: [PATCH] D22593: [Profile] document %h and %m

silvas accepted this revision. silvas added a comment. This revision is now accepted and ready to land. LGTM (also, another small suggestion). Comment at: docs/UsersManual.rst:1502 @@ +1501,3 @@ + multiple raw profiles dumped from different processes (running on the same or +

Re: r266719 - Warn if function or variable cannot be implicitly instantiated

On Tue, Aug 9, 2016 at 9:18 AM, Serge Pavlov wrote: > Whether enable this warning or not should be determined by user feedback. > The warning was implemented to help users in complicated cases that arise > in module-enabled builds. It seems however that it makes troubles for other > users. Based

Re: r278710 - Replace an obsolete company name.

You may also want to just try using the unicode character (not that it really matters that much though). On Mon, Aug 15, 2016 at 11:45 AM, Paul Robinson via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: probinson > Date: Mon Aug 15 13:45:52 2016 > New Revision: 278710 > > URL: http:/

Re: r259507 - Make the remaining headers self-contained.

On Tue, Feb 2, 2016 at 11:15 AM, David Blaikie via cfe-commits < cfe-commits@lists.llvm.org> wrote: > > > On Tue, Feb 2, 2016 at 11:11 AM, Rafael Espíndola < > cfe-commits@lists.llvm.org> wrote: > >> Out of curiosity, what technique were you using to find out if the >> headers were self-contained?

Re: r260201 - [CMake] Providing a CMake cache for 3-stage builds

Neat! Besides the awesomeness of the bootstrap, I didn't know about the -C option! (well, except that you told me about it at the social last week, but this is the first time I saw the actual usage). btw, the README.txt in cmake/caches says "The first two cache files in the directory" -- but it's

Re: [PATCH] D16851: Update of "GCC extensions not implemented yet" in Clang User's Manual

silvas added a subscriber: silvas. silvas added a comment. Assuming the features are implemented this seems fine. LGTM. Comment at: docs/UsersManual.rst:1698 @@ -1697,3 @@ -- clang does not support #pragma weak (`bug - 3679 `_). Due

r261053 - [AttrDocs.td] Fix up some reST syntax.

Author: silvas Date: Tue Feb 16 20:08:19 2016 New Revision: 261053 URL: http://llvm.org/viewvc/llvm-project?rev=261053&view=rev Log: [AttrDocs.td] Fix up some reST syntax. Modified: cfe/trunk/include/clang/Basic/AttrDocs.td Modified: cfe/trunk/include/clang/Basic/AttrDocs.td URL: http://llv

Re: r261053 - [AttrDocs.td] Fix up some reST syntax.

Btw, thanks to nlewycky to pointing this out. -- Sean Silva On Tue, Feb 16, 2016 at 6:08 PM, Sean Silva via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: silvas > Date: Tue Feb 16 20:08:19 2016 > New Revision: 261053 > > URL: http://llvm.org/viewvc/llvm-projec

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

silvas added a comment. Apologies for the delay. At this point, I think that this patch has evolved enough that it is best to start a new patch. I think the steps forward are: - Have cc1 accept -fprofile-instrument=llvm (requires no driver changes, but is enough for developers to test by being

Re: r261552 - [VFS] Add 'overlay-relative' field to YAML files

This or r261551 seem to be causing a build failure: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/527 -- Sean SIlva On Mon, Feb 22, 2016 at 10:41 AM, Bruno Cardoso Lopes via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: bruno > Date: Mon F

Re: r261552 - [VFS] Add 'overlay-relative' field to YAML files

The bot is still red: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast On Mon, Feb 22, 2016 at 6:48 PM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > Hi Sean, > > This is hopefully fixed in r261556. > > On Mon, Feb 22, 2016 at 5:45 PM, Sean Silva wrote

Re: [clang-tools-extra] r261737 - [clang-tidy] Added a check for forward declaration in the potentially wrong namespace

This or r261737 seem to be causing a bot failure: http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast/builds/636 -- Sean Silva On Wed, Feb 24, 2016 at 5:35 AM, Alexander Kornienko via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: alexfh > Date: Wed Feb

Re: [PATCH] D15829: [PGO] Clang Option that enables IR level PGO instrumentation

silvas added a comment. In http://reviews.llvm.org/D15829#360006, @xur wrote: > Here is the new patch that removes the auto detection of profile kind. > > In this patch, I replace the CC1 option of -fprofile-instr-use=<> with > -fprofile-instrument={llvm-use|clang-use}. For the use compilation,

Re: [PATCH] D17622: [PGO] clang cc1 option change to enable IR level instrumenation

silvas added a comment. Thanks for splitting this out. I think the `-fprofile-instrument=llvm` is straightforward and uncontroversial. Let's focus this review on that and split the others into a separate review. But a quick preview of my thoughs about `-fprofile-instrument={llvm,clang}-use`: I

Re: r268127 - Add a new warning to notify users of mismatched SDK and deployment target

This breaks the PS4 bots at least. They've been red for hours now. http://lab.llvm.org:8011/builders/llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast?numbuilds=100 On Fri, Apr 29, 2016 at 3:28 PM, Chris Bieneman via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: cbieneman > Date: Fri Apr 29

Re: [PATCH] D19678: Annotated-source optimization reports (a.k.a. "listing" files)

On Mon, May 2, 2016 at 4:14 PM, Hal Finkel via cfe-commits < cfe-commits@lists.llvm.org> wrote: > hfinkel added a comment. > > In http://reviews.llvm.org/D19678#416127, @rcox2 wrote: > > > Actually, the Intel compiler distinguishes between an optimization > report (-qopt-report) and an annotated l

Re: r268777 - Frontend: support -I=path for sysroot expansion

Do we also handle ':'? The corresponding behavior in the linker is in: http://llvm.org/klaus/lld/blob/master/ELF/DriverUtils.cpp#L-232 -- Sean Silva On Fri, May 6, 2016 at 12:13 PM, Saleem Abdulrasool via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: compnerd > Date: Fri May 6 14:1

Re: [PATCH] D19996: New clang option -mpiecopyrelocs to indicate support for linker copy relocations when linking as PIE

If this is something that GCC doesn't have, it would be nice if we put something in our own docs about it (something like docs/UsersManual.rst). On Thu, May 5, 2016 at 2:34 PM, Sriraman Tallam via cfe-commits < cfe-commits@lists.llvm.org> wrote: > On Thu, May 5, 2016 at 2:31 PM, Rafael Espíndola

r269160 - Hopefully bring llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast back to life

Author: silvas Date: Tue May 10 23:04:59 2016 New Revision: 269160 URL: http://llvm.org/viewvc/llvm-project?rev=269160&view=rev Log: Hopefully bring llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast back to life Bruno made a couple valiant attempts but the bot is still red. This reverts r269100 (

Re: r269100 - [VFS] Reconstruct the VFS overlay tree for more accurate lookup

Hi Bruno, I had to revert this in r269100 because it was looking like the bot was going to be left red overnight. Changes to this VFS code seem to have a trend of breaking on windows. Any idea why that is? I can understand things breaking on windows when writing low-level parts of an FS abstracti

Re: r269100 - [VFS] Reconstruct the VFS overlay tree for more accurate lookup

On Tue, May 10, 2016 at 9:49 PM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > Thanks Sean, > > I was about to ask for help and try a 4th attempt, as you noted after > 3 attempts I was not yet able to make this work on windows though... > So sorry! It had gone quiet for a few hours and

Re: r269100 - [VFS] Reconstruct the VFS overlay tree for more accurate lookup

On Tue, May 10, 2016 at 11:14 PM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > Hi Sean, > > > So sorry! It had gone quiet for a few hours and I wanted to avoid > leaving it > > red any longer. > > No problem, the priority is to get bot greens! > > > Does any platform define a guaranteed

Re: r269100 - [VFS] Reconstruct the VFS overlay tree for more accurate lookup

On Wed, May 11, 2016 at 10:46 AM, Bruno Cardoso Lopes < bruno.card...@gmail.com> wrote: > > I'm glad to help, but it makes me uneasy to have somebody working on a > > filesystem abstraction that does not have ready access to test and debug > > their changes across the major host platforms that LLV

Re: r269309 - [ubsan] Add -fsanitize-undefined-strip-path-components=N

On Thu, May 12, 2016 at 9:51 AM, Filipe Cabecinhas via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: filcab > Date: Thu May 12 11:51:36 2016 > New Revision: 269309 > > URL: http://llvm.org/viewvc/llvm-project?rev=269309&view=rev > Log: > [ubsan] Add -fsanitize-undefined-strip-path-com

Re: r269309 - [ubsan] Add -fsanitize-undefined-strip-path-components=N

On Fri, May 13, 2016 at 12:01 AM, Filipe Cabecinhas wrote: > > > On 13 May 2016, at 07:03, Sean Silva wrote: > > > > > > > > On Thu, May 12, 2016 at 9:51 AM, Filipe Cabecinhas via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > > Author: filcab > > Date: Thu May 12 11:51:36 2016 > > New Rev

Re: r269765 - Revert "[X86] Add immediate range checks for many of the builtins."

On Tue, May 17, 2016 at 7:07 AM, Filipe Cabecinhas via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: filcab > Date: Tue May 17 09:07:43 2016 > New Revision: 269765 > > URL: http://llvm.org/viewvc/llvm-project?rev=269765&view=rev > Log: > Revert "[X86] Add immediate range checks for ma

Re: r269910 - Update for llvm change.

On Wed, May 18, 2016 at 4:58 AM, Rafael Espindola via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rafael > Date: Wed May 18 06:58:56 2016 > New Revision: 269910 > > URL: http://llvm.org/viewvc/llvm-project?rev=269910&view=rev > Log: > Update for llvm change. > > Modified: > cfe/

Re: r270009 - Make Sema::getPrintingPolicy less ridiculously expensive. This used to perform

On Wed, May 18, 2016 at 6:39 PM, Richard Smith via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Author: rsmith > Date: Wed May 18 20:39:10 2016 > New Revision: 270009 > > URL: http://llvm.org/viewvc/llvm-project?rev=270009&view=rev > Log: > Make Sema::getPrintingPolicy less ridiculously expe

Re: r270009 - Make Sema::getPrintingPolicy less ridiculously expensive. This used to perform

Ah, just saw 270010 On Wed, May 18, 2016 at 6:49 PM, Sean Silva wrote: > > > On Wed, May 18, 2016 at 6:39 PM, Richard Smith via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: rsmith >> Date: Wed May 18 20:39:10 2016 >> New Revision: 270009 >> >> URL: http://llvm.org/viewvc/llvm-

Re: [PATCH] D20404: [Driver] Fix driver support for color diagnostics

silvas added a subscriber: silvas. silvas added a comment. I don't see an issue with putthing this as a helper in libBasic. We may need to add a libOption dependency to it but that sounds fine. http://reviews.llvm.org/D20404 ___ cfe-commits mailing

Re: r266719 - Warn if function or variable cannot be implicitly instantiated

On Thu, Apr 21, 2016 at 12:44 AM, Serge Pavlov wrote: > Let me demonstrate the problem using excerpt from v8 sources: > > -- lithium.h > template > struct LSubKindOperand { > static int* Create(int index) { return &cache[index]; } > st

Re: r266719 - Warn if function or variable cannot be implicitly instantiated

On Thu, May 19, 2016 at 12:13 PM, Serge Pavlov wrote: > In this case moving implementation of `Singleton::getInstance()` into a > .cpp file would prevent compiler from instantiation of the method body when > it sees `Singleton::getInstance()`. In this case > `Singleton::getInstance()` must be ins

  1   2   >