Re: [PATCH] D38208: Add support for remembering origins to ExternalASTMerger

Updated the diff.  Unfortunately reviews.llvm.org is down, so I'll try updating that page in the morning. Sean On 9/25/17 5:04 AM, Bruno Cardoso Lopes via Phabricator wrote: bruno added inline comments. Comment at: lib/AST/ExternalASTMerger.cpp:79 + return cast(SearchRe

r314336 - Add support for remembering origins to ExternalASTMerger

Author: spyffe Date: Wed Sep 27 12:57:58 2017 New Revision: 314336 URL: http://llvm.org/viewvc/llvm-project?rev=314336&view=rev Log: Add support for remembering origins to ExternalASTMerger ExternalASTMerger has hitherto relied on being able to look up any Decl through its named DeclContext chai

r310318 - This adds the argument --dump-ir to clang-import-test, which allows

Author: spyffe Date: Mon Aug 7 15:27:30 2017 New Revision: 310318 URL: http://llvm.org/viewvc/llvm-project?rev=310318&view=rev Log: This adds the argument --dump-ir to clang-import-test, which allows viewing of the final IR. This is useful for confirming that structure layout was correct. I've

r290004 - Testbed and skeleton of a new expression parser

Author: spyffe Date: Fri Dec 16 17:21:38 2016 New Revision: 290004 URL: http://llvm.org/viewvc/llvm-project?rev=290004&view=rev Log: Testbed and skeleton of a new expression parser LLVM's JIT is now the foundation of dynamic-compilation features for many languages. Clang also has low-level suppo

r290006 - Fixed library dependencies on clang-import-test to clean up the bots.

Author: spyffe Date: Fri Dec 16 17:34:16 2016 New Revision: 290006 URL: http://llvm.org/viewvc/llvm-project?rev=290006&view=rev Log: Fixed library dependencies on clang-import-test to clean up the bots. Modified: cfe/trunk/tools/clang-import-test/CMakeLists.txt Modified: cfe/trunk/tools/clan

r290010 - Added clangLex to the dependencies for clang-import-test.

Author: spyffe Date: Fri Dec 16 17:45:03 2016 New Revision: 290010 URL: http://llvm.org/viewvc/llvm-project?rev=290010&view=rev Log: Added clangLex to the dependencies for clang-import-test. This is part of the effort to get the i686-mingw32-RA-on-linux bot to like clang-import-test. Modified:

Re: [PATCH] D27683: Prepare PrettyStackTrace for LLDB adoption

That would require making LLDB crash and collecting the relevant crash log data out of the user's own logs. This isn't impossible – but additionally the generation of that log is asynchronous and you don't quite know when it'll land. Would you be all right with a more restricted macOS-only unit

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

David, thanks for keeping an eye on this and sorry for the breach of process. Would having Vassil approve the changelist (https://reviews.llvm.org/D27180 ) be appropriate? Let's say if he has any concerns or can't get to it by tomorrow, we revert my patches since

r290130 - Reverting r290004, r290006, r290010 pending review.

Author: spyffe Date: Mon Dec 19 13:15:43 2016 New Revision: 290130 URL: http://llvm.org/viewvc/llvm-project?rev=290130&view=rev Log: Reverting r290004, r290006, r290010 pending review. Removed: cfe/trunk/test/Import/ cfe/trunk/tools/clang-import-test/ Modified: cfe/trunk/test/CMakeLis

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

Reverted by 290130. I have new comments from Aleksei in https://reviews.llvm.org/D27180 . I'll apply those and update the patch. Sean > On Dec 19, 2016, at 9:48 AM, Sean Callanan wrote: > > David, > > thanks for keeping an eye on this and sorry for the bre

r290367 - Testbed and skeleton of a new expression parser

Author: spyffe Date: Thu Dec 22 14:03:14 2016 New Revision: 290367 URL: http://llvm.org/viewvc/llvm-project?rev=290367&view=rev Log: Testbed and skeleton of a new expression parser Recommitted after formal approval. LLVM's JIT is now the foundation of dynamic-compilation features for many langu

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. Yes, I look forward to testing this in LLDB. Thanks for your hard work. https://reviews.llvm.org/D14326 ___ cfe-commits mailing list cfe-commits

r299976 - [clang-import-test] Lookup inside contexts

Author: spyffe Date: Tue Apr 11 14:33:35 2017 New Revision: 299976 URL: http://llvm.org/viewvc/llvm-project?rev=299976&view=rev Log: [clang-import-test] Lookup inside contexts clang-import-test has until now been only able to report top-level Decls. This is clearly insufficient; we should be able

r299977 - [ExternalASTMerger] Fix the MSVC build

Author: spyffe Date: Tue Apr 11 14:50:37 2017 New Revision: 299977 URL: http://llvm.org/viewvc/llvm-project?rev=299977&view=rev Log: [ExternalASTMerger] Fix the MSVC build Modified: cfe/trunk/lib/AST/ExternalASTMerger.cpp Modified: cfe/trunk/lib/AST/ExternalASTMerger.cpp URL: http://llvm.or

r299983 - [ExternalASTMerger] Removed a move constructor to address MSVC build failure

Author: spyffe Date: Tue Apr 11 15:51:21 2017 New Revision: 299983 URL: http://llvm.org/viewvc/llvm-project?rev=299983&view=rev Log: [ExternalASTMerger] Removed a move constructor to address MSVC build failure Modified: cfe/trunk/lib/AST/ExternalASTMerger.cpp Modified: cfe/trunk/lib/AST/Exte

r307600 - clang-import-test had some dead code. I did the following to eliminate it:

Author: spyffe Date: Mon Jul 10 16:47:00 2017 New Revision: 307600 URL: http://llvm.org/viewvc/llvm-project?rev=307600&view=rev Log: clang-import-test had some dead code. I did the following to eliminate it: - eliminated error handling for the indirect CompilerInstance, which should never gene

r307602 - [clang-import-test] Committed missed update to clang-import-test.cpp

Author: spyffe Date: Mon Jul 10 17:27:57 2017 New Revision: 307602 URL: http://llvm.org/viewvc/llvm-project?rev=307602&view=rev Log: [clang-import-test] Committed missed update to clang-import-test.cpp I didn't commit clang-import-test.cpp in r307600, but it had some changes that were part of htt

r307603 - [clang-import-test] Test that enumerators and their values are found.

Author: spyffe Date: Mon Jul 10 17:29:37 2017 New Revision: 307603 URL: http://llvm.org/viewvc/llvm-project?rev=307603&view=rev Log: [clang-import-test] Test that enumerators and their values are found. Added: cfe/trunk/test/Import/enum/ - copied from r307452, cfe/trunk/test/Import/memb

r309014 - [ExternalASTMerger] Import Objective-C classes

Author: spyffe Date: Tue Jul 25 12:54:22 2017 New Revision: 309014 URL: http://llvm.org/viewvc/llvm-project?rev=309014&view=rev Log: [ExternalASTMerger] Import Objective-C classes This patch adds functionality and a test for importing Objective-C classes and their methods. It also adds a flag to

r309018 - Fix a bot by linking clang-import-test against libclangDriver

Author: spyffe Date: Tue Jul 25 13:09:30 2017 New Revision: 309018 URL: http://llvm.org/viewvc/llvm-project?rev=309018&view=rev Log: Fix a bot by linking clang-import-test against libclangDriver Modified: cfe/trunk/tools/clang-import-test/CMakeLists.txt Modified: cfe/trunk/tools/clang-import

Re: [PATCH] D30435: [clang-import-test] Lookup inside entities

Aleksei, thank you for your comments! I appreciate your comments in particular about source/destination confusion. I can relate to this, as this was (a) an area that confused me while I was working on this code in LLDB; and (b) it was something I had to keep straight in my head even when doin

Re: [PATCH] D30435: [clang-import-test] Lookup inside entities

Gosh, I missed the reserve() call. Sorry! I'll be happy to implement this change. Sean > On Mar 6, 2017, at 10:05 AM, Sean Callanan wrote: > > Aleksei, > > thank you for your comments! > > I appreciate your comments in particular about source/destination confusion. > I can relate to this

[PATCH] D26571: Clean up layout of ASTMerge tests

spyffe added a reviewer: beanz. spyffe updated this revision to Diff 77928. spyffe added a comment. Updated the locations so the structure is now a/test.c a/Inputs/a1.c a/Inputs/a2.c The naming of "test.c" is no longer a requirement but only a convention. Also `lit.site.cfg` is no longer

r287129 - Fixed layout of test/ASTMerge.

Author: spyffe Date: Wed Nov 16 12:21:00 2016 New Revision: 287129 URL: http://llvm.org/viewvc/llvm-project?rev=287129&view=rev Log: Fixed layout of test/ASTMerge. As outlined in a previous RFC, the test/ASTMerge/Inputs folder is getting full and the tests are starting to become interdependent.

[PATCH] D26571: Clean up layout of ASTMerge tests

spyffe closed this revision. spyffe added a comment. Committed r287129 Repository: rL LLVM https://reviews.llvm.org/D26571 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26753: ASTImporter: improve support for C++ templates

spyffe requested changes to this revision. spyffe added a comment. This revision now requires changes to proceed. This looks amazing. I have a few minor quibbles and a testing concern, but overall this looks like a great step forward! Thank you! Comment at: lib/AST/ASTImport

[PATCH] D26808: [Sema] Don't allow applying address-of operator to a call to a function with __unknown_anytype return type

spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. I think it's all right to be conservative here. The inference rules could get quite complicated if (for example) the use looked like this extern void foo (double *bar); extern __unknown_a

r301573 - Added an Importer test for in-class member initializers.

Author: spyffe Date: Thu Apr 27 13:10:29 2017 New Revision: 301573 URL: http://llvm.org/viewvc/llvm-project?rev=301573&view=rev Log: Added an Importer test for in-class member initializers. Added: cfe/trunk/test/Import/in-class-initializer/ cfe/trunk/test/Import/in-class-initializer/Input

r302975 - [ASTImporter] Improve handling of incomplete types

Author: spyffe Date: Fri May 12 19:46:33 2017 New Revision: 302975 URL: http://llvm.org/viewvc/llvm-project?rev=302975&view=rev Log: [ASTImporter] Improve handling of incomplete types ASTImporter has some bugs when it's importing types that themselves come from an ExternalASTSource. This is exp

[PATCH] D26054: Use `getFileLoc()` instead of `getSpellingLoc()` in the ASTImporter

spyffe created this revision. spyffe added reviewers: bruno, akyrtzi, a.sidorin. spyffe added a subscriber: cfe-commits. When the `ASTImporter`imports a source location, it avoids importing macro expansions by calling `getSpellingLoc()`. That's great in most cases, but for macros defined in the

[PATCH] D26054: Use `getFileLoc()` instead of `getSpellingLoc()` in the ASTImporter

spyffe updated this revision to Diff 76213. spyffe added a comment. Updated the corresponding comment. https://reviews.llvm.org/D26054 Files: lib/AST/ASTImporter.cpp test/ASTMerge/Inputs/macro.modulemap test/ASTMerge/Inputs/macro1.h test/ASTMerge/Inputs/macro1.m test/ASTMerge/Inputs/m

[PATCH] D26054: Use `getFileLoc()` instead of `getSpellingLoc()` in the ASTImporter

spyffe added a comment. Aleksei, thank you for your review. I don't quite follow what you'd like me to do with the `Input` files, though. Some of them certainly appear to be input files in the same way that all the other files in `Inputs` are. Are you suggesting that I move `macro.modulemap`

[PATCH] D26328: [ASTImporter] Added ability to import AtomicType nodes

spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. Looks good to me. Thanks, Kareem! https://reviews.llvm.org/D26328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/

[PATCH] D26054: Use `getFileLoc()` instead of `getSpellingLoc()` in the ASTImporter

spyffe added a comment. That seems reasonable, and would go a long way toward cleaning up the `Inputs` and making clear exactly which inputs correspond to which test file. Do you think it would be reasonable to take this diff the way it currently it is, and start a new one that pulls all the inp

r286144 - When the ASTImporter imports a source location, it avoids importing macro

Author: spyffe Date: Mon Nov 7 14:42:25 2016 New Revision: 286144 URL: http://llvm.org/viewvc/llvm-project?rev=286144&view=rev Log: When the ASTImporter imports a source location, it avoids importing macro expansions by calling getSpellingLoc(). That's great in most cases, but for macros defined

[PATCH] D26054: Use `getFileLoc()` instead of `getSpellingLoc()` in the ASTImporter

spyffe closed this revision. spyffe added a comment. $ svn commit lib test Sendinglib/AST/ASTImporter.cpp Adding test/ASTMerge/Inputs/macro.modulemap Adding test/ASTMerge/Inputs/macro1.h Adding test/ASTMerge/Inputs/macro1.m Adding test/ASTMerge/I

r286151 - Updated ASTMerge/macro.m to use _Nullable.

Author: spyffe Date: Mon Nov 7 15:10:31 2016 New Revision: 286151 URL: http://llvm.org/viewvc/llvm-project?rev=286151&view=rev Log: Updated ASTMerge/macro.m to use _Nullable. Modified: cfe/trunk/test/ASTMerge/Inputs/macro1.h Modified: cfe/trunk/test/ASTMerge/Inputs/macro1.h URL: http://llv

[PATCH] D26054: Use `getFileLoc()` instead of `getSpellingLoc()` in the ASTImporter

spyffe added a comment. Fixed the testcase to use _Nullable instead of __nullable, for Linux buildbots $ svn commit test Sendingtest/ASTMerge/Inputs/macro1.h Transmitting file data .done Committing transaction... Committed revision 286151. https://reviews.llvm.org/D26054 __

[PATCH] D26571: Clean up layout of ASTMerge tests

spyffe created this revision. spyffe added a reviewer: a.sidorin. spyffe added a subscriber: cfe-commits. spyffe set the repository for this revision to rL LLVM. As outlined in a previous RFC, the `test/ASTMerge/Inputs` folder is getting full and the tests are starting to become interdependent.

Re: [PATCH] D14326: ASTImporter: expressions, pt.2

spyffe requested changes to this revision. spyffe added a comment. This revision now requires changes to proceed. Overall I'm very enthusiastic about this and only have a few nitpicks. Thanks for the hard work! Comment at: lib/AST/ASTImporter.cpp:2364 @@ +2363,3 @@ + if (Arg.

[PATCH] D20118: Add support for injected class names and constructor initializers in C++

spyffe created this revision. spyffe added reviewers: sepavloff, a.sidorin. spyffe added a subscriber: cfe-commits. spyffe set the repository for this revision to rL LLVM. spyffe added a project: clang-c. The AST importer currently does not handle injected class names properly (it does not bind t

Re: [PATCH] D20118: Add support for injected class names and constructor initializers in C++

Thank you for your comments, I’m working on them now. Sean > On May 11, 2016, at 4:39 AM, Aleksei Sidorin wrote: > > a.sidorin added a comment. > > I' d like to have some tests for this. CXXCtorInitializers can be tested with > D14224 -like stuff or with ASTMat

Re: [PATCH] D20118: Add support for injected class names and constructor initializers in C++

spyffe added a subscriber: spyffe. spyffe added a comment. Thank you for your comments, I’m working on them now. Sean Repository: rL LLVM http://reviews.llvm.org/D20118 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.or

Re: [PATCH] D20118: Add support for injected class names and constructor initializers in C++

spyffe added a comment. I’m just going to use clang-format to resolve trailing whitespace/etc issues. It changes around some indentation in the class declaration for ASTImporter but that probably needs to be taken care of anyway… Sean Repository: rL LLVM http://reviews.llvm.org/D20118

Re: [PATCH] D20118: Add support for injected class names and constructor initializers in C++

I’m just going to use clang-format to resolve trailing whitespace/etc issues. It changes around some indentation in the class declaration for ASTImporter but that probably needs to be taken care of anyway… Sean > On May 13, 2016, at 1:40 PM, Sean Callanan wrote: > > spyffe added a subscriber

r269546 - Added support to the ASTImporter for C++ constructor initializers.

Author: spyffe Date: Sat May 14 00:20:31 2016 New Revision: 269546 URL: http://llvm.org/viewvc/llvm-project?rev=269546&view=rev Log: Added support to the ASTImporter for C++ constructor initializers. Thanks to Aleksei Sidorin for review and advice. Added: cfe/trunk/test/ASTMerge/Inputs/init-

r269551 - Handle injected class names in the ASTImporter.

Author: spyffe Date: Sat May 14 00:43:57 2016 New Revision: 269551 URL: http://llvm.org/viewvc/llvm-project?rev=269551&view=rev Log: Handle injected class names in the ASTImporter. Every class as parsed by Clang has a forward declaration of itself as a member: class A { class A; ... } but w

r269553 - Fixed a bug where the ASTImporter didn't propagate builtin IDs at all.

Author: spyffe Date: Sat May 14 01:11:19 2016 New Revision: 269553 URL: http://llvm.org/viewvc/llvm-project?rev=269553&view=rev Log: Fixed a bug where the ASTImporter didn't propagate builtin IDs at all. IdentifierInfos are assigned builtin IDs during parsing, but Idents.get() does not do that w

r269554 - Update identifiers as needed when loading macros from serialized ASTs.

Author: spyffe Date: Sat May 14 01:24:14 2016 New Revision: 269554 URL: http://llvm.org/viewvc/llvm-project?rev=269554&view=rev Log: Update identifiers as needed when loading macros from serialized ASTs. This is essential for iterating across macros properly, which LLDB does when loading macros f

r269693 - Added support to the ASTImporter for C++ constructor initializers.

Author: spyffe Date: Mon May 16 15:48:03 2016 New Revision: 269693 URL: http://llvm.org/viewvc/llvm-project?rev=269693&view=rev Log: Added support to the ASTImporter for C++ constructor initializers. Also added named casts and propagation of "implicit" to fix the LLDB testsuite. This is a fixed co

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

spyffe requested changes to this revision. spyffe added a comment. This revision now requires changes to proceed. Overall this is a great improvement and I look forward to taking advantage of this patch in LLDB! I had one specific nit about `NullPtrTy`, and one more general comment about your i

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

spyffe added a subscriber: spyffe. spyffe added a comment. Aleksei, it looks like I might have made a bad assumption in my ImportArray – namely that there were some entities that required arrays of things they’re constructed with to be allocated in the ASTContext. Looking at the constructors

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

Aleksei, it looks like I might have made a bad assumption in my ImportArray – namely that there were some entities that required arrays of things they’re constructed with to be allocated in the ASTContext. Looking at the constructors for those entities, it looks like most of them actually do t

Re: [PATCH] D14286: ASTImporter: expressions, pt.1

spyffe accepted this revision. spyffe added a comment. This revision is now accepted and ready to land. This all looks fine to me, and the LLDB test suite is happy also. http://reviews.llvm.org/D14286 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D22270: [ASTImporter] Properly report the locations of anonymous structs declared as part of named fields

spyffe created this revision. spyffe added a reviewer: manmanren. spyffe added a subscriber: cfe-commits. spyffe set the repository for this revision to rL LLVM. When importing classes and structs with anonymous structs, it is critical that distinct anonymous structs remain distinct despite havin

Re: [PATCH] D22270: [ASTImporter] Properly report the locations of anonymous structs declared as part of named fields

spyffe added a comment. Thank you very much for your review, Manman! I can implement all your individual fixes, those look fine. In answer to two of your bigger questions, though: - I see what you mean about the definition of an anonymous structure. It looks like our structure is an //untag

Re: [PATCH] D22270: [ASTImporter] Properly report the locations of anonymous structs declared as part of named fields

spyffe added a comment. I mean `findUntaggedStructOrUnionIndex` Repository: rL LLVM http://reviews.llvm.org/D22270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D22270: [ASTImporter] Properly report the locations of anonymous structs declared as part of named fields

spyffe updated this revision to Diff 63894. spyffe added a comment. Applied Manman's changes: - `const auto*` instead of `const RecordType*` - kept the if's separate because I... - ...moved the `Index++` and `continue` in so that we only increment the counter when we're really dealing with somet

r275460 - When importing classes and structs with anonymous structs, it is critical that

Author: spyffe Date: Thu Jul 14 14:53:44 2016 New Revision: 275460 URL: http://llvm.org/viewvc/llvm-project?rev=275460&view=rev Log: When importing classes and structs with anonymous structs, it is critical that distinct anonymous structs remain distinct despite having similar layout. This is alr

r262572 - Fixed a problem where the ASTImporter mishandled in-class initializers.

Author: spyffe Date: Wed Mar 2 19:21:28 2016 New Revision: 262572 URL: http://llvm.org/viewvc/llvm-project?rev=262572&view=rev Log: Fixed a problem where the ASTImporter mishandled in-class initializers. Previously, the ASTImporter, when copying a FieldDecl, would make the new FieldDecl use the

r262576 - Caught and fixed a typo in r262572.

Author: spyffe Date: Wed Mar 2 20:22:05 2016 New Revision: 262576 URL: http://llvm.org/viewvc/llvm-project?rev=262576&view=rev Log: Caught and fixed a typo in r262572. I should have checked and imported D's in-class initializer. Instead I accidentally used ToField's in-class initializer, which i

Re: r262576 - Caught and fixed a typo in r262572.

LLDB is actually the most comprehensive validation suite for the ASTImporter I’m aware of. Sean > On Mar 2, 2016, at 11:04 PM, Nico Weber wrote: > > Is it possible to test this? > > On Mar 2, 2016 6:26 PM, "Sean Callanan via cfe-commits" > mailto:cfe-commits@list

r264669 - Improvements to the ASTImporter to support LLDB top-level Clang expressions.

Author: spyffe Date: Mon Mar 28 16:43:01 2016 New Revision: 264669 URL: http://llvm.org/viewvc/llvm-project?rev=264669&view=rev Log: Improvements to the ASTImporter to support LLDB top-level Clang expressions. The testcase for this is in LLDB, adeed by r264662. This patch adds support for a vari