[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

s.egerton added a comment. I agree inline asm is a far from optimal solution but it seems like the lesser of two evils for now. This sounds like a good idea, but we need to be able to guarantee that the backend will be able to match to the correct instruction for all optimisation levels before

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

s.egerton added a comment. Sorry I misread your original comment. These functions exist so that we can guarantee that these particular instructions will be emitted; the other option was LLVM IR intrinsics and Clang builtins, this was the other patch (https://reviews.llvm.org/D66479). We are pl

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

s.egerton added a comment. We have a patch to add codegen pattern matching (https://reviews.llvm.org/D67348). Unfortunately we have found that we will not be able to rely on pattern matching here to guarantee that these instructions are emitted in all situations due to differences in optimisati

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

s.egerton accepted this revision. s.egerton added a comment. Looks good to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553 ___ cfe-commits mailing list cfe-c

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

This revision was automatically updated to reflect the committed changes. Closed by commit rG57cf6ee9c844: [RISCV] Add Clang frontend support for Bitmanip extension (authored by s.egerton). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ ht

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

s.egerton added a comment. Good point. It's reverted now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[PATCH] D71758: [Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using -fdollars-in-identifiers flag.

This revision was automatically updated to reflect the committed changes. Closed by commit rGa90ea386981f: [Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using… (authored by s.egerton). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

s.egerton planned changes to this revision. s.egerton added a comment. In D67661#1767141 , @lewis-revill wrote: > So I have a quick comment about this patch, perhaps it might help to get > things moving again. > > I'd like to see the actual frontend chan

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

s.egerton created this revision. s.egerton added reviewers: asb, simoncook, lewis-revill, PaoloS, lenary. Herald added subscribers: cfe-commits, luismarques, apazos, sameer.abuasal, pzheng, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, Ma

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

s.egerton updated this revision to Diff 234308. s.egerton added a comment. Add test that march 'b' flag enables __riscv_bitmanip. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553 Files: clang/lib/Basic/Tar

[PATCH] D71758: [Lexer] Allow UCN for dollar symbol '\u0024' in identifiers when using -fdollars-in-identifiers flag.

s.egerton created this revision. Herald added subscribers: cfe-commits, simoncook. Herald added a project: clang. s.egerton added reviewers: rsmith, akyrtzi, jordan_rose. Herald added a subscriber: dexonsmith. Previously, the -fdollars-in-identifiers flag allows the '$' symbol to be used in an ide