Author: sfantao
Date: Mon Sep 19 13:13:13 2016
New Revision: 281923
URL: http://llvm.org/viewvc/llvm-project?rev=281923&view=rev
Log:
Reorder initializers in CallStackFrame so that we don't get a warning.
Modified:
cfe/trunk/lib/AST/ExprConstant.cpp
Modified: cfe/trunk/lib/AST/ExprConstant.c
sfantao updated this revision to Diff 72117.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D18172
Files:
include/clang/Driver/Compilation.h
lib/Driver/Driver.cpp
lib/Driver/Types.cpp
test/Driver/cuda-bindings.cu
test/Driver/cuda-phases.cu
Index: test/Driver/cuda-phases.
sfantao updated this revision to Diff 72118.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21840
Files:
include/clang/Driver/Action.h
lib/Driver/Driver.cpp
Index: lib/Driver/Driver.cpp
===
--- lib/Driver/Driver.
sfantao updated this revision to Diff 72120.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21845
Files:
lib/Driver/Driver.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
===
--- test/Driver/
sfantao updated this revision to Diff 72119.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21843
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/Action.h
include/clang/Driver/Driver.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/Tool
sfantao updated this revision to Diff 72121.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21847
Files:
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
===
sfantao updated this revision to Diff 72122.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21848
Files:
include/clang/Driver/Compilation.h
include/clang/Driver/ToolChain.h
lib/Driver/Compilation.cpp
lib/Driver/Driver.cpp
lib/Driver/MSVCToolChain.cpp
lib/Driver/ToolCha
sfantao updated this revision to Diff 72124.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21853
Files:
include/clang/Driver/Action.h
include/clang/Driver/Types.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
lib/Driver/Types.cpp
test/Driver/o
sfantao updated this revision to Diff 72123.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21852
Files:
include/clang/Driver/Action.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/ToolChain.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-offload.c
=
sfantao updated this revision to Diff 72125.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21856
Files:
include/clang/Driver/Action.h
include/clang/Driver/ToolChain.h
lib/Driver/Action.cpp
lib/Driver/ToolChain.cpp
lib/Driver/Tools.cpp
lib/Driver/Tools.h
test/Driver/
sfantao updated this revision to Diff 72126.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21857
Files:
include/clang/Driver/Action.h
include/clang/Driver/Driver.h
include/clang/Driver/Tool.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/Tool.cpp
lib/Driver
Author: sfantao
Date: Fri Sep 30 10:34:19 2016
New Revision: 282865
URL: http://llvm.org/viewvc/llvm-project?rev=282865&view=rev
Log:
[CUDA][OpenMP] Add a generic offload action builder
Summary:
This patch proposes a new class to generate and record action dependences
related with offloading. Th
This revision was automatically updated to reflect the committed changes.
sfantao marked an inline comment as done.
Closed by commit rL282865: [CUDA][OpenMP] Add a generic offload action builder
(authored by sfantao).
Changed prior to commit:
https://reviews.llvm.org/D18172?vs=72117&id=73060#to
Author: sfantao
Date: Thu Jan 5 10:02:49 2017
New Revision: 291124
URL: http://llvm.org/viewvc/llvm-project?rev=291124&view=rev
Log:
[OpenMP] Add fields for flags in the offload entry descriptor.
Summary:
This patch adds two fields to the offload entry descriptor. One field is meant
to signal C
sfantao updated this revision to Diff 68086.
sfantao marked 5 inline comments as done.
sfantao added a comment.
- Fix comments and diagnostics.
https://reviews.llvm.org/D13909
Files:
test/CMakeLists.txt
test/Driver/clang-offload-bundler.c
tools/CMakeLists.txt
tools/clang-offload-bundler
sfantao added a comment.
Hi Jonas,
Thanks for the review!
Comment at: test/CMakeLists.txt:27-33
@@ -26,8 +26,9 @@
list(APPEND CLANG_TEST_DEPS
clang clang-headers
clang-format
c-index-test diagtool
clang-tblgen
+ clang-offload-bundler
)
Ha
sfantao updated this revision to Diff 68089.
sfantao marked an inline comment as done.
sfantao added a comment.
- Remove redundant return statement.
https://reviews.llvm.org/D21851
Files:
test/Driver/clang-offload-bundler.c
test/Driver/clang-offload-bundler.c.o
tools/clang-offload-bundler
sfantao added a comment.
Hi Art,
Thanks for the patch! That looks good.
https://reviews.llvm.org/D23526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sfantao
Date: Tue Aug 16 09:31:39 2016
New Revision: 278806
URL: http://llvm.org/viewvc/llvm-project?rev=278806&view=rev
Log:
Add empty --gcc-toolchain empty to cuda-detect test.
Unless we overload the default gcc toolchain with an empty string
the system root used in the tests will be i
Author: sfantao
Date: Tue Aug 16 09:38:39 2016
New Revision: 278811
URL: http://llvm.org/viewvc/llvm-project?rev=278811&view=rev
Log:
Reorder stderr redirection in test command.
Modified:
cfe/trunk/test/Driver/cuda-detect.cu
Modified: cfe/trunk/test/Driver/cuda-detect.cu
URL:
http://llvm.or
sfantao updated this revision to Diff 69124.
sfantao marked an inline comment as done.
sfantao added a comment.
- Add clang-offload bundler as dependency to clang.
https://reviews.llvm.org/D13909
Files:
test/CMakeLists.txt
test/Driver/clang-offload-bundler.c
tools/CMakeLists.txt
tools/c
sfantao added a comment.
Hi Jonas,
Thanks again for the review!
Comment at: test/CMakeLists.txt:27-33
@@ -26,8 +26,9 @@
list(APPEND CLANG_TEST_DEPS
clang clang-headers
clang-format
c-index-test diagtool
clang-tblgen
+ clang-offload-bundler
)
-
Author: sfantao
Date: Wed Aug 24 10:21:05 2016
New Revision: 279632
URL: http://llvm.org/viewvc/llvm-project?rev=279632&view=rev
Log:
clang-offload-bundler - offload files bundling/unbundling tool
Summary:
One of the goals of programming models that support offloading (e.g. OpenMP) is
to enable
Author: sfantao
Date: Wed Aug 24 10:39:07 2016
New Revision: 279634
URL: http://llvm.org/viewvc/llvm-project?rev=279634&view=rev
Log:
[Driver][OpenMP][CUDA] Add capability to bundle object files in sections of the
host binary format.
Summary:
This patch adds the capability to bundle object files
Author: sfantao
Date: Wed Aug 24 10:47:06 2016
New Revision: 279635
URL: http://llvm.org/viewvc/llvm-project?rev=279635&view=rev
Log:
Add target REQUIRES directives to offload bundler test.
Modified:
cfe/trunk/test/Driver/clang-offload-bundler.c
Modified: cfe/trunk/test/Driver/clang-offload
Author: sfantao
Date: Wed Aug 24 13:52:18 2016
New Revision: 279653
URL: http://llvm.org/viewvc/llvm-project?rev=279653&view=rev
Log:
Fix offload bundler tests so that diagnostic can start with caps.
Windows require that.
Modified:
cfe/trunk/test/Driver/clang-offload-bundler.c
Modified: cfe
Author: sfantao
Date: Thu Aug 25 09:35:20 2016
New Revision: 279741
URL: http://llvm.org/viewvc/llvm-project?rev=279741&view=rev
Log:
Fix offload bundler test to support Windows new lines.
Modified:
cfe/trunk/test/Driver/clang-offload-bundler.c
Modified: cfe/trunk/test/Driver/clang-offload-b
sfantao added a comment.
Hi Eugene,
The patch looks good to me. You may wait for someone that could okay the patch
to take a look too.
Thanks,
Samuel
Repository:
rL LLVM
https://reviews.llvm.org/D24165
___
cfe-commits mailing list
cfe-commits@
sfantao added a comment.
Hi Eugene,
The patch looks good to me. You may wait for someone that could okay the patch
to take a look too.
Thanks,
Samuel
Repository:
rL LLVM
https://reviews.llvm.org/D24165
___
cfe-commits mailing list
cfe-commits@
sfantao added a comment.
Hi Justin,
Thanks for the patch.
Comment at: clang/lib/Driver/Driver.cpp:479
+// the device toolchain we create depends on both.
+ToolChain *&CudaTC = ToolChains[CudaTriple.str() + "/" + HostTriple.str()];
+if (!CudaTC) {
I
Author: sfantao
Date: Mon Dec 12 12:00:20 2016
New Revision: 289450
URL: http://llvm.org/viewvc/llvm-project?rev=289450&view=rev
Log:
Fix format and a few typos in comments.
Modified:
cfe/trunk/include/clang-c/Index.h
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
cfe/trunk/lib/Sema/SemaOp
Author: sfantao
Date: Mon Dec 12 13:26:31 2016
New Revision: 289458
URL: http://llvm.org/viewvc/llvm-project?rev=289458&view=rev
Log:
Fix typo and remove unnecessary statement.
Modified:
cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
Modified: cfe/trunk/lib/CodeGen/CGOpenMPRuntime.cpp
URL:
http:
sfantao added a comment.
Hi Hal,
Thanks for the review!
In https://reviews.llvm.org/D21840#555719, @hfinkel wrote:
> The naming here is a bit hard to follow, we have 'dependent action',
> 'dependency action', 'depending action', and I think they're all supposed to
> mean the same thing. Only
sfantao updated this revision to Diff 75698.
sfantao marked 10 inline comments as done.
sfantao added a comment.
- Address Hal Finkel suggestions - rename functions/reorder code/fix comments.
https://reviews.llvm.org/D21840
Files:
include/clang/Driver/Action.h
lib/Driver/Driver.cpp
Index:
sfantao updated this revision to Diff 75705.
sfantao marked an inline comment as done.
sfantao added a comment.
- Address Hal Finkel comments - make diagnostic message more informative.
https://reviews.llvm.org/D21843
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Driver/
sfantao added a comment.
Hi Hal,
Thanks for the review!
Comment at: include/clang/Basic/DiagnosticDriverKinds.td:163
+def err_drv_expecting_fopenmp_with_fopenmp_targets : Error<
+ "The option -fopenmp-targets must be used in conjunction with a -fopenmp
option compatible with
sfantao added a comment.
Hi Hal,
Thanks for the review! Fixed the typos in the new diff.
Comment at: lib/Driver/Driver.cpp:1949
+SpecializedBuilders.push_back(new OpenMPActionBuilder(C, Args, Inputs));
+
//
hfinkel wrote:
> Since we can have both Open
sfantao updated this revision to Diff 75722.
sfantao marked 7 inline comments as done.
sfantao added a comment.
- Fix typos and add test tht checks phases when OpenMP and CUDA are used
simultaneously.
https://reviews.llvm.org/D21845
Files:
lib/Driver/Driver.cpp
test/Driver/openmp-offload.c
sfantao updated this revision to Diff 75730.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Address Hal Finkel comments - fix comments/fix linker script comment.
https://reviews.llvm.org/D21847
Files:
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
lib/Driver/T
sfantao added a comment.
Hi Hal,
Thanks for the review! Comments inlined.
Comment at: lib/Driver/Tools.cpp:334
+ LksStream << " OpenMP Offload Linker Script.\n";
+ LksStream << "*/\n";
+ LksStream << "TARGET(binary)\n";
hfinkel wrote:
> We should also say
sfantao updated this revision to Diff 75732.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Fix typos and check -dynamic when it comes to translating arguments for
offloading gcc toolchains.
https://reviews.llvm.org/D21848
Files:
include/clang/Driver/Compilation.h
inc
sfantao added a comment.
Hi Hal,
Thanks for the review!
Comment at: lib/Driver/ToolChains.cpp:2854
+ case options::OPT_shared:
+ case options::OPT_static:
+ case options::OPT_fPIC:
hfinkel wrote:
> And also?
>
> case options::OPT_dynamic:
Oh,
sfantao marked 7 inline comments as done.
sfantao added a comment.
Hi Hal,
Thanks for the review! Comments inlined.
Comment at: include/clang/Driver/Action.h:504
+ /// unbundling action.
+ struct DependingActionInfoTy final {
+/// \brief The tool chain of the depending a
sfantao updated this revision to Diff 75741.
sfantao marked 3 inline comments as done.
sfantao added a comment.
- Fix typos and use StringRef() instead of const char * to follow what the
Driver does today when it comes to specify the bound architectures.
https://reviews.llvm.org/D21853
Files:
sfantao added a comment.
Hi Justin
Thanks for letting me know. I'm looking into it.
Thanks again,
Samuel
Repository:
rL LLVM
https://reviews.llvm.org/D18172
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/m
Author: sfantao
Date: Wed Oct 26 19:53:34 2016
New Revision: 285263
URL: http://llvm.org/viewvc/llvm-project?rev=285263&view=rev
Log:
Fix bug when compiling CUDA code with -emit-llvm and -o.
In this case the device code is not injected into an host action and therefore
the
user should get an e
Author: sfantao
Date: Wed Oct 26 20:08:58 2016
New Revision: 285264
URL: http://llvm.org/viewvc/llvm-project?rev=285264&view=rev
Log:
Remove check for -o option in offloading actions builder.
This check is also present when jobs are built, so the offloading builder check
is not needed anymore.
sfantao added a comment.
In https://reviews.llvm.org/D18172#580276, @jlebar wrote:
> Hi, Samuel.
>
> This change introduced a new crash / assertion failure in the driver.
>
> $ echo | llvm-run clang -emit-llvm -c -x cuda - -o /dev/null
>
>
> Before this patch, we get an error (perhaps not as
Author: sfantao
Date: Thu Oct 27 11:29:20 2016
New Revision: 285307
URL: http://llvm.org/viewvc/llvm-project?rev=285307&view=rev
Log:
[Driver][CUDA][OpenMP] Reimplement tool selection in the driver.
Summary:
This creates a tool selector in the driver that replaces the existing one. The
goal is t
Author: sfantao
Date: Thu Oct 27 11:38:05 2016
New Revision: 285311
URL: http://llvm.org/viewvc/llvm-project?rev=285311&view=rev
Log:
[Driver][OpenMP] Create tool chains for OpenMP offloading kind.
Summary: This patch adds new logic to create the necessary tool chains to
support offloading for O
Author: sfantao
Date: Thu Oct 27 12:08:03 2016
New Revision: 285314
URL: http://llvm.org/viewvc/llvm-project?rev=285314&view=rev
Log:
[Driver][OpenMP] Add specialized action builder for OpenMP offloading actions.
Summary:
This patch adds a new specialized action builder to create OpenMP offloadin
sfantao updated this revision to Diff 76061.
sfantao marked 2 inline comments as done.
sfantao added a comment.
- Capitalize Clang in linker script comment and explain that the linker script
dump option is required to test the driver with -###.
https://reviews.llvm.org/D21847
Files:
include/
sfantao updated this revision to Diff 76062.
sfantao added a comment.
- Capitalize Clang in the regression test too.
https://reviews.llvm.org/D21847
Files:
include/clang/Driver/Options.td
lib/Driver/Driver.cpp
lib/Driver/Tools.cpp
test/Driver/openmp-offload.c
Index: test/Driver/openmp-
Author: sfantao
Date: Thu Oct 27 12:31:22 2016
New Revision: 285319
URL: http://llvm.org/viewvc/llvm-project?rev=285319&view=rev
Log:
[Driver][OpenMP] Build jobs for OpenMP offloading actions for targets using gcc
tool chains.
Summary:
This patch adds logic to create jobs for OpenMP offloading a
Author: sfantao
Date: Thu Oct 27 12:39:44 2016
New Revision: 285320
URL: http://llvm.org/viewvc/llvm-project?rev=285320&view=rev
Log:
[Driver][OpenMP] Add logic for offloading-specific argument translation.
Summary:
This patch includes support for argument translation that is specific of a
given
Author: sfantao
Date: Thu Oct 27 12:50:43 2016
New Revision: 285323
URL: http://llvm.org/viewvc/llvm-project?rev=285323&view=rev
Log:
[Driver][OpenMP] Update actions builder to create bundling action when
necessary.
Summary:
In order to save the user from dealing with multiple output files (for
Author: sfantao
Date: Thu Oct 27 13:00:51 2016
New Revision: 285324
URL: http://llvm.org/viewvc/llvm-project?rev=285324&view=rev
Log:
[Driver][OpenMP] Update actions builder to create unbundling action when
necessary.
Summary:
Each time that offloading support is requested by the user and the in
sfantao updated this revision to Diff 76064.
sfantao marked an inline comment as done.
sfantao added a comment.
- Add comment explaing that the bundler tool can detect if the input file is a
bundle or not.
https://reviews.llvm.org/D21853
Files:
include/clang/Driver/Action.h
include/clang/D
Author: sfantao
Date: Thu Oct 27 13:04:42 2016
New Revision: 285325
URL: http://llvm.org/viewvc/llvm-project?rev=285325&view=rev
Log:
[Driver][OpenMP] Add support to create jobs for bundling actions.
Summary: This patch adds the support to create a job for the
`OffloadBundlingAction` which will
Author: sfantao
Date: Thu Oct 27 13:14:55 2016
New Revision: 285326
URL: http://llvm.org/viewvc/llvm-project?rev=285326&view=rev
Log:
[Driver][OpenMP] Add support to create jobs for unbundling actions.
Summary:
This patch adds the support to create jobs for the `OffloadBundlingAction`
which will
sfantao updated this revision to Diff 76069.
sfantao added a comment.
- Rebase.
https://reviews.llvm.org/D21857
Files:
include/clang/Driver/Action.h
include/clang/Driver/Driver.h
include/clang/Driver/Tool.h
lib/Driver/Action.cpp
lib/Driver/Driver.cpp
lib/Driver/Tool.cpp
lib/Driver
Author: sfantao
Date: Thu Oct 27 13:29:57 2016
New Revision: 285327
URL: http://llvm.org/viewvc/llvm-project?rev=285327&view=rev
Log:
Use -fopenmp=libomp in all OpenMP offloading tests.
This will make sure the right features are being tested even for machines that
default to libgomp.
Modified:
sfantao added a comment.
A PR was generated as requested by Hal explaining why we do not generate jobs
for NVPTX targets yet.
https://llvm.org/bugs/show_bug.cgi?id=30812
https://reviews.llvm.org/D21845
___
cfe-commits mailing list
cfe-commits@list
sfantao abandoned this revision.
sfantao marked 8 inline comments as done.
sfantao added a comment.
Hi Jonas,
In https://reviews.llvm.org/D9888#581809, @Hahnfeld wrote:
> I think these changes have been contributed to trunk in multiple commits so
> this can be closed?
You're right, this can b
Author: sfantao
Date: Fri Oct 28 10:11:50 2016
New Revision: 285404
URL: http://llvm.org/viewvc/llvm-project?rev=285404&view=rev
Log:
Change OpenMP offload driver tests so that it doesn't use the full file path
during tests.
This was causing failures on windows bots.
Modified:
cfe/trunk/te
sfantao added a comment.
Hi Michael,
In https://reviews.llvm.org/D21845#581988, @mkuron wrote:
> I think `OffloadAction::DeviceDependences::add(..., ...,
> /*BoundArch=*/nullptr, Action::OFK_OpenMP)` is never sufficient. The invalid
> `BoundArch` eventually ends up in `NVPTX::Assembler::Constr
Author: sfantao
Date: Fri Oct 28 10:42:38 2016
New Revision: 285408
URL: http://llvm.org/viewvc/llvm-project?rev=285408&view=rev
Log:
Define extra variable in OpenMP offloading driver tests.
Modified:
cfe/trunk/test/Driver/openmp-offload.c
Modified: cfe/trunk/test/Driver/openmp-offload.c
URL
Author: sfantao
Date: Thu Nov 3 10:41:50 2016
New Revision: 285925
URL: http://llvm.org/viewvc/llvm-project?rev=285925&view=rev
Log:
Rename the version of ConstructJob for multiple outputs to
ConstructJobMultipleOutputs.
It was causing trouble with the GCC bots.
Modified:
cfe/trunk/include
Author: sfantao
Date: Mon Sep 14 12:41:32 2015
New Revision: 247584
URL: http://llvm.org/viewvc/llvm-project?rev=247584&view=rev
Log:
Update cxx-irgen.cpp test to allow signext in alwaysinline functions.
This was causing an error in Power8 targets.
Modified:
cfe/trunk/test/Modules/cxx-irgen.
sfantao created this revision.
sfantao added reviewers: ABataev, hfinkel, rjmccall.
sfantao added subscribers: cfe-commits, Hahnfeld.
This patch rebases and creates a new revision for
http://reviews.llvm.org/D11361 as requested by John.
Here's the adapted original summary (the global captures is
sfantao abandoned this revision.
sfantao added a comment.
Closing revision. It has been replaced by http://reviews.llvm.org/D12871 has
suggested by John.
Thanks!
Samuel
http://reviews.llvm.org/D11361
___
cfe-commits mailing list
cfe-commits@lists.
sfantao updated this revision to Diff 34869.
sfantao added a comment.
Update code to use implicit parameters for the captured variables using
`GenerateOpenMPCapturedStmtFunction`, similarly to what is done to other
directives.
`UseOnlyReferences` boolean was added to `GenerateOpenMPCapturedStm
sfantao updated the summary for this revision.
sfantao updated this revision to Diff 34870.
sfantao added a comment.
Rebase with the last changes in http://reviews.llvm.org/D12871.
http://reviews.llvm.org/D12262
Files:
include/clang/Basic/OpenMPKinds.h
include/clang/Sema/Sema.h
lib/Basic/
sfantao updated this revision to Diff 34933.
sfantao added a comment.
Minor changes to address Alexey's remarks.
http://reviews.llvm.org/D12871
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
lib/CodeGen/CodeGenFunction.h
test/OpenMP/t
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054
@@ +3043,13 @@
+
+ if (auto *VAT = dyn_cast(ElementType.getTypePtr())) {
+auto VATInfo = CGF.getVLASize(VAT);
+Size = llvm::ConstantInt::get(
+CGM.SizeTy,
+
sfantao added inline comments.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:80-81
@@ -67,1 +79,4 @@
II = &getContext().Idents.get("vla");
+ if (UseOnlyReferences)
+ArgType = getContext().getLValueReferenceType(
+ArgType, /*SpelledAsLValue=*/false);
sfantao updated this revision to Diff 34936.
sfantao added a comment.
Fix imprecision in previous diff.
http://reviews.llvm.org/D12871
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
lib/CodeGen/CodeGenFunction.h
test/OpenMP/target_cod
sfantao added inline comments.
Comment at: lib/CodeGen/CGStmtOpenMP.cpp:121-123
@@ -103,4 +120,5 @@
+ArgLVal.getAddress(), ArgLVal.getType()->castAs());
auto *ExprArg =
EmitLoadOfLValue(ArgLVal, SourceLocation()).getScalarVal();
auto VAT = FD->
sfantao updated the summary for this revision.
sfantao updated this revision to Diff 34955.
sfantao added a comment.
Rebase on top of last changes in http://reviews.llvm.org/D12871.
http://reviews.llvm.org/D12614
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/LangOp
sfantao updated this revision to Diff 35121.
sfantao added a comment.
Update if clause emission for target directive following Alexey's remark.
http://reviews.llvm.org/D12871
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
lib/CodeGen/Co
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054
@@ +3043,13 @@
+
+ if (auto *VAT = dyn_cast(ElementType.getTypePtr())) {
+auto VATInfo = CGF.getVLASize(VAT);
+Size = llvm::ConstantInt::get(
+CGM.SizeTy,
+
sfantao updated this revision to Diff 36263.
sfantao added a comment.
This diff refactors the original patch and is rebased on top of the latests
offloading changes inserted for CUDA.
Here I don't touch the CUDA support. I tried, however, to have the
implementation modular enough so that it cou
sfantao updated this revision to Diff 36317.
sfantao added a comment.
Address Alexey's remarks from last review.
http://reviews.llvm.org/D12871
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
lib/CodeGen/CodeGenFunction.h
test/OpenMP/t
sfantao added inline comments.
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3044-3054
@@ +3043,13 @@
+Sizes.push_back(Size);
+MapTypes.push_back(MapType);
+ }
+
+ // Keep track on whether the host function has to be executed.
+ auto OffloadErrorQType =
+ CGF.getCont
Author: sfantao
Date: Fri Oct 2 11:14:20 2015
New Revision: 249148
URL: http://llvm.org/viewvc/llvm-project?rev=249148&view=rev
Log:
[OpenMP] Target directive host codegen.
This patch implements the outlining for offloading functions for code
annotated with the OpenMP target directive. It uses
sfantao closed this revision.
sfantao added a comment.
Committed in r249148!
Thanks,
Samuel
http://reviews.llvm.org/D12871
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: sfantao
Date: Fri Oct 2 12:14:03 2015
New Revision: 249154
URL: http://llvm.org/viewvc/llvm-project?rev=249154&view=rev
Log:
[OpenMP] Capture global variables in target regions.
All global variables that are not enclosed in a declare target region
must be captured in the target region a
sfantao closed this revision.
sfantao added a comment.
Committed in r249154.
Thanks!
Samuel
http://reviews.llvm.org/D12262
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sfantao updated this revision to Diff 36410.
sfantao added a comment.
Fix bug for when no offloading triples are specified.
http://reviews.llvm.org/D12614
Files:
include/clang/Basic/DiagnosticDriverKinds.td
include/clang/Basic/LangOptions.def
include/clang/Basic/LangOptions.h
include/cl
sfantao updated this revision to Diff 32211.
sfantao added a comment.
This patch tries to avoid as much as possible changing the common
infrastructure, by adapting the CapturedDecl creation in SEMA and by adding
support to a second type of capture - ImplicitParamDecl (on top of the existent
Fie
sfantao added a comment.
Alexey, John,
Thanks for the review! I've tried to address your concerns in the last diff.
Please, check the inlined comments to find answers for the remarks of the
previous diff.
Thanks again!
Samuel
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:863-8
sfantao updated this revision to Diff 32322.
sfantao added a comment.
Adress reviewers concerns.
Also fix issue with target regions with no arguments and in the VLA size
computation I found in the meantime.
http://reviews.llvm.org/D11361
Files:
include/clang/AST/Decl.h
include/clang/AST/S
sfantao added a comment.
Alexey,
Thanks for the review! Find my comments inlined.
Thanks again!
Samuel
Comment at: lib/CodeGen/CGExpr.cpp:1969
@@ -1945,3 +1968,3 @@
else
- return EmitCapturedFieldLValue(*this, CapturedStmtInfo->lookup(VD),
-
sfantao updated this revision to Diff 32796.
sfantao added a comment.
Implement proxy function for target directive.
Move the creation of the target region parameters from
`CGOpenMPRuntime::emitTargetCall` to CodeGenFunction::EmitTargetDirective
because we need to access the VLA Maps of the tar
sfantao added a comment.
Thanks for review. The new diff now uses a proxy function. See other comments
inlined.
Thanks again!
Samuel
Comment at: lib/CodeGen/CGExpr.cpp:1969-1970
@@ -1945,4 +1968,4 @@
else
- return EmitCapturedFieldLValue(*this, CapturedStmtIn
sfantao updated this revision to Diff 32843.
sfantao added a comment.
Address reviewer concerns.
http://reviews.llvm.org/D11361
Files:
lib/CodeGen/CGOpenMPRuntime.cpp
lib/CodeGen/CGOpenMPRuntime.h
lib/CodeGen/CGStmtOpenMP.cpp
test/OpenMP/target_codegen.cpp
Index: test/OpenMP/target_cod
sfantao added a comment.
In http://reviews.llvm.org/D11361#229744, @ABataev wrote:
> Another one thing I forget to mention. Current implementation of
> CGOpenMPRuntime is libomp-specific. You're trying to add functionality that
> is libtarget-specific. Maybe it is a good idea to separate suppor
sfantao created this revision.
sfantao added reviewers: ABataev, rjmccall, hfinkel.
sfantao added a subscriber: cfe-commits.
All global variables that are not enclosed in a declare target region must be
captured in the target region as local variables do. Currently, there is no
support for decla
sfantao added a comment.
Two more inlined comments that I forgot to integrate in my previous response.
Thanks!
Samuel
Comment at: lib/CodeGen/CGOpenMPRuntime.h:190-204
@@ -180,2 +189,17 @@
+ /// \brief Values for bit flags used to specify the mapping type for
+ /// offloading
sfantao created this revision.
sfantao added reviewers: ABataev, rjmccall, hfinkel.
sfantao added a subscriber: cfe-commits.
All the offloading information is bundled into a descriptor that is passed to
the runtime library so that it can extract all the binaries and map variables
properly. This
1 - 100 of 453 matches
Mail list logo
