[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi created this revision. bazuzi added reviewers: ymandel, gribozavr2, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. bazuzi requested review of this revision. Herald added a project: clang. This allows for use of the same solver used by the DAC for additional solving p

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi updated this revision to Diff 536269. bazuzi added a comment. Updated function comment to remove unnecessary repetition and include newly-discovered caveat re: flow conditions. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153805/new/ https

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi updated this revision to Diff 536293. bazuzi added a comment. Rebase on main to pull in change from DenseSet to SetVector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153805/new/ https://reviews.llvm.org/D153805 Files: clang/include/cla

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:183 + /// been stored in flow conditions. + Solver::Result querySolver(llvm::DenseSet Constraints); + sammccall wrote: > sammccall wrote: > > FWIW, I

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi added a comment. It looks like D153485 changes the context for the last few comments significantly. What's the appetite for adding yet another child commit to the chain D153485 is in that exposes the solver directly? I

[PATCH] D153805: Expose DataflowAnalysisContext.querySolver().

bazuzi added a comment. Since the timeline for being able to use this is dependent not only on commits but integrates as well, lets go ahead with this then. Can someone commit it for me when we're ready? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.or

[PATCH] D149869: [clang][dataflow] Remove deprecated pass-through APIs for DataflowAnalysisContext.

bazuzi created this revision. bazuzi added reviewers: ymandel, gribozavr2, xazax.hun. Herald added subscribers: martong, rnkovacs. Herald added a reviewer: NoQ. Herald added a project: All. bazuzi requested review of this revision. Herald added a project: clang. These were recently deprecated in h

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

bazuzi created this revision. bazuzi added reviewers: ymandel, gribozavr2. Herald added subscribers: martong, xazax.hun. Herald added a reviewer: NoQ. Herald added a project: All. bazuzi requested review of this revision. Herald added a project: clang. This will eliminate the need for more pass-th

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

bazuzi added a comment. Thanks! Seems like you have commit access, Yitzie; could you commit this for me as "Samira Bazuzi "? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149464/new/ https://reviews.llvm.org/D149464 __

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

bazuzi added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowEnvironment.h:189 + /// Deprecated. Use *getDataflowAnalysisContext().getOptions().Log instead. Logger &logger() const { return *DACtx->getOptions().Log; } xazax.hu

[PATCH] D149464: [clang][dataflow] Expose DataflowAnalysisContext from DataflowEnvironment.

bazuzi updated this revision to Diff 518547. bazuzi added a comment. Use LLVM_DEPRECATED in place of comments indicating deprecation. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D149464/new/ https://reviews.llvm.org/D149464 Files: clang/include