[clang-tools-extra] r343845 - [clangd] Remove debugging output in test

Author: sammccall Date: Fri Oct 5 05:22:40 2018 New Revision: 343845 URL: http://llvm.org/viewvc/llvm-project?rev=343845&view=rev Log: [clangd] Remove debugging output in test Modified: clang-tools-extra/trunk/unittests/clangd/SerializationTests.cpp Modified: clang-tools-extra/trunk/unittes

Re: [clang-tools-extra] r343778 - [clangd] clangd-indexer gathers refs and stores them in index files.

(s) > 0x76C159CD (0x 0x > 0x 0x), BaseThreadInitThunk() + 0xD bytes(s) > 0x76E7385D (0x0000 0x000000000000 > 0x 0x), RtlUserThreadStart() + 0x1D bytes(s) > >

[clang-tools-extra] r343849 - [clangd] Remove last usage of ast matchers from SymbolCollector. NFC

Author: sammccall Date: Fri Oct 5 07:03:04 2018 New Revision: 343849 URL: http://llvm.org/viewvc/llvm-project?rev=343849&view=rev Log: [clangd] Remove last usage of ast matchers from SymbolCollector. NFC Modified: clang-tools-extra/trunk/clangd/index/SymbolCollector.cpp Modified: clang-tool

[clang-tools-extra] r344030 - [clangd] Fix nondeterministic test

Author: sammccall Date: Tue Oct 9 03:02:02 2018 New Revision: 344030 URL: http://llvm.org/viewvc/llvm-project?rev=344030&view=rev Log: [clangd] Fix nondeterministic test Modified: clang-tools-extra/trunk/unittests/clangd/DexTests.cpp Modified: clang-tools-extra/trunk/unittests/clangd/DexTes

Re: [clang-tools-extra] r* - [clangd]*

Thanks! Fixed in r344030. On Tue, Oct 9, 2018 at 12:28 AM Artem Dergachev via cfe-commits < cfe-commits@lists.llvm.org> wrote: > Hi all, > > Just wanted to attract attention to the clangd test failure at > http://lab.llvm.org:8080/green/job/clang-stage1-cmake-RA-expensive/12782/ > > Buildbots wer

Re: [PATCH] D56611: [clangd] A code action to swap branches of an if statement

Thanks! I suspect shared libraries makes a difference here, because the tweaks use an unusual library type (object library) to force linking. On Fri, Feb 1, 2019 at 3:01 AM Nathan Ridge via Phabricator < revi...@reviews.llvm.org> wrote: > nridge added a comment. > > Fix here: https://reviews.llvm

[clang-tools-extra] r352837 - [clangd] Fix crash in applyTweak, remove TweakID alias.

Author: sammccall Date: Thu Jan 31 21:41:50 2019 New Revision: 352837 URL: http://llvm.org/viewvc/llvm-project?rev=352837&view=rev Log: [clangd] Fix crash in applyTweak, remove TweakID alias. Strings are complicated, giving them opaque names makes us forget they're complicated. Modified: cla

[clang-tools-extra] r352857 - [clangd] Unbreak fuzzer target

Author: sammccall Date: Fri Feb 1 03:09:06 2019 New Revision: 352857 URL: http://llvm.org/viewvc/llvm-project?rev=352857&view=rev Log: [clangd] Unbreak fuzzer target Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer

[clang-tools-extra] r352863 - [clangd] Use delimited style to make life easier for the fuzzer

Author: sammccall Date: Fri Feb 1 03:20:20 2019 New Revision: 352863 URL: http://llvm.org/viewvc/llvm-project?rev=352863&view=rev Log: [clangd] Use delimited style to make life easier for the fuzzer Modified: clang-tools-extra/trunk/clangd/fuzzer/ClangdFuzzer.cpp Modified: clang-tools-extra

[clang-tools-extra] r352864 - [clangd] Implement textDocument/declaration from LSP 3.14

Author: sammccall Date: Fri Feb 1 03:26:13 2019 New Revision: 352864 URL: http://llvm.org/viewvc/llvm-project?rev=352864&view=rev Log: [clangd] Implement textDocument/declaration from LSP 3.14 Summary: LSP now reflects the declaration/definition distinction. Language server changes: - textDocu

[clang-tools-extra] r352868 - [clangd] Penalize file-scope symbols in the ranking for non-completion queries

Author: sammccall Date: Fri Feb 1 05:07:37 2019 New Revision: 352868 URL: http://llvm.org/viewvc/llvm-project?rev=352868&view=rev Log: [clangd] Penalize file-scope symbols in the ranking for non-completion queries Patch by Nathan Ridge! Differential Revision: https://reviews.llvm.org/D56653 Mo

[clang-tools-extra] r352874 - [clangd] Lib to compute and represent selection under cursor.

Author: sammccall Date: Fri Feb 1 07:05:11 2019 New Revision: 352874 URL: http://llvm.org/viewvc/llvm-project?rev=352874&view=rev Log: [clangd] Lib to compute and represent selection under cursor. Summary: The primary problem this solves is to expose the codeAction selection to AST-based refacto

[clang-tools-extra] r352875 - [clangd] Lib to compute and represent selection under cursor.

Author: sammccall Date: Fri Feb 1 07:09:41 2019 New Revision: 352875 URL: http://llvm.org/viewvc/llvm-project?rev=352875&view=rev Log: [clangd] Lib to compute and represent selection under cursor. Summary: The primary problem this solves is to expose the codeAction selection to AST-based refacto

[clang-tools-extra] r352876 - [clangd] Expose SelectionTree to code tweaks, and use it for swap if branches.

Author: sammccall Date: Fri Feb 1 07:09:47 2019 New Revision: 352876 URL: http://llvm.org/viewvc/llvm-project?rev=352876&view=rev Log: [clangd] Expose SelectionTree to code tweaks, and use it for swap if branches. Summary: This reduces the per-check implementation burden and redundant work. It a

[clang-tools-extra] r352953 - [Clangd] textDocument/definition and textDocument/declaration "bounce" between definition and declaration location when they are distinct.

Author: sammccall Date: Fri Feb 1 21:56:00 2019 New Revision: 352953 URL: http://llvm.org/viewvc/llvm-project?rev=352953&view=rev Log: [Clangd] textDocument/definition and textDocument/declaration "bounce" between definition and declaration location when they are distinct. Summary: This helps m

Re: [PATCH] D56370: [clangd] Add support for type hierarchy (super types only for now)

(Sorry, hit enter too soon and truncated one of the comments) On Mon, Feb 11, 2019 at 10:32 AM Sam McCall via Phabricator < revi...@reviews.llvm.org> wrote: > sammccall added a comment. > > In D56370#1391924 , @nridge > wrote: > > > As far as reworking the

[clang-tools-extra] r353821 - [clangd] Fix use-after-free in XRefs

Author: sammccall Date: Tue Feb 12 02:38:45 2019 New Revision: 353821 URL: http://llvm.org/viewvc/llvm-project?rev=353821&view=rev Log: [clangd] Fix use-after-free in XRefs Modified: clang-tools-extra/trunk/clangd/XRefs.cpp Modified: clang-tools-extra/trunk/clangd/XRefs.cpp URL: http://llvm

r354102 - [Analysis] -Wunreachable-code shouldn't fire on the increment of a foreach loop

Author: sammccall Date: Thu Feb 14 23:16:11 2019 New Revision: 354102 URL: http://llvm.org/viewvc/llvm-project?rev=354102&view=rev Log: [Analysis] -Wunreachable-code shouldn't fire on the increment of a foreach loop Summary: The idea is that the code here isn't written, so doesn't indicate a bug.

r354109 - Revert "[Analysis] -Wunreachable-code shouldn't fire on the increment of a foreach loop"

Author: sammccall Date: Fri Feb 15 01:18:49 2019 New Revision: 354109 URL: http://llvm.org/viewvc/llvm-project?rev=354109&view=rev Log: Revert "[Analysis] -Wunreachable-code shouldn't fire on the increment of a foreach loop" This reverts commit r354102. Modified: cfe/trunk/lib/Analysis/Reac

[clang-tools-extra] r354116 - [clangd] Unlink VFS working dir from OS working dir. Reland of r351051

Author: sammccall Date: Fri Feb 15 03:04:25 2019 New Revision: 354116 URL: http://llvm.org/viewvc/llvm-project?rev=354116&view=rev Log: [clangd] Unlink VFS working dir from OS working dir. Reland of r351051 Modified: clang-tools-extra/trunk/clangd/FSProvider.cpp Modified: clang-tools-extra/t

Re: r312750 - [Sema] -Wtautological-compare: handle comparison of unsigned with 0S.

Nice fix! It catches a lot of new cases on our codebase, all technically correct so far. A couple of issues though: A) Rollout - until we've completely cleaned up, we need to disable -Wtautological-compare entirely, which is a valuable check. I imagine anyone else using -Werror is in the same boat

Re: [PATCH] D62814: [clangd] Treat lambdas as functions when preparing hover response

AST dump doesn't traverse into typelocs, which is where x is. That said, this particular case is not worth any complexity at all. Even pointer-to-lambda is vanishingly rare. Regarding dropping ref/pointer info: one option here is keeping the old "class (lambda)&", and simply making sure we now po

r362785 - [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods.

Author: sammccall Date: Fri Jun 7 02:45:17 2019 New Revision: 362785 URL: http://llvm.org/viewvc/llvm-project?rev=362785&view=rev Log: [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods. Summary: - when a method is not available because of the target value kind

r362924 - Revert "Revert "[CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods.""

Author: sammccall Date: Mon Jun 10 02:52:09 2019 New Revision: 362924 URL: http://llvm.org/viewvc/llvm-project?rev=362924&view=rev Log: Revert "Revert "[CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods."" This reverts commit r362830, and relands r362785 with th

Re: r362785 - [CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods.

> On Fri, Jun 7, 2019 at 2:42 AM Sam McCall via cfe-commits < > cfe-commits@lists.llvm.org> wrote: > >> Author: sammccall >> Date: Fri Jun 7 02:45:17 2019 >> New Revision: 362785 >> >> URL: http://llvm.org/viewvc/llvm-project?rev=362785&view=rev >&

[clang-tools-extra] r362934 - [clangd] Stop marshalling/requiring FormattingOptions. We never did anything with them.

Author: sammccall Date: Mon Jun 10 06:01:49 2019 New Revision: 362934 URL: http://llvm.org/viewvc/llvm-project?rev=362934&view=rev Log: [clangd] Stop marshalling/requiring FormattingOptions. We never did anything with them. Modified: clang-tools-extra/trunk/clangd/Protocol.cpp clang-tool

[clang-tools-extra] r362939 - [clangd] Revamp textDocument/onTypeFormatting.

Author: sammccall Date: Mon Jun 10 07:26:21 2019 New Revision: 362939 URL: http://llvm.org/viewvc/llvm-project?rev=362939&view=rev Log: [clangd] Revamp textDocument/onTypeFormatting. Summary: The existing implementation (which triggers on }) is fairly simple and has flaws: - doesn't trigger freq

r362944 - Revert "[CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods."

Author: sammccall Date: Mon Jun 10 07:55:57 2019 New Revision: 362944 URL: http://llvm.org/viewvc/llvm-project?rev=362944&view=rev Log: Revert "[CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods." This reverts commit r362924, which causes a double-free of Shadow

r362950 - Re-land "[CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods."

Author: sammccall Date: Mon Jun 10 08:17:52 2019 New Revision: 362950 URL: http://llvm.org/viewvc/llvm-project?rev=362950&view=rev Log: Re-land "[CodeComplete] Improve overload handling for C++ qualified and ref-qualified methods." ShadowMapEntry is now really, truly a normal class. Modified:

[clang-tools-extra] r362978 - [clangd] Remove old hidden -use-dex-index flag

Author: sammccall Date: Mon Jun 10 13:38:16 2019 New Revision: 362978 URL: http://llvm.org/viewvc/llvm-project?rev=362978&view=rev Log: [clangd] Remove old hidden -use-dex-index flag Modified: clang-tools-extra/trunk/clangd/ClangdServer.h clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp

[clang-tools-extra] r363664 - [clangd] Add a capability to enable completions with fixes.

Author: sammccall Date: Tue Jun 18 04:57:26 2019 New Revision: 363664 URL: http://llvm.org/viewvc/llvm-project?rev=363664&view=rev Log: [clangd] Add a capability to enable completions with fixes. Reviewers: ilya-biryukov Subscribers: MaskRay, jkorous, arphaman, kadircet, cfe-commits Tags: #clan

[clang-tools-extra] r363680 - [clangd] Add hidden tweaks to dump AST/selection.

Author: sammccall Date: Tue Jun 18 06:37:54 2019 New Revision: 363680 URL: http://llvm.org/viewvc/llvm-project?rev=363680&view=rev Log: [clangd] Add hidden tweaks to dump AST/selection. Summary: This introduces a few new concepts: - tweaks have an Intent (they don't all advertise as refactorings

[clang-tools-extra] r363765 - [clangd] Add ClangdServer accessor for buffer contents

Author: sammccall Date: Wed Jun 19 00:29:05 2019 New Revision: 363765 URL: http://llvm.org/viewvc/llvm-project?rev=363765&view=rev Log: [clangd] Add ClangdServer accessor for buffer contents Modified: clang-tools-extra/trunk/clangd/ClangdServer.cpp clang-tools-extra/trunk/clangd/ClangdSer

[clang-tools-extra] r363766 - Revert "[clangd] Return vector from applyTweak. NFC"

Author: sammccall Date: Wed Jun 19 00:29:10 2019 New Revision: 363766 URL: http://llvm.org/viewvc/llvm-project?rev=363766&view=rev Log: Revert "[clangd] Return vector from applyTweak. NFC" This reverts commit r363691. Modified: clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp clang-too

r365887 - [JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from parsed commands.

Author: sammccall Date: Fri Jul 12 03:11:40 2019 New Revision: 365887 URL: http://llvm.org/viewvc/llvm-project?rev=365887&view=rev Log: [JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from parsed commands. Summary: It's common to use compiler wrappers by setting CC="gomacc clang++"

[clang-tools-extra] r365888 - [clangd] Prioritize indexing of files that share a basename with the open file.

Author: sammccall Date: Fri Jul 12 03:18:42 2019 New Revision: 365888 URL: http://llvm.org/viewvc/llvm-project?rev=365888&view=rev Log: [clangd] Prioritize indexing of files that share a basename with the open file. Summary: In practice, opening Foo.h will still often result in Foo.cpp making the

[clang-tools-extra] r365955 - [clangd] Fix off-by-one in CodeComplete and assertion in Dex

Author: sammccall Date: Fri Jul 12 13:35:41 2019 New Revision: 365955 URL: http://llvm.org/viewvc/llvm-project?rev=365955&view=rev Log: [clangd] Fix off-by-one in CodeComplete and assertion in Dex Modified: clang-tools-extra/trunk/clangd/CodeComplete.cpp clang-tools-extra/trunk/clangd/ind

r365975 - Re-land [JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from parsed commands.

Author: sammccall Date: Fri Jul 12 16:38:31 2019 New Revision: 365975 URL: http://llvm.org/viewvc/llvm-project?rev=365975&view=rev Log: Re-land [JSONCompilationDatabase] Strip distcc/ccache/gomacc wrappers from parsed commands. Use //net/dir like other test cases for windows compatibility Modif

[clang-tools-extra] r366199 - [clangd] Don't rebuild background index until we indexed one TU per thread.

Author: sammccall Date: Tue Jul 16 03:17:06 2019 New Revision: 366199 URL: http://llvm.org/viewvc/llvm-project?rev=366199&view=rev Log: [clangd] Don't rebuild background index until we indexed one TU per thread. Summary: This increases the odds that the boosted file (cpp file matching header) wil

r366200 - [SemaTemplate] Fix uncorrected typos after pack expansion

Author: sammccall Date: Tue Jul 16 03:30:21 2019 New Revision: 366200 URL: http://llvm.org/viewvc/llvm-project?rev=366200&view=rev Log: [SemaTemplate] Fix uncorrected typos after pack expansion Summary: This case is particularly important for clangd, as it is triggered after inserting the snippet

[clang-tools-extra] r366311 - [clangd] Fix error message in tweaktests to be useful. NFC

Author: sammccall Date: Wed Jul 17 03:17:47 2019 New Revision: 366311 URL: http://llvm.org/viewvc/llvm-project?rev=366311&view=rev Log: [clangd] Fix error message in tweaktests to be useful. NFC Modified: clang-tools-extra/trunk/clangd/unittests/TweakTests.cpp Modified: clang-tools-extra/tru

[clang-tools-extra] r366321 - [clangd] Force the required interpretation of #import on windows tests.

Author: sammccall Date: Wed Jul 17 06:21:25 2019 New Revision: 366321 URL: http://llvm.org/viewvc/llvm-project?rev=366321&view=rev Log: [clangd] Force the required interpretation of #import on windows tests. Summary: NFC but should fix a bunch of tests. Reviewers: kadircet Subscribers: ilya-bir

r366409 - [CodeComplete] Fix ASTUnit cached completion of macros from preamble, broken in r342528

Author: sammccall Date: Thu Jul 18 00:17:49 2019 New Revision: 366409 URL: http://llvm.org/viewvc/llvm-project?rev=366409&view=rev Log: [CodeComplete] Fix ASTUnit cached completion of macros from preamble, broken in r342528 Summary: The problem is the default LoadExternal with no completer, whic

[clang-tools-extra] r366443 - [clangd] Disable DumpRecordLayout by default per https://bugs.llvm.org/show_bug.cgi?id=42670

Author: sammccall Date: Thu Jul 18 08:00:38 2019 New Revision: 366443 URL: http://llvm.org/viewvc/llvm-project?rev=366443&view=rev Log: [clangd] Disable DumpRecordLayout by default per https://bugs.llvm.org/show_bug.cgi?id=42670 Modified: clang-tools-extra/trunk/clangd/refactor/tweaks/DumpAS

[clang-tools-extra] r366675 - [clangd] Set buffer name for main file. NFCI

Author: sammccall Date: Mon Jul 22 04:12:16 2019 New Revision: 366675 URL: http://llvm.org/viewvc/llvm-project?rev=366675&view=rev Log: [clangd] Set buffer name for main file. NFCI Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp Modified: clang-tools-extra/trunk/clangd/ClangdUnit.cpp

r366698 - [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp

Author: sammccall Date: Mon Jul 22 08:55:53 2019 New Revision: 366698 URL: http://llvm.org/viewvc/llvm-project?rev=366698&view=rev Log: [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp Summary: SelectionTree is a RecursiveASTVisitor which processes getSourceRange() f

[clang-tools-extra] r366698 - [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp

Author: sammccall Date: Mon Jul 22 08:55:53 2019 New Revision: 366698 URL: http://llvm.org/viewvc/llvm-project?rev=366698&view=rev Log: [clangd] Add dlog()s for SelectionTree, enabling -debug-only=SelectionTree.cpp Summary: SelectionTree is a RecursiveASTVisitor which processes getSourceRange() f

[clang-tools-extra] r366811 - [clangd] Log version, cwd, args, and transport on startup. NFC

Author: sammccall Date: Tue Jul 23 07:30:28 2019 New Revision: 366811 URL: http://llvm.org/viewvc/llvm-project?rev=366811&view=rev Log: [clangd] Log version, cwd, args, and transport on startup. NFC Reviewers: hokein Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commits

[clang-tools-extra] r366880 - [clangd] Reformat use of cl::opt: use unqualified name and don't bin-pack attributes. NFC

Author: sammccall Date: Wed Jul 24 02:33:27 2019 New Revision: 366880 URL: http://llvm.org/viewvc/llvm-project?rev=366880&view=rev Log: [clangd] Reformat use of cl::opt: use unqualified name and don't bin-pack attributes. NFC Reviewers: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, arp

[clang-tools-extra] r366882 - [clangd] Fix SelectionTree traversal of qualified types

Author: sammccall Date: Wed Jul 24 02:39:11 2019 New Revision: 366882 URL: http://llvm.org/viewvc/llvm-project?rev=366882&view=rev Log: [clangd] Fix SelectionTree traversal of qualified types Summary: QualifiedTypeLoc isn't treated like a regular citizen by RecursiveASTVisitor. This meant we were

[clang-tools-extra] r366893 - [clangd] SelectionTree treats TranslationUnitDecl (mostly) consistently with other containers.

Author: sammccall Date: Wed Jul 24 05:14:56 2019 New Revision: 366893 URL: http://llvm.org/viewvc/llvm-project?rev=366893&view=rev Log: [clangd] SelectionTree treats TranslationUnitDecl (mostly) consistently with other containers. Summary: Previously TranslationUnitDecl would never be selected.

[clang-tools-extra] r366900 - [clangd] Add categories to help options, and only show clangd options.

Author: sammccall Date: Wed Jul 24 05:41:52 2019 New Revision: 366900 URL: http://llvm.org/viewvc/llvm-project?rev=366900&view=rev Log: [clangd] Add categories to help options, and only show clangd options. Summary: Restricting the categories prevents extra unwanted options from creeping into hel

[clang-tools-extra] r366991 - [clangd] Also accept flags from CLANGD_FLAGS variable.

Author: sammccall Date: Thu Jul 25 00:54:48 2019 New Revision: 366991 URL: http://llvm.org/viewvc/llvm-project?rev=366991&view=rev Log: [clangd] Also accept flags from CLANGD_FLAGS variable. This simplifies various workflows, particularly in debugging/development. e.g. editors will tend to propag

[clang-tools-extra] r366992 - [clangd] Provide help text to users who run `clangd` in a terminal.

Author: sammccall Date: Thu Jul 25 01:00:54 2019 New Revision: 366992 URL: http://llvm.org/viewvc/llvm-project?rev=366992&view=rev Log: [clangd] Provide help text to users who run `clangd` in a terminal. Reviewers: hokein Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-comm

[clang-tools-extra] r367112 - [clangd] Fix background index not triggering on windows due to case mismatch.

Author: sammccall Date: Fri Jul 26 07:07:11 2019 New Revision: 367112 URL: http://llvm.org/viewvc/llvm-project?rev=367112&view=rev Log: [clangd] Fix background index not triggering on windows due to case mismatch. Summary: This isn't a general fix to all paths where we assume case-sensitivity, it

[clang-tools-extra] r367121 - [clangd] Support extraction of binary "subexpressions" like a + [[b + c]].

Author: sammccall Date: Fri Jul 26 08:29:52 2019 New Revision: 367121 URL: http://llvm.org/viewvc/llvm-project?rev=367121&view=rev Log: [clangd] Support extraction of binary "subexpressions" like a + [[b + c]]. Summary: These aren't formally subexpressions in C++, in this case + is left-associati

r367353 - Revert "[NFC][clang] Refactor getCompilationPhases()+Types.def step 3."

Author: sammccall Date: Tue Jul 30 13:38:11 2019 New Revision: 367353 URL: http://llvm.org/viewvc/llvm-project?rev=367353&view=rev Log: Revert "[NFC][clang] Refactor getCompilationPhases()+Types.def step 3." This reverts commit d2254dbf21a3243233b75294ef901086199df1b9. This (unintentionally?) cha

[clang-tools-extra] r367453 - [clangd] Ignore semicolons, whitespace, and comments in SelectionTree.

Author: sammccall Date: Wed Jul 31 10:52:40 2019 New Revision: 367453 URL: http://llvm.org/viewvc/llvm-project?rev=367453&view=rev Log: [clangd] Ignore semicolons, whitespace, and comments in SelectionTree. Summary: Whitespace and comments are a clear bugfix: selecting some comments/space near a

[clang-tools-extra] r367667 - [clangd] Add new helpers to make tweak tests scale better. Convert most tests. NFC

Author: sammccall Date: Fri Aug 2 02:12:39 2019 New Revision: 367667 URL: http://llvm.org/viewvc/llvm-project?rev=367667&view=rev Log: [clangd] Add new helpers to make tweak tests scale better. Convert most tests. NFC Summary: TweakTests.cpp has some pretty good helpers added for the first few

[clang-tools-extra] r367672 - [clangd] Remove bad assert: nothing relies on it, and the reasons it was true no longer hold.

Author: sammccall Date: Fri Aug 2 03:39:46 2019 New Revision: 367672 URL: http://llvm.org/viewvc/llvm-project?rev=367672&view=rev Log: [clangd] Remove bad assert: nothing relies on it, and the reasons it was true no longer hold. Modified: clang-tools-extra/trunk/clangd/XRefs.cpp Modified:

[clang-tools-extra] r367811 - [clangd] Fix error message with incorrect TextDocumentcontentChangeEvent.rangeLength

Author: sammccall Date: Mon Aug 5 01:14:13 2019 New Revision: 367811 URL: http://llvm.org/viewvc/llvm-project?rev=367811&view=rev Log: [clangd] Fix error message with incorrect TextDocumentcontentChangeEvent.rangeLength Modified: clang-tools-extra/trunk/clangd/DraftStore.cpp Modified: clan

[clang-tools-extra] r367812 - [clangd] Expose -offset-encoding=utf-32, which has been implemented for ages

Author: sammccall Date: Mon Aug 5 01:14:17 2019 New Revision: 367812 URL: http://llvm.org/viewvc/llvm-project?rev=367812&view=rev Log: [clangd] Expose -offset-encoding=utf-32, which has been implemented for ages Modified: clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp Modified: clang-to

[clang-tools-extra] r368083 - [clangd] Unfold SourceLocation flattening from findNameLoc in preparation for adding more overloads. NFC

Author: sammccall Date: Tue Aug 6 13:25:59 2019 New Revision: 368083 URL: http://llvm.org/viewvc/llvm-project?rev=368083&view=rev Log: [clangd] Unfold SourceLocation flattening from findNameLoc in preparation for adding more overloads. NFC Modified: clang-tools-extra/trunk/clangd/AST.cpp

[clang-tools-extra] r368186 - Code completion should not ignore default parameters in functions.

Author: sammccall Date: Wed Aug 7 09:52:21 2019 New Revision: 368186 URL: http://llvm.org/viewvc/llvm-project?rev=368186&view=rev Log: Code completion should not ignore default parameters in functions. Summary: Inorder to display the default arguments we must process the CK_Optional chunks of Co

r368455 - Rename PCH/leakfiles test so it runs on bots.

Author: sammccall Date: Fri Aug 9 10:13:56 2019 New Revision: 368455 URL: http://llvm.org/viewvc/llvm-project?rev=368455&view=rev Log: Rename PCH/leakfiles test so it runs on bots. Added: cfe/trunk/test/PCH/leakfiles.test Removed: cfe/trunk/test/PCH/leakfiles Removed: cfe/trunk/test/PCH

[clang-tools-extra] r368482 - [clangd] Give absolute path to clang-tidy and include-fixer. HintPath should always be absolute, some URI schemes care.

Author: sammccall Date: Fri Aug 9 13:45:24 2019 New Revision: 368482 URL: http://llvm.org/viewvc/llvm-project?rev=368482&view=rev Log: [clangd] Give absolute path to clang-tidy and include-fixer. HintPath should always be absolute, some URI schemes care. Modified: clang-tools-extra/trunk/cl

[clang-tools-extra] r368498 - clangd: use -j for background index pool

Author: sammccall Date: Fri Aug 9 16:03:32 2019 New Revision: 368498 URL: http://llvm.org/viewvc/llvm-project?rev=368498&view=rev Log: clangd: use -j for background index pool Summary: clangd supports a -j option to limit the amount of threads to use for parsing TUs. However, when using -backgro

[clang-tools-extra] r368500 - [clangd] Disallow extraction of expression-statements.

Author: sammccall Date: Fri Aug 9 16:40:54 2019 New Revision: 368500 URL: http://llvm.org/viewvc/llvm-project?rev=368500&view=rev Log: [clangd] Disallow extraction of expression-statements. Summary: I split out the "extract parent instead of this" logic from the "this isn't worth extracting" log

[clang-tools-extra] r368590 - [clangd] Refactor computation of extracted expr in ExtractVariable tweak. NFC

Author: sammccall Date: Mon Aug 12 10:05:35 2019 New Revision: 368590 URL: http://llvm.org/viewvc/llvm-project?rev=368590&view=rev Log: [clangd] Refactor computation of extracted expr in ExtractVariable tweak. NFC Summary: This takes this logic out of the Tweak class, and simplifies the signature

[clang-tools-extra] r364180 - [clangd] Improve SelectionTree string representation

Author: sammccall Date: Mon Jun 24 06:01:28 2019 New Revision: 364180 URL: http://llvm.org/viewvc/llvm-project?rev=364180&view=rev Log: [clangd] Improve SelectionTree string representation Modified: clang-tools-extra/trunk/clangd/Selection.cpp Modified: clang-tools-extra/trunk/clangd/Selecti

[clang-tools-extra] r364284 - [clangd] Fix NestedNameSpecifierLoc in SelectionTree

Author: sammccall Date: Tue Jun 25 02:36:09 2019 New Revision: 364284 URL: http://llvm.org/viewvc/llvm-project?rev=364284&view=rev Log: [clangd] Fix NestedNameSpecifierLoc in SelectionTree Reviewers: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, cfe-commits Tags: #clang Diff

[clang-tools-extra] r364519 - [clangd] Address limitations in SelectionTree:

Author: sammccall Date: Thu Jun 27 04:17:13 2019 New Revision: 364519 URL: http://llvm.org/viewvc/llvm-project?rev=364519&view=rev Log: [clangd] Address limitations in SelectionTree: Summary: - nodes can have special-cased hit ranges including "holes" (FunctionTypeLoc in void foo()) - token co

[clang-tools-extra] r364740 - [clangd] Make PreambleStatusCache handle filenames more carefully

Author: sammccall Date: Mon Jul 1 03:11:18 2019 New Revision: 364740 URL: http://llvm.org/viewvc/llvm-project?rev=364740&view=rev Log: [clangd] Make PreambleStatusCache handle filenames more carefully Summary: - when we hit the cache, the reported filename should be that of the cache query,

[clang-tools-extra] r364741 - [clangd] Fix unused var from r364735

Author: sammccall Date: Mon Jul 1 03:13:03 2019 New Revision: 364741 URL: http://llvm.org/viewvc/llvm-project?rev=364741&view=rev Log: [clangd] Fix unused var from r364735 Modified: clang-tools-extra/trunk/clangd/XRefs.cpp Modified: clang-tools-extra/trunk/clangd/XRefs.cpp URL: http://llvm

r364938 - clang-format: Add new style option AlignConsecutiveMacros

Author: sammccall Date: Tue Jul 2 08:53:14 2019 New Revision: 364938 URL: http://llvm.org/viewvc/llvm-project?rev=364938&view=rev Log: clang-format: Add new style option AlignConsecutiveMacros This option behaves similarly to AlignConsecutiveDeclarations and AlignConsecutiveAssignments, aligning

[clang-tools-extra] r365151 - [clangd] Mark a couple of unimportant flags as hidden. NFC

Author: sammccall Date: Thu Jul 4 11:49:08 2019 New Revision: 365151 URL: http://llvm.org/viewvc/llvm-project?rev=365151&view=rev Log: [clangd] Mark a couple of unimportant flags as hidden. NFC Modified: clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp Modified: clang-tools-extra/trunk/cl

[clang-tools-extra] r365288 - [clangd] Encapsulate fields in dex token. NFC

Author: sammccall Date: Sun Jul 7 19:37:06 2019 New Revision: 365288 URL: http://llvm.org/viewvc/llvm-project?rev=365288&view=rev Log: [clangd] Encapsulate fields in dex token. NFC Modified: clang-tools-extra/trunk/clangd/index/dex/PostingList.h clang-tools-extra/trunk/clangd/index/dex/T

[clang-tools-extra] r365289 - [clangd] Avoid slow ostreams in URI conversion.

Author: sammccall Date: Sun Jul 7 19:46:21 2019 New Revision: 365289 URL: http://llvm.org/viewvc/llvm-project?rev=365289&view=rev Log: [clangd] Avoid slow ostreams in URI conversion. This speeds up some hot paths significantly (e.g. dex::generateProximityURIs by a third or so) Modified: cl

[clang-tools-extra] r365311 - [clangd] Use xxhash instead of SHA1 for background index file digests.

Author: sammccall Date: Mon Jul 8 04:33:17 2019 New Revision: 365311 URL: http://llvm.org/viewvc/llvm-project?rev=365311&view=rev Log: [clangd] Use xxhash instead of SHA1 for background index file digests. Summary: Currently SHA1 is about 10% of our CPU, this patch reduces it to ~1%. xxhash is

[clang-tools-extra] r365356 - [clangd] Use -completion-style=bundled by default if signature help is available

Author: sammccall Date: Mon Jul 8 10:27:15 2019 New Revision: 365356 URL: http://llvm.org/viewvc/llvm-project?rev=365356&view=rev Log: [clangd] Use -completion-style=bundled by default if signature help is available Summary: I didn't manage to find something nicer than optional, but at least I f

[clang-tools-extra] r365364 - [clangd] Don't insert absolute paths, give up instead.

Author: sammccall Date: Mon Jul 8 11:07:46 2019 New Revision: 365364 URL: http://llvm.org/viewvc/llvm-project?rev=365364&view=rev Log: [clangd] Don't insert absolute paths, give up instead. Summary: Also implement resolution of paths relative to mainfile without HeaderSearchInfo. Reviewers: ka

[clang-tools-extra] r365522 - [clangd] Show documentation in hover, and fetch docs from index if needed.

Author: sammccall Date: Tue Jul 9 10:59:50 2019 New Revision: 365522 URL: http://llvm.org/viewvc/llvm-project?rev=365522&view=rev Log: [clangd] Show documentation in hover, and fetch docs from index if needed. Summary: I assume showing docs is going to be part of structured hover rendering, but

[clang-tools-extra] r365531 - [clangd] Rewrite of logic to rebuild the background index serving structures.

Author: sammccall Date: Tue Jul 9 11:30:49 2019 New Revision: 365531 URL: http://llvm.org/viewvc/llvm-project?rev=365531&view=rev Log: [clangd] Rewrite of logic to rebuild the background index serving structures. Summary: Previously it was rebuilding every 5s by default, which was much too frequ

[clang-tools-extra] r365576 - [clangd] fix assert in test after r365531.

Author: sammccall Date: Tue Jul 9 16:05:20 2019 New Revision: 365576 URL: http://llvm.org/viewvc/llvm-project?rev=365576&view=rev Log: [clangd] fix assert in test after r365531. Unverified because CMake/ninja seems to be broken... Modified: clang-tools-extra/trunk/clangd/unittests/Backgroun

[clang-tools-extra] r365773 - [clangd] Add priorities to background index queue, extract to separate class

Author: sammccall Date: Thu Jul 11 06:34:38 2019 New Revision: 365773 URL: http://llvm.org/viewvc/llvm-project?rev=365773&view=rev Log: [clangd] Add priorities to background index queue, extract to separate class Reviewers: kadircet Subscribers: mgorny, ilya-biryukov, MaskRay, jkorous, arphaman,

[clang-tools-extra] r365792 - [clangd] Implementation of auto type expansion.

Author: sammccall Date: Thu Jul 11 09:04:18 2019 New Revision: 365792 URL: http://llvm.org/viewvc/llvm-project?rev=365792&view=rev Log: [clangd] Implementation of auto type expansion. Add a tweak for clangd to replace an auto keyword to the deduced type. This way a user can declare something wit

[clang-tools-extra] r365793 - [clangd] Consume llvm::Error in test after r365792

Author: sammccall Date: Thu Jul 11 09:22:50 2019 New Revision: 365793 URL: http://llvm.org/viewvc/llvm-project?rev=365793&view=rev Log: [clangd] Consume llvm::Error in test after r365792 Modified: clang-tools-extra/trunk/clangd/unittests/XRefsTests.cpp Modified: clang-tools-extra/trunk/clang

[clang-tools-extra] r365794 - [clangd] Avoid template in Task constructor, hopefully fix MSVC build

Author: sammccall Date: Thu Jul 11 09:26:53 2019 New Revision: 365794 URL: http://llvm.org/viewvc/llvm-project?rev=365794&view=rev Log: [clangd] Avoid template in Task constructor, hopefully fix MSVC build Modified: clang-tools-extra/trunk/clangd/index/Background.h Modified: clang-tools-extr

r360996 - [ClangFormat] Editor integrations inherit default style from clang-format binary

Author: sammccall Date: Fri May 17 00:22:55 2019 New Revision: 360996 URL: http://llvm.org/viewvc/llvm-project?rev=360996&view=rev Log: [ClangFormat] Editor integrations inherit default style from clang-format binary Summary: This allows downstream customizations to the default style to work with

[clang-tools-extra] r361252 - [clangd] Add tweak to convert normal to raw string literal, when it contains escapes.

Author: sammccall Date: Tue May 21 06:04:24 2019 New Revision: 361252 URL: http://llvm.org/viewvc/llvm-project?rev=361252&view=rev Log: [clangd] Add tweak to convert normal to raw string literal, when it contains escapes. Reviewers: ilya-biryukov Subscribers: mgorny, MaskRay, jkorous, arphaman,

[clang-tools-extra] r361258 - [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to force it.

Author: sammccall Date: Tue May 21 06:40:31 2019 New Revision: 361258 URL: http://llvm.org/viewvc/llvm-project?rev=361258&view=rev Log: [clangd] Turn no-parse-completion on by when preamble isn't ready. Add flag to force it. Reviewers: kadircet Subscribers: ilya-biryukov, MaskRay, jkorous, arph

[clang-tools-extra] r361883 - [clangd] Add SourceManager accessor to ParsedAST. NFC

Author: sammccall Date: Tue May 28 14:52:34 2019 New Revision: 361883 URL: http://llvm.org/viewvc/llvm-project?rev=361883&view=rev Log: [clangd] Add SourceManager accessor to ParsedAST. NFC Modified: clang-tools-extra/trunk/clangd/ClangdUnit.h clang-tools-extra/trunk/clangd/XRefs.cpp

r350612 - [ASTMatchers] Improve assert message for broken parent map.

Author: sammccall Date: Mon Jan 7 23:29:46 2019 New Revision: 350612 URL: http://llvm.org/viewvc/llvm-project?rev=350612&view=rev Log: [ASTMatchers] Improve assert message for broken parent map. Summary: This assert catches places where the AST (as seen by RecursiveASTVisitor) becomes disconnect

Re: [PATCH] D56444: [AST] RecursiveASTVisitor visits lambda classes when implicit visitation is on.

I'll take a look at the regression, thanks. As noted in the other review thread, the new unit test you linked is broken: the code snippet doesn't compile (a&&), which seems to be the cause of the crash, or at least masks it. On Tue, Jan 8, 2019, 23:20 Jonas Toth via Phabricator < revi...@reviews.l

[clang-tools-extra] r373436 - [clang-tidy] Fix typo in r373428

Author: sammccall Date: Wed Oct 2 02:16:48 2019 New Revision: 373436 URL: http://llvm.org/viewvc/llvm-project?rev=373436&view=rev Log: [clang-tidy] Fix typo in r373428 Modified: clang-tools-extra/trunk/test/clang-tidy/bugprone-infinite-loop.cpp Modified: clang-tools-extra/trunk/test/clang-t

r373439 - [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version

Author: sammccall Date: Wed Oct 2 02:50:40 2019 New Revision: 373439 URL: http://llvm.org/viewvc/llvm-project?rev=373439&view=rev Log: [ClangFormat] Future-proof Standard option, allow floating or pinning to arbitrary lang version Summary: The historical context: - clang-format was written when

r373441 - [ClangFormat] relnotes for r373439

Author: sammccall Date: Wed Oct 2 02:52:52 2019 New Revision: 373441 URL: http://llvm.org/viewvc/llvm-project?rev=373441&view=rev Log: [ClangFormat] relnotes for r373439 Modified: cfe/trunk/docs/ReleaseNotes.rst Modified: cfe/trunk/docs/ReleaseNotes.rst URL: http://llvm.org/viewvc/llvm-pro

[clang-tools-extra] r373442 - [clangd] SelectionTree should mark a node as fully-selected if the only claimed tokens were early-claimed.

Author: sammccall Date: Wed Oct 2 03:01:53 2019 New Revision: 373442 URL: http://llvm.org/viewvc/llvm-project?rev=373442&view=rev Log: [clangd] SelectionTree should mark a node as fully-selected if the only claimed tokens were early-claimed. Summary: Previously they would be marked as partially

[clang-tools-extra] r330418 - Parse .h files as objective-c++ if we don't have a compile command.

Author: sammccall Date: Fri Apr 20 04:35:17 2018 New Revision: 330418 URL: http://llvm.org/viewvc/llvm-project?rev=330418&view=rev Log: Parse .h files as objective-c++ if we don't have a compile command. Summary: This makes C++/objC not totally broken, without hurting C files too much. Reviewer

[clang-tools-extra] r331029 - [clangd] Fix unicode handling, using UTF-16 where LSP requires it.

Author: sammccall Date: Fri Apr 27 04:59:28 2018 New Revision: 331029 URL: http://llvm.org/viewvc/llvm-project?rev=331029&view=rev Log: [clangd] Fix unicode handling, using UTF-16 where LSP requires it. Summary: The Language Server Protocol unfortunately mandates that locations in files be repres

<    1   2   3   4   5   6   7   8   9   10   >