Couple of thoughts. (Technically I'm out on leave so will let Jan/Ilya
review implementation and happy with whatever you decide)
Enabling
- negotiating LSP extensions is probably better done in the "capabilities"
message exchange than as a command-line flag. Generally, we want this
extension on if
Author: sammccall
Date: Tue May 15 10:43:27 2018
New Revision: 332378
URL: http://llvm.org/viewvc/llvm-project?rev=332378&view=rev
Log:
[clangd] Extract scoring/ranking logic, and shave yaks.
Summary:
Code completion scoring was embedded in CodeComplete.cpp, which is bad:
- awkward to test. The
Author: sammccall
Date: Wed May 30 01:03:43 2018
New Revision: 333514
URL: http://llvm.org/viewvc/llvm-project?rev=333514&view=rev
Log:
Fix -Wunused in NDEBUG introduced by HIP r333484
Modified:
cfe/trunk/lib/Driver/ToolChains/HIP.cpp
Modified: cfe/trunk/lib/Driver/ToolChains/HIP.cpp
URL:
h
Author: sammccall
Date: Fri Sep 29 09:41:23 2017
New Revision: 314532
URL: http://llvm.org/viewvc/llvm-project?rev=314532&view=rev
Log:
Small clangd cleanups, NFC
- remove old ASTUnit includes
- fix typo (regiterCallbackHandlers)
Modified:
clang-tools-extra/trunk/clangd/ClangdLSPServer.cpp
Author: sammccall
Date: Sat Sep 30 03:08:52 2017
New Revision: 314587
URL: http://llvm.org/viewvc/llvm-project?rev=314587&view=rev
Log:
[clangd] simplify ClangdLSPServer by private-inheriting callback interfaces. NFC
Summary:
There doesn't seem to be any real separation between the current three
Interesting - this is pretty primitive, and still fairly tightly coupled to
JSON-RPC.
I can't easily tell from the code how the ORC RPC functionality - would it
be easy to use with JSON-RPC, does it make sense to use serialization only,
does it have opinions about threading models? And really, what
Author: sammccall
Date: Thu Oct 12 06:29:58 2017
New Revision: 315577
URL: http://llvm.org/viewvc/llvm-project?rev=315577&view=rev
Log:
[clangd] less boilerplate in RPC dispatch
Summary:
Make the ProtocolHandlers glue between JSONRPCDispatcher and
ClangdLSPServer generic.
Eliminate small differen
Author: sammccall
Date: Thu Aug 30 08:07:34 2018
New Revision: 341076
URL: http://llvm.org/viewvc/llvm-project?rev=341076&view=rev
Log:
[clangd] Run SignatureHelp using an up-to-date preamble, waiting if needed.
Summary:
After code completion inserts a header, running signature help using the old
Author: sammccall
Date: Fri Aug 31 06:55:01 2018
New Revision: 341211
URL: http://llvm.org/viewvc/llvm-project?rev=341211&view=rev
Log:
[clangd] Flatten out Symbol::Details. It was ill-conceived, sorry.
Reviewers: ioeric
Subscribers: ilya-biryukov, MaskRay, jkorous, arphaman, kadircet, cfe-commi
Author: sammccall
Date: Mon Sep 3 07:37:43 2018
New Revision: 341318
URL: http://llvm.org/viewvc/llvm-project?rev=341318&view=rev
Log:
[clangd] Factor out the data-swapping functionality from MemIndex/DexIndex.
Summary:
This is now handled by a wrapper class SwapIndex, so MemIndex/DexIndex can b
Author: sammccall
Date: Mon Sep 3 08:23:01 2018
New Revision: 341321
URL: http://llvm.org/viewvc/llvm-project?rev=341321&view=rev
Log:
[clangd] Fix ambiguous make_unique with c++17. NFC
Modified:
clang-tools-extra/trunk/unittests/clangd/IndexTests.cpp
Modified: clang-tools-extra/trunk/unitt
Author: sammccall
Date: Mon Sep 3 09:37:59 2018
New Revision: 341325
URL: http://llvm.org/viewvc/llvm-project?rev=341325&view=rev
Log:
[clangd] Some nitpicking around the new split (preamble/main) dynamic index
Summary:
- DynamicIndex doesn't implement ParsingCallbacks, to make its role clearer.
Author: sammccall
Date: Mon Sep 3 13:26:26 2018
New Revision: 341337
URL: http://llvm.org/viewvc/llvm-project?rev=341337&view=rev
Log:
[clangd] Fix index-twice regression from r341242
Modified:
clang-tools-extra/trunk/clangd/index/FileIndex.cpp
Modified: clang-tools-extra/trunk/clangd/index
Author: sammccall
Date: Tue Sep 4 07:39:56 2018
New Revision: 341368
URL: http://llvm.org/viewvc/llvm-project?rev=341368&view=rev
Log:
[clangd] SymbolOccurrences -> Refs and cleanup
Summary:
A few things that I noticed while merging the SwapIndex patch:
- SymbolOccurrences and particularly Symb
Author: sammccall
Date: Tue Sep 4 09:16:50 2018
New Revision: 341375
URL: http://llvm.org/viewvc/llvm-project?rev=341375&view=rev
Log:
[clangd] Define a compact binary serialization fomat for symbol slab/index.
Summary:
This is intended to replace the current YAML format for general use.
It's ~1
Author: sammccall
Date: Tue Sep 4 09:19:40 2018
New Revision: 341376
URL: http://llvm.org/viewvc/llvm-project?rev=341376&view=rev
Log:
[clangd] Load static index asynchronously, add tracing.
Summary:
Like D51475 but simplified based on recent patches.
While here, clarify that loadIndex() takes a
Author: sammccall
Date: Wed Sep 5 00:44:02 2018
New Revision: 341450
URL: http://llvm.org/viewvc/llvm-project?rev=341450&view=rev
Log:
clang-format: Fix formatting C++ namespaces with preceding 'inline' or 'export'
specifier
This fixes formatting namespaces with preceding 'inline' and 'export'
Author: sammccall
Date: Wed Sep 5 00:52:49 2018
New Revision: 341451
URL: http://llvm.org/viewvc/llvm-project?rev=341451&view=rev
Log:
[clangd] Fix buildbot failures on older compilers from r341375
Modified:
clang-tools-extra/trunk/clangd/RIFF.cpp
clang-tools-extra/trunk/clangd/index/Ser
tantiation of function template specialization
> 'llvm::Expected::Expected
> &>' requested here
>return Result;
> ^
> ../tools/clang/tools/extra/clangd/index/Index.h:324:26: note: copy
> constructor of 'SymbolSlab' is implicitly deleted becau
Author: sammccall
Date: Wed Sep 5 03:33:36 2018
New Revision: 341458
URL: http://llvm.org/viewvc/llvm-project?rev=341458&view=rev
Log:
[clangd] Implement findReferences function
clangd will use findReferences to provide LSP's reference feature.
Modified:
clang-tools-extra/trunk/clangd/XRefs
Author: sammccall
Date: Wed Sep 5 03:39:58 2018
New Revision: 341459
URL: http://llvm.org/viewvc/llvm-project?rev=341459&view=rev
Log:
[clangd] Avoid enum class+enumValN to avoid GCC bug(?), and use consistent
style.
Modified:
clang-tools-extra/trunk/clangd/global-symbol-builder/GlobalSymb
Author: sammccall
Date: Wed Sep 5 04:53:07 2018
New Revision: 341462
URL: http://llvm.org/viewvc/llvm-project?rev=341462&view=rev
Log:
[clangd] Add xrefs LSP boilerplate implementation.
Reviewers: ilya-biryukov, ioeric
Subscribers: MaskRay, jkorous, arphaman, cfe-commits
Differential Revision:
Author: sammccall
Date: Wed Sep 5 06:17:51 2018
New Revision: 341466
URL: http://llvm.org/viewvc/llvm-project?rev=341466&view=rev
Log:
[clangd] Fix references.test assertions
Modified:
clang-tools-extra/trunk/test/clangd/references.test
Modified: clang-tools-extra/trunk/test/clangd/referenc
Author: sammccall
Date: Wed Sep 5 06:17:47 2018
New Revision: 341465
URL: http://llvm.org/viewvc/llvm-project?rev=341465&view=rev
Log:
[clangd] make zlib compression optional for binary format
Modified:
clang-tools-extra/trunk/clangd/index/Serialization.cpp
Modified: clang-tools-extra/trunk
Author: sammccall
Date: Wed Sep 5 06:22:11 2018
New Revision: 341467
URL: http://llvm.org/viewvc/llvm-project?rev=341467&view=rev
Log:
[clangd] Fix type/variable name conflict on some compilers
Modified:
clang-tools-extra/trunk/clangd/global-symbol-builder/GlobalSymbolBuilderMain.cpp
Modif
pointers to the GCC bug/breakage mentioned?
>
> On Thu, Sep 6, 2018 at 11:44 AM Ilya Biryukov
> wrote:
>
>> +1 for consistent style, but why not use enum class everywhere instead?
>>
>> On Wed, Sep 5, 2018 at 12:41 PM Sam McCall via cfe-commits <
>> cfe-commits
ov
>> wrote:
>>
>>> Any pointers to the GCC bug/breakage mentioned?
>>>
>>> On Thu, Sep 6, 2018 at 11:44 AM Ilya Biryukov
>>> wrote:
>>>
>>>> +1 for consistent style, but why not use enum class everywhere instead?
>>>
Author: sammccall
Date: Thu Sep 6 07:27:40 2018
New Revision: 341549
URL: http://llvm.org/viewvc/llvm-project?rev=341549&view=rev
Log:
Revert "[DebugInfo] Generate debug information for labels. (Fix PR37395)"
This reverts commit r341519, which generates debug info that causes
backend crashes. (w
Author: sammccall
Date: Mon Sep 10 03:00:47 2018
New Revision: 341797
URL: http://llvm.org/viewvc/llvm-project?rev=341797&view=rev
Log:
[clangd] Fix async index loading (from r341376).
Summary:
This wasn't actually async (due to std::future destructor blocking).
If it were, we would have clean sh
On Tue, Sep 11, 2018 at 3:43 PM Ilya Biryukov via Phabricator <
revi...@reviews.llvm.org> wrote:
> ilya-biryukov added a comment.
>
> In https://reviews.llvm.org/D51747#1229066, @sammccall wrote:
>
> > A few thoughts here:
> >
> > - does CDB describe user or project preferences? unclear.
>
>
> Agr
Author: sammccall
Date: Thu Sep 13 04:47:48 2018
New Revision: 342130
URL: http://llvm.org/viewvc/llvm-project?rev=342130&view=rev
Log:
[clangd] Simplify cancellation public API
Summary:
Task is no longer exposed:
- task cancellation is hidden as a std::function
- task creation returns the new
Author: sammccall
Date: Thu Sep 13 05:58:36 2018
New Revision: 342135
URL: http://llvm.org/viewvc/llvm-project?rev=342135&view=rev
Log:
[clangd] Allow all LSP methods to signal cancellation via $/cancelRequest
Summary:
The cancelable scopes are managed by JSONRPCDispatcher so that all Handlers
ru
Author: sammccall
Date: Fri Sep 14 05:24:09 2018
New Revision: 342228
URL: http://llvm.org/viewvc/llvm-project?rev=342228&view=rev
Log:
[Tooling] JSONCompilationDatabasePlugin infers compile commands for missing
files
Summary:
See the existing InterpolatingCompilationDatabase for details on how
Author: sammccall
Date: Fri Sep 14 05:32:08 2018
New Revision: 342229
URL: http://llvm.org/viewvc/llvm-project?rev=342229&view=rev
Log:
[clangd] Don't double-infer compile commands after r342228
Modified:
clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp
Modified: clang-tools-extr
Author: sammccall
Date: Fri Sep 14 05:36:06 2018
New Revision: 342230
URL: http://llvm.org/viewvc/llvm-project?rev=342230&view=rev
Log:
[clangd] Don't override the preamble while completing inside it, it doesn't
work.
Summary:
To stay fast, enable single-file-mode instead. This is fine since com
Author: sammccall
Date: Fri Sep 14 05:47:38 2018
New Revision: 342232
URL: http://llvm.org/viewvc/llvm-project?rev=342232&view=rev
Log:
[VFS] vfs::directory_iterator yields path and file type instead of full Status
Summary:
Most callers I can find are using only `getName()`. Type is used by the
r
Author: sammccall
Date: Fri Sep 14 11:49:16 2018
New Revision: 342261
URL: http://llvm.org/viewvc/llvm-project?rev=342261&view=rev
Log:
[clangd] Work around compiler macro expansion bugs(?) in completion tests
Modified:
clang-tools-extra/trunk/unittests/clangd/CodeCompleteTests.cpp
Modified:
Author: sammccall
Date: Fri Jul 20 01:01:37 2018
New Revision: 337527
URL: http://llvm.org/viewvc/llvm-project?rev=337527&view=rev
Log:
[clangd] FuzzyMatch exposes an API for its word segmentation. NFC
Summary: This is intended to be used for indexing, e.g. in D49417
Reviewers: ioeric, omtcyfz
Author: sammccall
Date: Mon Jul 23 04:25:25 2018
New Revision: 337682
URL: http://llvm.org/viewvc/llvm-project?rev=337682&view=rev
Log:
[Tooling] Use UniqueStringSaver. NFC
Modified:
cfe/trunk/include/clang/Tooling/Execution.h
cfe/trunk/lib/Tooling/Execution.cpp
Modified: cfe/trunk/inclu
Or make operator bool explicit
On Mon, Jul 23, 2018, 13:55 Ilya Biryukov via Phabricator <
revi...@reviews.llvm.org> wrote:
> ilya-biryukov accepted this revision.
> ilya-biryukov added a comment.
> This revision is now accepted and ready to land.
>
> Scary
> Definitely LGTM!
>
>
>
>
Author: sammccall
Date: Tue Jul 24 09:00:55 2018
New Revision: 337834
URL: http://llvm.org/viewvc/llvm-project?rev=337834&view=rev
Log:
[VFS] Cleanups to VFS interfaces.
Summary:
- add comments clarifying semantics
- Status::copyWithNewName(Status, Name) --> instance method
- Status::copyWithNewN
Author: sammccall
Date: Tue Feb 6 02:51:22 2018
New Revision: 324334
URL: http://llvm.org/viewvc/llvm-project?rev=324334&view=rev
Log:
[clangd] Cut input-mirror.test down to size. NFC
Modified:
clang-tools-extra/trunk/test/clangd/input-mirror.test
Modified: clang-tools-extra/trunk/test/clan
Author: sammccall
Date: Tue Feb 6 06:25:02 2018
New Revision: 324351
URL: http://llvm.org/viewvc/llvm-project?rev=324351&view=rev
Log:
[clangd] Don't try pthread, just use thread_local. Reverts r323949.
The pthread solution here breaks standalone builds, which don't have the
relevant cmake magic
Author: sammccall
Date: Fri Feb 9 06:42:01 2018
New Revision: 324735
URL: http://llvm.org/viewvc/llvm-project?rev=324735&view=rev
Log:
[clangd] Collect definitions when indexing.
Within a TU:
- as now, collect a declaration from the first occurrence of a symbol
(taking clang's canonical decl
Author: sammccall
Date: Tue Feb 13 00:59:23 2018
New Revision: 324990
URL: http://llvm.org/viewvc/llvm-project?rev=324990&view=rev
Log:
[clangd] Stop exposing Futures from ClangdServer operations.
Summary:
LSP has asynchronous semantics, being able to block on an async operation
completing is unn
Author: sammccall
Date: Tue Feb 13 19:20:07 2018
New Revision: 325097
URL: http://llvm.org/viewvc/llvm-project?rev=325097&view=rev
Log:
[clangd] Configure clangd tracing with CLANGD_TRACE env instead of -trace flag
Modified:
clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp
clang-tools-e
eb 14, 2018 at 4:22 AM Sam McCall via cfe-commits <
> cfe-commits@lists.llvm.org> wrote:
>
>> Author: sammccall
>> Date: Tue Feb 13 19:20:07 2018
>> New Revision: 325097
>>
>> URL: http://llvm.org/viewvc/llvm-project?rev=325097&view=rev
>> Log:
>&g
Author: sammccall
Date: Thu Feb 15 00:40:54 2018
New Revision: 325220
URL: http://llvm.org/viewvc/llvm-project?rev=325220&view=rev
Log:
[clangd] Fix tracing now that spans lifetimes can overlap on a thread.
Summary:
The chrome trace viewer requires events within a thread to strictly nest.
So we n
Author: sammccall
Date: Thu Feb 15 06:16:17 2018
New Revision: 325239
URL: http://llvm.org/viewvc/llvm-project?rev=325239&view=rev
Log:
[clangd] Fix make_unique ambiguity, NFC
Modified:
clang-tools-extra/trunk/clangd/Trace.cpp
Modified: clang-tools-extra/trunk/clangd/Trace.cpp
URL:
http://l
Author: sammccall
Date: Thu Feb 15 08:20:33 2018
New Revision: 325257
URL: http://llvm.org/viewvc/llvm-project?rev=325257&view=rev
Log:
[clangd] Use explicit env in test to make lit+windows happy. NFC
Modified:
clang-tools-extra/trunk/test/clangd/trace.test
Modified: clang-tools-extra/trunk/
Author: sammccall
Date: Fri Feb 16 01:41:43 2018
New Revision: 325326
URL: http://llvm.org/viewvc/llvm-project?rev=325326&view=rev
Log:
[clangd] TestFS cleanup: getVirtualBlahBlah -> testPath/testRoot. Remove
SmallString micro-opt for more ergonomic tests. NFC
Modified:
clang-tools-extra/tru
Author: sammccall
Date: Fri Feb 16 08:41:42 2018
New Revision: 325357
URL: http://llvm.org/viewvc/llvm-project?rev=325357&view=rev
Log:
[clangd] Include timestamps in log messages.
Modified:
clang-tools-extra/trunk/clangd/JSONRPCDispatcher.cpp
Modified: clang-tools-extra/trunk/clangd/JSONRPC
Author: sammccall
Date: Mon Feb 19 01:31:26 2018
New Revision: 325476
URL: http://llvm.org/viewvc/llvm-project?rev=325476&view=rev
Log:
[clangd] Fix use-after-free in SymbolYAML: strings are owned by yaml::Input!
Summary:
There are a few implementation options here - alternatives are either both
Author: sammccall
Date: Mon Feb 19 01:43:46 2018
New Revision: 325477
URL: http://llvm.org/viewvc/llvm-project?rev=325477&view=rev
Log:
[clangd] Add "clangd.trace" VSCode setting to enable tracing.
Summary:
Setting the CLANGD_TRACE environment variable directly is awkward with VSCode's
"reload fr
Author: sammccall
Date: Mon Feb 19 01:56:28 2018
New Revision: 325480
URL: http://llvm.org/viewvc/llvm-project?rev=325480&view=rev
Log:
[clangd] Tracing: name worker threads, and enforce naming scheduled async tasks
Summary:
This has a bit of a blast radius, but I think there's enough value in "f
Author: sammccall
Date: Mon Feb 19 05:04:41 2018
New Revision: 325493
URL: http://llvm.org/viewvc/llvm-project?rev=325493&view=rev
Log:
[clangd] Invert return value of fuzzyFind() (fix MemIndex's return value)
Have had way too many bugs by converting between "isComplete" and
"isIncomplete". LSP i
Author: sammccall
Date: Mon Feb 19 23:21:56 2018
New Revision: 325553
URL: http://llvm.org/viewvc/llvm-project?rev=325553&view=rev
Log:
[Sema] Fix -Wunused-variable
Modified:
cfe/trunk/lib/Sema/AnalysisBasedWarnings.cpp
Modified: cfe/trunk/lib/Sema/AnalysisBasedWarnings.cpp
URL:
http://llvm
Author: sammccall
Date: Tue Feb 20 03:46:39 2018
New Revision: 325574
URL: http://llvm.org/viewvc/llvm-project?rev=325574&view=rev
Log:
[clangd] Dump stack on crash
Modified:
clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp
Modified: clang-tools-extra/trunk/clangd/tool/ClangdMain.cpp
URL:
Author: sammccall
Date: Thu Feb 22 05:11:12 2018
New Revision: 325774
URL: http://llvm.org/viewvc/llvm-project?rev=325774&view=rev
Log:
[clangd] Allow embedders some control over when diagnostics are generated.
Summary:
Through the C++ API, we support for a given snapshot version:
- Yes: make su
Author: sammccall
Date: Thu Feb 22 07:33:33 2018
New Revision: 325801
URL: http://llvm.org/viewvc/llvm-project?rev=325801&view=rev
Log:
[clangd] fix test use-after-free from r325774
Modified:
clang-tools-extra/trunk/unittests/clangd/TUSchedulerTests.cpp
Modified: clang-tools-extra/trunk/unit
Author: sammccall
Date: Thu Feb 22 23:54:17 2018
New Revision: 325868
URL: http://llvm.org/viewvc/llvm-project?rev=325868&view=rev
Log:
[clangd] BindWithForward -> Bind. NFC
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
clang-tools-extra/trunk/clangd/Function.h
clang-tools
Author: sammccall
Date: Mon Dec 18 03:29:45 2017
New Revision: 320972
URL: http://llvm.org/viewvc/llvm-project?rev=320972&view=rev
Log:
[clangd] in VSCode client, filter extensions properly and only accept file: URIs
Summary:
The filtering wasn't previously working as intended - the string list i
Author: sammccall
Date: Tue Dec 19 02:29:27 2017
New Revision: 321065
URL: http://llvm.org/viewvc/llvm-project?rev=321065&view=rev
Log:
[clangd] Add unit tests for signature help. SigHelp/CodeComplete lit tests are
smoke only.
Modified:
clang-tools-extra/trunk/test/clangd/completion.test
Author: sammccall
Date: Tue Dec 19 04:23:48 2017
New Revision: 321073
URL: http://llvm.org/viewvc/llvm-project?rev=321073&view=rev
Log:
[clangd] Expose offset <-> LSP position functions, and fix bugs
Summary:
- Moved these functions to SourceCode.h
- added unit tests
- fix off by one in positionT
Author: sammccall
Date: Tue Dec 19 09:05:00 2017
New Revision: 321086
URL: http://llvm.org/viewvc/llvm-project?rev=321086&view=rev
Log:
[clangd] Fix warnings/compiler pickiness after r321083
Modified:
clang-tools-extra/trunk/clangd/CodeComplete.cpp
clang-tools-extra/trunk/unittests/clangd
Author: sammccall
Date: Tue Dec 19 09:06:07 2017
New Revision: 321087
URL: http://llvm.org/viewvc/llvm-project?rev=321087&view=rev
Log:
[clangd] Split findDefs/highlights into XRefs, from ClangdUnit. NFC
Going to add unit tests in the next patch. (Haha!) But seriously there's
some work to do firs
Author: sammccall
Date: Wed Dec 20 02:26:53 2017
New Revision: 321161
URL: http://llvm.org/viewvc/llvm-project?rev=321161&view=rev
Log:
[clangd] Add debug printers for basic protocol types. NFC
Modified:
clang-tools-extra/trunk/clangd/Protocol.cpp
clang-tools-extra/trunk/clangd/Protocol.h
Author: sammccall
Date: Wed Dec 20 08:06:05 2017
New Revision: 321184
URL: http://llvm.org/viewvc/llvm-project?rev=321184&view=rev
Log:
[clangd] Switch xrefs and documenthighlight to annotated-code unit tests. NFC
Summary:
The goal here is again to make it easier to read and write the tests.
I'v
Author: sammccall
Date: Thu Dec 21 06:58:44 2017
New Revision: 321272
URL: http://llvm.org/viewvc/llvm-project?rev=321272&view=rev
Log:
[clangd] Index symbols share storage within a slab.
Summary:
Symbols are not self-contained - it's only safe to hand them out if you
guarantee the lifetime of th
Author: sammccall
Date: Thu Dec 21 12:11:46 2017
New Revision: 321302
URL: http://llvm.org/viewvc/llvm-project?rev=321302&view=rev
Log:
[clangd] Don't re-hash SymbolID in maps, just use the SHA1 data
Modified:
clang-tools-extra/trunk/clangd/index/Index.cpp
clang-tools-extra/trunk/clangd/i
Author: sammccall
Date: Thu Dec 21 23:09:51 2017
New Revision: 321346
URL: http://llvm.org/viewvc/llvm-project?rev=321346&view=rev
Log:
Fix unused variable warning in SemaTemplate. NFC
Modified:
cfe/trunk/lib/Sema/SemaTemplate.cpp
Modified: cfe/trunk/lib/Sema/SemaTemplate.cpp
URL:
http://ll
Author: sammccall
Date: Fri Dec 22 00:12:39 2017
New Revision: 321348
URL: http://llvm.org/viewvc/llvm-project?rev=321348&view=rev
Log:
[clangd] Improve packing of Symbol struct. NFC
Modified:
clang-tools-extra/trunk/clangd/index/Index.h
clang-tools-extra/trunk/clangd/index/SymbolCollecto
Thanks Ben!
This was my r321272 - in hindsight I really should have run the tests with
asan for that type of change.
On Thu, Dec 21, 2017 at 6:51 PM, Benjamin Kramer via cfe-commits <
cfe-commits@lists.llvm.org> wrote:
> Author: d0k
> Date: Thu Dec 21 09:51:35 2017
> New Revision: 321286
>
> URL
Author: sammccall
Date: Fri Dec 22 01:47:34 2017
New Revision: 321350
URL: http://llvm.org/viewvc/llvm-project?rev=321350&view=rev
Log:
[clangd] Simplify GlobalCompilationDatabase, cache missing GCDs
Modified:
clang-tools-extra/trunk/clangd/GlobalCompilationDatabase.cpp
clang-tools-extra/
Author: sammccall
Date: Sat Dec 23 11:31:24 2017
New Revision: 321411
URL: http://llvm.org/viewvc/llvm-project?rev=321411&view=rev
Log:
[Index] Reduce size of SymbolInfo struct.
Summary:
This is currently 16 bytes, the patch reduces it to 4.
(Building with clang on linux x84, I guess others are s
Author: sammccall
Date: Sat Dec 23 11:38:03 2017
New Revision: 321412
URL: http://llvm.org/viewvc/llvm-project?rev=321412&view=rev
Log:
[clangd] Use Builder for symbol slabs, and use sorted-vector for storage
Summary:
This improves a few things:
- the insert -> freeze -> read sequence is now enf
Author: sammccall
Date: Tue Jan 2 01:35:10 2018
New Revision: 321639
URL: http://llvm.org/viewvc/llvm-project?rev=321639&view=rev
Log:
[Driver] Fix unused variables and test-writing-into-workdir after r321621
Modified:
cfe/trunk/lib/Driver/Driver.cpp
cfe/trunk/test/Driver/config-file.c
Author: sammccall
Date: Mon Jan 8 07:05:01 2018
New Revision: 321997
URL: http://llvm.org/viewvc/llvm-project?rev=321997&view=rev
Log:
Avoid assumption that lit tests are writable. NFC
Modified:
cfe/trunk/test/ARCMT/releases-driver.m
cfe/trunk/test/ARCMT/releases-driver.m.result
cfe/
Author: sammccall
Date: Mon Jan 8 07:49:40 2018
New Revision: 322001
URL: http://llvm.org/viewvc/llvm-project?rev=322001&view=rev
Log:
Avoid assumption that lit tests are writable. NFC
Modified:
clang-tools-extra/trunk/test/clang-apply-replacements/crlf.cpp
clang-tools-extra/trunk/test/c
wrote:
> I'm sure it's something obvious I don't understand here, but maybe someone
> else doesn't either & could benefit from it:
>
> What exactly does this change do? In what important way is "cp X Y"
> different from "cat X > Y"?
&g
Author: sammccall
Date: Tue Jan 9 01:32:53 2018
New Revision: 322065
URL: http://llvm.org/viewvc/llvm-project?rev=322065&view=rev
Log:
Avoid assumption that lit tests are writable (in a couple more places). NFC
Modified:
cfe/trunk/test/Modules/modify-module.m
cfe/trunk/test/PCH/modified-
Author: sammccall
Date: Tue Feb 27 09:15:50 2018
New Revision: 326211
URL: http://llvm.org/viewvc/llvm-project?rev=326211&view=rev
Log:
[clangd] Remove codecomplete override content API. Long live addDocument!
Modified:
clang-tools-extra/trunk/clangd/ClangdServer.cpp
clang-tools-extra/tru
Author: sammccall
Date: Fri Mar 2 00:56:37 2018
New Revision: 326546
URL: http://llvm.org/viewvc/llvm-project?rev=326546&view=rev
Log:
[clangd] Debounce streams of updates.
Summary:
Don't actually start building ASTs for new revisions until either:
- 500ms have passed since the last revision, or
Author: sammccall
Date: Mon Mar 5 09:28:54 2018
New Revision: 326719
URL: http://llvm.org/viewvc/llvm-project?rev=326719&view=rev
Log:
[clangd] Extract ClangdServer::Options struct.
Summary:
This subsumes most of the params to ClangdServer and ClangdLSPServer.
Adjacent changes:
- tests use a co
Author: sammccall
Date: Mon Mar 5 09:34:33 2018
New Revision: 326721
URL: http://llvm.org/viewvc/llvm-project?rev=326721&view=rev
Log:
[clangd] Fix unintentionally loose fuzzy matching, and the tests masking it.
Summary:
The intent was that [ar] doesn't match "FooBar"; the first character must m
Author: sammccall
Date: Tue Mar 6 06:30:07 2018
New Revision: 326798
URL: http://llvm.org/viewvc/llvm-project?rev=326798&view=rev
Log:
[clangd] Address missed comments from D44003
Modified:
clang-tools-extra/trunk/unittests/clangd/FuzzyMatchTests.cpp
Modified: clang-tools-extra/trunk/unitte
Author: sammccall
Date: Fri Mar 9 03:47:37 2018
New Revision: 327115
URL: http://llvm.org/viewvc/llvm-project?rev=327115&view=rev
Log:
[clang-tidy] fix header guard
Modified:
clang-tools-extra/trunk/clang-tidy/abseil/StringFindStartswithCheck.h
Modified: clang-tools-extra/trunk/clang-tidy/a
Author: sammccall
Date: Fri Mar 9 05:25:29 2018
New Revision: 327127
URL: http://llvm.org/viewvc/llvm-project?rev=327127&view=rev
Log:
[clangd] Don't index template specializations.
Summary:
These have different USRs than the underlying entity, but are not typically
interesting in their own righ
Author: sammccall
Date: Mon Mar 12 07:49:09 2018
New Revision: 327275
URL: http://llvm.org/viewvc/llvm-project?rev=327275&view=rev
Log:
[clangd] Collect the number of files referencing a symbol in the static index.
Summary:
This is an important ranking signal.
It's off for the dynamic index for n
Author: sammccall
Date: Mon Mar 12 16:22:35 2018
New Revision: 327344
URL: http://llvm.org/viewvc/llvm-project?rev=327344&view=rev
Log:
[clangd] Remove Tagged and some related APIs from ClangdServer.
Context can do what Tagged was intended to support (snapshot filesystems),
and less intrusively.
On Wed, Mar 14, 2018, 19:39 Simon Marchi via Phabricator <
revi...@reviews.llvm.org> wrote:
> simark added inline comments.
>
>
>
> Comment at: clangd/TUScheduler.h:69
> + /// FIXME: remove the callback from this function
> + void updateCompileCommand(PathRef File, tooling::Comp
Author: sammccall
Date: Wed May 30 07:14:58 2018
New Revision: 333547
URL: http://llvm.org/viewvc/llvm-project?rev=333547&view=rev
Log:
Revert "Update NRVO logic to support early return"
This reverts commit r333500, which causes stage2 compiler crashes.
Removed:
cfe/trunk/test/CodeGenCXX/nrv
Author: sammccall
Date: Mon Jun 4 03:37:16 2018
New Revision: 333881
URL: http://llvm.org/viewvc/llvm-project?rev=333881&view=rev
Log:
[clangd] Hover should return null when not hovering over anything.
Summary: Also made JSON serialize Optional to simplify this.
Reviewers: ioeric
Subscribers:
Author: sammccall
Date: Mon Jun 4 06:28:17 2018
New Revision: 333897
URL: http://llvm.org/viewvc/llvm-project?rev=333897&view=rev
Log:
[clangd] Fix inverted test (--gtest_filter strikes again...)
Modified:
clang-tools-extra/trunk/unittests/clangd/XRefsTests.cpp
Modified: clang-tools-extra/t
Author: sammccall
Date: Tue Jun 5 02:34:46 2018
New Revision: 333993
URL: http://llvm.org/viewvc/llvm-project?rev=333993&view=rev
Log:
[clangd] Rewrite JSON dispatcher loop using C IO (FILE*) instead of
std::istream.
Summary:
The EINTR loop around getline was added to fix an issue with mac gdb,
Author: sammccall
Date: Tue Jun 5 02:42:06 2018
New Revision: 333994
URL: http://llvm.org/viewvc/llvm-project?rev=333994&view=rev
Log:
[clang-tidy] fix broken test (no compile command) from r331763
Modified:
clang-tools-extra/trunk/test/clang-tidy/clang-tidy-enable-check-profile-one-tu.cpp
k --match-full-lines -implicit-check-not='{{warning:|error:}}'
>
> /build/clang-tools-extra/test/clang-tidy/clang-tidy-enable-check-profile-two-tu.cpp
> --
> Exit Code: 2
>
> Command Output (stderr):
> --
> FileCheck error: '-' is empty.
> FileCheck command l
gt; >>
> >> Script:
> >> --
> >> : 'RUN: at line 1'; clang-tidy -enable-check-profile
> >> -checks='-*,readability-function-size'
> >>
> >>
> /build/clang-tools-extra/test/clang-tidy/clang-tidy-e
Author: sammccall
Date: Tue Jun 5 05:22:43 2018
New Revision: 334014
URL: http://llvm.org/viewvc/llvm-project?rev=334014&view=rev
Log:
[clangd] Test tweaks (consistency, shorter, doc). NFC
Modified:
clang-tools-extra/trunk/clangd/Quality.h
clang-tools-extra/trunk/unittests/clangd/Quality
Author: sammccall
Date: Tue Jun 5 09:30:25 2018
New Revision: 334026
URL: http://llvm.org/viewvc/llvm-project?rev=334026&view=rev
Log:
[clangd] Boost code completion results that are narrowly scoped (local, members)
Summary:
This signal is considered a relevance rather than a quality signal beca
1 - 100 of 1737 matches
Mail list logo
