[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added a comment. In D137836#3959693 , @DavidSpickett wrote: > Looks like tests need updating for that new -1 return value: > https://lab.llvm.org/buildbot/#/builders/178/builds/3419 > > That bot builds with threading disabled. Thanks for letting

[PATCH] D137836: [Support] Move getHostNumPhysicalCores to Threading.h

lenary added a comment. In D137836#3959759 , @lenary wrote: > In D137836#3959693 , @DavidSpickett > wrote: > >> Looks like tests need updating for that new -1 return value: >> https://lab.llvm.org/buildbot/#/bui

[PATCH] D139086: [AArch64] Implement __arm_rsr128/__arm_wsr128

lenary created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This only contains the SelectionDAG implementation. Glob

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary updated this revision to Diff 227284. lenary added a comment. - More conservative march/mabi defaults on riscv-unknown-elf - Add clang release notes about this change to -march/-mabi Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ h

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. I have just updated D69383 . It now defaults to `rv{XLEN}imac` on ELF, rather than `rv{XLEN}gc`. This is to help this multilib issue. In the future, we want to implement MULTILIB_REUSE properly. Hopefully before Clang 10.0.0 is released.

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary updated this revision to Diff 227418. lenary added a comment. - Update tests to reflect new defaults Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ https://reviews.llvm.org/D69383 Files: clang/docs/ReleaseNotes.rst clang/lib/D

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM. Requires the changes in D69383 to land before this can. Comment at: clang/lib/Driver/ToolChains/Gnu.cpp:1544 + StringRef ABIName = t

[PATCH] D54214: [RISCV] Set triple based on -march flag

lenary added a comment. Herald added a subscriber: sameer.abuasal. I have no issue with the underlying logic here. Please rebase on top of D69383 and use `riscv::getRISCVArch(...)` defined in that patch rather than querying `Args.getLastArg(options::OPT_march_E

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

lenary added a comment. This patch is looking much better, thanks for updating it. Please may you clarify what RISC-V gcc does for `-lgcc`, `-lgcc_s`, `-lgcc_eh`? Is it different to what gcc does on other targets? Being closer to matching the linker arguments that gcc provides to ld seems like

[PATCH] D68391: [RISCV] Improve sysroot computation if no GCC install detected

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Thanks for the rebase. It looks good, let's get it committed! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68391/new/ https://reviews.llvm.org/D68391 _

[PATCH] D69590: [RISCV] Fix ILP32D lowering for double+double/double+int return types

lenary added a comment. In D69590#1728628 , @asb wrote: > Thanks James - won't this still leave problems for structs that need > flattening? The tests in clang/test/CodeGen/riscv32-ilp32d-abi.c already include lots of cases that include flattening. I

[PATCH] D54214: [RISCV] Set triple based on -march flag

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. In D54214#1737255 , @simoncook wrote: > Rebase. > > @lenary Following the discussion regarding D69383 > , I think it's

[PATCH] D68407: [WIP][RISCV] Use compiler-rt if no GCC installation detected

lenary added a comment. LGTM. I looked at what `g++` and `gcc` do (my riscv64-unknown-elf toolchain): - `gcc`: Passes `-lgcc --start-group -lc -lgloss --end-group -lgcc` to the linker - `g++`: Passes `"-lstdc++" -lm -lgcc --start-group -lc -lgloss --end-group -lgcc` to the linker This patch:

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary added a comment. I think this is just about ready to land, given our discussion on the RISC-V call on 7 November 2019. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ https://reviews.llvm.org/D69383 _

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary updated this revision to Diff 228728. lenary added a comment. - Rebase - Update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ https://reviews.llvm.org/D69383 Files: clang/docs/ReleaseNotes.rst clang/lib/Driver/ToolCh

[PATCH] D67409: [RISCV] enable LTO support, pass some options to linker.

lenary added a comment. The follow-up patch, implementing this correctly, is D70116 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67409/new/ https://reviews.llvm.org/D67409

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

lenary accepted this revision. lenary added a comment. Thanks for updating the patch. I'm happy for this patch to land, but I would like you to wait for @luismarques to approve it as well before landing it. Comment at: libunwind/src/Registers.hpp:3756 +inline double Registers

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

This revision was automatically updated to reflect the committed changes. Closed by commit rGe3d5ff5a0b10: [RISCV] Match GCC `-march`/`-mabi` driver defaults (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ https://revi

[PATCH] D69383: [RISCV] Match GCC `-march`/`-mabi` driver defaults

lenary updated this revision to Diff 229542. lenary added a comment. Rebase and update comments and release notes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69383/new/ https://reviews.llvm.org/D69383 Files: clang/docs/ReleaseNotes.rst clang

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. Do rebase this patch now that D69383 has landed, and check that it is still working correctly. If so, you can land this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ http

[PATCH] D68407: [RISCV] Use compiler-rt if no GCC installation detected

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Nice, LGTM! Thanks for fixing this in the presence of `CLANG_DEFAULT_RTLIB`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68407/new/ https://reviews.llvm.org/D68407 __

[PATCH] D70477: [Clang] Enable RISC-V support for Fuchsia

lenary added inline comments. Comment at: clang/cmake/caches/Fuchsia-stage2.cmake:130 + foreach(target x86_64;aarch64) # Set the per-target runtimes options. I don't know what's preventing you from enabling compiling the runtimes. I made a cmake config t

[PATCH] D67508: [RISCV] support mutilib in baremetal environment

lenary added a comment. Re-applied with typo fix in rGdf876a026981 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D67508/new/ https://reviews.llvm.org/D67508 _

[PATCH] D71124: [RISCV] support clang driver to select cpu

lenary added reviewers: lenary, asb. lenary added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:164 + +static constexpr llvm::StringLiteral ValidRV32CPUNames[] = {{"generic-rv32"}, +{"rocket-rv32"}}; ---

[PATCH] D71124: [RISCV] support clang driver to select cpu

lenary added inline comments. Comment at: clang/lib/Basic/Targets/RISCV.cpp:164 + +static constexpr llvm::StringLiteral ValidRV32CPUNames[] = {{"generic-rv32"}, +{"rocket-rv32"}}; khchen wrote: > lenary

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

lenary added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1525 unsigned TwoXLenInBytes = (2 * XLen) / 8; if (!IsFixed && ArgFlags.getOrigAlign() == TwoXLenInBytes && DL.getTypeAllocSize(OrigTy) == TwoXLenInBytes) { shiva02

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

lenary accepted this revision. lenary added a comment. LGTM! Thanks for correcting the preprocessor issues! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68362/new/ https://reviews.llvm.org/D68362 ___ cfe-commits mailing list cfe-commits@li

[PATCH] D71387: pass -mabi to LTO linker only in RISC-V targets, enable RISC-V LTO

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. Nice! I think this is the correct way of implementing this, and I don't think it will have any issue with other backends. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

lenary marked 3 inline comments as done. lenary added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1525 unsigned TwoXLenInBytes = (2 * XLen) / 8; if (!IsFixed && ArgFlags.getOrigAlign() == TwoXLenInBytes && DL.getTypeAllocSize(OrigTy) == T

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

lenary added a comment. Yeah, will do. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D68362/new/ https://reviews.llvm.org/D68362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[PATCH] D68362: [libunwind][RISCV] Add 64-bit RISC-V support

This revision was automatically updated to reflect the committed changes. Closed by commit rGce3d1c6d61dc: [libunwind][RISCV] Add 64-bit RISC-V support (authored by lenary). Herald added a project: libc++. Herald added a subscriber: libcxx-commits. Repository: rG LLVM Github Monorepo CHANGES S

[PATCH] D71553: [RISCV] Add Clang frontend support for Bitmanip extension

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71553/new/ https://reviews.llvm.org/D71553 __

[PATCH] D67661: [RISCV] Headers: Add Bitmanip extension Clang header files and rvintrin.h

lenary added a comment. Selfishly, I would like to see the addition of `rvintrin.h` separated from the bit-manipulation-specific headers. I'm looking at landing some additions to clang/LLVM that include builtins, and don't want to cause merge issues with this PR. I haven't yet had time to full

[PATCH] D71778: [RISCV] Add Clang Builtins for Accessing CSRs

lenary created this revision. lenary added reviewers: asb, luismarques. Herald added subscribers: llvm-commits, cfe-commits, apazos, sameer.abuasal, pzheng, s.egerton, benna, psnobl, jocewei, PkmX, rkruppe, the_o, brucehoult, MartinMosbeck, rogfer01, edward-jones, zzheng, MaskRay, jrtc27, shiva02

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

lenary added a comment. Two nits, then I'd be happy for this to land. It would be useful if @jrtc27 would also re-review, as he has blocking comments (which I believe are now addressed). Comment at: clang/docs/ClangCommandLineReference.rst:2958 + +Put global and static data s

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

lenary added a comment. In D57497#1920870 , @shiva0217 wrote: > In D57497#1920097 , @apazos wrote: > > > Thanks Shiva, I res-ynced and rebuilt the patch. It is working fine. > > > > I see there is a msmall-data-thre

[PATCH] D57497: [RISCV] Passing small data limitation value to RISCV backend

lenary accepted this revision. lenary added a comment. In D57497#1923615 , @shiva0217 wrote: > In D57497#1921497 , @lenary wrote: > > > How hard would it be to use the `-msmall-data-threshold` flag work if a > > `-

[PATCH] D73891: [RISCV] Support experimental/unratified extensions

lenary accepted this revision. lenary added a comment. I'm happy with the approach here. At some point we should put version numbers into the target features, but I think that can wait until we know how to cope with how the `G` extension expands into its other extensions (this has some open que

[PATCH] D74399: [Driver][RISCV] Add RedHat Linux RISC-V triple

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74399/new/ https://reviews.llvm.org/D74399 __

[PATCH] D74704: Support -fuse-ld=lld for riscv

lenary added a comment. I am worried about the interaction between `-fuse-ld=lld` and linker relaxation (which is not supported by LLD, as I understand it) 1. clang could ignore `-fuse-ld=lld` when linker relaxation is enabled 2. clang could ignore (disable) linker relaxation if `-fuse-ld=lld` i

[PATCH] D74704: Support -fuse-ld=lld for riscv

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. In D74704#1878944 , @jrtc27 wrote: > This isn't a new problem. The Linux and FreeBSD toolchains already support > -fuse-ld=lld properly, it's just the

[PATCH] D72755: [RISCV] Pass target-abi via module flag metadata

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM, Thank You! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D72755/new/ https://reviews.llvm.org/D72755 ___

[PATCH] D71124: [RISCV] support clang driver to select cpu

lenary added a comment. In D71124#1792216 , @khchen wrote: > The problem is how `-mcpu` interact with explicitly specified `-march` (or > target features). > > 1. in GCC, -mcpu is only used to chose the pipeline model, I think you mean "in GCC, `-mtune`

[PATCH] D145563: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK

lenary marked an inline comment as done. lenary added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64InstrInfo.td:1106 + +def : TokenAlias<"DSYNC", "dsync">; + john.brawn wrote: > It would make more sense to put this immediately after GCSB_DSYNC. Thi

[PATCH] D145563: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. lenary marked an inline comment as done. Closed by commit rGcb7fb737858c: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK (authored by lenary). Changed prior to commi

[PATCH] D146141: [ARM] Use FPUKind enum instead of unsigned

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146141/new/ https://reviews.llvm.org/D146141 __

[PATCH] D142410: [AArch64] ARMv8.5-A implies both FEAT_SB and FEAT_SSBS

lenary added a comment. @philipp.tomsich Reverse Ping. What are your plans for this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D142410/new/ https://reviews.llvm.org/D142410 ___ cfe-commits mail

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary added a comment. Updates incoming to add a specific check for netbsd and windows, which are currently excluding the affected tests anyway. Comment at: llvm/utils/lit/lit/llvm/config.py:165 +# +# This check hopefully detects both cases, and disables tests that re

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:171 +# in the tests that do the same thing. +(_, try_touch_err) = self.get_process_output(["touch", "-a", "-t", "199505050555.55", f.name]) +if try_touch_err != "": --

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary retitled this revision from "[lit] Detect Consistent File Access Times" to "[lit] Detect Inconsistent File Access Times". lenary edited the summary of this revision. lenary updated this revision to Diff 500742. Herald added a subscriber: krytarowski. Repository: rG LLVM Github Monorepo

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary marked 2 inline comments as done. lenary added a comment. Hopefully this addresses the feedback so far. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://reviews.llvm.org/D144638 _

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary added a comment. In D144638#4155217 , @michaelplatings wrote: > I see some of these tests previously had `UNSUPPORTED: system-netbsd` but not > `UNSUPPORTED: system-windows` - do you know why? I'm not entirely sure why, but I have some ideas: -

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary updated this revision to Diff 501838. lenary marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://reviews.llvm.org/D144638 Files: clang/test/Modules/prune.m lld/test/COFF/lto-cache.ll lld/t

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary added inline comments. Comment at: llvm/utils/lit/lit/llvm/config.py:190 +return False +if "1995" not in touch_res_out: +return False michaelplatings wrote: > This could end up matching the wrong part of the stri

[PATCH] D145563: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK

lenary created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This implements support for two new 2022 A-profile exten

[PATCH] D145563: [AArch64] Assembly Support for FEAT_GCS/FEAT_CHK

lenary added a comment. The CHKFEAT instruction here is not exactly as described in https://developer.arm.com/downloads/-/exploration-tools today - but the next release of that description will be updated with the new syntax. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary marked an inline comment as done. lenary added a comment. @jhenderson @int3 I think I have addressed your feedback - are you happy for me to land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://reviews.llvm.org/D1446

[PATCH] D144638: [lit] Detect Inconsistent File Access Times

lenary planned changes to this revision. lenary added a comment. To be clear: I've not yet addressed @jhenderson's comments above, yet, which may require changes to the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D144638/new/ https://revie

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary created this revision. Herald added subscribers: pmatos, asb, ormris, steven_wu, delcypher, hiraditya, sbc100, emaste. Herald added a reviewer: alexander-shaposhnikov. Herald added a reviewer: jhenderson. Herald added projects: lld-macho, All. Herald added a reviewer: lld-macho. lenary requ

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary added reviewers: simonwallis2, mgorny. lenary added a subscriber: mgorny. lenary added a comment. Adding more reviewers. @mgorny you disabled some tests on NetBSD in the past for the same reason (rG92dc7dce4a6f117a497ced1650bc48e5b658f0ea

[PATCH] D144638: [lit] Detect Consistent File Access Times

lenary added a comment. In D144638#4147133 , @jhenderson wrote: > This looks reasonable to me, with the caveat that I don't know a huge amount > about how the different OSes access time systems work. One question though: > if your antivirus was causing

[PATCH] D139086: [AArch64] Implement __arm_rsr128/__arm_wsr128

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG83b3304dd2a3: [AArch64] Implement __arm_rsr128/__arm_wsr128 (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary created this revision. Herald added subscribers: hiraditya, kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This change: - Modifies the ACLE code to allow the new

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary added a reviewer: sdesmalen. lenary added a subscriber: sdesmalen. lenary added a comment. @sdesmalen adding you as I've moved around the custom lowering of `INTRINSIC_VOID` to be its own function, and as we need to handle it for `@llvm.arm.prefetch` all the time, it's no longer condition

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary added inline comments. Comment at: llvm/test/CodeGen/AArch64/arm64-prefetch-new.ll:2 +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a < %s | FileCheck %s +; RUN: llc -mtriple=aarch64 -mattr=+v8.9a -O0 --global-isel-abort=1 < %s | FileCheck %s + tschuett wrote:

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary updated this revision to Diff 482489. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139443/new/ https://reviews.llvm.org/D139443 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/lib/Sema/SemaChecking.cpp clang/test/CodeGen/arm_acle.c clan

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

lenary added reviewers: paquette, aemerson. lenary added a comment. Adding Jessica and Amara as this affects GlobalISel for AArch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139443/new/ https://reviews.llvm.org/D139443 ___

[PATCH] D137838: [Support] Move TargetParsers to new component

lenary added a comment. The most recent update is all the fixes needed after the builds @MaskRay asked me for. I think this is ready to land on Monday? @thakis there will be GN fallout from this change. I do not intend to update GN in this patchset, but wanted to give you a heads-up. Reposito

[PATCH] D139443: [AArch64] Support SLC in ACLE prefetch intrinsics

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. lenary marked 2 inline comments as done. Closed by commit rG82b51a142804: [AArch64] Support SLC in ACLE prefetch intrinsics (authored by lenary). Repository: rG LLVM

[PATCH] D140222: [AArch64] Check 128-bit Sysreg Builtins

lenary created this revision. Herald added a subscriber: kristof.beyls. Herald added a project: All. lenary requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch contains several related changes: 1. We move to using TARGET_BUILTIN for

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary accepted this revision. lenary added a comment. LGTM. I've looked a lot closer at the tests this time around, and am happy with them, and I think the message is phrased better, and there shouldn't be warnings with `-cc1as`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/ne

[PATCH] D119720: [ARM] Pass for Cortex-A57 and Cortex-A72 Fused AES Erratum

lenary added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119720/new/ https://reviews.llvm.org/D119720 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[PATCH] D99079: [ARM][AArch64] Require appropriate features for crypto algorithms

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM. Please give the other reviewers time to chime in about this patch before merging. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99079/new/ https://reviews.llvm.org/D99079

[PATCH] D116415: [Arm] Remove duplicate CPU tests

lenary accepted this revision. lenary added a comment. There is also a duplicate line (lines 29 and 31) of `// RUN: %clang -target arm -march=armv5 -mthumb -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V5-THUMB %s` which I think can be removed when you land this. Repository: rG LLVM Github

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary added a comment. Two quick comments about when this is enabled, and then I'm happy! Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:772-774 if (KernelOrKext) Features.push_back("+strict-align"); else if (Arg *A = Args.getLastArg(options::OPT_mno_unaligned

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary accepted this revision. lenary added a comment. LGTM! Thanks for your hard work on this! I think you've addressed @pbarrio's comments on this, and I'm not sure when he's back, so wait 48h before landing this, in case there are further comments. CHANGES SINCE LAST ACTION https://review

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

lenary added inline comments. Comment at: clang/test/ClangScanDeps/modulemap-via-vfs.m:5-6 +// RUN: sed -e "s|DIR|%/t.dir|g" %t.dir/build/vfs.yaml.in > %t.dir/build/vfs.yaml +// RUN: clang-scan-deps -compilation-database %t.dir/build/compile-commands.json -j 1 -format experimen

[PATCH] D116611: [clang][scandeps] Update Module Cache Path in Test

lenary created this revision. lenary added reviewers: rsmith, Bigcheese. lenary requested review of this revision. Herald added a project: clang. This fixes the test introduced in D114206 so it no longer writes to the current working directory. Repository: r

[PATCH] D116611: [clang][scandeps] Update Module Cache Path in Test

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG015e08c6bada: [clang][scandeps] Update Module Cache Path in Test (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

lenary added a comment. @Bigcheese have you got a fix for the vfs issue with `.` and `..`? Looking closely at your comment, I'm surprised you landed this without an llvm-lit xfail for windows, given your comment above. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

lenary reopened this revision. lenary added a comment. This revision is now accepted and ready to land. Update: I'm going to revert this on main. This patch was accepted conditionally on you fixing the windows crash, which you have not done, so this was landed without being accepted. Revert is

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

lenary added a comment. In D114206#3221950 , @Bigcheese wrote: > In D114206#3221893 , @lenary wrote: > >> Update: I'm going to revert this on main. This patch was accepted >> conditionally on you fixing the windo

[PATCH] D116748: [AArch64][ARM][Clang] PerfMon Extension Added

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. I'm happy with this patch, but you could update the description to be clearer that you're adding an option to allow PMU v3.4 to be enabled/disabled separately to the architecture - not adding

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. @Bigcheese I am sorry - after a lot of further investigation, it was due to an odd interaction with some downstream changes. I will re-land your changes, with correct attribution to you. Rep

[PATCH] D114206: [Clang][ScanDeps] Use the virtual path for module maps

This revision was automatically updated to reflect the committed changes. Closed by commit rG37e6e022d21f: Re-land "[Clang][ScanDeps] Use the virtual path for module maps" (authored by Bigcheese, committed by lenary). Changed prior to commit: https://reviews.llvm.org/D114206?vs=394303&id=397972

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary added a comment. This caused some driver test failures. They have been fixed in https://reviews.llvm.org/rG11c67e5a4e99f51ec66c9781710f81955cfd5e24 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/ https://reviews.llvm.org/D116221 ___

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary added a comment. Reverted for the moment in rG3aec4b3d348d69e6c1ead7cba54677b855293983 while we fix the windows tests. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116221/new/ https://reviews.llvm.org/D11622

[PATCH] D116221: [AArch64][ARM][Clang] Unaligned Access Warning Added

lenary added a comment. This is coming together well. I think structs `U23` to `U26` in the C test are duplicates - how about surrounding them all in `#pragma pack(push, 2)` so they're different from the earlier cases? Quite a few more comments inline on the tests. Comment

[PATCH] D117271: [AArch64] clang support for Armv8.8/9.3 MOPS

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117271/new/ https://reviews.llvm.org/D117271 ___

[PATCH] D114703: [AArch64] Use Feature for A53 Erratum 835769 Fix

This revision was automatically updated to reflect the committed changes. Closed by commit rG52faad83c9f8: [AArch64] Use Feature for A53 Erratum 835769 Fix (authored by lenary). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114703/new/ https://revie

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

lenary marked an inline comment as done. lenary added a comment. In D70401#3188138 , @zixuan-wu wrote: > In D70401#3175266 , @khchen wrote: > >>> Is it (D70401 ) good enough to solve

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

lenary added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVISelLowering.cpp:1525 unsigned TwoXLenInBytes = (2 * XLen) / 8; if (!IsFixed && ArgFlags.getOrigAlign() == TwoXLenInBytes && DL.getTypeAllocSize(OrigTy) == TwoXLenInBytes) { lenary

[PATCH] D70401: [WIP][RISCV] Implement ilp32e ABI

lenary marked 3 inline comments as done. lenary added inline comments. Comment at: llvm/lib/Target/RISCV/RISCVRegisterInfo.cpp:104 + // so that we don't insert `fp` manipulation code into functions that do not + // require it. + const MachineFrameInfo &MFI = MF.getFrameInfo();

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

lenary added a comment. In D109825#3055142 , @xgupta wrote: > It misses llvm/test/CodeGen/AArch64 and llvm/test/MC/AArch64 testcases > changes, see for example https://reviews.llvm.org/D36667 (Cortex-A55 support). I'm not convinced this is required - th

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

lenary added inline comments. Comment at: clang/docs/ReleaseNotes.rst:86 +- Support has been added for the following processors (command-line identifiers in parentheses): + - Arm Cortex-A510 (cortex-a510) dmgreen wrote: > dmgreen wrote: > > Can you add an Arm

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG97809c828f8e: [AArch64]Enabling Cortex-A510 Support (authored by mubashar_, committed by lenary). Repository: rG LLVM Github Monorepo CHANGES SIN

[PATCH] D109825: [AArch64]Enabling Cortex-A510 Support

lenary added a comment. In D109825#3066853 , @jansvoboda11 wrote: > This seems to be breaking the macOS bot, can you take a look? > https://green.lab.llvm.org/green/job/clang-stage1-RA/24735/ Will do. Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D109157: [ARM] Mitigate the cve-2021-35465 security vulnurability.

lenary accepted this revision. lenary added a comment. This revision is now accepted and ready to land. LGTM, but the most recent way of implementing this (using target features) was something I suggested to Alexandros based on @ostannard's feedback about LTO. I think it is cleaner, and this pat

<    1   2   3