salari01 created this revision.
Extended the integrated assembler -Wa,-defsym option to be usable with the
Clang driver. Both options arehandled in the same way. Using -defsym when
not assembling files shows an unused argument warning.
https://reviews.llvm.org/D31496
Files:
include/clan
salari01 added inline comments.
Comment at: lib/Driver/ToolChains/Clang.cpp:1882
+TakeNextArg = true;
}
} else {
rogfer01 wrote:
> I wonder if you should `break;` here if validation fails like the original
> code did?
The reason for
salari01 created this revision.
When using the C preprocessor with assembly files, either with a capital `S`
file extension, or with `-xassembler-with-cpp`, the Unicode escape sequence
`\u` is ignored. The `\u` pattern can be used for expanding a macro argument
that starts with `u`.
https://r
salari01 updated this revision to Diff 94501.
salari01 added a comment.
Updated test to check preprocessed output instead of the assembled file. Cannot
use `-verify` with the driver, but with `-E` and `-o -`, there is no longer a
need to have the dummy warning to avoid the FileCheck error.
htt
salari01 abandoned this revision.
salari01 added a comment.
In https://reviews.llvm.org/D31496#721262, @rnk wrote:
> `-Wl,--defsym` is also a pretty common linker option. I'm hesitant to add
> this to the driver interface, since it seems like they could easily be
> confused.
I see. Was not aw
