[PATCH] D112890: headers: optionalise some generated resource headers

compnerd added a comment. In D112890#3099208 , @tschuett wrote: > I am undecided between this may break something and I cannot use the risc-v > headers on an x86 machine. This fundamentally cannot break something outside of the RISC-V //target//, it is

[PATCH] D112890: headers: optionalise some generated resource headers

compnerd added a comment. In D112890#3099256 , @tschuett wrote: > If I understand you correctly, I would need to pass something ala `-target > riscv-xx` to enable `__riscv_vector`. However, this is impossible because > the risk target is disabled. So I

[PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: llvm/CMakeLists.txt:289 +set(LLVM_TOOLS_INSTALL_DIR "${CMAKE_INSTALL_BINDIR}" CACHE STRING +"Path for binary subdirectory (defaults to 'bin')") mark_

[PATCH] D112890: headers: optionalise some generated resource headers

compnerd added a comment. @craig.topper - ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112890/new/ https://reviews.llvm.org/D112890 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[PATCH] D114639: Raise the minimum Visual Studio version to VS2019

compnerd added inline comments. Comment at: clang/docs/UsersManual.rst:3546 -cmake -G"Visual Studio 15 2017" -T LLVM .. +cmake -G"Visual Studio 17 2022" -T LLVM .. Meinersbur wrote: > jhenderson wrote: > > RKSimon wrote: > > > aaron.ballman wrote: > >

[PATCH] D113863: [clang-tidy] Make `readability-container-data-pointer` more robust

compnerd added inline comments. Comment at: clang-tools-extra/clang-tidy/readability/ContainerDataPointerCheck.cpp:22 +constexpr llvm::StringLiteral DerefContainerExprName = "deref-container-expr"; +constexpr llvm::StringLiteral AddrofContainerExprName = "addrof-container-expr"

[PATCH] D133890: [CMake] Do these replacements to make use of D132608

compnerd added a comment. I don't see anything wrong with this change per se, but I'm conflicted on the name of the variable. These are not standard variables but are encroaching on the CMake namespace. What happens if upstream decides to use these names? I think that we should keep the name

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

compnerd added a comment. @thakis and https://github.com/llvm/llvm-project/issues/59640 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139266/new/ https://reviews.llvm.org/D139266 ___ cfe-commits mailing

[PATCH] D140507: Parse: handle another case of invalid handling for attributes

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a subscriber: jdoerfert. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. clang would improperly disallow GNU attributes before C++ standard attributes when

[PATCH] D140507: Parse: handle another case of invalid handling for attributes

compnerd added a comment. I think that the current release note should be sufficient. This is handling the same scenario in a different path. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140507/new/ https://reviews.llvm.org/D140507

[PATCH] D140507: Parse: handle another case of invalid handling for attributes

This revision was automatically updated to reflect the committed changes. Closed by commit rG179d24d764ac: Parse: handle another case of invalid handling for attributes (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140507/new/

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd created this revision. compnerd added reviewers: aaron.ballman, sammccall. Herald added a subscriber: jdoerfert. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. We would previously reject valid input where GNU attributes preceded the

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd added inline comments. Comment at: clang/unittests/Tooling/SourceCodeTest.cpp:249-258 Visitor.runOverAnnotated(R"cpp( - #define ATTR __attribute__((deprecated("message"))) - $r[[ATTR + $r[[__attribute__((deprecated("message"))) int x;]])cpp");

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd updated this revision to Diff 475530. compnerd added a comment. Add unsupported test cases CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDeclCXX.cpp clang/lib/Pars

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd updated this revision to Diff 475570. compnerd edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDeclCXX.cpp clang/lib/Parse/ParseHL

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd updated this revision to Diff 476163. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979 Files: clang/include/clang/Parse/Parser.h clang/lib/Parse/ParseDeclCXX.cpp clang/lib/Parse/ParseHLSL.cpp clang/lib/Parse/ParseObjc.cpp clang

[PATCH] D126599: [docs][clang] Fix a broken link on the APINotes doc

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. It seems that other docs are following the GitHub URLs as well. I wish we could do the relative document link instead of embedding the URL, but if that is not possible, then this makes se

[PATCH] D92797: APINotes: add initial stub of APINotesWriter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf806be5eaae1: APINotes: add initial stub of APINotesWriter (authored by Saleem Abdulrasool , committed by compnerd). Changed p

[PATCH] D154130: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG05d613ea931b: [lit][clang] Avoid realpath on Windows due to MAX_PATH limitations (authored by compnerd). Repository: rG LLVM Github Monorepo CHAN

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd marked 5 inline comments as done. compnerd added inline comments. Comment at: clang/include/clang/Parse/Parser.h:1605-1606 // C99 6.9: External Definitions. DeclGroupPtrTy ParseExternalDeclaration(ParsedAttributes &Attrs, +

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

compnerd updated this revision to Diff 476949. compnerd marked an inline comment as done. compnerd added a comment. Address review feedback CHANGES SINCE LAST ACTION https://reviews.llvm.org/D137979/new/ https://reviews.llvm.org/D137979 Files: clang/include/clang/Parse/Parser.h clang/lib

[PATCH] D137979: parse: process GNU and standard attributes on top-level decls

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb78d5380da11: parse: process GNU and standard attributes on top-level decls (authored by compnerd). Changed prior to commit: https://reviews.llvm.

[PATCH] D138122: Lift EHPersonalities from Analysis to IR (NFC)

compnerd accepted this revision. compnerd added a comment. Additional validation is never a bad thing :). Please do sort the headers before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138122/new/ https://reviews.llvm.org/D138122 __

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd created this revision. compnerd added a reviewer: aaron.ballman. compnerd added a project: clang. Herald added a project: All. compnerd requested review of this revision. The itanium ABI represents the PMF as a pair of pointers. As such the structure cannot be passed through a single reg

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:381 +if (!Context.getTargetInfo().getCXXABI().isMicrosoft()) + if (const auto *UO = dyn_cast(InputExpr)) +if (UO->getOpcode() == UO_AddrOf) aaron.ballman wrote: > rnk wrot

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd marked an inline comment as done. compnerd added inline comments. Comment at: clang/test/Sema/gnu-asm-pmf.cpp:1-34 +// RUN: %clang_cc1 -triple x86_64-unknown-windows-msvc -std=c++2b -fsyntax-only -verify %s -DMICROSOFT_ABI +// RUN: %clang_cc1 -triple x86_64-unknown-wind

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd updated this revision to Diff 479752. compnerd marked an inline comment as done. compnerd added a comment. Address feedback from review CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138514/new/ https://reviews.llvm.org/D138514 Files: clang/include/clang/Basic/DiagnosticSemaK

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd added inline comments. Comment at: clang/lib/Sema/SemaStmtAsm.cpp:381 +if (!Context.getTargetInfo().getCXXABI().isMicrosoft()) + if (const auto *UO = dyn_cast(InputExpr)) +if (UO->getOpcode() == UO_AddrOf) rnk wrote: > compnerd wrote: >

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

compnerd created this revision. compnerd added reviewers: aaron.ballman, Mordante, fsb4000. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. MSVC requires that C++23 be available (`_HAS_CXX23`) else the entire content is elided. Conditionalis

[PATCH] D76979: [clang][llvm] Interface Stubs new yaml file format changes.

compnerd added a comment. Please address the linter warnings. I think that adding an additional test to demonstrate that the `experimental-ifs-version-v1` is properly diagnosed is a good idea. LGTM other than that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D77233: [NFC] Refactoring PropertyAttributeKind for ObjCPropertyDecl and ObjCDeclSpec.

compnerd added inline comments. Comment at: clang/include/clang/AST/DeclObjCCommon.h:21 +/// Keep this list in sync with LLVM's Dwarf.h ApplePropertyAttributes. +enum ObjCPropertyAttributeKind { + OBJC_PR_noattr = 0x00, It seems that you are touching all the sit

[PATCH] D75453: [Driver][ARM] fix undefined behaviour when checking architecture version

compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. Herald added a subscriber: danielkiss. Seems reasonable, though this isn't UB, its just use of an uninitialized variable. Please add a test case. Repository: rG LLVM Github M

[PATCH] D69763: [Clang][Test]: Remaining "lld-link2" -> "lld-link"

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Seems like a good idea since lld link2 has been made into lld link for a while now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69763/new/

[PATCH] D69869: [clang-tools-extra] fix the check for if '-latomic' is necessary

compnerd added a comment. I agree with @efriedma that it sounds odd, could you explain that please? It took about 3 reads before I saw the OUT in the WITHOUT, and then realized that this was just: `NOT (HAVE_CXX_ATOMICS_WITHOUT_LIB AND HAVE_CXX_ATOMICS64_WITHOUT_LIB)`. I don't know if there is

[PATCH] D69995: [clang][IFS] Adding support for processing more decl types in clang interface stubs.

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:202 + // or templated type. + if (cast(ND)->getType()->isDependentType() || + cas

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

compnerd added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3493 +llvm::SmallVector &PL = PhaseList; +types::getCompilationPhases(types::TY_IFS_CPP, PL); +llvm::SmallVector CompilePhaseList; The reference binding is odd. Why not just pass

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

compnerd added inline comments. Comment at: clang/lib/Driver/Driver.cpp:3506 + types::ID InputType = I.first; + const Arg *InputArg = I.second; + plotfi wrote: > compnerd wrote: > > structured bindings ... so much. > I don't understand? C++17's structu

[PATCH] D70306: clang: Exherbo multiarch ajustments

compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. The test adjustments are incorrect. They should optionally accept the triple in the path. Comment at: clang/lib/Driver/ToolChains/Linux.cpp:360 + addPath

[PATCH] D70274: [clang][IFS] Driver pipeline change for clang-ifs: generate interface stubs after standard pipeline.

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: clang/lib/Driver/Driver.cpp:3491 + if (Arg *A = Args.getLastArg(options::OPT_emit_interface_stubs)) { + +llvm::SmallVector PhaseList; ---

[PATCH] D70764: build: reduce CMake handling for zlib

compnerd created this revision. compnerd added reviewers: beanz, smeenai. Herald added subscribers: lldb-commits, Sanitizers, hiraditya, mgorny. Herald added projects: clang, Sanitizers, LLDB, LLVM. Rather than handling zlib handling manually, use `find_package` from CMake to find zlib properly.

[PATCH] D70764: build: reduce CMake handling for zlib

compnerd added a comment. @labath I think you are misunderstanding the patch. This is not autoselecting the dependencies. It is simply doing that based on an existing option that we have - `LLVM_ENABLE_ZLIB`. We could always search for zlib and override the results with `LLVM_ENABLE_ZLIB` as

[PATCH] D70838: [clang][IFS] Ignoring -Xlinker/-Xclang arguments in InterfaceStubs pass for now.

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Could you please provide a proper commit message before committing this? Also `-Xifs` is actually the inverse of what you want - that would be a set of arguments designed to be passed to

[PATCH] D70839: [clang][IFS] Claiming -emit-merged-ifs in clang driver when -c is used.

compnerd added a comment. The commit message doesn't really explain much. Why simply consume the argument? Why not actually halt the build since this clearly is conflicting, and its unclear what the user intended. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://rev

[PATCH] D70764: build: reduce CMake handling for zlib

compnerd added a comment. In D70764#1767395 , @JDevlieghere wrote: > Having one canonical variable controlling zlib support seems indeed desirable. > > In D70519#1754618 , @labath wrote: > > > With this patch, what

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

compnerd added a comment. Should probably add a check for `__block` variables. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71301/new/ https://reviews.llvm.org/D71301 ___ cfe-commits mailing list cfe-

[PATCH] D71301: [clang][IFS] Prevent Clang-IFS from Leaking symbols from inside a block.

compnerd added inline comments. Comment at: clang/lib/Frontend/InterfaceStubFunctionsConsumer.cpp:60 + if (const auto *MD = dyn_cast_or_null(Parent)) +return true; +} Use `isa` rather than `dyn_cast_or_null`. Furthermore, the `dyn_ca

[PATCH] D44671: [libcxx] Enable static libcxxabi linking on Darwin

compnerd added a reviewer: dexonsmith. compnerd added a comment. I want to get Duncan's input on this. I don't think that this is a supported configuration for macOS. Repository: rCXX libc++ https://reviews.llvm.org/D44671 ___ cfe-commits maili

[PATCH] D44646: Sema: in msvc compatibility mode, don't allow forceinline on variadics

compnerd added inline comments. Comment at: test/Sema/ms-forceinline-on-variadic.cpp:14 +__builtin_va_end(ap); +} + DHowett-MSFT wrote: > compnerd wrote: > > Would be nice to have a second test that uses the Microsoft definitions > > (`char *` and the offset

[PATCH] D44753: [Preprocessor] Rename __is_{target -> host}_* function-like builtin macros

compnerd added a comment. I may be a bit biased but I agree with @bob.wilson and @steven_wu. The current names are better from the user’s perspective. GCC’s build is a very bad example as it has runtime components built as part of it (libgcc). When building any code, even in a Canadian cross

[PATCH] D44494: [libunwind] Support __register_frame with a full .eh_frame section

compnerd requested changes to this revision. compnerd added a comment. This revision now requires changes to proceed. I really don't like this approach. I think that we should introduce a different entry point for this behavior rather than saying that we go through the existing interface. Havi

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

compnerd created this revision. compnerd added a project: clang. Herald added subscribers: kristof.beyls, javed.absar, aemerson. Centralise the definitions of these compiler vended types to aid inspection to ensure that they are defined similarly. The one case that stands out is the Darwin case w

[PATCH] D39281: [libunwind] Express Registers_*::lastDwarfReg using _LIBUNWIND_HIGHEST_DWARF_REGISTER

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: src/DwarfInstructions.hpp:170 const int lastReg = R::lastDwarfRegNum(); - assert((int)CFI_Parser::kMaxRegisterNumber > lastReg && + asser

[PATCH] D39280: [libunwind] Use uint64_t for unw_word_t in ARM EHABI

compnerd added a comment. I dont think that this is correct. IIRC, the unwind specification expects `unw_word_t` to match `uintptr_t` (that is, it should be 32-bits on https://reviews.llvm.org/P32 environments). https://reviews.llvm.org/D39280 __

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

compnerd updated this revision to Diff 120534. compnerd added a comment. Catch a couple of missed instances, add more context Repository: rL LLVM https://reviews.llvm.org/D39321 Files: lib/Basic/Targets/ARM.cpp test/Preprocessor/init.c Index: test/Preprocessor/init.c ===

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

compnerd added inline comments. Comment at: lib/Basic/Targets/ARM.cpp:231 + else if (Triple.isWatchABI()) +PtrDiffType = SignedLong; + I changed this to: if (Triple.isOSDarwin() && !Triple.isWatchABI()) PtrDiffType = SignedInt; Repository: rL

[PATCH] D38110: [libunwind][MIPS]: Add support for unwinding in O32 and N64 processes.

compnerd added inline comments. Comment at: include/__libunwind_config.h:69 +# define _LIBUNWIND_CURSOR_SIZE 47 +# define _LIBUNWIND_HIGHEST_DWARF_REGISTER 65 # else Can we sink the two cases into the `__mips__` case? Something like: #if defined(__mips__

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

compnerd added a comment. Yeah, we have coverage for the various environments in `test/Preprocessor/init.c`. The one case that I didn't find was the APCS-GNU case, which I added a test for additional coverage. Repository: rL LLVM https://reviews.llvm.org/D39321 _

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

compnerd closed this revision. compnerd added a comment. SVN r316810 Repository: rL LLVM https://reviews.llvm.org/D39321 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D39321: ARM: centralise SizeType, PtrDiffType, and IntPtrType

compnerd added a comment. Well, without matching that ABI, I think that centralizing the logic isn't any cleaner, since we determine the ABI later. With this, we also match the ABI as GNU defines it, and we can move the logic to the same location. `intptr_t` on Darwin && !WatchOS has the one

[PATCH] D39382: [libunwind] Restore arch specific lastDwarfRegNum in builds without _LIBUNWIND_IS_NATIVE_ONLY

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. This is fine, although, how does the cross-unwinding work without the remote address space support? https://reviews.llvm.org/D39382 ___ cfe-

[PATCH] D39251: [libunwind] Fix building for ARM with dwarf exception handling

compnerd accepted this revision. compnerd added inline comments. This revision is now accepted and ready to land. Comment at: src/Registers.hpp:1481 + mutable uint32_t _iwmmx_control[4]; #endif }; Why the change to mark these as mutable? https://reviews.llvm

[PATCH] D39534: [libunwind] Add ifdefs around ELF specific parts of UnwindRegisters*.S for ARM

compnerd requested changes to this revision. compnerd added inline comments. This revision now requires changes to proceed. Comment at: src/UnwindRegistersRestore.S:396 .fpu vfpv3-d16 +#endif DEFINE_LIBUNWIND_PRIVATE_FUNCTION(_ZN9libunwind13Registers_arm19restoreVFPWithFLDMD

[PATCH] D39534: [libunwind] Add ifdefs around ELF specific parts of UnwindRegisters*.S for ARM

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Very well, if thats the current implementation in the AsmParser, thats reasonable. I don't think that the directive has anything to do with the file format though. https://reviews.llvm.

[PATCH] D40115: Driver: remove `SupportsObjCGC`

compnerd created this revision. Herald added subscribers: aheejin, jgravelle-google, sbc100, dschuff, jfb. This option is not used in the frontend. Remove the method. Repository: rL LLVM https://reviews.llvm.org/D40115 Files: include/clang/Driver/ToolChain.h lib/Driver/ToolChains/BareMe

[PATCH] D40115: Driver: remove `SupportsObjCGC`

compnerd added a comment. @rjmccall this is quite a straightforward change, just not sure if there is some use for this that I cant think of off the top of my head to preserve this. Repository: rL LLVM https://reviews.llvm.org/D40115 ___ cfe-com

[PATCH] D40127: [Driver][ARM] For assembler files recognize -Xassembler or -Wa, -mthumb

compnerd added inline comments. Comment at: lib/Driver/ToolChain.cpp:549-556 +bool IsIntegratedAssemblerThumb = false; +for (const Arg *A : + Args.filtered(options::OPT_Wa_COMMA, options::OPT_Xassembler)) { + for (StringRef Value : A->getValues()) { +

[PATCH] D40127: [Driver][ARM] For assembler files recognize -Xassembler or -Wa, -mthumb

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Would be nice to rename the variable prior to commit. Comment at: lib/Driver/ToolChain.cpp:549-556 +bool IsIntegratedAssemblerThumb = false; +for (const Arg *A :

[PATCH] D40115: Driver: remove `SupportsObjCGC`

compnerd closed this revision. compnerd added a comment. SVN r318609 Repository: rL LLVM https://reviews.llvm.org/D40115 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D40256: [ARM] disable FPU features when using soft floating point.

compnerd added inline comments. Comment at: lib/Driver/ToolChains/Arch/ARM.cpp:419 +Features.push_back("-fullfp16"); + +const bool HasNeon = (std::find(ItBegin, ItEnd, "+neon") != ItEnd); It would be nice to not have these explicitly listed. But at

[PATCH] D146165: docs: add some documentation on Windows SDK search

compnerd created this revision. compnerd added reviewers: hans, rnk, mstorsjo. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. Add some documentation on the flags and the process by which clang identifies the headers and libraries for the Win

[PATCH] D146165: docs: add some documentation on Windows SDK search

compnerd added a comment. > Looks reasonable I guess - but I think it would be good to mention the env > variables INCLUDE and LIB too, for alternative ways of finding the same > things - even if it's not strictly the same as what this new section talks > about. Yes, I agree, I did miss that i

[PATCH] D146165: docs: add some documentation on Windows SDK search

compnerd marked an inline comment as not done. compnerd added inline comments. Comment at: clang/docs/UsersManual.rst:4504 +programs against the Windows system packages. Underlying the Windows SDK is the +UCRT, the universal C runtime. + hans wrote: > Optionall

[PATCH] D146165: docs: add some documentation on Windows SDK search

compnerd updated this revision to Diff 506978. compnerd added a comment. Update to include additional behaviour and reference `INCLUDE` and `LIB`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146165/new/ https://reviews.llvm.org/D146165 Files:

[PATCH] D146165: docs: add some documentation on Windows SDK search

This revision was automatically updated to reflect the committed changes. Closed by commit rG893ce5759fe2: docs: add some documentation on Windows SDK search (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D146165?vs=506978&id=507346#toc Repository: rG LLVM Github M

[PATCH] D145007: Driver: introduce GNU spellings to control MSVC paths

compnerd created this revision. compnerd added reviewers: rnk, mstorsjo. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. Add a set of `-Xmicrosoft` flags to control the Windows SDK and VisualC tools directories. This allows control over the

[PATCH] D145007: Driver: introduce GNU spellings to control MSVC paths

compnerd added a comment. Yeah, I suspect that would be difficult. Additionally, these are aliases, so they should already have testing coverage through the existing tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145007/new/ https://reviews

[PATCH] D145007: Driver: introduce GNU spellings to control MSVC paths

compnerd added a comment. Just a friendly reminder, I'd like to get this merged to do a follow up change to improve some of the usability of these flags. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145007/new/ https://reviews.llvm.org/D145007 _

[PATCH] D145007: Driver: introduce GNU spellings to control MSVC paths

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf1440bf6fd22: Driver: introduce GNU spellings to control MSVC paths (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D145517: MSVC: support version preference with search

compnerd created this revision. compnerd added reviewers: mstorsjo, rnk. Herald added a subscriber: hiraditya. Herald added a project: All. compnerd requested review of this revision. Herald added subscribers: llvm-commits, MaskRay. Herald added projects: clang, LLVM. Extend the logic for the WinS

[PATCH] D145517: MSVC: support version preference with search

compnerd added a comment. Sure thing, I can try to write up some details about that @hans! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D145517/new/ https://reviews.llvm.org/D145517 ___ cfe-commits maili

[PATCH] D145517: MSVC: support version preference with search

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf5f46822847: MSVC: support version preference with search (authored by compnerd). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D151837: [Clang][Parser] Accept GNU attributes preceding C++ style attributes on templates

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. Could you add a test case for the inverted order of attributes on a template as well? I don't think that there is a test case for that. CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D139749: Headers: use C++ inline semantics in C++ mode

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3b0677964c46: Headers: use C++ inline semantics in C++ mode (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D139749?vs=4

[PATCH] D152051: libclang-cpp: Add external visibility attribute to all classes

compnerd added a comment. In D152051#4392612 , @tstellar wrote: > I was not sure what to do with inline functions and also functions that were > implemented in the headers, so I did not add the LLVM_EXTERNAL_VISIBILITY > macro to most of those functions

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd updated this revision to Diff 480523. compnerd added a comment. Add a test case for member data. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D138514/new/ https://reviews.llvm.org/D138514 Files: clang/include/clang/Basic/DiagnosticSemaKinds.td clang/lib/Sema/SemaStmtAsm.cp

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

compnerd added inline comments. Comment at: clang/lib/Headers/stdatomic.h:21 +#if __STDC_HOSTED__ && __has_include_next() \ +&& !(defined(_MSC_VER) && __cplusplus-0 < 202002l) # include_next Mordante wrote: > Is `__cplusplus-0` inten

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

compnerd updated this revision to Diff 480531. compnerd added a comment. Update to avoid use of the `-0` trick. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139266/new/ https://reviews.llvm.org/D139266 Files: clang/lib/Headers/stdatomic.h Index: clang/lib/Headers/stdatomic.h =

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

compnerd added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR); if

[PATCH] D138514: Sema: diagnose PMFs passed through registers to inline assembly

compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. (Accepting Revision for Closing) I missed the trailing number of the differential revision, and it failed to tie it to this. The commit is at https://github.com/llvm/llvm-project/commit/

[PATCH] D137337: Replace LLVM_LIBDIR_SUFFIX by CMAKE_INSTALL_LIBDIR

compnerd added inline comments. Comment at: bolt/lib/RuntimeLibs/RuntimeLibrary.cpp:32 SmallString<128> LibPath = llvm::sys::path::parent_path(Dir); - llvm::sys::path::append(LibPath, "lib" LLVM_LIBDIR_SUFFIX); + llvm::sys::path::append(LibPath, CMAKE_INSTALL_LIBDIR); if

[PATCH] D139749: Headers: make a couple of builtins non-static

compnerd created this revision. compnerd added a reviewer: aaron.ballman. Herald added a project: All. compnerd requested review of this revision. Herald added a project: clang. When building with the 17.5.0 preview toolset for MSVC and building with modules, the definition of `_addcarry_u64` and

[PATCH] D139749: Headers: make a couple of builtins non-static

compnerd added a subscriber: STL_MSFT. compnerd added a comment. @fsb4000 is my reading correct that MSVC will look into trying to handle `static inline` even though it is a GNUism? I wonder if we should consider limiting the use of `static inline` to C mode rather than including C++. I also

[PATCH] D139749: Headers: make a couple of builtins non-static

compnerd added a comment. Seems that this alone is insufficient as some build does run into issues, so I may need to refine this further. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139749/new/ https://reviews.llvm.org/D139749 _

[PATCH] D139749: Headers: use C++ inline semantics in C++ mode

compnerd updated this revision to Diff 483081. compnerd retitled this revision from "Headers: make a couple of builtins non-static" to "Headers: use C++ inline semantics in C++ mode". compnerd edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D139749/new/

[PATCH] D139749: Headers: use C++ inline semantics in C++ mode

compnerd added a comment. Thanks @fsb4000 (and @CaseyCarter)! I think that due to the shipped version, it makes sense to do this still. Using standard semantics in general I think is preferable, since nothing prevents another compiler implementation to still do something similar. CHANGES SI

[PATCH] D139266: Headers: tweak inclusion condition for stdatomic.h

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0c3142af075: Headers: tweak inclusion condition for stdatomic.h (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D139266

[PATCH] D26796: [Driver] Use arch type to find compiler-rt libraries (on Linux)

compnerd added a comment. This would need an upgrade path, since the output name can actually be different from the `AchTypeName` (e.g. i386 vs i686). https://reviews.llvm.org/D26796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://li

[PATCH] D28210: system_error: inline error_category ctor on Win32

compnerd created this revision. compnerd added reviewers: EricWF, mclow.lists, majnemer. compnerd added subscribers: smeenai, cfe-commits. compnerd set the repository for this revision to rL LLVM. Because the class is marked as `dllexport` and instantiated in `algorithm.cpp` and is strongly define

[PATCH] D28211: typeinfo: provide a destructor for type_info

compnerd created this revision. compnerd added reviewers: EricWF, mclow.lists. compnerd added subscribers: smeenai, cfe-commits. compnerd set the repository for this revision to rL LLVM. When building without libc++abi and libcxxrt, provide the definition for the std::type_info destructor. Repos

[PATCH] D28212: typeinfo: provide a partial implementation for Win32

compnerd created this revision. compnerd added reviewers: EricWF, mclow.lists, majnemer, rnk. compnerd added subscribers: smeenai, kastiglione, cfe-commits. compnerd set the repository for this revision to rL LLVM. The RTTI structure is different on Windows when building under MS ABI. Update the d

<    1   2   3   4   5   6   7   >