[clang] [webkit.UncountedLambdaCapturesChecker] Fix a nullptr deference. (PR #120702)

rniwa wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/120702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebKit checkers] Recognize adoptRef as a safe function (PR #120629)

https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/120629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Detect protectedThis pattern. (PR #120528)

rniwa wrote: Thanks for the review https://github.com/llvm/llvm-project/pull/120528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Webkit Checkers] Introduce a Webkit checker for memory unsafe casts (PR #114606)

@@ -0,0 +1,185 @@ +//===- MemoryUnsafeCastChecker.cpp -*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[clang] [Webkit Checkers] Introduce a Webkit checker for memory unsafe casts (PR #114606)

@@ -0,0 +1,185 @@ +//===- MemoryUnsafeCastChecker.cpp -*- C++ -*-==// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apach

[clang] [webkit.UncountedLambdaCapturesChecker] Fix debug assertion failure. (PR #117090)

https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/117090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Fix debug assertion failure. (PR #117090)

rniwa wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/117090 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Ignore lambda invocation with arguments (PR #117394)

rniwa wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/117394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Ignore lambda invocation with arguments (PR #117394)

https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/117394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Ignore lambda invocation with arguments (PR #117394)

https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/117394 Fixed a bug that UncountedLambdaCapturesChecker would emit a warning on a lambda capture when the lambda is invoked with arguments. LocalVisitor::VisitCallExpr was not tolerating a lambda invocation with more th

[clang] [Static analysis] Encodes a filename before inserting it into a URL. (PR #120810)

https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/120810 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Recognize nested protectedThis pattern (PR #126443)

rniwa wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/126443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebKit Checkers] Treat attributes as trivial (PR #127289)

https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/127289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebKit Checkers] Treat attributes as trivial (PR #127289)

rniwa wrote: Thanks for the quick review! https://github.com/llvm/llvm-project/pull/127289 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Recognize nested protectedThis pattern (PR #126443)

@@ -299,6 +300,29 @@ struct RefCountableWithLambdaCapturingThis { return obj->next(); }); } + + void callAsyncNoescape([[clang::noescape]] WTF::Function&&); + void method_temp_lambda(RefCountable* obj) { +callAsyncNoescape([this, otherObj = RefPtr { obj }](au

[clang] [WebKit Checkers] Treat offsetof as a trivial expression. (PR #126996)

rniwa wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/126996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Recognize nested protectedThis pattern (PR #126443)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/126443 >From a40e782b866ec4756ddf3f04cc09caff31845ebf Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sun, 9 Feb 2025 13:50:26 -0800 Subject: [PATCH 1/3] [webkit.UncountedLambdaCapturesChecker] Recognize nested protec

[clang] [webkit.UncountedLambdaCapturesChecker] Recognize nested protectedThis pattern (PR #126443)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/126443 >From a40e782b866ec4756ddf3f04cc09caff31845ebf Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sun, 9 Feb 2025 13:50:26 -0800 Subject: [PATCH 1/4] [webkit.UncountedLambdaCapturesChecker] Recognize nested protec

[clang] [webkit.UncountedLambdaCapturesChecker] Recognize nested protectedThis pattern (PR #126443)

https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/126443 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebKit Checkers] Treat attributes as trivial (PR #127289)

https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/127289 For the purpose of determining triviality, ignore all attributes. >From 31e0fcbf7f8bf4d2244c863041df3716a598db3f Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Wed, 12 Feb 2025 22:16:11 -0800 Subject: [PATCH]

[clang] [webkit.UncountedLambdaCapturesChecker] Recognize nested protectedThis pattern (PR #126443)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/126443 >From a40e782b866ec4756ddf3f04cc09caff31845ebf Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sun, 9 Feb 2025 13:50:26 -0800 Subject: [PATCH 1/3] [webkit.UncountedLambdaCapturesChecker] Recognize nested protec

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow ArrayInitLoopExpr and OpaqueValueExpr in trivial expressions (PR #127182)

@@ -0,0 +1,47 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.webkit.UncountedCallArgsChecker -verify %s rniwa wrote: Added a non-trivial test case. https://github.com/llvm/llvm-project/pull/127182 ___ cfe-comm

[clang] [webkit.UncountedLambdaCapturesChecker] Support [[clang::noescape]] on a constructor (PR #126869)

@@ -106,6 +107,26 @@ class UncountedLambdaCapturesChecker return safeGetName(NsDecl) == "WTF" && safeGetName(Decl) == "switchOn"; } + bool VisitCXXConstructExpr(CXXConstructExpr *CE) override { +if (ConstructToIgnore.contains(CE)) + return t

[clang] [webkit.UncountedLambdaCapturesChecker] Recognize nested protectedThis pattern (PR #126443)

@@ -299,6 +300,29 @@ struct RefCountableWithLambdaCapturingThis { return obj->next(); }); } + + void callAsyncNoescape([[clang::noescape]] WTF::Function&&); + void method_temp_lambda(RefCountable* obj) { +callAsyncNoescape([this, otherObj = RefPtr { obj }](au

[clang] [webkit.UncountedLambdaCapturesChecker] Recognize nested protectedThis pattern (PR #126443)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/126443 >From a40e782b866ec4756ddf3f04cc09caff31845ebf Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sun, 9 Feb 2025 13:50:26 -0800 Subject: [PATCH 1/2] [webkit.UncountedLambdaCapturesChecker] Recognize nested protec

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow ArrayInitLoopExpr and OpaqueValueExpr in trivial expressions (PR #127182)

@@ -0,0 +1,47 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.webkit.UncountedCallArgsChecker -verify %s rniwa wrote: We have tests for non-trivial expressions: clang/test/Analysis/Checkers/WebKit/uncounted-obj-arg.cpp. I guess we can add a test case he

[clang] [webkit.UncountedLambdaCapturesChecker] Support [[clang::noescape]] on a constructor (PR #126869)

https://github.com/rniwa edited https://github.com/llvm/llvm-project/pull/126869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebKit Checkers] Treat offsetof as a trivial expression. (PR #126996)

https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/126996 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Support [[clang::noescape]] on a constructor (PR #126869)

rniwa wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/126869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Support [[clang::noescape]] on a constructor (PR #126869)

https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/126869 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow ArrayInitLoopExpr and OpaqueValueExpr in trivial expressions (PR #127182)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/127182 >From 2be47498ca7597748ee8b29f5d39d74608c2f4d3 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Fri, 14 Feb 2025 00:48:36 -0800 Subject: [PATCH 1/3] [alpha.webkit.UncountedCallArgsChecker] Allow ArrayInitLoopExp

[clang] [webkit.UncountedLambdaCapturesChecker] Recognize nested protectedThis pattern (PR #126443)

@@ -299,6 +300,29 @@ struct RefCountableWithLambdaCapturingThis { return obj->next(); }); } + + void callAsyncNoescape([[clang::noescape]] WTF::Function&&); + void method_temp_lambda(RefCountable* obj) { +callAsyncNoescape([this, otherObj = RefPtr { obj }](au

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow ArrayInitLoopExpr and OpaqueValueExpr in trivial expressions (PR #127182)

https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/127182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow ArrayInitLoopExpr and OpaqueValueExpr in trivial expressions (PR #127182)

rniwa wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/127182 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Fix a crash in declProtectsThis (PR #127309)

rniwa wrote: Thanks for the timely review! https://github.com/llvm/llvm-project/pull/127309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Fix a crash in declProtectsThis (PR #127309)

https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/127309 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebKit Checkers] Allow operator T&() in a const member function (PR #126470)

https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/126470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebKit Checkers] Allow operator T&() in a const member function (PR #126470)

rniwa wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/126470 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [webkit.UncountedLambdaCapturesChecker] Fix a crash in declProtectsThis (PR #127309)

https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/127309 Add a missing nullptr check to declProtectsThis. >From 715da2e5ec5cd64416a5dab9017a9c43a6ca8e78 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sat, 15 Feb 2025 01:33:47 -0800 Subject: [PATCH] [webkit.Uncounted

[clang] [webkit.UncountedLambdaCapturesChecker] Fix a crash in declProtectsThis (PR #127309)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/127309 >From 715da2e5ec5cd64416a5dab9017a9c43a6ca8e78 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Sat, 15 Feb 2025 01:33:47 -0800 Subject: [PATCH 1/2] [webkit.UncountedLambdaCapturesChecker] Fix a crash in declPro

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow ArrayInitLoopExpr and OpaqueValueExpr in trivial expressions (PR #127182)

https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/127182 Allow VisitArrayInitLoopExpr, VisitArrayInitIndexExpr, and VisitOpaqueValueExpr in trivial functions and statements. >From 2be47498ca7597748ee8b29f5d39d74608c2f4d3 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Dat

[clang] [WebKit Checkers] Treat offsetof as a trivial expression. (PR #126996)

https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/126996 None >From f7eafbfd258fb0acf60a01d033958f859c426ff3 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Wed, 12 Feb 2025 17:52:45 -0800 Subject: [PATCH] [WebKit Checkers] Treat offsetof as a trivial expression. --

[clang] [WebKit Checkers] Treat offsetof as a trivial expression. (PR #126996)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/126996 >From f7eafbfd258fb0acf60a01d033958f859c426ff3 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Wed, 12 Feb 2025 17:52:45 -0800 Subject: [PATCH 1/2] [WebKit Checkers] Treat offsetof as a trivial expression. ---

[clang] [WebKit Checkers] Treat offsetof as a trivial expression. (PR #126996)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/126996 >From f7eafbfd258fb0acf60a01d033958f859c426ff3 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Wed, 12 Feb 2025 17:52:45 -0800 Subject: [PATCH 1/3] [WebKit Checkers] Treat offsetof as a trivial expression. ---

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow ArrayInitLoopExpr and OpaqueValueExpr in trivial expressions (PR #127182)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/127182 >From 2be47498ca7597748ee8b29f5d39d74608c2f4d3 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Fri, 14 Feb 2025 00:48:36 -0800 Subject: [PATCH 1/2] [alpha.webkit.UncountedCallArgsChecker] Allow ArrayInitLoopExp

[clang] Check the type of Objective-C++ instance variables in WebKit member variable checkers. (PR #127570)

https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/127570 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UnretainedLocalVarsChecker] Add a checker for local variables to NS and CF types. (PR #127554)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/127554 >From d6c4e1a23dc0cc6850c5cfdceecc2e1be8943592 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 17 Feb 2025 18:18:09 -0800 Subject: [PATCH 1/4] [alpha.webkit.UnretainedLocalVarsChecker] Add a checker for lo

[clang] [alpha.webkit.UnretainedLocalVarsChecker] Add a checker for local variables to NS and CF types. (PR #127554)

@@ -3668,6 +3668,12 @@ Here are some examples of situations that we warn about as they *might* be poten RefCountable* uncounted = counted.get(); // warn } +alpha.webkit.UnretainedLocalVarsChecker +""" +The goal of this rule is to

[clang] [alpha.webkit.UnretainedLocalVarsChecker] Add a checker for local variables to NS and CF types. (PR #127554)

@@ -332,6 +345,14 @@ class UncheckedCallArgsChecker final : public RawPtrRefCallArgsChecker { return isUncheckedPtr(QT); } + bool isSafePtr(const CXXRecordDecl *Record) const final { +return isRefCounted(Record) || isCheckedPtr(Record); + } + + bool isSafePtrType

[clang] [alpha.webkit.NoUnretainedMemberChecker] Add a new WebKit checker for unretained member variables and ivars. (PR #128641)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128641 >From a4cd301d6176a8ee3441d0c74f6d2c4e32a50cdd Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 24 Feb 2025 23:01:31 -0800 Subject: [PATCH 1/2] [alpha.webkit.NoUnretainedMemberChecker] Add a new WebKit chec

[clang] [llvm] [alpha.webkit.UnretainedLambdaCapturesChecker] Add a WebKit checker for lambda capturing NS or CF types. (PR #128651)

https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/128651 Add a new WebKit checker for checking that lambda captures of CF types use RetainPtr either when ARC is disabled or enabled, and those of NS types use RetainPtr when ARC is disabled. >From dc53e0602fcec63bdd1bc8

[clang] [llvm] [alpha.webkit.UnretainedLambdaCapturesChecker] Add a WebKit checker for lambda capturing NS or CF types. (PR #128651)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128651 >From dc53e0602fcec63bdd1bc84325ecc16a3f3e293b Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 24 Feb 2025 23:39:13 -0800 Subject: [PATCH 1/2] [alpha.webkit.UnretainedLambdaCapturesChecker] Add a WebKit ch

[clang] [alpha.webkit.NoUnretainedMemberChecker] Add a new WebKit checker for unretained member variables and ivars. (PR #128641)

https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/128641 Add a new WebKit checker for member variables and instance variables of NS and CF types. A member variable or instance variable to a CF type should be RetainPtr regardless of whether ARC is enabled or disabled, a

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #128586)

https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/128586 This PR adds alpha.webkit.UnretainedCallArgsChecker by generalizing RawPtrRefLocalVarsChecker. It checks call arguments of NS or CF types are backed by a RetainPtr or not. The new checker is effective for NS and

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #128586)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128586 >From 90403f77295c0b3e4415263754e22b3c66f31876 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 24 Feb 2025 13:43:04 -0800 Subject: [PATCH 1/2] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS

[clang] [alpha.webkit.UnretainedLocalVarsChecker] Add a checker for local variables to NS and CF types. (PR #127554)

@@ -332,6 +345,14 @@ class UncheckedCallArgsChecker final : public RawPtrRefCallArgsChecker { return isUncheckedPtr(QT); } + bool isSafePtr(const CXXRecordDecl *Record) const final { +return isRefCounted(Record) || isCheckedPtr(Record); + } + + bool isSafePtrType

[clang] [alpha.webkit.UnretainedLocalVarsChecker] Add a checker for local variables to NS and CF types. (PR #127554)

https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/127554 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #128586)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128586 >From 90403f77295c0b3e4415263754e22b3c66f31876 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 24 Feb 2025 13:43:04 -0800 Subject: [PATCH 1/3] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #128586)

@@ -117,6 +127,9 @@ bool tryToFindPtrOrigin( E = call->getArg(0); continue; } + +if (safeGetName(callee) == "__builtin___CFStringMakeConstantString") rniwa wrote: This is for CFSTR. https://github.com/llvm/llvm-project/pull

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #128586)

@@ -28,6 +29,15 @@ bool tryToFindPtrOrigin( std::function isSafePtrType, std::function callback) { while (E) { +if (auto *DRE = dyn_cast(E)) { + auto *ValDecl = DRE->getDecl(); + auto QT = ValDecl->getType(); + auto ValName = ValDecl->getName(); +

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #128586)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128586 >From 90403f77295c0b3e4415263754e22b3c66f31876 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 24 Feb 2025 13:43:04 -0800 Subject: [PATCH 1/5] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #128586)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128586 >From 90403f77295c0b3e4415263754e22b3c66f31876 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 24 Feb 2025 13:43:04 -0800 Subject: [PATCH 1/6] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS

[clang] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebKit checker for correct use of RetainPtr, adoptNS, and adoptCF (PR #128679)

https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/128679 Add a new WebKit checker to validate the correct use of RetainPtr constructor as well as adoptNS and adoptCF functions. adoptNS and adoptCf are used for +1 semantics and RetainPtr constructor is used for +0 seman

[clang] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebKit checker for correct use of RetainPtr, adoptNS, and adoptCF (PR #128679)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128679 >From b4001f95cf6d35f59ef8af6df8f2bdbe043da380 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Tue, 25 Feb 2025 00:47:45 -0800 Subject: [PATCH 1/2] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebK

[clang] [alpha.webkit.UnretainedLocalVarsChecker] Add a checker for local variables to NS and CF types. (PR #127554)

@@ -332,6 +345,14 @@ class UncheckedCallArgsChecker final : public RawPtrRefCallArgsChecker { return isUncheckedPtr(QT); } + bool isSafePtr(const CXXRecordDecl *Record) const final { +return isRefCounted(Record) || isCheckedPtr(Record); + } + + bool isSafePtrType

[clang] [alpha.webkit.UnretainedLocalVarsChecker] Add a checker for local variables to NS and CF types. (PR #127554)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/127554 >From d6c4e1a23dc0cc6850c5cfdceecc2e1be8943592 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 17 Feb 2025 18:18:09 -0800 Subject: [PATCH 1/7] [alpha.webkit.UnretainedLocalVarsChecker] Add a checker for lo

[clang] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebKit checker for correct use of RetainPtr, adoptNS, and adoptCF (PR #128679)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128679 >From b4001f95cf6d35f59ef8af6df8f2bdbe043da380 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Tue, 25 Feb 2025 00:47:45 -0800 Subject: [PATCH 1/3] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebK

[clang] Check the type of Objective-C++ instance variables in WebKit member variable checkers. (PR #127570)

@@ -87,6 +92,31 @@ class RawPtrRefMemberChecker } } + void visitObjCDecl(const ObjCContainerDecl *CD) const { +if (auto *ID = dyn_cast(CD)) { rniwa wrote: oh, but this if statement does that already, right? as in, this if will only evaluate to tru

[clang] Check the type of Objective-C++ instance variables in WebKit member variable checkers. (PR #127570)

@@ -87,6 +92,31 @@ class RawPtrRefMemberChecker } } + void visitObjCDecl(const ObjCContainerDecl *CD) const { +if (auto *ID = dyn_cast(CD)) { + for (auto *Ivar : ID->ivars()) +visitIvarDecl(CD, Ivar); + return; +} +if (auto *ID = dyn_cast(C

[clang] Check the type of Objective-C++ instance variables in WebKit member variable checkers. (PR #127570)

@@ -87,6 +92,31 @@ class RawPtrRefMemberChecker } } + void visitObjCDecl(const ObjCContainerDecl *CD) const { +if (auto *ID = dyn_cast(CD)) { rniwa wrote: I don't think so. `ObjCContainerDecl` could be `ObjCCategoryDecl` or `ObjCProtocolDecl` as w

[clang] Check the type of Objective-C++ instance variables in WebKit member variable checkers. (PR #127570)

@@ -87,6 +92,31 @@ class RawPtrRefMemberChecker } } + void visitObjCDecl(const ObjCContainerDecl *CD) const { +if (auto *ID = dyn_cast(CD)) { + for (auto *Ivar : ID->ivars()) +visitIvarDecl(CD, Ivar); + return; +} +if (auto *ID = dyn_cast(C

[clang] [alpha.webkit.UnretainedLocalVarsChecker] Add a checker for local variables to NS and CF types. (PR #127554)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/127554 >From d6c4e1a23dc0cc6850c5cfdceecc2e1be8943592 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 17 Feb 2025 18:18:09 -0800 Subject: [PATCH 1/3] [alpha.webkit.UnretainedLocalVarsChecker] Add a checker for lo

[clang] [alpha.webkit.UnretainedLocalVarsChecker] Add a checker for local variables to NS and CF types. (PR #127554)

https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/127554 This PR adds alpha.webkit.UnretainedLocalVarsChecker by generalizing RawPtrRefLocalVarsChecker. It checks local variables to NS or CF types are guarded with a RetainPtr or not. The new checker is effective for NS

[clang] Check the type of Objective-C++ instance variables in WebKit member variable checkers. (PR #127570)

https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/127570 Like a C++ member variable, every Objective-C++ instance variable must be a RefPtr, Ref CheckedPtr, or CheckedRef to an object, not a raw pointer or reference. >From f93a95fc02a9389fda9597c6dffe0f16d8bc2bf1 Mon

[clang] [alpha.webkit.UnretainedLocalVarsChecker] Add a checker for local variables to NS and CF types. (PR #127554)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/127554 >From d6c4e1a23dc0cc6850c5cfdceecc2e1be8943592 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 17 Feb 2025 18:18:09 -0800 Subject: [PATCH 1/2] [alpha.webkit.UnretainedLocalVarsChecker] Add a checker for lo

[clang] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebKit checker for correct use of RetainPtr, adoptNS, and adoptCF (PR #128679)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128679 >From b4001f95cf6d35f59ef8af6df8f2bdbe043da380 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Tue, 25 Feb 2025 00:47:45 -0800 Subject: [PATCH 1/6] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebK

[clang] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebKit checker for correct use of RetainPtr, adoptNS, and adoptCF (PR #128679)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128679 >From b4001f95cf6d35f59ef8af6df8f2bdbe043da380 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Tue, 25 Feb 2025 00:47:45 -0800 Subject: [PATCH 1/5] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebK

[clang] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebKit checker for correct use of RetainPtr, adoptNS, and adoptCF (PR #128679)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128679 >From b4001f95cf6d35f59ef8af6df8f2bdbe043da380 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Tue, 25 Feb 2025 00:47:45 -0800 Subject: [PATCH 1/4] [alpha.webkit.webkit.RetainPtrCtorAdoptChecker] Add a new WebK

[clang] [alpha.webkit.UncountedCallArgsChecker] Recognize CXXUnresolvedConstructExpr as a safe origin. (PR #130258)

rniwa wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/130258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UncountedCallArgsChecker] Fix a false negative when a call argument is a local variable. (PR #129974)

https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/129974 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UncountedCallArgsChecker] Recognize CXXUnresolvedConstructExpr as a safe origin. (PR #130258)

https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/130258 Handle CXXUnresolvedConstructExpr in tryToFindPtrOrigin so that constructing Ref, RefPtr, CheckedRef, CheckedPtr, ... constructed in such a way that its type is unresolved at AST level will be still treated as a

[clang] [alpha.webkit.UncountedCallArgsChecker] Recognize CXXUnresolvedConstructExpr as a safe origin. (PR #130258)

https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/130258 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [alpha.webkit.UnretainedLambdaCapturesChecker] Add a WebKit checker for lambda capturing NS or CF types. (PR #128651)

@@ -3487,6 +3487,18 @@ Raw pointers and references to an object which supports CheckedPtr or CheckedRef See `WebKit Guidelines for Safer C++ Programming `_ for details. +alpha.webkit.UnretainedLambdaCapturesChecker

[clang] [llvm] [alpha.webkit.UnretainedLambdaCapturesChecker] Add a WebKit checker for lambda capturing NS or CF types. (PR #128651)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128651 >From dc53e0602fcec63bdd1bc84325ecc16a3f3e293b Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 24 Feb 2025 23:39:13 -0800 Subject: [PATCH 1/3] [alpha.webkit.UnretainedLambdaCapturesChecker] Add a WebKit ch

[clang] [alpha.webkit.NoUnretainedMemberChecker] Add a new WebKit checker for unretained member variables and ivars. (PR #128641)

@@ -0,0 +1,57 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.webkit.NoUnretainedMemberChecker -verify %s + +#include "objc-mock-types.h" + +namespace members { + + struct Foo { + private: +SomeObj* a = nullptr; +// expected-warning@-1{{Member variable 'a' in 'member

[clang] [alpha.webkit.NoUnretainedMemberChecker] Add a new WebKit checker for unretained member variables and ivars. (PR #128641)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128641 >From a4cd301d6176a8ee3441d0c74f6d2c4e32a50cdd Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 24 Feb 2025 23:01:31 -0800 Subject: [PATCH 1/3] [alpha.webkit.NoUnretainedMemberChecker] Add a new WebKit chec

[clang] [alpha.webkit.NoUnretainedMemberChecker] Add a new WebKit checker for unretained member variables and ivars. (PR #128641)

@@ -3487,6 +3487,19 @@ Raw pointers and references to an object which supports CheckedPtr or CheckedRef See `WebKit Guidelines for Safer C++ Programming `_ for details. +alpha.webkit.NoUnretainedMemberChecker +

[clang] [llvm] [alpha.webkit.UnretainedLambdaCapturesChecker] Add a WebKit checker for lambda capturing NS or CF types. (PR #128651)

rniwa wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/128651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [alpha.webkit.UnretainedLambdaCapturesChecker] Add a WebKit checker for lambda capturing NS or CF types. (PR #128651)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128651 >From dc53e0602fcec63bdd1bc84325ecc16a3f3e293b Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 24 Feb 2025 23:39:13 -0800 Subject: [PATCH 1/3] [alpha.webkit.UnretainedLambdaCapturesChecker] Add a WebKit ch

[clang] [alpha.webkit.UncountedCallArgsChecker] Fix a false negative when a call argument is a local variable. (PR #129974)

https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/129974 isASafeCallArg erroneously returns true when a call argument is a local variable regardless of its type. This is incorrect. We should only allow any local variable of a safe pointer type. Fix the bug by moving t

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #128586)

@@ -141,6 +158,42 @@ class RawPtrRefCallArgsChecker } } + void visitObjCMessageExpr(const ObjCMessageExpr *E, const Decl *D) const { +if (BR->getSourceManager().isInSystemHeader(E->getExprLoc())) + return; + +auto Selector = E->getSelector(); +if (auto

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #128586)

rniwa wrote: Let me close this and create a new PR with the corrected commit message. https://github.com/llvm/llvm-project/pull/128586 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #128586)

@@ -28,6 +29,15 @@ bool tryToFindPtrOrigin( std::function isSafePtrType, std::function callback) { while (E) { +if (auto *DRE = dyn_cast(E)) { + auto *ValDecl = DRE->getDecl(); + auto QT = ValDecl->getType(); + auto ValName = ValDecl->getName(); +

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #128586)

rniwa wrote: > This PR adds alpha.webkit.UnretainedCallArgsChecker by generalizing > RawPtrRefLocalVarsChecker. Do you mean RawPtrRefCallArgsChecker? Oh yeah, not sure how I'm gonna fix the typo in a commit message other than force pushing it though. https://github.com/llvm/llvm-project/pull/

[clang] [WebKit checkers] Don't treat virtual functions as safe. (PR #129632)

rniwa wrote: Thanks for the review! https://github.com/llvm/llvm-project/pull/129632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #130729)

https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/130729 This PR adds alpha.webkit.UnretainedCallArgsChecker by generalizing RawPtrRefCallArgsChecker. It checks call arguments of NS or CF types are backed by a RetainPtr or not. The new checker emits warnings for CF typ

[clang] [WebKit checkers] Don't treat virtual functions as safe. (PR #129632)

https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/129632 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [alpha.webkit.UnretainedLambdaCapturesChecker] Add a WebKit checker for lambda capturing NS or CF types. (PR #128651)

https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/128651 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS or CF type call arguments. (PR #128586)

https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/128586 >From 90403f77295c0b3e4415263754e22b3c66f31876 Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Mon, 24 Feb 2025 13:43:04 -0800 Subject: [PATCH 1/6] [alpha.webkit.UnretainedCallArgsChecker] Add a checker for NS

[clang] [alpha.webkit.ForwardDeclChecker] Add a new WebKit checker for forward declarations (PR #130554)

https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/130554 Add a new static analyzer which emits warnings for function call arguments, local variables, and member variables that are only forward declared. These forward declaration prevents other WebKit checkers from chec

<    1   2   3   4   5   6   7   >