[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

rpbeltran added a comment. This patch seems like a great contribution! Really glad to see this being added. I did have a question though on why this only appears to catch "&" vs "&&" instead of doing the same for "|" vs "||". It seems like both operators have roughly the same potential for conf

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

rpbeltran added a comment. Thanks! And sorry for missing that point in your first comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108003/new/ https://reviews.llvm.org/D108003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

rpbeltran added a comment. In D108003#2956332 , @xbolva00 wrote: >>> and it would be more of an optimization than correctness issue as far as I >>> understand > > Yeah, this is right, indeed. > > Maybe @rpbeltran has some idea or motivating cases for OR

[PATCH] D108003: [Clang] Extend -Wbool-operation to warn about bitwise and of bools with side effects

rpbeltran added a comment. Sorry for the late reply on this. I ran the warning against ChromeOS and actually found very few false positives and a couple interesting findings to file bugs for. I actually saw about an equal number of cases caught for `&` and `|`. https://source.chromium.org/chro